Commit graph

38746 commits

Author SHA1 Message Date
godofredoc e20e95100d
Add osx_sdk context for mac builds. (#141422)
This is to give ci.yaml the flexibility to select the contexts to execute and remove complexity from recipes.
2024-01-12 03:00:06 +00:00
engine-flutter-autoroll 6cc8b619ad
Roll Flutter Engine from ecdaed76f284 to 44a0a6ee4d39 (18 revisions) (#141432)
ecdaed76f2...44a0a6ee4d

2024-01-12 skia-flutter-autoroll@skia.org Roll Skia from d65d18ac1e8d to e9de42588e54 (1 revision) (flutter/engine#49738)
2024-01-11 matanlurey@users.noreply.github.com Add `SurfaceTextureSurfaceProducer` (flutter/engine#49653)
2024-01-11 skia-flutter-autoroll@skia.org Roll Skia from b63e5a3c14e1 to d65d18ac1e8d (1 revision) (flutter/engine#49735)
2024-01-11 jonahwilliams@google.com [Impeller] Begin migrating to RenderPass command recording API. (flutter/engine#49480)
2024-01-11 15619084+vashworth@users.noreply.github.com Run tests on macOS 13 only (flutter/engine#49722)
2024-01-11 jonahwilliams@google.com [Impeller] dont accidentally copy shared ptr. (flutter/engine#49731)
2024-01-11 skia-flutter-autoroll@skia.org Roll Skia from 56f28f137507 to b63e5a3c14e1 (1 revision) (flutter/engine#49733)
2024-01-11 jason-simmons@users.noreply.github.com Revert Dart SDK to 3245b92a5930 (flutter/engine#49727)
2024-01-11 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from gJuGKaWsKazIrvQeO... to Klxww53tA4-TG5pA9... (flutter/engine#49730)
2024-01-11 103135467+sealesj@users.noreply.github.com Google GitHub mirrors - reland (flutter/engine#49716)
2024-01-11 skia-flutter-autoroll@skia.org Roll Skia from 440f5f849008 to 56f28f137507 (1 revision) (flutter/engine#49723)
2024-01-11 103135467+sealesj@users.noreply.github.com Osv-scanner integration (flutter/engine#49470)
2024-01-11 jason-simmons@users.noreply.github.com [Impeller] Add DrawLine/DrawOval/ClipOval operations to the canvas recorder (flutter/engine#49697)
2024-01-11 skia-flutter-autoroll@skia.org Roll Dart SDK from 7f3ea1c3bc27 to 6f5bd26b293d (1 revision) (flutter/engine#49720)
2024-01-11 dnfield@google.com Try to get GLES tests running... (flutter/engine#49701)
2024-01-11 skia-flutter-autoroll@skia.org Roll Skia from 2a5710618fc3 to 440f5f849008 (1 revision) (flutter/engine#49715)
2024-01-11 skia-flutter-autoroll@skia.org Roll Skia from c46008e5a839 to 2a5710618fc3 (1 revision) (flutter/engine#49712)
2024-01-11 skia-flutter-autoroll@skia.org Roll Dart SDK from 3245b92a5930 to 7f3ea1c3bc27 (1 revision) (flutter/engine#49710)

Also rolling transitive DEPS:
  fuchsia/sdk/core/linux-amd64 from gJuGKaWsKazI to Klxww53tA4-T

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC bdero@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-01-12 02:56:24 +00:00
Bartek Pacia 0a1af8a192
Add support for Gradle Kotlin DSL (#140744)
This PR resolves #140548. It's based on my work in #118067.
2024-01-12 02:20:06 +00:00
Qun Cheng 5887d6c742
Fix typo (#141426) 2024-01-11 17:05:01 -08:00
auto-submit[bot] 66759d7522
Reverts "Run iOS staging tests with Xcode 15.2" (#141412)
Reverts flutter/flutter#141392
Initiated by: QuncCccccc
This change reverts the following previous change:
Original Description:
Potential fix for https://github.com/flutter/flutter/issues/141383.
2024-01-11 22:06:25 +00:00
Victoria Ashworth ef3de359de
Run iOS staging tests with Xcode 15.2 (#141392)
Potential fix for https://github.com/flutter/flutter/issues/141383.
2024-01-11 19:17:38 +00:00
Taha Tesser 8dcae5ace4
Fix ListWheelScrollView in an AnimatedContainer with zero height throw an error (#141372)
fixes [`ListWheelScrollView` Throws Unexpected Error Inside `AnimatedContainer`](https://github.com/flutter/flutter/issues/140780)
fixes [`CupertinoDatePicker` throw exception when parent height is 0](https://github.com/flutter/flutter/issues/55630)

### Code sample

<details>
<summary>expand to view the code sample</summary> 

```dart
import 'package:flutter/material.dart';

void main() => runApp(const MyApp());

class MyApp extends StatelessWidget {
  const MyApp({super.key});

  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      debugShowCheckedModeBanner: false,
      home: Scaffold(
        body: AnimatedContainer(
          height: 0,
          duration: Duration.zero,
          child: ListWheelScrollView(
            itemExtent: 20.0,
            children: <Widget>[
              for (int i = 0; i < 20; i++) Container(),
            ],
          ),
        ),
      ),
    );
  }
}
```

</details>
2024-01-11 18:26:04 +00:00
Andrew Kolos c355219154
make asset_test.dart tests not dependent on context (#141331)
Part of work on https://github.com/flutter/flutter/issues/141330, which is a part of work on https://github.com/flutter/flutter/issues/140092

This is a refactoring; there should be no behavioral changes in these tests.
2024-01-11 18:08:07 +00:00
Gianluca Bettega e281c39164
Expose 'enable' property to allow the user to disable the SearchBar (#137388)
This exposes the `enabled` property of the `TextField` widget to the `Searchbar` widget.

## Related Issues

https://github.com/flutter/flutter/issues/136943

Still missing tests
2024-01-11 17:58:50 +00:00
Jonah Williams 35903620c8
Add impeller key to skia gold client, Turn on a framework test shard that will run unit tests with --enable-impeller (#141341)
Redo of https://github.com/flutter/flutter/pull/140985 due to CLA issues.
2024-01-11 17:57:00 +00:00
Dan Field 9f2e681e7b
[Tool][Impeller] Make impellerc produce Vulkan and GLES shaders for Android. (#140976)
This should wait for some upstream work, just don't want to lose it locally for now. I'll switch this from draft and update the description when it's ready.
2024-01-11 17:49:59 +00:00
engine-flutter-autoroll f5fb61b953
Roll Packages from 378e70006863 to 0744fe6fdb31 (6 revisions) (#141378)
378e700068...0744fe6fdb

2024-01-11 10687576+bparrishMines@users.noreply.github.com [quick_actions_android] Close system dialogs for integration test (flutter/packages#5853)
2024-01-10 49699333+dependabot[bot]@users.noreply.github.com [file_selector]: Bump androidx.annotation:annotation from 1.7.0 to 1.7.1 in /packages/file_selector/file_selector_android/android (flutter/packages#5712)
2024-01-10 49699333+dependabot[bot]@users.noreply.github.com [in_app_pur]: Bump androidx.annotation:annotation from 1.7.0 to 1.7.1 in /packages/in_app_purchase/in_app_purchase_android/android (flutter/packages#5713)
2024-01-10 49699333+dependabot[bot]@users.noreply.github.com [url_launcher]: Bump androidx.annotation:annotation from 1.7.0 to 1.7.1 in /packages/url_launcher/url_launcher_android/android (flutter/packages#5708)
2024-01-10 49699333+dependabot[bot]@users.noreply.github.com [image_picker]: Bump androidx.annotation:annotation from 1.7.0 to 1.7.1 in /packages/image_picker/image_picker_android/android (flutter/packages#5703)
2024-01-10 engine-flutter-autoroll@skia.org Roll Flutter from 126302dfb4 to b840a60d7d (29 revisions) (flutter/packages#5855)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-01-11 15:46:22 +00:00
engine-flutter-autoroll 2216a78095
Roll Flutter Engine from efd0eb62f4aa to ecdaed76f284 (1 revision) (#141359)
efd0eb62f4...ecdaed76f2

2024-01-11 skia-flutter-autoroll@skia.org Roll Skia from 5d4f12f3f12d to c46008e5a839 (1 revision) (flutter/engine#49708)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC bdero@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-01-11 08:51:26 +00:00
engine-flutter-autoroll 60f503db0d
Roll Flutter Engine from ade9f18fa008 to efd0eb62f4aa (2 revisions) (#141356)
ade9f18fa0...efd0eb62f4

2024-01-11 skia-flutter-autoroll@skia.org Roll Skia from e80a6830eb4d to 5d4f12f3f12d (1 revision) (flutter/engine#49706)
2024-01-11 skia-flutter-autoroll@skia.org Roll Skia from ae45496c55e2 to e80a6830eb4d (2 revisions) (flutter/engine#49705)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC bdero@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-01-11 08:09:29 +00:00
engine-flutter-autoroll 3e5cad037c
Roll Flutter Engine from 42e3e0236112 to ade9f18fa008 (2 revisions) (#141337)
42e3e02361...ade9f18fa0

2024-01-11 dnfield@google.com [Impeller] Vulkan runtime effects/fragment program API (flutter/engine#49543)
2024-01-11 skia-flutter-autoroll@skia.org Roll Dart SDK from 9f5a6a2ccace to 3245b92a5930 (1 revision) (flutter/engine#49700)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC bdero@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-01-11 03:42:23 +00:00
engine-flutter-autoroll 085aaa5d63
Roll Flutter Engine from f39f5ca18328 to 42e3e0236112 (2 revisions) (#141327)
f39f5ca183...42e3e02361

2024-01-11 skia-flutter-autoroll@skia.org Roll Skia from 596053dde5f0 to ae45496c55e2 (1 revision) (flutter/engine#49695)
2024-01-10 skia-flutter-autoroll@skia.org Roll Skia from d1fbb9177115 to 596053dde5f0 (1 revision) (flutter/engine#49694)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC bdero@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-01-11 02:13:27 +00:00
engine-flutter-autoroll d1f3ae73eb
Roll Flutter Engine from 431d64dbb4b8 to f39f5ca18328 (1 revision) (#141322)
431d64dbb4...f39f5ca183

2024-01-10 skia-flutter-autoroll@skia.org Roll Skia from 2f254f5d41f2 to d1fbb9177115 (1 revision) (flutter/engine#49692)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC bdero@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-01-11 00:11:02 +00:00
Kate Lovett 9785718031
Add dart fix support to flutter_driver (#141300)
Part of https://github.com/flutter/flutter/issues/139249

This adds dart fix support plus fixes for APIs that are currently deprecated in the flutter_driver package.
2024-01-11 00:07:49 +00:00
Polina Cherkasova 13684ca471
Fix a leak. (#141312) 2024-01-11 00:00:10 +00:00
Kate Lovett a94c14e063
Add covariants to reduce subclass casts in 2D APIs (#141318)
While working in https://pub.dev/packages/two_dimensional_scrollables, I found I could eliminate some casts if we added covariants here in the framework.
Much of the 2D aPI in the framework is abstract, so I think it make sense to add these and make it easier/cleaner for subclasses using the APIs.
I made a similar change in https://github.com/flutter/flutter/pull/131358, this would cover all of the cases I could find so its nice and accommodating now.
2024-01-10 23:28:48 +00:00
engine-flutter-autoroll 30b0f729d6
Roll Flutter Engine from a045134c910d to 431d64dbb4b8 (2 revisions) (#141316)
a045134c91...431d64dbb4

2024-01-10 jonahwilliams@google.com [Impeller] reland: write directly to device buffer. (flutter/engine#49691)
2024-01-10 skia-flutter-autoroll@skia.org Roll Dart SDK from c2862d44e108 to 9f5a6a2ccace (1 revision) (flutter/engine#49689)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC bdero@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-01-10 23:25:09 +00:00
engine-flutter-autoroll f961fdf2ba
Roll Flutter Engine from 6810c9a57460 to a045134c910d (2 revisions) (#141313)
6810c9a574...a045134c91

2024-01-10 98614782+auto-submit[bot]@users.noreply.github.com Reverts "[Impeller] have Hostbuffer write directly to block allocated device buffers." (flutter/engine#49688)
2024-01-10 skia-flutter-autoroll@skia.org Roll Skia from 0443e02cdfd3 to 2f254f5d41f2 (1 revision) (flutter/engine#49685)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC bdero@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-01-10 22:37:07 +00:00
Justin McCandless 865825c3c1
Call onPopInvoked when pages API is used (#141221)
(Predictive Back) Fixes a bug where when using PopScope and Navigator.pages together, onPopInvoked wasn't being called.
2024-01-10 14:29:30 -08:00
Polina Cherkasova 420b15a75a
Fix mechanism to pass flag for leak tracking. (#141226) 2024-01-10 22:08:06 +00:00
engine-flutter-autoroll 94e7c9fc75
Roll Flutter Engine from 5d252831e62c to 6810c9a57460 (2 revisions) (#141308)
5d252831e6...6810c9a574

2024-01-10 jason-simmons@users.noreply.github.com [Impeller] Make the shaders loaded by the GLES playground consistent with other playgrounds (flutter/engine#49684)
2024-01-10 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from pUQrgMfXgU8RmLuL4... to gJuGKaWsKazIrvQeO... (flutter/engine#49682)

Also rolling transitive DEPS:
  fuchsia/sdk/core/linux-amd64 from pUQrgMfXgU8R to gJuGKaWsKazI

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC bdero@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-01-10 21:49:10 +00:00
engine-flutter-autoroll d9545c002a
Roll Flutter Engine from 6cb256fc4985 to 5d252831e62c (1 revision) (#141302)
6cb256fc49...5d252831e6

2024-01-10 skia-flutter-autoroll@skia.org Roll Skia from 334160c0eede to 0443e02cdfd3 (2 revisions) (flutter/engine#49681)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC bdero@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-01-10 21:02:54 +00:00
engine-flutter-autoroll 612ad45abb
Roll Flutter Engine from 52aedc6c9153 to 6cb256fc4985 (1 revision) (#141297)
52aedc6c91...6cb256fc49

2024-01-10 skia-flutter-autoroll@skia.org Roll Dart SDK from b3d7097aa10f to c2862d44e108 (1 revision) (flutter/engine#49677)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC bdero@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-01-10 20:08:26 +00:00
Polina Cherkasova 34f1f5f19e
Improve testing for leak tracking. (#140553) 2024-01-10 11:04:28 -08:00
engine-flutter-autoroll 0409a55076
Roll Flutter Engine from d1a2007a28b4 to 52aedc6c9153 (2 revisions) (#141291)
d1a2007a28...52aedc6c91

2024-01-10 jonahwilliams@google.com [Impeller] have Hostbuffer write directly to block allocated device buffers. (flutter/engine#49505)
2024-01-10 skia-flutter-autoroll@skia.org Roll Skia from 9271dcdade42 to 334160c0eede (1 revision) (flutter/engine#49675)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC bdero@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-01-10 18:57:50 +00:00
Christopher Fujino 0f5cd7855d
[flutter_tools] fix flutter create -t skeleton (#141233)
Fixes https://github.com/flutter/flutter/issues/139138

This had been broken since https://github.com/flutter/flutter/pull/130090 merged, however, the test happened run with flutter_tools/pubspec.yaml in the current working directory.
2024-01-10 18:50:07 +00:00
engine-flutter-autoroll 1f11f13e21
Roll Flutter Engine from b361a60ae224 to d1a2007a28b4 (1 revision) (#141285)
b361a60ae2...d1a2007a28

2024-01-10 skia-flutter-autoroll@skia.org Roll Dart SDK from efd053daa2a6 to b3d7097aa10f (1 revision) (flutter/engine#49673)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC bdero@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-01-10 18:13:26 +00:00
Derek Xu eff2e7dbb1
Unpin package:vm_service (#141279) 2024-01-10 12:47:25 -05:00
stuartmorgan 267ca02db2
Collapse pubspec.lock by default (#141282)
We recently added `open` to this as part of changing all the templates, but the lock file is often quite large, and is often ancillary to the important issues details (unlike cases like code or screenshots), so it's better to leave this one collapsed by default.
2024-01-10 17:35:21 +00:00
engine-flutter-autoroll ee4afd7179
Roll Packages from 09205ca19bd2 to 378e70006863 (2 revisions) (#141275)
09205ca19b...378e700068

2024-01-09 engine-flutter-autoroll@skia.org Roll Flutter from c6ddb73f97 to 126302dfb4 (32 revisions) (flutter/packages#5852)
2024-01-09 49699333+dependabot[bot]@users.noreply.github.com Bump github/codeql-action from 3.22.12 to 3.23.0 (flutter/packages#5849)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-01-10 15:45:31 +00:00
engine-flutter-autoroll b840a60d7d
Roll Flutter Engine from 3269fd84460d to b361a60ae224 (1 revision) (#141271)
3269fd8446...b361a60ae2

2024-01-10 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Migrate to Flutter mirrors for Google-owned Github repositories" (flutter/engine#49671)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC bdero@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-01-10 14:27:25 +00:00
engine-flutter-autoroll b73b460ebd
Roll Flutter Engine from a5d446da5495 to 3269fd84460d (1 revision) (#141264)
a5d446da54...3269fd8446

2024-01-10 skia-flutter-autoroll@skia.org Roll Skia from 51a0ad17b147 to 9271dcdade42 (1 revision) (flutter/engine#49669)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC bdero@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-01-10 11:59:18 +00:00
engine-flutter-autoroll 2df75b735a
Roll Flutter Engine from 3ccf66bed335 to a5d446da5495 (2 revisions) (#141252)
3ccf66bed3...a5d446da54

2024-01-10 skia-flutter-autoroll@skia.org Roll Dart SDK from d4b1939dffa6 to efd053daa2a6 (1 revision) (flutter/engine#49666)
2024-01-10 skia-flutter-autoroll@skia.org Roll Skia from ae30afc7b79a to 51a0ad17b147 (1 revision) (flutter/engine#49665)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC bdero@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-01-10 10:31:08 +00:00
engine-flutter-autoroll 3d5b200916
Roll Flutter Engine from e57e418c02ae to 3ccf66bed335 (1 revision) (#141241)
e57e418c02...3ccf66bed3

2024-01-10 skia-flutter-autoroll@skia.org Roll Skia from 2a77dffd384f to ae30afc7b79a (1 revision) (flutter/engine#49663)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC bdero@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-01-10 08:35:11 +00:00
engine-flutter-autoroll b23cf316bf
Roll Flutter Engine from 7e6f3d847e01 to e57e418c02ae (1 revision) (#141240)
7e6f3d847e...e57e418c02

2024-01-10 matanlurey@users.noreply.github.com Follow various best practices in `FlutterRenderer` (flutter/engine#49651)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC bdero@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-01-10 07:48:04 +00:00
engine-flutter-autoroll a103002496
Roll Flutter Engine from 1cf2e0a603c7 to 7e6f3d847e01 (1 revision) (#141237)
1cf2e0a603...7e6f3d847e

2024-01-10 skia-flutter-autoroll@skia.org Roll Skia from 0e8023dc0a1a to 2a77dffd384f (1 revision) (flutter/engine#49662)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC bdero@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-01-10 07:02:12 +00:00
engine-flutter-autoroll eeebee623e
Roll Flutter Engine from 32bbf8be8d2c to 1cf2e0a603c7 (1 revision) (#141232)
32bbf8be8d...1cf2e0a603

2024-01-10 skia-flutter-autoroll@skia.org Roll Dart SDK from 727ea68c62d8 to d4b1939dffa6 (1 revision) (flutter/engine#49657)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC bdero@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-01-10 03:25:40 +00:00
engine-flutter-autoroll 3bcf779f32
Roll Flutter Engine from 5b9d2132b7cd to 32bbf8be8d2c (1 revision) (#141229)
5b9d2132b7...32bbf8be8d

2024-01-10 skia-flutter-autoroll@skia.org Roll Skia from 4ef1837c2958 to 0e8023dc0a1a (1 revision) (flutter/engine#49655)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC bdero@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-01-10 02:40:32 +00:00
engine-flutter-autoroll 9c3e6ef278
Roll Flutter Engine from 941f268fc8bb to 5b9d2132b7cd (1 revision) (#141228)
941f268fc8...5b9d2132b7

2024-01-10 jacksongardner@google.com Refactor flutter.js to do dart2wasm bootstrapping and CanvasKit/Skwasm preloading. (flutter/engine#49037)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC bdero@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-01-10 01:51:25 +00:00
engine-flutter-autoroll 92f2df562c
Roll Flutter Engine from 542fea9edae4 to 941f268fc8bb (3 revisions) (#141224)
542fea9eda...941f268fc8

2024-01-09 30870216+gaaclarke@users.noreply.github.com [Impeller] made sure to scale the blur radius by the effect transform (flutter/engine#49645)
2024-01-09 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Refactors RBE support" (flutter/engine#49654)
2024-01-09 zanderso@users.noreply.github.com Refactors RBE support (flutter/engine#49416)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC bdero@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-01-10 01:07:14 +00:00
Igor Hnízdo 7efed85b35
NestedScrollView's outer scrollable jumping with BouncingScrollPhysics due to double precision errors (#138319)
This PR fixes scrolling issues with `NestedScrollView` using the `BouncingScrollPhysics`. In one of the steps of the calculation, we can reach a state where the position of the inner scrollable is set to a `double` value that falls within `precisionErrorTolerance` of `0` but we were using `==` with `0` rather than checking for a precision. My posts in the linked issue show the current behavior, and how I reached to conclusion (the code in this PR). This PR only addresses the "jumping" of the outer scrollable.  

Fixes #136199

I have not finished a test for this since I have never done so and therefore have 0 experience writing tests in Flutter, so any help there would be appreciated. I am also not sure how to test double precision errors in general. I did run all the nested_scroll_view_tests.dart locally and there are no failures.
2024-01-10 00:28:09 +00:00
engine-flutter-autoroll 34e8890eec
Roll Flutter Engine from 8c1501f3956d to 542fea9edae4 (1 revision) (#141217)
8c1501f395...542fea9eda

2024-01-09 31859944+LongCatIsLooong@users.noreply.github.com Fix macOS text composing (flutter/engine#49314)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC bdero@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-01-10 00:17:35 +00:00
Polina Cherkasova 0f2618ff4f
Fix or except leaks. (#141081)
Contributes to https://github.com/flutter/devtools/issues/6909.
2024-01-10 00:17:33 +00:00
engine-flutter-autoroll e58f43fb23
Roll Flutter Engine from 693af0c699c5 to 8c1501f3956d (1 revision) (#141215)
693af0c699...8c1501f395

2024-01-09 matanlurey@users.noreply.github.com Make `shell/platform/android` IDE-friendly, and add documentation (flutter/engine#49612)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC bdero@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-01-09 23:37:17 +00:00
Chris Bobbe 8d2aca385f
TextStyle: In copyWith, stop ignoring debugLabel when receiver has none (#141141)
Fixes #141140.

This ensures that if you call `.copyWith` and pass a `debugLabel`, the `debugLabel` won't be ignored, even if the receiver (the TextStyle you're calling `.copyWith` on) doesn't have a `debugLabel`.

The debugLabel field was added in #12552. I skimmed the discussion there and didn't find anything indicating that the param was being ignored on purpose.

I added a test case that passes with the new code and fails with the old code.
2024-01-09 23:21:24 +00:00
engine-flutter-autoroll 84e1086c4e
Roll Flutter Engine from a35e3b026e1d to 693af0c699c5 (5 revisions) (#141209)
a35e3b026e...693af0c699

2024-01-09 skia-flutter-autoroll@skia.org Roll Dart SDK from 721fccffc708 to 727ea68c62d8 (1 revision) (flutter/engine#49647)
2024-01-09 skia-flutter-autoroll@skia.org Roll Skia from 77534b672363 to 4ef1837c2958 (1 revision) (flutter/engine#49643)
2024-01-09 skia-flutter-autoroll@skia.org Roll Skia from 8c8be76a62c0 to 77534b672363 (1 revision) (flutter/engine#49641)
2024-01-09 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from 6z4cZ6HUidtgmhvdk... to pUQrgMfXgU8RmLuL4... (flutter/engine#49640)
2024-01-09 bdero@google.com [Flutter GPU] Track HostBuffer emplacements by offset. (flutter/engine#49618)

Also rolling transitive DEPS:
  fuchsia/sdk/core/linux-amd64 from 6z4cZ6HUidtg to pUQrgMfXgU8R

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC bdero@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-01-09 22:51:14 +00:00