Commit graph

12958 commits

Author SHA1 Message Date
Dan Field d8d36bc7e8
targetSdkVersion 28 (#26798) 2019-01-19 11:59:42 -08:00
Mehmet Fidanboylu c8379ad54f
Better ListTile leading/trailing widget alignment (#26778) 2019-01-19 11:55:05 -08:00
Todd Volkert db7e4fbbc4 Fix test expectations per change made in #26736 (#26809) 2019-01-19 11:32:48 -08:00
Ian Hickson 31a9626c48
[O] Removing all timeouts (mark II) (#26736)
These are essentially self-inflicted race conditions. Instead of timeouts we're going to try a more verbose logging mechanism that points out when things are taking a long time.
2019-01-19 00:31:05 -08:00
engine-flutter-autoroll fa79c8137d Roll engine 4acfced383b6..898b4f8da4ef (8 commits) (#26792)
* d470fc65e Roll src/third_party/skia 31972f889641..57263c2e0ccd (3 commits) (flutter/engine#7529)

* 11aa5e628 Roll src/third_party/dart da09945643..ac1bf656c4 (22 commits) (flutter/engine#7527)

* a0b4d6b61 Configure the embedder in AOT in "profile" and "release" runtime modes. (flutter/engine#7533)

* 2cf1181e5 Roll src/third_party/dart ac1bf656c4..2e5453ddb4 (42 commits) 2e5453ddb4 [ VM ] Updated licenses to match other licenses in project 3d71abcada Prepare to publish a new version of the analyzer_plugin package with an updated dependency on analyzer ebf319b64b Clean up some lingering references to type propogation be47aad327 [VM/Compiler/AOT] Bare instructions 9: Improve write barrier on ARM/ARM64/X64 10f63f806d [gardening] Mark io/stdout_stderr_non_blocking_test flaky on x64 8b214f4d72 Restore type parser from reify project 65dde13f1b Don't check formatting of Front-End test cases 53217e6eb1 [kernel] Add ability to (de)serialize DirectMethodInvocation 5048889c54 [kernel] Add ability to (de)serialize StaticInvocation 7ea2dfad20 [kernel] Add ability to (de)serialize DirectPropertySet 50c06c55ba [kernel] Add ability to (de)serialize DirectPropertyGet 793fbc0d4a [kernel] Add ability to (de)serialize StaticSet 581af6eb56 [co19] DEPS and status file updated b0017d758c Refer to correct locations in SDK (and other dill files) da6938a5b2 After some more `git cl uploads`, this fixes a bunch of little problems in the spec that we have noted over time. c9a55b437a [Kernel] Remove the dedicated fromEnvironment constants 1a0367a373 Create test which demonstrates issues 35558 and 35559 6205d7e82c [kernel] Add ability to (de)serialize StaticGet e529988474 [kernel] Rename ScopedReference to ScopedUse f437fa02c2 [kernel] Nest *Environment into *State for (de)serialization 0dea413d94 Tests for reachability, fix for try/finally. e3302cdb8f Follow-up to storing problems in the ast dd04c374b8 [vm,dart:io] On Linux, Android, and Fuchsia the getsockopt parameter is incorrect. e64428a839 Revert "[vm] Cleanup Dart_Get/Set/HasStickyError API and use isolate's sticky error only as a backup for thread's sticky error" 324718fadd [vm] Revert "Restore TLABs." 5a607755b2 [ VM / dart:io ] Fixed issue where writing to a socket after it has been closed would raise SIGPIPE and crash the process. 6b5e8603d5 Reland "[vm/compiler] AOT inline heuristics improvements" 06a1e6e9e3 [vm] Enable timeline on Fuchsia even in product mode. 2faab1d4c0 Update AstBuilder to build spread collection AST structures b10f179608 [vm] Cleanup Dart_Get/Set/HasStickyError API and use isolate's sticky error only as a backup for thread's sticky error 5b1daaac6c Exposes a thin layer over getsockopt/setsockopt for supported platforms. c701e76506 [vm/compiler] handle non-nullable null situation better b692a6d183 Improvements for flow analysis. fc62cf0373 [infra] Fix co19 git URL in DEPS e7bd3edc9f [vm] Assert callback state for all Dart_Set*ReturnValue, take 2. ddce2824fa Add more spread collection fasta test cases 6639cbd6c3 Add AstBuilder spread-collections and control-flow-collections flags 1020a22290 [dart2js] Do more native method inlining f353719b08 Ignore unnecessary_cast hint. 3513f872ce Extract DartFileEditBuilder.importLibrary() into separate file. 46080dd886 Update DEPS to check out co19 tests from dart.googlesource.com ca2db2ad53 [VM/Compiler/AOT] Bare instructions 8: Improve AOT code by using pc-relative calls

* d5d6bd2c5 Fix suspicious typo "painted" to "paint" (flutter/engine#7530)

* d89f3b059 Roll src/third_party/skia 57263c2e0ccd..5c7a3ac0e214 (15 commits) (flutter/engine#7536)

* 75cfebde0 Roll buildroot and update method of getting android SDK and support libs (flutter/engine#7284)

* 898b4f8da Allow embedders to specify AOT snapshot buffers. (flutter/engine#7538)
2019-01-18 23:30:04 -08:00
Dan Field e1f5ee36b2
Update VERSION_WIN_SDK (#26797)
Make sure we get latest build tools/platform for Windows.  It wasn't previously failing, but now is.  Similar changes made to Linux/Mac recently.
2019-01-18 21:56:39 -08:00
Dan Field e5eab66e9c
Update VERSION_LINUX_SDK (#26795)
Fix mistaken file extension inclusion

Will land TBR @mklim or @Hixie
2019-01-18 20:59:04 -08:00
Dan Field f02f4fbed3
Rev Android Platform to 28 for bots (#26790)
* Rev Android Platform to 28 for bots

* push all to 28

* include platform tools update
2019-01-18 20:39:10 -08:00
jslavitz 7751144c23
Revert switch drag behavior (#26770) 2019-01-18 13:13:35 -08:00
Hans Muller 43bf66a9ab
Close the Scaffold drawer in scroll_perf_test.dart (#26763) 2019-01-18 12:44:50 -08:00
rami-a 1b0f2015a2
Fix lerp in textTheme to allow for null parameters (#26764)
There's no reason to disallow this as TextStyle can handle lerping between null parameters just fine. This change also adds tests to ensure the correct behavior
2019-01-18 14:28:30 -05:00
Alexander Aprelev 07c592d901
Report early error if appropriate host local engine is not found. (#26766) 2019-01-18 11:26:54 -08:00
MH Johnson 5d0c1b86ee
[Material] Inline the single Theme.of(context) call in BAB (#26765) 2019-01-18 14:13:14 -05:00
xster b531b8f507
Use Cirrus image's fastlane instead of freezing our own set of gem dependencies (#26737) 2019-01-18 10:37:35 -08:00
Jonah Williams 8c5a41113e
Add support for reverse to ReorderableListView (#26203) 2019-01-18 10:10:44 -08:00
Jonah Williams 830c0dfe83
Allow attaching to profile builds (#26720) 2019-01-18 10:09:44 -08:00
Greg Spencer 179fa90489
Fix some doc references (#26441) 2019-01-18 10:07:55 -08:00
Liam Appelbe 9eada88b3e
Experimental flags in flutter (#26715)
* exp flags in flutter

* Fix test failures
2019-01-18 09:07:14 -08:00
jslavitz 4fe79442c8 Reverts default DragStartBehavior to DragStartBehavior.down (#26734) 2019-01-17 19:36:48 -08:00
Dan Field 563972ecac
Roll engine to d470fc65ea1cb91ae66706b320d82c4536a4da8b (#26727)
* Roll engine to d470fc65ea1cb91ae66706b320d82c4536a4da8b

d470fc65e Roll src/third_party/skia 31972f889641..57263c2e0ccd (3 commits) (flutter/engine#7529)
4acfced38 Ensure the ResourceContext is not ripped out from under dart (flutter/engine#7528)
270e9a78a Roll src/third_party/skia a4e46804946c..31972f889641 (8 commits) (flutter/engine#7526)
e98437248 Roll src/third_party/skia 33b4b4908b7a..a4e46804946c (1 commits) (flutter/engine#7524)
4c135c298 Revert "Wrap the user entrypoint function in a zone with native exception callback. (flutter/engine#7512)" (flutter/engine#7522)
0a080a1e0 Roll src/third_party/dart 700254996f..da09945643 (14 commits) da09945643 Update dartfix pubspec before publishing b81c1b2095 Parse spread collections in map literals 1b0d93366d Add list literal spread collection fasta test cases 6c2ea4936a Clean up several deprecation hints 07f95e7761 Revert "[vm] Enable timeline on Fuchsia even in product mode." 9cdce03e16 [dart2js] Improve null receiver guard removal near JS code c3599a9d8c Revert "[vm, isolate] Fix length truncation in message snapshots." 95e10c336f Revert "[vm] Assert callback state for all Dart_Set*ReturnValue." 3f7b371f2c [vm] Enable timeline on Fuchsia even in product mode. 4b22195ea1 [vm, isolate] Fix length truncation in message snapshots. a353b1172a [vm, compiler] Remove TAG_IC_DATA, which has since been subsumed by RebindRule. ca12afec50 [vm] Assert callback state for all Dart_Set*ReturnValue. 2028006a25 [Observatory] Updated Dart icon to new colour scheme 84273b9f36 Improvements for flow analysis.
fff537777 Roll src/third_party/skia 25b9f192ed8c..33b4b4908b7a (1 commits) (flutter/engine#7520)
a58cc3960 Roll src/third_party/skia 1ce80fb351a2..25b9f192ed8c (5 commits) (flutter/engine#7517)
52e0e9da5 Roll src/third_party/skia 081e6f375497..1ce80fb351a2 (12 commits) (flutter/engine#7514)
25559ed07 Wrap the user entrypoint function in a zone with native exception callback. (flutter/engine#7512)
1b0d09b21 Roll src/third_party/dart f701e11756..700254996f (5 commits) 700254996f [ Observatory / Dartium ] Updated observatory documentation and tests to remove references to Dartium. 78abb98ee7 [vm/bytecode] Fix AST removal for package-split kernel files with bytecode 0075b58bb8 CHANGELOG entry for DEPRECATED_MEMBER_USE split a5f102a7d1 Analyzer: first pass at reporting unchecked nullable value usage. a10ddca1b1 [ VM / Service ] Allow for `profile_period` flag to be set via the service protocol
e7ade51da Remove unused headers (flutter/engine#7511)
369b4db35 Roll src/third_party/skia 1374c85fbf53..081e6f375497 (6 commits) (flutter/engine#7510)
366d44e11 Roll src/third_party/dart 9b5eabdaca..f701e11756 (10 commits) f701e11756 [ VM / Debugger ] Fix issue where a 'Step' command issued when there's no stack caused a crash. c5bfccc6fb Make downloading the LSP spec a flag and commit the version parsed locally dbeec3bbf3 Fix formatting in generated LSP file header bfe15d87d8 Fix LSP exceptions serializing ResponseErrors with Uris 7984dc4fcc Prepare to publish analyzer version 0.34.2. 4b1b2f9176 Switch LSP formatter to not fetch resolved ASTs that aren't used 5ce5d697da Implement LSP code folding b47524d5b0 Ensure all unhandled exceptions are recorded on the server 8ba2de2344 Sort context for conflicting inherited members 215f6620e7 [Kernel] Signal errors on static fields in constant contexts
2019-01-17 17:03:12 -08:00
Jason Simmons f4c5e3eef2
[Gradle] Copy ICU data to flutter_shared only when building an AAR module (#26668)
This is based on 9880baa396
but will support building APKs with --local-engine
2019-01-17 16:33:14 -08:00
MH Johnson 6c07863f8d
[Material] Refactor _build<Widget> methods in BottomNavBar (#26722) 2019-01-17 19:02:34 -05:00
Chinmay Garde 9f72c5fbb4 Remove incorrect Coveralls badge. (#26550)
The code coverage for the repository seems to be ~85% while the coverage reported by the Coveralls badge is 100%.
2019-01-17 15:53:43 -08:00
Konstantin Pozin 29fb6159db [flutter_localizations] Add BUILD.gn for flutter_localizations (#26440) 2019-01-17 15:47:57 -08:00
mcplectrum b4daf33807 Fix Podfile issue #24342 (#25079)
* Fix Podfile issue #24342

Sometimes base configurations  (config.base_configuration_reference) can be nil, which leads to undefined method `real_path' for nil:NilClass.

* Disable bitcode in every case
2019-01-17 15:00:51 -08:00
Michael Goderbauer 45a70efa8a
Respect EditableText.keyboardAppearance (#26721) 2019-01-17 14:54:35 -08:00
Will Larche 60e9c5856d
[FAB] Adding FAB as class in tests. (#26192)
* [FAB] Adding FAB as class in tests.

* [Material] FAB theme tests corrected. Also deeper into Material for elevation testing.

* [Material] Comment clarification.

* [Material] TODO formatting.

* [Material] Formatting.

* [Material] Comment correction.

* [Material] Updated values.

* [Material] Removing comment, low-level check, and adding safety.
2019-01-17 14:39:22 -08:00
Stanislav Baranov eb8219edd5
Emulator support for dynamic mode on Intel architecture (#26565) 2019-01-17 14:21:35 -08:00
David Shuckerow 9e4c964072
Add animation tests for changes to the FloatingActionButtonLocation (#23677)
* Add more animation tests for rotation

* Test animation progress

* Progress on the tests

* Everything 'works'

* We don't need to guarantee the rotation of the fab as it exits.

* Remove print statement

* Cleanup extra lines

* Remove whitespace
2019-01-17 14:48:28 -06:00
Michael Goderbauer 975ea595e9
Fix missing const analyzer warning (#26716)
Introduced by merging an old PR (https://github.com/flutter/flutter/pull/21157).
2019-01-17 12:23:55 -08:00
Remi Rousselet 649f49d4bf Swap scope with gesture (#21157) 2019-01-17 11:11:35 -08:00
Michael Goderbauer 56039b4ba7
Make getOffsetToReveal work with nested Viewports (#26663)
Fixes #20893, the most-upvoted bug for framework.

A detailed analysis explaining the cause of the bug has been posted at #20893 (comment).
2019-01-17 11:03:07 -08:00
Gazihan Alankus 7e22b5f2c5 Doc fix: SliverChildBuilderDelegate is the lazy one (#26690) 2019-01-17 09:51:50 -08:00
Jonah Williams fb2467d0af
Add documentation for how to use annotated region (#24989) 2019-01-17 09:30:05 -08:00
abykov2 3c0a74ef0f Adding a shutdown hook to HotRunnerConfig (#26604) 2019-01-17 08:49:02 -08:00
Kenzie Schmoll 33bfa6a7c5
Register hotRestart service in flutter_tools. (#26669)
* Register hot restart service in flutter_tools.
2019-01-17 08:28:54 -08:00
Danny Tuppeny 244b077bee
Give integration tests unique temp folder names (#26227)
This will help track down any that aren't cleaning up and also may help track down leaked flutter_tester processes (https://github.com/dart-lang/sdk/issues/35549).
2019-01-17 11:29:18 +00:00
Dan Field c74b59a5b8
Roll engine back to 1e93a8eb39d79f643952737aa4fc31e1787a5a17 (#26694) 2019-01-17 00:31:56 -08:00
engine-flutter-autoroll 9b60ad4cd8
Roll engine 3c0aa918de87..25559ed07796 (11 commits) (#26683)
3c0aa918de...25559ed077

git log 3c0aa918de8782ed73b12fc148c4ab7cb6ed1416..25559ed0779604d56c47c5d2341ffd16b137cd10 --no-merges --oneline
25559ed07 Wrap the user entrypoint function in a zone with native exception callback. (flutter/engine#7512)
1b0d09b21 Roll src/third_party/dart f701e11756..700254996f (5 commits) 700254996f [ Observatory / Dartium ] Updated observatory documentation and tests to remove references to Dartium. 78abb98ee7 [vm/bytecode] Fix AST removal for package-split kernel files with bytecode 0075b58bb8 CHANGELOG entry for DEPRECATED_MEMBER_USE split a5f102a7d1 Analyzer: first pass at reporting unchecked nullable value usage. a10ddca1b1 [ VM / Service ] Allow for `profile_period` flag to be set via the service protocol
e7ade51da Remove unused headers (flutter/engine#7511)
369b4db35 Roll src/third_party/skia 1374c85fbf53..081e6f375497 (6 commits) (flutter/engine#7510)
366d44e11 Roll src/third_party/dart 9b5eabdaca..f701e11756 (10 commits) f701e11756 [ VM / Debugger ] Fix issue where a &#39;Step&#39; command issued when there&#39;s no stack caused a crash. c5bfccc6fb Make downloading the LSP spec a flag and commit the version parsed locally dbeec3bbf3 Fix formatting in generated LSP file header bfe15d87d8 Fix LSP exceptions serializing ResponseErrors with Uris 7984dc4fcc Prepare to publish analyzer version 0.34.2. 4b1b2f9176 Switch LSP formatter to not fetch resolved ASTs that aren&#39;t used 5ce5d697da Implement LSP code folding b47524d5b0 Ensure all unhandled exceptions are recorded on the server 8ba2de2344 Sort context for conflicting inherited members 215f6620e7 [Kernel] Signal errors on static fields in constant contexts
1e93a8eb3 Deprecate FlutterProjectArgs.main_path, packages_path (flutter/engine#7497)
b058920ca Edit the bundleid so that it conform to UIT specifications. (flutter/engine#7503)
32c9ae616 Roll src/third_party/skia 2c379d8e27e6..1374c85fbf53 (4 commits) (flutter/engine#7508)
96d10b184 Roll src/third_party/dart 492df72739..9b5eabdaca (8 commits) 9b5eabdaca Fix crash in color support a533753bec Remove --fast-startup flag support from testing scripts and status files 5f10aed19c [Kernel] Don&#39;t print static fields in instance constants bdb51e2837 Improve input path handling and remove extra schemas. 0604110806 Reduce expectations on thrown exception 966e007b63 Pass CallStructure on dynamic and static use in ResolutionWorldBuilder 3e7801294e Remove unneeded code in OrderedTypeSet 8a91948c03 [Kernel] Properly signal compilation errors for constants
770984088 Roll src/third_party/skia a8694cc150a1..2c379d8e27e6 (1 commits) (flutter/engine#7506)
046ddc68d Roll src/third_party/skia 47b7cd9a6baf..a8694cc150a1 (1 commits) (flutter/engine#7504)

The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff (bmparr@google.com), and stop
the roller if necessary.
2019-01-16 23:34:39 -05:00
Jonah Williams 83b9497c69
do not exit tool if fuchsia workflow fails (#26589) 2019-01-16 17:43:01 -08:00
Ian Hickson 800a6e1670 Quick fix for tap-to-show-keyboard regression (#26629)
* Fixes Android keyboard bug
2019-01-16 17:30:26 -08:00
Dan Field 4c99958df6
Revert "Move flutter_assets to App.framework (#26630)" (#26675)
This reverts commit d8db70af1a.
2019-01-16 16:46:37 -08:00
Luca Zuccarini 36a493602c Create an injectable factory for application packages. (#26422) 2019-01-16 14:12:47 -08:00
Dan Field d8db70af1a
Move flutter_assets to App.framework (#26630)
* move flutter_assets to App.framework

* remove flutter_assets references from all pbxproj files checked in
2019-01-16 14:02:54 -08:00
Vyacheslav Egorov 8f65ee9f53
Fix --build-shared-library on newer NDKs (#26642)
Newer NDKs switched to clang which by default uses system linker, instead
we need to force it to use appropriate toolchain linker by passing
-fuse-ld= command line flag.

Fixes #23458
2019-01-16 21:30:37 +01:00
Kenzie Schmoll a172de0159
Send ServiceExtensionToggled event when service extension is set to a value. (#26426) 2019-01-16 12:29:20 -08:00
Vyacheslav Egorov 7c434a5cf2
Revert "Add flutter_shared assets to module artifact (#23782)" (#26644)
This reverts commit 9880baa396.

Reason for revert: broke `--local-engine` command line option.
2019-01-16 21:23:18 +01:00
Kyrel Jerome a0f58c5e7a Grammatical fix: "places" to "placed" (#26482) 2019-01-16 10:43:29 -08:00
Chris Bracken 9a7b1a73bd
Replace platform check with swtich (#24752)
Generally, we should always use default-less switches for
platform-specific behaviour so we're forced to make a conscious decision
on each instance of such behaviour any time we add support for a new
platform.
2019-01-16 10:31:44 -08:00
MH Johnson 5e8e39723d
[Material] TabBarTheme text style parameters (#26533)
* Add labelStyle + unselectedLabelStyle to TabBarTheme
2019-01-16 13:30:21 -05:00