Commit graph

15335 commits

Author SHA1 Message Date
Greg Spencer d6938c56d9
Adds canRequestFocus toggle to FocusNode (#38704)
* Add an 'unfocusable' focus node to allow developers to indicate when they don't want a Focus widget to be active

* more unfocusable changes. not working.

* Switch to focusable attribute

* Rename to canRequestFocus

* Turn off debug output

* Update docs

* Removed unused import
2019-08-16 15:27:49 -07:00
Yegor 34c692659e
Teach render objects to reuse engine layers (#36402)
Teach Layer and its implementations, RenderObject and its implementations, and PaintingContext to reuse engine layers. The idea is that a concrete RenderObject creates a Layer and holds on to it as long as it needs it (i.e. when it is composited, and the layer type does not change). In return, each Layer object holds on to an EngineLayer and reports it to the engine via addRetained and oldLayer. This allows the Web engine to reuse DOM elements across frames. Without it, each frame drops all previously rendered HTML and regenerates it from scratch.
2019-08-16 15:27:12 -07:00
Michel Feinstein 1a5e4a5d7f Adds the arrowColor option to UserAccountsDrawerHeader (#38608) (#38636)
Changes a hard-coded value to a controllable parameter.
2019-08-16 15:14:14 -07:00
Chris Yang 09f6515b73
PlatformViewLink: Rename CreatePlatformViewController to CreatePlatformViewCallback (#38710) 2019-08-16 14:24:01 -07:00
Kate Lovett cac8fa5da0
Re-land 'Adding physicalDepth to MediaQueryData & TestWindow' (#38546) 2019-08-16 13:34:23 -07:00
Nurhan Turgut c2e2f093ec
Navigator change backup (#38494)
* Broadcasting popRoute and pushRoute methods via SystemChannels.navigation. These messages will be used in flutter_web to detect the route

* Broadcasting popRoute and pushRoute methods via SystemChannels.navigation. These messages will be used in flutter_web to detect the route

* Reverting all unrelated formatting changes.

* Adding unit tests. Adding more comments.

* Changing string method names with constant strings.

* Fixing a constant strings.

* Fixing analyzer error.

* Fixing more white space.

* Changing the method names. Adding comments to the SystemChannels

* Comment and code name fixes

* replacing the comment with reviewer suggestion.

* addinf systemchannels.navigation mock to test bindings

* Adding a new class for sending route change notrifications. The nottifications are only sent on web. This should fix breaking android/ios

* using new class RouteNotificationMessages in navigator

* Fixing analyzer issues.

* fixing cycle dependency

* fixing github analyze error

* dartfmt two new classes. trying to fix anayze errors

* Update route_notification_messages.dart

* trying to fix white space errors
2019-08-16 13:17:45 -07:00
Tong Wu b7bab3c2f0
Fix Catalina hot reload test by specifying the platform is iOS. (#38708) 2019-08-16 12:30:30 -07:00
Chris Yang 0b087a898a
PlatformViewLink: update cached surface to be Widget type (#38639) 2019-08-16 11:23:21 -07:00
Shi-Hao Hong ff0eca6463
Toggle buttons docs (#38635)
* Add toggle buttons assets

* Reorder video location, reduce height of videos

* Reduce height of toggle buttons assets
2019-08-16 14:19:54 -04:00
brandondiamond c161ac898c Fix typos / errors in doc comments (#38558) 2019-08-16 11:18:39 -07:00
Greg Spencer a11d73148c
Automatic focus highlight mode for FocusManager (#37825)
This adds a FocusHighlightMode to the FocusManager that switches based on the type of input that has recently been received. The initial value is based on the platform, but is updated as soon as user input is received. There is also a FocusHighlightStrategy enum so that the developer can change the strategy to a fixed value if needed.

The default is to automatically detect the mode based on the last type of user input. If they use a mouse or keyboard, it shows the focus highlights. If they use a touch interface, then the highlights disappear. This is consistent with the way that Android and Chrome work. The controls still receive focus, only the display of the highlight changes.

Text fields show the focus highlight regardless of the focus highlight mode.
2019-08-16 10:40:08 -07:00
Tom Robinson 1d03459fdb
Fix getOffsetToReveal for growthDirection reversed and AxisDirection down or right (#38441)
* Take growth direction into account when computing value for getOffsetForReveal in AxisDirection.right and .up conditions.

* Add alignment 1.0 test to left - reverse growth

* Add Reverse List showOnScreen test

* Formatting fix.
2019-08-16 13:38:23 -04:00
engine-flutter-autoroll f1003d536d
41eb729a6 Roll src/third_party/skia d95c9ac5994b..df54f37a5dc1 (1 commits) (flutter/engine#11054) (#38698)
git@github.com:flutter/engine.git/compare/22ad77051267...41eb729a653c

git log 22ad77051267..41eb729a653c --no-merges --oneline
2019-08-16 skia-flutter-autoroll@skia.org Roll src/third_party/skia d95c9ac5994b..df54f37a5dc1 (1 commits) (flutter/engine#11054)

The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff (stuartmorgan@google.com), and stop
the roller if necessary.
2019-08-16 13:21:36 -04:00
Dan Field a3221667de
Kill dead code (#38652) 2019-08-16 10:10:23 -07:00
rami-a 13844aa62a
[Material] Create theme for Dividers to enable customization of thickness (#38621) 2019-08-16 13:09:36 -04:00
Michael Thomsen 95b510618e
Rename patent file (#38686)
Rename this file to work around a limitation of the GitHub license detection tool, to ensure the repo is correctly tagged as BSD licensed
2019-08-16 16:54:58 +01:00
Andri Jasinski 267b858561 Disable xcode indexing in CI via COMPILER_INDEX_STORE_ENABLE=NO argument (#37378) 2019-08-16 08:29:45 -07:00
engine-flutter-autoroll 0ba71f944a
Roll engine d75718b8ccc7..22ad77051267 (2 commits) (#38688)
git@github.com:flutter/engine.git/compare/d75718b8ccc7...22ad77051267

git log d75718b8ccc7..22ad77051267 --no-merges --oneline
2019-08-16 skia-flutter-autoroll@skia.org Roll fuchsia/sdk/core/linux-amd64 from 5Nhwb... to 7b00W... (flutter/engine#11051)
2019-08-16 skia-flutter-autoroll@skia.org Roll src/third_party/skia da4f12c25bf1..d95c9ac5994b (3 commits) (flutter/engine#11050)

The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff (stuartmorgan@google.com), and stop
the roller if necessary.
2019-08-16 08:28:37 -04:00
engine-flutter-autoroll 5839e8a27a
d75718b8c Roll src/third_party/dart e35e8833ee..2023f09b56 (67 commits) (#38675)
git@github.com:flutter/engine.git/compare/bfa9be9978b9...d75718b8ccc7

git log bfa9be9978b9..d75718b8ccc7 --no-merges --oneline
2019-08-16 bkonyi@google.com Roll src/third_party/dart e35e8833ee..2023f09b56 (67 commits)

The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff (stuartmorgan@google.com), and stop
the roller if necessary.
2019-08-16 04:09:36 -04:00
engine-flutter-autoroll bc95f0881c
bfa9be997 Roll src/third_party/skia 6a519b8dd895..da4f12c25bf1 (1 commits) (flutter/engine#11045) (#38670)
git@github.com:flutter/engine.git/compare/c29c9bc0cdff...bfa9be9978b9

git log c29c9bc0cdff..bfa9be9978b9 --no-merges --oneline
2019-08-16 skia-flutter-autoroll@skia.org Roll src/third_party/skia 6a519b8dd895..da4f12c25bf1 (1 commits) (flutter/engine#11045)

The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff (stuartmorgan@google.com), and stop
the roller if necessary.
2019-08-16 03:14:36 -04:00
engine-flutter-autoroll 5a4d3cd52c
c29c9bc0c Make JIT work on iPhone armv7 (flutter/engine#11038) (#38664)
git@github.com:flutter/engine.git/compare/4b7a552b9eae...c29c9bc0cdff

git log 4b7a552b9eae..c29c9bc0cdff --no-merges --oneline
2019-08-16 dnfield@google.com Make JIT work on iPhone armv7 (flutter/engine#11038)

The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff (stuartmorgan@google.com), and stop
the roller if necessary.
2019-08-16 01:57:36 -04:00
engine-flutter-autoroll ad940c7b49
Roll engine f8e7453f1106..4b7a552b9eae (24 commits) (#38663)
git@github.com:flutter/engine.git/compare/f8e7453f1106...4b7a552b9eae

git log f8e7453f1106..4b7a552b9eae --no-merges --oneline
2019-08-16 stuartmorgan@google.com Roll Dart back to e35e8833 (flutter/engine#11043)
2019-08-16 bkonyi@google.com Roll src/third_party/dart 306f8e04bb..fecc4c8f2d (4 commits)
2019-08-16 skia-flutter-autoroll@skia.org Roll src/third_party/skia 963a606677e1..6a519b8dd895 (6 commits) (flutter/engine#11042)
2019-08-15 liyuqian@google.com Hide verbose dart snapshot during run_test.py (flutter/engine#11040)
2019-08-15 chinmaygarde@google.com Remove ability to override mac_sdk_path in flutter/tools/gn (flutter/engine#11013)
2019-08-15 bkonyi@google.com Roll src/third_party/dart cd16fba718..306f8e04bb (10 commits)
2019-08-15 stuartmorgan@google.com Roll buildroot to pick up recent macOS changes (flutter/engine#11037)
2019-08-15 jason-simmons@users.noreply.github.com Remove the ParagraphImpl class from the text API (flutter/engine#11012)
2019-08-15 jason-simmons@users.noreply.github.com Disable a deprecation warning for use of a TaskDescription constructor for older platforms (flutter/engine#11029)
2019-08-15 matthew-carroll@users.noreply.github.com Re-lands platform brightness support on iOS, plus platform contrast (flutter/engine#10791)
2019-08-15 iska.kaushik@gmail.com [fuchsia] Add required trace so files for fuchsia fars (flutter/engine#11036)
2019-08-15 skia-flutter-autoroll@skia.org Roll src/third_party/skia e5dc1ebc864a..963a606677e1 (14 commits) (flutter/engine#11032)
2019-08-15 stuartmorgan@google.com Add _glfw versions of the GLFW desktop libraries (flutter/engine#11024)
2019-08-15 skia-flutter-autoroll@skia.org Roll fuchsia/sdk/core/linux-amd64 from _fvZN... to 5Nhwb... (flutter/engine#11028)
2019-08-15 bkonyi@google.com Roll src/third_party/dart 9552646dc4..cd16fba718 (5 commits)
2019-08-15 dnfield@google.com Fix first frame logic (flutter/engine#11027)
2019-08-15 dnfield@google.com remove OS version (flutter/engine#11033)
2019-08-15 skia-flutter-autoroll@skia.org Roll src/third_party/skia e30a485a68c9..e5dc1ebc864a (7 commits) (flutter/engine#11025)
2019-08-15 bkonyi@google.com Roll src/third_party/dart cae08c6813..9552646dc4 (3 commits)
2019-08-15 jason-simmons@users.noreply.github.com Remove the output directory prefix from the Android engine JAR filename (flutter/engine#11015)
2019-08-15 inthroxify@users.noreply.github.com Fix flutter/flutter #34791 (flutter/engine#9977)
2019-08-15 bkonyi@google.com Roll src/third_party/dart e35e8833ee..cae08c6813 (28 commits)
2019-08-15 skia-flutter-autoroll@skia.org Roll src/third_party/skia f3f50099533d..e30a485a68c9 (2 commits) (flutter/engine#11022)
2019-08-15 skia-flutter-autoroll@skia.org Roll src/third_party/skia 319fd3d7bcb4..f3f50099533d (4 commits) (flutter/engine#11021)

The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff (stuartmorgan@google.com), and stop
the roller if necessary.
2019-08-16 00:21:36 -04:00
LongCatIsLooong 0ba8c2cdb1
Fix text scale factor for non-content components of Cupertino scaffolds (#38593) 2019-08-15 20:02:04 -07:00
Todd Volkert 1d8deb1bb8
Handle case of a connected unpaired iOS device (#38629)
Fixes https://github.com/flutter/flutter/issues/36789
Fixes https://github.com/flutter/flutter/issues/37000

https://github.com/flutter/flutter/issues/36524
https://github.com/flutter/flutter/issues/24600
2019-08-15 17:59:37 -07:00
Tom Robinson 0b3f2f61a2
Change RenderObject.getTransformTo to include ancestor. (#37652)
getTransformTo now includes ancestor in the transform it returns, except
for if ancestor is the root view, ensuring that the transform remains in
logical pixel space.
2019-08-15 20:52:15 -04:00
Jonah Williams 1df165ea13
Rename iOS arch for macOS release mode (macOS release mode 2 of 3) (#38645) 2019-08-15 17:38:35 -07:00
James Lin 9823b3dbd4 Update with more review feedback from jonahwilliams
* Remove the identity() function.
* Make _flattenMap private.
* Don't bother with ungrowable lists.
2019-08-15 16:47:20 -07:00
James Lin 4f3b70671c Add assert messages 2019-08-15 16:47:20 -07:00
James Lin e3ffa7689a Update with review feedback from dnfield and jonahwilliams 2019-08-15 16:47:20 -07:00
James Lin c02b805cdc Give _runFlutterTest the ability to validate command output
In another change (#37646), I want to test that a test fails and
prints expected output.  I didn't see an existing way to do that, so
I modified `_runFlutterTest` and `runCommand` to allow capturing the
output.  Currently capturing and printing output are mutually
exclusive since we don't need both.

Some awkward bits:
* There already exists a `runAndGetStdout` function that is very
  similar to `runCommand`, and this change makes the conceptual
  distinction more confusing.

* `runFlutterTest` has multiple code paths for different
  configurations.  I don't understand what the different paths are
  for, and I added output checking only along one of them.
2019-08-15 16:47:20 -07:00
Jonah Williams 01feddbece
Support for macOS release mode (1 of 3) (#37425) 2019-08-15 16:36:45 -07:00
Jonah Williams 57f1508b0e
roll back engine to f8e7453f11067b5801a4484283592977d18be242 (#38658) 2019-08-15 15:58:48 -07:00
Zachary Anderson 0566971d29
[flutter_tool] Throw tool exit on malformed storage url override (#38637) 2019-08-15 14:59:46 -07:00
engine-flutter-autoroll 7a138ca559
Roll engine 5d3012a1bb9d..cf6648313df8 (2 commits) (#38638)
git@github.com:flutter/engine.git/compare/5d3012a1bb9d...cf6648313df8

git log 5d3012a1bb9d..cf6648313df8 --no-merges --oneline
2019-08-15 jason-simmons@users.noreply.github.com Remove the output directory prefix from the Android engine JAR filename (flutter/engine#11015)
2019-08-15 inthroxify@users.noreply.github.com Fix flutter/flutter #34791 (flutter/engine#9977)

The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff (stuartmorgan@google.com), and stop
the roller if necessary.
2019-08-15 16:57:36 -04:00
liyuqian 77aa495eff
Update shader warm-up for recent Skia changes (#37955)
The update is copied from an update we made to a Google-internal
client: cl/260202900

The update will save 1 shader compilation.

This should help solve our regression:
https://github.com/flutter/flutter/issues/31203

More regressions on iOS might be introduced later by
https://github.com/flutter/engine/pull/9813#issuecomment-520039890

Unfortunately, we didn't rebase our benchmarks so such regressions
were not detected.

Hence to fully solve https://github.com/flutter/flutter/issues/31203,
we might need to revert some change in
https://github.com/flutter/engine/pull/9813 to make iOS shader warm-up
happen on the GPU thread again.
2019-08-15 13:04:22 -07:00
Greg Spencer a24bfed0e7
Add autofocus parameter to widgets which use Focus widget internally (#37809)
Add an autofocus parameter to widgets which use Focus widget internally, and update related docs.

This will allow developers to request that a particular widget be automatically focused when shown.
2019-08-15 12:30:19 -07:00
Chris Yang 5acf63d35a
PlatformViewLink, handling creation of the PlatformViewSurface and dispose PlatformViewController (#37703)
* link

* review fixes

* review fixes

* remove extra line
2019-08-15 12:16:38 -07:00
engine-flutter-autoroll 07197e91c3
Roll engine f8e7453f1106..5d3012a1bb9d (3 commits) (#38624)
git@github.com:flutter/engine.git/compare/f8e7453f1106...5d3012a1bb9d

git log f8e7453f1106..5d3012a1bb9d --no-merges --oneline
2019-08-15 bkonyi@google.com Roll src/third_party/dart e35e8833ee..cae08c6813 (28 commits)
2019-08-15 skia-flutter-autoroll@skia.org Roll src/third_party/skia f3f50099533d..e30a485a68c9 (2 commits) (flutter/engine#11022)
2019-08-15 skia-flutter-autoroll@skia.org Roll src/third_party/skia 319fd3d7bcb4..f3f50099533d (4 commits) (flutter/engine#11021)

The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff (stuartmorgan@google.com), and stop
the roller if necessary.
2019-08-15 15:15:39 -04:00
Zachary Anderson e24a27d374
[flutter_tool] Flip create language defaults to swift and kotlin (#38339) 2019-08-15 12:13:28 -07:00
Jonah Williams 8d6dc620d6
fix rpc exception for real (#38575) 2019-08-15 12:13:12 -07:00
Zachary Anderson a40ab895cf
[flutter_tool] Observatory connection error handling cleanup (#38353) 2019-08-15 12:13:03 -07:00
Alexander Aprelev f5dcbdab3a Increase pattern that matches operation duration. (#36392)
On Flutter HHH buildbot some operations that over a second: 4 digits for milliseconds, rather than 3 that are currently allowed.
2019-08-15 10:16:30 -07:00
Ingo Reinhart ed88d28d52 use common emulator/device list (#38296) 2019-08-15 10:13:18 -07:00
MH Johnson 1033155fb9
[Material] Add splashColor to FAB and FAB ThemeData (#38467)
* [Material] Add splashColor param to FAB and FAB ThemeData
2019-08-15 13:12:21 -04:00
Kate Lovett 55c979ea09
Updating code owners for golden file changes (#38564) 2019-08-15 09:13:45 -07:00
Jonah Williams 5ec039dd45
Don't reload if compilation has errors (#38586) 2019-08-15 09:08:19 -07:00
engine-flutter-autoroll b296d95391
Roll engine 426ea8dba6ea..f8e7453f1106 (3 commits) (#38613)
git@github.com:flutter/engine.git/compare/426ea8dba6ea...f8e7453f1106

git log 426ea8dba6ea..f8e7453f1106 --no-merges --oneline
2019-08-15 skia-flutter-autoroll@skia.org Roll fuchsia/sdk/core/linux-amd64 from pCY3J... to _fvZN... (flutter/engine#11020)
2019-08-15 skia-flutter-autoroll@skia.org Roll src/third_party/skia c061d31c2415..319fd3d7bcb4 (9 commits) (flutter/engine#11018)
2019-08-15 bkonyi@google.com Roll src/third_party/dart e35e8833ee..e35e8833ee (0 commits)

The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff (stuartmorgan@google.com), and stop
the roller if necessary.
2019-08-15 12:06:36 -04:00
Ian Hickson 86dacb200c Update CONTRIBUTING.md (#38491) 2019-08-15 00:07:49 -07:00
engine-flutter-autoroll 8cf40e90b0
Roll engine 4c4c9997780a..426ea8dba6ea (2 commits) (#38605)
git@github.com:flutter/engine.git/compare/4c4c9997780a...426ea8dba6ea

git log 4c4c9997780a..426ea8dba6ea --no-merges --oneline
2019-08-15 chris@bracken.jp Fix gn breakage on non-Fuchsia macOS host builds (flutter/engine#11019)
2019-08-15 chris@bracken.jp Fix gn breakage on Fuchsia macOS host builds (flutter/engine#11016)

The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff (stuartmorgan@google.com), and stop
the roller if necessary.
2019-08-15 02:32:36 -04:00
Dan Field 07f079a932
Improve bitcode check (#38587) 2019-08-14 23:30:26 -07:00