Commit graph

9309 commits

Author SHA1 Message Date
Alexandre Ardhuin c9b94e1412 enable lint prefer_const_constructors_in_immutables (#12693)
* enable lint prefer_const_constructors_in_immutables

* remove LabeledGlobalKey._
2017-10-25 11:20:36 +02:00
Alexandre Ardhuin 28366002d9 enable lint prefer_foreach (#12674)
* enable lint prefer_foreach

* fix tests
2017-10-25 08:25:44 +02:00
Alexandre Ardhuin 872d83a3c5 enable lint prefer_conditional_assignment (#12694) 2017-10-25 08:18:26 +02:00
Chris Bracken d69fcea1a8 Use Mountain View/Cupertino terms in drawer on iOS (#12699)
Use our platform identifiers rather than OS names for the platform
switcher radio buttons in the drawer as noted in section 2.3.10 of the
App Store review guidelines.

See: https://developer.apple.com/app-store/review/guidelines/
2017-10-24 18:11:10 -07:00
Jeff McGlynn 021a268852 Add a pageSnapping parameter to PageView (#12596)
* Add a pageSnapping parameter to PageView

Setting the pageSnapping property allows extending the PageView scroll
behavior, such as custom scroll animations or custom scroll bars.

* Apply pageSnapping CR feedback

- Remove _kNonSnappingPhysics, use null instead.
- Minor code style fixes.
- It turns out that the forth state is Arkansas, not California.
2017-10-24 17:09:33 -07:00
Greg Spencer ea679171e5 Add Material character counter to TextField. (#12648)
This adds an optional character counter and maxLength parameter to the TextField, as described in the Material Design Spec.

The counter text and style in the input decorator may be specified, but will default to the "right thing" if not specified, where the "right thing" is a counter that looks like "3 / 10" (if there are three characters entered into a field where maxLength is set to 10).

To limit the number of characters entered, I created a LengthLimitingTextFormatter that will limit the number of characters (Unicode runes) in the input, which can be used independently. The formatter is applied after the other formatters supplied (if any). Even if there is no decorator, the text field will limit the number of characters input if maxLength is set.

If maxLengthEnforced is set to false (it defaults to true), then the max length will not be enforced. In that case, if the text exceeds the length, then the counter will turn red, and it will make the divider turn red.
2017-10-24 14:49:39 -07:00
Michael Goderbauer c3e049613d Support for accessibilityHint and accessibilityValue (#12677)
* Support accessibility labels and hints

* more tests

* ++

* review comments

* fix merge

* test fix
2017-10-24 11:17:51 -07:00
Greg Spencer 80b820a26d Revert "Revert "Fixes InputDecorator to work with textScaleFactor, fixes Material Design differences. (#12595)" (#12678)" (#12689)
This reverts commit 72dc7d9146.

Re-landing my InputDecorator changes so that I can land the character counter PR.
2017-10-24 11:07:14 -07:00
Phil Quitslund d6a7d05a25 Fix typo in Calculator demo. (#12688) 2017-10-24 10:36:31 -07:00
Michael Goderbauer fe788c5b3d Roll engine to 8e79156765c67b71b1e1b9895dbc8eea43f9949c (#12687) 2017-10-24 10:27:39 -07:00
Alexander Aprelev 796a0007f7 Rolling engine with rolled dart (#12685) 2017-10-23 21:27:08 -07:00
Michael Goderbauer 141a6355ce Performance improvements for semantics tree compilation (#12682)
* Without checking compatibility

* ++

* ++

* ++

* more docs
2017-10-23 17:33:46 -07:00
Yegor 3206fb63ad Generate date localizations (#12466)
* merge with Hans; address comments

* merge material_localizations.dart
2017-10-23 15:30:34 -07:00
Greg Spencer 72dc7d9146 Revert "Fixes InputDecorator to work with textScaleFactor, fixes Material Design differences. (#12595)" (#12678)
This reverts commit 67cf7918cf.

Reverting because this causes scuba regressions that I'd like to
address in another PR that is pending, but we'd like to roll Flutter.
2017-10-23 14:56:50 -07:00
amirh ce4a45779d Add an isButton flag to the Semantic widget,use it for MaterialButton (#12657)
https://github.com/flutter/flutter/issues/11992
2017-10-23 14:52:41 -07:00
xster 52815b2224 Revive "Add a way to get the furthest Navigator" (#12647)
* Revert "Construct the accessibility channel's events by SemanticsEvent. (#12638)"

This reverts commit 4c1150dd01.

* Revert "Revert "Add a way to get the furthest Navigator" (#12608)"

This reverts commit 79f13c3625.
2017-10-23 12:24:19 -07:00
Jason Simmons 048bc5e0f6 roll engine (#12660) 2017-10-23 11:48:31 -07:00
Ian Hickson 05a22fe0ab FittedBox RTL (#12662) 2017-10-23 11:05:23 -07:00
Ian Hickson 662b668485 Revert "nav bar font styles are special, do not inherit (#12578)" (#12661)
This reverts commit 964a138d80.

It may (or may not) have caused a performance regression. Hard to say.
2017-10-23 11:05:12 -07:00
Alexandre Ardhuin 1fce14a31c enable lint prefer_single_quotes (#12665) 2017-10-22 18:11:36 +02:00
Yegor b07ea41954 add IntelliJ modules for dev/tools and packages/flutter_localizations (#12653) 2017-10-20 21:20:42 -07:00
Yegor 67d16cd517 Theme.of provides all TextStyle properties (#12552)
* Theme provides all TextStyle properties

* match field declaration order in the test

* Theme.of returns text style with inherit == false

* change TextStyle.inherit logic; docs

* add TextStyle.debugLabel

* address comments

* add debug labels to Typography text styles
2017-10-20 20:17:07 -07:00
Ian Hickson faf44b592a Factor out painting logic for DecorationImage (#12646)
This avoids some code duplication that existed before and will make
further modifications easier.
2017-10-20 16:58:16 -07:00
Jason Simmons eb475bbb80 move dart_io_entries.txt to third_party/dart for AOT builds with a local engine (#12659) 2017-10-20 15:32:27 -07:00
Jason Simmons 5e8634a625 libtxt: make a paragraph selection test handle equivalent libtxt and blink output (#12606) 2017-10-20 12:54:36 -07:00
Devon Carew 171b1b08c9 tweak the flutter create template to use the function shorthand for main() (#12654) 2017-10-20 10:46:07 -07:00
Hans Muller 796c5439f6 Language-specific LocalizationDelegates (#12645) 2017-10-20 10:45:28 -07:00
Devon Carew a554401e79 update the flutter create template files (#12641) 2017-10-19 19:38:39 -07:00
P.Y. Laligand e04472e8d5 Update location of intl package. (#12644)
Also switched to relative paths for local packages.
2017-10-19 19:36:50 -07:00
xster b96fa4de11 Let CupertinoNavBar automatically have a back or close button (#12575)
* create auto back button behaviour

* cosmetic fidelity

* tests

* review

* document new icon
2017-10-19 19:19:49 -07:00
amirh 4c1150dd01 Construct the accessibility channel's events by SemanticsEvent. (#12638)
This refactoring allows us to have SemanticsEvent object for events that are not
associated with an accessibility node id.
And allow https://github.com/flutter/flutter/pull/12594 to be a bit
cleaner with a single place for accessibility channel documentation (the
SemanticsEvent classes documentation).
2017-10-19 18:31:58 -07:00
xster 79f13c3625 Revert "Add a way to get the furthest Navigator" (#12608)
* Revert "BoxDecoration.borderRadius and RoundedRectangleBorder.borderRadius RTL (#12603)"

This reverts commit 0790891600.

* Revert "Copy snapshot file into assets (#12523)"

This reverts commit f6135107bc.

* Revert "Add a rootNavigator option to Navigator.of (#12580)"

This reverts commit 822084b235.
2017-10-19 17:34:39 -07:00
Ian Hickson 982f511c90 Make Border more general (#12619) 2017-10-19 17:06:01 -07:00
xster f2d3b99b43 Add docs for cupertino icons (#12610) 2017-10-19 16:45:22 -07:00
Hans Muller 765167bb8c Updated stocks example README (#12634) 2017-10-19 16:37:48 -07:00
amirh e543b07d1d Revert "Roll engine to 5003703330f280325fa73080bb23b1ab7008b213" (#12642)
* Revert "Fix error message to refer to actual ClipRect widget instead of non-existing RectClip (#12632)"

This reverts commit 1573d3b886.

* Revert "Roll engine to 5003703330f280325fa73080bb23b1ab7008b213 (#12629)"

This reverts commit 81a358b7a8.
2017-10-19 15:44:57 -07:00
robertoscaramuzzi 1573d3b886 Fix error message to refer to actual ClipRect widget instead of non-existing RectClip (#12632) 2017-10-19 15:27:48 -07:00
amirh 81a358b7a8 Roll engine to 5003703330f280325fa73080bb23b1ab7008b213 (#12629) 2017-10-19 13:55:16 -07:00
Michael Goderbauer 2a11e896ee Update clean command in devicelab tests (#12640) 2017-10-19 13:20:32 -07:00
Michael Goderbauer 1eed6dff34 Make clean command top level (#12616)
* Make clean command top level

Fixes https://github.com/flutter/flutter/issues/10783

* remove backwards
2017-10-19 11:23:42 -07:00
Chris Bracken e965b69285 Improve libimobiledevice doctor messages (#12633)
The libimobiledevice suite of tools do not include version information.
A simple way to verify they meet our version requirements is to run
idevice_id -l, which will fail when older versions are run against iOS
devices with newer versions of iOS installed.

Unfortunately, idevice_id -l will also fail when libimobiledevice is up
to date, but the attached devices have never been paired with the host
machine in Xcode.

This patch updates the error message to help guide the user in such
situations.
2017-10-19 10:52:25 -07:00
Greg Spencer 67cf7918cf Fixes InputDecorator to work with textScaleFactor, fixes Material Design differences. (#12595)
Fixes InputDecorator to work with textScaleFactor, fixes Material Design differences.

There were a number of differences with the Material Design spec, including
several different padding values and underline thickness.  This corrects
that so that the decorator is in line with the Material Design spec now.

Also, the decorator properly handles changes to the textScaleFactor, where
before it would not re-layout when needed, painting the cursor and
underline incorrectly.

The decorator also now properly animates helper, error, and hint text when
the textScaleFactor or input decoration properties change.

Helper text is now properly displayed in dense mode, as the spec shows.
Before this change, it was never displayed in dense mode.

Fixes #12485
2017-10-19 10:11:07 -07:00
Greg Spencer 7e09649c41 Override just the textScaleFactor (#12530)
Hixie pointed out that what I had before was resetting all of the MediaQuery values, not just textScaleFactor. This should fix that.
2017-10-19 09:24:05 -07:00
Alexander Aprelev c05da1e29d Stop syncing dart source files when in --preview-dart-2. (#12597)
Syncing source files is not needed when host sends kernel file to the device.
2017-10-19 07:16:15 -07:00
Sarah Zakarias f74cd91761 Update TextStyle doc and remove package field (#12577) 2017-10-19 10:14:38 +02:00
Sarah Zakarias e4f53c3abd Add 'package' argument to IconData (#12560) 2017-10-19 09:38:54 +02:00
Alexandre Ardhuin ce6f8d3a83 comment some lint exclusions (#12601) 2017-10-19 08:33:01 +02:00
Alexandre Ardhuin 700dc9f752 enable lint avoid_function_literals_in_foreach_calls (#12607) 2017-10-19 08:16:16 +02:00
Todd Volkert 79fbf8bb03 Split common matcher into its own file. (#12622)
This aids in running the tests internally in Google
since the libraries upon which tests depend and the
test files themselves are defined separately.
2017-10-18 20:55:00 -07:00
P.Y. Laligand e938ceb086 Adjust to new location for the Dart project. (#12621) 2017-10-18 19:45:48 -07:00