Commit graph

9489 commits

Author SHA1 Message Date
Devon Carew c25558d426
change 2 print calls to printStatus (#13206) 2017-11-27 08:13:24 -08:00
Devon Carew d776f64f4e
tweaks to the cli args for flutter run (#13207) 2017-11-27 06:56:51 -08:00
Devon Carew bdbe53be01
remove unused constants (#13199) 2017-11-24 19:13:18 -08:00
Mikkel Nygaard Ravn 167382480a
Clean up external_ui device lab test (#13177) 2017-11-23 10:24:16 +01:00
Michael Thomsen 5ecbc92b1a
Update tools reference (#13151) 2017-11-23 09:17:29 +01:00
Ian Hickson 4c9013b71b
BottomNavigationBar RTL (#13167) 2017-11-22 18:55:07 -08:00
Ian Hickson 9afc853f75
Revert "Reenable fade transition for Material page transition (#13048)" (#13172)
This reverts commit e73d406106.

It caused major performance regressions.
2017-11-22 18:54:15 -08:00
Ian Hickson 2bda59a1fe
TabBar RTL (#13164) 2017-11-22 18:53:42 -08:00
Chris Bracken 112df6efb0
Mark flutter_gallery__preview_dart_2_bulid unflaky (#13170)
This was fixed in #13150.

That commit rolled the engine to:
  flutter/engine@93b2179597,

which rolled Dart to:
  dart-lang/sdk@70e5deacb5

which includes:
  dart-lang/sdk@d38c08d973

Which fixes the breakage introduced in #13134.

This reverts commit f5d9c7775d.
2017-11-22 18:17:43 -08:00
Chris Bracken cf37a4721a
Reorganise flutter driver implementation sources (#13163)
This patch reorganises flutter_driver's lib/src directory into three
subdirectories:

* driver: sources transitively imported/exported by flutter_driver.dart,
  which defines the API used by driver tests executed on the host machine.

* extension: sources transitively imported/exported by
  driver_extension.dart, which defines the API used to instrument a
  Flutter app running on the target device for use with a driver test.

* common: sources common to both driver and extension code.

This makes rolling Flutter into repositories that use Bazel (or
Bazel-like build systems) significantly more robust, due to the simpler
glob patterns involved.
2017-11-22 17:24:41 -08:00
Chris Bracken d9bdb76fd2
Eliminate unused retry.dart from flutter_driver (#13161) 2017-11-22 16:54:19 -08:00
amirh 78e044f5ec
Cancel the animated image stream timer if all listeners were removed. (#13158)
This is a bug in my previous CL: instead of cancelling the timer if
there are no more listeners, I canceled it if there were listeners (I
can claim I just missed a not :) ).

Not cancelling the timer when removing the last listener was not that bad, as
the timer callback is guarded by a check to see if there are listeners.
So the animation will not continue.

But in the case there were multiple listeners on the same stream, and
one of them is removed, this bug will stop the animation for all other
listeners.
I added a test case for this scenario.
2017-11-22 15:27:26 -08:00
Ian Hickson 2db0c25f82
Dismissible RTL (#13137)
Fix the dismissible demo in the gallery (make it actuall update when you pick something from its menu; give it a better affordance for resetting once you've dismissed everything).

Improve some docs.

Fix various flinging bugs with dismissible. Add tests for those cases.

Add a feature to flutter_test to support a drag-then-fling gesture (used by the flinging tests).
2017-11-22 15:20:15 -08:00
Alex e6119282b7 feat: add optional headers param to network image (#13128)
* feat: add optional headers params to network image

* fix: addressed comments

* feat: add test

* style: format code
2017-11-22 15:19:52 -08:00
Pascal Welsch 891a218002 Add missing onDragCompleted to LongPressDraggable (#13119)
* Add missing onDragCompleted to LongPressDraggable

* Add test for LongPressDraggable onDragStarted and onDragCompleted
2017-11-22 15:18:28 -08:00
Leonardo Bispo de Oliveira b3fa055894 ExpansionTile opened - initial state (#13115)
Changed the ExpansionTile widget to have an optional value to
initialize the widget as collapsed or expanded.

The widget will be collapsed by default.
2017-11-22 15:16:27 -08:00
Chris Bracken d5cb9781e1
Eliminate unused matcher_util in flutter_driver (#13159)
Use of this file was eliminated in e7657b9462.
2017-11-22 15:15:37 -08:00
Ian Hickson 34ba6be93a
Popup menus RTL (#13110)
This fixes the popup menu code to do a better job of expanding
smoothly regardless of which side of the screen it's on. It still
results in a bidirection growth when positioned at the bottom of the
screen, so maybe we'll need to animate menus differently, but that's
a problem for another patch.

Also, improve some docs and provide RelativeRect.toSize which I needed
at one point while building this patch (though it didn't survive all
the way to the end).
2017-11-22 15:15:21 -08:00
Yegor 8c902ad479
clear timeline events prior to starting a new action (#12984)
* clear timeline events prior to starting a new action

* trailing commas
2017-11-22 15:08:09 -08:00
Pascal Welsch e73d406106 Reenable fade transition for Material page transition (#13048)
Fixes #12877 by reverting #9472
2017-11-22 15:07:41 -08:00
Kyle Bradshaw 3dc32873bf AnimationController reset() method (#13044)
* AnimationController reset() method

Just a simple convenience method to fix #13039

* Added `reset()` test

* More test expectations

Per feedback.

* Removed test print

* Improved documentation of reset()

* Add controller.reverse to test
2017-11-22 15:06:43 -08:00
Dwayne Slater c7c3b606fc Show Android tombstone during native crash (#12923)
* Show Android tombstone during native crash

* Fix tombstone lines being missed on newer Android versions
2017-11-22 14:58:59 -08:00
amirh 155a4cab18
Don't keep image stream listeners when TickerMode is disabled. (#13106)
This makes sure that we don't decode frames when we don't need to run
the animation.

For example, prior to this CL: an animated image in a page that is not
currently at the top of the page stack (it is covered by another page),
will keep the the image stream listener, and thus frames will still be
decoded.
2017-11-22 13:45:55 -08:00
xster 765dd80e8b
Add caching detail in doc (#13112)
* Add caching detail in doc

* review
2017-11-22 12:03:43 -08:00
Martin Kustermann d79c12e5b8
Roll engine to pick up revert in engine/third_party/dart which broke flutter tests (#13150) 2017-11-22 17:35:35 +01:00
Sigurd Meldgaard 257e595f34
Roll engine to 9d711ccf9b3ad0e4140ebb0dbd282587e8c01624 (#13149) 2017-11-22 16:04:34 +01:00
Mikkel Nygaard Ravn dbfd0bef9e
Move iOS test to devicelab_ios (#13148) 2017-11-22 15:14:14 +01:00
Mikkel Nygaard Ravn d06482cc79
Add integration test of textures (#13122) 2017-11-22 14:16:25 +01:00
Sigurd Meldgaard 8ba08718b6
Revert "Roll engine to e58764fbe0cf7a0fab7e75a94de9143a145108c3 (#13143)" (#13145)
This reverts commit 1abd8a12e2.
2017-11-22 13:00:46 +01:00
Sigurd Meldgaard 1abd8a12e2
Roll engine to e58764fbe0cf7a0fab7e75a94de9143a145108c3 (#13143) 2017-11-22 10:47:46 +01:00
Levin Rickert 396142b669 Fixed broken links to apple human interface guidelines (#13132) 2017-11-22 10:30:52 +01:00
Todd Volkert e792c6bb5b
Add support for binding to IPv6 localhost in flutter run (#13136)
This allows `flutter run` to work on hosts that are IPv6-only.
2017-11-21 20:12:21 -08:00
Alexander Aprelev f5d9c7775d
Mark flutter_gallery__preview_dart_2_bulid flaky. It was broken in last Dart engine roll (#13142) 2017-11-21 18:45:44 -08:00
Alexander Aprelev 780c4b55a3
Roll engine to pick up rollback of minimal IKG, that breaks some hot reload tests. (#13139) 2017-11-21 17:40:15 -08:00
Chris Bracken d6a35ee356
Update dart:vmservice_sky to vmservice_io (#13138)
In 77af1e5eec, dart:vmservice_sky was
renamed to dart:vmservice_io.
2017-11-21 16:23:33 -08:00
Chris Bracken 77af1e5eec
Roll engine to 5f9c8522dd60d5daa6f218d0bf3394796c7a23c0 (#13134)
Picks up Dart SDK roll to 3ee0a4284203ebc6991c78054583a7c02dc8faf9
2017-11-21 15:40:36 -08:00
Martin Kustermann 545ec9efb7
Add support for NDK discovery and add --prefer-shared-library option (#12788)
* Add support for NDK discovery and add --prefer-shared-library option

We would like to be able to use native tools (e.g. simpleperf, gdb) with
precompiled flutter apps.  The native tools work much better with *.so
files instead of the custom formats the Dart VM uses by default.

The reason for using blobs / instruction snapshots is that we do not
want to force flutter users to install the Android NDK.

This CL adds a `--prefer-shared-library` flag to e.g. `flutter build
apk` which will use the NDK compiler (if available) to turn the
precompiled app assembly file to an `*.so` file.  If the NDK compiler is
not available it will default to the default behavior.

* Rebase, add test for NDK detection, augment flutter.gradle with @Input for flag

* Use InMemoryFileSystem for test

* Remove unused import

* Address some analyzer warnings
2017-11-21 15:44:03 +01:00
Chris Bracken 14b5cb047e
Use duration not threadDuration for frame duration (#13117)
1. We want to measure wall-clock duration for the benchmarks, as opposed
   to thread duration (e.g., waiting on a mutex should accrue time) and
   'dur' is the metric to use for that.

2. On Darwin-based systems (macOS and iOS) 'tdur' is the result of a
   mach syscall lookup to thread_info. This call returns unreliable data
   on iOS. Chromium, for example, disables thread time support entirely
   for iOS.
2017-11-20 17:37:14 -08:00
Chris Bracken a95b752dc6
Roll engine to 82cd793ee5235c13d7398ede9aba49f0d75eefd1 (#13114) 2017-11-20 16:45:59 -08:00
xster 5fe32098b5
reverse doc from image providers back to image shorthands (#13074) 2017-11-20 10:34:48 -08:00
Mikkel Nygaard Ravn 9186ba0f89
Alpha pre roll (#13096) 2017-11-20 14:14:01 +01:00
Mikkel Nygaard Ravn 4676e1d724
Add support for iOS plugin class prefix (#13095) 2017-11-20 13:27:21 +01:00
Todd Volkert 928d2cc764
Add EBADF errno to list of ignorable errors in terminal.dart (#13077)
I get this error when piping an `echo` string to the stdin of
the flutter tool.

https://github.com/dart-lang/sdk/issues/29083
2017-11-17 15:45:27 -08:00
amirh cd54bd39ab
Fix table formatting in MultiFrameImageStreamCompleter doc - 2nd attempt (#13052) 2017-11-17 13:51:08 -08:00
amirh 5fc8eb8263
Use MultiFrameImageStreamProvider in the various image providers. (#12997) 2017-11-17 13:48:28 -08:00
Chris Bracken 86e23bdb64
Verify microtasks are flushed with each event loop (#13073)
Adds a test that verifies that the microtask queue is flushed between
engine event loop iterations.

Related issue: https://github.com/flutter/flutter/issues/9998
2017-11-17 12:05:39 -08:00
amirh acebaa6dba
roll engine to 4733e3373789894aa4f593137c6d440891d492a2 (#13075) 2017-11-17 12:03:52 -08:00
Greg Spencer 0259be90b8
Fix spelling errors in all the dartdocs. (#13061)
I got tired of drive-by spelling fixes, so I figured I'd just take care of them all at once.

This only corrects errors in the dartdocs, not regular comments, and I skipped any sample code in the dartdocs. It doesn't touch any identifiers in the dartdocs either. No code changes, just comments.
2017-11-17 10:05:21 -08:00
xster d5d2cdfeef
A bunch of onboarding error detections (#12977) 2017-11-16 22:53:22 -08:00
Todd Volkert 580281e520
Roll engine to 0e564957ac8c0045684efd4de6156ebcda347901 (#13062) 2017-11-16 19:33:32 -08:00