Commit graph

10710 commits

Author SHA1 Message Date
Karen Rustad Tölva 9155795883 Fix typo in main.dart templates (#35684) 2019-07-08 10:36:44 -07:00
Jonah Williams 4f0f88b5ea
Disable incremental compiler in dartdevc (#35681) 2019-07-08 10:36:11 -07:00
Jonah Williams 34467289d6
Add timer checking and Fake http client to testbed (#35392) 2019-07-08 10:04:48 -07:00
Chris Yang 49cce98483
add documentation: conic path clipping not supported for UIKitView (#35063) 2019-07-08 08:24:23 -07:00
Jonah Williams e6a7419603
disable a test case in xcode_backend.sh (#35708) 2019-07-08 08:04:48 -07:00
Todd Volkert 3bf91b5436
Prepare for Socket implements Stream<Uint8List> (#35646)
An upcoming change in the Dart SDK changes `Socket` from
implementing `Stream<List<int>>` to implementing `Stream<Uint8List>`.
This forwards-compatible change in flutter_tools prepares for that
Dart SDK change.

https://github.com/dart-lang/sdk/issues/36900
2019-07-05 12:59:32 -07:00
Jonah Williams 93edc014ae
update packages (#35573) 2019-07-04 11:26:19 -07:00
Gary Qian a0c47e2216
Do not use ideographic baseline for RenderPargraph baseline (#35493) 2019-07-03 15:04:18 -07:00
Sam Rawlins 5b6ebf1230 Add type to StreamChannel in generated test code. (#35367)
This is necessary for those who wish to comply with static analysis like
`strict-raw-types: true`, which includes generated code within their package.
2019-07-03 14:11:11 -07:00
Dan Field f85630b18a
Fix RenderFittedBox when child.size.isEmpty (#35487) 2019-07-03 12:40:06 -07:00
chunhtai f143fd6a4f
fix Selection handles position is off (#34665) 2019-07-03 10:50:10 -07:00
Jonah Williams b8597f0a7e
Move usage flutter create tests into memory filesystem. (#35160) 2019-07-03 10:49:33 -07:00
Michael Goderbauer d41eeeb50d
Include tags in SemanticsNode debug properties (#35491) 2019-07-03 09:13:37 -07:00
Michael Goderbauer 4ca7bfa0c2
Re-apply 'Add currentSystemFrameTimeStamp to SchedulerBinding' (#35492) 2019-07-03 09:13:09 -07:00
Justin McCandless 2d2bb6bf92
CupertinoTextField vertical alignment (#34723)
CupertinoTextField now supports vertical alignment via the textAlignVertical parameter.
2019-07-03 08:22:31 -07:00
Todd Volkert 4cd12fc8b7
Mark update-packages as non-experimental (#35467)
Marking it as experimental was breaking tests and packaging
scripts on stable branches.
2019-07-02 18:24:25 -07:00
Jonah Williams 556e374e02
fix default artifacts to exclude ios and android (#35303) 2019-07-02 17:40:55 -07:00
Siva f496595773
Use the new service protocol message names (#35482)
* Use the new service protocol message names
  clearVMTimeline
  setVMTimelineFlags
  getVMTimeline
  getVMTimelineFlags

* Fix clearTimeline at another spot.
2019-07-02 16:10:04 -07:00
Siva 3a67442129
Manual roll of engine 45b66b7...ffba2f6 (#35464)
* Manual roll of engine 45b66b7...ffba2f6

git log 45b66b7...ffba2f6 --oneline

ffba2f68d Roll src/third_party/dart b37aa3b036...0abff7b2bb (#9588)
62514cb77 Roll fuchsia/sdk/core/mac-amd64 from n9fZpXVmsbgKZzS8Q2GXxB453q8AbLpfGztsPsq47pMC to BYCwsJf7r7zfd2THSGinFeIHv552AEVchXdc7VZzP0IC (#9587)
9f2721284 Roll src/third_party/skia e4c88bb1f848..1ddee025229a (7 commits) (#9586)
03a31e0ad Roll fuchsia/sdk/core/linux-amd64 from F9oY0d56X3aONxwv5vw9Gco--AHmC8SHuDXdhdWCnnMC to d2VK3FYSEKQ35UdZw5FdbOZUI_xgT0-1h8DnGDUHPVAC (#9583)

* Fix analyzer warning.
2019-07-02 13:16:00 -07:00
Alexandre Ardhuin 758009ba70
more ui-as-code (#35393)
* more ui-as-code

* address review comments
2019-07-02 21:11:56 +02:00
Dan Field e2a55fe83f
update reassemble doc (#35164) 2019-07-02 11:11:48 -07:00
Tong Mu 1a374d820d
New parameter for RawGestureDetector to customize semantics mapping (#33936)
This PR adds a new parameter to RawGestureDetector, `semantics`, which configures how detectors handle semantics gestures. It has a default delegate that keep the current behavior.
2019-07-01 16:17:11 -07:00
stuartmorgan d6bd1c0584
Add --target support for Windows and Linux (#34660)
- Adds desktop projects to ApplicationPackageStore
- Plumbs target overrides through the desktop builds
2019-07-01 14:49:34 -07:00
Jenn Magder 95a1816698
Clean up host_app_ephemeral Profile build settings (#35307) 2019-07-01 11:02:25 -07:00
Michael Goderbauer f357f8d19e
Remove print (#35408) 2019-07-01 10:09:43 -07:00
Shi-Hao Hong ddd5ccd011
Add Container fallback to Ink build method (#35282)
* Add Container fallback to Ink build method

* Add tests for Ink container fallback
2019-07-01 08:28:34 -07:00
Dan Field 9e1b4b22c2
tests for about page (#35290) 2019-06-30 22:40:09 -07:00
Dan Field 3eb40925e5
Always test semantics (#35110)
Default `semanticsEnabled` to true for `testWidgets` and fix associated bugs
2019-06-28 12:40:23 -07:00
Zachary Anderson 97127730f2
[flutter_tool] Fill in Fuchsia version string (#34516) 2019-06-28 12:12:53 -07:00
MH Johnson 90284305fc
Re-land "[Material] Support for hovered, focused, and pressed border color on OutlineButtons" (#35278)
* outline border implements material state property
2019-06-28 14:40:42 -04:00
Tong Mu 94dbdcba73
benchmarkWidgets.semanticsEnabled default false. (#35280)
In order not to break existing benchmarks.
2019-06-28 11:03:16 -07:00
David Shuckerow df6e4d4872
Make it possible to override the FLUTTER_TEST env variable (#34301)
* Make it possible to override the FLUTTER_TEST env variable without unsetting it.

* Switch to using platform instead of Platform.

* Document the bindings, and introduce tests that initialize multiple WidgetsBindings with different environments.

* Add tests for the flutter platform test.

* Add license headers

* Fix lints

* Remove trailing whitespace

* Respond to Jonahs comments

* Respond to Ians comments

* Mock out the HttpServer in flutter_platform_test

* Mock out the HttpServer in flutter_platform_test

* Explain why we mock out the HttpServer in flutter_platform_test
2019-06-28 10:37:27 -07:00
Todd Volkert 66273157f0
More preparation for HttpClientResponse implements Uint8List (#35245)
https://github.com/dart-lang/sdk/issues/36900
2019-06-28 09:58:15 -07:00
Todd Volkert 17c18da0c6
Revert "[Material] Support for hovered, focused, and pressed border color on OutlineButtons (#34872)" (#35276)
This reverts commit 3f94159989.
2019-06-28 09:18:30 -07:00
MH Johnson 3f94159989
[Material] Support for hovered, focused, and pressed border color on OutlineButtons (#34872)
* outline border implements material state property
2019-06-28 11:55:54 -04:00
hizzd d780c2cff6 Fixed the LicensePage to close the page before loading the License causes an error (#34907) 2019-06-28 08:50:01 -07:00
Tong Mu 03ed06f44d
New benchmark: Gesture semantics (#35232)
* Add semanticsEnabled to widgetBenchmark
* Add button_matrix_app and gesture benchmark
2019-06-28 00:37:01 -07:00
Jonah Williams 95ca768976
Revert "Revert "Manual engine roll, Update goldens, improved wavy text decoration 0f9e297ad..185087a65f (#35066)" (#35237)" (#35242) 2019-06-27 22:58:54 -07:00
Shi-Hao Hong 892043842e
child param doc update in Ink and Ink.image (#35211)
* Add doc suggesting Container for BoxDecorations that have no child widget
2019-06-27 19:37:20 -07:00
Jonah Williams a1d3edc446
Twiggle bit to exclude dev and beta from desktop and web (#35221) 2019-06-27 19:04:02 -07:00
Jonah Williams b43b8bab94
Revert "Manual engine roll, Update goldens, improved wavy text decoration 0f9e297ad..185087a65f (#35066)" (#35237) 2019-06-27 18:38:40 -07:00
Jonah Williams 3d77923b39
fix coverage collection to un-red build (#35231) 2019-06-27 17:47:20 -07:00
Gary Qian 9c01d3a9cc
Manual engine roll, Update goldens, improved wavy text decoration 0f9e297ad..185087a65f (#35066) 2019-06-27 15:37:13 -07:00
Todd Volkert 04e2f22650
Force-upgrade package deps (#35206) 2019-06-27 14:02:23 -07:00
Jonah Williams c9b283386b
ensure test isolate is paused before collecting coverage (#35188) 2019-06-27 13:50:47 -07:00
Alexandre Ardhuin 919dcf53f3
enable lints prefer_spread_collections and prefer_inlined_adds (#35189) 2019-06-27 21:23:16 +02:00
Jonah Williams a0b2878e76
Make tool coverage collection resilient to sentinel coverage data (#35186) 2019-06-27 11:17:58 -07:00
Yegor c5f5b3c98a
Reuse matrix instance for transient transforms in _transformRect for fewer allocations (#35132) 2019-06-27 10:05:25 -07:00
rami-a 9166337698
Allow for customizing SnackBar's content TextStyle in its theme (#35075)
* Allow for customizing Snackbar's content TextStyle in its theme

* Address PR feedback

* Fix analyzer issues

* Address more PR feedback
2019-06-27 11:19:14 -04:00
Jonah Williams 8532f4d08e
Allow multi-root web builds (#34896)
* fix multiroot builds

* remove shout

* add basic test

* Update web_compilation_delegate.dart

* Address review feedback

* Update multiroot_asset_reader_test.dart

* Update multiroot_asset_reader_test.dart

* remove unpassable test

* fix for windows

* facepalm
2019-06-27 06:01:41 -07:00
Kasper b6349e7d9a Added onChanged property to TextFormField (#34932) 2019-06-26 18:13:53 -07:00
Todd Volkert 883d6eadcb
More HttpClientResponse implements Stream<Uint8List> fixes (#35149)
https://github.com/dart-lang/sdk/issues/36900
2019-06-26 16:56:10 -07:00
Todd Volkert d2c2f4c66b
More HttpClientResponse Uint8List fixes (#35143)
Follow-on change to https://github.com/flutter/flutter/pull/34863 (see that change
for context), whereby we ensure that we're properly dealing in `Uint8List`.

These necessary changes would have been caught by disabling implicit casts
in our analysis options.

dart-lang/sdk#36900
https://github.com/flutter/flutter/issues/13815
2019-06-26 16:11:04 -07:00
Jonah Williams 33ad5bac34
Attempt to enable tool coverage redux (#35074) 2019-06-26 16:02:49 -07:00
miDeb 6cebd350f5 Remove duplicate error parts (#34919) 2019-06-26 14:56:09 -07:00
Dan Field bb79ff3b49
More shards (#34877)
Shard tool_tests
2019-06-26 13:55:16 -07:00
Lau Ching Jun cfe4d0d7b9
Add FlutterProjectFactory so that it can be overridden internally. (#35092)
Also update the comments since we don't return Future<FlutterProject>
anymore.
2019-06-26 13:29:53 -07:00
Kate Lovett f9118c0fd0
Preserving SafeArea : Part 2 (#34298)
* WIP

* Added tests and updated SafeArea implementation.

* Analyzer nits

* Review feedback

* Updated for SnackBar and PersistentFooterButton cases, added tests to check other potential spots.

* doc addition for SafeArea

* Typos
2019-06-26 12:29:50 -07:00
Lau Ching Jun c8cefce300
Move findTargetDevices to DeviceManager (#35084)
This allows us to override the behavior internally.
2019-06-26 10:09:14 -07:00
Brian Egan 259151c39c
Add generated Icon diagram to api docs (#35046)
* Add generated Icon diagram to api docs
2019-06-26 18:16:16 +02:00
Danny Tuppeny f3be1d9d95
Add emulatorID field to devices in daemon (#34794)
* Add emulatorId to Android and iOS emulator devices

* Update docs

* Review tweaks

* Add tests for AndroidConsole for getting avd names

* Remove unused import

* Remove duplicated header

* Fix imports
2019-06-26 16:39:23 +01:00
Josh Burton 577c2fc48c Ensures flutter jar is added to all build types on plugin projects (#34573) 2019-06-25 10:40:55 -07:00
Alexandre Ardhuin c7408be181
prepare for lint update of prefer_final_fields (#35059) 2019-06-25 19:39:34 +02:00
Emmanuel Garcia 2cf8213468
Break down flutter doctor validations and results (#34624) 2019-06-25 10:22:08 -07:00
Alexandre Ardhuin b5ce06163c
enable lint use_full_hex_values_for_flutter_colors (#35056) 2019-06-25 17:58:19 +02:00
Alexandre Ardhuin fecf99ff1e
enable lint avoid_bool_literals_in_conditional_expressions (#35055) 2019-06-25 17:40:05 +02:00
LongCatIsLooong 326cd5e830
Add CupertinoTextField.onTap (#34964) 2019-06-24 21:02:53 -07:00
Shi-Hao Hong ea4460df3c
OutlineInputBorder adjusts for borderRadius that is too large (#34515)
* Implement OutlineInputBorder BorderRadius scaling via RRect.scaleRadii

* Add regression test to test for border scaling
2019-06-24 15:40:32 -07:00
Anthony a276ab3d6d
[Material] Properly call onChangeStart and onChangeEnd in Range Slider (#34869)
Fixes a bug in the Range Sider where the onChangeStart and onChangeEnd were not being called if the initial thumb selection came from a drag (rather than a tap).
2019-06-24 17:09:07 -04:00
Jonah Williams 25b5656969
Reland: rename web device (#34885) 2019-06-24 11:09:07 -07:00
Danny Tuppeny 8dbfc82bc7
Tweak the display name of emulators (#34785) 2019-06-24 11:41:02 +01:00
Todd Volkert bb6c3f8131
Remove flutter_tools support for old AOT snapshotting (#34895)
Android now exclusively uses ELF shared libraries, and
iOS uses assembly.
2019-06-22 19:30:24 -07:00
Todd Volkert e8270ff661
Prepare for HttpClientResponse Uint8List SDK change (#34863)
* Prepare for HttpClientResponse Uint8List SDK change

An upcoming change in the Dart SDK will change `HttpClientResponse`
from implementing `Stream<List<int>>` to instead implement
`Stream<Uint8List>`.

This forwards-compatible change to `_MockHttpClientResponse` is being
made to allow for a smooth rollout of that SDK breaking change. The
current structure of the class is as follows:

```dart
_MockHttpClientResponse extends Stream<List<int>> implements HttpClientResponse {
  ...
}
```

This structure would require that the Dart SDK change land atomically
a change to the class (`extends Stream<Uint8List>`). This atomic landing
requirement doesn't play well at all with Flutter's roll model vis-a-vis
the Dart SDK's roll model to Google's internal repo.  As such, this commit
changes the structure of `_MockHttpClientResponse` to be:

```dart
_MockHttpClientResponse implements HttpClientResponse {
  final Stream<Uint8List> _delegate;

  ...
}
```

Once the Dart SDK change has fully rolled out, we can simplify this class
back to its former structure.

https://github.com/dart-lang/sdk/issues/36900

* Review comment
2019-06-21 17:01:32 -07:00
Jonah Williams d644015620
Revert "set web device name to Chrome (#34856)" (#34884) 2019-06-21 15:04:44 -07:00
Jonah Williams 19d7925f1f
set web device name to Chrome (#34856) 2019-06-21 14:26:25 -07:00
Justin McCandless 63438b9244
Fix Vertical Alignment Regression (#34859)
Change the way outlined inputs vertically align their text to be more similar to how it used to be before a refactor. Fixes an edge case uncovered by a SCUBA test.
2019-06-21 11:24:54 -07:00
Jonah Williams 25a3121dfd
Prefer ephemeral devices from command line run (#34802) 2019-06-20 14:33:58 -07:00
Emily Fortuna bd9c900fce
Added some Widgets of the Week Videos to documentation (#34758)
* Added some Widgets of the Week to documentation: AspectRatio and AnimatedIcon.
2019-06-20 12:58:41 -07:00
Dan Field 71b9d461c8
Fix inline text span semantics (#34434) 2019-06-20 12:26:06 -07:00
Jason Simmons 300e8f842b
Remove flags related to dynamic patching (#34736) 2019-06-20 12:06:30 -07:00
Jacob Richman 38f849015c
Add more structure to errors messages. (#34684)
Breaking change to extremely rarely used ParentDataWidget.debugDescribeInvalidAncestorChain api changing the return type of the method from String to DiagnosticsNode.
2019-06-20 10:56:03 -07:00
Jenn Magder 1b176c5df1
Update Xcode projects to recommended Xcode 10 project settings (#34738) 2019-06-20 08:48:19 -07:00
Jenn Magder fa491fc9fe
Close platform when tests are complete (dispose compiler and delete font files) (#34685) 2019-06-20 08:47:54 -07:00
Jonah Williams b9932d55e7
Add linux doctor implementation (#34755) 2019-06-20 08:20:57 -07:00
Shi-Hao Hong 71254a6147
Custom height parameters for DataTable header and data rows (#33535)
* Custom dataRowHeight for DataTable and PaginatedDataTable

* Custom headingRowHeight for DataTable and PaginatedDataTable
2019-06-19 22:01:37 -07:00
Jonah Williams d7e53d4816
move hack flag to common (#34754) 2019-06-19 16:29:11 -07:00
Jonah Williams 830fb38640
Revert "Add basic desktop linux checks (#31873)" (#34753)
This reverts commit f221ad1f92.
2019-06-19 16:03:05 -07:00
Jonah Williams f221ad1f92
Add basic desktop linux checks (#31873) 2019-06-19 15:51:21 -07:00
Jonah Williams d4d10dac61
Revert "Check whether FLUTTER_ROOT and FLUTTER_ROOT/bin are writable. (#34291)" (#34750)
This reverts commit 49449505b6.
2019-06-19 15:37:04 -07:00
chunhtai c8c20fbc1f
add read only semantics flag (#34683) 2019-06-19 14:41:44 -07:00
Jonah Williams 0d9a1b201e
Remove environment variable guards for command line desktop and web (#33867) 2019-06-19 13:39:27 -07:00
Shi-Hao Hong 42d8383c9e
DataTable Custom Horizontal Padding (#33628)
* Add optional horizontalMargin and columnSpacing properties to DataTable

* Add horizontalMargin and columnSpacing tests for DataTable and PaginatedDataTable
2019-06-19 12:59:41 -07:00
Jim Graham e6f896e336
Adjust defaults in docs to match new defaults in code. (#34664)
(and fix grammar)

See: https://github.com/flutter/flutter/pull/21826
2019-06-19 12:55:44 -07:00
Yegor b15b5b90a0
Do not copy paths, rects, and rrects when layer offset is zero (#34587) 2019-06-19 12:32:12 -07:00
Jonah Williams 5d3efbde80
unpin build daemon (#34686) 2019-06-19 11:43:38 -07:00
Jonah Williams 7851a75183
Fix NPE in flutter tools (#34725) 2019-06-19 11:43:06 -07:00
Jonah Williams 0d4f4bddb6
Don't crash on invalid .packages file in initial run(#34527) 2019-06-19 10:52:23 -07:00
Jonah Williams 49449505b6
Check whether FLUTTER_ROOT and FLUTTER_ROOT/bin are writable. (#34291) 2019-06-19 09:12:43 -07:00
Danny Tuppeny d9983e1be7
Add category/platformType to emulators (#34721) 2019-06-19 17:10:39 +01:00
Justin McCandless b798b27bbd
Text field vertical align (#34355)
Adds the `textAlignVertical` param to TextField and InputDecorator, allowing arbitrary vertical positioning of text in its input.
2019-06-19 08:23:59 -07:00
Devon Carew 2b0c351880
fix a typo (#34584) 2019-06-19 07:26:10 -07:00
Haijun 91213e2ed6 fixed cupertinoTextField placeholder textAlign (#33739) 2019-06-18 23:36:40 -07:00
Emmanuel Garcia c50fa3d2bd Re-land config lib dependencies for flavors (#34668) 2019-06-18 22:37:42 -07:00
Michael Goderbauer 4f5d901395
Add Driver command to get diagnostics tree (#34440) 2019-06-18 18:31:21 -07:00
Michael Goderbauer b106fd0da9
Fix-up code sample for TweenSequence (#34679) 2019-06-18 18:30:34 -07:00
LongCatIsLooong 2602119194
Cupertino text edit tooltip rework (#34095) 2019-06-18 18:29:10 -07:00
Jonah Williams 7472fad194
Remove most of the target logic for build web, cleanup rules (#34589) 2019-06-18 17:04:11 -07:00
Emmanuel Garcia 9dbc66979a
Revert "Config lib dependencies when using flavors (#34592)" (#34655)
This reverts commit 358b9bd381.
2019-06-18 15:30:59 -07:00
chunhtai 9d38db421c
fix ExpansionPanelList merge the header semantics when it is not necessart (#33808) 2019-06-18 15:24:34 -07:00
chunhtai 00d95e6212
fix page scroll position rounding error (#34519) 2019-06-18 15:23:26 -07:00
Jonah Williams 5c52498d4e
Add device category, ephemeral, platformType for daemon (#33990) 2019-06-18 15:23:14 -07:00
Jonah Williams 73330e1241
Remove compilation trace and dynamic support code (#34529) 2019-06-18 15:22:04 -07:00
Kate Lovett 7d95e8e0c1
Splitting golden file versioning out as an argument of matchesGoldenFile (#33880)
* Splitting golden file versioning out as an argument of matchesGoldenFile

* Fixing description implementation.

* Removing unused imports

* Removing unused import

* Review feedback
2019-06-18 11:32:13 -07:00
Jenn Magder 8be46a0c4a
Kill compiler process when test does not exit cleanly (#34616) 2019-06-18 11:24:19 -07:00
stuartmorgan cc541e6724
Add missing pieces for 'driver' support on macOS (#34376)
- Adds desktop projects to ApplicationPackageStore
- Plumbs target overrides through the macOS build
2019-06-18 11:14:46 -07:00
Jason Simmons c19f78866d
Remove portions of the Gradle script related to dynamic patching (#34606) 2019-06-18 11:11:38 -07:00
Dan Field 4a60bee7c0
Release diagnostics (#34474)
Skip diagnostics on release mode, add test in firebase testlab
2019-06-18 11:06:09 -07:00
Emmanuel Garcia 358b9bd381
Config lib dependencies when using flavors (#34592) 2019-06-17 15:05:16 -07:00
Jonah Williams 5e467bda3a
Remove @protected annotation on ImageProvider.obtainKey (#34600) 2019-06-17 14:59:21 -07:00
Jonah Williams a772d4d314
retry on HttpException (#34526) 2019-06-17 10:48:01 -07:00
Emmanuel Garcia 09c09bf14b
Add back ability to override the local engine in Gradle (#34460) 2019-06-16 21:52:44 -07:00
Van Looveren Koen 60d2735e1a Added customizable padding for the segmented controll (#34555) 2019-06-16 14:58:04 -07:00
Josh Burton 07dc236237 Handles parsing APK manifests with additional namespaces or attributes (#34535) 2019-06-16 00:18:38 -07:00
Devon Carew 5f521eea22
add route information to Flutter.Navigation events (#34508)
* add route information to Flutter.Navigation events

* route can be null; re-work how we send route info to accomidate that
2019-06-15 20:40:34 -07:00
Jonah Williams dfa39f3ee5
Separate web and io implementations of network image (#34112)
* add web and io implemenations of network and asset image

* fix foundation import

* update to remove extra asset image indirection

* skip chunk test

* address comments

* disable non-functional test

* disable all golden tests

* address comments
2019-06-15 10:20:45 -07:00
Anthony 8b2ccca3a4
[Material] Fix TextDirection and selected thumb for RangeSliderThumbShape and RangeSliderValueIndicatorShape (#34501)
Expose the RangeSlider's TextDirection in the RangeSliderThumbShape's abstract paint() method, and ensure that start and end thumb are non-null when being passed to the thumb and value indicator shape paint methods.
2019-06-15 09:44:01 -04:00
Dan Field 3d58400e76
Revert "Revert "redux of a change to use new engine APIs for Flutter.Frame events (#34365)" (#34514)" (#34530)
This reverts commit 8f75d53735.
2019-06-15 00:01:35 -07:00
Dan Field 1427fef8f8
Make sure fab semantics end up on top (#34512) 2019-06-14 14:47:54 -07:00
Keerti Parthasarathy 8f75d53735
Revert "redux of a change to use new engine APIs for Flutter.Frame events (#34365)" (#34514)
This reverts commit ceb09b8bad.
2019-06-14 13:08:14 -07:00
Devon Carew ceb09b8bad
redux of a change to use new engine APIs for Flutter.Frame events (#34365) 2019-06-14 11:16:54 -07:00
Zachary Anderson dfecafa4ab
[flutter_tool,fuchsia] Update the install flow for packaging migration. (#34447) 2019-06-14 09:46:23 -07:00
Kate Lovett 81bbd3e12c
SliverFillRemaining flag for different use cases (#33627)
* WIP

* Fixing nested scroll view tests

* Fixing nested scroll view tests

* Fixing nested scroll view tests

* WIP

* Added flag for SliverFillRemaining

* Clean up

* Review

* Reverted nested scroll view tests

* Updating tests

* Updated for overscroll behavior
2019-06-14 09:44:57 -07:00
LongCatIsLooong ef1e64124d
SizedBox documentation (#34424) 2019-06-14 09:18:40 -07:00
Michael Thomsen 264de26572
Change API doc link to api.dart.dev (#34388) 2019-06-14 14:19:36 +02:00
LongCatIsLooong 731e9819e2
Allow "from" hero state to survive hero animation in a push transition (#32842) 2019-06-13 20:41:43 -07:00
Ian Hickson d310d31de3
Roll pub dependencies (#33677) 2019-06-13 18:07:16 -07:00
Todd Volkert 530824f423
Skip flaky test on Windows (#34464)
https://github.com/flutter/flutter/issues/34446
2019-06-13 17:56:07 -07:00
Jonah Williams f68bc1beb2
Dont depend on web SDK unless running tests on chrome (#34457) 2019-06-13 17:51:36 -07:00
Dan Field ea6b758720
Fix semantics_tester (#34368) 2019-06-13 16:15:00 -07:00
Michael Goderbauer 72828d66cf
Include raw value in Diagnostics json for basic types (#34417) 2019-06-13 16:14:14 -07:00
Emmanuel Garcia 1c6cda9a0d
Refactor Gradle plugin (#34353) 2019-06-13 16:05:28 -07:00
Jonah Williams 8c6841c738
skip bottom_sheet (#34430) 2019-06-13 12:23:18 -07:00
Emmanuel Garcia 2488c38931
Remove unused flag --target-platform from flutter run (#34369) 2019-06-13 11:47:42 -07:00
Michael Goderbauer eb9160eb93
Extract DiagnosticsNode serializer from WidgetInspector (#34012) 2019-06-13 11:30:18 -07:00
Jonah Williams aedf46afc7
Disable flaky tests (#34419) 2019-06-13 11:19:09 -07:00
Emmanuel Garcia afdc783ce5
Report commands that resulted in success or failure (#34288)
This is added as a dimension cd26
2019-06-13 10:27:23 -07:00
Zachary Anderson 3b42341aac
[flutter_tool,fuchsia] Prefetch tiles when starting an app (#34276) 2019-06-13 09:52:09 -07:00
Ian Hickson f31fc1bd0f More removing of timeouts. (#33932) 2019-06-12 23:12:35 -07:00
LongCatIsLooong 5f39487740
Don't show scrollbar if there isn't enough content (#34175) 2019-06-12 17:55:31 -07:00
Jonah Williams 3ae6abd9e8
Compatibility pass on flutter/material tests for JavaScript compilation. (9) (#33378) 2019-06-12 17:06:01 -07:00
chunhtai ad507723ec
fix Applying decoration for a table row widget will cause render exception (#34285) 2019-06-12 16:58:24 -07:00
Todd Volkert c40c687b2d
Add widget of the week videos (#34356)
* Spacer
* MediaQuery
* InheritedWidget
2019-06-12 16:36:09 -07:00
Todd Volkert 8163c0aebb
Re-apply compressionState changes. (#34341)
This re-applies the changes that were made in #33697 and #33729,
but which were reverted in #33792 and #33790, respectively due to
the Dart SDK not having received the update within Google yet.
The SDK has now rolled, so these changes can be re-applied.

https://github.com/flutter/flutter/issues/32374
https://github.com/flutter/flutter/issues/33791
2019-06-12 13:47:47 -07:00
Devon Carew 25c84001c4
Revert "update the Flutter.Frame event to use new engine APIs (#34243)" (#34352)
This reverts commit 446179f6c1.
2019-06-12 13:14:20 -07:00
Jenn Magder c40d701e96
Change Xcode project developmentRegion to 'en' and plist CFBundleDevelopmentRegion to DEVELOPMENT_LANGUAGE (#34293) 2019-06-12 11:31:17 -07:00
Devon Carew 446179f6c1
update the Flutter.Frame event to use new engine APIs (#34243)
* update the Flutter.Frame event to use new engine APIs

* add a test

* update test
2019-06-12 11:20:10 -07:00
Zachary Anderson 22ca3f96ca
[flutter_tool] Don't truncate verbose logs from _flutter.listViews (#34255) 2019-06-12 11:18:53 -07:00
Todd Volkert fb2f18e7e8
Prepare for Uint8List SDK breaking changes (#34295)
https://github.com/dart-lang/sdk/issues/36900
2019-06-12 10:22:50 -07:00
Jonah Williams 9d724d4c44
Compatibility pass on flutter/widgets tests for JavaScript compilation. (8) (#33377) 2019-06-11 14:51:03 -07:00
Emmanuel Garcia d9c1962973
Instrument usage of include_flutter.groovy and xcode_backend.sh (#34189)
This is done via `flutter build bundle`.   As a consequence, this PR introduces a new way to disable analytics via the `FLUTTER_SUPPRESS_ANALYTICS` env flag.
2019-06-11 14:46:00 -07:00
LongCatIsLooong 1eb8c640bb
Fix CupertinoTabScaffold index out of range (#33624) 2019-06-11 14:14:54 -07:00
Jason Simmons 89d887f331
Strip debug symbols from ELF library snapshots (#34250)
AOT compiled code is now packaged as an ELF library for Android targets.
By default gen_snapshot's output contains debug symbols.  The symbols could
be stripped as a separate step, but that requires NDK tools that the user
may not have available.

This change passes a gen_snapshot flag that omits the symbols, and it filters
out a warning printed when that flag is used.
2019-06-11 13:34:24 -07:00
Ben Konyi e59d9a815d
Reland "Added --dart-flags option to flutter run (#33924)" (#34181)
Reland "Added --dart-flags option to flutter run (#33924)"

This reverts commit 587687eedf.
2019-06-11 11:37:47 -07:00
guoskyhero 1bc8402478 Add hintStyle in SearchDelegate (#30388)
SearchDelegate hintStyle parameter
2019-06-11 11:15:50 -07:00
Jonah Williams 7feddfdec0
make sure this test doesnt run for real (#34199) 2019-06-11 10:35:10 -07:00
Neevash Ramdial d850d69c3f Added tool sample for PageController (#34137)
* Added tool sample for PageController

* Fixed text directionality bug
2019-06-11 09:57:17 -07:00
Jonah Williams 05e92c828b
Compatibility pass on flutter/physics tests for JavaScript compilation. (6) (#33359) 2019-06-11 09:09:13 -07:00
LongCatIsLooong e9ca112e44
update CupertinoDialogAction isDefaultAction documentation (#34163) 2019-06-10 19:17:55 -07:00
Jonah Williams ca14af6b92
Compatibility pass on flutter/rendering tests for JavaScript compilation. (5) (#33355) 2019-06-10 17:29:46 -07:00
Todd Volkert 1b3fc53595
Consider all non-interactive terminals to be bots (#34179) 2019-06-10 16:32:08 -07:00
Anthony 0bbac72558
[Material] Fix slider track shape to rounded (#34178)
The slider track shape for the onPrimaryColors constructor should be rounded, but it was accidentally changed to rectangular in #31681. This change restores the original behavior. This only affects sliders that are themed with SliderThemeData.onPrimaryColors().
2019-06-10 19:02:44 -04:00
Jonah Williams c88f64ed50
Compatibility pass on flutter/services tests for JavaScript compilation. (4) (#33354) 2019-06-10 15:46:36 -07:00
Jonah Williams f530b809b6
Reland: More verification on flutter build web, add tests and cleanup (#34173) 2019-06-10 15:37:23 -07:00
Jenn Magder c8bf7abeee
Disable CocoaPods input and output paths in Xcode build phase and adopt new Xcode build system (#34167)
Updates the Podfile template to use the CocoaPod disable_input_output_paths installation option which prevents the [CP] Embed Pods Frameworks build phase from outputting the Flutter.framework files.
2019-06-10 14:30:28 -07:00
Jonah Williams c05fa894e6
Compatibility pass on flutter/painting tests for JavaScript compilation. (3) (#33352) 2019-06-10 14:05:51 -07:00
Emmanuel Garcia 8627ff433b
Allow multi-abi shared libraries in APKs and App bundles (#34123)
* Gradle generates ELF shared libraries instead of AOT snapshots.
* `flutter build apk/appbundle` supports multiple `--target-platform` and defaults to `android-arm` and `android-arm64`.
* `flutter build apk` now has a flag called `--split-per-abi`.
2019-06-10 13:16:09 -07:00
Jonah Williams 71bfe3be9f
Revert "More verification on flutter build web, add tests and cleanup (#34090)" (#34166) 2019-06-10 12:01:14 -07:00
Jonah Williams 354ce1aa5a
More verification on flutter build web, add tests and cleanup (#34090) 2019-06-10 11:27:25 -07:00
Jonah Williams 980a574d4c
Compatibility pass on flutter/scheduler tests for JavaScript compilation. (2) (#33350) 2019-06-10 10:17:53 -07:00
Jonah Williams 392e825b24
Use product define for flutter web and remove extra asset server (#34159) 2019-06-10 09:54:02 -07:00
Alexander Aprelev d91797807e
Report async callback errors that currently go unreported. (#34081)
* Report async callback errors that currently go unreported.
* Add a test
2019-06-10 09:52:22 -07:00
chunhtai 38a5bbb44e
fix empty selection arrow when double clicked on empty read only textfield in ios (#34068) 2019-06-10 09:19:41 -07:00
Kate Lovett 991da4f77f
Updating MediaQuery with viewPadding (#33999)
* Updating MediaQuery with viewPadding

* Added tests

* Fixed test

* Updating remove logic & tests

* Diagram and documentation

* Review feedback
2019-06-10 09:10:24 -07:00
Justin McCandless ce4f15cd69
Toggle toolbar exception fix (#34055)
Stop a text editing error from happening
2019-06-10 08:06:24 -07:00
Jonah Williams 7f7c00a4e9
Enable web foundation tests (#34032) 2019-06-09 11:03:46 -07:00
Jonah Williams f8f7b89976
Revert "Generate ELF shared libraries and allow multi-abi libs in APKs and App bundles (#33696)" (#34121) 2019-06-08 18:43:25 -07:00
Emmanuel Garcia 966b15b4a4
Generate ELF shared libraries and allow multi-abi libs in APKs and App bundles (#33696)
* Gradle generates ELF shared libraries instead of AOT snapshots.
* `flutter build apk/appbundle` supports multiple `--target-platform` and defaults to `android-arm` and `android-arm64`.
*  `flutter build apk` now has a flag called `--split-per-abi`.
2019-06-08 18:02:32 -07:00
Jonah Williams 587687eedf
Revert "Added --dart-flags option to flutter run (#33924)" (#34092) 2019-06-07 19:33:14 -07:00
Ben Konyi 67a529b895
Added --dart-flags option to flutter run (#33924) 2019-06-07 18:53:42 -07:00
Shi-Hao Hong d3c864de06
Add endIndent property to Divider and VerticalDivider (#34057)
* Fixed indent to properly add to the top and not to the start

* Updated Divider documentation
2019-06-07 18:32:17 -07:00
Jonah Williams 8896f48c0f
make running on web spooky (#34084) 2019-06-07 18:17:04 -07:00
Jonah Williams 317e4cb013
don't warn on CHROME_EXECUTABLE missing if we've already located it. (#34079) 2019-06-07 18:16:54 -07:00
Gary Qian 938e4eb636
Add recognizer compatibility API (#34086) 2019-06-07 18:14:54 -07:00
Josh Burton 9223a44b8a Adds the androidX flag to a modules pubspec.yaml template so it is se… (#34066)
This is a small follow up to the previous AndroidX PR: https://github.com/flutter/flutter/pull/31028

This fixes an issue mentioned [here](https://github.com/flutter/flutter/issues/28805) where the androidX flag for a module is not set when creating a new project:

`flutter create --androidx -t module my_flutter`
2019-06-07 16:09:21 -07:00
Christopher Fujino 10d8758b2f
add analytics fields for attached device os version & run mode (#34074)
Adds two new custom analytics dimensions: run_target_os_version and run_target_mode_name that are sent with each invocation of flutter run and show up in Google Analytics as "screens".
2019-06-07 16:03:53 -07:00
Gary Qian c2eaf8359d
Reland "Text inline widgets, TextSpan rework (#30069)" with improved backwards compatibility (#34051) 2019-06-07 15:47:23 -07:00
Michael Goderbauer 4cc6880cb2
Remove unused/dead code from Diagnostics (#33996) 2019-06-07 15:07:41 -07:00
Zachary Anderson b847ba5a63
[flutter_tool] Send build timing to analytics (#34049) 2019-06-07 13:50:45 -07:00
Jonah Williams bd413bff1b
Add flutter create for the web (#34018) 2019-06-07 13:15:38 -07:00
Jonah Williams ef5fc1ae65
limit open files on macOS when copying assets (#34050) 2019-06-07 12:59:33 -07:00