Andrew Kolos
c05dc3e68e
[Reland] Fix flavors test install checks ( #134060 )
...
Reland of https://github.com/flutter/flutter/pull/133719 . Updates [the string comparison in flavor_test.dart](https://github.com/flutter/flutter/pull/134060/files#diff-53383b32b975bfed6875306dfb98911cad077a5251ca0591c5b0e125fb4a0f05R39 ) to use `path.join` to build the path string so that the generated path is correct for both Linux and Windows hosts.
Fixes https://github.com/flutter/flutter/issues/133713
I've tested this on a Windows host targeting a physical Android device.
2023-09-05 18:55:23 +00:00
engine-flutter-autoroll
2251063233
Manual roll Flutter Engine from fbc6f4a54047 to 1a6b47af3eb0 (12 revisions) ( #134049 )
...
Manual roll requested by zra@google.com
fbc6f4a540...1a6b47af3eskia-flutter-autoroll@skia.org Roll Dart SDK from
671cf059e4b6 to 43d4b1373788 (2 revisions) (flutter/engine#45435 )
2023-09-04 skia-flutter-autoroll@skia.org Roll Skia from c9d527e6b535 to
8206402f3c35 (1 revision) (flutter/engine#45434 )
2023-09-04 robert.ancell@canonical.com Fix building on Pango 1.49.4
(flutter/engine#45098 )
2023-09-04 skia-flutter-autoroll@skia.org Roll Dart SDK from
a5c7102af509 to 671cf059e4b6 (1 revision) (flutter/engine#45429 )
2023-09-04 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from
ynBQWN3XpE2JvSlfd... to A82pOZ3-NNgfJ2Da7... (flutter/engine#45428 )
2023-09-04 skia-flutter-autoroll@skia.org Roll ANGLE from 1fb536394148
to ab9bbb9b11b3 (1 revision) (flutter/engine#45426 )
2023-09-04 skia-flutter-autoroll@skia.org Roll Skia from 5eaf624077b5 to
c9d527e6b535 (1 revision) (flutter/engine#45425 )
2023-09-04 skia-flutter-autoroll@skia.org Roll ANGLE from ebf1e7163216
to 1fb536394148 (1 revision) (flutter/engine#45424 )
2023-09-04 skia-flutter-autoroll@skia.org Roll Skia from 906dcd219276 to
5eaf624077b5 (1 revision) (flutter/engine#45423 )
2023-09-04 skia-flutter-autoroll@skia.org Roll Skia from 4d0501380011 to
906dcd219276 (1 revision) (flutter/engine#45422 )
2023-09-04 skia-flutter-autoroll@skia.org Roll Skia from 15f77147a3ec to
4d0501380011 (1 revision) (flutter/engine#45421 )
2023-09-04 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from
p56hmQk2lEbN-VwEg... to ynBQWN3XpE2JvSlfd... (flutter/engine#45420 )
Also rolling transitive DEPS:
fuchsia/sdk/core/mac-amd64 from p56hmQk2lEbN to A82pOZ3-NNgf
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com ,zra@google.com on the revert to ensure that
a human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-09-05 11:51:56 -07:00
Polina Cherkasova
cb0a613ec6
SegmentedButton should not create new MaterialStatesController in every build. ( #133949 )
2023-09-05 11:00:22 -07:00
Christopher Fujino
85bece2689
[flutter_tools] Fix TypeError when a FileSystemException happens during flutter doctor ( #133373 )
...
Fixes https://github.com/flutter/flutter/issues/133086
2023-09-05 18:00:07 +00:00
Greg Spencer
6eca007a81
Fix links in top level README ( #133893 )
...
## Description
This fixes the top level links to the platform embedders in the README that is used to create the landing page on https://master-api.flutter.dev
2023-09-05 17:00:22 +00:00
Renzo Olivares
ef9befc9da
Reland leak fix for EditableTextState ( #133806 )
...
Relands: https://github.com/flutter/flutter/pull/131377
Reverted in: https://github.com/flutter/flutter/pull/133804
2023-09-03 18:23:20 +00:00
engine-flutter-autoroll
96621ebf0f
Roll Flutter Engine from 020776662e92 to fbc6f4a54047 (1 revision) ( #133935 )
...
020776662e...fbc6f4a540skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from E7CUB2EEOm7ShBUib... to p56hmQk2lEbN-VwEg... (flutter/engine#45419 )
Also rolling transitive DEPS:
fuchsia/sdk/core/mac-amd64 from E7CUB2EEOm7S to p56hmQk2lEbN
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC aaclarke@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-09-03 14:04:33 +00:00
engine-flutter-autoroll
c67e6df16b
Roll Flutter Engine from e496eec40e21 to 020776662e92 (1 revision) ( #133926 )
...
e496eec40e...020776662eskia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from MesZPNdj-uw8VdCyV... to E7CUB2EEOm7ShBUib... (flutter/engine#45417 )
Also rolling transitive DEPS:
fuchsia/sdk/core/mac-amd64 from MesZPNdj-uw8 to E7CUB2EEOm7S
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC aaclarke@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-09-03 03:22:24 +00:00
engine-flutter-autoroll
da51c6c718
Manual roll Flutter Engine from 489c399e3dc6 to e496eec40e21 (26 revisions) ( #133924 )
...
Manual roll requested by zra@google.com
489c399e3d...e496eec40eskia-flutter-autoroll@skia.org Roll Skia from 2d8849f9f0cc to 15f77147a3ec (1 revision) (flutter/engine#45414 )
2023-09-02 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from OF4TS05qlWCjukWw6... to MesZPNdj-uw8VdCyV... (flutter/engine#45413 )
2023-09-02 dkwingsmt@users.noreply.github.com Remove --disable-service-auth-codes (flutter/engine#45356 )
2023-09-02 bdero@google.com [Impeller] Import cstring for memcpy. (flutter/engine#45408 )
2023-09-02 skia-flutter-autoroll@skia.org Roll Dart SDK from cdf1ce0c6d7e to a5c7102af509 (1 revision) (flutter/engine#45412 )
2023-09-02 skia-flutter-autoroll@skia.org Roll ANGLE from 179bd7762ffa to ebf1e7163216 (1 revision) (flutter/engine#45411 )
2023-09-02 dkwingsmt@users.noreply.github.com Remove deprecated MOCK_METHODx calls (flutter/engine#45307 )
2023-09-02 jonahwilliams@google.com [Impeller] Better demonstrate blur and draw picture? (flutter/engine#45388 )
2023-09-02 jonahwilliams@google.com [Impeller] Make paths externally immutable, update all tests to use PathBuilder to create Path. (flutter/engine#45393 )
2023-09-02 skia-flutter-autoroll@skia.org Roll ANGLE from 962fdf7b7882 to 179bd7762ffa (1 revision) (flutter/engine#45409 )
2023-09-02 flar@google.com Cull the RTree bounds when they are forwarded in DrawDisplayList (flutter/engine#45358 )
2023-09-02 skia-flutter-autoroll@skia.org Roll Skia from fedff79a6afc to 2d8849f9f0cc (3 revisions) (flutter/engine#45407 )
2023-09-02 jonahwilliams@google.com [impeller] premultiply vertices colors. (flutter/engine#45406 )
2023-09-01 skia-flutter-autoroll@skia.org Roll ANGLE from 6a09e41ce6ea to 962fdf7b7882 (224 revisions) (flutter/engine#45400 )
2023-09-01 skia-flutter-autoroll@skia.org Roll Skia from 22ae23891e8e to fedff79a6afc (1 revision) (flutter/engine#45405 )
2023-09-01 30870216+gaaclarke@users.noreply.github.com [Impeller] turned on validations for all debug builds (flutter/engine#45350 )
2023-09-01 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from sk7JBGzW1Jw10Wy-T... to OF4TS05qlWCjukWw6... (flutter/engine#45403 )
2023-09-01 skia-flutter-autoroll@skia.org Roll Skia from 2c0405489966 to 22ae23891e8e (1 revision) (flutter/engine#45402 )
2023-09-01 737941+loic-sharma@users.noreply.github.com [Windows] Update vsync on raster thread (flutter/engine#45310 )
2023-09-01 skia-flutter-autoroll@skia.org Roll Dart SDK from a2ea759c16cc to cdf1ce0c6d7e (1 revision) (flutter/engine#45397 )
2023-09-01 skia-flutter-autoroll@skia.org Roll Skia from f3f6c733c7e6 to 2c0405489966 (1 revision) (flutter/engine#45396 )
2023-09-01 skia-flutter-autoroll@skia.org Roll Skia from 02fa14799c6c to f3f6c733c7e6 (1 revision) (flutter/engine#45394 )
2023-09-01 skia-flutter-autoroll@skia.org Roll Skia from d5d3b0d4ee77 to 02fa14799c6c (2 revisions) (flutter/engine#45392 )
2023-09-01 41930132+hellohuanlin@users.noreply.github.com [ios][ios17][text_input]fix text input system highlight in iOS 17 Beta 7 with firstRectForRange (flutter/engine#45303 )
2023-09-01 skia-flutter-autoroll@skia.org Roll Skia from d6266ef14a7e to d5d3b0d4ee77 (2 revisions) (flutter/engine#45389 )
2023-09-01 skia-flutter-autoroll@skia.org Roll Dart SDK from 0c121a6431cc to a2ea759c16cc (1 revision) (flutter/engine#45384 )
Also rolling transitive DEPS:
fuchsia/sdk/core/mac-amd64 from sk7JBGzW1Jw1 to MesZPNdj-uw8
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC aaclarke@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-09-02 20:40:36 +00:00
Zachary Anderson
3896912d44
Fix for new analyzer lint ( #133923 )
...
For https://github.com/flutter/flutter/issues/133922
2023-09-02 12:47:28 -07:00
engine-flutter-autoroll
685ce14b2d
Roll Flutter Engine from d00b69a438a6 to 489c399e3dc6 (3 revisions) ( #133879 )
...
d00b69a438...489c399e3dmatanlurey@users.noreply.github.com Update (flipping the default from false -> true) and deprecate Paint.enableDithering. (flutter/engine#44705 )
2023-09-01 jonahwilliams@google.com [Impeller] EntityPass::Clone needs to clone harder (flutter/engine#45313 )
2023-09-01 ychris@google.com Reland "ios: remove shared_application and support app extension build #44732 " (flutter/engine#45351 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC aaclarke@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-09-02 13:38:32 +00:00
Polina Cherkasova
248645a2b2
RestorableProperty should dispatch creation in constructor. ( #133883 )
2023-09-01 17:59:25 -07:00
Polina Cherkasova
a3362a9ff8
MaterialStatesController should dispatch creation in constructor. ( #133826 )
...
This PR also updates other tests to use matcher.
2023-09-01 17:29:47 -07:00
Polina Cherkasova
80f737d1e0
Mark leak in _DayPickerState. ( #133863 )
2023-09-01 17:10:41 -07:00
Loïc Sharma
df8ee8d63a
[Windows Arm64] Add first device lab test ( #133895 )
...
Adds the first Windows Arm64 devicelab test. The builder for this test won't be created until after this lands on master, so we can't actually test this until this is merged.
2023-09-01 23:55:36 +00:00
Victoria Ashworth
5649161bd7
Revert "fix install checks in flavors devicelab tests" ( #133894 )
...
Reverts flutter/flutter#133719
`Windows_android flavors_test_win` failed twice in a row in the tree
2023-09-01 22:17:48 +00:00
Renzo Olivares
b1f691c9fc
Remove deprecated TestWindow.platformBrightnessTestValue/TestWindow.clearPlatformBrightnessTestValue ( #133178 )
...
Part of: https://github.com/flutter/flutter/issues/133171
2023-09-01 20:35:58 +00:00
Andrew Kolos
a66eae17a2
fix install checks in flavors devicelab tests ( #133719 )
...
Fixes #133713
2023-09-01 20:32:50 +00:00
Renzo Olivares
959cdb79fb
Remove deprecated TestWindow.textScaleFactorTestValue/TestWindow.clearTextScaleFactorTestValue ( #133176 )
...
Part of: https://github.com/flutter/flutter/issues/133171
2023-09-01 20:31:16 +00:00
engine-flutter-autoroll
8cbf42a7d9
Roll Flutter Engine from ddd03f863897 to d00b69a438a6 (2 revisions) ( #133873 )
...
ddd03f8638...d00b69a438skia-flutter-autoroll@skia.org Roll ICU from de4ce0071eb4 to 985b9a6f70e1 (2 revisions) (flutter/engine#45382 )
2023-09-01 brianosman@google.com Migrate Fuchsia VK calls of GrBackend* (flutter/engine#45380 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC aaclarke@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-09-01 17:35:13 +00:00
Gray Mackall
033274c66a
Change android_virtual_device to version 34 ( #133809 )
...
Change from AVD 33 to [AVD 34](https://chrome-infra-packages.appspot.com/p/chromium/tools/android/avd/linux-amd64 ) in CI. Only affects two tests.
We should also update the firebase virtual and physical devices when 34 is available there (for example [here](e98d3929ca/.ci.yaml (L441)
2023-09-01 16:48:20 +00:00
Victoria Ashworth
37c55bab2c
Run Mac_arm64_ios run_debug_test_macos in presubmit ( #133869 )
...
Reland https://github.com/flutter/flutter/pull/133788 .
Fixes https://github.com/flutter/flutter/issues/118830 .
Fixes https://github.com/flutter/flutter/issues/125342 .
2023-09-01 16:20:46 +00:00
engine-flutter-autoroll
16b9e77070
Roll Flutter Engine from 4c085b883d6f to ddd03f863897 (1 revision) ( #133868 )
...
4c085b883d...ddd03f8638skia-flutter-autoroll@skia.org Roll Skia from 4eb9b17d8e84 to d6266ef14a7e (1 revision) (flutter/engine#45376 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC aaclarke@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-09-01 16:14:59 +00:00
Polina Cherkasova
78ff1226c9
Test cover more tests with leak tracking. ( #133828 )
2023-09-01 08:53:53 -07:00
chunhtai
0f3bd90d9b
Adds a parent scope TraversalEdgeBehavior and fixes modal route to no… ( #130841 )
...
…t trap the focus
fixes https://github.com/flutter/flutter/issues/112567
Several things I done:
1. add new enum `parentScope`
2. refactor _sortAllDescendants so that it doesn't recursively looking
into its descendant when it encounter a FocusScopeNode.
3. When the nextFocus try to focus into a FocusScopeNode, it will try to
find the first focusable FocusNode in traversal order and focus it
instead if it doesn't have a first focus.
4. Change the default in Navigator to always be `parentScope`
5. Only the root navigator will use `leaveFlutterView` if platform is
web.
Previously 2 and 3 are not needed because once a focusscope trapped the
focus, there isn't a chance where the parent focusscope have to deal
with next focus.
If we don't do 2 and 3 after the change, it will cause it to stuck in
the current scope again. Because once the focus leave the current scope,
it needs to also remove the first focus in that scope (so that it can
start fresh when focus traversal back to the scope in the future). At
this point the current scope will have the primary focus without the
first focus. The parent scope will then try to find the next focus, and
it will place the focus to the first traversal child in the current
scope again.
## Pre-launch Checklist
- [ ] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [ ] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [ ] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [ ] I signed the [CLA].
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [ ] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [ ] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
2023-09-01 08:37:38 -07:00
Mark O'Sullivan
1b1c8a1607
Fixed PaginatedDataTable not using dataRowMinHeight and dataRowMaxHeight from Theme ( #133634 )
...
`PaginatedDataTable` will now make use of `dataRowMinHeight` and `dataRowMaxHeight` from the Theme
*List which issues are fixed by this PR. You must list at least one issue.*
Resolves #133633
2023-09-01 15:36:48 +00:00
engine-flutter-autoroll
eb77b525c2
Roll Flutter Engine from ced8f1a71206 to 4c085b883d6f (2 revisions) ( #133857 )
...
ced8f1a712...4c085b883dskia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from _x3hf702RacYnw3E6... to sk7JBGzW1Jw10Wy-T... (flutter/engine#45372 )
2023-09-01 leroux_bruno@yahoo.fr [Linux] Fix channel buffers control commands error handling (flutter/engine#45056 )
Also rolling transitive DEPS:
fuchsia/sdk/core/mac-amd64 from _x3hf702RacY to sk7JBGzW1Jw1
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC aaclarke@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-09-01 14:43:24 +00:00
Bruno Leroux
e326199923
Add more documentation for SystemChannels.keyboard getKeyboardState ( #133663 )
...
## Description
This PR adds some documentation to SystemChannels.keyboard getKeyboardState.
This method was added in https://github.com/flutter/flutter/pull/122885 .
## Related Issue
Fixes https://github.com/flutter/flutter/issues/132938 .
## Tests
Documentation only.
2023-09-01 09:24:33 +00:00
Bruno Leroux
510ecaa4e7
Fix MaterialState.pressed is missing when pressing button with keyboard ( #133558 )
...
## Description
This PR fixes changes how `InkWell` reacts to keyboard activation.
**Before**: the activation started a splash and immediately terminated it which did not let time for widgets that resolve material state properties to react (visually it also mean the splash does not have time to expand).
**After**: the activation starts and terminates after a delay (I arbitrary choose 200ms for the moment).
## Related Issue
Fixes https://github.com/flutter/flutter/issues/132377 .
## Tests
Adds one test.
2023-09-01 09:08:21 +00:00
engine-flutter-autoroll
f0b682bc05
Roll Flutter Engine from 09cb3d99f24e to ced8f1a71206 (1 revision) ( #133844 )
...
09cb3d99f2...ced8f1a712skia-flutter-autoroll@skia.org Roll Skia from 6d95a1db276d to 4eb9b17d8e84 (1 revision) (flutter/engine#45369 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC aaclarke@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-09-01 08:43:11 +00:00
engine-flutter-autoroll
c141126df0
Roll Flutter Engine from 0769aba5b7d8 to 09cb3d99f24e (1 revision) ( #133842 )
...
0769aba5b7...09cb3d99f2skia-flutter-autoroll@skia.org Roll Skia from 2916365d0fa6 to 6d95a1db276d (1 revision) (flutter/engine#45368 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC aaclarke@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-09-01 07:45:52 +00:00
engine-flutter-autoroll
4324d2112e
Roll Flutter Engine from a9ebed54c451 to 0769aba5b7d8 (2 revisions) ( #133839 )
...
a9ebed54c4...0769aba5b7skia-flutter-autoroll@skia.org Roll Skia from e585fdc18134 to 2916365d0fa6 (1 revision) (flutter/engine#45366 )
2023-09-01 jonahwilliams@google.com [Impeller] use correct blend mode for performance overlay (flutter/engine#45365 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC aaclarke@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-09-01 06:45:32 +00:00
engine-flutter-autoroll
e9448fdf61
Roll Flutter Engine from 01e74b252ee0 to a9ebed54c451 (2 revisions) ( #133831 )
...
01e74b252e...a9ebed54c4skia-flutter-autoroll@skia.org Roll Skia from 818f20f3f653 to e585fdc18134 (1 revision) (flutter/engine#45363 )
2023-09-01 skia-flutter-autoroll@skia.org Roll Dart SDK from 9f9bd8cddfb0 to 0c121a6431cc (1 revision) (flutter/engine#45362 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC aaclarke@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-09-01 03:49:06 +00:00
engine-flutter-autoroll
a3a651d822
Roll Flutter Engine from f28eb11e5bd4 to 01e74b252ee0 (1 revision) ( #133830 )
...
f28eb11e5b...01e74b252ebdero@google.com Bump impeller-cmake-example to head (flutter/engine#45359 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC aaclarke@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-09-01 03:04:18 +00:00
engine-flutter-autoroll
0a305bbc54
Roll Flutter Engine from 494fd7fe85a3 to f28eb11e5bd4 (1 revision) ( #133825 )
...
494fd7fe85...f28eb11e5bjonahwilliams@google.com [Impeller] copy data out of DlVertices. (flutter/engine#45355 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC aaclarke@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-09-01 01:41:28 +00:00
engine-flutter-autoroll
d67ec7c771
Roll Flutter Engine from b867c4da54cc to 494fd7fe85a3 (1 revision) ( #133823 )
...
b867c4da54...494fd7fe85skia-flutter-autoroll@skia.org Roll Skia from e1b27dcecd0a to 818f20f3f653 (2 revisions) (flutter/engine#45353 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC aaclarke@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-09-01 00:47:40 +00:00
Andrea Cioni
400702d1d6
Add an example for InputChip generated by user input ( #130645 )
...
New example for `InputChip` that demonstrate how to create/delete them based on user text inputs.
The sample application shows a custom text area where user can enter text. After the user has typed and hits _Enter_ the text will be replaced with an `InputChip` that contains that text. Is it possible to continue typing and add more chips in this way. All of them will be placed in a scrollable horizontal row. Also is it possible to have suggestion displayed below the text input field in case the typed text match some of the available suggestions.
Issue I'm trying to solve:
- https://github.com/flutter/flutter/issues/128247
**Code structure:**
The example app is composed of 2 main components that find places inside `MainScreen`:
- `ChipsInput`
- `ListView`
`ChipsInput` emulates a `TextField` where you can enter text. This text field accepts also a list of values of generic type T (`Topping` in my example), that gets rendered as `InputChip` inside the text field, before the text inserted by the user. This widgets is basically an `InputDecorator` widget that implements `TextInputClient` to get `TextEditingValue` events from the user keyboard. At the end of the input field there is another component, the `TextCursor`, that is displayed just when the user give the focus to the field and emulates the carrets that `TextField` has.
There are also some available callbacks that the user can use to capture events in the `ChipsInput` field like: `onChanged`, `onChipTapped`, `onSubmitted` and `onTextChanged`. This last callback is used to build a list of suggestion that will be placed just below the `ChipsInput` field inside the `ListView`.
2023-09-01 00:02:04 +00:00
engine-flutter-autoroll
62fb15a636
Roll Flutter Engine from 10e2df60b053 to b867c4da54cc (3 revisions) ( #133820 )
...
10e2df60b0...b867c4da54sra@google.com [web] More efficient fallback font selection (flutter/engine#44526 )
2023-08-31 skia-flutter-autoroll@skia.org Roll Dart SDK from ac3bc9f6351a to 9f9bd8cddfb0 (1 revision) (flutter/engine#45352 )
2023-08-31 skia-flutter-autoroll@skia.org Roll Skia from bf6b239838d3 to e1b27dcecd0a (1 revision) (flutter/engine#45349 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC aaclarke@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-08-31 23:58:05 +00:00
Kate Lovett
cf051e7db2
Fix clipBehavior ignored in Scrollable of SingleChildScrollView ( #133696 )
...
Fixes https://github.com/flutter/flutter/issues/133330
The clipBehavior was not passed to the underlying Scrollable, which informs things like the clip on the StretchingOverscrollIndicator.
2023-08-31 23:50:39 +00:00
Polina Cherkasova
956999a4b9
Make Route dispatching memory events. ( #133721 )
2023-08-31 16:23:44 -07:00
engine-flutter-autoroll
727b9fd106
Roll Flutter Engine from ca513c999257 to 10e2df60b053 (3 revisions) ( #133815 )
...
ca513c9992...10e2df60b0ian@hixie.ch Avoid saying exactly who can give test exemptions (flutter/engine#45343 )
2023-08-31 skia-flutter-autoroll@skia.org Roll Skia from 5d08dadd2ef4 to bf6b239838d3 (1 revision) (flutter/engine#45344 )
2023-08-31 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from 7sFO_YvenNXCm6TdK... to _x3hf702RacYnw3E6... (flutter/engine#45348 )
Also rolling transitive DEPS:
fuchsia/sdk/core/mac-amd64 from 7sFO_YvenNXC to _x3hf702RacY
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC aaclarke@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-08-31 23:20:25 +00:00
Kate Lovett
5b6d748cb4
Fix sample code crash, add test ( #133812 )
...
Fixes https://github.com/flutter/flutter/issues/133402
On web `1 << 32` crashes, 31 is the maximum.
2023-08-31 22:56:06 +00:00
engine-flutter-autoroll
7ade163885
Roll Flutter Engine from 51090e3cfe79 to ca513c999257 (15 revisions) ( #133810 )
...
51090e3cfe...ca513c9992zanderso@users.noreply.github.com Revert "Reland "Build iOS unittest target in unopt builds" (#44356 )"" (flutter/engine#45346 )
2023-08-31 flar@google.com Lazily allocate RasterCacheItems only when caching is enabled (flutter/engine#45211 )
2023-08-31 skia-flutter-autoroll@skia.org Roll Skia from 8ff4fd208c26 to 5d08dadd2ef4 (3 revisions) (flutter/engine#45340 )
2023-08-31 ychris@google.com Reland "Build iOS unittest target in unopt builds" (#44356 )" (flutter/engine#44821 )
2023-08-31 yousefi@google.com Update comment const_finder.dart (flutter/engine#45180 )
2023-08-31 dkwingsmt@users.noreply.github.com Replace an unnecessary util function with PostSync (flutter/engine#45190 )
2023-08-31 skia-flutter-autoroll@skia.org Roll Skia from cda0cfaadfd7 to 8ff4fd208c26 (3 revisions) (flutter/engine#45337 )
2023-08-31 skia-flutter-autoroll@skia.org Roll Dart SDK from 0cea73a8d3c3 to ac3bc9f6351a (4 revisions) (flutter/engine#45336 )
2023-08-31 chris@bracken.jp [macOS] Link __availability_version_check (flutter/engine#45333 )
2023-08-31 skia-flutter-autoroll@skia.org Roll Skia from 8c05d5103d6b to cda0cfaadfd7 (3 revisions) (flutter/engine#45334 )
2023-08-31 zanderso@users.noreply.github.com Adds an --rbe option to tools/gn that works on Linux hosts (flutter/engine#45271 )
2023-08-31 brianosman@google.com Migrate VK calls of GrBackend* (flutter/engine#45325 )
2023-08-31 zanderso@users.noreply.github.com Roll buildroot (flutter/engine#45329 )
2023-08-31 zanderso@users.noreply.github.com Revert dl split (flutter/engine#45326 )
2023-08-31 skia-flutter-autoroll@skia.org Roll Skia from d113402de2ce to 8c05d5103d6b (4 revisions) (flutter/engine#45331 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC aaclarke@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-08-31 22:25:02 +00:00
Christopher Fujino
33210218ba
[flutter_tools] Fix flutter upgrade not finding git tags ( #133778 )
...
Fixes https://github.com/flutter/flutter/issues/133441
2023-08-31 22:01:10 +00:00
chunhtai
0b3b8cd551
Removes ios universal link vmservices and let xcodeproject to dump js… ( #133709 )
...
â¦on file
The deeplink validation tool will become an static app so it can't no longer access vm services.
The goal will be then to turn them into flutter analyze command similar to `flutter analyze --android --[options]` that static app can use on.
This pr only removes vm services and turn the api to dump a output file instead of printing everything to stdout.
2023-08-31 21:50:54 +00:00
yaakovschectman
e6e44de33c
Add MacOS AppKitView class. ( #132583 )
...
Add derived classes from the Darwin platform view base classes for
MacOS. Functionality is largely the same as the `UiKitView`, but the two
are decoupled and and can further diverge in the future as needed. Some
unit tests remain skipped for now as the gesture recognizers for MacOS
are not yet implemented.
https://github.com/flutter/flutter/issues/128519
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [ ] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
---------
Co-authored-by: Chris Bracken <chris@bracken.jp>
2023-08-31 17:48:12 -04:00
Loïc Sharma
b4753c328d
Improve doctor output on incomplete Visual Studio installation ( #133390 )
...
Flutter doctor warns if the user is updating Visual Studio or has paused
a Visual Studio update. The current output recommends reinstalling
Visual Studio. This is unnecessary as the user should be able to use the
Visual Studio Installer app to complete the installation:
This message is covered by this existing test:
229b74d987/packages/flutter_tools/test/general.shard/windows/visual_studio_validator_test.dart (L68-L81)https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
2023-08-31 14:37:46 -07:00
Victoria Ashworth
e98d3929ca
Revert "Run Mac_arm64_ios run_debug_test_macos in presubmit" ( #133808 )
...
Reverts flutter/flutter#133788
Something is wrong with bot https://chromium-swarm.appspot.com/bot?id=flutter-devicelab-mac-38 , it's unable to open the project in Xcode. Failing consistently.
https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket/8771213845302282993/+/u/ios_debug_symbol_doctor/recover_with_120_second_timeout/stdout
So reverting until we can get the bot fixed.
2023-08-31 21:34:48 +00:00
Andrew Kolos
c263c56dc6
give --task-args option in test_runner a help description ( #133791 )
...
Fixes https://github.com/flutter/flutter/issues/133790
Provides help text for the `--task-args` option of the `test_runner` devicelab command. The current help text is just copypasta from another option's help text
2023-08-31 21:08:59 +00:00
Christopher Fujino
1519553bed
[flutter_tools] print out the unzipping method used by update_dart_sdk.ps1 ( #133364 )
...
in case there are future issues with unzipping the dart sdk, such as https://github.com/flutter/flutter/issues/132592 , we should log out what tool we are using to try to extract the archive.
2023-08-31 21:06:47 +00:00
