LongCatIsLooong
bafdb124c7
Prevent LayoutBuilder from rebuilding more than once ( #147856 )
...
Fixes https://github.com/flutter/flutter/issues/146379 : introduces `Element.buildScope` which `BuildOwner.buildScope` uses to identify subtrees that need skipping (those with different `BuildScope`s). If `Element.update` calls `updateChild` then dirty children will still be rebuilt regardless of their build scopes.
This also introduces `LayoutBuilder.applyDoubleRebuildFix` migration flag which should only live for a week or less.
Caveats:
`LayoutBuilder`'s render object calls `markNeedsLayout` if a descendant Element is dirty. Since `markNeedsLayout` also implies `markNeedsPaint`, the render object is going to be very repaint/relayout-happy.
Tests:
Presubmits with the migration flag set to true: https://github.com/flutter/flutter/pull/147856/checks?check_run_id=24629865893
2024-05-29 22:03:20 +00:00
Valentin Vignal
bc097c619a
Add test for inherited_theme.0.dart ( #149120 )
...
Contributes to https://github.com/flutter/flutter/issues/130459
It adds a test for
- `examples/api/lib/widgets/inherited_theme/inherited_theme.0_test.dart`
2024-05-29 20:05:25 +00:00
Ellet
e553bbc2ba
Update progress_indicator.dart to indicate the adaptive option is for both macOS and iOS ( #145246 )
...
Since we are using The `CupertinoScrollBar` for both macOS and iOS, it's a good idea to update the description of the `adaptive` function to indicate it will be used for macOS and iOS
*Update progress_indicator.dart to indicate the adaptive option is for both macOS and iOS.*
2024-05-29 19:06:07 +00:00
LinXunFeng
d424b64229
_ModalScopeStatus as InheritedModel ( #149022 )
...
According to previous discussion at https://github.com/flutter/flutter/pull/145389#discussion_r1561564845 , this change makes `_ModalScopeStatus` an `InheritedModel` rather than an `InheritedWidget`, and provides the following methods.
- `isCurrentOf`
- `canPopOf`
- `settingsOf`
For example, `ModalRoute.of(context)!.settings` could become `ModalRoute.settingsOf(context)` as a performance optimization.
2024-05-29 18:46:04 +00:00
Valentin Vignal
2e275032d5
Add test for radio.toggleable.0.dart ( #149153 )
...
Contributes to https://github.com/flutter/flutter/issues/130459
It adds a test for
- `examples/api/lib/material/radio/radio.toggleable.0.dart`
2024-05-29 18:30:57 +00:00
LongCatIsLooong
557fca4582
Add a sentinel value for TextStyle.height ( #149049 )
...
Fixes: https://github.com/flutter/flutter/issues/58765
The rationale for the choice of the sentinel value: https://github.com/flutter/engine/pull/52940
The exact value of `kTextHeightNone` should be kept as an implementation detail. It's unfortunate that the current value `0` is dangerously close to `TextStyle.height`'s valid domain. If we ever allow `TextStyle.height == 0` (which totally makes sense) then it shouldn't be difficult to change the const.
2024-05-29 18:24:16 +00:00
Kate Lovett
90937b02eb
Remove dynamic_layouts from issue template ( #149252 )
...
Part of https://github.com/flutter/flutter/issues/148979
The package is being removed from flutter/packages, and so this removes it from the issue template.
2024-05-29 17:28:03 +00:00
engine-flutter-autoroll
10557babf9
Roll Flutter Engine from 30aa720d4999 to 60968ee3bde7 (1 revision) ( #149255 )
...
30aa720d49...60968ee3bdskia-flutter-autoroll@skia.org Roll Skia from 2fe794827c51 to d1a6967c48a5 (1 revision) (flutter/engine#53088 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jacksongardner@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-05-29 17:16:16 +00:00
engine-flutter-autoroll
6b05c462c7
Roll Flutter Engine from b26e1b023cdb to 30aa720d4999 (7 revisions) ( #149249 )
...
b26e1b023c...30aa720d49skia-flutter-autoroll@skia.org Roll Skia from 99966843c23f to 2fe794827c51 (1 revision) (flutter/engine#53087 )
2024-05-29 skia-flutter-autoroll@skia.org Roll Skia from d2469aaf5ab1 to 99966843c23f (1 revision) (flutter/engine#53086 )
2024-05-29 skia-flutter-autoroll@skia.org Roll Skia from 9ea5a1dd5270 to d2469aaf5ab1 (2 revisions) (flutter/engine#53085 )
2024-05-29 skia-flutter-autoroll@skia.org Roll Skia from eedef8763102 to 9ea5a1dd5270 (1 revision) (flutter/engine#53084 )
2024-05-29 skia-flutter-autoroll@skia.org Roll Skia from 0026a6047133 to eedef8763102 (1 revision) (flutter/engine#53081 )
2024-05-29 flar@google.com DisplayList forward opacity incompatibility through deferred saves (flutter/engine#53078 )
2024-05-28 skia-flutter-autoroll@skia.org Roll Skia from ac454b80130c to 0026a6047133 (1 revision) (flutter/engine#53076 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jacksongardner@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-05-29 16:15:16 +00:00
engine-flutter-autoroll
a00bba82bd
Roll Packages from a933c3016f6c to 31d332900d98 (6 revisions) ( #149246 )
...
a933c3016f...31d332900dflutter/packages#6815 )
2024-05-28 22373191+Hari-07@users.noreply.github.com [google_maps_flutter] Implement polyline patterns in google maps ios (flutter/packages#5757 )
2024-05-28 34871572+gmackall@users.noreply.github.com [many] Remove references to v1 embedding (flutter/packages#6494 )
2024-05-28 48729942+altynbek132@users.noreply.github.com [go_router] docs: updated link in navigation.md to correct file path for push_with_shell_route.dart (flutter/packages#6670 )
2024-05-28 49699333+dependabot[bot]@users.noreply.github.com [webview]: Bump androidx.webkit:webkit from 1.10.0 to 1.11.0 in /packages/webview_flutter/webview_flutter_android/android (flutter/packages#6805 )
2024-05-28 engine-flutter-autoroll@skia.org Roll Flutter from 0b31ffc125a1a33e63b9flutter/packages#6822 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com ,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-05-29 15:52:20 +00:00
Polina Cherkasova
c85fa6abf4
Clean leak in editable_text_test.dart. ( #149223 )
...
Introduced by https://github.com/flutter/flutter/pull/149042
<img width="145" alt="Screenshot 2024-05-28 at 6 25 22â¯PM" src="https://github.com/flutter/flutter/assets/12115586/5eb32012-b1c4-4188-8e9b-a6631483960c ">
2024-05-29 15:41:18 +00:00
Kostia Sokolovskyi
60d32e4534
Add tests for animated_switcher.0.dart API example. ( #149180 )
...
This PR contributes to https://github.com/flutter/flutter/issues/130459
### Description
- Adds tests for `examples/api/lib/widgets/animated_switcher/animated_switcher.0.dart`
2024-05-29 12:10:34 +00:00
engine-flutter-autoroll
35ae519140
Manual roll Flutter Engine from d0323905fc2f to b26e1b023cdb (16 revisions) ( #149220 )
...
Manual roll requested by jacksongardner@google.com
d0323905fc...b26e1b023c34871572+gmackall@users.noreply.github.com Manual revert of #53001 (flutter/engine#53075 )
2024-05-28 chinmaygarde@google.com Remove --ios-cpu flag. Only the arm64 variant is supported. (flutter/engine#53044 )
2024-05-28 skia-flutter-autoroll@skia.org Roll Skia from 229d94a8807e to ac454b80130c (1 revision) (flutter/engine#53074 )
2024-05-28 jonahwilliams@google.com [Impeller] make strokes slightly lighter. (flutter/engine#53067 )
2024-05-28 skia-flutter-autoroll@skia.org Roll Skia from 23ddbb590e44 to 229d94a8807e (2 revisions) (flutter/engine#53071 )
2024-05-28 jmccandless@google.com FlutterFragment predictive back (flutter/engine#52302 )
2024-05-28 skia-flutter-autoroll@skia.org Roll Skia from 02c359cf8233 to 23ddbb590e44 (2 revisions) (flutter/engine#53070 )
2024-05-28 skia-flutter-autoroll@skia.org Roll Skia from 4f91b3865441 to 02c359cf8233 (1 revision) (flutter/engine#53069 )
2024-05-28 30870216+gaaclarke@users.noreply.github.com [Impeller] shrunk the buffer for the rrect_blur (flutter/engine#53068 )
2024-05-28 skia-flutter-autoroll@skia.org Roll Skia from 91cd2b48377a to 4f91b3865441 (4 revisions) (flutter/engine#53066 )
2024-05-28 34871572+gmackall@users.noreply.github.com Upgrade all[most] androidx dependencies to latest (flutter/engine#53001 )
2024-05-28 skia-flutter-autoroll@skia.org Roll Skia from 0c2c490021b7 to 91cd2b48377a (3 revisions) (flutter/engine#53065 )
2024-05-28 skia-flutter-autoroll@skia.org Roll Skia from 545203f95d4e to 0c2c490021b7 (2 revisions) (flutter/engine#53063 )
2024-05-28 skia-flutter-autoroll@skia.org Roll Skia from 74b4d97be6ab to 545203f95d4e (1 revision) (flutter/engine#53062 )
2024-05-28 skia-flutter-autoroll@skia.org Roll Skia from 848d9498fd68 to 74b4d97be6ab (1 revision) (flutter/engine#53061 )
2024-05-28 johnniwinther@google.com Remove use of --nnbd-agnostic (flutter/engine#53055 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jacksongardner@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-05-29 04:33:07 +00:00
Hany Mohamed
9ea9726b21
Change snack bar default hitTestBehavior to deferToChild when SnackBarThemeData.insetPadding is not null ( #148568 )
...
The PR changes the default value of hitTestBehavior in snack bars to `HitTestBehavior.deferToChild` when snackBarTheme.insetPadding is not null, so that widgets behind snack bars affected by the value set to insetPadding, remain interactive even while a snack bar is visible. This PR can be considered as an extension to what have been done in PR #127959 which fixes the same problem but for individual snack bars with margin not being null. This PR works on the theme level.
*List which issues are fixed by this PR. You must list at least one issue. An issue is not required if the PR fixes something trivial like a typo.*
#148566
2024-05-29 04:31:32 +00:00
auto-submit[bot]
886de22182
Reverts "sliverGridDelegate mainAxisExtent add assert ( #148470 )" ( #149224 )
...
Reverts: flutter/flutter#148470
Initiated by: eyebrowsoffire
Reason for reverting: Unit test failures closing the tree.
Original PR Author: hello-coder-xu
Reviewed By: {QuncCccccc, Piinks}
This change reverts the following previous change:
* sliverGridDelegate mainAxisExtent add assert,Avoid incorrect use *
Fixes https://github.com/flutter/flutter/issues/138871
2024-05-29 02:33:16 +00:00
flyboy
af5a1a9e11
sliverGridDelegate mainAxisExtent add assert ( #148470 )
...
* sliverGridDelegate mainAxisExtent add assert,Avoid incorrect use *
Fixes https://github.com/flutter/flutter/issues/138871
2024-05-29 00:26:08 +00:00
Luis
b1540324e5
Fix SearchAnchor suggestions not refreshing after long API call ( #148767 )
...
Fixes https://github.com/flutter/flutter/issues/148765 .
## Fix Demo
https://github.com/flutter/flutter/assets/28322469/ad76ac8b-5e84-4fee-b04c-fbc9fa919450
2024-05-29 00:20:18 +00:00
Loïc Sharma
1f4e378de1
Add link to golden file test docs in the framework gardener guide ( #149207 )
...
This also adds a link from the Framework gardener guide.
2024-05-28 23:55:58 +00:00
Polina Cherkasova
65e3007687
Remove opt out for CurvedAnimation. ( #147594 )
2024-05-28 16:35:29 -07:00
LongCatIsLooong
0214afb40b
Fix the RenderFlex.computeDryBaseline implementation to match computeDistanceToActualBaseline ( #149062 )
...
Per Hixie's comment [here](https://github.com/flutter/flutter/issues/145739#issuecomment-2128006146 ), keep the current behavior
2024-05-28 23:21:08 +00:00
Polina Cherkasova
c109b3cb02
Clean leaky test. ( #149199 )
...
Introduced by https://github.com/flutter/flutter/pull/149006
To repro run:
`flutter test /Users/polinach/_/flutter_dev/packages/flutter/test/material/text_button_test.dart --dart-define LEAK_TR`
<img width="268" alt="Screenshot 2024-05-28 at 11 50 33â¯AM" src="https://github.com/flutter/flutter/assets/12115586/c1a1bf5e-4df4-4819-b897-b09021d3a07a ">
2024-05-28 23:06:10 +00:00
Gray Mackall
df64ca0b11
Change android_plugin_new_output_dir_test.dart test description ( #149198 )
...
Changes the test description to what I understand it is testing.
Context at https://discord.com/channels/608014603317936148/846507907876257822/1245077048599515157 .
cc @chunfengyao as the original author, as I see you are still active on Github ð
2024-05-28 23:04:10 +00:00
Bruno Leroux
fdca33c5b1
fix M2 InputDecorator suffix icon doesn't turn red on error ( #149161 )
...
The suffixIcon of a TextField with an error now turns red like it should (on Material 2).
2024-05-28 11:27:55 -07:00
Varun Kamani
e2e68c047c
Add selectionOverlayBuilder in CupertinoDatePicker and CupertinoTimer… ( #143079 )
...
It's now possible to override the default selection overlay with CupertinoDatePicker.selectionOverlayBuilder and CupertinoTimerPicker.selectionOverlayBuilder.
2024-05-28 11:24:57 -07:00
Justin McCandless
980b5a1976
Mouse onEnter and onExit now support hovering stylus ( #149006 )
...
Hovering with a stylus will now behave similarly to hovering with a mouse. For example, hovering a button will show the button's hovered styling.
2024-05-28 10:39:30 -07:00
LongCatIsLooong
b1221a92dc
Remove TextEditingController private member access ( #149042 )
...
Fixes https://github.com/flutter/flutter/issues/148692
I intend to CP this.
2024-05-28 17:37:25 +00:00
engine-flutter-autoroll
6543a2155e
Roll Packages from b7bcb4bd1267 to a933c3016f6c (1 revision) ( #149184 )
...
b7bcb4bd12...a933c3016fengine-flutter-autoroll@skia.org Roll Flutter from 65644712730b31ffc125flutter/packages#6820 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com ,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-05-28 15:46:17 +00:00
engine-flutter-autoroll
87564cec51
Roll Flutter Engine from b1751088c7e9 to d0323905fc2f (2 revisions) ( #149169 )
...
b1751088c7...d0323905fcskia-flutter-autoroll@skia.org Roll Skia from 312160c7c920 to 848d9498fd68 (1 revision) (flutter/engine#53059 )
2024-05-28 jonahwilliams@google.com [Impeller] Use scaled font to determine bounds, match Skia position rounding behavior, add subpixel X/Y/All/None positioning. (flutter/engine#53042 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jacksongardner@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-05-28 15:39:26 +00:00
Kevin Moore
891432c30f
[tool] Use kebabCase directly ( #149150 )
...
Drop silly snakeCase(..., '-') bits
2024-05-28 15:33:15 +00:00
Kate Lovett
1fbcbb73a0
[wiki migration] Leftover wiki pages and links ( #148989 )
...
This is waiting on
- https://github.com/flutter/flutter/pull/148777
- https://github.com/flutter/flutter/pull/148790
After this PR lands, there will likely be 1-2 more clean up PRs, after which the migration will be done!
---
This moves the remaining wiki pages as planned in [flutter.dev/go/migrate-flutter-wiki-spreadsheet](https://docs.google.com/spreadsheets/d/1x65189ZBdNiLRygpUYoU08pwvXD4M-Z157c6pm8deGI/edit?usp=sharing )
It also adds the team labels to the label bot for future PRs.
Changes to the content were only updating cross links, or links to refer to the main branch rather than master.
Remaining links to the wiki will be updated once all other pages have finished moving, they still work in the meantime.
Part of https://github.com/flutter/flutter/issues/145009
2024-05-28 15:12:10 +00:00
engine-flutter-autoroll
a1a33e63b9
Roll Flutter Engine from 6e0f812d82fe to b1751088c7e9 (1 revision) ( #149157 )
...
6e0f812d82...b1751088c7skia-flutter-autoroll@skia.org Roll Skia from 064f93590e63 to 312160c7c920 (1 revision) (flutter/engine#53058 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-05-28 07:56:25 +00:00
Martin Kustermann
9938ab1c60
[web] Remove --dart-sdk flag to dart2wasm compiler ( #149129 )
...
Dart2wasm only needs a platform file, which contains the compiled
`dart:*` libraries. There's no need to specify a seperate `--dart-sdk`
option (anymore).
(See also https://dart-review.googlesource.com/c/sdk/+/366821 )
2024-05-28 09:48:44 +02:00
engine-flutter-autoroll
ea1976a17c
Roll Flutter Engine from 416c619829a6 to 6e0f812d82fe (1 revision) ( #149155 )
...
416c619829...6e0f812d82chinmaygarde@google.com Add an unoptimized Android debug config to local_engine.json. (flutter/engine#53057 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-05-28 07:01:24 +00:00
engine-flutter-autoroll
47f463c382
Roll Flutter Engine from cf201b119585 to 416c619829a6 (1 revision) ( #149148 )
...
cf201b1195...416c619829byoungchan.lee@gmx.com Add Linux platform support for fetching refresh rate on startup. (flutter/engine#52934 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-05-28 02:26:25 +00:00
engine-flutter-autoroll
f0d6c4413c
Roll Flutter Engine from dcc063c8deae to cf201b119585 (1 revision) ( #149143 )
...
dcc063c8de...cf201b1195skia-flutter-autoroll@skia.org Roll Skia from 96479ef610f5 to 064f93590e63 (1 revision) (flutter/engine#53056 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-05-27 20:32:29 +00:00
engine-flutter-autoroll
a821c2113b
Roll Packages from 7b423f582180 to b7bcb4bd1267 (7 revisions) ( #149136 )
...
7b423f5821...b7bcb4bd12engine-flutter-autoroll@skia.org Roll Flutter from cb26a01a406564471273flutter/packages#6796 )
2024-05-26 stuartmorgan@google.com Update Flutter wiki links (flutter/packages#6789 )
2024-05-25 engine-flutter-autoroll@skia.org Roll Flutter from 8dd08314d2cb26a01a40flutter/packages#6794 )
2024-05-24 stuartmorgan@google.com [ci] Switch podspec check over to ARM (flutter/packages#6791 )
2024-05-24 stuartmorgan@google.com [pointer_interceptor] Add Swift Package Manager support (flutter/packages#6790 )
2024-05-24 engine-flutter-autoroll@skia.org Roll Flutter from 8d955cdd648dd08314d2flutter/packages#6788 )
2024-05-24 joonas.kerttula@codemate.com [google_maps_flutter_platform_interface] Add improvements to BitmapDescriptor API (flutter/packages#6687 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com ,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-05-27 15:54:25 +00:00
engine-flutter-autoroll
0b31ffc125
Roll Flutter Engine from 451480f2bf66 to dcc063c8deae (1 revision) ( #149125 )
...
451480f2bf...dcc063c8deskia-flutter-autoroll@skia.org Roll Skia from a74086522b47 to 96479ef610f5 (1 revision) (flutter/engine#53054 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-05-27 09:39:05 +00:00
engine-flutter-autoroll
73fb6c7eff
Roll Flutter Engine from 76f5849eec5d to 451480f2bf66 (1 revision) ( #149123 )
...
76f5849eec...451480f2bfskia-flutter-autoroll@skia.org Roll Skia from 33234e7c2072 to a74086522b47 (3 revisions) (flutter/engine#53052 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-05-27 08:48:26 +00:00
engine-flutter-autoroll
fa156f9d8b
Roll Flutter Engine from 2b92f87cb5c1 to 76f5849eec5d (1 revision) ( #149121 )
...
2b92f87cb5...76f5849eecskia-flutter-autoroll@skia.org Roll Skia from 0ac91408b96a to 33234e7c2072 (1 revision) (flutter/engine#53051 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-05-27 08:08:06 +00:00
Valentin Vignal
1efca65408
Add test for future_builder.0.dart ( #148453 )
...
Contributes to https://github.com/flutter/flutter/issues/130459
It adds a test for
- `examples/api/lib/widgets/async/future_builder.0.dart`
2024-05-27 07:12:56 +00:00
engine-flutter-autoroll
63b17c8401
Roll Flutter Engine from 469193ef0e9a to 2b92f87cb5c1 (1 revision) ( #149119 )
...
469193ef0e...2b92f87cb5chinmaygarde@google.com [Impeller] Suppress SPIRV validation errors in latest Vulkan SDK. (flutter/engine#53049 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-05-27 07:12:55 +00:00
engine-flutter-autoroll
8fd8e66de4
Roll Flutter Engine from e91fbacde56d to 469193ef0e9a (1 revision) ( #149114 )
...
e91fbacde5...469193ef0eskia-flutter-autoroll@skia.org Roll Skia from f357c9f2781c to 0ac91408b96a (1 revision) (flutter/engine#53047 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-05-27 01:49:30 +00:00
engine-flutter-autoroll
eb1027f678
Roll Flutter Engine from f3025ae1511b to e91fbacde56d (1 revision) ( #149101 )
...
f3025ae151...e91fbacde5skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from j_hH7zx04OsJaL9p2... to c-Sm5-fy8c2YM7Myk... (flutter/engine#53046 )
Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from j_hH7zx04OsJ to c-Sm5-fy8c2Y
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-05-27 01:03:32 +00:00
engine-flutter-autoroll
6564471273
Roll Flutter Engine from a207dfe8e96b to f3025ae1511b (1 revision) ( #149098 )
...
a207dfe8e9...f3025ae151skia-flutter-autoroll@skia.org Roll Skia from 93ef9f3c4f39 to f357c9f2781c (1 revision) (flutter/engine#53045 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-05-26 05:45:25 +00:00
engine-flutter-autoroll
e2c25b24ca
Manual roll Flutter Engine from 1d154ff93a87 to a207dfe8e96b (10 revisions) ( #149096 )
...
Manual roll requested by zra@google.com
1d154ff93a...a207dfe8e9#53032 )" (flutter/engine#53041 )
2024-05-25 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Roll Dart SDK from b759e9f83ff9 to aed02f471e34 (1 revision) (#53036 )" (flutter/engine#53040 )
2024-05-25 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Roll Dart SDK from aed02f471e34 to 17c351dd16f4 (1 revision) (#53037 )" (flutter/engine#53039 )
2024-05-25 skia-flutter-autoroll@skia.org Roll Skia from 6e42cb7a099d to 93ef9f3c4f39 (1 revision) (flutter/engine#53038 )
2024-05-25 skia-flutter-autoroll@skia.org Roll Dart SDK from aed02f471e34 to 17c351dd16f4 (1 revision) (flutter/engine#53037 )
2024-05-25 skia-flutter-autoroll@skia.org Roll Dart SDK from b759e9f83ff9 to aed02f471e34 (1 revision) (flutter/engine#53036 )
2024-05-25 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from 9PoD1BZXVglZ-EWu3... to j_hH7zx04OsJaL9p2... (flutter/engine#53035 )
2024-05-25 skia-flutter-autoroll@skia.org Roll Skia from a783c0c8df89 to 6e42cb7a099d (1 revision) (flutter/engine#53034 )
2024-05-25 skia-flutter-autoroll@skia.org Roll Dart SDK from 641d61332238 to b759e9f83ff9 (1 revision) (flutter/engine#53032 )
2024-05-25 skia-flutter-autoroll@skia.org Roll Skia from 7eb8515603c1 to a783c0c8df89 (1 revision) (flutter/engine#53033 )
Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from 9PoD1BZXVglZ to j_hH7zx04OsJ
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-05-25 22:21:25 +00:00
Bruno Leroux
0f3882e050
Fix Linux numpad shortcuts on web ( #148988 )
...
## Description
This PRs fixes a Web issue on Linux related to numpad keys.
In https://github.com/flutter/flutter/pull/145464 , I introduced numpad shortcuts for Linux. These shortcuts work well on a desktop Linux application but they broke the Linux+Web numpad logic.
When I added these shortcuts, I expected them to not be active on Web (because I knew that on Web, those shortcuts are handled by the browser). But there is a trick: text editing shortcuts are still defined on Web but they are disabled at the editable text level so one can use them in components that are not `EditableText` (see https://github.com/flutter/flutter/pull/103377 ).
In this PR, I used the same approach than for other text editing shortcuts: when on web associate those shortcuts to the `DoNothingAndStopPropagationTextIntent` intent.
## Related Issue
Fixes https://github.com/flutter/flutter/issues/148447 .
## Tests
Updates 2 tests.
Adds 2 tests.
2024-05-25 19:59:19 +00:00
engine-flutter-autoroll
cb26a01a40
Roll Flutter Engine from e0207131ea13 to 1d154ff93a87 (1 revision) ( #149070 )
...
e0207131ea...1d154ff93askia-flutter-autoroll@skia.org Roll Skia from 0b7d656b9c03 to 7eb8515603c1 (1 revision) (flutter/engine#53031 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-05-25 03:06:27 +00:00
engine-flutter-autoroll
45d7dbad8f
Roll Flutter Engine from f693fdd840e8 to e0207131ea13 (7 revisions) ( #149068 )
...
f693fdd840...e0207131easkia-flutter-autoroll@skia.org Roll Dart SDK from 4ef8ed68a8d4 to 641d61332238 (1 revision) (flutter/engine#53029 )
2024-05-24 skia-flutter-autoroll@skia.org Roll Skia from 10459d97152a to 0b7d656b9c03 (3 revisions) (flutter/engine#53028 )
2024-05-24 flar@google.com Reland "DisplayListBuilder internal reorganization with better rendering op overlap detection" (52646) (flutter/engine#53002 )
2024-05-24 skia-flutter-autoroll@skia.org Roll Skia from 137a4ea4e033 to 10459d97152a (3 revisions) (flutter/engine#53027 )
2024-05-24 skia-flutter-autoroll@skia.org Roll Skia from d252bca326a6 to 137a4ea4e033 (1 revision) (flutter/engine#53026 )
2024-05-24 skia-flutter-autoroll@skia.org Roll Skia from 97783ac3000d to d252bca326a6 (2 revisions) (flutter/engine#53025 )
2024-05-24 chinmaygarde@google.com Rename Skia specific TUs. (flutter/engine#52855 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-05-25 01:38:22 +00:00
engine-flutter-autoroll
5bf11bc2cd
Roll Flutter Engine from b5e98f9b8d0f to f693fdd840e8 (4 revisions) ( #149057 )
...
b5e98f9b8d...f693fdd8401961493+harryterkelsen@users.noreply.github.com [canvaskit] Fix overlay reorganization for edge case with only 1 overlay (flutter/engine#53006 )
2024-05-24 skia-flutter-autoroll@skia.org Roll Dart SDK from 49b226cecee7 to 4ef8ed68a8d4 (1 revision) (flutter/engine#53024 )
2024-05-24 skia-flutter-autoroll@skia.org Roll Skia from f832549400ab to 97783ac3000d (1 revision) (flutter/engine#53023 )
2024-05-24 30870216+gaaclarke@users.noreply.github.com [Impeller] sped up the linear gradient by moving calculations to the cpu (flutter/engine#53007 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-05-25 00:44:19 +00:00
Joodo
734d243bc8
fix popup menu offset when using useRootNavigator in PopupMenu ( #144670 )
...
fix issue #144669
2024-05-24 21:38:08 +00:00
