Commit graph

36817 commits

Author SHA1 Message Date
Michael Goderbauer b966b2beee
Enable private field promotion for dev (#134480)
New feature in upcoming Dart 3.2. See https://github.com/dart-lang/language/issues/2020. Feature is enabled by bumping the min SDK version to 3.2.

Part of https://github.com/flutter/flutter/issues/134476.
2023-09-12 18:29:00 +00:00
Kate Lovett 4e7a07af88
Remove chip tooltip deprecations (#134486)
Part of https://github.com/flutter/flutter/issues/133171

These deprecations were introduced in https://github.com/flutter/flutter/pull/96174
The replacement is to use `deleteButtonTooltipMessage`.
This migration is supported by dart fix. âœ
2023-09-12 18:23:52 +00:00
engine-flutter-autoroll cba7daf3ce
Roll Flutter Engine from 8a8ddaeecf8a to d4698c65aa8d (2 revisions) (#134553)
8a8ddaeecf...d4698c65aa

2023-09-12 skia-flutter-autoroll@skia.org Roll Skia from 7e9b94634911 to f3f0cab7efd0 (1 revision) (flutter/engine#45710)
2023-09-12 derekx@google.com Add trace-to-file switch (flutter/engine#45553)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC bdero@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-09-12 18:22:52 +00:00
Kate Lovett 90ae98f576
Remove deprecated TextSelectionOverlay.fadeDuration (#134485)
Part of https://github.com/flutter/flutter/issues/133171

This was deprecated in https://github.com/flutter/flutter/pull/100381
Th replacement is to use `SelectionOverlay.fadeDuration` instead.
This migration is supported by dart fix. âœ
2023-09-12 17:14:18 +00:00
engine-flutter-autoroll ce39d01d52
Roll Flutter Engine from 25be03186d82 to 8a8ddaeecf8a (1 revision) (#134545)
25be03186d...8a8ddaeecf

2023-09-12 skia-flutter-autoroll@skia.org Roll Skia from a1ff98bebf89 to 7e9b94634911 (2 revisions) (flutter/engine#45707)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC bdero@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-09-12 16:52:21 +00:00
engine-flutter-autoroll f9aef4f21e
Roll Packages from ef0c65ea4ccd to e04ba886a85e (5 revisions) (#134546)
ef0c65ea4c...e04ba886a8

2023-09-12 stuartmorgan@google.com [tool] Add a package inclusion filter (flutter/packages#4904)
2023-09-12 me@nils.re [flutter_markdown] Fix changelog regarding minimum supported SDK version (flutter/packages#4851)
2023-09-12 stuartmorgan@google.com [ios_platform_images] Add integration tests (flutter/packages#4899)
2023-09-12 robert@odrowaz.dev [image_picker] Copy exif tags in categories II and III (flutter/packages#4738)
2023-09-11 233583+mossmana@users.noreply.github.com [google_maps_flutter_android] Fix for testToggleInfoWindow persistently flaky  (flutter/packages#4768)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-09-12 16:50:18 +00:00
chunhtai 5900c4baa7
Revert "Adds a parent scope TraversalEdgeBehavior and fixes modal rou… (#134550)
…te to no… (#130841)"

This reverts commit 0f3bd90d9b.

Internal test needs migration

## Pre-launch Checklist

- [ ] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [ ] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [ ] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [ ] I signed the [CLA].
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [ ] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [ ] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
2023-09-12 09:18:40 -07:00
Flutter GitHub Bot bdd96032a0
Marks Windows_android channels_integration_test_win to be unflaky (#133129)
<!-- meta-tags: To be used by the automation script only, DO NOT MODIFY.
{
  "name": "Windows_android channels_integration_test_win"
}
-->
The issue https://github.com/flutter/flutter/issues/130732 has been closed, and the test has been passing for [50 consecutive runs](https://data.corp.google.com/sites/flutter_infra_metrics_datasite/flutter_check_test_flakiness_status_dashboard/?p=BUILDER_NAME:%22Windows_android%20channels_integration_test_win%22).
This test can be marked as unflaky.
2023-09-12 15:37:30 +00:00
engine-flutter-autoroll 9e891f2dc9
Roll Flutter Engine from 4091167e402d to 25be03186d82 (1 revision) (#134536)
4091167e40...25be03186d

2023-09-12 skia-flutter-autoroll@skia.org Roll Skia from 55c9c377f0b0 to a1ff98bebf89 (1 revision) (flutter/engine#45706)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC bdero@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-09-12 15:34:08 +00:00
engine-flutter-autoroll 127c76b91b
Roll Flutter Engine from 54175da7ba90 to 4091167e402d (1 revision) (#134532)
54175da7ba...4091167e40

2023-09-12 skia-flutter-autoroll@skia.org Roll Skia from 8d11fcb3068a to 55c9c377f0b0 (1 revision) (flutter/engine#45705)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC bdero@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-09-12 14:34:25 +00:00
engine-flutter-autoroll 278b145ae4
Roll Flutter Engine from 85f3f02e5c37 to 54175da7ba90 (2 revisions) (#134531)
85f3f02e5c...54175da7ba

2023-09-12 skia-flutter-autoroll@skia.org Roll Skia from 5b94fc73a36e to 8d11fcb3068a (1 revision) (flutter/engine#45703)
2023-09-12 skia-flutter-autoroll@skia.org Roll Skia from 72e5b5c8d5f0 to 5b94fc73a36e (1 revision) (flutter/engine#45701)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC bdero@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-09-12 13:44:21 +00:00
engine-flutter-autoroll ac79c84615
Roll Flutter Engine from 1369ab35aaa7 to 85f3f02e5c37 (1 revision) (#134519)
1369ab35aa...85f3f02e5c

2023-09-12 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from fSmVaZwp41ZGp5hKn... to QgAHx3BtJfN3TmodS... (flutter/engine#45700)

Also rolling transitive DEPS:
  fuchsia/sdk/core/mac-amd64 from fSmVaZwp41ZG to QgAHx3BtJfN3

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC bdero@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-09-12 11:14:36 +00:00
engine-flutter-autoroll bb079949bb
Roll Flutter Engine from 2f1efe5967f3 to 1369ab35aaa7 (1 revision) (#134512)
2f1efe5967...1369ab35aa

2023-09-12 skia-flutter-autoroll@skia.org Roll Skia from 9f92b15074a6 to 72e5b5c8d5f0 (1 revision) (flutter/engine#45696)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC bdero@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-09-12 09:10:10 +00:00
engine-flutter-autoroll 6f96d5eb61
Roll Flutter Engine from 4d8265cbc133 to 2f1efe5967f3 (3 revisions) (#134511)
4d8265cbc1...2f1efe5967

2023-09-12 skia-flutter-autoroll@skia.org Roll Skia from ba5d081cd448 to 9f92b15074a6 (1 revision) (flutter/engine#45695)
2023-09-12 49699333+dependabot[bot]@users.noreply.github.com Bump actions/upload-artifact from 3.1.2 to 3.1.3 (flutter/engine#45694)
2023-09-12 skia-flutter-autoroll@skia.org Roll Skia from 62aa41ee8135 to ba5d081cd448 (3 revisions) (flutter/engine#45692)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-09-12 08:21:08 +00:00
engine-flutter-autoroll c7f3859976
Roll Flutter Engine from ee7215553deb to 4d8265cbc133 (1 revision) (#134506)
ee7215553d...4d8265cbc1

2023-09-12 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from cUKimo52R-2EIfHh5... to vGleXqh2SRUNJM7JN... (flutter/engine#45691)

Also rolling transitive DEPS:
  fuchsia/sdk/core/linux-amd64 from cUKimo52R-2E to vGleXqh2SRUN

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-09-12 06:56:23 +00:00
engine-flutter-autoroll e95c745b33
Roll Flutter Engine from 6ddee4423d2c to ee7215553deb (2 revisions) (#134505)
6ddee4423d...ee7215553d

2023-09-12 skia-flutter-autoroll@skia.org Roll Skia from c4e94d5febdc to 62aa41ee8135 (2 revisions) (flutter/engine#45690)
2023-09-12 matanlurey@users.noreply.github.com [Impeller] Fix thread leak in ResourceManagerVK. (flutter/engine#45686)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-09-12 06:06:14 +00:00
engine-flutter-autoroll bc594bd448
Roll Flutter Engine from a98348946d61 to 6ddee4423d2c (1 revision) (#134490)
a98348946d...6ddee4423d

2023-09-12 matej.knopp@gmail.com [Web] Properly report inverted selection (flutter/engine#44806)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-09-12 02:58:25 +00:00
xubaolin a9fac73361
[New feature] Allowing the ListView slivers to have different extents while still having scrolling performance (#131393)
Fixes https://github.com/flutter/flutter/issues/113431

Currently we only support specifying all slivers to have the same extent.
This patch introduces an `itemExtentBuilder` property for `ListView`, allowing the slivers to have different extents while still having scrolling performance, especially when the scroll position changes drastically(such as scrolling by the scrollbar or controller.jumpTo()).

@Piinks Hi, Any thoughts about this?  :)
2023-09-12 02:16:48 +00:00
engine-flutter-autoroll e645fb7d5e
Roll Flutter Engine from 8389ad914b21 to a98348946d61 (4 revisions) (#134487)
8389ad914b...a98348946d

2023-09-12 jason-simmons@users.noreply.github.com Roll libwebp to 1.3.1 (flutter/engine#45675)
2023-09-11 skia-flutter-autoroll@skia.org Roll Skia from 0b8d2203ab35 to c4e94d5febdc (5 revisions) (flutter/engine#45679)
2023-09-11 chinmaygarde@google.com Pipe VMA asserts to FML. (flutter/engine#45661)
2023-09-11 skia-flutter-autoroll@skia.org Roll Skia from e6225224fb4e to 0b8d2203ab35 (9 revisions) (flutter/engine#45671)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-09-12 02:15:07 +00:00
Kohei Seino 82cb74932f
ScaleGestureRecognizer: make pointerCount public (#127310)
make `pointCount` in `ScaleGestureRecognizer` public to handle pointer event depending on the number of pointers.

https://github.com/flutter/flutter/issues/127309
2023-09-12 01:01:38 +00:00
Chinmay Kabi 4a3ab6828a
Fix DataTable example not being scrollable (#131556) 2023-09-11 18:55:53 -05:00
engine-flutter-autoroll 0770c60af3
Roll Flutter Engine from 06696e768c1b to 8389ad914b21 (2 revisions) (#134469)
06696e768c...8389ad914b

2023-09-11 109111084+yaakovschectman@users.noreply.github.com Merge `Window` into `FlutterWindow` (flutter/engine#45542)
2023-09-11 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from 7Zk_dvFh301kgQte4... to fSmVaZwp41ZGp5hKn... (flutter/engine#45665)

Also rolling transitive DEPS:
  fuchsia/sdk/core/mac-amd64 from 7Zk_dvFh301k to fSmVaZwp41ZG

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-09-11 23:39:08 +00:00
Christopher Fujino b76b82aa71
[flutter_tools] disallow -O0 for flutter build web (#134185)
Fixes https://github.com/flutter/flutter/issues/133404.

Per the dart2js team on the linked issue, `-O0` is not intended for end users, but more for actual debugging/development of the compiler.
2023-09-11 23:33:09 +00:00
Kostia Sokolovskyi adaf78a60d
Cover focus tests with leak tracking (#134457) 2023-09-11 15:35:09 -07:00
engine-flutter-autoroll b90c1a8766
Roll Flutter Engine from 0774ddcda9b0 to 06696e768c1b (4 revisions) (#134462)
0774ddcda9...06696e768c

2023-09-11 jacksongardner@google.com Revert "Remove some of our hacks around JSPromise now that we have better APIs." (flutter/engine#45660)
2023-09-11 skia-flutter-autoroll@skia.org Roll Skia from 3ed290acb65f to e6225224fb4e (2 revisions) (flutter/engine#45658)
2023-09-11 kjlubick@users.noreply.github.com Update skwasm build to use safer flush call (flutter/engine#45652)
2023-09-11 jacksongardner@google.com Remove some of our hacks around JSPromise now that we have better APIs. (flutter/engine#45591)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-09-11 22:01:23 +00:00
Kostia Sokolovskyi e7058f568f
Fix memory leak in RenderAnimatedSize (#133653)
`AnimationController` and `CurvedAnimation` objects were not disposed in `RenderAnimatedSize`.

### Description
- Fixes https://github.com/flutter/flutter/issues/133903;
- Adds the missing `dispose()` calls for `AnimationController` and `CurvedAnimation` in `RenderAnimatedSize`.

### Tests
- Updates `animated_size_test.dart` to test that `AnimationController` and `CurvedAnimation` are disposed after `RenderSize` disposal.
2023-09-11 20:46:04 +00:00
engine-flutter-autoroll 969911d1d0
Roll Flutter Engine from e42fd367adcb to 0774ddcda9b0 (1 revision) (#134447)
e42fd367ad...0774ddcda9

2023-09-11 skia-flutter-autoroll@skia.org Roll Skia from 2fa311521fb2 to 3ed290acb65f (1 revision) (flutter/engine#45653)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-09-11 19:14:03 +00:00
engine-flutter-autoroll 9dbbd5b4bf
Roll Flutter Engine from d593002b7159 to e42fd367adcb (1 revision) (#134444)
d593002b71...e42fd367ad

2023-09-11 30870216+gaaclarke@users.noreply.github.com Revert "Makes Skia's vkQueueSubmit threadsafe." (flutter/engine#45650)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-09-11 18:19:20 +00:00
engine-flutter-autoroll b831c9f44f
Roll Packages from aaae5ef97a45 to ef0c65ea4ccd (6 revisions) (#134445)
aaae5ef97a...ef0c65ea4c

2023-09-11 engine-flutter-autoroll@skia.org Roll Flutter from 7c28e8eb07 to 219efce7f1 (16 revisions) (flutter/packages#4901)
2023-09-11 chris.langham32@gmail.com [url_launcher] migrating iOS tests from objc to swift (flutter/packages#4758)
2023-09-09 engine-flutter-autoroll@skia.org Roll Flutter from da676f79aa to 7c28e8eb07 (20 revisions) (flutter/packages#4879)
2023-09-09 49699333+dependabot[bot]@users.noreply.github.com Bump actions/upload-artifact from 3.1.2 to 3.1.3 (flutter/packages#4863)
2023-09-08 engine-flutter-autoroll@skia.org Roll Flutter from aea4552acd to da676f79aa (28 revisions) (flutter/packages#4874)
2023-09-08 48349434+paulppn@users.noreply.github.com [webview_flutter_android] Added the functionality to fullscreen html5 video (flutter/packages#3879)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-09-11 18:17:25 +00:00
engine-flutter-autoroll 6562d52634
Roll Flutter Engine from 2b5961cbc40d to d593002b7159 (3 revisions) (#134439)
2b5961cbc4...d593002b71

2023-09-11 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from SFM4ele7RYnVMhr7S... to cUKimo52R-2EIfHh5... (flutter/engine#45647)
2023-09-11 kjlubick@users.noreply.github.com Use safer GrDirectContext APIs (flutter/engine#45644)
2023-09-11 skia-flutter-autoroll@skia.org Roll Skia from 787b61f00100 to 2fa311521fb2 (1 revision) (flutter/engine#45642)

Also rolling transitive DEPS:
  fuchsia/sdk/core/linux-amd64 from SFM4ele7RYnV to cUKimo52R-2E

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-09-11 17:31:23 +00:00
Polina Cherkasova 0844726ab3
Mark leak: instances of OpacityLayer, created by _RenderChip, should be disposed. (#134395) 2023-09-11 17:12:02 +00:00
Polina Cherkasova 219efce7f1
Cover more tests with leak tracking. (#134363) 2023-09-11 09:42:27 -07:00
engine-flutter-autoroll 6de4e16985
Roll Flutter Engine from e9f1696e5060 to 2b5961cbc40d (1 revision) (#134424)
e9f1696e50...2b5961cbc4

2023-09-11 skia-flutter-autoroll@skia.org Roll Skia from 4c50e0870461 to 787b61f00100 (1 revision) (flutter/engine#45639)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-09-11 13:23:33 +00:00
engine-flutter-autoroll c6fa26162f
Roll Flutter Engine from ac6be4dbf821 to e9f1696e5060 (1 revision) (#134410)
ac6be4dbf8...e9f1696e50

2023-09-11 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from 6PrTSjMiSCsSb0muF... to 7Zk_dvFh301kgQte4... (flutter/engine#45636)

Also rolling transitive DEPS:
  fuchsia/sdk/core/mac-amd64 from 6PrTSjMiSCsS to 7Zk_dvFh301k

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-09-11 09:41:25 +00:00
engine-flutter-autoroll 954444a0e3
Roll Flutter Engine from 1aa11b644855 to ac6be4dbf821 (1 revision) (#134407)
1aa11b6448...ac6be4dbf8

2023-09-11 skia-flutter-autoroll@skia.org Roll Skia from 2e80ffb2ebea to 4c50e0870461 (1 revision) (flutter/engine#45635)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-09-11 09:00:23 +00:00
engine-flutter-autoroll ffe1ebd207
Roll Flutter Engine from 7e41b064eb23 to 1aa11b644855 (2 revisions) (#134404)
7e41b064eb...1aa11b6448

2023-09-11 skia-flutter-autoroll@skia.org Roll Skia from 5aff628b1c47 to 2e80ffb2ebea (1 revision) (flutter/engine#45634)
2023-09-11 skia-flutter-autoroll@skia.org Roll Skia from 947f91dcacf5 to 5aff628b1c47 (1 revision) (flutter/engine#45633)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-09-11 07:46:15 +00:00
engine-flutter-autoroll 69f6e7d15d
Roll Flutter Engine from 04d836f69571 to 7e41b064eb23 (1 revision) (#134396)
04d836f695...7e41b064eb

2023-09-11 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from a024p4HJVVgmCW5Jo... to SFM4ele7RYnVMhr7S... (flutter/engine#45632)

Also rolling transitive DEPS:
  fuchsia/sdk/core/linux-amd64 from a024p4HJVVgm to SFM4ele7RYnV

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-09-11 04:50:38 +00:00
engine-flutter-autoroll 0d9ea62756
Roll Flutter Engine from 2acd60d6baed to 04d836f69571 (1 revision) (#134392)
2acd60d6ba...04d836f695

2023-09-10 skia-flutter-autoroll@skia.org Roll Skia from 4eea73a072d3 to 947f91dcacf5 (1 revision) (flutter/engine#45629)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-09-10 22:34:24 +00:00
engine-flutter-autoroll 44131ae4cf
Roll Flutter Engine from 59b08263f7cc to 2acd60d6baed (1 revision) (#134391)
59b08263f7...2acd60d6ba

2023-09-10 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from VciXahwZgiusifyh8... to 6PrTSjMiSCsSb0muF... (flutter/engine#45626)

Also rolling transitive DEPS:
  fuchsia/sdk/core/mac-amd64 from VciXahwZgius to 6PrTSjMiSCsS

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-09-10 21:00:31 +00:00
engine-flutter-autoroll de25def778
Roll Flutter Engine from a2af0c6965be to 59b08263f7cc (1 revision) (#134384)
a2af0c6965...59b08263f7

2023-09-10 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from U70-bvYinYjKdGGSt... to a024p4HJVVgmCW5Jo... (flutter/engine#45624)

Also rolling transitive DEPS:
  fuchsia/sdk/core/linux-amd64 from U70-bvYinYjK to a024p4HJVVgm

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-09-10 17:25:28 +00:00
engine-flutter-autoroll 2da03e54a9
Roll Flutter Engine from 47d1a045d140 to a2af0c6965be (1 revision) (#134375)
47d1a045d1...a2af0c6965

2023-09-10 skia-flutter-autoroll@skia.org Roll Skia from 1bb0f15f2cff to 4eea73a072d3 (1 revision) (flutter/engine#45623)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-09-10 13:15:26 +00:00
Daco Harkes aa36db1d29
Native assets support for MacOS and iOS (#130494)
Support for FFI calls with `@Native external` functions through Native assets on MacOS and iOS. This enables bundling native code without any build-system boilerplate code.

For more info see:

* https://github.com/flutter/flutter/issues/129757

### Implementation details for MacOS and iOS.

Dylibs are bundled by (1) making them fat binaries if multiple architectures are targeted, (2) code signing these, and (3) copying them to the frameworks folder. These steps are done manual rather than via CocoaPods. CocoaPods would have done the same steps, but (a) needs the dylibs to be there before the `xcodebuild` invocation (we could trick it, by having a minimal dylib in the place and replace it during the build process, that works), and (b) can't deal with having no dylibs to be bundled (we'd have to bundle a dummy dylib or include some dummy C code in the build file).

The dylibs are build as a new target inside flutter assemble, as that is the moment we know what build-mode and architecture to target.

The mapping from asset id to dylib-path is passed in to every kernel compilation path. The interesting case is hot-restart where the initial kernel file is compiled by the "inner" flutter assemble, while after hot restart the "outer" flutter run compiled kernel file is pushed to the device. Both kernel files need to contain the mapping. The "inner" flutter assemble gets its mapping from the NativeAssets target which builds the native assets. The "outer" flutter run get its mapping from a dry-run invocation. Since this hot restart can be used for multiple target devices (`flutter run -d all`) it contains the mapping for all known targets.

### Example vs template

The PR includes a new template that uses the new native assets in a package and has an app importing that. Separate discussion in: https://github.com/flutter/flutter/issues/131209.

### Tests

This PR adds new tests to cover the various use cases.

* dev/devicelab/bin/tasks/native_assets_ios.dart
  * Runs an example app with native assets in all build modes, doing hot reload and hot restart in debug mode.
* dev/devicelab/bin/tasks/native_assets_ios_simulator.dart
  * Runs an example app with native assets, doing hot reload and hot restart.
* packages/flutter_tools/test/integration.shard/native_assets_test.dart
  * Runs (incl hot reload/hot restart), builds, builds frameworks for iOS, MacOS and flutter-tester.
* packages/flutter_tools/test/general.shard/build_system/targets/native_assets_test.dart
  * Unit tests the new Target in the backend.
* packages/flutter_tools/test/general.shard/ios/native_assets_test.dart
* packages/flutter_tools/test/general.shard/macos/native_assets_test.dart
  * Unit tests the native assets being packaged on a iOS/MacOS build.

It also extends various existing tests:

* dev/devicelab/bin/tasks/module_test_ios.dart
   * Exercises the add2app scenario.
* packages/flutter_tools/test/general.shard/features_test.dart
   * Unit test the new feature flag.
2023-09-10 08:07:13 +00:00
engine-flutter-autoroll 690800bca3
Roll Flutter Engine from feea98d6d0ae to 47d1a045d140 (1 revision) (#134368)
feea98d6d0...47d1a045d1

2023-09-10 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from 51fG0shrG6fW64BtN... to VciXahwZgiusifyh8... (flutter/engine#45620)

Also rolling transitive DEPS:
  fuchsia/sdk/core/mac-amd64 from 51fG0shrG6fW to VciXahwZgius

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-09-10 05:41:26 +00:00
engine-flutter-autoroll 8919140c0a
Roll Flutter Engine from 4edbefa5e8f7 to feea98d6d0ae (1 revision) (#134365)
4edbefa5e8...feea98d6d0

2023-09-10 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from i9IPFS-XpkPjlH235... to U70-bvYinYjKdGGSt... (flutter/engine#45618)

Also rolling transitive DEPS:
  fuchsia/sdk/core/linux-amd64 from i9IPFS-XpkPj to U70-bvYinYjK

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-09-10 03:37:11 +00:00
Renzo Olivares 2c477b1812
SelectableRegion onSelectionChange should be called when the selection changes (#134215)
This change makes sure to call `onSelectionChange` in all cases when selection might change including:
* Dragging selection handles
* Mouse drag to select
* Keyboard actions
* Long press drag to select
2023-09-09 22:03:23 +00:00
engine-flutter-autoroll c7665ff84c
Roll Flutter Engine from b8afb6deacf3 to 4edbefa5e8f7 (1 revision) (#134360)
b8afb6deac...4edbefa5e8

2023-09-09 skia-flutter-autoroll@skia.org Roll Skia from 386c7a6a56fd to 1bb0f15f2cff (1 revision) (flutter/engine#45615)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-09-09 21:26:17 +00:00
engine-flutter-autoroll cc317dff86
Roll Flutter Engine from d1913cb6a276 to b8afb6deacf3 (1 revision) (#134356)
d1913cb6a2...b8afb6deac

2023-09-09 skia-flutter-autoroll@skia.org Roll Skia from 58e39bd84ab2 to 386c7a6a56fd (1 revision) (flutter/engine#45614)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-09-09 18:06:18 +00:00
engine-flutter-autoroll 7c28e8eb07
Roll Flutter Engine from 4e3231af6efc to d1913cb6a276 (1 revision) (#134355)
4e3231af6e...d1913cb6a2

2023-09-09 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from RbgNQ_B-mcwvmNSq3... to 51fG0shrG6fW64BtN... (flutter/engine#45612)

Also rolling transitive DEPS:
  fuchsia/sdk/core/mac-amd64 from RbgNQ_B-mcwv to 51fG0shrG6fW

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-09-09 16:48:23 +00:00
engine-flutter-autoroll 6660cc9816
Roll Flutter Engine from 348e3a376807 to 4e3231af6efc (1 revision) (#134353)
348e3a3768...4e3231af6e

2023-09-09 skia-flutter-autoroll@skia.org Roll Skia from 3dfd4316b80d to 58e39bd84ab2 (1 revision) (flutter/engine#45610)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-09-09 15:52:13 +00:00
Polina Cherkasova 5555836712
Day picker should dispose created MaterialStatesController's. (#133884)
Fixes https://github.com/flutter/flutter/issues/133862
2023-09-09 08:45:27 -07:00