development/flutter
development/flutter
1
0
Fork 0
mirror of https://github.com/flutter/flutter synced 2024-10-13 19:52:53 +00:00
Code Issues Packages Projects Releases Wiki Activity
14149 commits 770 branches 974 tags 1.7 GiB
Commit graph

10138 commits

Author SHA1 Message Date
Jonah Williams 6a250c8d65
update packages and unpin build (#32066) 2019-05-03 16:54:35 -07:00
Hans Muller 73957b94e7
Test Material buttons against a11y contrast guidelines (#32050) 2019-05-03 16:13:42 -07:00
Greg Spencer 11e0a725d4
Re-land: Add support for Tooltip hover (#31699) 
This is a re-land of #31561, after fixing performance regressions.

Added change listening to the MouseTracker so that the Listener and tooltip can react to whether or not a mouse is connected at all. Added a change check to make sure Listener only repaints when something changed.

Fixes #22817
 2019-05-03 13:00:36 -07:00
Gary Qian 3bd1737c0e
Partially Rollback caret change for Android (#32043) 2019-05-03 12:32:04 -07:00
Justin McCandless 0a3df1b576
Text wrap width (#31987) 
Add `textWidthBasis` param to Text to allow calculating width according to longest line.
 2019-05-03 11:41:07 -07:00
Furkan Tektas 299ce6e373 Cupertino Turkish Translation (#32013) 2019-05-03 11:03:25 -07:00
chunhtai 38808d9fe4
Reland fix 25807 implement move for sliver multibox widget (#31978) 2019-05-03 09:48:20 -07:00
Efthymis Sarmpanis 39d660be78 Extract TODO comment from Image.asset dardoc (#31903) 2019-05-03 08:29:02 -07:00
Efthymis Sarmpanis d095b05522 Updated primaryColor docs to refer to colorScheme properties (#31902) 2019-05-03 08:28:16 -07:00
Tong Mu 7beb09e76a
Redo "Remove pressure customization from some pointer events" (#30874) 
* Revert "Revert "Remove pressure customization from some pointer events (#30414)" (#30873)"

This reverts commit f34c2ef0a3.

* Revert pressure removal of PointerUpEvent

* Replace PR with an issue

* Add tests for fromMouseEvent
 2019-05-02 23:05:01 -07:00
Zachary Anderson 3d276cc6a8
[flutter_tool] Pull the right Fuchsia SDK for the platform (#31998) 2019-05-02 15:26:59 -07:00
MH Johnson a40e5c90f0
[Material] selected/unselected label styles + icon themes on BottomNavigationBar (#31018) 
* add text style params

* add icon theme params

* Added tests
 2019-05-02 18:20:16 -04:00
Kate Lovett 4676c66b9a
Merge branch 'gold' into master 2019-05-02 15:01:35 -07:00
Jonah Williams 1d91bd2583
Revert "Start abstracting platform logic builds behind a shared interface (#31889)" (#32003) 
This reverts commit e5459942c8.
 2019-05-02 14:14:46 -07:00
Jonah Williams e5459942c8
Start abstracting platform logic builds behind a shared interface (#31889) 2019-05-02 13:31:00 -07:00
Kate Lovett 80344acaaa
Comma Comma Nit Nit 2019-05-02 12:56:31 -07:00
chunhtai caebdaf1e8
fix issue 30526: rounding error (#30979) 2019-05-02 12:42:25 -07:00
Hans Muller 4230e9674c
Simplify drawer scrimColor defaults, update tests (#31947) 2019-05-02 11:57:01 -07:00
Justin McCandless 34325ba33a
Revert "Tight Paragraph Width (#30988)" (#31979) 
This reverts commit 323108ff47 due to weird engine dependency bug
 2019-05-02 10:36:51 -07:00
Justin McCandless 323108ff47
Tight Paragraph Width (#30988) 
Add `textWidthBasis` param to Text to allow calculating width according to longest line.
 2019-05-02 09:21:45 -07:00
James Lin 0c20a2ed01 Fix MediaQueryData.toString() to generate readable output 
MediaQueryData.toString() omitted commas and spaces around some
properties, making the output difficult to read.
 2019-05-02 08:44:51 -07:00
Todd Volkert f48cc4611a
Add documentation to Navigator (#31851) 2019-05-02 08:02:11 -07:00
Jonas Termansen 8b9eb3e2b2 Report CompileTime metric in flutter build aot --report-timings. (#31895) 
This is the correct metric to report for compilation time benchmarks rather
than RunTime. Rename the 'gen_snapshot' value to merely 'snapshot' for
backwards compatibility and overall simplicity.

This change simplifies Dart's benchmarking of Flutter by making it easier to
adopt --report-timings (made for Dart to use), which makes the benchmarks
much more robust.
 2019-05-02 15:22:43 +02:00
Jonah Williams 83aa065f6a
Add commands to swap dart imports for local development (#31925) 2019-05-02 01:14:15 -07:00
Jacob Richman e17f9e8ff8
Fix bug handling cyclic diagnostics. (#31960) 2019-05-01 22:09:53 -07:00
LongCatIsLooong 15f187fce0
Add docs to AppBar (#31317) 
- Added docs to AppBar to cover AppBar's inherited MediaQuery when not used in a Scaffold in general
- s/Hero]s/Hero]es/
 2019-05-01 20:39:37 -07:00
Dan Field 5b2281e747
Make Flex only overflow on epsilon (#31890) 2019-05-01 17:28:33 -07:00
Shi-Hao Hong 8959caa239
Update scrimDrawerColor with proper const format (#31938) 2019-05-01 15:18:08 -07:00
Diego Velásquez López d8bb880d08 added scrimColor property in Scaffold widget (#31025) 2019-05-01 14:50:52 -07:00
Shi-Hao Hong 7690bb47dc
Add Horizontal Padding to Constrained Chip Label Calculations (#31861) 
* Add horizontal padding and properly constrain chip label calculations

* Added regression test for avatar, label and delete icon constraint
 2019-05-01 13:46:36 -07:00
Dan Field df669ab1ea
Avoid NPE for flutter attach mDNS (#31926) 2019-05-01 13:41:00 -07:00
Zachary Anderson 6a69f8c98c
[fuchsia] Add support for the 'device' command using the SDK (#31910) 2019-05-01 13:24:09 -07:00
Jonah Williams 06973f58a7
Revert "Revert "fix edge swiping and dropping back at starting point (#31623)" (#31876)" (#31923) 2019-05-01 12:53:04 -07:00
Shi-Hao Hong 0c871b8528
Improve RadioListTile Callback Behavior Consistency (#31574) 2019-05-01 12:52:52 -07:00
Greg Spencer be75fb36c5
Change unfocus to unfocus the entire chain, Fix setFirstFocus (#31909) 
In #31614, I added an unfocus() to FocusNodes to allow giving up of focus, but it only worked on the primary focus. This changes that so that it will unfocus the entire chain, not just the primary focus. Now, if you call unfocus() on a FocusNode or FocusScopeNode, and their hasFocus returns true, then after calling unfocus(), it will return false. Before this change, it would only do that if hasPrimaryFocus was also true.

This also fixes a bug in the way setFirstFocus was implemented, making it conform more to the behavior of the previous implementation. It has simplified logic in reparent, and in when it requests focus for scope nodes that have had setFirstFocus called on them.
 2019-05-01 12:20:41 -07:00
Jacob Richman 63aa5b3647
Refactor core uses of FlutterError. (#30983) 
Make FlutterError objects more structured so they can be displayed better in debugging tools such as Dart DevTools.
 2019-05-01 11:20:12 -07:00
Todd Volkert 3d09f939ba
Make Gradle error message more specific (#31850) 2019-05-01 10:28:57 -07:00
Victor Maraccini 74c6237abc Fix bundle id on iOS launch using flutter run (#31039) 2019-05-01 10:21:43 -07:00
rami-a 6a1468db16
Add BottomSheetTheme to enable theming color, elevation, shape of BottomSheet (#31318) 
* Introduce BottomSheetTheme and shape support for bottom sheet

* Add bottom sheet theme to ThemeData. Use theme in bottom sheet build

* Expose color, elevation, shape to showModalBottomSheet helper

* Expose color, elevation, shape to showBottomSheet helper

* Address PR feedback

* Address PR feedback

* Address additional PR feedback
 2019-05-01 13:10:50 -04:00
Jonah Williams 60a1b2b9ea
Revert "Redo: Add buttons to gestures (#31819)" (#31912) 
This reverts commit fea2c7d671.
 2019-05-01 10:06:45 -07:00
Emmanuel Garcia 3e65bb060f
Fix #31764: Show appropriate error message when fonts pubspec.yaml isn't iterable 
Show appropriate error message when fonts isn't iterable
 2019-05-01 09:49:39 -07:00
Dan Field a8504405a8
Revert "Handle notification errors (#31868)" (#31886) 
This reverts commit c0d5fd23ab.
 2019-04-30 23:27:30 -07:00
Jonah Williams c82fc132a8
add stderr to log processor for desktop (#31874) 2019-04-30 19:18:15 -07:00
Gary Qian 4102486d63
Center iOS caret, remove constant offsets that do not scale (#31687) 2019-04-30 17:41:01 -07:00
chunhtai e2dfd73c2e
only build asset when there is asset declared in pubspec (#31804) 2019-04-30 16:03:47 -07:00
Jonah Williams 514fb2c7c0
Revert "fix edge swiping and dropping back at starting point (#31623)" (#31876) 2019-04-30 15:44:09 -07:00
Dan Field 4bc35fc87a
Allow DSS to be dragged when its children do not fill extent (#31832) 
* Allow DSS to be dragged when its children do not fill extent

* Fix when maxChildSize  < 1.0
 2019-04-30 15:42:42 -07:00
Dan Field c0d5fd23ab
Handle notification errors (#31868) 2019-04-30 15:42:22 -07:00
Jonah Williams 5e77d6508e
Initial sketch of tools testbed (#31765) 2019-04-30 15:42:16 -07:00
Jonah Williams 48936d9a95
Remove deprecated commands (#31759) 2019-04-30 14:43:03 -07:00
liyuqian fb87619143
Fix prefer_const_constructors (#31860) 
This will fix our flutter build post-submit analyze test

Merge on red to fix flutter build
 2019-04-30 10:38:26 -07:00
Tong Mu fea2c7d671
Redo: Add buttons to gestures (#31819) 
* Revert "Revert "Add buttons to gestures (#30339)" (#31801)"

This reverts commit 8fd7fa492a.

* Synthesise kPrimaryButton for unknown devices

* Change TestPointer to a better API
 2019-04-30 09:56:24 -07:00
liyuqian 71a89a469a
Reland "Fix text field selection toolbar under Opacity (#31097)" (#31802) 
This reverts commit 120a1fc47f.

Updated the golden file
 2019-04-30 09:47:32 -07:00
liyuqian 7cab6d5e1c
Support clipBehavior changes in hot reload (#31761) 
## Description

Make `_RenderCustomClip`'s `clipBehavior` non-final so we can update it during `updateRenderObject`. This will support `clipBehavior` changes in hot reload.

## Related Issues

Fixes #30863

## Tests

I added the following tests:

* ClipRect updates clipBehavior in updateRenderObject
* ClipRRect updates clipBehavior in updateRenderObject
* ClipOval updates clipBehavior in updateRenderObject
* ClipPath updates clipBehavior in updateRenderObject
* PhysicalModel updates clipBehavior in updateRenderObject
* PhysicalShape updates clipBehavior in updateRenderObject
 2019-04-30 09:46:38 -07:00
Keerti Parthasarathy eae67f05df
Make const available for classes that override AssetBundle (#31807) 2019-04-30 09:10:04 -07:00
Dan Field eac2104bc6
remove assert for Flutter Driver (#31815) 2019-04-29 17:03:25 -07:00
Shi-Hao Hong 39712854fc
Fix ExpansionPanelList Duplicate Global Keys Exception (#31228) 
- Move `setState` to only be invoked when guarded by `widget._allowMultiplePanelsOpen`, fixing the case for `ExpansionPanelList`

- Remove setting `_currentOpenPanel` to `widget.initialOpenPanelValue` in `didUpdateWidget`, since this should only occur on `initState` and not every time the widget is updated. This fixes the problem for `ExpansionPanelList.radio`

- Added a `didUpdateWidget` condition for when `ExpansionPanelList` changes into `ExpansionPanelList.radio` to open the panel at `widget.initialOpenPanelValue`

- Added test cases for regression, expansionCallback cases, and `didUpdateWidget` transitions between `ExpansionPanelList` and `ExpansionPanelList.radio`
 2019-04-29 16:55:05 -07:00
Jonah Williams 37e25238a8
Attempt to reduce usage of runtimeType (#31696) 2019-04-29 16:44:50 -07:00
Dan Field fe9512fa72
Re-enable const (#31600) 
* Re-enable const
 2019-04-29 16:02:42 -07:00
Jonah Williams 8fd7fa492a
Revert "Add buttons to gestures (#30339)" (#31801) 
This reverts commit 727e7e829f.
 2019-04-29 12:59:30 -07:00
Jonah Williams 120a1fc47f
Revert "Fix text field selection toolbar under Opacity (#31097)" (#31800) 2019-04-29 12:57:35 -07:00
liyuqian e427c2dd86
Fix text field selection toolbar under Opacity (#31097) 
## Description

As we've introduced offset to the Opacity layer, we have to override
`applyTransform` to make Leader/FollowerLayer work correctly.

## Related Issues

Fixes https://github.com/flutter/flutter/issues/30587

Together with https://github.com/flutter/engine/pull/8585,
this test will also exercise test against
https://github.com/flutter/flutter/issues/30586.

## Tests

I added the following tests:
* text field selection toolbar renders correctly inside opacity
 2019-04-29 11:25:41 -07:00
xster d12f359991
fix edge swiping and dropping back at starting point (#31623) 2019-04-29 11:05:24 -07:00
Tong Mu 727e7e829f
Add buttons to gestures (#30339) 
* Callbacks of tap, long press, drag, and double tap GR respond to only primary events.
* Add "secondary" callbacks to tap.
* Recognizers only compete on events if there are any related callbacks.
* Add "kSecondaryButton" constant.
 2019-04-29 10:46:33 -07:00
Jonah Williams c1c15dd702
Revert "update packages and unpin build (#31736)" (#31795) 2019-04-29 09:56:55 -07:00
Jonah Williams 41b18422df
update packages and unpin build (#31736) 2019-04-29 09:10:01 -07:00
Jonah Williams 4ff467191b
make FlutterProject synchronous (#31757) 2019-04-29 08:21:32 -07:00
MH Johnson 5412ef07f2
[Material] Update TabController to support dynamic Tabs (#30884) 
* Update TabController to support dynamic tabs.

* Added test for single Tab showing correct color.
 2019-04-29 10:35:55 -04:00
Dmitriy Zaitsev 8e66c53f3d Fix the documentation for UiKitView#creationParams (#31619) 
It looks like the documentation for UiKitView has been copy-pasted from AndroidView or so.
This PR fixes the word 'Android' to 'iOS' for the `creationParams`.
 2019-04-29 14:50:44 +02:00
Sander Kersten 9d16b84b35 Fix calculation of hero rectTween when Navigator isn't fullscreen (#29677) 2019-04-29 14:43:44 +02:00
James D. Lin ae5749819b Make the matchesGoldenFile docs link to an explanation of how to create golden image files (#31093) 2019-04-29 14:43:24 +02:00
Antti Ahti bf8262d85b Remove trailing whitespace from README template (#31762) 2019-04-29 13:04:55 +02:00
Kent Boogaart 392d5b2c28 Fix typo (#31771) 2019-04-29 13:04:30 +02:00
Shi-Hao Hong 7c4ccb349e
Improve ThemeData.accentColor connection to secondary color (#31295) 2019-04-26 19:39:22 -07:00
K. P. Sroka 59f4e92b6e Update onChange docs to Radio and RadioListTile 
Added note that onChange callback will not be invoked if the radio is already selected
 2019-04-26 19:36:22 -07:00
xster 26d7f502a9
Add some docs to StatefulBuilder (#31291) 2019-04-26 18:10:18 -07:00
Greg Spencer 7565093f3e
Revert "Add support for Tooltip hover (#31561)" (#31692) 
This reverts commit eca9364069 because of four
performance regressions. Will fix and re-land.
 2019-04-26 14:29:19 -07:00
Dan Field 6a48e663ef
Bottom sheet scrolling (#21896) 2019-04-26 14:12:11 -07:00
Danny Tuppeny fdcc8aafa7
Allow adb stdout to contain the port number without failing (#31491) 
* Allow adb stdout to contain the port number without failing

* Add tests that port forwarder correctly responds to known ADB output
 2019-04-26 21:03:25 +01:00
Jonah Williams 9d364043af
Refactor the test compiler into a separate library (#31642) 2019-04-26 12:33:41 -07:00
chunhtai d121df9987
fix 31511: Test performance has regressed (#31582) 2019-04-26 09:02:38 -07:00
Shi-Hao Hong 14f2f98f9d
Add InkWell docs on transitions and ink splash clipping (#31316) 2019-04-26 07:55:29 -07:00
Dan Field 81803cacf3
Remove engine tests (#31452) 2019-04-26 01:01:51 -07:00
LongCatIsLooong 7d19f97d03
Fix refresh control in the gallery demo, update comments (#30129) 
- Fixed the bug where CupertinoRefreshControl doesn't work in the gallery demo on Android.
- Updated documentation on CupertinoRefreshControl
- Added comments to the gallery demo
- Added concrete examples to ScrollPhysics
 2019-04-25 20:49:47 -07:00
Todd Volkert e57d0ff73b
Fix doc link (#31638) 2019-04-25 20:31:45 -07:00
Greg Spencer 7775c23784
[Re-Land] Implement focus traversal for desktop platforms. (#31614) 
This re-lands the Focus changes in #30040. Correctness changes in routes.dart, and removes the automatic requesting of focus on reparent when there is no current focus, which caused undesirable selections.

Addresses #11344, #1608, #13264, and #1678
Fixes #30084
Fixes #26704
 2019-04-25 16:26:58 -07:00
Kate Lovett fdd554fb46 Anaalyzer fixes. 2019-04-25 15:59:48 -07:00
Jonah Williams fdae7bb871
add check that xcode project configuration is not missing (#31621) 2019-04-25 15:51:25 -07:00
Jonah Williams 0acd3e6b04
refactor context to be implicit-downcast safe (#31622) 2019-04-25 15:51:08 -07:00
Kate Lovett abb555fe94 Modified platform specific golden file test. 2019-04-25 15:50:53 -07:00
Kate Lovett 04ad0ffa1e Style nits 2019-04-25 15:30:58 -07:00
Kate Lovett 328647aa6e Removed matchesGoldenFile and skips 2019-04-25 15:16:57 -07:00
Kate Lovett 8861e9f3dc Cleanup 2019-04-25 14:51:59 -07:00
Jonah Williams 52415cb0a5
baby-steps to testing/refactoring flutter_platform (#31616) 2019-04-25 14:01:28 -07:00
Greg Spencer eca9364069
Add support for Tooltip hover (#31561) 
Adds support for mouse pointer hovering to trigger tooltips, as well as custom timeouts for the tooltip durations, and a custom decoration. It also makes the tooltip be fully opaque when shown, and fade in over 150ms, and fade out over 75ms, and draw a 4.0 corner radius, all to conform with the material spec. Prior to this change, it was using a corner radius of 2.0 when shown, and faded in and out over 200ms.

Fixes #22817
 2019-04-25 13:39:52 -07:00
Justin McCandless a21a1f4105
iOS selection handles are invisible (#31332) 
Fix a bug where text selection handles were invisible in iOS
 2019-04-25 12:32:10 -07:00
Jonah Williams 6b191841f3
Allow filtering devices to only those supported by current project (#31446) 2019-04-25 12:25:12 -07:00
Kate Lovett e332ab859a Changed implementation to incorpoarate new init feature for goldctl. Reduces redundant work as well. 2019-04-25 12:18:56 -07:00
Phil Quitslund 5ec33654b1
fix transform assert (#31568) 
* fix transform assert
 2019-04-25 10:56:44 -07:00
Kate Lovett a38311e6c8 Fixing duplicate test names. 2019-04-25 10:05:13 -07:00