development/flutter
development/flutter
1
0
Fork 0
mirror of https://github.com/flutter/flutter synced 2024-10-13 11:42:54 +00:00
Code Issues Packages Projects Releases Wiki Activity

Improve RadioListTile Callback Behavior Consistency (#31574)

Browse source
This commit is contained in:
Shi-Hao Hong 2019-05-01 12:52:52 -07:00 committed by GitHub
parent be75fb36c5
commit 0c871b8528
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 168 additions and 13 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
packages/flutter/lib/src/material/radio_list_tile.dart
View file

@ -231,7 +231,7 @@ class RadioListTile<T> extends StatelessWidget {
isThreeLine: isThreeLine,
dense: dense,
enabled: onChanged != null,
onTap: onChanged != null ? () { onChanged(value); } : null,
onTap: onChanged != null && !checked ? () { onChanged(value); } : null,
selected: selected,
),
),

179
packages/flutter/test/material/control_list_tile_test.dart
View file

@ -34,20 +34,175 @@ void main() {
expect(log, equals(<dynamic>[false, '-', false]));
});
testWidgets('RadioListTile control test', (WidgetTester tester) async {
testWidgets('RadioListTile should initialize according to groupValue', (WidgetTester tester) async {
final List<int> values = <int>[0, 1, 2];
int selectedValue;
// Constructor parameters are required for [RadioListTile], but they are
// irrelevant when searching with [find.byType].
final Type radioListTileType = const RadioListTile<int>(
value: 0,
groupValue: 0,
onChanged: null,
).runtimeType;
List<RadioListTile<int>> generatedRadioListTiles;
List<RadioListTile<int>> findTiles() => find
.byType(radioListTileType)
.evaluate()
.map<RadioListTile<int>>((Element element) => element.widget)
.toList();
Widget buildFrame() {
return wrap(
child: StatefulBuilder(
builder: (BuildContext context, StateSetter setState) {
return Scaffold(
body: ListView.builder(
itemCount: values.length,
itemBuilder: (BuildContext context, int index) => RadioListTile<int>(
onChanged: (int value) {
setState(() { selectedValue = value; });
},
value: values[index],
groupValue: selectedValue,
title: Text(values[index].toString()),
),
),
);
},
),
);
}
await tester.pumpWidget(buildFrame());
generatedRadioListTiles = findTiles();
expect(generatedRadioListTiles[0].checked, equals(false));
expect(generatedRadioListTiles[1].checked, equals(false));
expect(generatedRadioListTiles[2].checked, equals(false));
selectedValue = 1;
await tester.pumpWidget(buildFrame());
generatedRadioListTiles = findTiles();
expect(generatedRadioListTiles[0].checked, equals(false));
expect(generatedRadioListTiles[1].checked, equals(true));
expect(generatedRadioListTiles[2].checked, equals(false));
});
testWidgets('RadioListTile control tests', (WidgetTester tester) async {
final List<int> values = <int>[0, 1, 2];
int selectedValue;
// Constructor parameters are required for [Radio], but they are irrelevant
// when searching with [find.byType].
final Type radioType = const Radio<int>(
value: 0,
groupValue: 0,
onChanged: null,
).runtimeType;
final List<dynamic> log = <dynamic>[];
await tester.pumpWidget(wrap(
child: RadioListTile<bool>(
value: true,
groupValue: false,
onChanged: (bool value) { log.add(value); },
title: const Text('Hello'),
),
));
await tester.tap(find.text('Hello'));
Widget buildFrame() {
return wrap(
child: StatefulBuilder(
builder: (BuildContext context, StateSetter setState) {
return Scaffold(
body: ListView.builder(
itemCount: values.length,
itemBuilder: (BuildContext context, int index) => RadioListTile<int>(
onChanged: (int value) {
log.add(value);
setState(() { selectedValue = value; });
},
value: values[index],
groupValue: selectedValue,
title: Text(values[index].toString()),
),
),
);
},
),
);
}
// Tests for tapping between [Radio] and [ListTile]
await tester.pumpWidget(buildFrame());
await tester.tap(find.text('1'));
log.add('-');
await tester.tap(find.byType(const Radio<bool>(value: false, groupValue: false, onChanged: null).runtimeType));
expect(log, equals(<dynamic>[true, '-', true]));
await tester.tap(find.byType(radioType).at(2));
expect(log, equals(<dynamic>[1, '-', 2]));
log.add('-');
await tester.tap(find.text('1'));
log.clear();
selectedValue = null;
// Tests for tapping across [Radio]s exclusively
await tester.pumpWidget(buildFrame());
await tester.tap(find.byType(radioType).at(1));
log.add('-');
await tester.tap(find.byType(radioType).at(2));
expect(log, equals(<dynamic>[1, '-', 2]));
log.clear();
selectedValue = null;
// Tests for tapping across [ListTile]s exclusively
await tester.pumpWidget(buildFrame());
await tester.tap(find.text('1'));
log.add('-');
await tester.tap(find.text('2'));
expect(log, equals(<dynamic>[1, '-', 2]));
});
testWidgets('Selected RadioListTile should not trigger onChanged', (WidgetTester tester) async {
// Regression test for https://github.com/flutter/flutter/issues/30311
final List<int> values = <int>[0, 1, 2];
int selectedValue;
// Constructor parameters are required for [Radio], but they are irrelevant
// when searching with [find.byType].
final Type radioType = const Radio<int>(
value: 0,
groupValue: 0,
onChanged: null,
).runtimeType;
final List<dynamic> log = <dynamic>[];
Widget buildFrame() {
return wrap(
child: StatefulBuilder(
builder: (BuildContext context, StateSetter setState) {
return Scaffold(
body: ListView.builder(
itemCount: values.length,
itemBuilder: (BuildContext context, int index) => RadioListTile<int>(
onChanged: (int value) {
log.add(value);
setState(() { selectedValue = value; });
},
value: values[index],
groupValue: selectedValue,
title: Text(values[index].toString()),
),
),
);
},
),
);
}
await tester.pumpWidget(buildFrame());
await tester.tap(find.text('0'));
await tester.pump();
expect(log, equals(<int>[0]));
await tester.tap(find.text('0'));
expect(log, equals(<int>[0]));
await tester.tap(find.byType(radioType).at(0));
await tester.pump();
expect(log, equals(<int>[0]));
});
testWidgets('SwitchListTile control test', (WidgetTester tester) async {