Commit graph

12934 commits

Author SHA1 Message Date
Jonah Williams bb5c340066
[flutter_tools] cache the base URL as index.html (#53666) 2020-04-01 00:36:02 -07:00
cjng96 d62c7ecce5
Ignore key events on edit control on web platform (#52656) (#52661) 2020-04-01 00:31:03 -07:00
Greg Spencer 2a649b16e2
Add an adaptive visual density static function, and add it to… (#51921)
Adds a VisualDensity.adaptivePlatformDensity static function that returns different values for visual density based on the defaultTargetPlatform. Returns compact for desktop platforms, and a default visual density for other platforms.
2020-03-31 16:16:25 -07:00
Jose Alba d14a301e41
Revert "[Slider] Rebase. (#52663)" (#53698)
This reverts commit e71cf1cdbe.
2020-03-31 16:14:22 -07:00
Jenn Magder ad07c4041a
Delete unused NDK location checks (#53694) 2020-03-31 14:53:49 -07:00
Gary Qian 6280b39164
Un-gate value setting in formatter repeat check logic (#53613) 2020-03-31 13:16:02 -07:00
Kate Lovett cb4147cf73
Doc Improvements (#53377) 2020-03-31 13:11:02 -07:00
Mubarak Imam df90bb5fd6
fix issue with multiple java runtimes on macOS (#52474) 2020-03-31 11:36:01 -07:00
nujz fcd90c0a51
ScrollPosition.jumpTo call notifyListeners twice (#53425) 2020-03-31 11:26:02 -07:00
Jonah Williams 7bf74c3460
[flutter_tools] handle unsafe build outputs (#53601) 2020-03-31 11:01:01 -07:00
Jose Alba e71cf1cdbe
[Slider] Rebase. (#52663) 2020-03-31 10:56:01 -07:00
stuartmorgan a2d62df3ee
Use feature flags for desktop cache (#53608) 2020-03-30 21:51:48 -07:00
chunhtai aee9e94c21
Revert "Implements the navigator page api (#50362)" (#53610)
This reverts commit 9a6eb7def3.
2020-03-30 16:12:40 -07:00
Jonah Williams 8cb1d269f6
[versions] update EVERYTHING (#53467) 2020-03-30 14:09:38 -07:00
Shi-Hao Hong 85e5b210b4
Implement DropdownMenuItem.onTap (#53368)
* Implement DropdownMenuItem.onTap
2020-03-30 13:48:40 -07:00
Darren Austin c7a6e300dd
Fixed a bug with the month grid showing the wrong month after selecting a date. (#53594) 2020-03-30 13:45:33 -07:00
Ayush Bherwani 08ee37e1c1
[RefreshIndicator] adds strokeWidth parameter to RefreshIndicator (#53344) 2020-03-30 12:56:06 -07:00
Jonah Williams 72343ee0e4
[flutter_tools] refactor build_system and targets to be context-free (#53268) 2020-03-30 12:51:04 -07:00
Jonah Williams 4605b51a7e
[flutter_tools] use package Uuid consistently (#53492) 2020-03-30 12:46:06 -07:00
Shi-Hao Hong 57d7946b2f
Implement DropdownButton and DropdownButtonFormField onTap callback (#53105) 2020-03-30 12:46:02 -07:00
Ayush Bherwani b665533060
[MediaQueryData] adds assertions to MediaQueryData Constructor (#53003) 2020-03-30 12:41:03 -07:00
Shi-Hao Hong f36a49762b
Refresh Material and Cupertino localizations (#53448) 2020-03-29 13:36:01 -07:00
Dan Field c8efcb632b
Only fetch tags when not on dev/beta/stable (#53450) 2020-03-27 22:31:01 -07:00
Jonah Williams dfc3318e87
[flutter_tools] dont create synthetic sdk when running consumer-only (#53466) 2020-03-27 22:25:09 -07:00
Jonah Williams 8403930d41
[flutter_tools] unpin SDK deps when upgrading packages (#53429) 2020-03-27 22:11:01 -07:00
Pieter van Loon 6c9071d3c2
Added parallax effect for cupertino fullscreenDialog (#50180) 2020-03-27 22:06:01 -07:00
stuartmorgan 94500073a0
Windows template update project (#53302)
Updates the Windows app template to use the new DartProject API, significantly simplifying the template.

Increments the template version, even though this isn't itself a breaking change, so that users will be prompted to update their projects rather than be broken later when the old API is removed.
2020-03-27 16:36:15 -07:00
chunhtai 9a6eb7def3
Implements the navigator page api (#50362) 2020-03-27 16:24:01 -07:00
Jenn Magder ce40fbaf51
Include metadata in GitHub crash template (#53118) 2020-03-27 16:21:45 -07:00
Darren Austin 4dd9136397
Reset autovalidate in the text input form field of the Date Picker when switching back to input mode from calendar mode. (#53434) 2020-03-27 15:06:01 -07:00
Onat Çipli ac3b77bdac
Scrollbar display always (#50752) 2020-03-27 14:51:03 -07:00
Ferhat 763f875441
Treeshake debugFillProperties (#53303) 2020-03-27 14:50:03 -07:00
Jenn Magder 57b0ddbd60
Uninstall app flag (#53385) 2020-03-27 10:13:54 -07:00
Jonah Williams be3a4b37b3
[flutter_tools] don't trim log messages from the web (#53379) 2020-03-26 18:08:05 -07:00
Jonah Williams 2717eb6413
[flutter tools] rewrite launch non-prebuilt app tests (#53351) 2020-03-26 17:36:02 -07:00
Jonah Williams c5800fe107
[flutter_tools] update iOS deploy tests for best practices (#53343) 2020-03-26 17:31:01 -07:00
Dmitry Borodin 5a3e7e4366
Updated obsolete URL (#52158) 2020-03-26 14:34:00 -07:00
Dan Field ed67c47982
Add error callbacks to other image resolving code (#53329) 2020-03-26 13:36:03 -07:00
Anthony 0d111bc91a
[Material] Create a Navigation Rail component and theme (#49574) 2020-03-26 13:31:02 -07:00
Zachary Anderson 9d97918c60
[flutter_tools] Prepare for OSError to implement Exception (#53258) 2020-03-26 09:51:01 -07:00
Jenn Magder 8a9023522c
Push iMobileDevice and iosDeploy instantiation into XCDevice constructor (#53307) 2020-03-25 18:12:13 -07:00
Jonah Williams e23c4796a3
Expose extra frontend options through build apk/ios/macOS (#53273)
This will allow experimenting with the remove to string transformer before we're ready to turn it on by default. This doesn't work for web yet since we use dart2js instead of the frontend_server for producing kernel
2020-03-25 16:56:41 -07:00
xster 1376746237
Reland #53153 to attach to existing modules and apps for Android (#53289) 2020-03-25 16:45:49 -07:00
aoisensi eb85557a77
fix typo? (#52921) 2020-03-25 16:26:02 -07:00
Angjie Li 6083f15805
Allow user to specify which Chrome binary to use. (#53275)
* Allow user to specify which Chrome binary to use.
2020-03-25 15:55:32 -07:00
Jenn Magder ee3920c208
Remove SimControl from context (#53304) 2020-03-25 15:40:42 -07:00
adityapstar a57feac62e
fixed typo in HttpClient failure message (#53211) 2020-03-25 15:26:01 -07:00
Jenn Magder ba57ea09d1
Revert "Move processUtils into globals (#53209)" (#53301) 2020-03-25 14:59:03 -07:00
Jenn Magder 86389be66e
Convert CocoaPods tests to testWithoutContext (#53291) 2020-03-25 13:27:10 -07:00
Jenn Magder ec3653f41d
Remove XcodeValidator from context (#53213) 2020-03-25 11:57:05 -07:00
Dan Field 31175eb008
Revert "Revert "Replace uses of deprecated CastError with TypeError (#53221)" (#53226)" (#53269) 2020-03-25 11:26:02 -07:00
Jenn Magder 9ccac00599
Move processUtils into globals (#53209) 2020-03-25 11:23:08 -07:00
Michael Thomsen 29913c9011
Expose new pub outdated command (#53251) 2020-03-25 11:21:03 -07:00
Jenn Magder b860a3912b
Increase xcdevice timeout to 2 seconds (#53184) 2020-03-25 11:14:22 -07:00
Jenn Magder 207efd4cee
Convert idevicescreenshot and upgradePbxProjWithFlutterAssets tests to testWithoutContext (#53208) 2020-03-25 11:14:00 -07:00
Zachary Anderson 52e4011a3a
[flutter_tool] Timeout the Azure bot detector http request (#53217) 2020-03-25 11:11:03 -07:00
chunhtai 13fa5734f8
Reland fixes sliver list child layout offset calculation (#53187) 2020-03-25 11:06:02 -07:00
Jenn Magder b684041bb8
Revert "Let flutter attach find the service port by looking through old logs again (#53153)" (#53282)
This reverts commit 0c5ffdc9ef.
2020-03-25 10:53:45 -07:00
xster 0c5ffdc9ef
Let flutter attach find the service port by looking through old logs again (#53153) 2020-03-24 23:26:01 -07:00
Leaf Petersen 6563b0de34
Revert "Replace uses of deprecated CastError with TypeError (#53221)" (#53226)
This reverts commit 6c7c2e372a.
2020-03-24 23:02:41 -07:00
Leaf Petersen 6c7c2e372a
Replace uses of deprecated CastError with TypeError (#53221) 2020-03-24 22:11:46 -07:00
Darren Austin 142b526f1b
Material Date Picker redesign (#50546)
Date Picker UI redesign
2020-03-24 18:44:57 -07:00
Dan Field 25ef78e234
Revert "Revert "Fix RefreshIndicator performance issue (#47667)" (#53149)" (#53206) 2020-03-24 17:56:01 -07:00
Jenn Magder c93847d187
Remove IOSDeploy from globals, hoist to XCDevice constructor (#53203) 2020-03-24 16:50:35 -07:00
Jussi Lahdenniemi 600a3a74ea
Fix to DrawerController: Call the callback when drawer opened/closed with a fling. (#52593) 2020-03-24 15:56:03 -07:00
Jenn Magder 778c2ce923
Convert some code_signing_tests to testWithoutContext (#53142) 2020-03-24 15:30:35 -07:00
Jenn Magder 151c8db7dc
Remove dead vmservice.RPCError catch (#53193) 2020-03-24 13:35:29 -07:00
Jonah Williams 8e492fa845
[flutter_tools] fix type error with AppDomain current directory (#53181) 2020-03-24 12:58:40 -07:00
Jonah Williams b5cd3ce854
[flutter_tools] test and catch more exception types in web runner (#53183) 2020-03-24 12:58:30 -07:00
Devon Carew d6614dbafd
save and restore the chrome session local storage information (#53030)
save and restore the chrome session local storage information
2020-03-24 12:20:13 -07:00
Jenn Magder c9323bdccd
Convert cocoapods_validator_test to testWithoutContext (#53177) 2020-03-24 11:34:57 -07:00
Jenn Magder 70c651b0a4
Move BuildSystem to globals (#53139) 2020-03-24 11:23:10 -07:00
Jenn Magder 0b321e6715
Remove IMobileDevice from globals, hoist to XCDevice constructor (#53144)
* Convert ios_device_logger_test.dart to testWithoutContext

* Remove IMobileDevice from globals, hoist to XCDevice constructor
2020-03-24 11:22:54 -07:00
Jenn Magder 404bb5a572
Convert analyze_test to testWithoutContext (#53141) 2020-03-24 11:22:34 -07:00
Dan Field f3d95cd734
Revert "Fix RefreshIndicator performance issue (#47667)" (#53149)
This reverts commit 602ac0bc10.
2020-03-24 09:55:47 -07:00
Lasse R.H. Nielsen af5194dbfd
Prepare Flutter for SDK changes to runZoned. (#52953)
The `runZoned` method deprecates the `onError` parameter.
Invocations using that parameter must use `runZonedGuarded` instead.

This prepares Flutter for the deprecation. The same places need to be migrated to using
`runZonedGuarded` when the SDK change has been ported to Flutter.
Then the deprecated member will be removed in a follow-up CL when the most important
packages have been migrated.
2020-03-24 08:34:17 -07:00
Jonah Williams 10571920c0
[flutter_tools] update to latest dwds API (#52936)
Should fix issues introduced in web-server device and allow loading org-dartlang-app URIs
2020-03-23 18:47:50 -07:00
chunhtai 2a8e7b7bf1
fix changinternalstate crash when remove local history entry in final… (#52561) 2020-03-23 13:36:01 -07:00
Ferhat fed6887aa0
Remove implements Function (#53113) 2020-03-23 11:54:32 -07:00
Justin McCandless 197ac5256e
Enable CupertinoContextMenu on Web (#52977) 2020-03-23 11:01:02 -07:00
chunhtai 9f4e5ad9c3
Fix ios black screen during splash screen if widget binding initializ… (#52913) 2020-03-23 10:56:01 -07:00
Christian Mürtz 602ac0bc10
Fix RefreshIndicator performance issue (#47667) 2020-03-23 10:51:02 -07:00
stuartmorgan 685e9d1e47
Add pre-stable support for create on Windows (#51895)
Adds initial support for flutter create of apps and plugins. This is derived from the current FDE example app and sample plugin, adding template values where relevant.

Since the APIs/tooling/template aren't stable yet, the app template includes a version marker, which will be updated each time there's a breaking change. The build now checks that the template version matches the version known by that version of the tool, and gives a specific error message when there's a mismatch, which improves over the current breaking change experience of hitting whatever build failure the breaking change causes and having to figure out that the problem is that the runner is out of date. It also adds a warning to the create output about the fact that it won't be stable.

Plugins don't currently have a version marker since in practice this is not a significant problem for plugins yet the way it is for runners; we can add it later if that changes.

Fixes #30704
2020-03-23 10:42:26 -07:00
LongCatIsLooong 87cbddddd8
Let cupertino & material switches move to the right state after dragging (#51606) 2020-03-20 15:56:01 -07:00
Jonah Williams b1664a27d9
ensure default value for report timings (#52978) 2020-03-20 14:30:33 -07:00
Jonah Williams 441665e21a
[flutter_tools] split logger test and create log reader testing interface (#52934) 2020-03-20 13:46:39 -07:00
Jonah Williams 590f22ce82
[flutter_tools] restore report timings functionality to build aot (#52918) 2020-03-20 13:46:19 -07:00
Christopher Fujino 7d1fbcae1a
Refactor exits happy (#52916) 2020-03-20 13:05:19 -07:00
Yegor 2e36be7691
Enable more material and cupertino tests on the Web (#52961) 2020-03-20 11:36:24 -07:00
Tong Mu bbc0cc07f6
Move mouse_tracking.dart to rendering (#52781)
* Move mouse_tracking to rendering

* Move test
2020-03-20 11:22:02 -07:00
Yegor 5ea13b8493
fix KeySet.hashCode; enable multiple web tests (#52861)
fix KeySet.hashCode; enable multiple web tests
2020-03-20 08:49:19 -07:00
chunhtai 3998549d52
Revert "fixes sliver list child layout offset calculation (#42703)" (#52923)
This reverts commit 11efa00f9f.
2020-03-20 06:07:25 -07:00
Jonah Williams a13c9cfc48
[flutter_tools] fix toFilePath called on null (#52931)
In certain circumstances, the .packages file or dart cache could be missing - since the tool runs from a snapshot this is otherwise fine.
2020-03-19 22:20:15 -07:00
Michael Thomsen 4106fbd99c
Allow recent Dart language features (#52879) 2020-03-19 16:54:34 -07:00
Jonah Williams 62c9c89d6b
[flutter_tools] split start app android tests into new file (#52906) 2020-03-19 16:53:19 -07:00
Jonah Williams 5b956fd8f6
[flutter_tools] split isSupportedForProject test into new file (#52911) 2020-03-19 16:42:05 -07:00
Chris Yang b05210c707
Move ios screenshot test to flutter gold. (#52553) 2020-03-19 16:27:41 -07:00
Kirill Pertsev bae2f2c108
Enables log reader on iOS Simulator to (rudimentary) process multiline messages (#52452) 2020-03-19 15:41:39 -07:00
rami-a e2610a450c
[Material] Allow Appbar to exclude header semantics (#52894) 2020-03-19 15:06:02 -07:00
Jason Simmons bbc9d4f3a6
Do not check the executable status of gen_snapshot if it has not yet been downloaded (#52574) 2020-03-19 15:01:02 -07:00
Jonah Williams d20242b703
[flutter_tools] refactor ios install/uninstall to new file (#52891) 2020-03-19 14:53:14 -07:00
Jonah Williams b21e780aee
[flutter_tools] refactor AotBuilder, removing globals and duplicated kernel compilation (#52896)
Reland of #52091
2020-03-19 14:52:42 -07:00
chunhtai 11efa00f9f
fixes sliver list child layout offset calculation (#42703) 2020-03-19 14:51:04 -07:00
Jonah Williams 9391e480b2
Revert "[flutter_tools] refactor GenSnapshot and AotBuilder (#52091)" (#52893)
This reverts commit f65421aaca.
2020-03-19 10:16:20 -07:00
Jenn Magder a61bff2fcf
Show Xcode workspace clean output with verbose flag (#52860) 2020-03-19 09:51:01 -07:00
Jonah Williams f65421aaca
[flutter_tools] refactor GenSnapshot and AotBuilder (#52091)
Remove dependency injection from GenSnapshot and AotBuilder and update tests to use FakeProcessManager
2020-03-19 09:36:38 -07:00
Jonah Williams fe310148a1
[flutter_tool] Remove extra usage of .packages in vm service API (#52845) 2020-03-19 09:35:57 -07:00
Dan Field 53dc8db0e8
Do not throw when trying to discover a fuchsia device and the sshConfig is invalid (#52858)
* Do not throw when trying to discover a fuchsia device and the sshConfig is invalid
2020-03-19 09:28:54 -07:00
Ayush Bherwani 6c2a29dd37
[Api Docs] Improves contentPadding documentation in InputDecoration (#52807) 2020-03-19 09:26:02 -07:00
Jonah Williams 73b6702dee
[flutter_tools] refactor iOS tests for Device.startApp into new file (#52854) 2020-03-18 17:43:25 -07:00
Gary Qian ee8131b430
Reland formatter changes (#52765) 2020-03-18 15:56:02 -07:00
Jenn Magder ee845255de
Move XcodeProjectInterpreter to globals (#52847) 2020-03-18 15:55:09 -07:00
Jenn Magder e0ab6fc00c
Move outputPreferences to globals (#52846) 2020-03-18 15:54:26 -07:00
Jonah Williams 0274f170fb
[flutter_tools] have the tool print the current canvaskit mode when toggling (#52841) 2020-03-18 15:51:23 -07:00
Yegor 7b4c195f99
Fix web test flakiness; enable web golden tests (#52789)
* Fix web test flakiness; enable web golden tests

The fix is three-part:

- Only allow one test to load _and_ test at any point in time.
- Use a fresh Chrome instance for each test file.
- Increase Cirrus resources.

The first two changes only fix the "Unknown error loading" error, but not hanging tests. The resource increase also prevents hanging tests.

Other minor changes:

- Remove test batching (it's no longer necessary)
- Fix the Chrome class, which was using the wrong Completer.
2020-03-18 15:11:48 -07:00
Kate Lovett ea67a65bde
Re-land Luci Support for Gold (#52760) 2020-03-18 12:56:02 -07:00
Christopher Fujino 2d9902d9ac
Cleanup ios devices (#52568) 2020-03-18 12:51:01 -07:00
Zachary Anderson e8778da12c
[flutter_tools] Don't crash when analytics fails to initialize (#52775) 2020-03-18 10:00:14 -07:00
Michael Goderbauer 1444e77205
Use stable IDs for TextSpan SemanticsNodes (#52769) 2020-03-18 09:56:02 -07:00
Jonah Williams 542feb4736
[flutter_tools] remove unused Snapshot.dart artifact and associated code (#52821) 2020-03-18 09:18:41 -07:00
Jonah Williams da0788a180
Update fuchsia remote debug protocol to use package:test shim instead of package:test_api (#52706)
This is necessary to ensure the tests can run in google3. Fixes https://b.corp.google.com/issues/151657461
2020-03-18 09:12:46 -07:00
Justin McCandless a811bce4b0
TextField behavior when at maxLength (#52130)
TextFields now disallow adding characters in the center of the text at maxLength.
2020-03-18 08:02:22 -07:00
Jonah Williams b7101b45f5
[flutter_tools] disable added integration test due to Cirrus flakes (#52782) 2020-03-17 19:07:22 -07:00
Jonah Williams 46f0a5f7b5
[flutter_tools] Reland android device cleanup. (#52686) 2020-03-17 17:58:39 -07:00
Jonah Williams 90d6169678
[flutter_tools] refactor the IOSDevicePortForwarder and move tests out of devices_test.dart (#52772)
Updates the IOSDevicePortForwarder to no longer depend on context, or on an IOSDevice instance. Instead, it receives all necessary configuration through the constructor.

Moves the IOSDevicePortForwarder to a separate file.
2020-03-17 17:58:05 -07:00
Jonah Williams 6884086e5c
[flutter_tools] Update to latest dwds APIs (#51004)
Update to latest dwds APIs, moving back to dwds driven hot restart and enabling future work on expression evaluation.
2020-03-17 17:29:53 -07:00
gaaclarke 6990b8b2d3
Added the "trace-whitelist" flag to run. (#52556) 2020-03-17 16:42:20 -07:00
Jonah Williams f149eec31b
[flutter_tools] always initialize the resident runner from dill (#52497) 2020-03-17 16:37:06 -07:00
Ferhat d3a66e3107
[web] Add support for ChunkEvents during image loading (#52558)
* Add support for ChunkEvents for web
* Add lint skip for webOnly call in _network_image_web
2020-03-17 16:07:21 -07:00
Jenn Magder 757b39ba99
Ignore fuchsia device-finder no device error (#52761) 2020-03-17 16:02:45 -07:00
Christopher Fujino 071d4eb2c8
explicitly catch ArgumentError, and add tests (#52757) 2020-03-17 12:55:57 -07:00
Jonas Finnemann Jensen a4d30c1607
Add a comment for path dependencies in plugin example template (#50978) 2020-03-17 20:31:52 +01:00
Dan Field 08768e87e4
Revert repeater (#52752)
Reverts repeat filter logic for text formatter
2020-03-17 12:24:13 -07:00
Jonah Williams a7011c4817
[flutter_tools] don't force service worker cache files to be absolute (#52606) 2020-03-17 10:17:03 -07:00
Shi-Hao Hong 351457cdd0
[gen_l10n] Separate out AppLocalizations classes and subclasses by language code (#52335) 2020-03-17 08:46:02 -07:00
Jenn Magder 93a6057c42
Add SDK location unit tests (#52691) 2020-03-16 16:02:22 -07:00
Jenn Magder 2f216ceee5
Add timeout flag to devices command, pipe through discovery (#51678) 2020-03-16 14:15:00 -07:00
Jonah Williams 028b7dced1
[flutter_tools] remove context from WebWorkflow (#52613) 2020-03-16 11:33:00 -07:00
Kate Lovett 48fc135003
Revert "Refactoring Gold to enable both Luci & Cirrus support (#49815)" (#52670)
This reverts commit 7edcc92b10.
2020-03-16 10:26:09 -07:00
Greg Spencer acd51a726e
Make AnimatedSwitcher example into a dartpad example (#52547) 2020-03-16 09:02:08 -07:00
Michael Thomsen e167181444
Move flutter_gallery to the testing folder (#52532)
Move Flutter Gallery to dev/integration_tests/ as it is an older copy used only for testing. The current version of the Flutter Gallery now lives in https://github.com/flutter/gallery.
2020-03-16 10:31:42 +01:00
Kate Lovett 7edcc92b10
Refactoring Gold to enable both Luci & Cirrus support (#49815) 2020-03-13 20:11:01 -07:00
liyuqian 77c46276cc
Fix typo its to it's (#52580) 2020-03-13 20:01:01 -07:00
Michel Feinstein 34b7030c1e
Fixed a typo. (#52562) 2020-03-13 19:11:04 -07:00
Jenn Magder 73ea37eca9
Revert "Fall back to environment SDKROOT passed from Xcode (#52570)" (#52583)
This reverts commit 8e6e15f915.
2020-03-13 18:29:09 -07:00
Ayush Bherwani 60b9d15495
[RaisedButton] Added padding property to RaisedButton.icon (#52393) 2020-03-13 17:21:02 -07:00
Jenn Magder 8e6e15f915
Fall back to environment SDKROOT passed from Xcode (#52570) 2020-03-13 17:16:56 -07:00
Dan Field 98cf01858c
Fetch tags for version command (#52212) 2020-03-13 17:16:03 -07:00
Jonah Williams bbc5b9d967
Revert "[flutter_tools]: reland android device cleanup (#52542)" (#52579)
This reverts commit 9186dfc34d.
2020-03-13 16:38:59 -07:00
Kate Lovett aa622fbb26
Switching to Gold Status Check (#51968) 2020-03-13 11:41:01 -07:00
JosepBove 6c0d2db57a
Correct broken curves asset links (#52501) 2020-03-13 11:10:40 -07:00
Jonah Williams 3bc36095da
Revert "[flutter_tools]: reland move engine unpack to dart (#52543)" (#52549)
This reverts commit 3e25e60f57.
2020-03-13 09:50:07 -07:00
gaaclarke f8e9a4fff2
Added option to specify you want the keyboard to be dismissed when you scroll. (#52068) 2020-03-13 09:44:24 -07:00
Jonah Williams 9186dfc34d
[flutter_tools]: reland android device cleanup (#52542) 2020-03-13 09:42:02 -07:00
Jonah Williams 3e25e60f57
[flutter_tools]: reland move engine unpack to dart (#52543)
Reland of #50707
2020-03-13 09:40:55 -07:00
Jonah Williams b3a37d0273
[flutter_tools] support toggling CanvasKit rendering on with 'k' (#52511) 2020-03-13 07:02:34 -07:00
Tong Mu c82c399eb7
[DataTable] Hide arrow padding when not sorting (#51667)
* Change onSort and add tests

* Add doc

* Regression test

* Remove if (true)

* Make test clearer

* Clearer comment
2020-03-12 18:20:15 -07:00
Tong Mu b2d53f60e7
Tap gesture no longer add pointer after resetting (#52450)
* TapGestureRecognizer no longer adds the pointer after it resets.

* Adds an assertion to make sure TapGestureRecognizer.startTrackingPointer is never called when _down is null
2020-03-12 18:19:19 -07:00
Jonah Williams 1e8c4572ec
Revert "[flutter_tools] remove globals in AndroidDevices (#52505)" (#52515)
This reverts commit 1bf9d6f4f7.
2020-03-12 18:14:32 -07:00
Christopher Fujino 14d8534c3e
add usbmuxd (#52500) 2020-03-12 17:36:01 -07:00
Dan Field 73b2895ff1
Add errorBuilder to Image widget (#52481) 2020-03-12 16:21:01 -07:00
Jonah Williams 1bf9d6f4f7
[flutter_tools] remove globals in AndroidDevices (#52505) 2020-03-12 15:51:26 -07:00
Zachary Anderson 0cd2ece539
[flutter_tools] Hanlde OSError in places where we've seen it thrown (#52491) 2020-03-12 14:01:01 -07:00
Shi-Hao Hong 183da8f837
[gen_l10n] Fix suppportedLocales list (#52448)
* Fix suppportedLocales list

* Refactor integration tests for gen_l10n tool to catch exceptions
2020-03-12 12:58:13 -07:00
Jonah Williams d98213c46f
[flutter_tools] reland: Update background isolates when performing hot reload/restart (#52479)
Reland of #52149
2020-03-12 12:48:05 -07:00
Dan Field 02769001d3
Android SDK test fixes (#52144) 2020-03-12 10:53:23 -07:00
Finn 9e848f3c78
Add ignore public member api docs in template (#52422) 2020-03-12 10:36:02 -07:00
Christopher Fujino 38a8845481
move iosworkflow to globals (#52444) 2020-03-12 10:16:28 -07:00
Wu Zhong db6e2061aa
Fixes typo in comments (#52408) 2020-03-12 09:31:01 -07:00
Dmitry Ratushnyy 1b0fd265bd
[ISSUE-30478] Release cache dir lock acquired by a command on sigint or sigterm (#52194) 2020-03-12 09:11:01 -07:00
Zachary Anderson 04a1b78b75
Revert "[flutter_tools] Update background isolates when performing hot reload/restart (#52149)" (#52476)
This reverts commit edd03a1af8.
2020-03-12 09:02:31 -07:00
Greg Spencer 7c9f95ac0a
Minor doc changes (#52433)
Just some very minor doc changes: an adjustment of my comments in #51495, and a typo fix.
2020-03-11 16:57:06 -07:00
Gary Qian fed6ce17f8
Directionality formatter to move whitespace bidi handling into framework (#51964) 2020-03-11 16:25:12 -07:00
Jonah Williams edd03a1af8
[flutter_tools] Update background isolates when performing hot reload/restart (#52149)
When performing a hot restart, collect isolates without an attached flutter view and send a kill signal. These must have been spawned by running main, so restarting without removing them leads to isolate duplication.

When performing a hot reload, ensure that we send a reloadSources command to every isolate and not just uiIsolates.
2020-03-11 15:52:04 -07:00
Gary Qian d56266375b
Reland "Improve text formatter repeat filter logic (#52055)" (#52366) 2020-03-11 13:36:43 -07:00
Justin McCandless 4841a7ed6f
Text Selection Overflow (Android) (#49391)
Adds an overflow menu to the text selection menu on Android when the items overflow.
2020-03-11 13:36:10 -07:00
Greg Spencer 210f4d8313
Convert Diagnosticable to a mixin (#51495)
This converts Diagnosticable to be a mixin instead of an abstract class, so that it can be used to add diagnostics to classes which already have a base class.

It leaves in place the DiagnosticableMixin mixin, since there are some plugins that are still using it, and removing it would mean that those plugins wouldn't work with master branch Flutter anymore. DiagnosticableMixin will be removed once this mixin version of Diagnosticable makes its way to the stable branch.
2020-03-11 10:03:05 -07:00
Jonah Williams 6804cef587
[flutter_tools] throw exception instead of string from startApp (#52365)
When attempting to start an emulator in profile mode, ensure the daemon can exit gracefully
2020-03-11 09:41:52 -07:00
Emmanuel Garcia 4049889d9e
Make --androidx flag a noop in flutter create (#52340) 2020-03-10 20:05:41 -07:00
Jonah Williams ea3563ea4d
[flutter_tools] update visual studio and validator to remove globals, update test cases (#51680)
Updates VisualStudio and VisualStudioValidator to use constructors instead of global injection. Updates VisualStudio test cases to prefer FakeProcessManager
Updates build_windows test to work without injected VisualStudio
2020-03-10 16:49:23 -07:00
Zachary Anderson 53dce17b35
[flutter_tools] Fallback discovery: Don't crash when an Isolate has no root library (#52354) 2020-03-10 15:31:02 -07:00
Greg Spencer d19c44344b
Add sample for InheritedNotifier, convert two others to DartPa… (#52349)
This adds a sample for InheritedNotifier, and converts a couple of other samples to be DartPad samples. I also added a new sample template stateful_widget_material_ticker, which adds a TickerProviderStateMixin to the state object so that animation controllers can be created there easily.
2020-03-10 15:23:45 -07:00
Zachary Anderson 78b45fb1b2
[flutter_tools] Throw a tool exit when samples fetch fails (#52355) 2020-03-10 15:21:02 -07:00
Zachary Anderson 7f564b7436
[flutter_tools] Handle StateError in ProtocolDiscovery.uri (#52337) 2020-03-10 14:26:02 -07:00
Jonah Williams 5d289721fc
[flutter_tools] handle null value from sdk version (#52351)
When the AndroidDevice checks for the current API version, it isn't handling a null response. While we can refuse to run on API levels that are unsupported, we should probably assume that a null response = lowest possible API level and allow these to run.
2020-03-10 14:23:18 -07:00
Zachary Anderson 605debfcff
[flutter_tools] Make AndroidConsole check for next line (#52353) 2020-03-10 14:21:01 -07:00
Gary Qian ac6ea52b37
Revert "Add missing features to DefaultTextStyleTransition and AnimatedDefaultTextStyle (#51517)" (#52352) 2020-03-10 14:11:03 -07:00
Ben Konyi 66b978a197
Update pub dependencies to roll forward package:test (#52273) 2020-03-10 13:26:02 -07:00
Michael Goderbauer ade6a1b3c5
Fix a11y scrolling for reversed lists (#52332) 2020-03-10 13:04:22 -07:00
Zachary Anderson 733fc20073
[flutter_tool] Use unzip -t instead of zip -T to verify zip files (#52331) 2020-03-10 12:22:53 -07:00
Jonah Williams fdb7bd3c0f
[flutter_tools] attempt to fix .first crasher in web loading (#52301) 2020-03-10 12:09:37 -07:00
Jonah Williams 2133343a29
[flutter_tools] cache result of BotDetector in persistent tool state (#52325)
The Azure bot detection can take up to a second to determine if a client is/isn't a bot. To prevent this from slowing down all flutter commands, we can cache the results in the persistent tool state - since we don't expect the same client id to ever become a bot or stop being a bot
2020-03-10 11:35:52 -07:00
Jonah Williams 377879825e
[flutter_tools] prevent StateError when log reader is disposed (#52173)
Previously the AdbLogReader did async setup in the StreamController.onListen callback, specifically it would query the api version and start the adb process. If the log subscription was cancelled before this setup completed, then the log output could (haven't confirmed) get added to a closed controller, causing the above state error.
2020-03-10 11:34:40 -07:00
Jenn Magder fdd023fa59
Migrate older Xcode projects off the legacy build system (#52288) 2020-03-10 10:11:16 -07:00
Jonah Williams 60d0fef17a
[flutter_tools] move stack_trace_mapper and require.js into memory file system (#52276) 2020-03-09 22:07:34 -07:00
Jonah Williams 3191af1332
[flutter_tools] add more information to obfuscate option documentation (#52282) 2020-03-09 20:09:47 -07:00
Jonah Williams 88b39402ac
[flutter_tools] configure dwds to not serve devtools (#52284) 2020-03-09 19:20:11 -07:00
Francisco Magdaleno e9905b6ad8
[Keyboard] Collects windows key data (#52265) 2020-03-09 17:21:02 -07:00
Jonah Williams bc43b41d99
[flutter_tools] ensure --track-widget-creation is not enabled for build aot (#52261)
This option was defaulting to on, which was tickling some benchmarks
2020-03-09 17:19:14 -07:00
George Wright 084a7077ce
Revert "Put fuchsia tools into their own directory, and set source_dir to point at them. (#52266)" (#52277)
This reverts commit ffcc776513.
2020-03-09 16:55:58 -07:00