Commit graph

17612 commits

Author SHA1 Message Date
Christopher Fujino b2b97c2a7e
Revert "catch release builds pre-submit (#50515)" (#50683) 2020-02-12 17:18:09 -08:00
Christopher Fujino 7b7bd11d11
catch release builds pre-submit (#50515) 2020-02-12 16:29:56 -08:00
stuartmorgan 7bdd4757ec
Create plugin symlinks for Windows and Linux (#50599)
This makes ephemeral symlinks to each plugin, for use by build systems.
This is similar to the logic implemented in the Podfile on iOS and
macOS, but managed internally to the Flutter tool.

Exploration for addressing #32719 and #32720
Related to #41146
2020-02-12 16:23:27 -08:00
gaaclarke d3c318ed49
Made xcode_backend stop on error. (#50664) 2020-02-12 16:23:01 -08:00
Greg Spencer d57d493507
Reland: Add OrderedFocusTraversalPolicy and FocusTraversalGrou… (#50672)
This re-lands #49235 with the addition of includeSemantics flag on the Focus widget so that the FocusTraversalGroup can create a Focus widget without affecting the semantics tree.

The FocusTraversalGroup uses the Focus widget to create a grouping of descendants for traversal, but doesn't actually participate in focus (canRequestFocus is always false), so we don't want it to add a Semantics widget in that case, since that can cause semantics changes. The canRequestFocus attribute can also be used when a widget is disabled, so we do sometimes want to include Semantics even if that is false, but not in the case where it is always false, as for FocusTraversalGroup.

- Added a test to make sure that FocusTraversalGroup doesn't add any semantics information.
2020-02-12 16:22:01 -08:00
Greg Spencer b2a7ff36a9
Fix lack of ancestor notification when a focus node is unfocus… (#50319)
This fixes a problem when unfocusing focus nodes where the ancestor focus nodes and scopes don't receive notification that a child was unfocused.

Fixes #43497
2020-02-12 16:20:08 -08:00
linxuebin 96e42de1c8
Added error message for flutter_gallery transitions_perf test. (#47776) 2020-02-12 16:13:02 -08:00
engine-flutter-autoroll 8b08120404
Roll engine 0e8ed2715a35..e0ebaea59071 (31 commits) (#50671)
* f49a8b62f Roll src/third_party/skia c03e6982f96f..465864cad5d2 (14 commits) (flutter/engine#16524)

* c477c0644 Enable verbose logging for shell unittests on Fuchsia (flutter/engine#16526)

* a662579f7 Clear frame references at the end of every CanvasKit frame (flutter/engine#16525)

* 3f31ea3d3 Roll src/third_party/skia 465864cad5d2..21f382c19d76 (6 commits) (flutter/engine#16528)

* 38fb6b135 Roll fuchsia/sdk/core/linux-amd64 from 8L7NY... to Bmq1m... (flutter/engine#16529)

* 9c0168a5a Roll fuchsia/sdk/core/mac-amd64 from PMcw3... to 7JkB7... (flutter/engine#16530)

* e8a888dfa Roll src/third_party/skia 21f382c19d76..f83d0346c06a (2 commits) (flutter/engine#16532)

* 1e8b33130 Roll src/third_party/dart 5244d99a5d4e..5fc031ebc1d7 (42 commits) (flutter/engine#16533)

* c4e3ae6ae Roll src/third_party/skia f83d0346c06a..88c3793a4eaa (1 commits) (flutter/engine#16534)

* 6cdb14e17 Roll src/third_party/skia 88c3793a4eaa..abefc9c170c9 (1 commits) (flutter/engine#16535)

* 975acd8ff Roll src/third_party/skia abefc9c170c9..4fe89b4d871d (2 commits) (flutter/engine#16536)

* b7424d0ce Roll src/third_party/dart 5fc031ebc1d7..30151a654151 (2 commits) (flutter/engine#16537)

* 25e812778 Roll src/third_party/skia 4fe89b4d871d..dc2782c380f6 (1 commits) (flutter/engine#16538)

* 74fa10c95 Roll src/third_party/dart 30151a654151..76b18c455e2c (1 commits) (flutter/engine#16539)

* 91b8e406c Roll src/third_party/skia dc2782c380f6..cdf2491afa04 (1 commits) (flutter/engine#16540)

* 5acf9b195 Roll src/third_party/skia cdf2491afa04..50a490a1a4fb (2 commits) (flutter/engine#16541)

* 989777718 Roll src/third_party/skia 50a490a1a4fb..c3b67eb988c8 (4 commits) (flutter/engine#16542)

* 78a890972 Use os_log instead of syslog on Apple platforms (flutter/engine#13487)

* ea56ad22d libtxt: use a fixture in the benchmarks (flutter/engine#16531)

* a61dbf2f6 Revert "Use os_log instead of syslog on Apple platforms (#13487)" (flutter/engine#16546)

* 539f64f56 [fuchsia] Disable retained layers (flutter/engine#16548)

* c3b507248 Expose DPI helper functions for Runner apps to use (flutter/engine#16313)

* 5041ff1b1 support endless trace buffer (flutter/engine#16520)

* 6aacf5e76 Re-land: Use os_log instead of syslog on Apple platforms (flutter/engine#16549)

* a5736b85d Roll src/third_party/skia c3b67eb988c8..b1525c721ea6 (4 commits) (flutter/engine#16543)

* 49a370f8e Roll src/third_party/dart 76b18c455e2c..e4c39721c473 (6 commits) (flutter/engine#16544)

* 270421c10 Fix ensureInitializationCompleteAsync callback when already initialized. (#39675) (flutter/engine#16503)

* ca02b9197 Prevent long flash when switching to Flutter app. (#47903) (flutter/engine#16527)

* 44e80fd61 skiping tests in Safari. LUCI recipe for Mac is ready. this is the only step left for stopping us running unit tests in Safari (flutter/engine#16550)

* 5fb0116d6 iOS platform view gesture blocking policy. (flutter/engine#15940)

* e0ebaea59 Revert "Re-land: Use os_log instead of syslog on Apple platforms (#16549)" (flutter/engine#16558)
2020-02-12 16:11:39 -08:00
Jenn Magder e5de31d589
Use forward slashes on Windows for git exclude (#50662) 2020-02-12 16:10:00 -08:00
Jenn Magder 24017e761e
Revert "AlertDialog.actionsOverflowButtonSpacing and ButtonBar.overflowButtonSpacing (#50609)" (#50674) 2020-02-12 15:20:13 -08:00
Michel Feinstein 508c35940b
Added linking to viewInsets and viewPadding in MediaQuery padding docs (#50659) 2020-02-12 14:58:05 -08:00
Shi-Hao Hong 23d61a81dc
AlertDialog.actionsOverflowButtonSpacing and ButtonBar.overflowButtonSpacing (#50609)
* Add ButtonBar.overflowButtonSpacing

* Add AlertDialog overflow button spacing functionality
2020-02-12 14:53:59 -08:00
chunhtai 7168421e9f
fixes route name annoucement in navigator (#50495) 2020-02-12 14:53:05 -08:00
Jacob Richman 7820641a05
Fix Diagnostics subclasses that had the wrong default value for the named parameter. (#50645) 2020-02-12 14:52:50 -08:00
Dan Field 24f8f799da
add an --enable-vmservice flag (#50663) 2020-02-12 14:52:09 -08:00
Dan Field 58a4122b97
update packages (#50666) 2020-02-12 14:51:38 -08:00
Greg Spencer c132c0faa9
Revert "Add OrderedFocusTraversalPolicy and FocusTraversalGrou… (#50660)
This reverts commit 8ef5e2f046 because it breaks some semantics tests.
2020-02-12 13:37:36 -08:00
sanni prasad 7f819c935b
Update cupertino_icons dependency version in pubspec.yaml template (#50479) 2020-02-12 13:28:03 -08:00
engine-flutter-autoroll 57b93c790f
Roll engine e4f46f32f1fd..0e8ed2715a35 (21 commits) (#50535)
* a195a92cc [SkParagraph] Text layout benchmarks using SkParagraph (flutter/engine#16373)

* 0340d457a Roll fuchsia/sdk/core/mac-amd64 from fvWgE... to FLFOw... (flutter/engine#16498)

* 9443518f6 Fix safe area reporting with transparent FlutterActivitys. (#46060) (flutter/engine#16208)

* 0980b2ad5 Roll src/third_party/skia 9f3eef796f63..b2031d4255e2 (12 commits) (flutter/engine#16499)

* 8f03a563d Check Java formatting in format.sh (flutter/engine#16500)

* 077918dcf Apply Google Java format (flutter/engine#16501)

* ec1b2e39f Roll src/third_party/skia b2031d4255e2..a9405c2a2967 (5 commits) (flutter/engine#16502)

* 82d193241 Roll src/third_party/skia a9405c2a2967..8dad1ffd81f8 (1 commits) (flutter/engine#16505)

* a302bfd06 Roll src/third_party/dart fd992e423ef6..4310f50edc95 (17 commits) (flutter/engine#16506)

* a86f4cba3 Roll fuchsia/sdk/core/linux-amd64 from LvSlH... to 8L7NY... (flutter/engine#16508)

* 6c04a6960 Roll src/third_party/skia 8dad1ffd81f8..c03e6982f96f (2 commits) (flutter/engine#16510)

* b1aaec3c4 Roll src/third_party/dart 4310f50edc95..9464eb51f539 (2 commits) (flutter/engine#16511)

* cab49e420 Roll fuchsia/sdk/core/mac-amd64 from FLFOw... to PMcw3... (flutter/engine#16512)

* 695a2768e Roll src/third_party/dart 9464eb51f539..f120417ddbfc (1 commits) (flutter/engine#16513)

* 6d3e2606e Roll src/third_party/dart f120417ddbfc..b158bf7bd537 (2 commits) (flutter/engine#16514)

* acc26a2f1 Use Skia to determine "actual" font name in CanvasKit backend (flutter/engine#16504)

* 1daba5318 Partially fix canvas vs text paint order when running on Blink/Webkit browsers (flutter/engine#16483)

* 826b2d46e Apply lints from internal roll (flutter/engine#16509)

* d107eaaa0 Remove mirrors on the web (flutter/engine#16516)

* 7e869faf5 Adds new route annoucement method. (flutter/engine#16523)

* 0e8ed2715 Roll src/third_party/dart b158bf7bd537..5244d99a5d4e (1 commits) (flutter/engine#16517)
2020-02-12 13:26:17 -08:00
Josh Burton 2b16202ea2
Adds shadowColor property to the Card widget (#47273) 2020-02-12 13:23:02 -08:00
Jenn Magder c03fbada1b
Revert "Turn back on macOS shard Cirrus caching" (#50661) 2020-02-12 13:10:36 -08:00
Zachary Anderson b9ecebf101
Reland: [flutter_tools] Disable analytics for more bots (#50641) 2020-02-12 10:58:02 -08:00
sjindel-google 3aa72cc2f2
Use ELF for AOT snapshots on Fuchsia. (#50468) 2020-02-12 10:53:04 -08:00
Arthur Denner d3e1e29375
SimpleDialogOption: support custom padding (#50035) 2020-02-12 08:58:03 -08:00
Anthony Mansour 4c1045c0f8
Fixed preferredSize getter in TabBar (#41299) 2020-02-12 08:53:02 -08:00
Zachary Anderson 1903ce012e
Revert "[flutter_tools] Disable analytics for more bots (#50579)" (#50622)
This reverts commit 0a38f29c0d.
2020-02-11 22:47:41 -08:00
Jenn Magder 7c24ebc79b
Map arm64e devices to arm64 devices (#50612) 2020-02-11 19:43:43 -08:00
Casey Hillers 781cd4d87c
Update Devicelab README with new dashboard information (#48908) 2020-02-11 18:25:17 -08:00
Gary Qian cad08149ca
Remove invalid assert for TextHeightBehavior (#50603) 2020-02-11 19:08:05 -05:00
Jonah Williams 953df281ea
Revert "Revert "Reduced code duplication in ink_splash.dart, ink_ripple.dart (#49480)" (#50502)" (#50512)
This reverts commit 9bc0e6a991.
2020-02-11 16:05:53 -08:00
Jonah Williams 5406258fc6
[flutter_tools] fix crash when IsolateRef returns sentinel (#50611) 2020-02-11 16:03:45 -08:00
Jenn Magder bfbb347682
Use BUILD_LIBRARY_FOR_DISTRIBUTION build setting for generating add-to-app frameworks (#50536) 2020-02-11 15:53:02 -08:00
Zachary Anderson 0a38f29c0d
[flutter_tools] Disable analytics for more bots (#50579) 2020-02-11 15:48:02 -08:00
Jonah Williams 18f38cd45b
Switch flutter_tools to use frontend_server for web compilation (#50365) 2020-02-11 15:43:46 -08:00
Jason Simmons 324e20de09
Update TextStyle.hashCode to handle list fields (#50520) 2020-02-11 14:38:03 -08:00
LongCatIsLooong 48d5fcabbd
evict _SliverFractionalPadding cache on constraint change (#50523) 2020-02-11 12:52:53 -08:00
Alexandre Ardhuin f15c887c63
change quote to avoid escapes (#50368) 2020-02-11 20:58:27 +01:00
Lamonte fd1062debd
Exposed optional scrollController property in ReorderableListView (#49148) 2020-02-11 10:58:02 -08:00
Jenn Magder e002698c35
Turn back on macOS shard Cirrus caching (#50496) 2020-02-11 10:37:53 -08:00
Jonah Williams fa44a1cf37
[flutter_tools] fix path escaping on in depfile generation (#50538) 2020-02-11 09:31:58 -08:00
Greg Spencer c6e45ffa30
Updating snippets documentation README.md (#50483)
Updates the README file for snippets.
2020-02-11 09:19:23 -08:00
Greg Spencer 8ef5e2f046
Add OrderedFocusTraversalPolicy and FocusTraversalGroup to all… (#49235)
This change adds a way to provide explicit focus order for a part of the widget tree.

It adds FocusTraversalPolicyGroup, which in many ways is similar to DefaultFocusTraversal, except that it groups a widget subtree together so that those nodes are traversed as a group. DefaultFocusTraversal doesn't work as one would expect: If there is more than one DefaultFocusTraversal inside of a focus scope, the policy can change depending on which node was asked to move "next", which can cause unexpected behavior. The new grouping mechanism doesn't have that problem. I deprecate DefaultFocusTraversal in this PR.

It also adds OrderedFocusTraversalPolicy, which is a policy that can be supplied to FocusTraversalPolicyGroup to set the policy for a sub-tree. It looks for FocusTraversalOrder inherited widgets, which use a FocusOrder to do the sorting. FocusOrder has two subclasses: NumericalFocusOrder (which sorts based on a double), and LexicalFocusOrder, which sorts based on a String.

As part of doing this, I refactored the way FocusTraversalPolicy is implemented so that it has more default implementation methods, and exposes a new protected member: sortDescendants, which makes it easier for developers to make their own policy subclasses: they only need to implement sortDescendants to get a new ordering behavior, but can also still override any of the default implementation behaviors if they need different behavior.

I was able to do this without breaking the API (AFAICT).
2020-02-11 09:18:39 -08:00
Gary Qian f769bcc5c4
Reland "Track lastKnownRemoteTextEditingValue separately from received data" (#50307) 2020-02-10 20:55:48 -05:00
Christopher Fujino 1f498e2471
Set bundle config rather than deprecated --system flag (#50497) 2020-02-10 17:41:37 -08:00
Amir Hardon bcef4edfc8
Make the template plugin example depend on the plugin as a real dependency (#50485) 2020-02-10 16:03:02 -08:00
Mouad Debbar bf551a31fe
EditableText's autofocus:true should not crash (#50372) 2020-02-10 15:58:02 -08:00
engine-flutter-autoroll c388a26131
Roll engine 6158f03ef5fa..e4f46f32f1fd (3 commits) (#50399) 2020-02-10 15:54:03 -08:00
Shi-Hao Hong 67826bdce5
Revert "Fix SnackBar clipping when it is floating due to FloatingActionButton positioning (#47616)" (#50516)
This reverts commit 801a6a7e5e.
2020-02-10 14:59:32 -08:00
Greg Spencer 18f8002ec8
Make FocusManager a ChangeNotifier that notifies when the prim… (#50392)
This makes FocusManager a ChangeNotifier that notifies when the primaryFocus changes so that an app can track the current focus.

Fixes #50501
2020-02-10 14:33:31 -08:00
Dan Field 9cb2953e10
Fix image tests that make faulty assumptions about lifecycle of image provider (#50297) 2020-02-10 14:23:01 -08:00