macOS was sharing the iOS font theme, but the names of the underlying
fonts differ between the two platforms, so this was actually using the
fallback font from the engine. Instead of using the underlying font
names on macOS, which is no longer allowed by CoreText, use the
meta-font returned by systemFontOfSize:
This has been verified on 10.15; older versions of macOS may need
different font names as the handling of these fonts have changed over
time. Fixing older versions as necessary will be handled in a follow-up.
See https://github.com/flutter/flutter/issues/57805
* d4a735835 Roll Dart SDK from c4214e6daaac to 4a6764bf28c2 (4 revisions) (flutter/engine#23770)
* 9bc776a84 [web] Add --watch flag to 'felt test' (flutter/engine#23727)
* 247ebc2dc Roll Skia from bde06cc511d2 to f3087d8297fe (7 revisions) (flutter/engine#23772)
* 8b27e6fb4 skip flaky test (flutter/engine#23775)
* 2927e9fb4 block thread merging with shared engines (flutter/engine#23733)
* df5f3b086 Implement handling of framework-handled key events (flutter/engine#23655)
* f205ceda2 Roll Skia from f3087d8297fe to e0fe62adaa3e (9 revisions) (flutter/engine#23781)
* fa7aebf1e Roll Skia from e0fe62adaa3e to 18aeb5731b51 (1 revision) (flutter/engine#23784)
* 9acfb7d59 Fix JNI void vs object method call (flutter/engine#23785)
* df13ccf44 Roll Skia from 18aeb5731b51 to 7aa7f039b9ee (1 revision) (flutter/engine#23786)
* e3e3b2b6e Roll Fuchsia Mac SDK from pc_veLlry... to xYraItnQp... (flutter/engine#23787)
* 8a096d641 ci: Print output in case of compile error (flutter/engine#23522)
* f1c3ced54 Roll Fuchsia Linux SDK from fByXAJ76e... to vs54lOVoj... (flutter/engine#23788)
* 0c79393dd Revert "Roll Dart SDK from c4214e6daaac to 4a6764bf28c2 (4 revisions) (#23770)" (flutter/engine#23791)
Instead of using package:package_config to write the .dart_tool/package_config the original json is modified and rewritten.
The .dart_tool/package_config.json file is read twice to simplify control flow.
This also avoids the issue of package:package_config writing directly to local filesystem.
This PR replaces the ColoredBox that ListTile uses with an Ink widget. That Ink widget is given a ShapeDecoration with the ListTile's color and shape. This fixes issues where the ListTile color would obscure material ripple effects, and cause the specified shape to not be respected.
List which issues are fixed by this PR. You must list at least one issue.
Fixes#73616Fixes#63877Fixes#67117
If you had to change anything in the flutter/tests repo, include a link to the migration guide as per the breaking change policy.
I modified a handful of tests related to ListTiles. The tests I changed had implementation-specific ways of checking the ListTile color. I have rewritten those so that instead of checking for a ColoredBox with a specific color, they check that a path is painted with the correct color.
I added the following tests to list_tile_test.dart:
"ListTile shows Material ripple effects on top of tileColor" (Regression test for #73616)
"ListTile shape is painted correctly" (Regression test for #63877)
I added the following test to sliver_prototype_item_extent_test.dart:
"SliverPrototypeExtentList prototypeItem paint transform is zero" (Regression test for #67117)
Make RenderCustomPaint consult its preferred size for intrinsics when it has no child. Currently, it returns 0 for its intrinsics, even if it has a non-zero preferred size.
