Ian Hickson
abebd340d7
Style correctness improvements for toStrings and related fixes ( #142485 )
...
Children should be omitted from debugFillProperties (if they really need to be included they should be in debugDescribeChildren, but in general for widgets we don't bother including them since they are eventually included anyway).
toStrings should not contain newlines (or, ideally, should use Diagnosticable).
Also some minor tweaks to match grammar and style guide conventions.
2024-01-30 22:41:15 +00:00
engine-flutter-autoroll
176b439d67
Roll Flutter Engine from 500ae6c4d947 to d20ed240ace9 (1 revision) ( #142554 )
...
500ae6c4d9...d20ed240acskia-flutter-autoroll@skia.org Roll Skia from 739b66191c66 to 62cab132c9ad (2 revisions) (flutter/engine#50181 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC matanl@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-01-30 22:33:22 +00:00
dependabot[bot]
c40acdad15
Bump codecov/codecov-action from 3.1.5 to 3.1.6 ( #142553 )
...
Bumps [codecov/codecov-action](https://github.com/codecov/codecov-action ) from 3.1.5 to 3.1.6.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/codecov/codecov-action/releases ">codecov/codecov-action's releases</a>.</em></p>
<blockquote>
<h2>v3.1.6</h2>
<p><strong>Full Changelog</strong>: <a href="https://github.com/codecov/codecov-action/compare/v3.1.5...v3.1.6 ">https://github.com/codecov/codecov-action/compare/v3.1.5...v3.1.6 </a></p>
</blockquote>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="ab904c41d6a8c374ae46https://redirect.github.com/codecov/codecov-action/issues/1228 ">#1228</a>)"</li>
<li>See full diff in <a href="4fe8c5f003...ab904c41d6https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=codecov/codecov-action&package-manager=github_actions&previous-version=3.1.5&new-version=3.1.6 )](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores )
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.
---
<details>
<summary>Dependabot commands and options</summary>
<br />
You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency
- `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
</details>
2024-01-30 22:03:07 +00:00
engine-flutter-autoroll
d35c08e9cf
Roll Flutter Engine from cd12316a0883 to 500ae6c4d947 (1 revision) ( #142551 )
...
cd12316a08...500ae6c4d935989475+MeandNi@users.noreply.github.com Revert "Close connection on keyboard close (#41500 )" (flutter/engine#49366 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC matanl@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-01-30 21:47:25 +00:00
engine-flutter-autoroll
b23b3da935
Roll Flutter Engine from 0e4342c5a1f2 to cd12316a0883 (6 revisions) ( #142548 )
...
0e4342c5a1...cd12316a08skia-flutter-autoroll@skia.org Roll Dart SDK from 10bbb376de7e to 734aae9604e8 (1 revision) (flutter/engine#50179 )
2024-01-30 30870216+gaaclarke@users.noreply.github.com [Impeller] added mipmaps to subpasses directly on a draw call (flutter/engine#50157 )
2024-01-30 skia-flutter-autoroll@skia.org Manual roll Dart SDK from d0b48a008559 to 10bbb376de7e (8 revisions) (flutter/engine#50172 )
2024-01-30 skia-flutter-autoroll@skia.org Roll Skia from 7df4d35e11cf to 739b66191c66 (1 revision) (flutter/engine#50175 )
2024-01-30 jonahwilliams@google.com [Android] Reland: recycle hardware buffer textures. (flutter/engine#50122 )
2024-01-30 mk12360@gmail.com Roll buildroot to 52689fe8955a9a4916a38f0b8ae5ea3e217037f4 (flutter/engine#50160 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC matanl@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-01-30 20:55:07 +00:00
engine-flutter-autoroll
4b110de996
Roll Flutter Engine from 438e9b4d7d4e to 0e4342c5a1f2 (11 revisions) ( #142543 )
...
438e9b4d7d...0e4342c5a1flutter/engine#50174 )
2024-01-30 skia-flutter-autoroll@skia.org Roll Skia from a3d46fac53be to 7df4d35e11cf (3 revisions) (flutter/engine#50173 )
2024-01-30 skia-flutter-autoroll@skia.org Roll Skia from c2fada52fdc4 to a3d46fac53be (2 revisions) (flutter/engine#50171 )
2024-01-30 skia-flutter-autoroll@skia.org Roll Skia from 7dc9ba2e8c90 to c2fada52fdc4 (1 revision) (flutter/engine#50170 )
2024-01-30 skia-flutter-autoroll@skia.org Roll Skia from 1c0eae94fc09 to 7dc9ba2e8c90 (1 revision) (flutter/engine#50169 )
2024-01-30 skia-flutter-autoroll@skia.org Roll Skia from 4e992fb3a9db to 1c0eae94fc09 (3 revisions) (flutter/engine#50167 )
2024-01-30 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from Hqi_x_A9lYsY58VSn... to Z-xFM2ILZJw22eU8q... (flutter/engine#50166 )
2024-01-30 jonahwilliams@google.com [Impeller] Add interface for submitting multiple command buffers at once. (flutter/engine#50139 )
2024-01-30 49699333+dependabot[bot]@users.noreply.github.com Bump actions/upload-artifact from 4.1.0 to 4.3.0 (flutter/engine#50165 )
2024-01-30 skia-flutter-autoroll@skia.org Roll Skia from 083c1a4d9767 to 4e992fb3a9db (1 revision) (flutter/engine#50164 )
2024-01-30 mbrase@google.com Use structured logging on Fuchsia (flutter/engine#49918 )
Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from Hqi_x_A9lYsY to Z-xFM2ILZJw2
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC matanl@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-01-30 19:57:25 +00:00
Renzo Olivares
1daac1b875
Fix: selection handles do not inherit color from local Theme widget ( #142476 )
...
This change uses `CapturedTheme`s to capture the themes from the context the selection handles were built in and wraps the handles with them so they can correctly inherit `Theme`s from local `Theme` widgets.
`CapturedTheme`s only captures `InheritedTheme`s, so this change also makes `_InheritedCupertinoTheme` an `InheritedTheme`. This is so we can capture themes declared under a `CupertinoTheme`, for example `primaryColor` is used as the selection handle color.
Fixes #74890
2024-01-30 18:12:18 +00:00
Flutter GitHub Bot
bd715036b5
Marks Windows_arm64 plugin_test_windows to be unflaky ( #137675 )
...
<!-- meta-tags: To be used by the automation script only, DO NOT MODIFY.
{
"name": "Windows_arm64 plugin_test_windows"
}
-->
The issue https://github.com/flutter/flutter/issues/134083 has been closed, and the test has been passing for [50 consecutive runs](https://data.corp.google.com/sites/flutter_infra_metrics_datasite/flutter_check_test_flakiness_status_dashboard/?p=BUILDER_NAME:%22Windows_arm64%20plugin_test_windows%22 ).
This test can be marked as unflaky.
2024-01-30 18:02:52 +00:00
Jonah Williams
75b3c8ec9a
Revert "Roll Flutter Engine from 0e586d1c28c8 to f02a4a80a77e (3 revisions)" ( #142533 )
...
Reverts flutter/flutter#142528
2024-01-30 09:33:52 -08:00
Aizat Azhar
75a2e5b493
Reset framesEnabled to default value at the end of each test ( #141844 )
...
Reset `framesEnabled` to `true` at the end of each test as otherwise subsequent tests may fail when pumping a widget
Fixes #141835
2024-01-30 16:04:15 +00:00
Kate Lovett
e8cb029583
Fix SliverMainAxisGroup geometry cacheExtent ( #142482 )
...
Fixes https://github.com/flutter/flutter/issues/142183
This fixes a bug in the SliverGeometry of SliverMainAxisGroup. The cacheExtent represents how many pixels the sliver has consumed in the SliverConstraints.remainingCacheExtent. Since it was not set, slivers that came after a SliverMainAxisGroup that filled the whole screen did not properly lay out their own children, in some cases making lazy sliver more eager than they should be.
2024-01-30 16:04:13 +00:00
engine-flutter-autoroll
5bb4fa35f3
Roll Flutter Engine from 0e586d1c28c8 to f02a4a80a77e (3 revisions) ( #142528 )
...
0e586d1c28...f02a4a80a7skia-flutter-autoroll@skia.org Roll Skia from 1c0eae94fc09 to 7dc9ba2e8c90 (1 revision) (flutter/engine#50169 )
2024-01-30 skia-flutter-autoroll@skia.org Roll Skia from 4e992fb3a9db to 1c0eae94fc09 (3 revisions) (flutter/engine#50167 )
2024-01-30 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from Hqi_x_A9lYsY58VSn... to Z-xFM2ILZJw22eU8q... (flutter/engine#50166 )
Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from Hqi_x_A9lYsY to Z-xFM2ILZJw2
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC matanl@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-01-30 15:57:08 +00:00
engine-flutter-autoroll
461f0bfb4b
Roll Packages from 516648afb6be to 25abb5d1e0de (6 revisions) ( #142527 )
...
516648afb6...25abb5d1e0tessertaha@gmail.com [rfw] Add `OverflowBar` widget and Update `ButtonBar` widget implementation (flutter/packages#5807 )
2024-01-30 stuartmorgan@google.com [ci] Reduce tasks slightly (flutter/packages#6011 )
2024-01-29 stuartmorgan@google.com Clarify issue requirement (flutter/packages#6010 )
2024-01-29 stuartmorgan@google.com [various] Disambiguate TestDefaultBinaryMessengerBinding (flutter/packages#6009 )
2024-01-29 engine-flutter-autoroll@skia.org Manual roll Flutter from a8efa771d62f6fdf2650flutter/packages#6008 )
2024-01-29 49699333+dependabot[bot]@users.noreply.github.com Bump github/codeql-action from 3.23.1 to 3.23.2 (flutter/packages#5987 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com ,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-01-30 15:38:31 +00:00
engine-flutter-autoroll
72dc162ff0
Roll Flutter Engine from 438e9b4d7d4e to 0e586d1c28c8 (4 revisions) ( #142515 )
...
438e9b4d7d...0e586d1c28jonahwilliams@google.com [Impeller] Add interface for submitting multiple command buffers at once. (flutter/engine#50139 )
2024-01-30 49699333+dependabot[bot]@users.noreply.github.com Bump actions/upload-artifact from 4.1.0 to 4.3.0 (flutter/engine#50165 )
2024-01-30 skia-flutter-autoroll@skia.org Roll Skia from 083c1a4d9767 to 4e992fb3a9db (1 revision) (flutter/engine#50164 )
2024-01-30 mbrase@google.com Use structured logging on Fuchsia (flutter/engine#49918 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC matanl@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-01-30 15:13:06 +00:00
Rulong Chen（陈汝龙）
ccb2b4439a
Using initExpensiveAndroidView for Android Hybrid Composition Mode ( #142399 )
...
After https://github.com/flutter/flutter/pull/100990 , we should use `initExpensiveAndroidView` for Android Hybrid Composition mode instead of `initSurfaceAndroidView`.
`initSurfaceAndroidView` attempts to use `TLHC` when possible. In cases where that is not supported, it falls back to using Hybrid Composition.
https://github.com/flutter/engine/pull/49414
2024-01-30 06:59:24 +00:00
engine-flutter-autoroll
40ecbc81b9
Roll Flutter Engine from ed73d40a8c93 to 438e9b4d7d4e (1 revision) ( #142508 )
...
ed73d40a8c...438e9b4d7dmbrase@google.com Fix incorrect FML_VLOG() severity usage (flutter/engine#50118 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jacksongardner@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-01-30 05:33:32 +00:00
Polina Cherkasova
6dff3da31c
Organize leak tracking TODOs. ( #142460 )
2024-01-29 21:21:34 -08:00
engine-flutter-autoroll
5c64d0370b
Roll Flutter Engine from 5584a78a439b to ed73d40a8c93 (1 revision) ( #142504 )
...
5584a78a43...ed73d40a8cskia-flutter-autoroll@skia.org Roll Skia from 09379d00b455 to 083c1a4d9767 (1 revision) (flutter/engine#50162 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jacksongardner@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-01-30 03:21:25 +00:00
engine-flutter-autoroll
bce0a84bff
Roll Flutter Engine from df5f1afd4991 to 5584a78a439b (2 revisions) ( #142503 )
...
df5f1afd49...5584a78a43matanlurey@users.noreply.github.com Revert: "Change how OpenGL textures are flipped in the Android embedder" (flutter/engine#50158 )
2024-01-30 john@johnmccutchan.com Re-Re-land Manually revert TLHC optimizations (flutter/engine#50155 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jacksongardner@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-01-30 02:17:36 +00:00
engine-flutter-autoroll
4c62abd691
Roll Flutter Engine from 65bf8b1db4d1 to df5f1afd4991 (1 revision) ( #142501 )
...
65bf8b1db4...df5f1afd49johnoneil@users.noreply.github.com Enable `_Float16` "half-float" Functionality Only When Available. (flutter/engine#49851 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jacksongardner@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-01-30 01:38:07 +00:00
engine-flutter-autoroll
d5b189c371
Roll Flutter Engine from c9268c7db03c to 65bf8b1db4d1 (1 revision) ( #142496 )
...
c9268c7db0...65bf8b1db4skia-flutter-autoroll@skia.org Roll Skia from c1899b2586da to 09379d00b455 (3 revisions) (flutter/engine#50156 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jacksongardner@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-01-30 00:53:11 +00:00
engine-flutter-autoroll
9c1665355d
Roll Flutter Engine from e21208583956 to c9268c7db03c (1 revision) ( #142492 )
...
e212085839...c9268c7db0skia-flutter-autoroll@skia.org Roll Skia from 0327d5b319fc to c1899b2586da (3 revisions) (flutter/engine#50152 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jacksongardner@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-01-30 00:06:26 +00:00
engine-flutter-autoroll
8d14d31928
Roll Flutter Engine from bedafa8794b6 to e21208583956 (1 revision) ( #142483 )
...
bedafa8794...e212085839skia-flutter-autoroll@skia.org Roll Skia from 3680286e6bf4 to 0327d5b319fc (1 revision) (flutter/engine#50150 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jacksongardner@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-01-29 23:31:14 +00:00
Camille Simon
995e3fad7c
Revert "Reland: "Fix how Gradle resolves Android plugin" ( #137115 )" ( #142464 )
...
This reverts commit f5ac225c8dhttps://github.com/flutter/flutter/pull/137115 .
This is a continuation of https://github.com/flutter/flutter/pull/142266 that was redone based on feedback to make this easier to revert in the future. The exact steps I took to create this revert:
1. Revert commit noted above
2. Fix merge conflicts, that notably involved reverting some changes in https://github.com/flutter/flutter/pull/140744 ~and https://github.com/flutter/flutter/pull/141417~ (fixed my merge to avoid the second PR from being affected)
3. Delete `packages/flutter_tools/test/integration.shard/android_plugin_skip_unsupported_test.dart` as this was added in the commit noted above
cc @Gustl22 since I couldn't tag as a reviewer
2024-01-29 22:44:24 +00:00
Flutter GitHub Bot
9207b85de8
Marks Mac_pixel_7pro native_assets_android to be unflaky ( #141675 )
...
<!-- meta-tags: To be used by the automation script only, DO NOT MODIFY.
{
"name": "Mac_pixel_7pro native_assets_android"
}
-->
The test has been passing for [50 consecutive runs](https://data.corp.google.com/sites/flutter_infra_metrics_datasite/flutter_check_test_flakiness_status_dashboard/?p=BUILDER_NAME:%22Mac_pixel_7pro%20native_assets_android%22 ).
This test can be marked as unflaky.
2024-01-29 22:16:06 +00:00
engine-flutter-autoroll
ace9181172
Roll Flutter Engine from 9c3ebf67b5da to bedafa8794b6 (4 revisions) ( #142478 )
...
9c3ebf67b5...bedafa8794skia-flutter-autoroll@skia.org Roll Skia from f3b9e80d262a to 3680286e6bf4 (2 revisions) (flutter/engine#50149 )
2024-01-29 jason-simmons@users.noreply.github.com Handle construction/destruction of GObject private data containing C++ objects in Linux embedder tests (flutter/engine#50022 )
2024-01-29 aam@google.com Include dart vm internal sources into flutter distro. (flutter/engine#50116 )
2024-01-29 matanlurey@users.noreply.github.com Manually revert TLHC optimizations, holding on to width/height changes. (flutter/engine#50144 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jacksongardner@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-01-29 22:02:03 +00:00
Justin McCandless
ade8af278f
onNavigationNotification for *App.router ( #142190 )
...
onNavigationNotification was not being passed through when using the router in MaterialApp and CupertinoApp. I believe this was just an oversight on my part when I wrote https://github.com/flutter/flutter/pull/120385 . This PR passes them through.
Fixes https://github.com/flutter/flutter/issues/139903
@maRci0002 Would this totally fix your issue https://github.com/flutter/flutter/issues/139903 ?
2024-01-29 22:00:51 +00:00
Flutter GitHub Bot
1af09dde12
Marks Mac_x64 framework_tests_misc to be unflaky ( #142118 )
...
<!-- meta-tags: To be used by the automation script only, DO NOT MODIFY.
{
"name": "Mac_x64 framework_tests_misc"
}
-->
The test has been passing for [50 consecutive runs](https://data.corp.google.com/sites/flutter_infra_metrics_datasite/flutter_check_test_flakiness_status_dashboard/?p=BUILDER_NAME:%22Mac_x64%20framework_tests_misc%22 ).
This test can be marked as unflaky.
2024-01-29 21:02:25 +00:00
engine-flutter-autoroll
58a9ee5ebc
Roll Flutter Engine from 3e2b8975bd5b to 9c3ebf67b5da (1 revision) ( #142472 )
...
3e2b8975bd...9c3ebf67b5skia-flutter-autoroll@skia.org Roll Skia from 18e440859275 to f3b9e80d262a (1 revision) (flutter/engine#50145 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jacksongardner@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-01-29 20:45:15 +00:00
Bryan Olivares
1d5c2c5118
Feat: TextField can scroll when disabled ( #140922 )
...
This PR is adding a flag parameter to the `TextField` widget. This flag controls whether the TextField ignores pointers. The flag takes priority over other TextField behaviors such as enabled, so it can be useful when trying to have a disabled TextField that can be scrolled (behavior observed using TextArea on the web).
Adding a flag parameter to `TextField` helps with more customization and flexibility to the widget which can improve user experience. I am open to other ideas.
Fixes issue #140147
Before:
https://github.com/flutter/flutter/assets/66151079/293e5b4e-3126-4a00-824d-1530aeaa494b
After:
https://github.com/flutter/flutter/assets/66151079/08c1af09-3bf9-4b49-b684-dda4dd920503
Usage:
```dart
child: TextField(
ignorePointer: false,
enabled: false,
),
```
2024-01-29 20:22:19 +00:00
engine-flutter-autoroll
21ca59e72c
Roll Flutter Engine from 436f91f3b06b to 3e2b8975bd5b (2 revisions) ( #142466 )
...
436f91f3b0...3e2b8975bdskia-flutter-autoroll@skia.org Roll Skia from 675e69e83129 to 18e440859275 (2 revisions) (flutter/engine#50143 )
2024-01-29 skia-flutter-autoroll@skia.org Roll Skia from eaae6d12a547 to 675e69e83129 (1 revision) (flutter/engine#50141 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jacksongardner@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-01-29 19:58:06 +00:00
Flutter GitHub Bot
259c72a82d
Marks Mac_arm64 framework_tests_misc to be unflaky ( #142119 )
...
<!-- meta-tags: To be used by the automation script only, DO NOT MODIFY.
{
"name": "Mac_arm64 framework_tests_misc"
}
-->
The test has been passing for [50 consecutive runs](https://data.corp.google.com/sites/flutter_infra_metrics_datasite/flutter_check_test_flakiness_status_dashboard/?p=BUILDER_NAME:%22Mac_arm64%20framework_tests_misc%22 ).
This test can be marked as unflaky.
2024-01-29 19:53:21 +00:00
Michael Goderbauer
c576f0039d
Fix InputDecorationTheme copyWith fallback for iconColor ( #142462 )
...
Same as https://github.com/flutter/flutter/pull/138914 , but with a test.
2024-01-29 19:15:22 +00:00
Mohammad Bagher Fakouri
fd7f45a8be
Add SingleChildScrollView for NavigationRail ( #137415 )
...
## Description
Add `SingleChildScrollView` to `NavigationRail` for scrolling.
Closes : #89167
2024-01-29 19:11:59 +00:00
Loïc Sharma
f727948f6d
[Windows Arm64] Run plugin test post-submit ( #141987 )
...
The Flutter try pool does not have any Windows Arm64 machines. Thus, any Windows Arm64 pre-submit tests will fail as there's no machines to run them.
This converts the only Windows Arm64 pre-submit test, the plugin test, to run post-submit.
See: https://github.com/flutter/flutter/issues/141986
2024-01-29 19:10:45 +00:00
Andrew Kolos
83bdde2bd3
Catch file system exceptions when trying to parse user-provided asset file paths ( #142214 )
...
Fixes #141211
2024-01-29 18:43:57 +00:00
Nate
38879daef7
Implementing switch expressions in foundation/ and material/ ( #142279 )
...
This PR is the fourth step in the journey to solve issue #136139 and make the entire Flutter repo more readable.
(previous pull requests: #139048 , #139882 , #141591 )
This one is covering files in `packages/flutter/lib/src/foundation/` and `packages/flutter/lib/src/material/`.
The `material/` directory is pretty big though, so for now I just did the files that start with `a`, `b`, and `c`.
2024-01-29 18:14:02 +00:00
engine-flutter-autoroll
5ee1460b8c
Roll Flutter Engine from bff1e46c0d65 to 436f91f3b06b (1 revision) ( #142455 )
...
bff1e46c0d...436f91f3b0skia-flutter-autoroll@skia.org Roll Skia from c699bb0d86fd to eaae6d12a547 (1 revision) (flutter/engine#50140 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jacksongardner@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-01-29 18:07:49 +00:00
Polina Cherkasova
96c322d6ec
Opt out test from leak tracking. ( #142417 )
2024-01-29 09:49:44 -08:00
Zachary Anderson
6a6874ecf9
Update Android minSdkVersion to 21 ( #142267 )
...
This PR increases Android's `minSdkVersion` to 21.
There are two changes in this PR aside from simply increasing the number
from 19 to 21 everywhere.
First, tests using `flutter_gallery` fail without updating the
lockfiles. The changes in the PR are the results of running
`dev/tools/bin/generate_gradle_lockfiles.dart` on that app.
Second, from
[here](https://developer.android.com/build/multidex#mdex-pre-l ):
> if your minSdkVersion is 21 or higher, multidex is enabled by default
and you don't need the multidex library.
As a result, the `multidex` option everywhere is obsolete. This PR
removes all logic and tests related to that option that I could find.
`Google testing` and `customer_tests` pass on this PR, so it seems like
this won't be too breaking if it is at all. If needed I'll give this
some time to bake in the framework before landing the flutter/engine
PRs.
Context: https://github.com/flutter/flutter/issues/138117 ,
https://github.com/flutter/flutter/issues/141277 , b/319373605
2024-01-29 09:49:09 -08:00
engine-flutter-autoroll
bdb71b8f5a
Roll Flutter Engine from 3d87470655b1 to bff1e46c0d65 (1 revision) ( #142446 )
...
3d87470655...bff1e46c0d103135467+sealesj@users.noreply.github.com Remove ockmock GitHub reference (flutter/engine#50086 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jacksongardner@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-01-29 16:50:20 +00:00
engine-flutter-autoroll
88624474a8
Roll Packages from cbe810031b88 to 516648afb6be (3 revisions) ( #142445 )
...
cbe810031b...516648afb619920697+getBoolean@users.noreply.github.com [go_router] Add `topRoute` to `GoRouterState` (flutter/packages#5736 )
2024-01-27 stuartmorgan@google.com Add Kotlin to CONTRIBUTING.md (flutter/packages#5970 )
2024-01-26 engine-flutter-autoroll@skia.org Roll Flutter (stable) from 67457e669f41456452f2flutter/packages#5979 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com ,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-01-29 15:43:14 +00:00
engine-flutter-autoroll
65652d5b18
Roll Flutter Engine from 1405cb7b6e74 to 3d87470655b1 (1 revision) ( #142444 )
...
1405cb7b6e...3d87470655skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from 5aijurFz23iIuRaMQ... to Hqi_x_A9lYsY58VSn... (flutter/engine#50137 )
Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from 5aijurFz23iI to Hqi_x_A9lYsY
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jacksongardner@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-01-29 15:30:22 +00:00
engine-flutter-autoroll
44ce0bf956
Roll Flutter Engine from 3e65f1720a6f to 1405cb7b6e74 (1 revision) ( #142432 )
...
3e65f1720a...1405cb7b6eskia-flutter-autoroll@skia.org Roll Skia from 8c9f983ee600 to c699bb0d86fd (3 revisions) (flutter/engine#50136 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jacksongardner@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-01-29 09:31:07 +00:00
engine-flutter-autoroll
38ac3de48f
Roll Flutter Engine from 210ed1dfb8cf to 3e65f1720a6f (1 revision) ( #142429 )
...
210ed1dfb8...3e65f1720askia-flutter-autoroll@skia.org Roll Skia from a26e0b3ca4df to 8c9f983ee600 (1 revision) (flutter/engine#50134 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jacksongardner@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-01-29 08:06:03 +00:00
engine-flutter-autoroll
7e46394178
Roll Flutter Engine from f15cb86d31c3 to 210ed1dfb8cf (1 revision) ( #142426 )
...
f15cb86d31...210ed1dfb8skia-flutter-autoroll@skia.org Roll Skia from d81204e28dcb to a26e0b3ca4df (1 revision) (flutter/engine#50132 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jacksongardner@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-01-29 06:46:24 +00:00
engine-flutter-autoroll
e743df8b6a
Roll Flutter Engine from f3d48be76630 to f15cb86d31c3 (11 revisions) ( #142425 )
...
f3d48be766...f15cb86d31zanderso@users.noreply.github.com Revert Dart to Version 3.4.0-82.0.dev (flutter/engine#50131 )
2024-01-28 skia-flutter-autoroll@skia.org Roll Dart SDK from 639cf51f4472 to 1d0b890287a4 (1 revision) (flutter/engine#50129 )
2024-01-28 skia-flutter-autoroll@skia.org Roll Skia from 40205cafdb4e to d81204e28dcb (1 revision) (flutter/engine#50127 )
2024-01-28 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from GBTh3gOOgmndwT70X... to 5aijurFz23iIuRaMQ... (flutter/engine#50126 )
2024-01-28 bdero@google.com [Impeller] Fix alpha management issues for advanced blends. (flutter/engine#50070 )
2024-01-28 skia-flutter-autoroll@skia.org Roll Skia from 0c1e352e87aa to 40205cafdb4e (1 revision) (flutter/engine#50124 )
2024-01-27 skia-flutter-autoroll@skia.org Roll Dart SDK from 422d048880a8 to 639cf51f4472 (1 revision) (flutter/engine#50123 )
2024-01-27 737941+loic-sharma@users.noreply.github.com Revert "[Windows] Introduce `egl::Surface` and `egl::WindowSurface`" (flutter/engine#50104 )
2024-01-27 skia-flutter-autoroll@skia.org Roll Dart SDK from d0b48a008559 to 422d048880a8 (1 revision) (flutter/engine#50121 )
2024-01-27 skia-flutter-autoroll@skia.org Roll Skia from b9b80230c87b to 0c1e352e87aa (1 revision) (flutter/engine#50120 )
2024-01-27 skia-flutter-autoroll@skia.org Roll Dart SDK from 141ab6c14cd1 to d0b48a008559 (1 revision) (flutter/engine#50119 )
Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from GBTh3gOOgmnd to 5aijurFz23iI
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jacksongardner@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-01-29 05:11:17 +00:00
engine-flutter-autoroll
efb1346767
Roll Flutter Engine from 95e9a15fd909 to f3d48be76630 (1 revision) ( #142370 )
...
95e9a15fd9...f3d48be766skia-flutter-autoroll@skia.org Manual roll Dart SDK from 7ae508ee09a3 to 141ab6c14cd1 (1 revision) (flutter/engine#50115 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jacksongardner@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-01-27 19:07:24 +00:00
Zachary Anderson
4601341b50
Add no-shuffle to language_version_test.dart ( #142378 )
2024-01-27 10:57:39 -08:00
engine-flutter-autoroll
db828a8351
Roll Flutter Engine from 2687ddb2655c to 95e9a15fd909 (8 revisions) ( #142369 )
...
2687ddb265...95e9a15fd9flar@google.com Cache Impeller paths in the DisplayList to amortize conversion (flutter/engine#50076 )
2024-01-27 98614782+auto-submit[bot]@users.noreply.github.com Reverts "[Android] Cache GPU resources using HardwareBuffer's id as key" (flutter/engine#50114 )
2024-01-27 skia-flutter-autoroll@skia.org Roll Dart SDK from 58665e3dee42 to 7ae508ee09a3 (1 revision) (flutter/engine#50112 )
2024-01-27 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from WHlwlOwznFknNm5IS... to GBTh3gOOgmndwT70X... (flutter/engine#50111 )
2024-01-27 skia-flutter-autoroll@skia.org Roll Skia from 6279c88b9e29 to b9b80230c87b (4 revisions) (flutter/engine#50110 )
2024-01-27 jonahwilliams@google.com [Impeller] add missing barrier to compute tessellator. (flutter/engine#50108 )
2024-01-27 jonahwilliams@google.com [Android] Cache GPU resources using HardwareBuffer's id as key (flutter/engine#50028 )
2024-01-27 54558023+keyonghan@users.noreply.github.com Move Mac builder_cache to prod (flutter/engine#50044 )
Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from WHlwlOwznFkn to GBTh3gOOgmnd
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jacksongardner@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-01-27 06:33:10 +00:00
