development/flutter
development/flutter
1
0
Fork 0
mirror of https://github.com/flutter/flutter synced 2024-10-14 04:02:56 +00:00
Code Issues Packages Projects Releases Wiki Activity
15861 commits 770 branches 974 tags 1.7 GiB
Commit graph

11214 commits

Author SHA1 Message Date
Jonah Williams 925a52fa6b
add host and port to run configuration for web devices (#40191) 2019-09-12 08:58:49 -07:00
Francisco Magdaleno f5733f7a62 Fix crash on vswhere search from flutter doctor (#40263) 
Fixes a crash introduced on #40011 due to an incorrect type in the vswhere search

Fixes #40238
 2019-09-11 21:03:42 -07:00
Jonah Williams 270878fc50
fix copy command and remove resolve sync for macOS assemble (#40294) 2019-09-11 20:29:27 -07:00
Zachary Anderson 73c10e8ced
[flutter_tool] process.dart cleanup (#39899) 2019-09-11 18:20:42 -07:00
Emmanuel Garcia 3712ea63d8
Flip the default for proguard (#40282) 2019-09-11 17:51:51 -07:00
Michael Goderbauer 6dc9bf0a02
Fix curve for popping hero (#39844) 2019-09-11 14:55:59 -07:00
Jonah Williams 6d37867c4a
Place hot reload artifacts in a temp directory (#40171) 2019-09-11 12:57:43 -07:00
Jonah Williams 963c8a8921
Remove io and isolate from libraries for web sdk (#40259) 2019-09-11 12:40:33 -07:00
Jonah Williams 8eee93fa64
Ensure we send hot restart events for flutter web (#40175) 2019-09-11 09:38:42 -07:00
Christopher Fujino c5e2bf5cfe
catch errors during gradle update (#37526) 2019-09-11 09:21:42 -07:00
Zachary Anderson 2c94f2b4d9
[flutter_tool] Kill a timing out process before trying to drain its stdout/err streams (#40159) 2019-09-11 08:30:29 -07:00
stuartmorgan e6ae95c4ce
Add an ephemeral directory to Windows projects (#40194) 
Moves files generated in windows/flutter/ as part of the build to an ephemeral/ subdirectory, matching the approach used on macOS (and in the future, Windows).

Adds that directory to the generated properties file to minimize hard-coding of paths in the project.
 2019-09-11 07:46:57 -07:00
stuartmorgan ef97a69dab
Make Swift plugin template swift-format compliant (#40195) 
swift-format will alphabetize import statements, so Flutter* should be
before Foundation. Also, separating the "Generated file" comment
prevents the formatter from thinking that the comment is associated with
the following import, rather than the file, if it does re-order.
 2019-09-11 07:43:50 -07:00
Jonah Williams 32c946f31b
make sure we launch with dwds (#40210) 2019-09-10 20:49:27 -07:00
LongCatIsLooong da151c95ba
CupertinoAlertDialog dark mode & CupertinoActionSheet fidelity (#40007) 2019-09-10 20:40:06 -07:00
Jonah Williams 609a78fdca
Revert "build bundle with assemble (#37508)" (#40204) 2019-09-10 20:03:52 -07:00
Jonah Williams f614144f0a
Add "web" server device to allow running flutter for web on arbitrary browsers (#39951) 
* add web server device

* remove extra async

* fixes to server device

* testing updates

* fix test cases

* address comments
 2019-09-10 19:29:31 -07:00
Jonah Williams a7aff56741
build bundle with assemble (#37508) 2019-09-10 19:28:38 -07:00
Jonah Williams 8504f3ae13
Update the supported library set for Flutter for web (#39983) 2019-09-10 17:27:30 -07:00
Emmanuel Garcia f098de1fde
Enable Proguard by default on release mode (#39986) 2019-09-10 17:22:55 -07:00
Francisco Magdaleno 362cde43ff
[windows] Searches for pre-release and 'all' Visual Studio installations (#40011) 2019-09-10 17:01:53 -07:00
Jenn Magder 556e3d9e74
Keep Flutter.framework binaries writable so they can be code signed (#40174) 2019-09-10 15:17:56 -07:00
Jenn Magder 12229264e2
Show CocoaPods version in hint text (#40117) 2019-09-10 13:26:32 -07:00
Michael Goderbauer 3f98fb7949
Ensure frame is scheduled when root widget is attached (#40105) 2019-09-10 13:26:09 -07:00
Sam Rawlins 2bc8f999f7 Remove visibleForTesting annotation; this constructor is used outside of testing (#39997) 2019-09-10 13:12:53 -07:00
Greg Spencer a7c06e113b
Fixed passing autofocus to MaterialButton, and when rebuilding Focus widget. (#39903) 
Fixed passing autofocus to MaterialButton, and when rebuilding Focus widget, and added a test for Focus and MaterialButton to test that it works properly.
 2019-09-10 10:29:58 -07:00
Jonah Williams f877c97b3b
Use persisted build information to automatically clean old outputs in assemble (#39654) 2019-09-10 09:57:47 -07:00
Mouad Debbar 03e8100346
Disable the performance overlay for web (#39999) 2019-09-10 08:56:28 -07:00
Peter Lee 423a1914f6 fix typo (#40048) 2019-09-10 08:54:18 -07:00
Andrew Brogdon 691977755c
Adds DartPad option to the DartDoc snippet generator. (#39924) 2019-09-10 08:36:14 -07:00
Jonah Williams 79ec38f7f3
ensure we use pub from flutter sdk (#40131) 2019-09-10 07:41:59 -07:00
Shi-Hao Hong 2449928d7c
Add null check to _IndicatorPainter._tabOffsetsEqual() to prevent crash (#40009) 
* Add tabOffsetEqual null check with TODO
 2019-09-09 21:12:27 -07:00
Sarbagya Dhaubanjar 45d57e780f Added properties in DropdownButtonFormField to match DropdownButton (#36998) 
* Added properties in DropdownFormField to match DropdownButton

* Minor style guide related changes
 2019-09-09 21:11:23 -07:00
Slade Capasso 4c254e5e8a Updates to debugFillProperties to test all properties in slider.dart and slider_test.dart (#39632) 2019-09-09 18:31:40 -07:00
LongCatIsLooong 663d0b13bc
Fix double.infinity serialization (#40099) 2019-09-09 18:30:12 -07:00
Jonah Williams 477ae6b8ce
cleanup use of build runner internals (#40045) 2019-09-09 18:16:03 -07:00
Jonah Williams eb7eb3ce3c
use build runners script gen (#40049) 2019-09-09 18:15:17 -07:00
Jonah Williams 0f365d3add
remove dart dir chrome profile (#39934) 2019-09-09 18:14:13 -07:00
Jonah Williams f19e4ab4f7
roll dwds (#40001) 2019-09-07 15:35:14 -07:00
Christopher Fujino f945079c65
remove fallback code for ios/usb artifacts (#39585) 2019-09-06 14:23:20 -07:00
Jonah Williams b2da79ce98
roll build runner and remove delay (#39988) 2019-09-06 14:19:12 -07:00
Harry Terkelsen 83da35fbbc
If there are no web plugins, don't generate a plugin registrant (#39910) 2019-09-06 12:54:31 -07:00
Jonah Williams b4c3671718
Register reload sources call and make 'r' restart for web (#39950) 2019-09-06 10:41:15 -07:00
lisa-liao 8b90d9d045 Allow independent theming of Persistent and Modal bottom sheets Background Color (#39333) 2019-09-06 13:06:01 -04:00
LongCatIsLooong 8661dc4022
Make CupertinoDynamicColor.resolve return null when given a null color (#39927) 2019-09-06 09:58:13 -07:00
chunhtai 57d714ebb8
fix widget built twice during warm up frame (#39079) 2019-09-06 09:46:18 -07:00
Jonah Williams 296e97f322
Revert "Correct libraries path and remove dart:io and dart:isolate for web dart platform (#39364)" (#39985) 
This reverts commit 3f4d27c4bc.
 2019-09-06 09:24:14 -07:00
Walid Elalaouy 8601bb7b38 Add showAboutDialog sample (#39299) 2019-09-06 09:06:53 -07:00
Jonah Williams 3f4d27c4bc
Correct libraries path and remove dart:io and dart:isolate for web dart platform (#39364) 2019-09-06 08:21:41 -07:00
Konstantin Scheglov 3118ae19ff
Fix new prefer_const_constructors after analyzer fix. (#39917) 2019-09-05 19:59:24 -07:00
Jonah Williams 0167f53101
update packages --force upgrade (#39932) 2019-09-05 19:35:59 -07:00
Michael Goderbauer e2325600ea
Do not render any frames when just initializing Bindings (#39535) 2019-09-05 17:08:50 -07:00
Shi-Hao Hong abfc560b9d
ToggleButtons test improvement (#38898) 
* Improve finders throughout toggle_buttons_test.dart

* Improve Material finders

* Update toggle_buttons_theme_test.dart finders to be more precise

* Refactor out textStyle and iconTheme finders

* Refactor iconTheme and buttonTextTheme logic
 2019-09-05 15:12:36 -07:00
Ian Hickson a415c76b5b
Docs (#39198) 
* Minor improvements to framework documentation.

* maybePop documentation fix

* Mark some flutter_test arguments required.

Without these set, we get a crash.

* Minor correction to ListView docs
 2019-09-05 15:11:50 -07:00
stuartmorgan 4c2c7c417d
Switch to the Win32 Windows embedding (#39836) 
Pulls the Win32 embedding artifacts instead of the GLFW versions for
Windows.

Fixes #38590
 2019-09-05 10:09:12 -07:00
stuartmorgan 3948e8759e
Allow specifying a project for Xcode getInfo (#39782) 
Avoids unnecessarily breaking projects that have another .xcodeproj in
their macos/ directory, which worked until the addition of the getInfo
call.
 2019-09-05 10:07:03 -07:00
LongCatIsLooong 443892bd27
CupertinoButton & Bottom tab bar dark mode (#39765) 
* CupertinoTabBar

* CupertinoButton

* update

* review
 2019-09-05 10:06:45 -07:00
liyuqian 7c0dfd5362
Revert "Replace deprecated onReportTimings w/ frameTimings (#38861)" (#39778) 
This reverts commit 6ef80b447f.
 2019-09-05 09:58:08 -07:00
Jonah Williams dd7694256e
remove input files argument to target (#39769) 2019-09-05 09:56:37 -07:00
Jonah Williams 4728ef5c16
handle browser refresh (#39776) 2019-09-05 09:56:05 -07:00
Jonah Williams 06348522c3
workaround for mangled web sdk source map packages (#39774) 2019-09-05 09:55:54 -07:00
Justin McCandless 64424a6ae4
Null TextWidthBasis docs (#39761) 
Docs improvement after seeing "null" showing up for TextWidthBasis.
 2019-09-05 09:54:56 -07:00
Mouad Debbar 2640bfeb10
Allow gaps in the initial route (#39440) 2019-09-05 09:51:35 -07:00
Zachary Anderson 0f2af976a2
[flutter_tools] Add a timeout to another showBuildSettings command (#39579) 2019-09-05 09:50:46 -07:00
Kenzie Schmoll d50d9c5e60
Register flutterVersion service in flutter_tools. (#39524) 
* Register getFlutterVersion service in flutter_tools.

* Add short revision ids to response.

* Rename method and remove obsolete comments.

* Fix broken test by adding sendPeerNotifications flag.

* Implement mockPeer.sendNotification.
 2019-09-05 09:50:36 -07:00
Devon Carew 57e6042f68
update to the latest package:dwds (#39834) 2019-09-05 09:50:10 -07:00
Anthony 3932ffb1cd Revert "Show search app bar theme (#37962)" (#39786) 
This reverts commit e3f8d05540.
 2019-09-04 20:13:16 -07:00
Ian Hickson 2efbc11b7a
Revert "Keep Flutter.framework binaries writable so they can be code signed (#39539)" (#39859) 
This reverts commit 72cacb4040.
 2019-09-04 17:47:39 -07:00
rami-a af9f210443
Fix single action banner to ensure button alignment (#39583) 2019-09-04 09:41:46 -04:00
Jenn Magder 72cacb4040
Keep Flutter.framework binaries writable so they can be code signed (#39539) 2019-09-03 18:00:45 -07:00
Greg Spencer f9bc89932c
Re-Land of HighlightMode change with benchmark improvements. (#39589) 
* Automatic focus highlight mode for FocusManager

This re-lands the highlight mode change.

* Review Changes
 2019-09-03 17:49:41 -07:00
Emmanuel Garcia d230234d67
Revert Maven dependencies (#39747) (39157) (#39784) 2019-09-03 17:49:10 -07:00
Harry Terkelsen 6f4359d1b7
Add lib/generated_plugin_registrant.dart to gitignore (#39781) 2019-09-03 16:03:09 -07:00
LongCatIsLooong e7f608072b
CupertinoActionSheet dark mode & fidelity (#39215) 2019-09-03 13:48:09 -07:00
Jonah Williams d804097014
print launching on device message (#39748) 2019-09-03 12:55:06 -07:00
Jonah Williams af851ab6bc
Revert "remove input files argument to target (#39701)" (#39768) 
This reverts commit 5e7beaf7b8.
 2019-09-03 12:47:33 -07:00
Jonah Williams 5e7beaf7b8
remove input files argument to target (#39701) 2019-09-03 12:46:08 -07:00
LongCatIsLooong 63c3de1091
Timer picker fidelity revision (#38481) 
* WIP

* trying out different numbers

* apply intrinsic width and height

* update

* update behavior

* documentation

* wip

* fix tests

* constants

* respect theme

* respect theme

* add new test

* add new test

* update

* review

* update golden commit hash
 2019-09-03 11:54:25 -07:00
Jonah Williams 476a4de17e
Add delay to recompile request for web (#39752) 2019-09-03 11:53:46 -07:00
Jonah Williams 76ebcc8a14
remove web flag from create (#39756) 2019-09-03 11:53:27 -07:00
Emmanuel Garcia 1b429bdb47
Fix type mismatch in Gradle (#39747) 2019-09-03 11:39:30 -07:00
Jonah Williams cc9b614efd
minor cleanup and prevent multiple exit (#39751) 2019-09-03 11:00:39 -07:00
Harry Terkelsen d33cf11556
Automatically generated registrants for web plugins (#39628) 
* WIP on web plugin registry

* WIP on registering plugins

* WIP on web plugin registration

* Only generate `package:flutter_web_plugins` imports if plugins are
defined

* Add parsing test

* Add documentation

* Fix analyzer warnings

* add license headers

* Add tests for package:flutter_web_plugins

* Run `flutter update-packages --force-upgrade`

* Fix analyzer errors

* Fix analyzer error in test

* Update copyright and remove flutter SDK constraints

* Enable tests since engine has rolled

* add flutter_web_plugins tests to bots

* Create an empty .packages file for WebFs test
 2019-09-03 10:37:34 -07:00
Jenn Magder 0b93c96f52
Remove bitcode=NO from add-to-app flows (#39503) 2019-09-03 10:28:19 -07:00
chunhtai 36a7e3f0ef
fix sliverfixedextent with sliverchildbuilderdelegate does not correct calculate max scroll extent (#39142) 2019-09-03 10:27:37 -07:00
Tom Robinson f5fc32ff8f Update docs for GrowthDirection and scrollOffset (#39286) 2019-09-03 09:45:44 -07:00
Francisco Magdaleno deb155e89a
[macos] Check for special keys before creating a logical key (#37901) 2019-09-03 09:13:01 -07:00
Kate Lovett c8af729d1c
Golden Doc Updates (#39082) 2019-09-03 08:45:51 -07:00
Zachary Anderson b9029c7672
[flutter_tool] Add onError callback to asyncGuard. Use it in Doctor (#39445) 2019-09-03 08:14:44 -07:00
LongCatIsLooong ad47f9eea9
CupertinoActivityIndicator & CupertinoApp dark mode (#39289) 2019-09-03 07:52:36 -07:00
Greg Spencer 8daa165d01
Make disabled buttons/chips/text fields not be focusable. (#38726) 
This changes the behavior of text fields, Material buttons, and Chips so that if they are disabled they lose focus. Before this change, it was possible to disable a control and then use focus traversal to reach it anyhow, and in the case of text fields, enter text into a disabled field.

Fixes #33985
 2019-09-03 07:51:28 -07:00
rami-a 0ebcfe10da
Prevent exception when creating a Divider borderSide (#39572) 2019-09-03 10:15:42 -04:00
stuartmorgan 2e058142d2
Fix macOS App.framework version symlink (#39702) 
The Current->A symlink in a framework shouldn't have a trailing slash;
some versions of codesigning consider the version with a trailing slash
unsignable.
 2019-09-02 16:26:15 -07:00
Anthony e3f8d05540
Show search app bar theme (#37962) 
Use the entire appBarTheme from the showSearch delegate for the search pages appBar theme, rather than just a select set of fields.
 2019-09-02 14:23:42 -04:00
Emmanuel Garcia b63cb44105
Use new Maven artifacts from Gradle (#39157) 2019-09-02 10:35:17 -07:00
Jonah Williams 7bc4074ff3
use dpr and window size from binding (#39577) 2019-09-01 23:57:32 -07:00
Jonah Williams f12a5ec347
dont hide build commands (#39555) 2019-09-01 23:57:11 -07:00
Jonah Williams f5eb12cdc2
filter error message from skip build script checks (#39558) 2019-09-01 23:56:56 -07:00
Devon Carew e468296af3
remove a period from the service protocol printout (#39545) 2019-08-31 11:39:00 -07:00
Mouad Debbar a2957c571e
Upstream changes necessary for text editing in flutter web (#39344) 2019-08-30 10:00:03 -07:00
Anthony bb1d139c50
Replace doc example text (#39428) 
The Text in the Transform.scale example is "Bad Ideas", which could be confusing as example code. This PR replaces it with something more random.
 2019-08-30 10:29:32 -04:00
Matt Carroll d5c5ac62ad
Revert "Add handling of 'TextInput.clearClient' message from platform to framework (#35054). (#35100)" (#39523) 
This reverts commit 324fe201b0.
 2019-08-29 21:52:33 -07:00
Kaushik Iska fc05c3738c
Flutter Plugin Tool supports multi-platform plugin config (#38632) 2019-08-29 21:51:31 -07:00
Jonah Williams b2a4ebe38f
Handle single unsupported device (#39541) 2019-08-29 21:39:38 -07:00
Emmanuel Garcia 6266d5f35d
Log flags in build apk and appbundle (#39457) 2019-08-29 21:37:35 -07:00
Jonah Williams 2dbf0106d8
Create dart tool directory if it is missing (#39543) 2019-08-29 21:31:57 -07:00
Dan Field eefe9d9527
keep symbols for profile (#39530) 2019-08-29 20:54:30 -07:00
Jonah Williams 359b532570
Remove run in shell and add unit test for chrome launching (#39462) 2019-08-29 19:35:06 -07:00
Gary Qian 7e361d7461
Reland "Expose LineMetrics in TextPainter (#39282)" (#39519) 2019-08-29 17:19:14 -07:00
Phil Quitslund 37846b032f
migrate from slow async io calls (#39515) 
* migrate from slow async io calls
 2019-08-29 16:47:10 -07:00
LongCatIsLooong 98b9f31478
make CupertinoDynamicColor const constructible (#39430) 
* make CupertinoDynamicColor const constructible

* review
 2019-08-29 16:40:16 -07:00
Dan Field 632526aab9
Update validation to support Xcode11 version (#39463) 2019-08-29 15:28:05 -07:00
Harry Terkelsen 13bd52bf9e
Add HtmlElementView (the Flutter Web platform view) (#37819) 
* Implement HtmlView, the platform view widget for Flutter Web

* Document HtmlView constructor

* Respond to review comments

* - Rename to HtmlElementView
- Assert running on web
- Move test to Chrome-only file
 2019-08-29 12:49:04 -07:00
Jonah Williams ed4794382b
Revert "Expose LineMetrics in TextPainter through computeLineMetrics. (#39282)" (#39504) 
This reverts commit d67f47b21e.
 2019-08-29 12:14:02 -07:00
Gary Qian d67f47b21e
Expose LineMetrics in TextPainter through computeLineMetrics. (#39282) 2019-08-29 11:28:04 -07:00
Tong Mu 4fc11db5cc
Add IterableFlagsProperty and use it on proxy box classes (#39354) 
* Add FlagsSummary and implement Listener
 2019-08-29 10:07:48 -07:00
Harry Terkelsen 9f4ab273f1
Add viewType to PlatformViewLink (#39446) 
* Add viewType to PlatformViewLink

Re-initialize the controller when the viewType changes.

* Re-word `PlatformViewLink` doc comment for clarity
 2019-08-28 20:02:08 -07:00
Jonah Williams 4984d1a33d
update packages (#39429) 2019-08-28 17:04:07 -07:00
Jonah Williams 73b798b260
Revert "Better docs for text (#38922)" (#39447) 
This reverts commit ddd31bcee7.
 2019-08-28 16:01:47 -07:00
liyuqian 6ef80b447f
Replace deprecated onReportTimings w/ frameTimings (#38861) 
This is the continuation of https://github.com/flutter/engine/pull/11041 and https://github.com/flutter/flutter/pull/38574

This is not a breaking change as we're not removing `onReportTimings` API.
We're simply removing the use of it in our framework.
 2019-08-28 15:25:06 -07:00
Dan Field cb965495d7
Reland "Relax arguments around local engine, build hello_world with bitcode" (#39434) 2019-08-28 15:19:04 -07:00
Emmanuel Garcia 4a1c62c28b
Add missing files in the Gradle wrapper directory (#39145) 2019-08-28 14:52:08 -07:00
Ian Hickson ddd31bcee7 Better docs for text (#38922) 2019-08-28 14:41:09 -07:00
Jonah Williams f362419601
make sure profile is forwarded through build web command (#39414) 2019-08-28 14:05:01 -07:00
Kenzie Schmoll 13f18d5a66
Make inspector details subtree depth configurable. (#39085) 
* Make inspector details subtree depth configurable.
 2019-08-28 14:02:12 -07:00
Jonah Williams 393106fbf5
Revert "Relax requirements around local engine, build hello_world with bitcode (#39357)" (#39431) 
This reverts commit 202c1b4224.
 2019-08-28 13:12:45 -07:00
Dan Field 202c1b4224
Relax requirements around local engine, build hello_world with bitcode (#39357) 2019-08-28 10:27:01 -07:00
Zachary Anderson b7c714e84c
[flutter_tool] Use a timeout for xcode showBuildSettings (#39280) 2019-08-28 10:03:53 -07:00
Andrei Lesnitsky 35de8d5278 respect reversed scroll views (#39195) 
This PR makes Scrollable scroll in correct direction when reverse: true on desktop and web
 2019-08-28 06:49:49 -07:00
xster 4640690d0f
let flutter build aar use a local engine (#39312) 2019-08-27 23:46:33 -07:00
Jonah Williams 55a1ba761d
Use output dir instead of specific paths in assemble rules (#39274) 2019-08-27 22:52:51 -07:00
Justin McCandless d3b70c91bf
Add the textAlignVertical param to TextFormField (#39144) 2019-08-27 19:08:35 -07:00
Jonah Williams 80f96ee662
surface errors from build runner (#39358) 2019-08-27 19:08:10 -07:00
Jonah Williams 23637844a3
fix source map loading and service protocol for flutter web (#39189) 2019-08-27 19:06:48 -07:00
stuartmorgan 2476415b60
Rename macos_build_flutter_assets.sh (#39353) 
The name is very misleading at this point, since it does substantially
more than build flutter_assets. Name it more generically as a wrapper
for 'assemble' for macOS builds.
 2019-08-27 19:03:14 -07:00
Emmanuel Garcia 5353d5e877
Fid app bundle in Gradle 3.5 (#39126) 2019-08-27 17:08:02 -07:00
Zachary Anderson 91ae1409b9
[flutter_tool] Create a temp snapshot to run create_test.dart tests (#39338) 2019-08-27 14:28:03 -07:00
adazh 5667b78291
Added a Driver wait condition for no pending platform messages (#39196) 2019-08-27 14:26:31 -07:00
Jonah Williams 6f71ce26d6
Place terminalUi flag on terminal interface (#39214) 2019-08-27 14:20:51 -07:00
Tong Mu 7f02566ca6
Add "OneSequenceRecognizer.resolvePointer". Fix DragGestureRecognizer crash on multiple pointers (#39017) 
* Add drag tests

* Add resolvePointer

* Correct monodrag implementation

* Fix some addTearDown
 2019-08-26 17:44:01 -07:00
stuartmorgan 7407695816
Add profile support on macOS (#39264) 
Fix some places where Debug/Release was treated as a binary switch.

Makes similar changes to Windows and Linux to simplify adding profile
support to those platforms in the future. This means `--profile` builds
will fail on Linux and Windows for now, but that's fine since they
aren't actually supported, and unlike `--release` don't provide useful
functionality at the native code level.

Also fixes 'stopApp' always using Debug on macOS, to avoid showing an
error when running Profile (or Release).

Fixes #33203
 2019-08-26 16:30:30 -07:00
Tom Robinson 6204eb6445
Change SliverGeometry.maxScrollObstructionExtent for RenderSliverFloatingPersistentHeader to match docs (#39263) 
RenderSliverFloatingPersistentHeader does not pin to the leading edge of the viewport so the value of maxScrollObstructionExtent in it's SliverGeometry should be 0 per the docs at https://api.flutter.dev/flutter/rendering/SliverGeometry/maxScrollObstructionExtent.html.
 2019-08-26 15:42:10 -07:00
Jonah Williams 0f8b8c91a3
Kill resident runner on browser disconnect. (#39066) 2019-08-26 15:06:36 -07:00
Collin Jackson a1c185f37a
Fix plugin template app's tests (#39080) 
* Fix plugin template

* Add test of plugin template working
 2019-08-26 14:57:16 -07:00
Venkataramana Neelapala 19cdb21cb6 Added backgroundColor property to CupertinoTimePicker and CupertinoDatePicker. #34741 (#39056) 2019-08-26 14:47:49 -07:00
Michael Klimushyn e31d88f9c9
Downgrade the AndroidX warning (#39147) 
Originally we wanted to cast as wide of a net and make the warning as
prominent as possible. Recently we've received feedback that the false
positives are more harmful than not, so downgrading the loud message to
a single line warning.
 2019-08-26 14:30:22 -07:00
Zachary Anderson e9bd2ef087
[flutter_tool] Some additional input validation for 'version' (#39136) 2019-08-26 12:12:50 -07:00
Chris Yang 7f5540faac
PlatformViewLink handles focus (#38643) 
In the build of PlatformViewLink, Added a FocusNode wrapping around the surface widget.
The focus node will ask platform view to clear its focus when necessary through [PlatformViewController.clearFocus].
The platform view can notify the framework it wants to gain focus by calling [PlatformViewCreationParams.onFocusChanged]
 2019-08-26 12:04:17 -07:00
Hans Muller 35c916d733
Added Scaffold.extendBodyBehindAppBar (#39156) 
* Co-authored-by: Brett Morgan <brettmorgan@google.com>
 2019-08-26 11:31:19 -07:00
Greg Spencer 365f577c70
Normalize assert checking of clipBehavior (#38568) 
I noticed that we were pretty inconsistent with the way that we checked the value of clipBehavior in the framework, so I normalized the usages and updated docs where necessary.

This is a breaking change if you used to pass null explicitly to FlatButton, OutlineButton or RaisedButton constructors, expecting to get Clip.none. It will now assert if you do that. Existing implementations that pass null implicitly by not specifying clipBehavior won't need to change their call sites. It always implicitly defaulted to Clip.none before, and it will continue to do that, it's only places where it was explicitly set to null in order to get the implicit default that it will fail.
 2019-08-23 14:08:04 -07:00