development/flutter
development/flutter
1
0
Fork 0
mirror of https://github.com/flutter/flutter synced 2024-10-13 11:42:54 +00:00
Code Issues Packages Projects Releases Wiki Activity

[flutter_tool] Some additional input validation for 'version' (#39136)

Browse source
This commit is contained in:
Zachary Anderson 2019-08-26 12:12:50 -07:00 committed by GitHub
parent 7f5540faac
commit e9bd2ef087
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 14 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
packages/flutter_tools/lib/src/commands/version.dart
View file

@ -65,6 +65,10 @@ class VersionCommand extends FlutterCommand {
// check min supported version
final Version targetVersion = Version.parse(version);
if (targetVersion == null) {
throwToolExit('Failed to parse version "$version"');
}
bool withForce = false;
if (targetVersion < minSupportedVersion) {
if (!argResults['force']) {

10
packages/flutter_tools/test/general.shard/commands/version_test.dart
View file

@ -62,6 +62,16 @@ void main() {
ProcessManager: () => MockProcessManager(),
});
testUsingContext('tool exit on confusing version', () async {
const String version = 'master';
final VersionCommand command = VersionCommand();
final Future<void> runCommand = createTestCommandRunner(command).run(<String>['version', version]);
expect(() async => await Future.wait<void>(<Future<void>>[runCommand]),
throwsA(isInstanceOf<ToolExit>()));
}, overrides: <Type, Generator>{
ProcessManager: () => MockProcessManager(),
});
testUsingContext('exit tool if can\'t get the tags', () async {
final VersionCommand command = VersionCommand();