Commit graph

33482 commits

Author SHA1 Message Date
suragch 9619c33348
Remove obsolete comment (#120265)
* Remove obsolete comment

The method `_stopCursorTimer` no longer exists.

* Add edited comment back in

Addresses these comments:
- https://github.com/flutter/flutter/pull/120265#discussion_r1101673834
- https://github.com/flutter/flutter/pull/120265#discussion_r1102120022

---------

Co-authored-by: Kate Lovett <katelovett@google.com>
2023-02-23 02:46:16 +00:00
codiss 156c6614bf
Fix Material3 TabBarTheme.dividerColor not working (#119690)
* Fixed Material3 TabBarTheme.dividerColor not working

* Add 'Material3 - TabBar inherits the dividerColor of TabBarTheme' test

---------

Co-authored-by: Kate Lovett <katelovett@google.com>
2023-02-23 02:46:11 +00:00
Michael Goderbauer 4ef1fe4434
Work-around for channels flake (#121261) 2023-02-23 02:46:08 +00:00
Michael Goderbauer 1737233567
Fix typo (#121291) 2023-02-23 02:46:06 +00:00
Greg Spencer a50bdcfd18
Add getInheritedWidgetOfExactType to BuildContext (#121276)
* Add getInheritedWidgetOfExactType to BuildContext

* Use the new API in all the places

* Fix doc error

* Review Changes
2023-02-23 01:09:51 +00:00
Christopher Fujino 048725981e
remove Christopher Fujino from codeowners of //dev/ci (#121281)
Co-authored-by: Ricardo Amador <32242716+ricardoamador@users.noreply.github.com>
2023-02-23 01:09:48 +00:00
David Skelly 368537b910
Add padding to DropdownButton (#115806)
* add padding param to DropdownButton

* improve padding comment

* update test

* Add more context to documentation

* update padding documentation with more detail

---------

Co-authored-by: Kate Lovett <katelovett@google.com>
2023-02-23 01:07:51 +00:00
Tomasz Gucio f85a75db25
Remove outdated TODO (#121200) 2023-02-23 01:02:52 +00:00
engine-flutter-autoroll fede6d17e9
Roll Flutter Engine from 3aa112c75ccb to 137caa761540 (20 revisions) (#121286)
* 0fd15eece Started using bgr10_xr for opaque surfaces. (flutter/engine#39727)

* f0e5c08f7 [platform_view] fix overlapping platform view not touchable (flutter/engine#39527)

* 03b5998b4 Roll Fuchsia Mac SDK from 25mb67G0L_sZ_OQCC... to dj-2XkYHvZUsqlZTc... (flutter/engine#39782)

* 2e5b1bf04 Updated the wide-gamut constant and added a unit test for it. (flutter/engine#39776)

* 1ce93ca0a Roll Dart SDK from 0db7573c6b70 to c9a4fd7fd7fa (1 revision) (flutter/engine#39783)

* 8368fb5b6 Roll Dart SDK from c9a4fd7fd7fa to 5003b952affb (1 revision) (flutter/engine#39787)

* ee5ea205b Roll Dart SDK from 5003b952affb to 6f5df63655ad (1 revision) (flutter/engine#39790)

* d9be356a8 Roll Fuchsia Mac SDK from dj-2XkYHvZUsqlZTc... to cGa3bk2BmrHL_waB8... (flutter/engine#39791)

* 50af61302 [web] Add `dart:js_interop` to BUILD.gn. (flutter/engine#39792)

* eb5e5624d [common] Use FML macro to prevent copy/assignment (flutter/engine#39786)

* 6acfddc78 Add more log when receiving semantics node not part of update (flutter/engine#39777)

* 336e7ce63 Roll Skia from 22b594afb4d3 to 78bad646fe78 (24 revisions) (flutter/engine#39793)

* e65391f8b [Impeller] Add root dockspace to playgrounds (flutter/engine#39789)

* 3848f6429 [Impeller] ensure glyph type contributes to FontGlyphPair hash/eq (flutter/engine#39794)

* cb1ef6f08 Roll Skia from 78bad646fe78 to 335cabcf8b99 (2 revisions) (flutter/engine#39795)

* ac6129db2 made opaque wide gamut images take up 32 bits per pixel (flutter/engine#39691)

* c74a4bc67 save/restore around clipping the (potentially cached) frame canvas (flutter/engine#39797)

* ed3f15d94 [Embedder API] Add CODEOWNERS (flutter/engine#39784)

* 1a3bddcc1 Fix a race in ShellTest.PushBackdropFilterToVisitedPlatformViews (flutter/engine#39798)

* 137caa761 Roll Dart SDK from 6f5df63655ad to 602941be8007 (2 revisions) (flutter/engine#39800)
2023-02-23 00:20:39 +00:00
Casey Hillers 8f7ccd4c41
Revert "Speed up first asset load by using the binary-formatted asset manifest for image resolution (#118782)" (#121220)
This reverts commit e3db0488ad.
2023-02-23 00:13:33 +00:00
Ricardo Amador 1168c2c8b9
Update jdk in cirrus dockerfile image. (#121251)
* Update jdk in cirrus dockerfile image.

* Update to install jaxb for jdk11. Hopefully this works.

* Add jaxb to classpath

* Classpath was not set in run

* Update to use newer tools

* typo

* Update path to commandline tools.

* Trying different approach

* Wrong path

* Wrong path

* Wrong path

* Wrong path

* Remove debug statements
2023-02-22 15:06:58 -08:00
Casey Hillers 9241426828
Revert "Revert "[Re-land#2] Button padding M3 (#119498)" (#119597)" (#119656)
This reverts commit 7ba440655a.
2023-02-22 13:51:03 -08:00
Michael Goderbauer 5ccb4d4b95
Rename WindowPadding to ViewPadding (#121152)
* Rename WindowPadding to ViewPadding

* dart fix

* typos
2023-02-22 21:32:40 +00:00
Mushaheed Syed 7d85a585da
Add ActionButtonIconsData for overriding action icons (#118229)
* Add ActionButtonIconsData for overriding action icons

* Fix formatting issues

* Add missing exports in material library and add copyWith method in ActionButtonIconsData

* Move all action buttons, and icons to action_buttons.dart

* Rename actionButtonIcons to actionIconTheme

* Refactor buttons in action_buttons.dart to extend a private class for common implementation

* Refactor icons in action_buttons

* Fix docs in action_buttons_theme

* Fix #107646 always use 'Icons.arrow_back' as a back_button icon in web

* Update documentation for action buttons and add style parameter to every action button

* Fix analyzer warnings

* Add missing style argument in IconButton of _ActionButton

* Add tests for action buttons, action icon theme, drawer buttons, and back buttons

* Add example (+test) for action icon button's action icon theme in examples/api

* Fix analysis errors

* Add missing license header in action_icon_theme.0.dart

* Fix deprecation notice in theme_data.dart

* Update theme data tests for actionIconTheme

* Remove iconSize parameter from ActionButtons and update docs

* Fix failing tests

* Update button color during backbutton tests to red

* Fix analytics issues

* Fix format
2023-02-22 09:22:44 -08:00
Ricardo Amador d816e72f07
Do not swallow the error from the licenses acceptance (#121243) 2023-02-22 08:55:08 -08:00
gaaclarke 4c25587b71
Added negative test and blur test to the wide gamut tests. (#120914)
* Added negative test and blur test to the wide gamut tests.

* switched back to dstOver

* fixed blur test

* analysis warnings

* analyzer
2023-02-22 00:10:25 +00:00
suragch dad9eb21f9
fix spelling typo (#120062)
* fix spelling typo

* _index not nullable

This address the comment here: https://github.com/flutter/flutter/pull/120062#issuecomment-1421424676
2023-02-21 23:16:23 +00:00
Jessica Pereira aa29358c5e
Fix license page rtl (#120497)
* fix license page rtl

* fix editor spacings, tests to lateral view

* fix defaultSize and setSurfaceSize

* add validation for packageList position

* fix spacing

* simplify align
2023-02-21 21:54:39 +00:00
Kate Lovett c6e1a4dc9a
Fix formatting (#121167) 2023-02-21 21:34:19 +00:00
engine-flutter-autoroll 7d497ce887
3aa112c75 Fix documentation of FlEngineOnPreEngineRestartHandler (flutter/engine#39759) (#121168) 2023-02-21 21:16:37 +00:00
David Iglesias a463bb82c4
[tool][web] Makes flutter.js more G3 friendly. (#120504)
* Allow any JS file in flutter loader.

* Nag only if service worker API is completely unavailable.

* Add info about Secure Contexts if that may be the reason why serviceworker is not available.

* Update sanity test.

* If service worker settings are null, do not even check if the API is available.
2023-02-21 20:51:37 +00:00
engine-flutter-autoroll 06ccf55454
Roll Flutter Engine from c3d9c30f3e09 to 40f60b92ba17 (2 revisions) (#121163)
* 068670a1f Roll Dart SDK from 12aec0627d0a to 0db7573c6b70 (2 revisions) (flutter/engine#39774)

* 40f60b92b Roll Skia from a16472080754 to 22b594afb4d3 (2 revisions) (flutter/engine#39773)
2023-02-21 20:23:18 +00:00
engine-flutter-autoroll 1f03825f30
Roll Flutter Engine from aa526b68fc1b to c3d9c30f3e09 (2 revisions) (#121158)
* 5b00a9579 Roll Skia from 2f05923f825e to a16472080754 (18 revisions) (flutter/engine#39772)

* c3d9c30f3 [Windows] Mark move-only classes as such (flutter/engine#39738)
2023-02-21 19:32:18 +00:00
stuartmorgan c564007f94
Switch analysis to flutter/packages (#120908)
In preparation for the merge of flutter/plugins into flutter/packaegs,
update the cross-repo analysis to flutter/packages rather than
flutter/plugins.

The flutter_plugins.version file is left intentionally for now to avoid
issues with the roller; it will be removed when the roller has been
updated to roll the other repository.
2023-02-21 14:26:08 -05:00
gaaclarke bd5e8db3a3
Turned off bringup for wide gamut color tests. (#120918) 2023-02-21 18:53:11 +00:00
Kate Lovett 09518ac725
Remove single axis assertion (#120738) 2023-02-21 18:05:07 +00:00
Kate Lovett 4acbe9706f
Remove alternate axis assertion from StretchingOverscrollIndicator (#120734)
* remove axes assertion

* Update packages/flutter/lib/src/widgets/overscroll_indicator.dart
2023-02-21 18:05:04 +00:00
Enguerrand ARMINJON 6259b690f6
feature/clean-a-specific-scheme: Add this-scheme new flag for clean command (#116733)
Co-authored-by: Enguerrand_ARMINJON_MAC_2 <earminjon@sqli.com>
2023-02-21 17:35:13 +00:00
Mouad Debbar 902d86e09c
[web] Unify line boundary expectations on web and non-web (#121006)
* [web] Temporarily disable a line boundary test

* [web] Unify line boundary expectations on web and non-web
2023-02-21 17:28:13 +00:00
Mateus Felipe C. C. Pinto ebbc94bc2b
allow passing --file-reporter option to test running refs #69425 (#120716)
* allow passing --file-reporter option to test running refs #69425

* Add trailing comma to help to meet style requirements

* Add space between tests for clarity

---------

Co-authored-by: daniel-v <dvarga@skawa.hu>
2023-02-21 17:24:11 +00:00
engine-flutter-autoroll 23df770860
34a681353 [local_auth] Add Android theme compatibility documentation (flutter/plugins#6875) (#121144) 2023-02-21 17:01:09 +00:00
Andrew Kolos e3db0488ad
Speed up first asset load by using the binary-formatted asset manifest for image resolution (#118782)
* add asset manifest bin loading and asset manifest api

* use new api for image resolution

* remove upfront smc data casting

* fix typecasting issue

* remove unused import

* fix tests

* lints

* lints

* fix import

* fix outdated type name

* restore AssetManifest docstrings

* update test

* update other test

* make error message for invalid keys more useful
2023-02-21 16:05:12 +00:00
engine-flutter-autoroll 7175de4fe6
aa526b68f Roll Fuchsia Mac SDK from X3ES-2nMPaH13KIAI... to 25mb67G0L_sZ_OQCC... (flutter/engine#39769) (#121136) 2023-02-21 12:43:40 +00:00
engine-flutter-autoroll e5619b9357
35aeeec58 Roll Dart SDK from a1401ef3d0ec to 12aec0627d0a (1 revision) (flutter/engine#39767) (#121114) 2023-02-21 03:38:23 +00:00
engine-flutter-autoroll 8e66901ee0
Roll Flutter Engine from 5d61f352ca32 to 9b3784fefe9a (2 revisions) (#121111)
* 355f56087 Roll Dart SDK from 194b1d4829c9 to a1401ef3d0ec (1 revision) (flutter/engine#39764)

* 9b3784fef Roll Fuchsia Mac SDK from sXPr06r252ZU681Fi... to X3ES-2nMPaH13KIAI... (flutter/engine#39766)
2023-02-20 23:46:26 +00:00
engine-flutter-autoroll 980b3c5b0e
Roll Plugins from 8f3419be5e0e to 132d9c77da4d (16 revisions) (#121101)
* 3c7d54bba [camerax] Implement camera preview (flutter/plugins#7112)

* 48f50b4f1 [image_picker] Update NSPhotoLibraryUsageDescription description in README (flutter/plugins#6589)

* eea17c996 Migrate these tests to the "new" API. (flutter/plugins#7189)

* 190c6d916 Roll Flutter from 298d8c76ba to 0be7c3f30d (21 revisions) (flutter/plugins#7194)

* c0d4e8041 [google_sign_in] Endorses next web package. (flutter/plugins#7191)

* cc4eaba0f [google_maps]: Bump org.mockito:mockito-core (flutter/plugins#7099)

* 717a8bfef [image_picker]: Bump org.mockito:mockito-core (flutter/plugins#7097)

* 8a09d8c13 [lifecycle]: Bump org.mockito:mockito-core (flutter/plugins#7096)

* 40377a12a [in_app_pur]: Bump org.mockito:mockito-core (flutter/plugins#7094)

* 6a4bbf1df [url_launcher]: Bump org.mockito:mockito-core (flutter/plugins#7098)

* 96ab5cd12 Update codeowners (flutter/plugins#7188)

* 00d5855cc Add missing CODEOWNER (flutter/plugins#7016)

* c3e9d1ba3 [webview_flutter] Adds examples of accessing platform-specific features for each class (flutter/plugins#7089)

* 1f7b57917 Roll Flutter from 0be7c3f30d to 33e4d21f7c (5 revisions) (flutter/plugins#7196)

* 1acaf55c2 [plugins] Disables the AndroidGradlePluginVersion issue ID in all android packages (flutter/plugins#7045)

* 132d9c77d [espresso] Update some dependencies (flutter/plugins#7195)
2023-02-20 19:09:52 +00:00
Eilidh Southren ae8d05184e
[M3] Update checkbox shape value (#120976)
* update m3 values

* update test formatting

* update crswap

* update test

* update token value

* update tests
2023-02-20 11:38:26 +00:00
engine-flutter-autoroll 8d305b605e
5d61f352c Roll Fuchsia Mac SDK from 7FGKB187AdG0SCban... to sXPr06r252ZU681Fi... (flutter/engine#39760) (#121085) 2023-02-20 10:43:26 +00:00
engine-flutter-autoroll cc9b198213
780279109 [Impeller] Implement invert colors flag. (flutter/engine#39729) (#121074) 2023-02-20 05:49:25 +00:00
engine-flutter-autoroll c71e479fd4
cf85927ff Rename WindowPadding to ViewPadding (flutter/engine#39737) (#121069) 2023-02-20 00:00:39 +00:00
engine-flutter-autoroll d54d3b4d16
d00cc4b04 Roll Fuchsia Linux SDK from 7rgqQxifQPjH_2zXB... to 0RfFdaUCok_sFfUN1... (flutter/engine#39758) (#121068) 2023-02-19 23:08:26 +00:00
engine-flutter-autoroll fc8b7c7549
4434f3a43 Roll Fuchsia Mac SDK from HtmcMFg6ZlyRkcNsB... to 7FGKB187AdG0SCban... (flutter/engine#39756) (#121067) 2023-02-19 21:56:46 +00:00
engine-flutter-autoroll 33e4d21f7c
00ce81fdf Roll Fuchsia Linux SDK from Iykltk3-HtXqYplbg... to 7rgqQxifQPjH_2zXB... (flutter/engine#39755) (#121058) 2023-02-19 09:48:23 +00:00
engine-flutter-autoroll 3c6a25d7d8
4a58ff869 Roll Fuchsia Mac SDK from nvf4Ago0k-VS2JPxZ... to HtmcMFg6ZlyRkcNsB... (flutter/engine#39754) (#121056) 2023-02-19 09:04:29 +00:00
engine-flutter-autoroll 4245389900
1b71ea81a Roll ICU from 266a46937f05 to c6b685223182 (4 revisions) (flutter/engine#39753) (#121054) 2023-02-19 02:53:13 +00:00
engine-flutter-autoroll ab39d076ca
Roll Flutter Engine from a7c28d0851dd to 8d13f3761460 (2 revisions) (#121050)
* 027b63ef3 Roll Fuchsia Mac SDK from baD5uG2X0rk-EZZly... to nvf4Ago0k-VS2JPxZ... (flutter/engine#39751)

* 8d13f3761 Roll Dart SDK from 1a45ec0bd08e to 194b1d4829c9 (2 revisions) (flutter/engine#39752)
2023-02-18 21:09:24 +00:00
engine-flutter-autoroll 43e74c05e6
a7c28d085 Roll Fuchsia Linux SDK from hi7JwgHijuYYKAFUR... to Iykltk3-HtXqYplbg... (flutter/engine#39750) (#121047) 2023-02-18 20:09:18 +00:00
engine-flutter-autoroll 0be7c3f30d
Roll Flutter Engine from a9db42c3edc2 to c22c64812243 (2 revisions) (#121041)
* 3ecac16c3 Roll Dart SDK from 3ec7f1f92216 to cad83c2785e6 (8 revisions) (flutter/engine#39745)

* c22c64812 Roll Dart SDK from cad83c2785e6 to 1a45ec0bd08e (2 revisions) (flutter/engine#39748)
2023-02-18 14:35:06 +00:00
engine-flutter-autoroll a5b53a6d2a
a9db42c3e Roll Skia from 733a19f6a625 to 2f05923f825e (3 revisions) (flutter/engine#39744) (#121030) 2023-02-18 07:53:34 +00:00
engine-flutter-autoroll 66dce657fa
Roll Flutter Engine from 9a3c3e462fce to 3777ed51774f (2 revisions) (#121029)
* 7b1e703cb Roll Fuchsia Linux SDK from tMm2Lzb-LE20Rxwm9... to hi7JwgHijuYYKAFUR... (flutter/engine#39742)

* 3777ed517 Roll Fuchsia Mac SDK from _wymybZYKzX_3iFd6... to baD5uG2X0rk-EZZly... (flutter/engine#39743)
2023-02-18 07:09:35 +00:00