Commit graph

14316 commits

Author SHA1 Message Date
Jonah Williams 925f5f1c53
Revert "Wire up hot restart and incremental rebuilds for web (#33197)" (#33529)
This reverts commit 52ae99682e.
2019-05-29 12:09:01 -07:00
Zachary Anderson 8139a368ea
[flutter_tool] Use product runner in Fuchsia release build (#33282) 2019-05-29 10:08:58 -07:00
Jonah Williams 52ae99682e
Wire up hot restart and incremental rebuilds for web (#33197) 2019-05-29 09:49:16 -07:00
Mehmet Fidanboylu 27bdb11030
Expose service client and app isolate in driver (#33431) 2019-05-29 09:29:24 -07:00
Jonah Williams 0c517aecbb
remove empty file (#33489) 2019-05-29 09:24:36 -07:00
stuartmorgan aecf053ee0
Use vswhere to find Visual Studio (#33448)
Rather than hard-coding a set of locations to check, use vswhere (which
is installed by VS 2017 and later), and construct the vcvars64.bat path
relative to that. This will allow Windows builds to work without special
configuration for people who have VS installed at a custom path.

Also adds error logging with different messages for each failure point,
so that rather than the not-very-informative 'failed to find
vcvars64.bat' message, the failure will provide feedback about what to
do.

This is an interim solution; later this will be replaced by a
VisualStudio class with associated validator to match the structure of
the other toolchains.

Fixes #33249
2019-05-29 09:17:17 -07:00
stuartmorgan e1a784ae3f
Wrap Windows build invocation in a batch script (#33443)
Invoking msbuild with runInShell makes handling path escaping more
error-prone, and substantially increases the chances of running into
maximum path limits. This replaces the direct call with a .bat wrapper
that calls vsvars64.bat then msbuild, and uses relative paths within the
script to keep command lengths short.

Fixes https://github.com/flutter/flutter/issues/32792
2019-05-28 21:53:03 -07:00
Jonah Williams c56b455180
ensure unpack declares required artifacts (#33454) 2019-05-28 17:35:05 -07:00
Jason Simmons 786d9cee50
Fix a missing_return analyzer error in a code example (#33468)
This will fix a failure in dev/bots/analyze-sample-code.dart when using
the tip of tree Dart SDK.
2019-05-28 16:32:09 -07:00
Jonah Williams d729e70e0c
correctly pin build_daemon (#33463) 2019-05-28 15:28:24 -07:00
Jason Simmons f9e28e7df7
Do not return null from IosProject.isSwift (#33450) 2019-05-28 14:27:38 -07:00
Jonah Williams 8e3e0a89f4
Revert "Instrument add to app flows (#33297)" (#33449)
This reverts commit faec4ca361.
2019-05-28 12:52:58 -07:00
Jonah Williams 2d9b158faf
Revert "Framework support for font features in text styles (#33230)" (#33444)
This reverts commit 841286d652.
2019-05-28 11:35:03 -07:00
Harry Terkelsen 13e9bfcc94
Add binaryMessenger constructor argument to platform channels (#30406)
* Deprecates `BinaryMessages` in favor of a default instance of `BinaryMessenger`, called `defaultBinaryMessenger`
* Platform channels use the `defaultBinaryMessenger` for their binaryMessenger default argument.
2019-05-28 11:18:22 -07:00
Emmanuel Garcia faec4ca361
Instrument add to app flows (#33297) 2019-05-28 11:11:20 -07:00
Jason Simmons 841286d652
Framework support for font features in text styles (#33230)
See https://github.com/flutter/flutter/issues/31691
2019-05-28 11:06:54 -07:00
Greg Spencer 7c811b6a66
Fix first focus determination. (#33279)
Replacing the algorithm for finding the first focusable item in the focus tree. Somehow it was a kind of gibberish before, and really didn't work or make sense.
2019-05-28 10:19:19 -07:00
Luiz Dubas 841e1cf0af Add mustRunAfter on mergeAssets task to force task ordering (#33272)
Co-authored-by: Miguel Lemos <miguelslemos@gmail.com>
2019-05-28 10:01:19 -07:00
Jonah Williams a656bcf54f
rename test file that misnamed (#33361) 2019-05-28 09:56:13 -07:00
Yegor 8217f4bc8c
remove Layer.replaceWith due to no usage and no tests (#33164) 2019-05-28 09:55:32 -07:00
Kate Lovett 20c31e7ac3
Sample Code & Animation for Flow Widget (#31929)
* Adding sample and animation for Flow widget

* Updated dart templates for layout in API docs

* Updated the sample code for a clearer example.

* make clean
2019-05-28 09:30:16 -07:00
Todd Volkert 323373d333
Add blank newline after Dartdoc bulleted list. (#33403)
This also fixes up some indentation in some
bulleted lists.

https://github.com/dart-lang/dartdoc/issues/1969
2019-05-27 12:27:28 -07:00
Todd Volkert ddef473e07
Add clarification in Animation's listener API docs (#33363) 2019-05-27 10:17:09 -07:00
Jonah Williams 75d75bfaec
fix relative paths and snapshot logic in tool (#33283) 2019-05-25 19:47:17 -07:00
Jonah Williams 582c5587cd
make sure we build test targets too (#33284) 2019-05-25 19:46:44 -07:00
stuartmorgan 81c38b22cb
Implement macOS support in flutter doctor (#33277)
Splits Xcode validation out of the iOS validator and into a stand-alone
validator, and groups the CocoaPods validator with that top-level
validator instead of the iOS validator. iOS now validates only the
iOS-specific tools (e.g., ideviceinstaller).

Reorganizes many of the associated clases so that those that are used by
both macOS and iOS live in macos/ rather than ios/. Moves some
validators to their own files as part of the restructuring.

This is the macOS portion of #31368
2019-05-24 22:51:02 -04:00
Chris Bracken 156b4220b4
Americanise spellings (#33323)
Updates documentation and non-public API to use American spellings for
consistency with the rest of the codebase.

No changes to behaviour... other than how it's spelt.
2019-05-24 19:13:02 -07:00
Chris Bracken 4d9923201b
Correct typos (#33322)
Corects a bnuch of typeos throuhgout teh Fluter codebsae.

Made use of the `misspell` tool:
https://github.com/client9/misspell
2019-05-24 19:12:45 -07:00
stuartmorgan 0f6e4e6190
Add macosPrefix to the pubspec schema for plugins (#33287)
Adds a new macosPrefix, which serves the same purpose as iosPrefix but
for macOS plugins.

It is not yet used by the tooling, but this allows for plugins to start
to be written using it in preparation for tooling support for plugins.

Part of #32718
2019-05-24 15:39:48 -04:00
Todd Volkert daa7060882
Add stateful_widget_animation snippet template (#33295) 2019-05-24 09:24:16 -07:00
Shi-Hao Hong 9d52085344
ExpandIcon Custom Colors (#33148)
* Implement ExpandIcon custom color, expandedColor, and disabledColor

* Update to use pumpAndSettle instead of hard-coded duration

* Update colors to unfocused state, added dark mode test to active state

* Fix Colors.white30 doc opacity value

* Add links to Material Design specifications to color, expandedColor and disabledColor

* Update API docs to reference dark theme material page
2019-05-24 09:06:23 -07:00
Shi-Hao Hong 73798a1592
Explain hairline rendering in BorderSide.width docs (#33226) 2019-05-24 09:04:21 -07:00
Greg Spencer c99ed8fed9
Add unpublish_package script. (#33267)
This adds a maintenance script that will allow us to "unpublish" a release: basically remove it from the cloud storage so that we're no longer serving it from the website.

Obviously, gsutil access to the cloud storage server is required for this to function.
2019-05-24 08:56:52 -07:00
Zachary Anderson f5827f0f07
[flutter_tool] Improve Fuchsia 'run' tests (#33263) 2019-05-24 07:48:41 -07:00
Jonah Williams 7ec9a6fa72
no longer necessary with ddc fix (#33271) 2019-05-23 23:49:41 -07:00
Emmanuel Garcia 12a0e475e2
Make paths absolute in settings.gradle (#33228) 2019-05-23 23:32:11 -07:00
Jonah Williams 1bd85dd6c2
disable flaky devfs test (#33285) 2019-05-23 17:05:29 -07:00
liyuqian 552e74770d
Mark non-flaky test as such (#33269) 2019-05-23 12:39:55 -07:00
Todd Volkert c6129b4e85
Add cast to prepare for package:file update (#33268) 2019-05-23 12:33:24 -07:00
Todd Volkert bc7bc94083
Slight clarification in the ImageCache docs (#33195)
It was easy to miss the reference to the top-level `imageCache`
property before.  This calls out the property a little more
explicitly.
2019-05-23 10:29:07 -07:00
Paul Berry 9a16900ed1
Pass an async callback to testWidgets. (#33260)
The dart analyzer fails to warn about missing returns in function expressions due to a bug that has been
fixed but not yet rolled into Flutter (see
https://dart-review.googlesource.com/c/sdk/+/100301).  So it failed to catch that https://github.com/flutter/flutter/pull/33217 accidentally introduced a call to `testWidgets` that passed it a synchronous callback.
2019-05-23 10:17:22 -07:00
Fedor Korotkov 4bc8e9c00e [ci] use Windows Container 2019 (#33248)
They are newer and faster to start
2019-05-23 09:35:58 -07:00
Justin McCandless 6031c56d4c
Material Long Press Text Handle Flash (#32911)
Fix a bug where holding down on text selection caused the handles to flash. The fix was to only update selection when it actually changed.
2019-05-23 08:15:59 -07:00
Devon Carew 0e8720e926
use the --disable-server-feature-completion cli arg to the analysis server (#33232) 2019-05-23 07:48:23 -07:00
Todd Volkert be2918ff30
Fix ImageStreamListener's hashCode & operator== (#33217)
I forgot to add `onChunk` to them in #33092
2019-05-22 18:14:01 -07:00
stuartmorgan ef9866bf27
Build macOS via workspace, rather than project (#33198)
This is necesasry to integrate CocoaPods, since CocoaPods operates
primarily on the workspace rather than the project.
2019-05-22 19:58:29 -04:00
engine-flutter-autoroll 2f6a986675
Roll engine 64f18f2cb686..8dc3a4cde207 (5 commits) (#33219)
64f18f2cb6...8dc3a4cde2

git log 64f18f2cb686649e7ba330e8254053f13d1526cd..8dc3a4cde2075a4f5458fd0eb199627f5124508d --no-merges --oneline
8dc3a4cde Add missing top level to stub_ui (flutter/engine#9060)
6299af30a remove over-optimistic assert (flutter/engine#9045)
0308a1c4a Roll src/third_party/dart fde6a5917e..e3edfd36b2 (14 commits)
1bce77992 Roll src/third_party/skia e63b01b364a0..f77dbd04b926 (19 commits) (flutter/engine#9057)
4dbb9ba38 Expose pointer type and buttons in embedder.h (flutter/engine#9034)

The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff (garyq@google.com), and stop
the roller if necessary.
2019-05-22 19:58:17 -04:00
Jonah Williams 018df5ecdd
manual engine roll (#33224) 2019-05-22 16:12:02 -07:00
Jonah Williams a30ffb60ad
Revert "Clean up some flutter_tools tests and roll dependencies (#33163)" (#33206) 2019-05-22 12:20:02 -07:00
Jason Simmons a6f1c095dc
Engine roll 75963dbb0ba6..64f18f2cb686 (#33157) 2019-05-22 10:19:08 -07:00