Jonah Williams
8c0cf1ddf7
Revert "Lazily download artifacts (III) ( #27903 )" ( #29064 )
...
This reverts commit 3fd36200d9
2019-03-08 13:31:51 -08:00
Jonah Williams
3fd36200d9
Lazily download artifacts (III) ( #27903 )
2019-03-08 13:15:50 -08:00
Jonah Williams
d4a441a0d9
Add integration to all targets ( #29020 )
2019-03-08 12:25:35 -08:00
Justin McCandless
9e9f48dabb
Fix TextField height issues ( #27205 )
...
* Create new TextField attribute to control maxLength behaviour
* Create test case for maxLinesIncrementalHeight
* fix maxLinesIncrementalHeight set method
* fix editable_test.dart
* Just introducing some proposed API additions, renaming to expands
* Pass minLines and expands through to child widgets and validate
* minLines can't be null, and expands can't be true when maxLines is 1
* Implement minLines and maxLines height sizing logic
* Simplify minLines validation logic
* expands parameter proof of concept
* min/max mixup bug fix, and tests work with expands false
* Test expands=true cases, and fix textPainter.height being out of date
* Test all behavior matrix cases
* min/max assertion more strict, can't be equal
* Tests work that were missing expands serialization
* Action sheet tests no longer fail due to rounding error
* TextFieldFocus test no longer mysteriously fails
* TODOs for making expands nullable. Will depend on how Expanded wrapping works
* Expanded growth happens when expanded is true and maxLines is null
* Test Expanded wrapper
* No more overflow when wrapped in Expanded
* Docs improvements
* expands can be null
* Simplify error cases to support existing behavior
* Docs examples and other docs cleanup
* Expansion up to perfectly meet the parent size
* Fix analyze null error
* Fix test after move to nullable expands
* minLines defaults to null
* expands is now exclusively for expanding to parent height and not growth between min and max
* _layout rewritten to handle max height. Need to fix prefix tests and
reenable expands
* Tests for textfield overflowing parent
* layoutLineBox is documented and private
* expands works in new _layout
* _layout return numbers seem to perfectly match original _layout
* inputWidth comment after trying it out and failing tests
* Fix analyze errors
* WIP prefix/suffix do affect height
* Prefix/suffix and icons affect height, tests pass, but I'm still visually verifying identical to original
* Tall prefix test that verifies pixel perfect layout
* Fix overflowing edge case and test it
* Clean up comments, old code, and todos
* Changing _expands causes relayout. Wasnt able to figure out how to test though...
* Clean up code review comments
* Fix misalignment when tall prefix and border, and clean up related test
* Simple code review cleanup
* Bring back inputWidth to _layout method
* Fix rounding errors showing up in mac tests
* Fix flake by reordering tests. Without this, the dreaded intrinsicwidth flake is reproducible 50% of the time on my machine.
* Fix more rounding error mac tests
2019-03-08 12:22:43 -08:00
Greg Spencer
80082ac4d3
Remove references to obsolete SemanticsSortOrder ( #29012 )
...
This removes references to SemanticsSortOrder, which was removed a long time ago.
2019-03-08 09:39:45 -08:00
Greg Spencer
89512e46f6
Add/rewrite tests for FocusScope. ( #28169 )
...
In anticipation of changing a lot of the focus code, I'm adding some tests for the FocusScope.
As a result, I was able to find and fix a bug where there was an incorrect assert.
I also added some more documentation.
Several of the tests enforce what I think is incorrect behavior related to passing focus off when the widget tree gets rebuilt without focus nodes that were previously there, but I'm not going to change that behavior in this PR.
I also renamed focus_test.dart to focus_scope_test.dart to be more in line with our naming conventions.
2019-03-08 09:39:20 -08:00
Dan Field
4be4830c2f
update readme for LUCI ( #29023 )
...
* update readme for LUCI
* Update README.md
2019-03-08 09:25:13 -08:00
engine-flutter-autoroll
da7649586a
Roll engine a48cd16e0777..60314077846c (2 commits) ( #29049 )
...
a48cd16e07...6031407784flutter/engine#8082 )
95ef58cf4 Add script to help generate PR messages (flutter/engine#8074 )
The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff (mklim@google.com ), and stop
the roller if necessary.
2019-03-08 12:07:29 -05:00
Dan Field
0360d0f274
print system time on all mac builds ( #29025 )
2019-03-08 07:08:32 -08:00
Jonah Williams
77142b8257
Revert "re-enable dart2js test ( #29010 )" ( #29030 )
...
This reverts commit 6a7f231d89
2019-03-07 22:18:15 -08:00
Jonah Williams
6a7f231d89
re-enable dart2js test ( #29010 )
2019-03-07 21:56:02 -08:00
Gary Qian
8f1a430557
Initialize the lifecycle state with initial state in window. Roll engine (19 commits) ( #28688 )
...
git log --oneline --no-merges f4951df193a7966f9ed4da43d555eee0913d84d1..a48cd16e077778a7aa5908e4faa4da07714260f2
a48cd16e0 Update a11y word forward/back enum names (https://github.com/flutter/engine/pull/8073 )
b5f59ed89 Delay the vsync callback till the frame start time specified by embedder. (https://github.com/flutter/engine/pull/8072 )
7426305f5 Mark const extern (https://github.com/flutter/engine/pull/8077 )
d3f6d7a21 only partial rule revert (https://github.com/flutter/engine/pull/8078 )
d71bfe58d Only build a full Dart SDK when building for the host system (https://github.com/flutter/engine/pull/8071 )
de90dbff7 Refactor web configuration/ Add dartdevc (https://github.com/flutter/engine/pull/7978 )
ff46dd38f Roll src/third_party/skia 4c1ea43a79b5..88b8d1124b72 (8 commits) (https://github.com/flutter/engine/pull/8070 )
80c6dd286 Roll src/third_party/skia 692122e3ef23..4c1ea43a79b5 (3 commits) (https://github.com/flutter/engine/pull/8069 )
68ed654ea Roll src/third_party/skia 3c957d575c58..692122e3ef23 (6 commits) (https://github.com/flutter/engine/pull/8067 )
ca0bac4fb Revert "add signal to pointer kinds" (https://github.com/flutter/engine/pull/8066 )
3fb627f2c add signal to pointer kinds (https://github.com/flutter/engine/pull/8065 )
5a06afa2a Roll src/third_party/skia 801a9c16d81e..3c957d575c58 (19 commits) (https://github.com/flutter/engine/pull/8063 )
a93d99db9 A11y callback (https://github.com/flutter/engine/pull/8005 )
3661d5e43 Re-land "Buffer lifecycle in WindowData" (https://github.com/flutter/engine/pull/8032 )
471a2c89a Send scroll events from the macOS shell (https://github.com/flutter/engine/pull/8056 )
2fe9c9b5f Roll src/third_party/skia 72542816cadb..801a9c16d81e (46 commits) (https://github.com/flutter/engine/pull/8060 )
3335764ae Skip skp files in license check (https://github.com/flutter/engine/pull/8050 )
7f16789b2 Remove redundant thread checker in FML. (https://github.com/flutter/engine/pull/8053 )
840c5233a Correct URL for Cirrus CI build status badge (https://github.com/flutter/engine/pull/8054 )
57c120a29 remove extra source files (https://github.com/flutter/engine/pull/8052 )
4773375c6 Used named conditionals for platform specific dependencies and suppress Android and Windows hooks on Mac. (https://github.com/flutter/engine/pull/8051 )
70a18b515 Add clang static analysis support to gn wrapper (https://github.com/flutter/engine/pull/8047 )
b30f9897b Improve elevation bounds for physical shape layers (https://github.com/flutter/engine/pull/8044 )
e37bd27b4 Fix weak pointer use violations in shell and platform view. (https://github.com/flutter/engine/pull/8046 )
dd80fc9ff Add engine support for scrollwheel events (https://github.com/flutter/engine/pull/7494 )
2019-03-07 20:05:42 -08:00
Dan Field
a3b484d0da
make coverage work again ( #29016 )
2019-03-07 18:59:43 -08:00
Jonah Williams
f5c3579f30
Remove extra build_runner modes, remove flutter_build ( #28873 )
2019-03-07 14:52:29 -08:00
Kate Lovett
64d31016ed
Form Snippet for API Docs ( #28857 )
...
* Added code snippet for Form Class. ref:#21136
* Formatting adjustments.
* Changed wording related to GlobalKey.
2019-03-07 13:35:42 -08:00
xster
acf51d8e36
Add more doc pointing to the EditableText's rudimentary nature around gesture handling ( #28955 )
2019-03-07 13:25:32 -08:00
liyuqian
da8b340c4a
Quick fix for shader warm up ( #28951 )
...
Fix issues in https://github.com/flutter/flutter/pull/28687
2019-03-07 12:45:39 -08:00
Alexandre Ardhuin
440ce8fde6
Fix indentations of statements in BlockFunctionBody ( #28933 )
...
* fix indentof statements in BlockFunctionBody
* fix indentof statements in BlockFunctionBody in tests
2019-03-07 21:09:28 +01:00
Dan Field
f67a529e6d
Fix coverage shard and print summary after test run ( #28970 )
...
* Fix coverage shard
* clarify
* Make sure we print test results
* Actually report test results before exiting
* revert unintended changes
2019-03-07 11:31:35 -08:00
Jonah Williams
a2d349c4c1
select ResidentCompiler during FlutterDevice initialization ( #28603 )
2019-03-07 11:02:42 -08:00
Dan Field
df465c7718
Fall-back to platform tools in Android SDK detection logic. ( #28863 )
2019-03-07 10:45:29 -08:00
Jonah Williams
cd1b89c696
Revert "Roll engine f4951df193a7..471a2c89a689 (11 commits) ( #28966 )" ( #28975 )
...
This reverts commit 1b14339e6a
2019-03-06 17:42:51 -08:00
Tong Mu
2e1a8c746f
Add minimum time gap requirement to double tap ( #28749 )
...
* First impl with StopwatchWithZone
* Clean up params and name
* Remove outdated TODO
* Fix style
* Fix a missing param. Add @require
* Fix import meta
* Fix code style
* Add missing require. Fix comment style.
* Fix code style
* Fix code style
2019-03-06 15:58:37 -08:00
engine-flutter-autoroll
1b14339e6a
Roll engine f4951df193a7..471a2c89a689 (11 commits) ( #28966 )
...
f4951df193...471a2c89a6flutter/engine#8056 )
2fe9c9b5f Roll src/third_party/skia 72542816cadb..801a9c16d81e (46 commits) (flutter/engine#8060 )
3335764ae Skip skp files in license check (flutter/engine#8050 )
7f16789b2 Remove redundant thread checker in FML. (flutter/engine#8053 )
840c5233a Correct URL for Cirrus CI build status badge (flutter/engine#8054 )
57c120a29 remove extra source files (flutter/engine#8052 )
4773375c6 Used named conditionals for platform specific dependencies and suppress Android and Windows hooks on Mac. (flutter/engine#8051 )
70a18b515 Add clang static analysis support to gn wrapper (flutter/engine#8047 )
b30f9897b Improve elevation bounds for physical shape layers (flutter/engine#8044 )
e37bd27b4 Fix weak pointer use violations in shell and platform view. (flutter/engine#8046 )
dd80fc9ff Add engine support for scrollwheel events (flutter/engine#7494 )
The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff (mklim@google.com ), and stop
the roller if necessary.
2019-03-06 18:49:28 -05:00
xster
0b6b39b39e
Move material iOS back swipe test to material ( #28855 )
2019-03-06 15:48:59 -08:00
Muhammed Salih Guler
11678da3b0
Add semantics label to FadeInImage. ( #28799 )
2019-03-06 15:38:35 -08:00
TruongSinh Tran-Nguyen
0c7fe40e37
fix #19175 How should addTime be used from a test? ( #25202 )
2019-03-06 15:32:33 -08:00
Ivan
ec27e04582
fix missing variable name ( #28944 )
2019-03-06 15:22:02 -08:00
Jonah Williams
dd94499418
Add build script invalidation and snapshotting logic ( #28866 )
2019-03-06 15:16:16 -08:00
Dan Field
e5b1ed7a7f
Fix for post submit on cirrus ( #28963 )
...
* Fix for post submit on cirrus
2019-03-06 14:23:37 -08:00
Dan Field
20e0f13cc9
Test reporter ( #28297 )
...
* Wrap test.main with a custom processor
* Report test results to bigquery table
2019-03-06 13:13:45 -08:00
Jason Simmons
427fcebcc5
Remove the flutter_shared assets directory from the Gradle script ( #27572 )
...
flutter_shared was used to package the icudtl.dat file, but that data is
now embedded inside libflutter.so
2019-03-06 11:23:27 -08:00
Phil Quitslund
802eca29d2
set literal conversions ( #27811 )
2019-03-06 11:05:16 -08:00
Dan Field
608b03c79b
Update docs for ancestorWidgetOfExactType ( #28675 )
...
* doc update
2019-03-06 10:51:15 -08:00
Reece Dunham
d4474128c5
Update macOS version in tests ( #28852 )
...
This switches the Cirrus macOS images to use Mojave, since Cirrus has deprecated the High Sierra images.
2019-03-06 09:35:27 -08:00
Chris Bracken
52e4214dbb
Fix crash on flutter update-packages ( #28922 )
...
When running git update-packages, if the goldens repo is dirty, the
flutter tool currently crashes and logs the failure from git pull.
This adds a check for a dirty git client and emits a friendlier error
message in the case where it's not clean, and avoid the crash by
catching the NonZeroExitCode exception and rethrowing as toolExit
instead.
Fixes: https://github.com/flutter/flutter/issues/28915
2019-03-06 09:14:39 -08:00
Alexandre Ardhuin
4c1f4d14e1
fix some formatting issues ( #28809 )
...
* fix some formatting issues
* address review comments
* fix indent
2019-03-06 09:37:32 +01:00
Chris Bracken
01a29b85ef
Roll engine 4f54a1d...2e97618 ( #28899 )
...
flutter/engine@f4951df19 (upstream/master) Minor cleanups to CONTRIBUTING.md (flutter/engine#8043 )
flutter/engine@effee2f80 remove extra statement (flutter/engine#8041 )
flutter/engine@14e082fa0 (master) add lint script for Android with baseline (flutter/engine#8036 )
flutter/engine@5fed42197 Roll src/third_party/skia 25bc174cf682..72542816cadb (14 commits) (flutter/engine#8040 )
flutter/engine@e6a5201f0 Add missing values to semantics action enums (flutter/engine#8033 )
flutter/engine@75d4db31d Roll src/third_party/skia fbc887df72ec..25bc174cf682 (7 commits) (flutter/engine#8039 )
flutter/engine@c46226980 Roll src/third_party/skia 0a57971f0544..fbc887df72ec (1 commits) (flutter/engine#8037 )
flutter/engine@ed628da00 Add missing kHasImplicitScrolling enum value (flutter/engine#8030 )
flutter/engine@052774e1c Roll src/third_party/skia e3e80b7edfd1..0a57971f0544 (16 commits) (flutter/engine#8035 )
flutter/engine@2cd9b41ba Select MPL instead of LGPL (flutter/engine#7991 )
flutter/engine@629c0d836 Roll src/third_party/dart 7d8ffe0daf..571ea80e11 (3 commits)
flutter/engine@8f1fdcd19 Android Embedding PR 14: Almost done with FlutterFragment. (flutter/engine#8000 )
flutter/engine@fb3e35d6a Android Embedding PR15: Add Viewport Metrics to FlutterView (flutter/engine#8029 )
flutter/engine@36ca5740c (flutter/engine#8026 )
flutter/engine@3d53e2026 Roll src/third_party/skia 5800f2e8a920..e3e80b7edfd1 (2 commits) (flutter/engine#8028 )
flutter/engine@f3d4a7f71 Roll src/third_party/dart 7c70ab1817..7d8ffe0daf (77 commits)
flutter/engine@a2246c199 Start of linting Android embedding (flutter/engine#8023 )
flutter/engine@48bf4803e [fuchsia] Fix snapshot BUILD.gn file for Fuchsia roll (flutter/engine#8024 )
2019-03-05 18:18:44 -08:00
Amir Hardon
5099701f88
Make RenderUiKitView reject absorbed touch events ( #28666 )
...
When a touch event that is in the bounds of a RenderUiKitView is absorbed by another render object,
the RenderUiKitView's handleEvent is not called for that object. On the platform side, the touch event hits the FlutterTouchInterceptingView which is waiting for a framework decision that never arrived on whether to reject or accept the gesture.
This change fixes the issue by having RenderUiKitView register a global PointerRoute, that is used to reject absorbed touch events.
2019-03-04 14:26:50 -08:00
Kate Lovett
013fd2112b
FAB Snippet for API Docs ( #28752 )
...
* Added code snippets for FloatingActionButton Class. ref:#21136
* Extraneous white spaces.
Co-Authored-By: Piinks <katelovett@google.com>
* Alignment correction.
* The analyze result wasn't showing on github interface. Checked through Cirrus and it's all-green.
Co-Authored-By: Piinks <katelovett@google.com>
2019-03-04 13:09:25 -08:00
Hans Muller
e8b87203c5
Handle Cupertino back gesture interrupted by Navigator push ( #28756 )
2019-03-04 11:42:00 -08:00
Jason Simmons
a1aea2e442
Use a simpler implementation of Diagnosticable.toString when running in profile/release mode ( #28661 )
...
Diagnosticable.toString may be called in performance sensitive contexts
(for example, creating debug labels for Tickers)
2019-03-04 11:05:20 -08:00
Jason Simmons
c3527389b6
Avoid the overhead of instantiating a generator in paintImage ( #28736 )
...
This function is called frequently with non-repeating images during many
animations
2019-03-04 11:04:51 -08:00
Joshua Seaton
1ffd5f02d6
[fuchsia] Permit relative entries to the fuchsia_tester ( #28821 )
...
This change permits
(1) a relative --flutter-shell
(2) relative (source, dill) entries within the test JSON file
and enables portability in the invocation scripts produced by fuchsia's
dart test GN template.
2019-03-04 13:52:58 -05:00
engine-flutter-autoroll
cb704dfd96
Roll engine e9eae9a1af77..4f54a1dd9444 (3 commits) ( #28843 )
...
e9eae9a1af...4f54a1dd94flutter/engine#8022 )
75e2b4702 Roll src/third_party/skia c6671be0ea75..c1a9feb6f06e (2 commits) (flutter/engine#8021 )
b44a9305c Roll src/third_party/skia 1b9f889628e0..c6671be0ea75 (1 commits) (flutter/engine#8020 )
The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff (garyq@google.com ), and stop
the roller if necessary.
2019-03-04 13:31:30 -05:00
engine-flutter-autoroll
7fc14a55af
e9eae9a1a Roll src/third_party/skia c97b0672a73f..1b9f889628e0 (1 commits) (flutter/engine#8019) ( #28801 )
...
a28329cb91...e9eae9a1afflutter/engine#8019 )
The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff (garyq@google.com ), and stop
the roller if necessary.
2019-03-04 11:43:28 -05:00
engine-flutter-autoroll
2bab21b2bd
Roll engine 39c46dea4b73..a28329cb91ac (10 commits) ( #28797 )
...
39c46dea4b...a28329cb91flutter/engine#8018 )
cdc141072 Roll src/third_party/skia 0d7012a80c17..58a75383a70b (1 commits) (flutter/engine#8017 )
01d8a1f27 Roll src/third_party/skia c945f0e31a53..0d7012a80c17 (1 commits) (flutter/engine#8016 )
75cd4df37 Roll src/third_party/skia 9159c8ef83b2..c945f0e31a53 (1 commits) (flutter/engine#8015 )
13064aec8 Add overloads for lookup that lets you specify a bundle (flutter/engine#8007 )
130cf77c5 Build engine for iOS on presubmit (flutter/engine#8011 )
7234cc463 Roll src/third_party/skia 705e67347962..9159c8ef83b2 (1 commits) (flutter/engine#8014 )
8a0b054a4 Roll src/third_party/skia 09198525261a..705e67347962 (7 commits) (flutter/engine#8013 )
36cdd2ee6 Roll src/third_party/skia 436d47d5bde9..09198525261a (6 commits) (flutter/engine#8012 )
9bef73a1a Roll src/third_party/skia e1f5b644656f..436d47d5bde9 (3 commits) (flutter/engine#8009 )
The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff (garyq@google.com ), and stop
the roller if necessary.
2019-03-03 05:15:28 -05:00
Danny Tuppeny
740fb2a8bb
Fix the test annotation used for test groups ( #28638 )
2019-03-02 13:19:49 +00:00
Jonah Williams
d91cfffa50
switch tool tests to build runner ( #28759 )
2019-03-01 19:18:38 -08:00
engine-flutter-autoroll
778e95a39b
Roll engine 66042161eba1..39c46dea4b73 (4 commits) ( #28755 )
...
66042161eb...39c46dea4b#7999 )" (flutter/engine#8010 )
293cfcaa5 Guard against using Android API not defined in API level 16 & 17 (flutter/engine#8006 )
d7e0bc10c Roll src/third_party/skia 71a23d4195d9..e1f5b644656f (8 commits) (flutter/engine#8004 )
0b1740171 Buffer lifecycle in WindowData (flutter/engine#7999 )
The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff (garyq@google.com ), and stop
the roller if necessary.
2019-03-01 20:48:28 -05:00
