Commit graph

16066 commits

Author SHA1 Message Date
Greg Spencer 89d6c8d90b
Enables setting of semantics focused and focusable attributes within Focus widgets. (#41814)
This adds a Semantics node to the Focus and FocusScope widgets, setting the focused and focusable attributes so that the accessibility subsystem can be told when a control has the input focus.

Includes an engine roll to flutter/engine@77252d2, and the following 8 engine changes:

flutter/engine@77252d2 Greg Spencer Add missing focusable testing info (flutter/engine#13013)
flutter/engine@0e42a29 skia-flutter-.. Roll src/third_party/skia 54548626a977..e27a503a0a21 (1 commits) (flutter/engine#13024)
flutter/engine@6b56ed7 gaaclarke Refactor: FlutterDartProject (flutter/engine#13006)
flutter/engine@393480c skia-flutter-.. Roll src/third_party/skia 77dde599c98a..54548626a977 (1 commits) (flutter/engine#13023)
flutter/engine@080b89d skia-flutter-.. Roll src/third_party/skia 2b1a25a4d324..77dde599c98a (1 commits) (flutter/engine#13021)
flutter/engine@90b0f30 Ben Konyi Roll src/third_party/dart f4a72bfc64..bb04f145b2 (18 commits) (flutter/engine#13020)
flutter/engine@049fb89 skia-flutter-.. Roll fuchsia/sdk/core/linux-amd64 from q_uYX... to cknsi... (flutter/engine#13019)
flutter/engine@6925b2a skia-flutter-.. Roll fuchsia/sdk/core/mac-amd64 from wuAtw... to u0JpE... (flutter/engine#13018)

Related Issues
Addresses #40101

Landing on red in order to fix the build: it's red because of the needed engine roll.
2019-10-09 14:45:42 -07:00
Emmanuel Garcia 3c521fb980
Add android.permission.WAKE_LOCK permission to abstract_method_smoke_test (#42352) 2019-10-09 13:42:25 -07:00
Darren Austin 440753bae8
Fix regression with ModalBottomSheets not responding to changes in theme (#42189)
Fix regression with ModalBottomSheets not responding to changes in theme
after they are shown.
2019-10-08 21:33:17 -07:00
engine-flutter-autoroll 85cc31319a
0d749933b Roll src/third_party/skia 1494a7f1ec03..2b1a25a4d324 (15 commits) (flutter/engine#13016) (#42290)
git@github.com:flutter/engine.git/compare/1e58794b238b...0d749933bcc6

git log 1e58794b238b..0d749933bcc6 --no-merges --oneline
2019-10-09 skia-flutter-autoroll@skia.org Roll src/third_party/skia 1494a7f1ec03..2b1a25a4d324 (15 commits) (flutter/engine#13016)


If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC chinmaygarde@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
2019-10-09 00:08:43 -04:00
Jonah Williams 6a99a8d9e4
Ensure web restart analytics events aren't sent for failures/dont serve devtools by default (#42260) 2019-10-08 20:06:13 -07:00
engine-flutter-autoroll 0c1d1324a3
Roll engine 21b8224ae12d..1e58794b238b (2 commits) (#42287)
git@github.com:flutter/engine.git/compare/21b8224ae12d...1e58794b238b

git log 21b8224ae12d..1e58794b238b --no-merges --oneline
2019-10-09 chinmaygarde@gmail.com Revert "Upgrade compiler to Clang 10. (#11256)" (flutter/engine#13017)
2019-10-09 chinmaygarde@google.com Upgrade compiler to Clang 10. (flutter/engine#11256)


If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC chinmaygarde@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
2019-10-08 23:02:43 -04:00
engine-flutter-autoroll 8159a99060
Roll engine c635d70c7266..21b8224ae12d (10 commits) (#42285)
git@github.com:flutter/engine.git/compare/c635d70c7266...21b8224ae12d

git log c635d70c7266..21b8224ae12d --no-merges --oneline
2019-10-08 gspencergoog@users.noreply.github.com Send AccessibilityEvent.TYPE_VIEW_FOCUSED when input focus is set. (flutter/engine#12746)
2019-10-08 dnfield@google.com Fix for a11y crash on iOS (flutter/engine#12990)
2019-10-08 katelovett@google.com Link Semantics Typo (flutter/engine#13009)
2019-10-08 ferhat@gmail.com [web] Add support for path transform (flutter/engine#12794)
2019-10-08 jason-simmons@users.noreply.github.com Auto-formatter fixes for BUILD.gn files (flutter/engine#13005)
2019-10-08 bkonyi@google.com Unblock SIGPROF on flutter_tester start (flutter/engine#12813)
2019-10-08 mouad.debbar@gmail.com [web] Update the url when route is replaced (flutter/engine#13003)
2019-10-08 katelovett@google.com Missing link flag (flutter/engine#13001)
2019-10-08 30870216+gaaclarke@users.noreply.github.com Started setting our debug background task id to invalid after completion. (flutter/engine#12999)
2019-10-08 ychris@google.com Add `onUnregistered` callback in 'Texture' and 'FlutterTexture' (flutter/engine#12695)


If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC chinmaygarde@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
2019-10-08 22:18:43 -04:00
Jonah Williams 25b3ea7ed2
Revert removal of linux support from unpack command (#42276) 2019-10-08 19:18:18 -07:00
Kate Lovett 1ec44a0c36
Incorporating Link Semantics (#41327) 2019-10-08 18:16:11 -07:00
Jonah Williams 14c1c211d5
Catch argument error from Make when it isn't installed (#42252) 2019-10-08 14:53:55 -07:00
Jonah Williams fde267516b
Make Pub an interface in the flutter tool (#42257) 2019-10-08 14:53:28 -07:00
engine-flutter-autoroll fc62666161
Roll engine 5b3182294f63..c635d70c7266 (5 commits) (#42263)
git@github.com:flutter/engine.git/compare/5b3182294f63...c635d70c7266

git log 5b3182294f63..c635d70c7266 --no-merges --oneline
2019-10-08 skia-flutter-autoroll@skia.org Roll src/third_party/skia 902cf1e12a74..1494a7f1ec03 (10 commits) (flutter/engine#13000)
2019-10-08 liyuqian@google.com SkSL precompile (flutter/engine#12412)
2019-10-08 chinmaygarde@google.com Compile sanitizer suppressions list and file bugs as necessary. (flutter/engine#12991)
2019-10-08 chinmaygarde@google.com Add a unit-test to verify that root surface transformation affect platform view coordinates. (flutter/engine#12783)
2019-10-08 katelovett@google.com Re-land Adding Link Semantics (flutter/engine#12972)


If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC chinmaygarde@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
2019-10-08 17:50:43 -04:00
engine-flutter-autoroll dcfced221f
Roll engine 3a445edda924..5b3182294f63 (3 commits) (#42258)
git@github.com:flutter/engine.git/compare/3a445edda924...5b3182294f63

git log 3a445edda924..5b3182294f63 --no-merges --oneline
2019-10-08 bkonyi@google.com Roll src/third_party/dart aece1c1e92..f4a72bfc64 (4 commits)
2019-10-08 30870216+gaaclarke@users.noreply.github.com Added an embedder example (flutter/engine#12808)
2019-10-08 sebastian.roth@gmail.com Fix typo on channel buffer debug output. (flutter/engine#12960)


If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC chinmaygarde@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
2019-10-08 16:17:43 -04:00
LongCatIsLooong f818fbe020
Update CupertinoActivityIndicator colors and gradient (#42032) 2019-10-08 12:51:55 -07:00
engine-flutter-autoroll c64b236f9b
Roll engine 49dbaae818cd..3a445edda924 (4 commits) (#42251)
git@github.com:flutter/engine.git/compare/49dbaae818cd...3a445edda924

git log 49dbaae818cd..3a445edda924 --no-merges --oneline
2019-10-08 30870216+gaaclarke@users.noreply.github.com Made _printDebug only happen on debug builds of the engine for now. (flutter/engine#12980)
2019-10-08 devoncarew@google.com remove references to package:_chrome (flutter/engine#12931)
2019-10-08 ditman@gmail.com Open source canvas tests from flutter_web_ui (flutter/engine#12819)
2019-10-08 mouad.debbar@gmail.com Prevent default when Tab is clicked (flutter/engine#12986)


If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC chinmaygarde@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
2019-10-08 15:14:43 -04:00
Kate Lovett 6760628147
Typos & Style clean up (#42006) 2019-10-08 10:39:09 -07:00
engine-flutter-autoroll 0917cb003d
Roll engine 611c345a4e76..49dbaae818cd (3 commits) (#42246)
git@github.com:flutter/engine.git/compare/611c345a4e76...49dbaae818cd

git log 611c345a4e76..49dbaae818cd --no-merges --oneline
2019-10-08 skia-flutter-autoroll@skia.org Roll fuchsia/sdk/core/linux-amd64 from gB_ii... to q_uYX... (flutter/engine#12996)
2019-10-08 aam@google.com Roll dart to aece1c1e92. (flutter/engine#12997)
2019-10-08 skia-flutter-autoroll@skia.org Roll fuchsia/sdk/core/mac-amd64 from wOfz2... to wuAtw... (flutter/engine#12995)


If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC chinmaygarde@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
2019-10-08 13:36:43 -04:00
Romain Rastel 0ddcd70ca1 Add helperMaxLines to InputDecoration and InputDecorationTheme (#39433)
Similar to errorMaxLines
2019-10-08 10:34:20 -07:00
gaaclarke ed1d5a8f1c
Added SystemNavigator.pop "animated" argument. (#41820) 2019-10-08 10:05:30 -07:00
engine-flutter-autoroll 70e753a2a7
611c345a4 Roll src/third_party/skia a28cf7c08061..902cf1e12a74 (4 commits) (flutter/engine#12994) (#42244)
git@github.com:flutter/engine.git/compare/819b0cae0c23...611c345a4e76

git log 819b0cae0c23..611c345a4e76 --no-merges --oneline
2019-10-08 skia-flutter-autoroll@skia.org Roll src/third_party/skia a28cf7c08061..902cf1e12a74 (4 commits) (flutter/engine#12994)


If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC chinmaygarde@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
2019-10-08 12:51:43 -04:00
Alexandre Ardhuin 83e5a8a0e4
some formatting changes (#41640) 2019-10-08 18:32:10 +02:00
engine-flutter-autoroll 85a3da3a5e
Roll engine 4a849e0f8dd5..819b0cae0c23 (6 commits) (#42240)
git@github.com:flutter/engine.git/compare/4a849e0f8dd5...819b0cae0c23

git log 4a849e0f8dd5..819b0cae0c23 --no-merges --oneline
2019-10-08 skia-flutter-autoroll@skia.org Roll src/third_party/skia f611d943fb73..a28cf7c08061 (29 commits) (flutter/engine#12993)
2019-10-08 garyq@google.com Unpublicize kDoNotResizeDimension (flutter/engine#12989)
2019-10-08 skia-flutter-autoroll@skia.org Roll src/third_party/skia 4c82a9fc83a5..f611d943fb73 (1 commits) (flutter/engine#12831)
2019-10-08 skia-flutter-autoroll@skia.org Roll fuchsia/sdk/core/mac-amd64 from kwa2O... to wOfz2... (flutter/engine#12827)
2019-10-08 skia-flutter-autoroll@skia.org Roll fuchsia/sdk/core/linux-amd64 from by2LL... to gB_ii... (flutter/engine#12979)
2019-10-08 jason-simmons@users.noreply.github.com Roll Wuffs to 0.2.0-rc.1 (flutter/engine#12983)


If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC chinmaygarde@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
2019-10-08 12:05:43 -04:00
engine-flutter-autoroll ff7e23ba52
Roll engine 1d62160fdb2f..4a849e0f8dd5 (17 commits) (#42200)
git@github.com:flutter/engine.git/compare/1d62160fdb2f...4a849e0f8dd5

git log 1d62160fdb2f..4a849e0f8dd5 --no-merges --oneline
2019-10-08 dnfield@google.com Color matrix doc (flutter/engine#12982)
2019-10-07 jason-simmons@users.noreply.github.com Use the standard gen_snapshot target unless the platform requires host_targeting_host (flutter/engine#12988)
2019-10-07 bkonyi@google.com Roll src/third_party/dart 8413a0db0d..8ba6f7e2eb (39 commits) (flutter/engine#12981)
2019-10-07 liyuqian@google.com Unblock Fuchsia roll (flutter/engine#12977)
2019-10-06 chinmaygarde@google.com Update buildroot to pull in ubsan updates. (flutter/engine#12821)
2019-10-05 skia-flutter-autoroll@skia.org Roll src/third_party/skia 95edac1c9a4a..4c82a9fc83a5 (13 commits) (flutter/engine#12818)
2019-10-05 chinmaygarde@google.com Enable sanitizer build variants. (flutter/engine#12816)
2019-10-05 katelovett@google.com Revert "Adding Link SemanticsFlag (#12453)" (flutter/engine#12815)
2019-10-04 jason-simmons@users.noreply.github.com Use the x64 host toolchain for x86 target gen_snapshot only on Linux (flutter/engine#12809)
2019-10-04 yjbanov@google.com add option for bulk-updating screenshots; update screenshots (flutter/engine#12797)
2019-10-04 dnfield@google.com unbreak unopt fuchsia (flutter/engine#12805)
2019-10-04 jason-simmons@users.noreply.github.com Build gen_snapshot with a 64-bit host toolchain even if the target platform is 32-bit (flutter/engine#12802)
2019-10-04 dnfield@google.com [flutter_runner] a11y updates, tests! (flutter/engine#12380)
2019-10-04 WATER1350@gmail.com Fix crash in copypixelbuffer (flutter/engine#10326)
2019-10-04 bkonyi@google.com Roll src/third_party/dart d6c6d12ebf..8413a0db0d (2 commits)
2019-10-04 skia-flutter-autoroll@skia.org Roll fuchsia/sdk/core/mac-amd64 from JyZWz... to kwa2O... (flutter/engine#12803)
2019-10-04 katelovett@google.com Adding Link SemanticsFlag (flutter/engine#12453)


If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC liyuqian@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
2019-10-08 11:29:43 -04:00
Ian Hickson cdc2d9901d
More consistent temp directory naming (#42063)
Applying our style guide:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo#have-good-hygiene-when-using-temporary-directories
2019-10-07 16:43:04 -07:00
LongCatIsLooong 9529d678fa
Cupertino { TabScafold, TextSelection, TextField } dark mode & minor fidelity update (#41431) 2019-10-07 16:41:50 -07:00
Mouad Debbar 1946fc4da0
[web] Always send the route name even if it's null (#41996) 2019-10-07 15:23:31 -07:00
Jonah Williams 9638756c2a
Apply mocks to test command to deflake web_fs test (#42118) 2019-10-07 15:20:33 -07:00
Yegor ebfe6020b8
Enable more web tests; use blacklist to filter them out (#41922)
Add more web tests;use blacklist instead of whitelist
2019-10-07 15:05:24 -07:00
Zachary Anderson cf0d4979c7
[flutter_tool] Re-work analytics events to use labels and values (#42016) 2019-10-07 15:04:55 -07:00
Darren Austin 2d642e95e1
Changed the dark theme elevation overlay to use the colorScheme.onSurface (#41857)
The Material Dark Theme spec has been updated (or soon will be) to clarify that the elevation overlay that is applied to surface colors to indicate elevation should be based off of the colorScheme.onSurface color and not white. This commit implements this change.
2019-10-07 11:02:29 -07:00
Dan Field 4566b34033
Do not validate the Android SDK when building an appbundle (#41946) 2019-10-07 10:38:19 -07:00
Dan Field 3af16678ad
Reland "AOT support for Linux Desktop I: switch Linux builds to assemble (#41612)" (#42030)" (#42038)
This reverts commit 142a8630ec.
2019-10-07 10:37:58 -07:00
Emmanuel Garcia fa4d31b311
Fix smoke test (#42022) 2019-10-07 10:05:40 -07:00
engine-flutter-autoroll 43a6626c0c
Roll engine 7d90779bb66f..1d62160fdb2f (7 commits) (#42011)
git@github.com:flutter/engine.git/compare/7d90779bb66f...1d62160fdb2f

git log 7d90779bb66f..1d62160fdb2f --no-merges --oneline
2019-10-04 iska.kaushik@gmail.com Prettify all CMX files (flutter/engine#12800)
2019-10-04 garyq@google.com Restart all modern Samsung keyboard IMM (flutter/engine#12780)
2019-10-04 dnfield@google.com Reland fuchsia build improvements (flutter/engine#12795)
2019-10-04 50856934+nturgut@users.noreply.github.com Fixing selection issues in Firefox (flutter/engine#12793)
2019-10-04 chinmaygarde@google.com Disable EmbedderTest::CanLaunchAndShutdownMultipleTimes. (flutter/engine#12799)
2019-10-04 iska.kaushik@gmail.com [flutter_runner] Update the cmx files to include TZ support (flutter/engine#12798)
2019-10-04 skia-flutter-autoroll@skia.org Roll src/third_party/skia fbdf48ecb204..95edac1c9a4a (1 commits) (flutter/engine#12790)


If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC liyuqian@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
2019-10-07 13:03:43 -04:00
Zachary Anderson 3b66db6bf7
Updates packages (#41936) 2019-10-07 09:46:57 -07:00
Ian Hickson 97e00b2288 Skip sdk_validation_test again (#42091) 2019-10-07 08:11:45 -07:00
Ian Hickson 682e6383ac
Refactor sdk_validation_test (#42064) 2019-10-06 14:39:16 -07:00
Ian Hickson 1196f91f71
Fix local test failures in flutter_tools (#42015)
* Minor clean-up in terminal.dart

* Don't wrap text in tests (otherwise we'll be sensitive to the terminal width).
2019-10-06 14:38:17 -07:00
Dan Field f4b4616f87
Diagnose failure in CI, Mark III (#42037) 2019-10-04 20:01:04 -07:00
Ian Hickson a22f4e9be5
trying to diagnose failure in CI, mark II (#42036)
* remove prints

* Remove the setUpAll() to see if that changes the error message.
2019-10-04 19:43:54 -07:00
Ian Hickson 4e6b77c087
trying to diagnose failure in CI (#42035) 2019-10-04 19:01:37 -07:00
Ian Hickson 142a8630ec
Revert "AOT support for Linux Desktop I: switch Linux builds to assemble (#41612)" (#42030)
This reverts commit 3024053c82.
2019-10-04 17:51:51 -07:00
James D. Lin fcbe8f44ea
Restructure ProjectFileInvalidator.findInvalidated a bit (#42008)
Restructure ProjectFileInvalidator.findInvalidated a bit

I plan to modify `ProjectFileInvalidator.findInvalidated` to allow
it to use `FileStat.stat` instead of `FileStat.statSync`.
Restructure `findInvalidated` a bit so that `FileStat.statSync` is
called in only one place.

Note that this change now always counts the `.packages` file as one
of the files scanned, even if it does not exist.  I think that this
is okay since it more accurately reflects the number of times that we
hit the filesystem with `stat()`, and it is consistent with how other
files are counted.
2019-10-04 17:22:35 -07:00
engine-flutter-autoroll 71497367ef
Roll engine 759d3dba259b..7d90779bb66f (5 commits) (#42004)
git@github.com:flutter/engine.git/compare/759d3dba259b...7d90779bb66f

git log 759d3dba259b..7d90779bb66f --no-merges --oneline
2019-10-04 skia-flutter-autoroll@skia.org Roll fuchsia/sdk/core/linux-amd64 from VkAgX... to by2LL... (flutter/engine#12791)
2019-10-04 bkonyi@google.com Roll src/third_party/dart 28f21d4e99..d6c6d12ebf (3 commits)
2019-10-04 jonahwilliams@google.com Fix bug in package script and add dev_compiler to list of uploaded packages (flutter/engine#12785)
2019-10-04 bkonyi@google.com Roll src/third_party/dart 7a7dcd1ed9..28f21d4e99 (2 commits)
2019-10-04 skia-flutter-autoroll@skia.org Roll fuchsia/sdk/core/mac-amd64 from wYLiQ... to JyZWz... (flutter/engine#12788)


If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC liyuqian@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
2019-10-04 16:13:43 -04:00
James D. Lin 14c5c6e161
Clean up ProjectFileInvalidator.findInvalidated a bit (#41889)
In preparation for some refactoring that I will be doing to
`ProjectFileInvalidator.findInvalidated`, make its code a bit
clearer:
* Indicate which arguments may be null.
* Don't bother calling `FileStat.statSync` on the `.packages` file
  for the initial load.  This makes the checks for the `.packages`
  file consistent with those for other files.
* Use `DateTime.isAfter()` instead of comparing microseconds
  ourselves.

While I was touching this file, I also removed some unnecessary
comparisons to `false`. (`_ManifestAssetBundle.wasBuiltOnce()` is the
only implementation I can find of `AssetBundle.wasBuiltOnce()`, and
it never returns `null`.)
2019-10-04 12:55:17 -07:00
Jonah Williams 3024053c82
AOT support for Linux Desktop I: switch Linux builds to assemble (#41612) 2019-10-04 12:13:36 -07:00
Ryan Macnak cdb3578b14
Plumb --enable-asserts through to frontend_server invocation in debug mode. (#41832)
Bytecode generation will otherwise omit assert code, causing --enable-asserts to have no effect in the VM.
2019-10-04 12:07:23 -07:00
Rody Davis b730a993c1 Fix CupertinoTextField and TextField ToolbarOptions not changing (#40665) 2019-10-04 11:22:57 -07:00
krisgiesing 0e605cc4dd Revert "Fix ReorderableListView's use of child keys (#41334) (#41338)" (#41931)
This reverts commit 2b138fd7d2.
2019-10-04 07:52:15 -07:00
Erick Ghaumez 62ae5883a8 Fix 'popupTheme' variable name in a MaterialBannerTheme method (#41632) 2019-10-04 22:42:09 +08:00