Commit graph

11388 commits

Author SHA1 Message Date
Danny Tuppeny 868d8c1458
In microbenchmarks, ensure flutter quits by sending q to stdin (#19400)
* Tell flutter to quit directly

Fixes #19208.

* Tweak comment
2018-07-23 18:53:19 +01:00
Gary Miguel a7b59b51b8 Remove redundant check for platform.isLinux. (#19441)
We don't actually care if we're on linux, we care only if the lcov
tool is available. We check for that explicitly just below.
Additionally there is code below which indicates that lcov is available
for macOS. Before this change that code would never execute.
2018-07-23 08:38:20 -07:00
Alexandre Ardhuin 27018359d2
re-enable lint unnecessary_const (#19592)
* re-enable lint unnecessary_const

* remove trailling whitespaces

* remove unnecessary const (after merge)
2018-07-23 08:31:48 +02:00
Lukas Piliszczuk 1cb2677234 Change material RefreshIndictor.onRefresh signature from Future<Null> to Future<void> (#18775)
* Change material refresh indicator onRefresh signature from Future<Null> to Future<void>.

* Update authors.

* Explicitly name void argument.
2018-07-21 15:30:53 -07:00
Jonah Williams e154298e0b
Roll engine to 96f5f5b96c7220ffc8c4ce22ed895616a15ad3a0 (#19615) 2018-07-21 00:45:16 -07:00
Greg Spencer 3bff2e4666
Shard the Appveyor tests. (#19631) 2018-07-20 22:30:02 -07:00
amirh debd50158e
Introduce an AndroidView widget and a RenderAndroidView render object. (#19565)
RenderAndroidView is responsible for sizing and displaying an embedded
Android view.
AndroidView is responsible for creating and disposing the Android view
and is using RenderAndroidView to display it.
2018-07-20 15:58:55 -07:00
jslavitz 9a4db21129
Changed duration (#19015)
* Changed duration

* Fixed column width for ios build error messages

* fixed a couple things

* fixed a couple things

* accidental changes

* added spaces

* added spaces

* Added test for default snackbar duration

* Fixed link:

* Final commit

* Final commit2

* Actual final commit
2018-07-20 15:17:44 -07:00
Leaf Petersen 32f94443cc
Remove uses of deprecated constants and change int.parse to int.tryParse (#19575)
* Remove uses of deprecated constants
* Change int.parse to int.tryParse where appropriate
2018-07-20 15:07:24 -07:00
Ian Hickson 35346b4966
Increase verbosity on bots during setup and other minor cleanup (#19526)
The verbosity change is to help track down timeouts that currently look like:

```
C:\Windows\Temp\flutter sdk>call bin\flutter.bat config --no-analytics
Checking Dart SDK version...
Downloading Dart SDK from Flutter engine c5a63d28bf3735569c8187753bc490d8351a8363...
Unzipping Dart SDK...
Updating flutter tool...
```
2018-07-20 11:01:45 -07:00
Michael Goderbauer 8a00318e89
Whitespace fixes to make Travis happy (#19611)
Follow-up to https://github.com/flutter/flutter/pull/18562, which passed Travis before the check was added.
2018-07-20 10:51:41 -07:00
Greg Spencer 90a5f4613f
Separate tools tests from other tests and put them in a different shard. (#19593) 2018-07-20 10:21:34 -07:00
Norbert Kozsir a14b4f621e Making the space between keyboard and text-field when the keyboard pops up a variable. (#18562) 2018-07-20 09:46:24 -07:00
Sarah Zakarias f0639bb022
add more uses of FlutterProject to locate files (#19403) 2018-07-20 09:21:41 +02:00
Greg Spencer 9f39039f7b
Add presubmit test for trailing whitespace. (#19412)
Checks only changed source files (C++, Dart, Java, ObjC) for trailing whitespace.
2018-07-19 23:05:37 -07:00
Greg Spencer 1cc036519c
Removes trailing whitespace from source files. (#19329) 2018-07-19 23:03:58 -07:00
Sigurd Meldgaard 2d3a5c744d
Revert "Revert "Use FlutterProject to locate files (#18913)" (#19409)" (#19456)
With a fix of a path being printed relative instead of absolute.
2018-07-20 08:00:30 +02:00
Jonah Williams d2d17abeec
Add support for custom semantics actions to Android and iOS. (#18882) 2018-07-19 20:47:21 -07:00
Alex Allen 924c206cf8 Add optional haptic feedback on LongPressDraggable (#18781) 2018-07-19 20:21:40 -07:00
Jonah Williams a66ea0a628
add textCapitalization property (#19367) 2018-07-19 18:06:44 -07:00
Jonah Williams eb69f59461
Allow material button to grow as wide as its constraints allow (#19416) 2018-07-19 14:20:46 -07:00
Hans Muller 73960e7569
Added 20 new supported locales to Material (#19567) 2018-07-19 14:19:21 -07:00
Ryan Macnak 0c79970df3 Roll engine to 482469bad8094ff05fd66dfc07149fbef4ae00ac.
482469bad Roll Dart to 937ee2e8ca4b76499e24cd463f07bfb736bccd74. (#5800)
bb323c145 Revert "Roll src/third_party/skia 9e0d7e4072e4..297c3c8e85bd (62 commits) (#5802)" (#5803)
0bf69f02d Roll src/third_party/skia 9e0d7e4072e4..297c3c8e85bd (62 commits) (#5802)
2018-07-19 13:30:15 -07:00
Ryan Macnak 0442ab8b8b Roll engine to 5d0e13a45b210b9b05427cccfc5f94928ae701ab.
5d0e13a45 Fix starting isolate directly from CoreJIT snapshot. (#5798)
2018-07-19 13:30:15 -07:00
Ryan Macnak c4328e0053 Roll engine to 09ff9493e08c0c937bcd2c6f780981e2a7c5f2b5.
09ff9493e Re-land removal of vmservice_io from release builds. (#5784)
b523ee847 Revert "Switch to Fuchsia's ICU (#5774)" (#5801)
69695493b Switch to Fuchsia's ICU (#5774)
2018-07-19 13:30:15 -07:00
Ryan Macnak 2a058d3a58 Roll engine to 55b423f07ff747c2303c957fe151487b45585192.
55b423f07 Ensure assistiveTechnologyEnabled is initialized when the android view is set up (#5793)
3054f3183 Add touch events to the platform views method channel API. (#5796)
91c16af0c Revert "Roll Dart to 937ee2e8ca4b76499e24cd463f07bfb736bccd74. (#5745)" (#5799)
1a66f895b Roll Dart to 937ee2e8ca4b76499e24cd463f07bfb736bccd74. (#5745)
8d046a727 Revert "Roll src/third_party/skia 9e0d7e4072e4..8f8bf8880d9d (32 commits) (#5794)" (#5797)
e8d172cf3 Revert "Fix Dart 2 reload when running from a snapshot instead of platform.dill. (#5792)" (#5795)
624cf7e25 Fix Dart 2 reload when running from a snapshot instead of platform.dill. (#5792)
16da4710d Roll src/third_party/skia 9e0d7e4072e4..8f8bf8880d9d (32 commits) (#5794)
3fe63fd5d Add presubmit check for engine to flutter roll (#5790)
2018-07-19 13:30:15 -07:00
matthew-carroll 3ca6445c99
Added textInputAction parameter to TextFormField that forwards to TextField, added onEditingComplete parameter to TextField that forwards to EditableText, added onEditingComplete parameter to TextFormField that forwards to TextField. (#19397) (#19427) 2018-07-19 13:22:45 -07:00
TL Lee 865d809d61
Revert accidental force push: 99457c92d7 (#19573) 2018-07-19 16:04:02 -04:00
Jason Simmons e80c699cc9
Keep the debug repaint rainbow color within a valid range (#19355)
Fixes https://github.com/flutter/flutter/issues/18971
2018-07-19 12:58:52 -07:00
Tian Lun Lee 99457c92d7 Add build test for Flutter codelabs 2018-07-19 15:26:49 -04:00
Danny Tuppeny d9ee971e38
Fix copy/paste error in test (#19564) 2018-07-19 19:52:15 +01:00
amirh c1de12dd44
Skip flaky test (expression_evaluation_test) (#19543) 2018-07-19 10:20:28 -07:00
Chris Bracken bb338ef2c6
Don't bundle Genereted.xcconfig as a resource (#19544)
Generated.xcconfig is only required at build time for iOS apps. In the
flutter create project template and example apps, Generated.xcconfig was
previously marked as a resource to be bundled into the built app.
2018-07-19 07:24:06 -07:00
Hans Muller a960b870cc
Enable extended FAB hero transition resizing (#19534) 2018-07-19 07:15:13 -07:00
Danny Tuppeny 6016882a56
Update devicelab test with new message prefix (#19560)
While working on attach, I changed the message output while waiting for an app to connect but didn't catch this.
2018-07-19 14:59:20 +01:00
Danny Tuppeny ed9afbbc72
Add --machine support for flutter attach (#19077)
* Extract some of startApp into a reusable method

* Get basic attach --machine working

* Attach --machine tweaks

Move validation to validate method and create daemon early so we get the startup event before trying to get a connection.

* Bump daemon version so we know whether it's valid to flutter attach

* Tweak output text

* Swap package imports for relative

* Review tweaks (naming, formatting, typedefs)

* Separate arguments from process spawning

This will make calling attach easier

* Add a basic test for flutter attach --machine

* Fix crash if port unforward modifies the list of forwarded ports

* Add a no-op port forwarder for flutter-tester

* Switch to using BasicProject instead of our own inline code

* Fix expectation in test now we have a portForwarder

* Remove stale TODO (this is done)

* Tweak formatting

* Change some Completers to void to fix Dart 2 issues
2018-07-19 13:38:29 +01:00
Danny Tuppeny 442fc3cf06
Make cleanup of flutter processes in tests more reliable (#19307)
* Make cleanup of flutter processes in tests more reliable

* Fix quit signals

I confused SigInt&SigTerm for SigTerm&SigKill when I first did this. SigTerm can be blocked and doesn't guarantee the process will be terminated.

* Don't use deprecated constants

* Fix typo

* Add some additional info to debug buffer

* Fix return types on Futures
2018-07-19 11:37:40 +01:00
Danny Tuppeny d3f6128c21
Flutter emulator launch crash running in dart-2-mode (#19454)
* Only printError on our simple messages

Any other type is a real error that should be a normal crash (to get a proper error log).

See #19453.

* Add toList() to convert Iterable<String> -> List<String>

This code previously throw in Dart-2 mode.

Fixes #19453.

* Move getSimulatorPath into Xcode

* Add a test that we tried to launch the simulator

* Remove unused import
2018-07-19 10:32:44 +01:00
Sigurd Meldgaard 403a08b906
Fix typo (#19555) 2018-07-19 10:46:40 +02:00
Viet Do 953db753ab
Adding multicolumn cupertino picker to the Gallery. (#19284)
* Add sample of multicolumn picker to Flutter Gallery
* Modify CupertinoPicker to be able to be rendered off-center.
2018-07-18 16:29:26 -07:00
Hans Muller ba1a18f45c
Small update to the Text.rich API doc (#18721) 2018-07-18 16:10:58 -07:00
Chris Bracken c0294e3a02
Eliminate Dart 1 benchmarks (#19430)
Flutter app development has been Dart 2 only for a significant amount of
time, and we're about to remove all support for Dart 1.
2018-07-18 15:56:51 -07:00
xster d07d6ac36e
Fix sliver padding safe area for material gallery (#19497) 2018-07-18 15:46:51 -07:00
amirh 48f441723d
Introduce PlatformViewsService for controlling platform views. (#19325)
Currently only Android views are supported.

This also includes a FakePlatformViewsController which is a fake
implementation of the engine side for testing.
2018-07-18 15:45:54 -07:00
Matt Sullivan cf83b790f5
Chevrons fade out completely on month picker scroll event (#19422) 2018-07-18 15:44:35 -07:00
Greg Spencer 2af2a08288
Turn on MacOS tests on Cirrus (#19424)
Cirrus CI has macOS VMs, so this turns on an instance for tests so that we can evaluate if we can use Cirrus for all three platforms or not.
2018-07-18 15:33:38 -07:00
Zachary Anderson dae3959d47
[fuchsia] Add new package dep to BUILD.gn file (#19533) 2018-07-18 14:41:03 -07:00
Ian Hickson 089f59d2c5
Clean up golden files (#19440)
Makes them all be generated on Linux and fixes some to not be so large.
2018-07-18 12:01:56 -07:00
Michael Goderbauer 7a9dd709c6 mark flaky benchmarks as flaky (#19492) 2018-07-18 11:11:39 -07:00
Ryan Macnak 3840719987
Make initialSemanticsTreeCreation less sensitive to GC timing. (#19491)
Bug: https://github.com/flutter/flutter/issues/19435
2018-07-18 10:00:16 -07:00