engine-flutter-autoroll
85e52d4363
Roll Flutter Engine from e726798410af to e0fb071ead2f (2 revisions) ( #135276 )
...
e726798410...e0fb071eadskia-flutter-autoroll@skia.org Roll Dart SDK from eaeca487c944 to 5d33f4c85b82 (1 revision) (flutter/engine#46176 )
2023-09-22 skia-flutter-autoroll@skia.org Roll Skia from 5b2dae1a9b54 to 86454ab4f3de (1 revision) (flutter/engine#46175 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-09-22 03:34:27 +00:00
engine-flutter-autoroll
68d5c1760b
Roll Flutter Engine from 2a33fdc4be48 to e726798410af (1 revision) ( #135271 )
...
2a33fdc4be...e726798410dnfield@google.com [Impeller] fail if software backend is chosen and Impeller is enabled on iOS (flutter/engine#46124 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-09-22 02:14:19 +00:00
engine-flutter-autoroll
5163d81489
Roll Flutter Engine from 7a9409e12fab to 2a33fdc4be48 (3 revisions) ( #135270 )
...
7a9409e12f...2a33fdc4beskia-flutter-autoroll@skia.org Roll Skia from 611f08987be3 to 5b2dae1a9b54 (2 revisions) (flutter/engine#46168 )
2023-09-21 matanlurey@users.noreply.github.com Revert #46131 , don't store `vkImage`, reset `vkComandPool` synchronously (flutter/engine#46166 )
2023-09-21 skia-flutter-autoroll@skia.org Roll Skia from a0928a46b9c8 to 611f08987be3 (2 revisions) (flutter/engine#46165 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-09-22 01:20:25 +00:00
Kostia Sokolovskyi
9d42ad84ee
Fix memory leak in NestedScrollViewState. ( #135248 )
2023-09-21 18:20:23 -07:00
engine-flutter-autoroll
5def6f2bab
Roll Flutter Engine from 78c1ad249b57 to 7a9409e12fab (8 revisions) ( #135266 )
...
78c1ad249b...7a9409e12fskia-flutter-autoroll@skia.org Roll Skia from 0cf83a86c56d to a0928a46b9c8 (19 revisions) (flutter/engine#46164 )
2023-09-21 john@johnmccutchan.com Re-enable HardwareBuffer backed Platform Views on Android >= 29 (flutter/engine#46071 )
2023-09-21 jonahwilliams@google.com [Impeller] Use final cmd buffer to present drawable. (flutter/engine#46023 )
2023-09-21 matanlurey@users.noreply.github.com More Clang Tidy --fix[es] to header files (flutter/engine#46151 )
2023-09-21 dkwingsmt@users.noreply.github.com Reland: Enforce the rule of calling FlutterView.Render (#45300 ) (flutter/engine#45555 )
2023-09-21 yjbanov@google.com Revert "[web] fix clicks on merged semantic nodes (#43620 )" (flutter/engine#46067 )
2023-09-21 matanlurey@users.noreply.github.com Move `git_repo_tools` and `process_fakes` outside of `clang_tidy`. (flutter/engine#46017 )
2023-09-21 godofredoc@google.com Remove linux fuchsia from recipes cq. (flutter/engine#46153 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-09-22 00:00:09 +00:00
Kostia Sokolovskyi
ffecedbca4
Cover more test/widgets tests with leak tracking #11 ( #135231 )
2023-09-21 16:30:32 -07:00
Jacob MacDonald
daea6e00bf
remove field override, assign to super field instead ( #135165 )
...
Removes an ignore about overriding fields. Instead we just assign the value to the original field in the super class.
Related to https://github.com/dart-lang/language/issues/3332 (discovered during investigations into the violation of that lint).
2023-09-21 22:02:12 +00:00
hangyu
528a281a5c
Update alwaysNeedsCompositing in RenderParagraph ( #135076 )
...
fix #111370
According to
5b47fef613/packages/flutter/lib/src/rendering/box.dart (L1259)https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
2023-09-21 14:53:22 -07:00
LongCatIsLooong
45e4a0e525
Fix a TextSpan test ( #135187 )
...
`TextSpan.toStringDeep()` returns a string that contains a lengthy diagnostic message instead of the plain string.
2023-09-21 19:41:58 +00:00
Yegor
d0664bcd79
a few web tweaks for a11y assessment app ( #134479 )
...
Mostly tweaks for better focus management, namely:
* Use `autofocus` throughout so the a11y focus is transferred to a logical place when overlaid content pops up (screen transitions, dialogs).
* Consolidate "enabled" and "disabled" widgets into the same screen. Otherwise, when only a disabled widget is shown, there's nothing to focus on and the screen reader is lost.
2023-09-21 19:38:20 +00:00
Zachary Anderson
30a9f99bc8
Send analytics on 'build ios' and 'build ipa' for plist impeller value ( #135193 )
...
This analytics event only records the value of the plist entry on
`build` commands. This will give an idea of the proportion of users who
are disabling Impeller when shipping apps.
2023-09-21 11:49:29 -07:00
Derek Xu
c627dbfbc6
Add --frontend-server-starter-path option to flutter run and flutter test ( #135038 )
2023-09-21 14:32:35 -04:00
engine-flutter-autoroll
da1f801fd5
Roll Flutter Engine from fa032d52a118 to 78c1ad249b57 (1 revision) ( #135238 )
...
fa032d52a1...78c1ad249bskia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from 3DKf4d8UFviYKRI28... to PXDDhlPyd9sgrWWun... (flutter/engine#46148 )
Also rolling transitive DEPS:
fuchsia/sdk/core/mac-amd64 from 3DKf4d8UFviY to PXDDhlPyd9sg
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-09-21 18:16:40 +00:00
Tong Mu
203ec67c65
Fix violation of the render rule in Windows Startup Test ( #134245 )
...
This PR fixes yet another case in the windows startup test that violates the render rule, which caused https://github.com/flutter/engine/pull/45300 to be reverted.
Although the `FlutterView.render` call is within `onBeginFrame`, there is an `await` before the call, causing the call to fall out of the synchronous scope.
I've added this problem to the documentation of `FlutterView.render` in https://github.com/flutter/engine/pull/45555 .
2023-09-21 17:43:07 +00:00
Bruno Leroux
de44daf1f8
Add a parameter to configure InputDecorator hint fade animations duration ( #135211 )
...
## Description
This PR adds a parameter to configure the input decorator hint fade transition duration.
This animation is not part of the Material specification.
Removing it was considered but it breaks internal tests (see https://github.com/flutter/flutter/pull/107406 ).
I also considered several ways to avoid the fade animation (setting duration to 0, removing the hint text, etc) but it breaks many existing tests that assumes the hint text to be visible.
To mitigate the issue in a non disruptive way, I set the default duration to 20ms (an arbitrary short value).
## Related Issue
Fixes https://github.com/flutter/flutter/issues/20283 .
## Tests
Adds 3 tests, updates 3 tests.
2023-09-21 17:37:07 +00:00
Kostia Sokolovskyi
4204f07d76
Add RestorationManager disposals in test/services/restoration_test.dart. ( #135218 )
2023-09-21 10:24:52 -07:00
Polina Cherkasova
77718845dd
Handle breaking changes in leak_tracker. ( #135185 )
2023-09-21 10:06:21 -07:00
engine-flutter-autoroll
5708b76ef0
Roll Flutter Engine from 6c1e58c86e8c to fa032d52a118 (1 revision) ( #135227 )
...
6c1e58c86e...fa032d52a1skia-flutter-autoroll@skia.org Roll Skia from 322abacca561 to 0cf83a86c56d (1 revision) (flutter/engine#46143 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-09-21 16:30:00 +00:00
engine-flutter-autoroll
8f04f0c2f8
Roll Packages from 51e74b97508a to d0411e450a8d (1 revision) ( #135224 )
...
51e74b9750...d0411e450astuartmorgan@google.com [various] Update invalid NSURL tests (flutter/packages#4959 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com ,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-09-21 15:45:19 +00:00
engine-flutter-autoroll
22748e3a3a
Roll Flutter Engine from 584861202198 to 6c1e58c86e8c (1 revision) ( #135216 )
...
5848612021...6c1e58c86esigurdm@google.com Add package:tar to DEPS (flutter/engine#46140 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-09-21 13:33:29 +00:00
derdilla
beeb3ce923
Cover some cupertino tests with leak tracing ( #135149 )
2023-09-21 06:30:21 -07:00
engine-flutter-autoroll
687f9c867f
Roll Flutter Engine from a4b1ef79596a to 584861202198 (2 revisions) ( #135214 )
...
a4b1ef7959...5848612021skia-flutter-autoroll@skia.org Roll Dart SDK from d5d05146868a to eaeca487c944 (2 revisions) (flutter/engine#46138 )
2023-09-21 skia-flutter-autoroll@skia.org Roll Skia from c20aeee90da9 to 322abacca561 (1 revision) (flutter/engine#46137 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-09-21 10:53:27 +00:00
engine-flutter-autoroll
089e93a15c
Roll Flutter Engine from 3e66ffa6aae6 to a4b1ef79596a (1 revision) ( #135206 )
...
3e66ffa6aa...a4b1ef7959skia-flutter-autoroll@skia.org Roll Skia from 81b9c7fd19b2 to c20aeee90da9 (3 revisions) (flutter/engine#46134 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-09-21 07:38:23 +00:00
Bruno Leroux
07cc3f7a61
Form fields onChange callback should be called on reset ( #134295 )
...
## Description
This PR fixes form fields in order to call the `onChange` callback when the form is reset.
This change is based on the work done in https://github.com/flutter/flutter/pull/123108 .
I considered adding the `onChange` callback to the `FormField` superclass but it would break existing code because two of the three subclasses defines the `onChange` callback with `ValueChanged<String>?` type and the third one defines it with `ValueChanged<String?>?`.
## Related Issue
Fixes https://github.com/flutter/flutter/issues/123009 .
## Tests
Adds 3 tests.
2023-09-21 05:54:19 +00:00
engine-flutter-autoroll
518b775191
Roll Flutter Engine from 88aad1056781 to 3e66ffa6aae6 (2 revisions) ( #135200 )
...
88aad10567...3e66ffa6aaskia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from zuOP7YCHHocXuZJcD... to 3DKf4d8UFviYKRI28... (flutter/engine#46133 )
2023-09-21 jonahwilliams@google.com [Impeller] temp work around for cmd pool validation issues. (flutter/engine#46131 )
Also rolling transitive DEPS:
fuchsia/sdk/core/mac-amd64 from zuOP7YCHHocX to 3DKf4d8UFviY
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-09-21 05:48:26 +00:00
engine-flutter-autoroll
b90a13f3a1
Roll Flutter Engine from 76e5e35ab395 to 88aad1056781 (1 revision) ( #135198 )
...
76e5e35ab3...88aad10567skia-flutter-autoroll@skia.org Roll Skia from a7bcbb9a39f3 to 81b9c7fd19b2 (1 revision) (flutter/engine#46129 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-09-21 04:44:25 +00:00
engine-flutter-autoroll
c416aa4735
Roll Flutter Engine from 89d864552acd to 76e5e35ab395 (21 revisions) ( #135192 )
...
89d864552a...76e5e35ab3matanlurey@users.noreply.github.com Tidy up `DlPaint` and friends. (flutter/engine#46120 )
2023-09-21 skia-flutter-autoroll@skia.org Roll Skia from 86f48da2c812 to a7bcbb9a39f3 (1 revision) (flutter/engine#46128 )
2023-09-21 30870216+gaaclarke@users.noreply.github.com [Impeller] removed global mutable variable for tessellation allocation function pointers (flutter/engine#46127 )
2023-09-20 jonahwilliams@google.com [Impeller] Remove removal of save layer from clip. (flutter/engine#46113 )
2023-09-20 jason-simmons@users.noreply.github.com [Impeller] Apply the entity transformation when rendering FramebufferBlendContents (flutter/engine#46106 )
2023-09-20 matanlurey@users.noreply.github.com Clang tidy-ify `DlColor` and friends. (flutter/engine#46122 )
2023-09-20 godofredoc@google.com Apply the right tag for linux fuchsia cipd packages. (flutter/engine#46123 )
2023-09-20 skia-flutter-autoroll@skia.org Roll Skia from b78c91996051 to 86f48da2c812 (4 revisions) (flutter/engine#46121 )
2023-09-20 skia-flutter-autoroll@skia.org Roll Skia from d923bab3d5fa to b78c91996051 (4 revisions) (flutter/engine#46119 )
2023-09-20 matanlurey@users.noreply.github.com Make `dl_color_(filter|source)` tidy. (flutter/engine#46111 )
2023-09-20 matanlurey@users.noreply.github.com Make `dl_(image|mask|path)_(filter|effect).h` tidy! (flutter/engine#46110 )
2023-09-20 matanlurey@users.noreply.github.com Migrate from `LOG_X` to `kLogX`. (flutter/engine#46107 )
2023-09-20 skia-flutter-autoroll@skia.org Roll Skia from b3c1f49821d8 to d923bab3d5fa (2 revisions) (flutter/engine#46118 )
2023-09-20 matanlurey@users.noreply.github.com Make a variety of low-impact Clang tidy fixes in Impeller. (flutter/engine#46116 )
2023-09-20 ychris@google.com [ios] fix asset url not found when loading app extension (flutter/engine#46073 )
2023-09-20 matanlurey@users.noreply.github.com Make a variety of low-impact Clang tidy fixes. (flutter/engine#46114 )
2023-09-20 skia-flutter-autoroll@skia.org Roll Skia from c19115e8f712 to b3c1f49821d8 (3 revisions) (flutter/engine#46112 )
2023-09-20 skia-flutter-autoroll@skia.org Roll Skia from f4238844089f to c19115e8f712 (5 revisions) (flutter/engine#46108 )
2023-09-20 mdebbar@google.com [web] Move context menu handling to its own class (flutter/engine#46042 )
2023-09-20 matanlurey@users.noreply.github.com Delete `ci/lint.sh`, which is no longer used. (flutter/engine#46049 )
2023-09-20 mdebbar@google.com [web] Make `PlatformViewManager` a clear singleton (flutter/engine#46044 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-09-21 03:09:24 +00:00
Jia Hao
f92884c7b8
Rename debugProfilePlatformChannels to a constant that works in release mode ( #134922 )
...
When it comes to startup profiling, it is very helpful to look at platform channels. `debugProfilePlatformChannels` today only works in debug and profile mode. Unfortunately, using profile mode is less accurate for startup profiling, because of the service isolate introducing additional overhead.
This PR allows this toggle to work in release mode. Note that there are two parts to `debugProfilePlatformChannels`:
- Adding timeline events
- Logging statistics about platform channels
I also considered adding a separate toggle to limit the scope of this change to the former, but that seems like complexity that we might not need at this time.
Towards #102189
2023-09-21 00:20:09 +00:00
derdilla
a0406cccb1
Mark ReastaurationManager not disposed ( #134832 )
2023-09-20 16:46:14 -07:00
derdilla
237db2bb2a
cover more tests with leak tracing ( #134834 )
2023-09-20 16:45:44 -07:00
derdilla
2868bc1351
Fix leak in hardware_keyboard_test.dart ( #134380 )
2023-09-20 16:45:15 -07:00
Kostia Sokolovskyi
04854e8aff
Fix memory leak in _SelectableTextState ( #135049 )
2023-09-20 16:43:44 -07:00
engine-flutter-autoroll
1bfd6a1f3c
Roll Flutter Engine from 39c0f2ea1f53 to 89d864552acd (4 revisions) ( #135169 )
...
39c0f2ea1f...89d864552askia-flutter-autoroll@skia.org Roll Skia from 565d95f72f2e to f4238844089f (3 revisions) (flutter/engine#46105 )
2023-09-20 skia-flutter-autoroll@skia.org Roll Dart SDK from ed05ca364d5e to d5d05146868a (1 revision) (flutter/engine#46104 )
2023-09-20 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from aHtib4LBcLwx7JwK-... to QcxgV9KlY7j3o3b4j... (flutter/engine#46102 )
2023-09-20 skia-flutter-autoroll@skia.org Roll Skia from 9bc5eeb93a1e to 565d95f72f2e (1 revision) (flutter/engine#46100 )
Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from aHtib4LBcLwx to QcxgV9KlY7j3
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-09-20 22:59:18 +00:00
David Iglesias
a4bc894616
[deps] Update package:web dependency. ( #135174 )
...
This PR is the result of running:
```console
$ flutter upgrade-packages --force-upgrade
```
### Issues
* Fixes https://github.com/flutter/flutter/issues/135075
* Supersedes #135081
2023-09-20 22:55:52 +00:00
Yegor
d6d2e89fc8
finer grained logging of Chromium launch sequence ( #135078 )
...
Log the details of how Chromium is about to be launched prior to running
the Chromium command, as well as the path to the Chromium executable.
This should improve our understanding of what's happening here:
https://github.com/flutter/flutter/issues/132654#issuecomment-1726630123
2023-09-20 15:20:16 -07:00
Gray Mackall
b433b17539
Upgrade AGP version in tracing_tests ( #134671 )
...
Related to https://github.com/flutter/flutter/issues/134419
2023-09-20 20:56:25 +00:00
derdilla
a96bf714cb
Cover cupertino/form_section_test with leak tracing ( #135158 )
2023-09-20 13:29:41 -07:00
Kostia Sokolovskyi
e6d160a5c7
Cover more test/widgets tests with leak tracking #7 ( #134943 )
2023-09-20 13:27:29 -07:00
Michael Goderbauer
b0a90aee17
Enable strict-inference ( #135043 )
...
Avoids that dynamic accidentally sneaks in, see https://dart.dev/tools/analysis#enabling-additional-type-checks
2023-09-20 19:59:08 +00:00
Kostia Sokolovskyi
96a4ae9dc5
Cover more test/widgets tests with leak tracking #10 ( #135143 )
2023-09-20 12:29:33 -07:00
derdilla
9b767e6c1f
cover more tests with leak tracing ( #134833 )
2023-09-20 12:21:10 -07:00
Chris Yang
22e4088134
codeisn extension safe iOS framework ( #134966 )
...
Update the conductor to code sign extension safe iOS frameworks
The new frameworks are added in
https://github.com/flutter/engine/pull/45781/files
part of https://github.com/flutter/flutter/issues/124291
Also includes an Engine roll includes:
9232e76c3039c0f2ea1fhttps://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
2023-09-20 11:50:04 -07:00
engine-flutter-autoroll
4d8e390c1b
Roll Flutter Engine from 6f256257b79f to 55314d08d792 (2 revisions) ( #135151 )
...
6f256257b7...55314d08d7skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from kGkqpvcPI1TGmR4Sc... to zuOP7YCHHocXuZJcD... (flutter/engine#46097 )
2023-09-20 skia-flutter-autoroll@skia.org Roll Skia from 56ce5bb201c6 to f54c214a739b (4 revisions) (flutter/engine#46098 )
Also rolling transitive DEPS:
fuchsia/sdk/core/mac-amd64 from kGkqpvcPI1TG to zuOP7YCHHocX
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-09-20 17:41:24 +00:00
Greg Spencer
6e5134b067
Remove 'must be non-null' and 'must not be null' comments in widgets library ( #134992 )
...
## Description
This removes all of the comments that are of the form "so-and-so (must not be null|can ?not be null|must be non-null)" from the cases where those values are defines as non-nullable values.
This PR removes them from the widgets library.
This was done by hand, since it really didn't lend itself to scripting, so it needs to be more than just spot-checked, I think. I was careful to leave any comment that referred to parameters that were nullable, but I may have missed some.
In addition to being no longer relevant after null safety has been made the default, these comments were largely fragile, in that it was easy for them to get out of date, and not be accurate anymore anyhow.
This did create a number of constructor comments which basically say "Creates a [Foo].", but I don't really know how to avoid that in a large scale change, since there's not much you can really say in a lot of cases. I think we might consider some leniency for constructors to the "Comment must be meaningful" style guidance (which we de facto have already, since there are a bunch of these).
## Related PRs
- https://github.com/flutter/flutter/pull/134984
- https://github.com/flutter/flutter/pull/134991
- https://github.com/flutter/flutter/pull/134993
- https://github.com/flutter/flutter/pull/134994
## Tests
- Documentation only change.
2023-09-20 16:43:01 +00:00
engine-flutter-autoroll
52969a0909
Roll Flutter Engine from 5f82fc2f6f24 to 6f256257b79f (1 revision) ( #135147 )
...
5f82fc2f6f...6f256257b7skia-flutter-autoroll@skia.org Roll Skia from fd317812bd27 to 56ce5bb201c6 (4 revisions) (flutter/engine#46096 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-09-20 16:13:25 +00:00
Camille Simon
594ff98a65
[Android] Add Java/AGP/Gradle incompatibility warning to flutter create ( #131444 )
...
Adds warning to `flutter create` command that checks if detected Java version is compatible with the template AGP and template Gradle versions. If a developer is building for Android and their Java version is incompatible with either the AGP or Gradle versions that Flutter currently supports by default for new Flutter projects, then
- a warning will show noting the incompatibility and
- steps will be shown to fix the issue, the recommended option being to configure a new compatible Java version given that Flutter knows we can support the template Gradle/AGP versions and updating them manually may be risky (feedback on this approach would be greatly appreciated!)
Given that the template AGP and Gradle versions are compatible, this PR assumes that the detected Java version may only conflict with one of the template AGP or Gradle versions because:
- the minimum Java version for a given AGP version is less than the maximum Java version compatible for the minimum Gradle version required for that AGP version (too low a Java version will fail AGP compatibility test, but not Gradle compatibility).
- the maximum Java version compatible with minimum Gradle version for a given AGP version is higher than minimum Java version required for that AGP version (too high a Java version will fail Gradle compatibility test, but not AGP compatibility test).
Fixes https://github.com/flutter/flutter/issues/130515 in the sense that `flutter create foo`; `cd foo`; `flutter run` should always be successful.
2023-09-20 16:01:04 +00:00
engine-flutter-autoroll
3a78e5c5fc
Roll Packages from d4e245421737 to 51e74b97508a (12 revisions) ( #135145 )
...
d4e2454217...51e74b9750stuartmorgan@google.com [ios_platform_images] Convert to Pigeon (flutter/packages#4945 )
2023-09-19 abdeluached@gmail.com [go_router_builder] Generate initialLocation with StatefulShellBranchConfig (flutter/packages#4880 )
2023-09-19 engine-flutter-autoroll@skia.org Roll Flutter from b7d0e8c9ed8936504163flutter/packages#4947 )
2023-09-18 47866232+chunhtai@users.noreply.github.com [go_router] Adds on exit (flutter/packages#4699 )
2023-09-18 47866232+chunhtai@users.noreply.github.com [go_router] Fixes RouteInformationParser that does not restore full RouteMatchList if the optionURLReflectsImperativeAPIs is set (flutter/packages#4713 )
2023-09-18 stuartmorgan@google.com [file_selector] Fix unknown extensions on macOS (flutter/packages#4946 )
2023-09-18 30872003+misos1@users.noreply.github.com [camera_avfoundation] ignore audio samples until first video sample (flutter/packages#4587 )
2023-09-18 engine-flutter-autoroll@skia.org Roll Flutter from 1b18b1327ab7d0e8c9edflutter/packages#4944 )
2023-09-18 tarrinneal@gmail.com [video_player] isCompleted event. (flutter/packages#4923 )
2023-09-18 32538273+ValentinVignal@users.noreply.github.com [go_router] Fix an issue in the documentation that used `state.queryParameters` instead of `state.uri.queryParameters` (flutter/packages#4881 )
2023-09-18 stuartmorgan@google.com [google_sign_in] Convert iOS to Pigeon (flutter/packages#4941 )
2023-09-18 stuartmorgan@google.com Add dashboard link to README (flutter/packages#4902 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com ,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-09-20 16:01:02 +00:00
Greg Spencer
8cda3bea23
Remove 'must not be null' comments from various libraries. ( #134984 )
...
## Description
This removes all of the comments that are of the form "so-and-so (must not be null|can ?not be null|must be non-null)" from the cases where those values are defines as non-nullable values.
This PR removes them from the animation, cupertino, foundation, gestures, semantics, and services libraries. Each of them only had a few, so I lumped them together.
This was done by hand, since it really didn't lend itself to scripting, so it needs to be more than just spot-checked, I think. I was careful to leave any comment that referred to parameters that were nullable, but I may have missed some.
In addition to being no longer relevant after null safety has been made the default, these comments were largely fragile, in that it was easy for them to get out of date, and not be accurate anymore anyhow.
This did create a number of constructor comments which basically say "Creates a [Foo].", but I don't really know how to avoid that in a large scale change, since there's not much you can really say in a lot of cases. I think we might consider some leniency for constructors to the "Comment must be meaningful" style guidance (which we de facto have already, since there are a bunch of these).
## Related PRs
- https://github.com/flutter/flutter/pull/134991
- https://github.com/flutter/flutter/pull/134992
- https://github.com/flutter/flutter/pull/134993
- https://github.com/flutter/flutter/pull/134994
## Tests
- Documentation only change.
2023-09-20 15:44:49 +00:00
engine-flutter-autoroll
a1f8c99f95
Roll Flutter Engine from 6535421b30d3 to 5f82fc2f6f24 (2 revisions) ( #135142 )
...
6535421b30...5f82fc2f6fskia-flutter-autoroll@skia.org Roll Skia from d7f2d1083979 to fd317812bd27 (2 revisions) (flutter/engine#46094 )
2023-09-20 skia-flutter-autoroll@skia.org Roll Dart SDK from b3fd178ce59f to ed05ca364d5e (1 revision) (flutter/engine#46093 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-09-20 15:29:06 +00:00
engine-flutter-autoroll
7212a079d9
Roll Flutter Engine from 67d4aaef3c7b to 6535421b30d3 (1 revision) ( #135139 )
...
67d4aaef3c...6535421b30skia-flutter-autoroll@skia.org Roll Dart SDK from b3fd178ce59f to ed05ca364d5e (1 revision) (flutter/engine#46092 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-09-20 14:38:24 +00:00
