Commit graph

10394 commits

Author SHA1 Message Date
amirh ed84fb9652
add a bottomAppBarColor to ThemeData (#14859) 2018-02-26 10:41:56 -08:00
Devon Carew 761cb82c6d
update the IntelliJ metadata templates (#14867)
* update the IntelliJ metedata templates

* fix test expectation
2018-02-26 07:38:22 -08:00
Alexander Aprelev c3bbcb6f91
Add --preview-dart-2 to 'flutter drive' (#14858)
* Add --preview-dart-2 to 'flutter drive'

* Run driver side in --preview-dart-2 mode.

* Fix test
2018-02-24 09:28:58 -08:00
amirh 1f3eb5034f
Add a hasNotch flag to BottomAppBar (#14856) 2018-02-23 18:35:40 -08:00
amirh c6e7ad1cfb
Let the FAB compute the notch even when it doesn't overlap the BAB. (#14852)
The Floating Action Button adds some margin around it for the notch.
So we need to compute a notch even when the FAB and the Bottom App Bar
doe not overlap.
2018-02-23 15:34:03 -08:00
amirh 5d39f15c69
Smooth Floating Action Button notch (#14851) 2018-02-23 14:58:50 -08:00
Jason Simmons 7f03b9e41b
Upgrade to test package version 0.12.30+4 (#14853)
30+4 has made some changes to the remoting protocol that are incompatbile
with a test harness running 30+3 (e.g. adding a type='initial' field to the
first message)
2018-02-23 12:49:57 -08:00
Vyacheslav Egorov 1f6b9471a8
Fix snapshot fingerprinting in --preview-dart-2 mode. (#14843)
* Fix snapshot fingerprinting in --preview-dart-2 mode.

This is a follow up to PR #14775 - instead of treating dill file
as an input treat as intermediate file and don't fingerprint it.

Make sure to always use original main Dart file as an entry
point for fingerprint calculation.

This fixes an issue that AOT snapshot would not be recompiled in
the preview-dart-2 mode if entry point changes, e.g.

$ flutter build aot -t t/x.dart --preview-dart-2
$ flutter build aot -t t/y.dart --preview-dart-2

The second invocation would not build AOT snapshot.

(This issue is visible on the microbencmarks bot)
2018-02-23 21:40:19 +01:00
David Shuckerow 3ee85e0137
Create and test max and min animations (#14814) 2018-02-22 14:54:27 -08:00
Hans Muller 3ea4d06340
Update TabBar indicator painter when tab controller changes (#14825) 2018-02-22 11:12:39 -08:00
amirh 01b53bd014
Fix overlap check in bottom app bar's custom clipper (#14813) 2018-02-22 09:20:37 -08:00
Greg Spencer 0b6c1938cf
Fix gsutil argument order. (#14808) 2018-02-22 09:03:10 -08:00
Michael Thomsen 382ee4baa4
Detail number of available devices in doctor summary (#14781) 2018-02-22 17:40:56 +01:00
Michael Thomsen b6d8615aed
No longer gitignore pubspec.lock (#14768) 2018-02-22 10:11:09 +01:00
Todd Volkert 37ffb2d730
Make the isRunningOnBot getter more robust. (#14811)
It was failing in the case of an AppContext being in scope
but not having a `BotDetector` seeded in it.
2018-02-21 15:01:46 -08:00
xster 1bdbfe7b52
Fix SliverPadding dropping the chain on scrollOffsetCorrection propagation (#14789)
* Fix SliverPadding dropping the chain on scrollOffsetCorrection propagation

* review doc
2018-02-21 14:51:14 -08:00
xster 62addedc11
Fix focus switching when changing tabs in CupertinoTabScaffold (#14431)
* Fix focus switching when changing tabs in CupertinoTabScaffold

* review

* Test focuses are saved within tabs

* review
2018-02-21 12:51:19 -08:00
Mikkel Nygaard Ravn 681192a042
Fix test that makes assumptions about the impl of async method (#14804) 2018-02-21 20:47:26 +01:00
Victor Choueiri 3f884661bd Skip upgrade check on upgrade (#14797) 2018-02-21 11:34:36 -08:00
Victor Choueiri 586d7c2f20 Fix broken link to AnimatedListState documentation (#14786) 2018-02-21 11:31:43 -08:00
xster d3418a5da4
Productionize the publishing Travis shard (#14714) 2018-02-21 10:57:21 -08:00
amirh 7996d7fb82
Initial implementation of BottomAppBar (#14713)
* add a FAB NotchMaker to ScaffoldGeometry

* add a notchMaker to FloatingActionButton

* Initial implementation of BottomAppBar

Mainly includes the notch making logic.
Not yet tested as currently there is no way to make the FAB and the BAB
overlap, once #14368 to lands we could add unit tests to the
BottomAppBar as well.

* use a closeable for clearing the FAB notchmaker
2018-02-21 10:20:58 -08:00
jcollins-g ca677011f8
Fix flutter tools packages_test when run off bots (#14692)
* Fix packages tests when run off bots

* Tweak dependencies to make bots happy

* Review comment
2018-02-21 09:54:07 -08:00
Hans Muller 24efb55b03
Generalized TabBar selected tab indicator (#14741) 2018-02-21 09:13:45 -08:00
Todd Volkert 21c514fc56
Wire up support for --skia-deterministic-rendering (#14802)
https://github.com/flutter/flutter/issues/14519
2018-02-20 23:22:58 -08:00
Todd Volkert 50b7fad6a3
Mark android_sample_catalog_generator as flaky (#14799)
https://github.com/flutter/flutter/issues/14798
2018-02-20 22:14:33 -08:00
Todd Volkert 22a4a7d9d2
Roll engine to 585610456326bc455ffeb257f6d33d476b4ee3fc (#14788)
Fixes https://github.com/flutter/flutter/issues/14751
2018-02-20 15:52:49 -08:00
xster 4c0cfee3d1
Set encryption compliance in Gallery Info.plist (#14737) 2018-02-20 15:42:28 -08:00
Todd Volkert eabfd570dd
Remove unused parameter to DevFS._scanBundleEntry (#14782) 2018-02-20 12:43:29 -08:00
Alexander Aprelev 45175f5342
Now that we are on dev-23, remove analyzer //ignore (#14780) 2018-02-20 11:20:13 -08:00
Alexander Aprelev 39ddeb52b0
Fix snapshot fingerprint check for --preview-dart-2. (#14775)
* Fix snapshot fingerprint check for --preview-dart-2.

* Remove printTraces
2018-02-20 10:02:00 -08:00
Jason Simmons 494270fe46
Return the result of the operation in ServiceObject.reload (#14755) 2018-02-20 09:45:32 -08:00
Victor Choueiri 4f5f4222e0 Add flutter version to non-verbose doctor output (#14779) 2018-02-20 09:22:49 -08:00
Danny Tuppeny f914e701c5
Update some http links to https (#14762)
These URLs all automatically redirect HTTP to HTTPS so makes sense to point users at the secure versions.
2018-02-19 21:12:17 +00:00
Mikkel Nygaard Ravn 130dfc87ad
Make Podfiles use symlinks to local pods (#14748) 2018-02-19 21:32:13 +01:00
Mikkel Nygaard Ravn 54bf773d37
Fix dartdoc typo (#14772) 2018-02-19 20:35:53 +01:00
Todd Volkert 1363489a86
Add a --just-print flag to roll_dev. (#14766)
This will allow other tools to call into the roll_dev script
to know what version is about to be published without actually
publishing.
2018-02-18 22:27:46 -08:00
Mikkel Nygaard Ravn 1e242ebc7c
Mark plugin tests as stable (#14760) 2018-02-17 22:46:29 +01:00
Mikkel Nygaard Ravn f526805e20
Fix of flutter packages get in plugin project (#14757) 2018-02-17 21:25:13 +01:00
Todd Volkert d4e973351e
Roll engine to e5b72e5f87cae358b457b6c1cb55c4560ce3c46c (#14759)
https://github.com/flutter/flutter/issues/14751
2018-02-17 11:31:34 -08:00
xster f7f1685cac
Make sure broken pod install runs triggers pod install on next flutter build (#14753) 2018-02-16 16:05:16 -08:00
Alexandre Ardhuin 297fd9431f
fix potential call on null (#14731)
* fix potential call on null

* review
2018-02-16 22:37:07 +01:00
Todd Volkert 1686b6d56d
Remove fixed asset bundles - they're no longer used. (#14729) 2018-02-16 10:22:52 -08:00
Alexander Aprelev fe00598ab3
Reintroduce engineDartSdkPath artifact. (#14742)
This is needed to support running with local engine's dart sdk.

This is follow-up to https://github.com/flutter/flutter/pull/14702.
2018-02-16 09:20:23 -08:00
Vyacheslav Egorov aa7e9637ac
Fix several Dart 2 issues in the flutter_driver. (#14749)
* All lists produced by JSON parsing are List<dynamic>. If more
speficic type is required then they need to be explicitly cast, e.g.
using castFrom helper;
* Function of type (ByText) -> Finder is not a subtype of
(SerializableFinder) -> Finder because ByText is in the contravariant
position;
* In Dart 2 typed(any) should be used instead of any in mockito based
tests.
2018-02-16 18:01:54 +01:00
Matt Sullivan 2a6ed0a869
Added sample code to AnimatedOpacity API docs (#14730)
* Added sample code to AnimatedOpacity docs
2018-02-16 08:56:44 -08:00
Mikkel Nygaard Ravn 31a0a5f4d0
Remove generated files from repo (#14697) 2018-02-16 12:33:21 +01:00
Mikkel Nygaard Ravn 57779e7e01
Skip new failing test while investigating (#14746)
Merging on red tree to get back to green.
2018-02-16 12:05:37 +01:00
Mikkel Nygaard Ravn 2000435728
Move plugin injection to just after pub get (#14743) 2018-02-16 10:17:28 +01:00
Mikkel Nygaard Ravn 558c753f01
Fix test failure by silencing analyzer preamble and congrats (#14745) 2018-02-16 09:37:48 +01:00