Commit graph

10394 commits

Author SHA1 Message Date
Jacob Richman 046c6d5f7f
Track which Widget objects were created by the local project. (#15041)
Make flutter test support the --track-widget-creation flag.
Add widget creation location tests. Tests are skipped when
--track-widget-creation flag is not passed.
2018-03-09 08:09:49 -08:00
Michael Goderbauer a9e2781132
Do not do semantics for detached objects (#15320) 2018-03-08 22:33:46 -08:00
Michael Goderbauer 35c43ecc98
Roll engine to 1d0da7799583b089ede66b81068f40cc4597a429 (#15322) 2018-03-08 22:30:55 -08:00
Michael Goderbauer f002839d44
Better print-out of semantics tree (#15302) 2018-03-08 19:14:43 -08:00
Alexander Aprelev 2890e18bcb
Return copied kernel filename for flutter test execution. (#15298)
* Return copied kernel filename.

This fixes 'flutter test --preview-dart-2' crash.
2018-03-08 16:02:21 -08:00
Hans Muller 0038a2b21c
Updated the material_en.arb description for signedIn (#15306) 2018-03-08 15:42:29 -08:00
Jason Simmons 6f5bcb97a4
Do not add spacing to the first child's width in RenderWrap line wrapping (#15272)
The first child fits on the line if the line can accomodate its width.
After the first child the line needs room for the child's width plus spacing.
2018-03-08 15:01:37 -08:00
Todd Volkert d996ab921c
Rename "slow mode" to be "debug mode" (#15205)
This moves toward more consistency in our messaging. Apps are
launched using --debug, so the banner will reflect the build
mode.
2018-03-08 12:54:06 -08:00
Alexander Aprelev 1087279a4d
Create frontend compiler in flutter test lazily. (#15251)
* Create frontend compiler in `flutter test` lazily.

This is needed to avoid unwarranted runtime dependencies on Artifacts,
for example when in non-preview-dart-2 mode.
Refactor the compilation-related code into _Compiler class.
2018-03-08 11:21:40 -08:00
Alexander Aprelev 1a3c9b83c0
Step process, boolean_selector, collection deps up. (#15262)
This is needed to fix 'flutter test --preview-dart-2 test/all.dart' in dev/devicelab
2018-03-08 11:07:03 -08:00
Hans Muller f14397ae11
Correct DefaultMaterialLocalizations.delegate supported locales list (#15260) 2018-03-08 11:06:31 -08:00
Hans Muller ea155df91e
Roll localizations (#15269) 2018-03-08 11:06:09 -08:00
Stefano Rodriguez b944cd7187 Plug TextDirection into box_decoration background gradient (#14810)
* Plug TextDirection into box_decoration background gradient

* Add test
2018-03-08 11:00:21 -08:00
Jonah Williams afabdfecf9
Display a message if hardware rendering is supported (#15266)
* add device.supportsHardwareRendering and display a message if true

* Address some comments
2018-03-08 10:41:29 -08:00
Alexander Aprelev 69c33a321a
Fix path to uri conversion. (#15264) 2018-03-08 10:25:27 -08:00
Jason Simmons 6e46c184d6
Roll engine back to 24cf8ebd8621713a6936df783dad5019f52bc85e (#15270)
This reverts commit 9d46ed2bb9.
2018-03-08 10:09:18 -08:00
Jason Simmons 7358d59036
Dart2 typesafe invocation of IsolateConfiguration callback (#15267) 2018-03-08 10:08:59 -08:00
Jason Simmons 9d46ed2bb9
Roll engine to 1b7325ca6825a1305d5521a5c0abe6fb32688dea (#15257)
(libtxt is enabled by default in this engine)
2018-03-07 13:37:26 -08:00
Jonah Williams 27df288568
RenderWrap.performLayout should take spacing into consideration (#15256)
* RenderWrap.performLayout takes should take spacing into consideration when deciding to move to next row/axis

* fix spacing in text

* remove dart:developer import

* remove extra line
2018-03-07 13:00:14 -08:00
xster c2261a3a2c
Remove a mixin from RenderListWheelViewport that was never used (#14900) 2018-03-07 11:56:36 -08:00
Todd Volkert fffb7630c1
Give file system recording serialization a timeout. (#15217)
Some file I/O is piped from OS processes and never completes,
so without havign a timeout on the recording serialzation, we
end up waiting forever on that I/O to complete.
2018-03-07 11:39:59 -08:00
shrike69 f3c806c9f2
Remove _checkPort() when getting flutter views (#15184) 2018-03-07 10:35:24 -08:00
Alexander Markov 7d0536b87a
Enable global type flow analysis in Dart 2 AOT (#15221) 2018-03-07 09:35:22 -08:00
Alexander Aprelev 0d6d312546
Test gradle dependencies-file generation (#15176)
* Test gradle dependency file generation

* Fix lints, clean up comments, formatting.
2018-03-07 08:29:05 -08:00
Alexander Aprelev c01cad3491
Fix flutter test --preview-dart-2 following last dart roll. (#15233)
* Fix `flutter test --preview-dart-2`  following last dart roll.

Incremental compiler maintains single incremental dill file, so for every test compilation that dill file has to be copied away for execution.

* Fix lints
2018-03-07 06:27:58 -08:00
Siva 9c38d6bb35
Fix some of the generic types specified to avoid runtime errors in --preview-dart-2 (#15166)
* Fix some of the generic types specified to avoid runtime errors in
--preview-dart-2

  type 'YamlMap' is not a subtype of type 'Map<String, dynamic>' where
    YamlMap is from package:yaml/src/yaml_node.dart
    Map is from dart:core
    String is from dart:core

  package:flutter_devicelab/framework/manifest.dart 17:36       loadTaskManifest
  test/manifest_test.dart 14:33                                 main.<fn>.<fn>
  package:test/src/backend/declarer.dart 161:27                 Declarer.test.<fn>.<fn>.<fn>

* Add dynamic generic types to keep the analyer happy.

* Address code review comment.
2018-03-07 00:33:21 -08:00
Mikkel Nygaard Ravn 0d59679624
Make Flutter tooling work on Android without Xcode being installed (#15161) 2018-03-07 08:41:23 +01:00
Josh Soref c5a5945e92 Spelling (#15229)
* spelling: accommodate

* spelling: allotted

* spelling: anonymous

* spelling: artificial

* spelling: associated

* spelling: asset

* spelling: button

* spelling: canvas

* spelling: compatibility

* spelling: coverage

* spelling: condition

* spelling: decoration

* spelling: deferring

* spelling: diameter

* spelling: direction

* spelling: displacement

* spelling: dropdown

* spelling: needing

* spelling: environment

* spelling: exited

* spelling: expansion

* spelling: explore

* spelling: families

* spelling: horizontal

* spelling: increment

* spelling: indices

* spelling: internationalization

* spelling: labrador

* spelling: localizations

* spelling: midflight

* spelling: milliseconds

* spelling: minimum

* spelling: multiple

* spelling: multiplication

* spelling: navigator

* spelling: overridden

* spelling: package

* spelling: performance

* spelling: platform

* spelling: porsche

* spelling: position

* spelling: preceded

* spelling: precede

* spelling: precedence

* spelling: print

* spelling: property

* spelling: readily

* spelling: reproducibility

* spelling: rounded

* spelling: scroll

* spelling: separate

* spelling: separator

* spelling: services

* spelling: specific

* spelling: specify

* spelling: synchronously

* spelling: through

* spelling: timeout

* spelling: triangle

* spelling: trivial

* spelling: unusual

* spelling: then

* spelling: vertically

* spelling: visible

* spelling: visited

* spelling: voice
2018-03-06 21:36:03 -08:00
Todd Volkert d0cbbd5394
Fail if precompiled test entry point is specified, but more than one test suite is run (#15208) 2018-03-06 21:28:52 -08:00
Alexander Markov 602e6d74b5
Pass entry points JSON files to front-end server, take 2 (#15227)
* Pass entry points JSON files to front-end server (#15180)

* Fix ios/debug build which uses 'flutter build aot': do not require entry points files and disable AOT transformations in this mode
2018-03-06 18:45:45 -08:00
Hans Muller e1c38aa024
Enable aligning a dropdown button's width with its menu's width (#14849) 2018-03-06 17:37:27 -08:00
Alexander Markov 01d8e0a143
Revert "Pass entry points JSON files to front-end server" (#15223)
* Revert "Pass entry points JSON files to front-end server (#15180)"

This reverts commit 0edea88745.

Reason: buildbot failures on Mac.
2018-03-06 16:08:37 -08:00
xster f048023638
Cupertino picker haptic (#14831)
* Add selection haptic feedback to Cupertino Pickers

* review

* don't haptic on android
2018-03-06 15:38:00 -08:00
Michael Goderbauer 86be138d9c
Make BottomNavBar accessible (#15211) 2018-03-06 15:08:39 -08:00
Alexander Markov 0edea88745
Pass entry points JSON files to front-end server (#15180) 2018-03-06 14:50:22 -08:00
Keerti Parthasarathy 0263394028
Adding back commit #e0f6e62 with fix to test failures (#15212)
* Add to Artifacts, and add optional arguments to entry points for flut… (#15185)

Add to Artifacts, and add optional arguments to entry points for flutter run and test to allow for wiring up the same with preview-dart-2 internally

* Changing packages uri here is not necessary
2018-03-06 14:41:50 -08:00
Alexander Aprelev 758b302c8d
Add --preview-dart-2 relaunch test. (#15117)
* Add a test that measures/verifies start from warm state(app was previously compiled).

* Remove json file from the first run.
2018-03-06 14:33:26 -08:00
Jason Simmons 85412d8b7c
Roll engine to 24cf8ebd8621713a6936df783dad5019f52bc85e (#15213) 2018-03-06 14:06:36 -08:00
Keerti Parthasarathy 7066cd7b88
Revert "Add to Artifacts, and add optional arguments to entry points for flut… (#15185)" (#15210)
This reverts commit e0f6e626e9.
2018-03-06 11:55:39 -08:00
Keerti Parthasarathy e0f6e626e9 Add to Artifacts, and add optional arguments to entry points for flut… (#15185)
Add to Artifacts, and add optional arguments to entry points for flutter run and test to allow for wiring up the same with preview-dart-2 internally
2018-03-06 10:03:42 -08:00
Alexander Markov dba9584ba1
Pass extra front-end and gen_snapshot options to GenerateDependencies gradle task, as it also runs 'flutter build aot' (#14980) 2018-03-06 09:19:30 -08:00
Sarah Zakarias 3ecc2a4ed2
Url encode asset lookup key (#15171) 2018-03-06 09:24:31 +01:00
Todd Volkert 545c292cb8
Pass --trace to pub when in verbose mode (#15169)
https://github.com/dart-lang/pub/issues/1812
2018-03-05 20:01:30 -08:00
P.Y. Laligand 8709e5e71f
[fuchsia] Add explicit sources to a few targets. (#15182) 2018-03-05 18:03:09 -08:00
Yegor e9c982c39f
[semantics]: minor docs & style clean-up (#15181)
* [semantics]: minor docs & style clean-up

* remove a
2018-03-05 17:01:42 -08:00
Jonah Williams 419fef3f8b
Check that State.initState and State.didUpdateWidget don't return Futures (#15183)
* add a debug check that the returned Type of State.initState and State.didUpdateWidget are not Futures

* add test to verify that async lifecycles throw FlutterErrors

* address some feedback, match implementation of setState check

* address feedback from hixie

* fix odd spacing in test
2018-03-05 15:59:18 -08:00
Sarah Zakarias f8ac23cd86 Roll engine to a00f8e8bc0f3d08ec0c0ca24b01226441bcaf03a (#15172) 2018-03-05 23:27:57 +01:00
Alexander Aprelev 70f60b17d7
Run dev/bots/test's flutter drive test in preview-dart-2 (#15090)
* Run dev/bots/test's flutter drive test in preview-dart-2

* Fix extension callback type

* More type fixes
2018-03-05 08:55:10 -08:00
Todd Volkert c885015934
Fix download Dart DK step to work for paths with apostrophes (#15137)
Fixes https://github.com/flutter/flutter/issues/15136
2018-03-04 12:15:22 -08:00
Ian Hickson fe334e1652
More quoting in Bash (#15087)
Someone ended up with STAMP_PATH containing a blank line.

Also, replace [ with [[.
2018-03-02 17:54:51 -08:00