Commit graph

33498 commits

Author SHA1 Message Date
Flutter GitHub Bot 8080becadf
roll packages (#120951) 2023-02-23 19:21:53 +00:00
Flutter GitHub Bot 5dc569f148
Marks Linux run_debug_test_linux to be unflaky (#121237)
Co-authored-by: Loïc Sharma <737941+loic-sharma@users.noreply.github.com>
2023-02-23 19:11:17 +00:00
engine-flutter-autoroll c722ce419a
Roll Flutter Engine from 19cf8e363f78 to b4b4c15d3a60 (2 revisions) (#121341)
* e7d34e1e8 Roll Skia from 69f83e81ef3f to a321a8750271 (2 revisions) (flutter/engine#39819)

* b4b4c15d3 Roll Fuchsia Mac SDK from xFmgbl9L7nOoL8W-w... to OCFfGKefENe8lYAwM... (flutter/engine#39820)
2023-02-23 17:44:30 +00:00
chunhtai 660992a161
Fix text.rich to merge widget span (#113461)
* Fix text.rich to merge widget span

* migrate to new API

* update

* addressing comment

* addressing comments

* update

* addressing comment

* Update
2023-02-23 17:38:52 +00:00
Taha Tesser 56e1bddc59
Fix SliverAppBar.medium & SliverAppBar.large title overlap with leading/actions widgets, leading width, and title spacing (#120780)
* Fix `SliverAppBar.medium` & `SliverAppBar.large` title overlap with leading/actions widgets, leading width, and title spacing

* Add `titleSpacing` theme tests and consolidate multiple tests for the same widgets
2023-02-23 17:12:11 +00:00
engine-flutter-autoroll af347d6677
19cf8e363 [web] Copy everything under the local canvaskit folder (flutter/engine#39799) (#121338) 2023-02-23 16:48:20 +00:00
engine-flutter-autoroll 19b2aa14c0
c87028288 Roll Fuchsia Linux SDK from 0RfFdaUCok_sFfUN1... to 69m3Jn73L34XwlsWH... (flutter/engine#39761) (#121332) 2023-02-23 14:03:39 +00:00
Eilidh Southren 0c1ed75915
Remove newline (#121090)
* remove newline

* update crswap

* add const constructor

* update const
2023-02-23 10:39:41 +00:00
engine-flutter-autoroll 0f69bc7b78
Roll Flutter Engine from 34794638c8b8 to d4bae2887e24 (2 revisions) (#121320)
* 952a89b4b [Impeller] Wire up a playground that can run Dart (flutter/engine#39805)

* d4bae2887 [Impeller] Add PolygonMode to render layer (flutter/engine#39810)
2023-02-23 10:03:28 +00:00
Bruno Leroux 046d907f53
Fix TextSelectionGestureDetectorBuilder wrong cause for onDoubleTapDown (#121093)
Co-authored-by: Bruno Leroux <bruno.leroux@gmail.com>
2023-02-23 09:24:17 +00:00
engine-flutter-autoroll 114d93f832
34794638c Roll Skia from 149bb820e0c3 to 69f83e81ef3f (2 revisions) (flutter/engine#39815) (#121316) 2023-02-23 08:51:08 +00:00
engine-flutter-autoroll 02d5f2f648
b0248b199 Roll Skia from 29fc6cac02f5 to 149bb820e0c3 (1 revision) (flutter/engine#39813) (#121313) 2023-02-23 08:01:11 +00:00
engine-flutter-autoroll 7d0aa9eea9
74eb9be55 Roll Skia from fa36bb160826 to 29fc6cac02f5 (3 revisions) (flutter/engine#39812) (#121308) 2023-02-23 07:15:09 +00:00
engine-flutter-autoroll 3115993117
Roll Flutter Engine from c4577135b5b9 to 26971ae36c31 (2 revisions) (#121305)
* 41d6f3bb7 Roll Skia from f163f6ed5db0 to fa36bb160826 (2 revisions) (flutter/engine#39811)

* 26971ae36 Roll Fuchsia Mac SDK from cGa3bk2BmrHL_waB8... to xFmgbl9L7nOoL8W-w... (flutter/engine#39808)
2023-02-23 05:25:39 +00:00
engine-flutter-autoroll 1ba617a59c
Roll Flutter Engine from 137caa761540 to c4577135b5b9 (4 revisions) (#121303)
* 00f2a3861 Deprecate WindowPadding (flutter/engine#39775)

* 4c6c259ba Roll Skia from 335cabcf8b99 to 080897012390 (4 revisions) (flutter/engine#39802)

* e1c327750 Roll Skia from 080897012390 to f163f6ed5db0 (1 revision) (flutter/engine#39806)

* c4577135b [iOS][Text Input] Avoid crash when its UIViewController.view is nil. (flutter/engine#39768)
2023-02-23 04:33:22 +00:00
Todd Volkert 71c4570932
Add ResizeImage.policy (#121154)
* Add ResizeImage.policy

This adds a new `ResizeImage.policy` property that controls how `ResizeImage`
will interpret its `width` and `height` properties. The existing behavior is
preserved via `ResizeImagePolicy.exact` (default), but there is now the option
to use `ResizeImagePolicy.fit`, which satisfies the use case outlined in
flutter/flutter#118543.

The API doc assets were added in flutter/assets-for-api-docs#209

Fixes flutter/flutter#118543

* Docuemnt public member

* Remove protected annotation from overrides - was failing tests

* Fixed analysis of code in Dartdoc

* More dartdoc code analysis fixes

* One more fix

* Review comments
2023-02-23 03:53:05 +00:00
suragch 9619c33348
Remove obsolete comment (#120265)
* Remove obsolete comment

The method `_stopCursorTimer` no longer exists.

* Add edited comment back in

Addresses these comments:
- https://github.com/flutter/flutter/pull/120265#discussion_r1101673834
- https://github.com/flutter/flutter/pull/120265#discussion_r1102120022

---------

Co-authored-by: Kate Lovett <katelovett@google.com>
2023-02-23 02:46:16 +00:00
codiss 156c6614bf
Fix Material3 TabBarTheme.dividerColor not working (#119690)
* Fixed Material3 TabBarTheme.dividerColor not working

* Add 'Material3 - TabBar inherits the dividerColor of TabBarTheme' test

---------

Co-authored-by: Kate Lovett <katelovett@google.com>
2023-02-23 02:46:11 +00:00
Michael Goderbauer 4ef1fe4434
Work-around for channels flake (#121261) 2023-02-23 02:46:08 +00:00
Michael Goderbauer 1737233567
Fix typo (#121291) 2023-02-23 02:46:06 +00:00
Greg Spencer a50bdcfd18
Add getInheritedWidgetOfExactType to BuildContext (#121276)
* Add getInheritedWidgetOfExactType to BuildContext

* Use the new API in all the places

* Fix doc error

* Review Changes
2023-02-23 01:09:51 +00:00
Christopher Fujino 048725981e
remove Christopher Fujino from codeowners of //dev/ci (#121281)
Co-authored-by: Ricardo Amador <32242716+ricardoamador@users.noreply.github.com>
2023-02-23 01:09:48 +00:00
David Skelly 368537b910
Add padding to DropdownButton (#115806)
* add padding param to DropdownButton

* improve padding comment

* update test

* Add more context to documentation

* update padding documentation with more detail

---------

Co-authored-by: Kate Lovett <katelovett@google.com>
2023-02-23 01:07:51 +00:00
Tomasz Gucio f85a75db25
Remove outdated TODO (#121200) 2023-02-23 01:02:52 +00:00
engine-flutter-autoroll fede6d17e9
Roll Flutter Engine from 3aa112c75ccb to 137caa761540 (20 revisions) (#121286)
* 0fd15eece Started using bgr10_xr for opaque surfaces. (flutter/engine#39727)

* f0e5c08f7 [platform_view] fix overlapping platform view not touchable (flutter/engine#39527)

* 03b5998b4 Roll Fuchsia Mac SDK from 25mb67G0L_sZ_OQCC... to dj-2XkYHvZUsqlZTc... (flutter/engine#39782)

* 2e5b1bf04 Updated the wide-gamut constant and added a unit test for it. (flutter/engine#39776)

* 1ce93ca0a Roll Dart SDK from 0db7573c6b70 to c9a4fd7fd7fa (1 revision) (flutter/engine#39783)

* 8368fb5b6 Roll Dart SDK from c9a4fd7fd7fa to 5003b952affb (1 revision) (flutter/engine#39787)

* ee5ea205b Roll Dart SDK from 5003b952affb to 6f5df63655ad (1 revision) (flutter/engine#39790)

* d9be356a8 Roll Fuchsia Mac SDK from dj-2XkYHvZUsqlZTc... to cGa3bk2BmrHL_waB8... (flutter/engine#39791)

* 50af61302 [web] Add `dart:js_interop` to BUILD.gn. (flutter/engine#39792)

* eb5e5624d [common] Use FML macro to prevent copy/assignment (flutter/engine#39786)

* 6acfddc78 Add more log when receiving semantics node not part of update (flutter/engine#39777)

* 336e7ce63 Roll Skia from 22b594afb4d3 to 78bad646fe78 (24 revisions) (flutter/engine#39793)

* e65391f8b [Impeller] Add root dockspace to playgrounds (flutter/engine#39789)

* 3848f6429 [Impeller] ensure glyph type contributes to FontGlyphPair hash/eq (flutter/engine#39794)

* cb1ef6f08 Roll Skia from 78bad646fe78 to 335cabcf8b99 (2 revisions) (flutter/engine#39795)

* ac6129db2 made opaque wide gamut images take up 32 bits per pixel (flutter/engine#39691)

* c74a4bc67 save/restore around clipping the (potentially cached) frame canvas (flutter/engine#39797)

* ed3f15d94 [Embedder API] Add CODEOWNERS (flutter/engine#39784)

* 1a3bddcc1 Fix a race in ShellTest.PushBackdropFilterToVisitedPlatformViews (flutter/engine#39798)

* 137caa761 Roll Dart SDK from 6f5df63655ad to 602941be8007 (2 revisions) (flutter/engine#39800)
2023-02-23 00:20:39 +00:00
Casey Hillers 8f7ccd4c41
Revert "Speed up first asset load by using the binary-formatted asset manifest for image resolution (#118782)" (#121220)
This reverts commit e3db0488ad.
2023-02-23 00:13:33 +00:00
Ricardo Amador 1168c2c8b9
Update jdk in cirrus dockerfile image. (#121251)
* Update jdk in cirrus dockerfile image.

* Update to install jaxb for jdk11. Hopefully this works.

* Add jaxb to classpath

* Classpath was not set in run

* Update to use newer tools

* typo

* Update path to commandline tools.

* Trying different approach

* Wrong path

* Wrong path

* Wrong path

* Wrong path

* Remove debug statements
2023-02-22 15:06:58 -08:00
Casey Hillers 9241426828
Revert "Revert "[Re-land#2] Button padding M3 (#119498)" (#119597)" (#119656)
This reverts commit 7ba440655a.
2023-02-22 13:51:03 -08:00
Michael Goderbauer 5ccb4d4b95
Rename WindowPadding to ViewPadding (#121152)
* Rename WindowPadding to ViewPadding

* dart fix

* typos
2023-02-22 21:32:40 +00:00
Mushaheed Syed 7d85a585da
Add ActionButtonIconsData for overriding action icons (#118229)
* Add ActionButtonIconsData for overriding action icons

* Fix formatting issues

* Add missing exports in material library and add copyWith method in ActionButtonIconsData

* Move all action buttons, and icons to action_buttons.dart

* Rename actionButtonIcons to actionIconTheme

* Refactor buttons in action_buttons.dart to extend a private class for common implementation

* Refactor icons in action_buttons

* Fix docs in action_buttons_theme

* Fix #107646 always use 'Icons.arrow_back' as a back_button icon in web

* Update documentation for action buttons and add style parameter to every action button

* Fix analyzer warnings

* Add missing style argument in IconButton of _ActionButton

* Add tests for action buttons, action icon theme, drawer buttons, and back buttons

* Add example (+test) for action icon button's action icon theme in examples/api

* Fix analysis errors

* Add missing license header in action_icon_theme.0.dart

* Fix deprecation notice in theme_data.dart

* Update theme data tests for actionIconTheme

* Remove iconSize parameter from ActionButtons and update docs

* Fix failing tests

* Update button color during backbutton tests to red

* Fix analytics issues

* Fix format
2023-02-22 09:22:44 -08:00
Ricardo Amador d816e72f07
Do not swallow the error from the licenses acceptance (#121243) 2023-02-22 08:55:08 -08:00
gaaclarke 4c25587b71
Added negative test and blur test to the wide gamut tests. (#120914)
* Added negative test and blur test to the wide gamut tests.

* switched back to dstOver

* fixed blur test

* analysis warnings

* analyzer
2023-02-22 00:10:25 +00:00
suragch dad9eb21f9
fix spelling typo (#120062)
* fix spelling typo

* _index not nullable

This address the comment here: https://github.com/flutter/flutter/pull/120062#issuecomment-1421424676
2023-02-21 23:16:23 +00:00
Jessica Pereira aa29358c5e
Fix license page rtl (#120497)
* fix license page rtl

* fix editor spacings, tests to lateral view

* fix defaultSize and setSurfaceSize

* add validation for packageList position

* fix spacing

* simplify align
2023-02-21 21:54:39 +00:00
Kate Lovett c6e1a4dc9a
Fix formatting (#121167) 2023-02-21 21:34:19 +00:00
engine-flutter-autoroll 7d497ce887
3aa112c75 Fix documentation of FlEngineOnPreEngineRestartHandler (flutter/engine#39759) (#121168) 2023-02-21 21:16:37 +00:00
David Iglesias a463bb82c4
[tool][web] Makes flutter.js more G3 friendly. (#120504)
* Allow any JS file in flutter loader.

* Nag only if service worker API is completely unavailable.

* Add info about Secure Contexts if that may be the reason why serviceworker is not available.

* Update sanity test.

* If service worker settings are null, do not even check if the API is available.
2023-02-21 20:51:37 +00:00
engine-flutter-autoroll 06ccf55454
Roll Flutter Engine from c3d9c30f3e09 to 40f60b92ba17 (2 revisions) (#121163)
* 068670a1f Roll Dart SDK from 12aec0627d0a to 0db7573c6b70 (2 revisions) (flutter/engine#39774)

* 40f60b92b Roll Skia from a16472080754 to 22b594afb4d3 (2 revisions) (flutter/engine#39773)
2023-02-21 20:23:18 +00:00
engine-flutter-autoroll 1f03825f30
Roll Flutter Engine from aa526b68fc1b to c3d9c30f3e09 (2 revisions) (#121158)
* 5b00a9579 Roll Skia from 2f05923f825e to a16472080754 (18 revisions) (flutter/engine#39772)

* c3d9c30f3 [Windows] Mark move-only classes as such (flutter/engine#39738)
2023-02-21 19:32:18 +00:00
stuartmorgan c564007f94
Switch analysis to flutter/packages (#120908)
In preparation for the merge of flutter/plugins into flutter/packaegs,
update the cross-repo analysis to flutter/packages rather than
flutter/plugins.

The flutter_plugins.version file is left intentionally for now to avoid
issues with the roller; it will be removed when the roller has been
updated to roll the other repository.
2023-02-21 14:26:08 -05:00
gaaclarke bd5e8db3a3
Turned off bringup for wide gamut color tests. (#120918) 2023-02-21 18:53:11 +00:00
Kate Lovett 09518ac725
Remove single axis assertion (#120738) 2023-02-21 18:05:07 +00:00
Kate Lovett 4acbe9706f
Remove alternate axis assertion from StretchingOverscrollIndicator (#120734)
* remove axes assertion

* Update packages/flutter/lib/src/widgets/overscroll_indicator.dart
2023-02-21 18:05:04 +00:00
Enguerrand ARMINJON 6259b690f6
feature/clean-a-specific-scheme: Add this-scheme new flag for clean command (#116733)
Co-authored-by: Enguerrand_ARMINJON_MAC_2 <earminjon@sqli.com>
2023-02-21 17:35:13 +00:00
Mouad Debbar 902d86e09c
[web] Unify line boundary expectations on web and non-web (#121006)
* [web] Temporarily disable a line boundary test

* [web] Unify line boundary expectations on web and non-web
2023-02-21 17:28:13 +00:00
Mateus Felipe C. C. Pinto ebbc94bc2b
allow passing --file-reporter option to test running refs #69425 (#120716)
* allow passing --file-reporter option to test running refs #69425

* Add trailing comma to help to meet style requirements

* Add space between tests for clarity

---------

Co-authored-by: daniel-v <dvarga@skawa.hu>
2023-02-21 17:24:11 +00:00
engine-flutter-autoroll 23df770860
34a681353 [local_auth] Add Android theme compatibility documentation (flutter/plugins#6875) (#121144) 2023-02-21 17:01:09 +00:00
Andrew Kolos e3db0488ad
Speed up first asset load by using the binary-formatted asset manifest for image resolution (#118782)
* add asset manifest bin loading and asset manifest api

* use new api for image resolution

* remove upfront smc data casting

* fix typecasting issue

* remove unused import

* fix tests

* lints

* lints

* fix import

* fix outdated type name

* restore AssetManifest docstrings

* update test

* update other test

* make error message for invalid keys more useful
2023-02-21 16:05:12 +00:00
engine-flutter-autoroll 7175de4fe6
aa526b68f Roll Fuchsia Mac SDK from X3ES-2nMPaH13KIAI... to 25mb67G0L_sZ_OQCC... (flutter/engine#39769) (#121136) 2023-02-21 12:43:40 +00:00
engine-flutter-autoroll e5619b9357
35aeeec58 Roll Dart SDK from a1401ef3d0ec to 12aec0627d0a (1 revision) (flutter/engine#39767) (#121114) 2023-02-21 03:38:23 +00:00