Commit graph

17100 commits

Author SHA1 Message Date
Kate Lovett 76b21d2867 Refactor SliverFillRemaining (#47379) 2020-01-07 12:08:02 -08:00
Sam Rawlins 5005824763 Mark unused but desired private constructors as such (#46200) 2020-01-07 12:03:03 -08:00
Kate Lovett f974c295b5 SliverFadeTransition (#45950) 2020-01-07 11:58:01 -08:00
Alexandre Ardhuin 4f9b6cf017
enable lint prefer_final_in_for_each (#47724) 2020-01-07 16:32:04 +01:00
Jonah Williams fa337f5922
[flutter_tool] Enable globals technical debt benchmark (#48266) 2020-01-06 16:44:12 -08:00
Dan Field d73b3682c9
Fix state in test (#48269) 2020-01-06 16:33:31 -08:00
Dan Field 79c4c38cc9 Make analyze once test not depend on test order or flutter create command (#48003) 2020-01-06 16:33:01 -08:00
Mouad Debbar f6a88d0309
Registering multiple transformed events should work (#48149) 2020-01-06 14:24:52 -08:00
Jonah Williams 2221a9f514
[flutter_tool] Cache the path context in the flutter tool (#48250)
recomputing the path context in the getter violates flutter repo style guide and adds a small but measurable overhead to all path operations
2020-01-06 13:57:13 -08:00
Jonah Williams 53f98c98d9
update gitignore and xcode changes to macOS project for flutter gallery (#48251) 2020-01-06 13:56:42 -08:00
Jenn Magder 1da96a9cdf Add @christopherfujino as owner of dev/ci (docker) (#48261) 2020-01-06 13:55:03 -08:00
Dan Field ea799d97f4
.. (#48263) 2020-01-06 13:30:21 -08:00
Ben Konyi a0e5621956
Added showCheckboxColumn parameter to DataTable and PaginatedDataTable (#47552)
`showCheckboxColumn` will determine whether or not selectable rows in
DateTable or PaginatedDataTable will contain a leading CheckBox.
2020-01-06 16:29:36 -05:00
Jacob MacDonald c3f590a872
update dependencies for flutter_tool (#48260) 2020-01-06 13:08:06 -08:00
Jonah Williams ee7a37f1d3
[flutter_tools] Ensure that global variables are easily identifiable (#47398) 2020-01-06 11:04:20 -08:00
Dan Field 19c7550540 fix mockStopWatch creation (#48098) 2020-01-06 11:03:01 -08:00
神楽坂花火 80ee2ff04f Add Border.symmetric constructor (#47523) 2020-01-06 09:48:02 -08:00
Phil Quitslund 7fee0c52d3 mark widget == and hashCode as nonVirtual (#46900) 2020-01-06 09:43:02 -08:00
engine-flutter-autoroll 301b09f46e
3851981b8 Roll fuchsia/sdk/core/mac-amd64 from Vk6uT... to Kom_K... (flutter/engine#15142) (#48244)
cbdc7bde22...3851981b86

git log cbdc7bde224c..3851981b863a --first-parent --oneline
2020-01-04 skia-flutter-autoroll@skia.org Roll fuchsia/sdk/core/mac-amd64 from Vk6uT... to Kom_K... (flutter/engine#15142)


If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC franciscojma@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
2020-01-06 12:39:12 -05:00
Alexandre Ardhuin 1fc43d9330
add key to constructors of public widgets (#47884)
* add key to constructors of public widgets

* fix a test

* fix a test
2020-01-06 17:41:54 +01:00
engine-flutter-autoroll 2ae5832164
cbdc7bde2 Roll src/third_party/skia 7ac038f302f2..6791ee2f8059 (20 commits) (flutter/engine#15141) (#48163)
eb139936eb...cbdc7bde22

git log eb139936eb2c..cbdc7bde224c --first-parent --oneline
2020-01-04 skia-flutter-autoroll@skia.org Roll src/third_party/skia 7ac038f302f2..6791ee2f8059 (20 commits) (flutter/engine#15141)


If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC franciscojma@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
2020-01-06 11:30:12 -05:00
Jenn Magder 0aed0b61a1
Add newlines between plugin names in GitHub template (#46937) 2020-01-03 17:53:54 -08:00
Shi-Hao Hong fa1ebab88e
Added API docs on opening a Scaffold's drawer programmatically (#48152)
* Added docs on how to set drawer to open only programmatically
2020-01-03 15:20:48 -08:00
LongCatIsLooong adc6482784
Implement CupertinoDatepicker time/dateTime constraints (#44628) 2020-01-03 14:50:41 -08:00
engine-flutter-autoroll a3bbdfb23a
eb139936e [web] Fix right click issues (flutter/engine#15103) (#48143)
5858519139...eb139936eb

git log 5858519139c2..eb139936eb2c --first-parent --oneline
2020-01-03 mouad.debbar@gmail.com [web] Fix right click issues (flutter/engine#15103)


If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC franciscojma@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
2020-01-03 16:19:11 -05:00
LongCatIsLooong 7511d8c06a
fix MediaQuery override in CupertinoDatePicker (#48001) 2020-01-03 11:05:50 -08:00
Devon Carew c924f499f5
ignore a (potentially) unused import in generated code (#47593) 2020-01-03 11:04:03 -08:00
creativecreatorormaybenot b383bdfd1f Initial (#47831) 2020-01-03 10:53:32 -08:00
engine-flutter-autoroll 9195f81fb7
Roll engine d35a4b300877..5858519139c2 (3 commits) (#48139)
d35a4b3008...5858519139

git log d35a4b300877..5858519139c2 --first-parent --oneline
2020-01-03 skia-flutter-autoroll@skia.org Roll src/third_party/dart 05e70d5b38cb..2f57602411b3 (44 commits) (flutter/engine#15100)
2020-01-03 skia-flutter-autoroll@skia.org Roll fuchsia/sdk/core/linux-amd64 from AVtRQ... to MwGkB... (flutter/engine#15110)
2020-01-03 skia-flutter-autoroll@skia.org Roll fuchsia/sdk/core/mac-amd64 from zkzoZ... to Vk6uT... (flutter/engine#15104)


If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC franciscojma@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
2020-01-03 13:43:11 -05:00
Shi-Hao Hong 62e436f049
Implement AlertDialog.actionsPadding and AlertDialog.buttonPadding (#47709)
* Implement AlertDialog.actionsPadding and AlertDialog.buttonPadding
2020-01-03 08:18:21 -08:00
Dan Field 7b69d137c8 reset state between runs of devFS tests (#48101) 2020-01-03 08:18:02 -08:00
Dan Field d7c347f027 make pub get test shufflable (#48095) 2020-01-03 08:13:03 -08:00
engine-flutter-autoroll 628e8543f8
Roll engine fa05d367add3..d35a4b300877 (4 commits) (#48131)
fa05d367ad...d35a4b3008

git log fa05d367add3..d35a4b300877 --first-parent --oneline
2020-01-03 skia-flutter-autoroll@skia.org Roll src/third_party/skia 107c66669d37..7ac038f302f2 (30 commits) (flutter/engine#15102)
2020-01-02 skia-flutter-autoroll@skia.org Roll src/third_party/dart b52d264f5b2f..05e70d5b38cb (17 commits) (flutter/engine#15085)
2020-01-02 skia-flutter-autoroll@skia.org Roll fuchsia/sdk/core/mac-amd64 from iImpF... to zkzoZ... (flutter/engine#15086)
2020-01-02 skia-flutter-autoroll@skia.org Roll fuchsia/sdk/core/linux-amd64 from sxapd... to AVtRQ... (flutter/engine#15083)


If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC franciscojma@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
2020-01-03 11:12:12 -05:00
Dan Field 5ff7225450 fix io_test (#48097) 2020-01-02 19:53:02 -08:00
Angjie Li 9df1790f24 Flutter Web Driver Support (#47890) 2020-01-02 19:48:01 -08:00
chunhtai 57a93419b4
EditableText should not update textinput style when the textinput is … (#47904) 2020-01-02 16:19:52 -08:00
Francisco Magdaleno a46d1791fc
Reland "Revert "Add visual density to the gallery options (#46090)"... (#47702)" (#48094)
This reverts commit e46671f323.
2020-01-02 15:50:59 -08:00
Jenn Magder dc99d61e5d Remove simulator arch in Profile and Release, App.xcframework (#48002) 2020-01-02 13:03:01 -08:00
Jenn Magder a6c3ffe10c Allow Xcode project Info.plist to be moved (#47993) 2020-01-02 12:03:02 -08:00
engine-flutter-autoroll c3406914a8
Roll engine bdc9708d235e..fa05d367add3 (4 commits) (#48077)
bdc9708d23...fa05d367ad

git log bdc9708d235e..fa05d367add3 --first-parent --oneline
2020-01-02 skia-flutter-autoroll@skia.org Roll src/third_party/skia c65d0069ec56..107c66669d37 (4 commits) (flutter/engine#15088)
2019-12-30 skia-flutter-autoroll@skia.org Roll src/third_party/skia 7c095dc67ce6..c65d0069ec56 (9 commits) (flutter/engine#15084)
2019-12-30 skia-flutter-autoroll@skia.org Roll src/third_party/skia 5a2f962313a5..7c095dc67ce6 (6 commits) (flutter/engine#15067)
2019-12-28 skia-flutter-autoroll@skia.org Roll src/third_party/dart c547f5d933e5..b52d264f5b2f (19 commits) (flutter/engine#14827)


If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC franciscojma@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
2020-01-02 15:02:12 -05:00
Dan Field 24f39d40a4 Revert "Revert "Add many more global analyses. (#47875)" (#48080)" (#48081)
This reverts commit 04ea3183ce.
2020-01-02 11:47:28 -08:00
Francisco Magdaleno 04ea3183ce
Revert "Add many more global analyses. (#47875)" (#48080)
This reverts commit e768c92fbc.
2020-01-02 09:25:59 -08:00
Ian Hickson e768c92fbc
Add many more global analyses. (#47875)
* Update packages.

* Add many more global analyses.

* Catch trailing spaces and trailing newlines in all text files.
  Before we were only checking newly added files, but that means we
  missed some.

* Port the trailing spaces logic to work on Windows too.

* Correct all the files with trailing spaces and newlines.

* Refactor some of the dev/bots logic into a utils.dart library.
  Notably, the "exit" and "print" shims for testing are now usable
  from test.dart, analyze.dart, and run_command.dart.

* Add an "exitWithError" function that prints the red lines and
  then exits. This is the preferred way to exit from test.dart,
  analyze.dart, and run_command.dart.

* More consistency in the output of analyze.dart.

* Refactor analyze.dart to use the _allFiles file enumerating logic
  more widely.

* Add some double-checking logic to the _allFiles logic to catch
  cases where changes to that logic end up catching fewer files
  than expected (helps prevent future false positives).

* Add a check to prevent new binary files from being added to
  the repository. Grandfather in the binaries that we've already
  added.

* Update all the dependencies (needed because we now import crypto in
  dev/bots/analyze.dart).
2019-12-30 17:12:19 -08:00
Kate Lovett 4fbef2a4a9
Revert "Testing tryjob triage (#47893)" (#47985)
This reverts commit 659dc8129d.
2019-12-30 13:09:14 -08:00
Shi-Hao Hong 173322dc78
Support preferred locales for gen_l10n (#47845)
* Add preferred-supported-locales option to gen_l10n.dart executable
2019-12-30 11:22:01 -08:00
Kate Lovett 659dc8129d
Testing tryjob triage (#47893) 2019-12-30 09:24:47 -08:00
Devon Carew 43a8c24344
fix an analysis ignore for the missing_required_param hint (#47956) 2019-12-29 12:28:57 -08:00
engine-flutter-autoroll 841924e161
Roll engine 5a730c60d3ce..bdc9708d235e (25 commits) (#47926)
5a730c60d3...bdc9708d23

git log 5a730c60d3ce..bdc9708d235e --first-parent --oneline
2019-12-28 franciscojma86@gmail.com Revert "Use ELF for Dart AOT snapshots on Fuchsia. (#13896)" (flutter/engine#14823)
2019-12-27 skia-flutter-autoroll@skia.org Roll src/third_party/skia 89bf1547f3aa..5a2f962313a5 (16 commits) (flutter/engine#14825)
2019-12-27 skia-flutter-autoroll@skia.org Roll fuchsia/sdk/core/linux-amd64 from ikxBh... to sxapd... (flutter/engine#14821)
2019-12-27 skia-flutter-autoroll@skia.org Roll fuchsia/sdk/core/mac-amd64 from IEPKx... to iImpF... (flutter/engine#14817)
2019-12-27 skia-flutter-autoroll@skia.org Roll src/third_party/dart 94a4f6415e6c..c547f5d933e5 (9 commits) (flutter/engine#14812)
2019-12-27 skia-flutter-autoroll@skia.org Roll src/third_party/skia f2d522a3f434..89bf1547f3aa (4 commits) (flutter/engine#14814)
2019-12-26 skia-flutter-autoroll@skia.org Roll src/third_party/dart 232a171a0b1c..94a4f6415e6c (8 commits) (flutter/engine#14808)
2019-12-26 skia-flutter-autoroll@skia.org Roll src/third_party/skia 07d744fb8a53..f2d522a3f434 (4 commits) (flutter/engine#14807)
2019-12-26 skia-flutter-autoroll@skia.org Roll src/third_party/skia 05eb83be171c..07d744fb8a53 (3 commits) (flutter/engine#14806)
2019-12-26 skia-flutter-autoroll@skia.org Roll fuchsia/sdk/core/linux-amd64 from v3R8A... to ikxBh... (flutter/engine#14802)
2019-12-26 skia-flutter-autoroll@skia.org Roll src/third_party/dart 75fc15c7e186..232a171a0b1c (4 commits) (flutter/engine#14803)
2019-12-26 skia-flutter-autoroll@skia.org Roll fuchsia/sdk/core/mac-amd64 from ZA31z... to IEPKx... (flutter/engine#14702)
2019-12-26 skia-flutter-autoroll@skia.org Roll src/third_party/skia 3d3150c89c5f..05eb83be171c (3 commits) (flutter/engine#14800)
2019-12-24 skia-flutter-autoroll@skia.org Roll src/third_party/skia a2d7225c0fc1..3d3150c89c5f (1 commits) (flutter/engine#14680)
2019-12-24 skia-flutter-autoroll@skia.org Roll src/third_party/dart 8736fec094bb..75fc15c7e186 (6 commits) (flutter/engine#14679)
2019-12-24 liyuqian@google.com Run and collect benchmarks (flutter/engine#14556)
2019-12-23 skia-flutter-autoroll@skia.org Roll src/third_party/dart 4a639e8df261..8736fec094bb (11 commits) (flutter/engine#14678)
2019-12-23 skia-flutter-autoroll@skia.org Roll src/third_party/skia ac29f1342fd2..a2d7225c0fc1 (5 commits) (flutter/engine#14677)
2019-12-23 nurhan@google.com fix selection issue (flutter/engine#14604)
2019-12-23 skia-flutter-autoroll@skia.org Roll fuchsia/sdk/core/linux-amd64 from TUoVa... to v3R8A... (flutter/engine#14670)
2019-12-23 skia-flutter-autoroll@skia.org Roll src/third_party/dart cfca5ea9f2e9..4a639e8df261 (7 commits) (flutter/engine#14671)
2019-12-23 skia-flutter-autoroll@skia.org Roll src/third_party/skia 6ec826085b2a..ac29f1342fd2 (1 commits) (flutter/engine#14672)
2019-12-23 skia-flutter-autoroll@skia.org Roll fuchsia/sdk/core/mac-amd64 from IZ278... to ZA31z... (flutter/engine#14675)
2019-12-21 skia-flutter-autoroll@skia.org Roll src/third_party/dart 1db1a837f8c9..cfca5ea9f2e9 (2 commits) (flutter/engine#14667)
2019-12-21 skia-flutter-autoroll@skia.org Roll src/third_party/skia 2723af6a6d43..6ec826085b2a (3 commits) (flutter/engine#14665)


If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC cbracken@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
2019-12-28 14:50:12 -05:00
神楽坂花火 b28dd0c296 Reland "Add brightness to CupertinoNavigationBar (fixes #46216) (#47521)" (#47855) 2019-12-27 18:33:01 -08:00
Jim Graham cf00b969a1
Fix semantics and transition-perf tests to parse new event format. (#47899) 2019-12-27 18:15:49 -08:00