Commit graph

9718 commits

Author SHA1 Message Date
Greg Spencer 765191e7b4
Adding minzip to packaging steps for Windows (#13679)
This adds our self-compiled copy of the MinGit executable (built from the flutter/git repo) to the archive when building an archive for Windows.

I also tweaked the internal API for prepare_package.dart so that there's a single entry point to build an archive.
2017-12-20 15:35:53 -08:00
Hans Muller 83134cd39f
Added find.ancestor to CommonFinders (#13691) 2017-12-20 15:03:58 -08:00
Michael Goderbauer 95aeb05ced
Roll engine to 937bde8f98e64aa574f77049bc52e9c8e862c82c (#13709) 2017-12-20 14:32:22 -08:00
Ian Hickson b1c870b312
Reenable fade transition for Material page transition (#13048) (#13680)
Fixes #12877 by reverting #9472
2017-12-20 13:52:01 -08:00
Victor Choueiri ba58111b7b Add .vscode/ to .gitignore template (#13697)
Adds .vscode/ to the .gitignore rules generated on flutter create.
2017-12-20 12:43:22 -08:00
Yegor 81d4834278
support increase and decrease SemanticsActions in time picker (#13689)
* support increase and decrease SemanticsActions in time picker

* test roll over
2017-12-20 10:25:33 -08:00
Erik Corry 7766b2a196 Roll Dart to 718bda0c9 (#13698) 2017-12-20 15:13:34 +01:00
Erik Corry a96487929b Roll Flutter engine incl. new Skia. (#13696) 2017-12-20 13:28:40 +01:00
Mikkel Nygaard Ravn 36bcdc4c7e
Fix Android templates (#13681) 2017-12-20 10:50:40 +01:00
Michael Goderbauer 39c2521f29
Update project.pbxproj of flutter_gallery (#13678) 2017-12-19 16:59:35 -08:00
Michael Goderbauer 52ebff721a
selected ListTile is selected (#13676)
* selected ListTile is selected

* review comment

* analyzer fix
2017-12-19 16:39:56 -08:00
Hans Muller 31418570a2
Gen localization classes intead of a big map (#13653)
* Gen localization classes intead of a big map

* tighten up the newlines so that std output matches file output

* restore locale sorting
2017-12-19 14:02:22 -08:00
Alan Russian 30720bd148 Change async stubbing to use thenAnswer. (#13521)
* Change async stubbing to use thenAnswer.

Mockito now prohibits calling thenReturn with Futures and Streams. dart-lang/mockito#79

* Update all Mockito deps to 3.0.0.

* Revert "Update all Mockito deps to 3.0.0."

This reverts commit e8ab9d37c3.

I did not correctly update the mockito dep, and there's no easy way to update to 3.0 alpha right now.

* Change thenAnswer((_) => to thenAnswer((invocation) =>

* Add Invocation type to thenAnswer lambdas
2017-12-19 13:13:57 -08:00
Ian Hickson 78ff7707e1
Fix niggling PaginatedDataTable bugs (#13556)
Prevent header from thinking it can wrap and then overflowing.

Fix default footer string which lost its colon (localized values are fine).

Make the "rows per page" drop-down include at least one value even when the table lacks many items. (Previously it would assert if your table was too short.)

Make the footer scrollable.

Fix some todos and improve some debug output.

Tests for much of the above.
2017-12-19 12:39:48 -08:00
Yegor b5eac0422a
use different delimiter for generated code; print generated code into mismatch description (#13667) 2017-12-19 11:45:29 -08:00
Michael Goderbauer e6f20eb95c
IconButton is a button, semantically (#13674)
* IconButton is a button, semantically

* fix datepicker test
2017-12-19 11:33:23 -08:00
Hans Muller 12f405578f
Added five new locales to flutter_localizations (#13621) 2017-12-19 11:09:50 -08:00
xster ce75911f1a
Add flutter_assets and *.class to gitignore (#13664) 2017-12-19 10:21:59 -08:00
Chris Bracken e478a5472d
Apply media padding in Gallery Pesto demo (#13668)
Applies horizontal safe area insets to the Pesto demo in the Gallery.
This is to support the iPhone X sensor housing notch and other similarly
creative display features when in landscape orientation.
2017-12-19 09:15:26 -08:00
Greg Spencer 37f216bfab
Add support for 7Zip to the packaging script. (#13659)
A modern version of 7Zip (7za.exe) is now installed on the bots, this makes use of that.
2017-12-18 14:40:29 -08:00
Mikkel Nygaard Ravn d2d86e35c5
Bump test timeout threshold (#13661) 2017-12-18 23:04:07 +01:00
Mikkel Nygaard Ravn e9ba0dd4ba
Switch from app.flx to flutter_assets (#13656) 2017-12-18 22:09:49 +01:00
Chris Bracken b771294c16
Use idevice_id for devicelab iOS device lookups (#13652)
This replaces the use of ideviceinfo (whose output was then filtered for
device IDs) with an invocation idevice_id -l, which returns the list
directly, one per line.
2017-12-18 11:10:18 -08:00
Sarah Zakarias 68bf4b3c62 Remove app.flx and add flutter_assets to project.pbxproj of all example apps (#13649) 2017-12-18 20:08:30 +01:00
Sarah Zakarias 73552ecae2 Remove app.flx on iOS (#13648) 2017-12-18 18:58:44 +01:00
Chris Bracken c7ea97f2bb
Use idevice_id for devicelab iOS device listing (#13624)
This patch migrates iOS device listing from using Xcode instruments to
using the libimobiledevice tools idevice_id and ideviceinfo.

ideviceinfo was previously incompatible with iOS 11 physical devices;
this has now been fixed.

In 58fe8237d2 flutter_tools migrated from
libimobiledevice-based device listing on iOS to using Xcode instruments
to work around the lack of support for iOS 11. Using instruments entails
several downsides, including a significantly higher performance hit, and
leaking hung DTServiceHub processes in certain cases when a simulator is
running, necessitating workarounds in which we watched for, and cleaned
up leaked DTServiceHub processes. This patch returns reverts the move to
instruments now that it's no longer necessary.

This reverts commit 58fe8237d2.
2017-12-18 09:46:33 -08:00
Sarah Zakarias 2ef379ad12
Remove app.flx from apk (#13647) 2017-12-18 14:33:35 +01:00
Chris Bracken e85d099229
Apply media padding to Contacts demo (#13628)
Applies horizontal safe area insets to the Contacts demo in the Gallery.
This is to support the iPhone X sensor housing notch and other similarly
creative display features when in landscape orientation.
2017-12-15 19:10:18 -08:00
xster 2e1b0a7fd2
update xcode project (#13587) 2017-12-15 19:02:53 -08:00
Chris Bracken 7fb78523e9
Require Xcode 9.0 or later for iOS builds (#13608) (#13622)
We now require Xcode 9.0, which ships with the iOS 11 SDK, for iOS
builds. This change does not affect the minimum supported iOS deployment
target, which remains iOS 8.

The iOS 11 SDK adds support for safe area insets, which model the status
bar, iPhone X home indicator, and symmetric horizontal insets to avoid
the iPhone X sensor housing when in landscape mode.

This re-lands flutter/flutter#13608 now that the devicelab Macs have
been updated to Xcode 9.
2017-12-15 18:13:10 -08:00
Ian Hickson 8e5d77d3fa
Make animating opacity cheaper. (#13583)
No need to update the compositing bits all the time.
2017-12-15 18:10:36 -08:00
Chris Bracken 813be533cd
Apply media padding to snackbar contents (#13623)
Applies any additional bottom, left, and right media padding inside the
snackbar, if present. This accounts for the iPhone X home indicator
widget and horizontal padding for the sensor housing notch in landscape
orientation.
2017-12-15 17:55:25 -08:00
Greg Spencer a556ad095d
Switch to using XZ instead of BZip2 for tar archives. (#13620)
XZ is about 50MB smaller, and it works on both Mac and Linux.
2017-12-15 16:40:49 -08:00
xster a43be998ec
Split one CustomPainter doc paragraph to bullet points (#13590)
* split doc paragraph

* specify shouldRepaint argument nullability

* review
2017-12-15 15:56:28 -08:00
Chris Bracken f39a847c8b
Apply media padding in UserAccountsDrawerHeader (#13619)
Applies top, left, right media padding to avoid placing content within
the safe area insets (e.g. iPhone X notch area in landscape
orientation).
2017-12-15 15:52:19 -08:00
Greg Spencer f00c90232c
Add a Dart script to prepare the flutter repo for packaging. (#13548)
This is the first step in a two-step process of moving the package preparation step from a recipe in chrome_infra to a dart script in the flutter repo. This will make it easier to make changes to the process. The second step is to change the infra recipe to call this script.

In addition, I added a step to the packaging process to run flutter create for each type of template so that any pub dependencies of the templates get added to the cache that gets packaged (and thus users can run flutter create --offline and have it work).

Note that the actual packaging into a "tar" or "zip" file now happens here, so a developer could actually run this script on their machine to create a package.
2017-12-15 15:01:30 -08:00
Ian Hickson e65c882e97
Provide a navigatorKey property on MaterialApp and WidgetsApp (#13591)
This lets people poke at navigators without having to get their
BuildContext from a build function or State first.
2017-12-15 14:41:52 -08:00
Chris Bracken 2c0c9ba9e5
Apply media padding in complex layout benchmark drawer header (#13610)
By default BoxScrollView (and hence ListView, which is a subclass)
padding is the media padding along its scroll axis in order to avoid
placing list items within areas where user interaction should be
minimised -- e.g. under the status bar, or in and around the iPhone X
notch in landscape mode.

In cases where a list item should occupy the padding area, developers
should set the ListView padding to EdgeInsets.zero so as not to pick up
the default media padding. For widgets inside the drawer that should
avoid safe areas, developers can add a SafeArea widget.
2017-12-15 12:46:35 -08:00
amirh 05dba60c63
keep recursing past directories with pubspec.yaml when gathering packages (#13573) 2017-12-15 12:21:03 -08:00
Chris Bracken 6728d4845d
Revert "Require Xcode 9.0 or later for iOS builds (#13608)" (#13612)
Our devicelab machines have not yet been upgraded to Xcode 9. Once this
has been done, I'll re-land this.

This reverts commit 0fac5f01a2.
2017-12-15 11:59:42 -08:00
Chris Bracken 0fac5f01a2
Require Xcode 9.0 or later for iOS builds (#13608)
We now require Xcode 9.0, which ships with the iOS 11 SDK, for iOS
builds. This change does not affect the minimum supported iOS deployment
target, which remains iOS 8.

The iOS 11 SDK adds support for safe area insets, which model the status
bar, iPhone X home indicator, and symmetric horizontal insets to avoid
the iPhone X sensor housing when in landscape mode.
2017-12-15 11:44:01 -08:00
Chris Bracken d8bfb3a99b
Apply media padding to Gallery Material Design demos (#13593)
Applies media padding (e.g. iPhone X safe area insets) to the Material Design demos in the Gallery.

Covers the following demos:
* Buttons (via the TabbedComponentDemoScaffold change)
* Cards
* Expansion panels
* Grid list
* Icons
* Images (via the TabbedComponentDemoScaffold change)
* Page Selector
* Progress Indicator
* Scrollable tabs
* Selection controls (via the TabbedComponentDemoScaffold change)
* Snack bar
* Tabs
* Text fields
* Tooltips

Fixes #13594
2017-12-15 10:13:30 -08:00
Martin Kustermann d9edab84e4
Roll engine to d945976b04cc82d32c9691dae1fc8e4955222b3d (#13605) 2017-12-15 16:03:49 +01:00
Yegor 235b64ed2f
make date picker accessible (#13502)
* make date picker accessible

* make test file lookup location-independent

* address some comments

* always wrap in IgnorePointer

* no bitmasks for flags and actions

* recommend List<*>
2017-12-14 20:38:39 -08:00
Chris Bracken dc9c95375f
Apply media padding in Color, Typography demos (#13592) 2017-12-14 18:32:41 -08:00
Chris Bracken dd943fefe0
Apply media padding in Cupertino Navigation demo (#13585)
Adds safe areas around:
1. The body of the colour swatch view (tab 1)
2. The chat header (tab 2)
3. The chat bubbles (tab 2)
4. The 'Sign In' launcher button (tab 3)
2017-12-14 17:38:48 -08:00
Chris Bracken 8a77036b35
Center Shrine demo title with centerTitle (#13586)
Rather than use a Center widget, center the title using AppBar's
centerTitle property. This ensures the title is horizontally centred
with respect to the screen rather than centred in the space between the
leading and trailing app bar widgets, which are asymmetrical in Shrine.
2017-12-14 16:53:30 -08:00
Chris Bracken 5bbcf6d4fc
Apply T, L, R media padding in Cupertino nav bar (#13580)
Applies top, left, right media padding for iOS safe area insets. This is
a follow-up to the media padding applied to large titles in
flutter/flutter#13550.
2017-12-14 15:26:16 -08:00
Ian Hickson c28121eeca
Allow the ErrorWidget to be overridden. (#13578)
Fixes https://github.com/flutter/flutter/issues/10695
2017-12-14 15:05:41 -08:00
Michael Goderbauer f9cf5a1f3d
Add a11y label to modal barrier (#13543) 2017-12-14 15:03:51 -08:00