Commit graph

21232 commits

Author SHA1 Message Date
Jenn Magder 351ccf7eaf
Better error message when export options plist does not a fix (#68826) 2020-10-22 23:28:51 -07:00
Jenn Magder aea070790f
Turn off CLANG_WARN_QUOTED_INCLUDE_IN_FRAMEWORK_HEADER in CocoaPod targets (#68817) 2020-10-22 22:02:04 -07:00
Cyp 45e02daf22
Correctly handle centerSlice with resoultion-aware assets. (#68325) 2020-10-22 21:57:03 -07:00
Jonah Williams 1edec6fc20
Revert "[flutter_tools] refactor drive launch into separate service, split by mobile+desktop and web (#68451)" (#68845)
This reverts commit 2e75f52ae4.
2020-10-22 19:39:33 -07:00
Jonah Williams b25ce5b16c
Revert "Fix a multiple pointers bug (#68587)" (#68841)
This reverts commit bde85ea3bb.
2020-10-22 19:16:08 -07:00
xubaolin bde85ea3bb
Fix a multiple pointers bug (#68587)
* Fix mutiple pointers bug

* Add unit test case

* Remove unnecessary map clone
2020-10-22 16:09:47 -07:00
xubaolin 95909c2a04
change TextEditingController.clear() behavior (#68775)
Fixes a bug where keyboard capitalization mode was exited when pressing clear.
2020-10-22 15:56:26 -07:00
Kate Lovett 8e8f61856a
Fix overscroll edge case that puts NestedScrollViews out of sync (#68644) 2020-10-22 15:37:06 -07:00
YeungKC c5c2b24a07
Fix floating behavior of long label and outline input border (#68727)
Corrects the space available to the label in an outlined text field
2020-10-22 15:36:06 -07:00
Alexander Brusher 099ae9b417
Re-enables tests previously failing due to new semantics flag. (#66916) 2020-10-22 15:32:03 -07:00
stuartmorgan 22c502e315
Add Windows build test (#68657)
Enables build_test for Windows. Currently only flutter_gallery has platform directories for the desktop platforms, so this will run only that build, but this will provide an end-to-end build test for Windows.

Other example/test projects can be brought online for Windows in the future just by adding the windows/ directory to the project.
2020-10-22 15:14:30 -07:00
Jonah Williams 2e75f52ae4
[flutter_tools] refactor drive launch into separate service, split by mobile+desktop and web (#68451)
Overhaul of flutter drive in order to deliver a better experience, namely:

flutter run and flutter drive now share more flags, so code paths that were previously only testable on run are now testable on drive.
Removes web-initialize-platform as this is no longer used
flutter drive correctly sets up a logger that shows native exceptions, by connecting to the vm service.
VM service connection now provides access to memory info without launching devtools (only for debug/profile mode)
Web changes

Passes on the one test in the repo, otherwise the webdriver code has been isolated as much as possible

Additional NNBD related bug fixes:

No longer passes --enable-experiment to the test script. (FYI @blasten ). earlier we might have assumed that the flutter gallery benchmarks would be migrated along side the app and flutter driver, but only the app under test needs to be migrated. The test scripts should never be run with the experiment.
2020-10-22 15:07:02 -07:00
xubaolin 1bd661f4d4
fix a widgetspan hittest bug (#68694) 2020-10-22 14:27:04 -07:00
Ian Hickson 6a434ab9ec
Fix grammar and writing style for some of the Router documentation (#68513) 2020-10-22 14:22:09 -07:00
Janice Collins dcc8ced8e4
Update to dartdoc 0.36.1 (#68791) 2020-10-22 14:13:50 -07:00
stuartmorgan 4ea6d3de93
Enable dev/bots/ build_tests for macOS (#68656)
Enables build_test for Windows, macOS, and Linux. Currently only
flutter_gallery has platform directories for the desktop platforms, so
this will run only that build, but this will provide an end-to-end build
test for all three desktop platforms.

Once this lands, other example/test projects can be brought online for
desktop platforms in the future just by adding the relevant platform
directories to the project.
2020-10-22 13:52:19 -07:00
stuartmorgan 3da995adec
Handle backspace in text fields (#68812)
Currently the framework handles delete, but not backspace, so embeddings
all have to implement backspace handling themselves. This eliminates
that inconsistency and allows simplified code in embeddings by adding
backspace handling.

It also fixes a bug uncovered in the delete handling where deleting a
selection would also delete the next character after the selection.
2020-10-22 13:51:07 -07:00
Jenn Magder f63d56e455
App.framework must support iOS 8 for older Flutter projects (#68729)
* App.framework must support iOS 8 for older Flutter projects

* Fix test
2020-10-22 13:50:54 -07:00
stuartmorgan 3ff334d68d
Add a missing include to the Linux plugin template (#68737)
The template uses strcmp (to check the received method), so should
include <cstring>
2020-10-22 13:50:39 -07:00
Jonah Williams 37470dfc0b
[devicelab] de-flake iOS launch (#68790)
* [devicelab] de-flake iOS launch
2020-10-22 13:37:57 -07:00
Jonah Williams 21ca1f9ba5
[flutter_tools] use --no-print-incremental-dependencies for non-resident and test compiles (#68678) 2020-10-22 13:34:59 -07:00
Dan Field 4af674285b
Move service extension to correct binding so images are repainted after enabling/disabling, update test (#68793)
* Move service extension to correct binding so images are repainted after enabling/disabling, update test

* Update binding.dart
2020-10-22 13:34:21 -07:00
Jonah Williams 37042fdb08
[flutter_tools] remove iOS screenshot on failure functionality (#68650)
* [flutter_tools] remove iOS screenshot on failure functionality

* remove all screenshot code
2020-10-22 13:34:07 -07:00
puelo 24d3999783
Generate RawKeyEvents for iOS 13.4+ (#65193)
* Added RawKeyEvent support for iOS

* Removed unused remnant

* added some missing keys

* Removed trailing whitespaces

* commit for build

* Added mapping names

* Made iOS keycodes generatable and collectable

* Fixed naming and formatting issues

* fixed raw_keyboard_test
2020-10-22 13:33:51 -07:00
Jenn Magder f877266139
Add CocoaPods sudo installation note (#68542)
* Add CocoaPods sudo installation note

* Refer to instructions
2020-10-22 13:33:35 -07:00
chunhtai 6cab3f6008
fix simple dialog introducing additional node for semantics label (#68804)
* fix simple dialog introducing additional node for semantics label

* add test
2020-10-22 13:33:17 -07:00
Michael Goderbauer dd2ea7c503
Migrate all of examples/layers to sound null safety (#68744) 2020-10-22 13:33:07 -07:00
Michael Goderbauer 8273b99294
Remove dartdoc checker exclusion for class and library files (#68726) 2020-10-22 13:32:55 -07:00
Jenn Magder 04657354f5
Build IPA command (#67781)
* Build IPA command

* xcarchive -> ipa
2020-10-22 13:32:51 -07:00
Michael Goderbauer 91478d96a8
Do not instantiate intermediate tabs during transition (#68124) 2020-10-22 13:32:47 -07:00
Jaime Blasco 52c715fe43
Add textSelectionControls to TextField etc. (#66785)
Enables custom text selection menus by allowing selectionControls to be passed to TextField et. al.
2020-10-22 13:31:51 -07:00
Jonah Williams 16029c3868
[null-safety] try updating snippets for null safety (#68723)
Add a language version so the snippets do not opt-in automatically.

Fixes #68719
2020-10-22 13:18:06 -07:00
Jonah Williams a655a1778d
[null-safety] swap tool unit tests to tester (#68733) 2020-10-22 13:17:31 -07:00
Jonah Williams 2783f8e2e1
Roll engine to defa8be2b10650dad50dfee9324ed8d16eeec13f (#68789) 2020-10-22 09:36:06 -07:00
engine-flutter-autoroll fe189baf34
f459a8661 Ensure root isolate create callback is invoked before the isolate is in the running phase. (flutter/engine#22041) (#68749) 2020-10-21 19:25:53 -07:00
engine-flutter-autoroll 5bfc576ca5
fc72bd2ad Plumb through Dart entrypoint arguments on the Linux embedder (flutter/engine#21933) (#68746) 2020-10-21 18:13:43 -07:00
engine-flutter-autoroll 753c9c9f45
1358f13c2 Run framework tests in sound null safety mode (flutter/engine#22038) (#68740) 2020-10-21 16:35:21 -07:00
Jacob MacDonald 78f05dfb9f
add sdk constraints where missing to prepare for nnbd flag flip (#68611) 2020-10-21 14:59:44 -07:00
Robert Ancell 16b9933d85
Disable header bar when not using GNOME Shell. (#68452)
Fixes https://github.com/flutter/flutter/issues/68253
2020-10-22 10:24:19 +13:00
Robert Ancell b200baebd7
Try the Wayland GDK backend, the engine now supports it (#66519)
* Try the Wayland GDK backend, the engine now supports it

* Update comment from review

* Just do default GTK behaviour
2020-10-22 09:38:11 +13:00
engine-flutter-autoroll 85bfbc8060
Roll Engine from c2c74ed7080a to 27184748130a (2 revisions) (#68722)
* 6e5d37609 Roll Dart SDK from 86242db30c23 to 874709e52a99 (1 revision) (flutter/engine#22023)

* 271847481 Roll Dart SDK from 874709e52a99 to a3d902d8598e (1 revision) (flutter/engine#22026)
2020-10-21 13:37:42 -07:00
Jacob Richman 0884236504
Fix assert due to VSCode passing in an isolateId as well as the expected args to setPubRootDirectories. (#68721) 2020-10-21 12:13:10 -07:00
Michael Goderbauer 42f3709a5a
Sound null safety for framework and flutter_test (#68642) 2020-10-21 10:09:11 -07:00
Justin McCandless 955e07461b
Revert "Fix text field label width on outline input border (#67736)" (#68672) 2020-10-21 08:52:03 -07:00
Janice Collins 4a59ee9c31
Updated dartdoc to 0.36.0 (#68641) 2020-10-21 08:47:02 -07:00
Zachary Anderson cbcd1321ed
Revert "enable unnecessary_string_escapes and use_raw_strings (#68302)" (#68714)
This reverts commit ae06c19a37.
2020-10-21 08:16:13 -07:00
Alexandre Ardhuin ae06c19a37
enable unnecessary_string_escapes and use_raw_strings (#68302) 2020-10-21 16:34:24 +02:00
engine-flutter-autoroll a4ac7cce82
Roll Engine from 6934f8aa311e to c2c74ed7080a (2 revisions) (#68682)
* b99d94f39 Roll Skia from 1c823674d957 to 2d2f82c00aeb (13 revisions) (flutter/engine#22015)

* c2c74ed70 Roll Dart SDK from 8be6a08153cc to 86242db30c23 (2 revisions) (flutter/engine#22018)
2020-10-20 21:46:59 -07:00
engine-flutter-autoroll 203a96f93f
Roll Engine from 8a5b42344581 to 6934f8aa311e (3 revisions) (#68676)
* 638c18236 [fuchsia] zx::vmar::map migration (flutter/engine#22003)

* 56f399a53 Revert "Define SK_VULKAN for clang-tidy runs (#21927)" (flutter/engine#22012)

* 6934f8aa3 Determine null-safety isolate flags for launches of the service isolate. (flutter/engine#22013)
2020-10-20 21:01:52 -07:00
Jacob Richman e5d7bab115
Fix null safety error in inspector service extensions taking a variable number of args. (#68661)
* Fix null safety error in inspector service extensions taking variable numbers of args.

Fixes https://github.com/flutter/flutter/issues/68627.
Also fix all inspector tests that do not rely on golden image functionality
so that they run with --enable-experiment=non-nullable. This verifies there
is test coverage to ensure there isn't a regression.

* Remove uses of dynamic.
2020-10-20 18:27:55 -07:00