Commit graph

3973 commits

Author SHA1 Message Date
Jonah Williams 73b6702dee
[flutter_tools] refactor iOS tests for Device.startApp into new file (#52854) 2020-03-18 17:43:25 -07:00
Jenn Magder ee845255de
Move XcodeProjectInterpreter to globals (#52847) 2020-03-18 15:55:09 -07:00
Jenn Magder e0ab6fc00c
Move outputPreferences to globals (#52846) 2020-03-18 15:54:26 -07:00
Jonah Williams 0274f170fb
[flutter_tools] have the tool print the current canvaskit mode when toggling (#52841) 2020-03-18 15:51:23 -07:00
Yegor 7b4c195f99
Fix web test flakiness; enable web golden tests (#52789)
* Fix web test flakiness; enable web golden tests

The fix is three-part:

- Only allow one test to load _and_ test at any point in time.
- Use a fresh Chrome instance for each test file.
- Increase Cirrus resources.

The first two changes only fix the "Unknown error loading" error, but not hanging tests. The resource increase also prevents hanging tests.

Other minor changes:

- Remove test batching (it's no longer necessary)
- Fix the Chrome class, which was using the wrong Completer.
2020-03-18 15:11:48 -07:00
Christopher Fujino 2d9902d9ac
Cleanup ios devices (#52568) 2020-03-18 12:51:01 -07:00
Zachary Anderson e8778da12c
[flutter_tools] Don't crash when analytics fails to initialize (#52775) 2020-03-18 10:00:14 -07:00
Jonah Williams 542feb4736
[flutter_tools] remove unused Snapshot.dart artifact and associated code (#52821) 2020-03-18 09:18:41 -07:00
Jonah Williams 46f0a5f7b5
[flutter_tools] Reland android device cleanup. (#52686) 2020-03-17 17:58:39 -07:00
Jonah Williams 90d6169678
[flutter_tools] refactor the IOSDevicePortForwarder and move tests out of devices_test.dart (#52772)
Updates the IOSDevicePortForwarder to no longer depend on context, or on an IOSDevice instance. Instead, it receives all necessary configuration through the constructor.

Moves the IOSDevicePortForwarder to a separate file.
2020-03-17 17:58:05 -07:00
Jonah Williams 6884086e5c
[flutter_tools] Update to latest dwds APIs (#51004)
Update to latest dwds APIs, moving back to dwds driven hot restart and enabling future work on expression evaluation.
2020-03-17 17:29:53 -07:00
gaaclarke 6990b8b2d3
Added the "trace-whitelist" flag to run. (#52556) 2020-03-17 16:42:20 -07:00
Jonah Williams f149eec31b
[flutter_tools] always initialize the resident runner from dill (#52497) 2020-03-17 16:37:06 -07:00
Jenn Magder 757b39ba99
Ignore fuchsia device-finder no device error (#52761) 2020-03-17 16:02:45 -07:00
Christopher Fujino 071d4eb2c8
explicitly catch ArgumentError, and add tests (#52757) 2020-03-17 12:55:57 -07:00
Jonah Williams a7011c4817
[flutter_tools] don't force service worker cache files to be absolute (#52606) 2020-03-17 10:17:03 -07:00
Jenn Magder 93a6057c42
Add SDK location unit tests (#52691) 2020-03-16 16:02:22 -07:00
Jenn Magder 2f216ceee5
Add timeout flag to devices command, pipe through discovery (#51678) 2020-03-16 14:15:00 -07:00
Jonah Williams 028b7dced1
[flutter_tools] remove context from WebWorkflow (#52613) 2020-03-16 11:33:00 -07:00
Michael Thomsen e167181444
Move flutter_gallery to the testing folder (#52532)
Move Flutter Gallery to dev/integration_tests/ as it is an older copy used only for testing. The current version of the Flutter Gallery now lives in https://github.com/flutter/gallery.
2020-03-16 10:31:42 +01:00
Jenn Magder 73ea37eca9
Revert "Fall back to environment SDKROOT passed from Xcode (#52570)" (#52583)
This reverts commit 8e6e15f915.
2020-03-13 18:29:09 -07:00
Jenn Magder 8e6e15f915
Fall back to environment SDKROOT passed from Xcode (#52570) 2020-03-13 17:16:56 -07:00
Dan Field 98cf01858c
Fetch tags for version command (#52212) 2020-03-13 17:16:03 -07:00
Jonah Williams bbc5b9d967
Revert "[flutter_tools]: reland android device cleanup (#52542)" (#52579)
This reverts commit 9186dfc34d.
2020-03-13 16:38:59 -07:00
Jonah Williams 3bc36095da
Revert "[flutter_tools]: reland move engine unpack to dart (#52543)" (#52549)
This reverts commit 3e25e60f57.
2020-03-13 09:50:07 -07:00
Jonah Williams 9186dfc34d
[flutter_tools]: reland android device cleanup (#52542) 2020-03-13 09:42:02 -07:00
Jonah Williams 3e25e60f57
[flutter_tools]: reland move engine unpack to dart (#52543)
Reland of #50707
2020-03-13 09:40:55 -07:00
Jonah Williams b3a37d0273
[flutter_tools] support toggling CanvasKit rendering on with 'k' (#52511) 2020-03-13 07:02:34 -07:00
Jonah Williams 1e8c4572ec
Revert "[flutter_tools] remove globals in AndroidDevices (#52505)" (#52515)
This reverts commit 1bf9d6f4f7.
2020-03-12 18:14:32 -07:00
Christopher Fujino 14d8534c3e
add usbmuxd (#52500) 2020-03-12 17:36:01 -07:00
Jonah Williams 1bf9d6f4f7
[flutter_tools] remove globals in AndroidDevices (#52505) 2020-03-12 15:51:26 -07:00
Zachary Anderson 0cd2ece539
[flutter_tools] Hanlde OSError in places where we've seen it thrown (#52491) 2020-03-12 14:01:01 -07:00
Jonah Williams d98213c46f
[flutter_tools] reland: Update background isolates when performing hot reload/restart (#52479)
Reland of #52149
2020-03-12 12:48:05 -07:00
Finn 9e848f3c78
Add ignore public member api docs in template (#52422) 2020-03-12 10:36:02 -07:00
Christopher Fujino 38a8845481
move iosworkflow to globals (#52444) 2020-03-12 10:16:28 -07:00
Dmitry Ratushnyy 1b0fd265bd
[ISSUE-30478] Release cache dir lock acquired by a command on sigint or sigterm (#52194) 2020-03-12 09:11:01 -07:00
Zachary Anderson 04a1b78b75
Revert "[flutter_tools] Update background isolates when performing hot reload/restart (#52149)" (#52476)
This reverts commit edd03a1af8.
2020-03-12 09:02:31 -07:00
Jonah Williams edd03a1af8
[flutter_tools] Update background isolates when performing hot reload/restart (#52149)
When performing a hot restart, collect isolates without an attached flutter view and send a kill signal. These must have been spawned by running main, so restarting without removing them leads to isolate duplication.

When performing a hot reload, ensure that we send a reloadSources command to every isolate and not just uiIsolates.
2020-03-11 15:52:04 -07:00
Jonah Williams 6804cef587
[flutter_tools] throw exception instead of string from startApp (#52365)
When attempting to start an emulator in profile mode, ensure the daemon can exit gracefully
2020-03-11 09:41:52 -07:00
Emmanuel Garcia 4049889d9e
Make --androidx flag a noop in flutter create (#52340) 2020-03-10 20:05:41 -07:00
Jonah Williams ea3563ea4d
[flutter_tools] update visual studio and validator to remove globals, update test cases (#51680)
Updates VisualStudio and VisualStudioValidator to use constructors instead of global injection. Updates VisualStudio test cases to prefer FakeProcessManager
Updates build_windows test to work without injected VisualStudio
2020-03-10 16:49:23 -07:00
Zachary Anderson 53dce17b35
[flutter_tools] Fallback discovery: Don't crash when an Isolate has no root library (#52354) 2020-03-10 15:31:02 -07:00
Zachary Anderson 78b45fb1b2
[flutter_tools] Throw a tool exit when samples fetch fails (#52355) 2020-03-10 15:21:02 -07:00
Zachary Anderson 7f564b7436
[flutter_tools] Handle StateError in ProtocolDiscovery.uri (#52337) 2020-03-10 14:26:02 -07:00
Jonah Williams 5d289721fc
[flutter_tools] handle null value from sdk version (#52351)
When the AndroidDevice checks for the current API version, it isn't handling a null response. While we can refuse to run on API levels that are unsupported, we should probably assume that a null response = lowest possible API level and allow these to run.
2020-03-10 14:23:18 -07:00
Zachary Anderson 605debfcff
[flutter_tools] Make AndroidConsole check for next line (#52353) 2020-03-10 14:21:01 -07:00
Zachary Anderson 733fc20073
[flutter_tool] Use unzip -t instead of zip -T to verify zip files (#52331) 2020-03-10 12:22:53 -07:00
Jonah Williams fdb7bd3c0f
[flutter_tools] attempt to fix .first crasher in web loading (#52301) 2020-03-10 12:09:37 -07:00
Jonah Williams 2133343a29
[flutter_tools] cache result of BotDetector in persistent tool state (#52325)
The Azure bot detection can take up to a second to determine if a client is/isn't a bot. To prevent this from slowing down all flutter commands, we can cache the results in the persistent tool state - since we don't expect the same client id to ever become a bot or stop being a bot
2020-03-10 11:35:52 -07:00
Jonah Williams 377879825e
[flutter_tools] prevent StateError when log reader is disposed (#52173)
Previously the AdbLogReader did async setup in the StreamController.onListen callback, specifically it would query the api version and start the adb process. If the log subscription was cancelled before this setup completed, then the log output could (haven't confirmed) get added to a closed controller, causing the above state error.
2020-03-10 11:34:40 -07:00