Christopher Fujino
730d6d44b7
Don't pin package:macros ( #148087 )
...
Full context https://github.com/flutter/flutter/issues/148004
TL;DR
1. Because `package:macros` depends on `package:_macros` via [a Dart SDK
dependency](https://github.com/dart-lang/sdk/blob/main/pkg/macros/pubspec.yaml#L13 );
and
2. `package:macros` exactly pins `package:_macros`; and
3. Each new version of `package:macros` will increment its exact pin of
`package:_macros`
([comment](https://github.com/flutter/flutter/issues/148004#issuecomment-2103099893 ));
and
4. The [flutter/flutter](https://github.com/flutter/flutter ) repository
exactly pins the Dart SDK (via its exact pin on the
[flutter/engine](https://github.com/flutter/engine ) repository
Therefore, the [flutter/flutter](https://github.com/flutter/flutter )
repository effectively pins both `package:macros` and `package:_macros`
already (as in, there exists only a single version of each that pub will
successfully be able to solve within the context of a particular Flutter
SDK).
Therefore, it is safe for
[flutter/flutter](https://github.com/flutter/flutter ) repository to
*not* pin `package:macros`, which will allow engine -> framework rolls
that contain a new Dart SDK that contains a new `package:_macros`
version to land automatically, provided all tests pass.
2024-05-09 16:28:49 -07:00
Ian Hickson
e1e742ac35
Remove hidden dependencies on the default LocalPlatform ( #147342 )
...
This is part 13 of a broken down version of the #140101 refactor.
This only makes one dependency explicit. Further PRs will do the same
for other dependencies, until these APIs have no hidden dependencies.
2024-05-09 15:33:55 -07:00
Nate
94a7151eb8
Getting rid of containers ( #147432 )
...
This pull request aims to make the Flutter framework more efficient,
based on issue #147431 .
2024-05-09 16:31:54 -06:00
engine-flutter-autoroll
77427f6608
Roll Flutter Engine from c0fd3386d018 to 6e722ae213bd (2 revisions) ( #148070 )
...
c0fd3386d0...6e722ae213skia-flutter-autoroll@skia.org Roll Skia from 2a368794c73e to 2813bc21202e (2 revisions) (flutter/engine#52697 )
2024-05-09 skia-flutter-autoroll@skia.org Roll Skia from aa82350f9cf4 to 2a368794c73e (1 revision) (flutter/engine#52696 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-05-09 18:16:19 +00:00
Michael Goderbauer
2bfb1b0e2f
Bump flutter_lints to 4.0 ( #148020 )
...
Follow-up to https://github.com/flutter/packages/pull/6695 .
2024-05-09 18:07:51 +00:00
huycozy
bd44399865
Add Badge example ( #148053 )
...
### Demo screenshot
### Related issue
Fixes https://github.com/flutter/flutter/issues/144336
2024-05-09 16:47:16 +00:00
Benji Farquhar
a5e0c2ffe7
Fix ExpandIcon color when ExpansionPanel.canTapOnHeader true ( #147097 ) ( #147098 )
...
Fixes https://github.com/flutter/flutter/issues/147097 . The expand/collapse icon should not be the disabled color when ExpansionPanel.canTapOnHeader is true because the ExpansionPanel is active, and we may want to keep the icon there as a visual indicator to the user that it is expandable/collapsable.
2024-05-09 15:35:07 +00:00
engine-flutter-autoroll
607a3dad76
Roll Flutter Engine from c2e874fdc164 to c0fd3386d018 (1 revision) ( #148040 )
...
c2e874fdc1...c0fd3386d0skia-flutter-autoroll@skia.org Roll Skia from 68ab865c016f to aa82350f9cf4 (2 revisions) (flutter/engine#52695 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-05-09 08:39:07 +00:00
engine-flutter-autoroll
9f7b4e8424
Roll Flutter Engine from fe08238f5a52 to c2e874fdc164 (1 revision) ( #148038 )
...
fe08238f5a...c2e874fdc1skia-flutter-autoroll@skia.org Roll Skia from f4e251cc8407 to 68ab865c016f (2 revisions) (flutter/engine#52694 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-05-09 07:42:31 +00:00
engine-flutter-autoroll
54fec08643
Roll Flutter Engine from 69f2d9610a18 to fe08238f5a52 (1 revision) ( #148034 )
...
69f2d9610a...fe08238f5askia-flutter-autoroll@skia.org Roll Skia from 91088addfbd9 to f4e251cc8407 (1 revision) (flutter/engine#52693 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-05-09 06:00:14 +00:00
flutter-pub-roller-bot
076e701f46
Roll pub packages ( #148011 )
...
This PR was generated by `flutter update-packages --force-upgrade`.
2024-05-09 04:45:28 +00:00
engine-flutter-autoroll
972dcd7c65
Roll Flutter Engine from bd58d2b2d655 to 69f2d9610a18 (7 revisions) ( #148030 )
...
bd58d2b2d6...69f2d9610askia-flutter-autoroll@skia.org Roll Skia from 4e83fac12783 to 91088addfbd9 (1 revision) (flutter/engine#52691 )
2024-05-08 skia-flutter-autoroll@skia.org Roll Skia from df446841e3cd to 4e83fac12783 (2 revisions) (flutter/engine#52688 )
2024-05-08 magder@google.com Fix UIVisualEffectView leak in platform view filter (flutter/engine#52591 )
2024-05-08 jonahwilliams@google.com [Impeller] initialize ahb swapchain with max entries. (flutter/engine#52670 )
2024-05-08 skia-flutter-autoroll@skia.org Roll Skia from 76f88de905be to df446841e3cd (3 revisions) (flutter/engine#52686 )
2024-05-08 chinmaygarde@google.com Reland "Add host_profile_arm64 and host_release_arm64 local engine configurations." (flutter/engine#52633 )
2024-05-08 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from 27ZAbzJkEopmu0Emp... to RDVdjRvCxkJh2NLxS... (flutter/engine#52685 )
Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from 27ZAbzJkEopm to RDVdjRvCxkJh
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-05-09 02:41:26 +00:00
Kevin Moore
4e81abe85f
[web] Update wasm CLI details to be clear JavaScript is ALSO compiled ( #147944 )
...
At the moment, we ALWAYS compile JS with Wasm. The CLI flags should be clear on this!
2024-05-09 01:33:26 +00:00
Kate Lovett
00f40667c1
Exclude abi key in local golden file testing ( #148023 )
...
Part of https://github.com/flutter/flutter/issues/148022
2024-05-08 23:39:13 +00:00
Michael Goderbauer
26030557b1
Fix semantic debugger ( #147953 )
...
This was broken in https://github.com/flutter/flutter/pull/122452 . The culprit is that `PipelineOwner.ensureSemantics` doesn't turn on semantics for the entire app, it pretends to only turn it on for the local `PipelineOwner`. Unfortunately, that local `PipelineOwner` is never informed that it should produce semantics when semantics are not turned on globally. So, `PipelineOwner.ensureSemantics` is essentially without effect if semantics are not already turned on globally.
I can't think of a use case where it would be useful to only turn on semantics for a particular pipeline owner and fixing `PipelineOwner.ensureSemantics` would get pretty messy with performance implications even if semantics are turned off. So, this PR deprecates that functionality and moves the `SemanticsDebugger` to the global semantics API.
Fixes https://github.com/flutter/flutter/issues/147665 .
2024-05-08 23:12:47 +00:00
engine-flutter-autoroll
9e2d945c6d
Roll Flutter Engine from 93c504058426 to bd58d2b2d655 (2 revisions) ( #148014 )
...
93c5040584...bd58d2b2d6skia-flutter-autoroll@skia.org Roll Skia from 4019d8957cff to 76f88de905be (3 revisions) (flutter/engine#52684 )
2024-05-08 chinmaygarde@google.com [Impeller] Start a glossary. (flutter/engine#52641 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-05-08 22:35:24 +00:00
engine-flutter-autoroll
f8d29c8695
Roll Flutter Engine from 9cb60de37b6d to 93c504058426 (6 revisions) ( #148010 )
...
9cb60de37b...93c5040584#52677 )" (flutter/engine#52683 )
2024-05-08 skia-flutter-autoroll@skia.org Roll Skia from d965fc1fd319 to 4019d8957cff (2 revisions) (flutter/engine#52682 )
2024-05-08 30870216+gaaclarke@users.noreply.github.com Revert 484688634c71ec38c18218eaa13dc47fa7007b74 (flutter/engine#52680 )
2024-05-08 skia-flutter-autoroll@skia.org Roll Skia from d8427844b843 to d965fc1fd319 (4 revisions) (flutter/engine#52679 )
2024-05-08 jonahwilliams@google.com [Impeller] require and use backpressure for AHB swapchain. (flutter/engine#52676 )
2024-05-08 skia-flutter-autoroll@skia.org Roll Dart SDK from b7cad2edae4b to 673b3aa8558a (1 revision) (flutter/engine#52677 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-05-08 21:49:25 +00:00
flutter-pub-roller-bot
b7a9e60850
Roll pub packages ( #147995 )
...
This PR was generated by `flutter update-packages --force-upgrade`.
2024-05-08 20:28:00 +00:00
Andrew Kolos
2cfae1431f
add print traces to reload isolate resume logic ( #147997 )
...
In service of https://github.com/flutter/flutter/issues/146879 and https://github.com/flutter/flutter/issues/145812 .
This PR adds some more traces to help us figure out where we are getting blocked. See https://github.com/flutter/flutter/issues/146879#issuecomment-2101115534 for more context.
2024-05-08 19:57:57 +00:00
Sam Rawlins
39d8492fb8
Tweak to fix context.mounted in dialog_demo ( #147998 )
...
Prepares for a fix to the `use_build_context_synchronously` lint (https://dart-review.googlesource.com/c/sdk/+/365541 ) that will complain about these unsafe usages.
The lint rule cannot tell that the `mounted` field is shorthand for `context.mounted`.
2024-05-08 19:56:22 +00:00
Dimil Kalathiya
c97f22ec12
_RenderValueIndicator leak fix used on RangeSlider (#147581 )
...
Part of #141198
*Fixes memory leak on `RangeSlider`*
2024-05-08 19:04:17 +00:00
engine-flutter-autoroll
32444e5822
Roll Flutter Engine from f3ce5a59c207 to 9cb60de37b6d (5 revisions) ( #147994 )
...
f3ce5a59c2...9cb60de37bskia-flutter-autoroll@skia.org Roll Skia from c7794fee8063 to d8427844b843 (2 revisions) (flutter/engine#52671 )
2024-05-08 skia-flutter-autoroll@skia.org Manual roll Dart SDK from a9cf6a411c71 to b7cad2edae4b (7 revisions) (flutter/engine#52669 )
2024-05-08 jonahwilliams@google.com [Impeller] Update BlitPass::AddCopy to use destination_region instead of origin for buffer to texture copies. (flutter/engine#52555 )
2024-05-08 flar@google.com DisplayListBuilder internal reorganization with better rendering op overlap detection (flutter/engine#52646 )
2024-05-08 zanderso@users.noreply.github.com Roll reclient forward (flutter/engine#52632 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-05-08 18:24:41 +00:00
engine-flutter-autoroll
1c7e6a401e
Roll Flutter Engine from 071014f31c6b to f3ce5a59c207 (1 revision) ( #147984 )
...
071014f31c...f3ce5a59c2skia-flutter-autoroll@skia.org Roll Skia from 2319f1ae8fe4 to c7794fee8063 (20 revisions) (flutter/engine#52668 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-05-08 16:59:10 +00:00
Valentin Vignal
1a8aeb15ef
Fix memory leaks in context menu ( #147822 )
2024-05-08 09:57:41 -07:00
engine-flutter-autoroll
8e834b555b
Roll Packages from 5ccddfc995e4 to 8de142d33b88 (4 revisions) ( #147980 )
...
5ccddfc995...8de142d33bstuartmorgan@google.com [path_provider] Add Swift Package Manager support (flutter/packages#6680 )
2024-05-07 goderbauer@google.com [go_router] guard context access in then clauses (flutter/packages#6685 )
2024-05-07 engine-flutter-autoroll@skia.org Roll Flutter from 04424e10fe7920a52dd5flutter/packages#6683 )
2024-05-07 srawlins@google.com [camera] Ignore implementation imports outside of lib (flutter/packages#6191 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com ,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-05-08 15:44:10 +00:00
Aliasgar Vohra
4d6c00cc2b
🐛 : FIX : Long labels overflowing in extended navigation rail. ( #145474 )
...
It has been observed that while in extended navigation rail, if longer labels are given the it is overflowing. Problem identified in "NavigationRail" widget only in case of extended version of it. This PR includes the fix for the same.
Fixes https://github.com/flutter/flutter/issues/110901 .
*NO breaking changes.*
2024-05-08 11:05:24 +00:00
engine-flutter-autoroll
1fba66d82e
Roll Flutter Engine from 78878241c8f3 to 071014f31c6b (1 revision) ( #147973 )
...
78878241c8...071014f31cjonahwilliams@google.com [Impeller] support requires readback from onscreen texture in experimental canvas. (flutter/engine#52640 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-05-08 10:15:36 +00:00
Danny Tuppeny
cea1d6f055
Unpin DDS and roll pub packages ( #147925 )
...
DDS was temporarily pinned to 4.1.0 because 4.2.0 triggered some test
failures (see https://github.com/flutter/flutter/pull/147250 ). Those
failures should be fixed by vm_service 14.2.2, so this unpins DDS and
rolls both of these packages (along with devtools_shared, which is a DDS
dependency).
(If the bot updates vm_service before this is done, I can rebase over
that will reduce the size of this PR to just a few files)
2024-05-08 10:35:28 +01:00
Bruno Leroux
86a2613cee
Fix floating SnackBar is not centered when RTL and Material 2 ( #147861 )
...
## Description
This PR fixes floating `SnackBar` positioning when the text direction is RTL and the theme uses Material 2.
In https://github.com/flutter/flutter/pull/140215 , I fixed the `SnackBar` position for M3/RTL, but while doing so I broke the positioning for M2/RTL... Unfortunately, there was no existing test for this case.
The solution is to not rely on `TextDirection` to compute the `SnackBar` position: the `SnackBar` is centered in both cases so the text direction has no impact on its positioning (it had some impact in the `SnackBar` content, but this is managed correctly).
## Related Issue
Fixes https://github.com/flutter/flutter/issues/147838 .
## Tests
Adds 1 test.
2024-05-08 07:34:05 +00:00
engine-flutter-autoroll
a318c79979
Roll Flutter Engine from 0a469aa59c4e to 78878241c8f3 (1 revision) ( #147962 )
...
0a469aa59c...78878241c8jonahwilliams@google.com [Impeller] bump image count to 3 (flutter/engine#52650 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-05-08 05:52:11 +00:00
engine-flutter-autoroll
0b3a88f218
Roll Flutter Engine from 8b0ab9366715 to 0a469aa59c4e (1 revision) ( #147957 )
...
8b0ab93667...0a469aa59cchinmaygarde@google.com [Impeller] In the AHB swapchain, make the wait stages be non-temporaries. (flutter/engine#52644 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-05-08 02:42:36 +00:00
Valentin Vignal
ab8b2f7e53
Fix more memory leaks in cupertino page transition ( #147907 )
2024-05-07 19:07:04 -07:00
engine-flutter-autoroll
aa9cf009c2
Roll Flutter Engine from 1c52274e1118 to 8b0ab9366715 (1 revision) ( #147955 )
...
1c52274e11...8b0ab93667jonahwilliams@google.com [Impeller] Support copy from buffer to texture for GLES blitpass, use blit pass to set contents in glyph atlas. (flutter/engine#52510 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-05-08 01:54:58 +00:00
engine-flutter-autoroll
bda1b3bd40
Roll Flutter Engine from d8dd731f91ef to 1c52274e1118 (2 revisions) ( #147954 )
...
d8dd731f91...1c52274e11chinmaygarde@google.com [Impeller] Disable aging in the AHB swapchains and use FILO. (flutter/engine#52637 )
2024-05-07 matanlurey@users.noreply.github.com Move `Logger.test` to an injected log output versus leaky abstraction. (flutter/engine#52639 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-05-08 01:09:32 +00:00
engine-flutter-autoroll
d59af86b61
Roll Flutter Engine from 880280a14b65 to d8dd731f91ef (1 revision) ( #147951 )
...
880280a14b...d8dd731f91zanderso@users.noreply.github.com Fix links in rbe.md (flutter/engine#52635 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-05-08 00:30:23 +00:00
LongCatIsLooong
e37b29daa9
Implement computeDryBaseline for RenderChip ( #146224 )
...
Also, use `getDryLayout` for the first pass of the `label` layout.
The computeDryBaseline stuff doesn't have a test because there're asserts making sure it returns the same result as `computeDistanceToActualBaseline`. I have tried adding `+1` to the return expression and `flutter test` fails.
2024-05-08 00:27:59 +00:00
Dimil Kalathiya
4abd7352f8
fixes RawDialogRoute memory leak ( #147817 )
...
part of #141198
- Fixes memory leak on `RawDialogRoute`
- Adds opt-in test
2024-05-07 23:39:56 +00:00
engine-flutter-autoroll
1fee18760e
Roll Flutter Engine from 1fe835b85f5c to 880280a14b65 (1 revision) ( #147947 )
...
1fe835b85f...880280a14bmatanlurey@users.noreply.github.com Move setting the logging level into the `Logger` constructor, refactor. (flutter/engine#52624 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-05-07 23:35:06 +00:00
Elliott Brooks
b487b8c19a
[flutter web] Listen for service extension registration events to determine hot-restart method name ( #147897 )
...
### Some background:
* Flutter registers the hot-restart service extension for all devices **except** web devices. For web devices, DWDS registers the service extensions.
* When a user is debugging their code via VS Code, the VS Code Dart extension [sends a hot-restart](94cb81c552/src/debug/run_daemon_base.ts (L100)f3978c7a46/packages/flutter_tools/lib/src/isolated/resident_web_runner.dart (L447)https://github.com/dart-lang/webdev/pull/2388 ). Previously, we registered the "hotRestart" service extension on a client that was directly connected to the VmService. With https://github.com/dart-lang/webdev/pull/2388 , we will be registering the "hotRestart" service extension on a client that is connected to DDS.
When a service extension is registered against DDS, DDS adds a prefix to the service extension method name (e.g. "hotRestart" becomes "s0.hotRestart"). It informs clients of the service extension name via `kServiceRegistered` events sent to the `Service` stream.
Therefore, this change simply listens to those service extension registered events, and uses them to determine the "hotRestart" service extension's method name.
2024-05-07 23:06:59 +00:00
engine-flutter-autoroll
89e538da28
Roll Flutter Engine from 42898e014fd1 to 1fe835b85f5c (3 revisions) ( #147943 )
...
42898e014f...1fe835b85f#52620 )" (flutter/engine#52630 )
2024-05-07 matanlurey@users.noreply.github.com Move `verbose` to `environment.verbose`, pass to `ninja --verbose` if provided. (flutter/engine#52619 )
2024-05-07 chinmaygarde@google.com Add host_profile_arm64 and host_release_arm64 local engine configurations. (flutter/engine#52620 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-05-07 22:44:58 +00:00
David Iglesias
d7656f2fcf
[web] Use platform detection from Flutter web engine. ( #147346 )
...
> [!IMPORTANT]
> Requires the following engine PR:
> * https://github.com/flutter/engine/pull/52380
> ----
This PR refactors Flutter `foundation`'s library `platform` for the web with the same code we use to detect platforms in the engine.
## Issues
* Fixes: https://github.com/flutter/flutter/issues/128943
## Testing
Demo app deployed here:
* https://dit-browser-detect.web.app
2024-05-07 22:44:56 +00:00
LongCatIsLooong
f20c853d20
Implement RenderEditable.computeDryBaseline ( #147911 )
...
Missed `RenderEditable` so https://github.com/flutter/flutter/pull/146224 is failing in google3
2024-05-07 21:26:48 +00:00
Taha Tesser
74356f30dd
Introduce TabBar.textScaler for tab label upper text scale limit ( #147232 )
...
fixes [Tab is hardcoding the height of the icons and the text ](https://github.com/flutter/flutter/issues/13322 )
### Description
This PR introduces `TabBar.textScaler` to provide upper text scale limit for tab label.
### Code sample
<details>
<summary>expand to view the code sample</summary>
```dart
import 'package:flutter/material.dart';
void main() => runApp(const MyApp());
class MyApp extends StatelessWidget {
const MyApp({super.key});
@override
Widget build(BuildContext context) {
return MaterialApp(
debugShowCheckedModeBanner: false,
home: MediaQuery(
data: const MediaQueryData(textScaler: TextScaler.linear(3.0)),
child: DefaultTabController(
length: 3,
child: Scaffold(
appBar: AppBar(
title: const Text('Sample'),
bottom: const TabBar(
textScaler: TextScaler.linear(2.0),
tabs: <Widget>[
Tab(text: 'Tab 1'),
Tab(text: 'Tab 2'),
Tab(text: 'Tab 3'),
],
),
),
floatingActionButton: Builder(builder: (BuildContext context) {
return FloatingActionButton(
onPressed: () {
print(MediaQuery.textScalerOf(context));
},
child: const Icon(Icons.add),
);
}),
),
),
),
);
}
}
```
</details>
### Without `TabBar.textScaler`
### With `TabBar.textScaler`
```dart
bottom: const TabBar(
textScaler: TextScaler.linear(2.0),
tabs: <Widget>[
Tab(text: 'Tab 1'),
Tab(text: 'Tab 2'),
Tab(text: 'Tab 3'),
],
),
```
2024-05-07 20:54:09 +00:00
Michael Goderbauer
8796562d0a
Properly guard context access in then clauses ( #147935 )
...
Prepares for a fix to the `use_build_context_synchronously` lint (https://dart-review.googlesource.com/c/sdk/+/365541 ) that will complain about these unsafe usages.
2024-05-07 20:50:46 +00:00
engine-flutter-autoroll
458c384fe2
Roll Flutter Engine from d88b7dbfef2e to 42898e014fd1 (2 revisions) ( #147939 )
...
d88b7dbfef...42898e014fchinmaygarde@google.com [Impeller] Wait for the previous AHB texture to be fully recyclable. (flutter/engine#52588 )
2024-05-07 jason-simmons@users.noreply.github.com Manual Skia roll to 2319f1ae8fe42525f8b6a1969a1cee67bdbee290 (flutter/engine#52615 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-05-07 20:41:15 +00:00
derdilla
a7bdf369e5
improve focus example ( #147464 )
...
Part of #130459 . Adds a test to the [second focus example](https://api.flutter.dev/flutter/widgets/Focus-class.html#widgets.Focus.2 ) and makes the function of the example more clear.
2024-05-07 20:07:49 +00:00
August
be3e916443
feat: Rework getting plugin implementation candidates and plugin resolution ( #145258 )
...
Part of #137040 and #80374
- Extracted getting plugin implementation candidates and the default implementation to its own method
- Extracted resolving the plugin implementation to its own method
- Simplify candidate selection algorithm
- Support overriding inline dart implementation for an app-facing plugin
- Throw error, if a federated plugin implements an app-facing plugin, but also references a default implementation
- Throw error, if a plugin provides an inline implementation, but also references a default implementation
2024-05-07 20:03:27 +00:00
engine-flutter-autoroll
b8dc9da9b6
Roll Flutter Engine from 5d94a52687a6 to d88b7dbfef2e (1 revision) ( #147938 )
...
5d94a52687...d88b7dbfefjonahwilliams@google.com [Impeller] allow cloning a rectangle packer with an increased size. (flutter/engine#52563 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-05-07 19:57:50 +00:00
Mitchell Goodwin
e67e951388
Change dialog font family ( #141295 )
...
Fixes #139434 .
Changes the font from "Text" to "Display". We should only be using the "Display" font for fonts of size 20 and above. Previously "Display" was not showing correctly so this font being wrong was flying under the radar.
Before:
<img width="315" alt="Screenshot 2024-01-10 at 10 49 26â¯AM" src="https://github.com/flutter/flutter/assets/58190796/c8beba30-04d2-4c22-86ae-85c0576136ee ">
After:
<img width="289" alt="Screenshot 2024-01-10 at 10 52 11â¯AM" src="https://github.com/flutter/flutter/assets/58190796/c6b33aaf-791c-460e-a640-37d8ddf3f713 ">
2024-05-07 19:32:47 +00:00
Daco Harkes
6967ae551e
Fix dep tracking ( #147709 )
...
Fix dependency tracking in the build.
* https://github.com/flutter/flutter/issues/147643
## Testing
It's not clear to me where to test the caching behavior of specific targets.
* test/general.shard/build_system/targets/common_test.dart
* This doesn't test the caching behavior of any targets
* test/general.shard/build_system/build_system_test.dart
* test/general.shard/cache_test.dart
* Both of these don't test specific `Target`s, these have `TestTarget`s.
* test/integration.shard/isolated/native_assets_test.dart
* This could work, but it's an integration test that already takes long to run.
2024-05-07 17:44:12 +00:00
