Bruno Leroux
6f61f6135f
Activate shortcuts based on NumLock state ( #145146 )
...
## Description
The PR updates `SingleActivator` in order to add a parameter for specifying that a shortcut depends on <kbd>NumLock</kbd> key state.
Somewhat similarly to what is possible with common modifiers expect that a boolean is not enough in this case because: by default, a shortcut should ignore the <kbd>NumLock</kbd> state and it should be possible to define shortcuts that require <kbd>NumLock</kbd> to be locked and other that require it to be unlocked.
@gspencergoog I considered defining a new `ShortcutActivator` implementation for this, but I thinks that adding the feature directly to `SingleActivator` results in a cleaner API.
## Related Issue
Fixes https://github.com/flutter/flutter/issues/145144
Preparation for https://github.com/flutter/flutter/issues/144936
## Tests
Adds 3 tests.
2024-03-19 08:27:50 +00:00
engine-flutter-autoroll
88a9b58dd8
Roll Flutter Engine from 59519ceee30a to de6b8f49b849 (1 revision) ( #145381 )
...
59519ceee3...de6b8f49b8skia-flutter-autoroll@skia.org Roll Skia from 726cccdbfd3d to 62f3d0cbb9c8 (2 revisions) (flutter/engine#51513 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-03-19 08:05:52 +00:00
engine-flutter-autoroll
16bd4bb3fd
Roll Flutter Engine from ac8f1f233d6f to 59519ceee30a (2 revisions) ( #145379 )
...
ac8f1f233d...59519ceee3flutter/engine#51512 )
2024-03-19 skia-flutter-autoroll@skia.org Roll Skia from 86de9a698b76 to 726cccdbfd3d (1 revision) (flutter/engine#51511 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC bdero@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-03-19 07:26:08 +00:00
engine-flutter-autoroll
ca864c048e
Roll Flutter Engine from 4a86b5b17c39 to ac8f1f233d6f (3 revisions) ( #145375 )
...
4a86b5b17c...ac8f1f233dskia-flutter-autoroll@skia.org Roll Skia from f5d824314bf7 to 86de9a698b76 (2 revisions) (flutter/engine#51510 )
2024-03-19 chinmaygarde@google.com Add missing license blocks. (flutter/engine#51496 )
2024-03-19 skia-flutter-autoroll@skia.org Roll Dart SDK from f874a4976038 to 3e64b8fcbfb7 (1 revision) (flutter/engine#51509 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC bdero@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-03-19 05:50:35 +00:00
engine-flutter-autoroll
da8aaf274b
Roll Flutter Engine from c0d1b0d5d43f to 4a86b5b17c39 (1 revision) ( #145373 )
...
c0d1b0d5d4...4a86b5b17cskia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from I5fL_9DJQBS1Bydbz... to ppkQSDakw0QcsVt8u... (flutter/engine#51507 )
Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from I5fL_9DJQBS1 to ppkQSDakw0Qc
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC bdero@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-03-19 03:54:23 +00:00
engine-flutter-autoroll
4f1c78948d
Roll Flutter Engine from 3d909f14118e to c0d1b0d5d43f (1 revision) ( #145371 )
...
3d909f1411...c0d1b0d5d4skia-flutter-autoroll@skia.org Roll Skia from 2f07d8e1829b to f5d824314bf7 (1 revision) (flutter/engine#51506 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC bdero@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-03-19 03:05:59 +00:00
engine-flutter-autoroll
c6b0240a85
Roll Flutter Engine from 0ee413ee276a to 3d909f14118e (5 revisions) ( #145370 )
...
0ee413ee27...3d909f1411skia-flutter-autoroll@skia.org Roll Skia from 7e207af2200b to 2f07d8e1829b (1 revision) (flutter/engine#51505 )
2024-03-18 skia-flutter-autoroll@skia.org Roll Skia from 9950dc8ec6fd to 7e207af2200b (4 revisions) (flutter/engine#51502 )
2024-03-18 skia-flutter-autoroll@skia.org Roll Dart SDK from 47ab7cca8a83 to f874a4976038 (1 revision) (flutter/engine#51501 )
2024-03-18 ian@hixie.ch More renderdoc_frame_capture.md updates (flutter/engine#51499 )
2024-03-18 chinmaygarde@google.com [Impeller] Allow identifying device driver and vendor information. (flutter/engine#51498 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC bdero@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-03-19 01:59:16 +00:00
engine-flutter-autoroll
b34048c84b
Roll Flutter Engine from 89df726bf13a to 0ee413ee276a (3 revisions) ( #145365 )
...
89df726bf1...0ee413ee27chinmaygarde@google.com A native Android unit-testing harness. (flutter/engine#51479 )
2024-03-18 98614782+auto-submit[bot]@users.noreply.github.com Reverts "[Fuchsia] only download fuchsia deps when necessary (#51439 )" (flutter/engine#51500 )
2024-03-18 kustermann@google.com [web] Avoid using `js_util.{jsify,dartify}()` in dart2wasm for converting to JS wrappers (flutter/engine#51375 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC bdero@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-03-18 23:59:09 +00:00
engine-flutter-autoroll
acd28f0b81
Roll Flutter Engine from 3fde3678a357 to 89df726bf13a (1 revision) ( #145359 )
...
3fde3678a3...89df726bf1ian@hixie.ch Add details to renderdoc_frame_capture.md (flutter/engine#51483 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC bdero@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-03-18 23:14:08 +00:00
dependabot[bot]
ed2c7eda89
Bump github/codeql-action from 3.24.7 to 3.24.8 ( #145358 )
...
Bumps [github/codeql-action](https://github.com/github/codeql-action ) from 3.24.7 to 3.24.8.
<details>
<summary>Changelog</summary>
<p><em>Sourced from <a href="https://github.com/github/codeql-action/blob/main/CHANGELOG.md ">github/codeql-action's changelog</a>.</em></p>
<blockquote>
<h1>CodeQL Action Changelog</h1>
<p>See the <a href="https://github.com/github/codeql-action/releases ">releases page</a> for the relevant changes to the CodeQL CLI and language packs.</p>
<p>Note that the only difference between <code>v2</code> and <code>v3</code> of the CodeQL Action is the node version they support, with <code>v3</code> running on node 20 while we continue to release <code>v2</code> to support running on node 16. For example <code>3.22.11</code> was the first <code>v3</code> release and is functionally identical to <code>2.22.11</code>. This approach ensures an easy way to track exactly which features are included in different versions, indicated by the minor and patch version numbers.</p>
<h2>[UNRELEASED]</h2>
<p>No user facing changes.</p>
<h2>3.24.8 - 18 Mar 2024</h2>
<ul>
<li>Improve the ease of debugging extraction issues by increasing the verbosity of the extractor logs when running in debug mode. <a href="https://redirect.github.com/github/codeql-action/pull/2195 ">#2195</a></li>
</ul>
<h2>3.24.7 - 12 Mar 2024</h2>
<ul>
<li>Update default CodeQL bundle version to 2.16.4. <a href="https://redirect.github.com/github/codeql-action/pull/2185 ">#2185</a></li>
</ul>
<h2>3.24.6 - 29 Feb 2024</h2>
<p>No user facing changes.</p>
<h2>3.24.5 - 23 Feb 2024</h2>
<ul>
<li>Update default CodeQL bundle version to 2.16.3. <a href="https://redirect.github.com/github/codeql-action/pull/2156 ">#2156</a></li>
</ul>
<h2>3.24.4 - 21 Feb 2024</h2>
<ul>
<li>Fix an issue where an existing, but empty, <code>/sys/fs/cgroup/cpuset.cpus</code> file always resulted in a single-threaded run. <a href="https://redirect.github.com/github/codeql-action/pull/2151 ">#2151</a></li>
</ul>
<h2>3.24.3 - 15 Feb 2024</h2>
<ul>
<li>Fix an issue where the CodeQL Action would fail to load a configuration specified by the <code>config</code> input to the <code>init</code> Action. <a href="https://redirect.github.com/github/codeql-action/pull/2147 ">#2147</a></li>
</ul>
<h2>3.24.2 - 15 Feb 2024</h2>
<ul>
<li>Enable improved multi-threaded performance on larger runners for GitHub Enterprise Server users. This feature is already available to GitHub.com users. <a href="https://redirect.github.com/github/codeql-action/pull/2141 ">#2141</a></li>
</ul>
<h2>3.24.1 - 13 Feb 2024</h2>
<ul>
<li>Update default CodeQL bundle version to 2.16.2. <a href="https://redirect.github.com/github/codeql-action/pull/2124 ">#2124</a></li>
<li>The CodeQL action no longer fails if it can't write to the telemetry api endpoint. <a href="https://redirect.github.com/github/codeql-action/pull/2121 ">#2121</a></li>
</ul>
<h2>3.24.0 - 02 Feb 2024</h2>
<ul>
<li>CodeQL Python analysis will no longer install dependencies on GitHub Enterprise Server, as is already the case for GitHub.com. See <a href="https://github.com/github/codeql-action/blob/main/#3230---08-jan-2024 ">release notes for 3.23.0</a> for more details. <a href="https://redirect.github.com/github/codeql-action/pull/2106 ">#2106</a></li>
</ul>
<h2>3.23.2 - 26 Jan 2024</h2>
<ul>
<li>On Linux, the maximum possible value for the <code>--threads</code> option now respects the CPU count as specified in <code>cgroup</code> files to more accurately reflect the number of available cores when running in containers. <a href="https://redirect.github.com/github/codeql-action/pull/2083 ">#2083</a></li>
</ul>
</blockquote>
<p>... (truncated)</p>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="05963f47d8https://redirect.github.com/github/codeql-action/issues/2200 ">#2200</a> from github/update-v3.24.8-1ecc2779e</li>
<li><a href="2b9b5215601ecc2779e9https://redirect.github.com/github/codeql-action/issues/2198 ">#2198</a> from github/henrymercer/improve-tracking-autobuild-e...</li>
<li><a href="e28ae3a84cbddfc7c6d53edd1bf72588a0b7abb388b28eb70df055b5e672https://redirect.github.com/github/codeql-action/issues/2197 ">#2197</a> from github/henrymercer/log-job-status</li>
<li><a href="0d680ab61chttps://redirect.github.com/github/codeql-action/issues/2196 ">#2196</a> from github/henrymercer/update-packs-input-description</li>
<li>Additional commits viewable in <a href="3ab4101902...05963f47d8https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=github/codeql-action&package-manager=github_actions&previous-version=3.24.7&new-version=3.24.8 )](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores )
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.
---
<details>
<summary>Dependabot commands and options</summary>
<br />
You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency
- `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
</details>
2024-03-18 22:24:06 +00:00
Danny Tuppeny
89ef73e068
Roll pub packages + update DAP tests ( #145349 )
...
This manually rolls pub packages and updates some calls to use updated APIs that use `Uri` instead of file paths (since macro-generated sources don't exist as files on disk).
2024-03-18 21:39:21 +00:00
sanni prasad
993f554e4c
Fix for issue 140372 ( #144947 )
...
*Continuing work from the PR https://github.com/flutter/flutter/pull/140373 *
Add the ability to set route settings on PopupMenuButton
Fixes https://github.com/flutter/flutter/issues/140372
Added UTs as requested
2024-03-18 21:35:37 +00:00
LongCatIsLooong
98369bdd50
Introduce methods for computing the baseline location of a RenderBox without affecting the current layout ( #144655 )
...
Extracted from https://github.com/flutter/flutter/pull/138369
Introduces `RenderBox.{compute,get}DryBaseline` for computing the baseline location in `RenderBox.computeDryLayout`.
2024-03-18 21:32:22 +00:00
engine-flutter-autoroll
f704560c0b
Roll Flutter Engine from 016206de75bc to 3fde3678a357 (2 revisions) ( #145350 )
...
016206de75...3fde3678a3jason-simmons@users.noreply.github.com Write recent logcat output to the LUCI log directory if an Android unit test fails (flutter/engine#51462 )
2024-03-18 737941+loic-sharma@users.noreply.github.com [Embedder API] Remove view (flutter/engine#51400 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC bdero@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-03-18 20:36:39 +00:00
engine-flutter-autoroll
f84407ec92
Roll Flutter Engine from 90c4d64d410f to 016206de75bc (2 revisions) ( #145345 )
...
90c4d64d41...016206de75magder@google.com Support accessibility back gesture to pop route from view controller (flutter/engine#51241 )
2024-03-18 yjbanov@google.com [web] remove Tappable from basic set of a11y roles; add it case by case (flutter/engine#51466 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC bdero@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-03-18 19:43:29 +00:00
Ricardo Amador
71c1aba10b
Switch hot_mode_dev_cycle_linux__benchmark to run in postsubmit ( #145343 )
...
Switch hot_mode_dev_cycle_linux__benchmark to run in postsubmit.
*List which issues are fixed by this PR. You must list at least one issue. An issue is not required if the PR fixes something trivial like a typo.*
Part of https://github.com/flutter/flutter/issues/145242
*If you had to change anything in the [flutter/tests] repo, include a link to the migration guide as per the [breaking change policy].*
2024-03-18 19:15:22 +00:00
engine-flutter-autoroll
ca39806dbd
Roll Flutter Engine from 9162c8309e24 to 90c4d64d410f (1 revision) ( #145342 )
...
9162c8309e...90c4d64d41jonahwilliams@google.com [Impeller] revert vestiges of submit batching. (flutter/engine#51450 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC bdero@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-03-18 18:53:22 +00:00
Victoria Ashworth
7f368f7ed4
Add --no-dds to Mac_arm64_ios version of hot_mode_dev_cycle_ios__benchmark ( #145335 )
...
Attempting to debug https://github.com/flutter/flutter/issues/142305 .
2024-03-18 18:51:26 +00:00
engine-flutter-autoroll
f4ee956d3e
Roll Flutter Engine from 89fb886a162c to 9162c8309e24 (2 revisions) ( #145336 )
...
89fb886a16...9162c8309e68449066+zijiehe-google-com@users.noreply.github.com [Fuchsia] only download fuchsia deps when necessary (flutter/engine#51439 )
2024-03-18 30870216+gaaclarke@users.noreply.github.com [Impeller] make sure to render TiledTextureContents if the geometry doesn't fit in the texture's bounds. (flutter/engine#51393 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC bdero@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-03-18 18:11:57 +00:00
engine-flutter-autoroll
e1b0005317
Roll Flutter Engine from 86de0f75606f to 89fb886a162c (1 revision) ( #145327 )
...
86de0f7560...89fb886a16skia-flutter-autoroll@skia.org Roll Skia from 9b08a3f3881c to 9950dc8ec6fd (1 revision) (flutter/engine#51490 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC bdero@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-03-18 17:06:24 +00:00
engine-flutter-autoroll
f217fc1739
Roll Packages from 756dcc11180b to a757073ac4ea (3 revisions) ( #145325 )
...
756dcc1118...a757073ac4engine-flutter-autoroll@skia.org Roll Flutter from 71606af8d87c860ddf97flutter/packages#6345 )
2024-03-16 10687576+bparrishMines@users.noreply.github.com [pointer_interceptor_web] Skip broken semantics tests and do a manual roll (flutter/packages#6342 )
2024-03-15 41930132+hellohuanlin@users.noreply.github.com [pigeon]Add hellohuanlin to pigeon iOS for code reviews (flutter/packages#6333 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com ,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-03-18 15:43:22 +00:00
engine-flutter-autoroll
b346eb3443
Roll Flutter Engine from f11015e14d24 to 86de0f75606f (1 revision) ( #145322 )
...
f11015e14d...86de0f7560skia-flutter-autoroll@skia.org Roll Dart SDK from d5cf2d3849ca to 47ab7cca8a83 (1 revision) (flutter/engine#51489 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC bdero@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-03-18 14:54:32 +00:00
Bruno Leroux
50e7f2b84b
InputDecorator M3 tests migration - Step6 - constraints ( #145213 )
...
## Description
This PR migrates `InputDecorator.constraints` related tests to M3 and also various regression tests.
It is the fifth step for the M3 test migration for `InputDecorator`.
Step 1: https://github.com/flutter/flutter/pull/142981
Step 2: https://github.com/flutter/flutter/pull/143369
Step 3: https://github.com/flutter/flutter/pull/143520
Step 4: https://github.com/flutter/flutter/pull/144169
Step 5: https://github.com/flutter/flutter/pull/144932
## Related Issue
Related to https://github.com/flutter/flutter/issues/139076
@justinmc A somewhat small PR, I wanted to migrate the small group related to 'InputDecoration.constraints' (starting at line 2801), it adds a test checking min interactive height and two others that shows one way to bypass the standard min interactive height.
2024-03-18 12:53:14 +00:00
Taha Tesser
06ed849cbc
Update inherited_theme_test.dart, ink_paint_test.dart, ink_splash_test.dart, opacity_test.dart for Material 3 ( #144013 )
...
Updated unit tests for `Tooltip` to have M2 and M3 versions.
More info in #139076
2024-03-18 12:45:22 +00:00
engine-flutter-autoroll
28fea5948c
Roll Flutter Engine from eac9db75f902 to f11015e14d24 (2 revisions) ( #145321 )
...
eac9db75f9...f11015e14dskia-flutter-autoroll@skia.org Roll Skia from d32e7eda9307 to 9b08a3f3881c (1 revision) (flutter/engine#51487 )
2024-03-18 skia-flutter-autoroll@skia.org Roll Skia from 666607a99603 to d32e7eda9307 (1 revision) (flutter/engine#51485 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC bdero@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-03-18 12:35:25 +00:00
engine-flutter-autoroll
c6f2b53efd
Roll Flutter Engine from aebc0021cd18 to eac9db75f902 (1 revision) ( #145308 )
...
aebc0021cd...eac9db75f9skia-flutter-autoroll@skia.org Roll Skia from 38f06cbd2f37 to 666607a99603 (2 revisions) (flutter/engine#51484 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC bdero@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-03-18 07:53:17 +00:00
engine-flutter-autoroll
03b5ea519a
Roll Flutter Engine from 89c775963926 to aebc0021cd18 (1 revision) ( #145305 )
...
89c7759639...aebc0021cdskia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from Ow67Jf4AHxeapVlCa... to I5fL_9DJQBS1Bydbz... (flutter/engine#51482 )
Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from Ow67Jf4AHxea to I5fL_9DJQBS1
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC bdero@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-03-18 05:30:35 +00:00
engine-flutter-autoroll
dd865ce476
Roll Flutter Engine from 5c31faa15ab7 to 89c775963926 (1 revision) ( #145303 )
...
5c31faa15a...89c7759639ian@hixie.ch Minor markup tweaks in render_frame_capture.md (flutter/engine#51480 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC bdero@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-03-18 00:24:27 +00:00
engine-flutter-autoroll
69a3f54013
Roll Flutter Engine from 4c420dd2dfd9 to 5c31faa15ab7 (2 revisions) ( #145294 )
...
4c420dd2df...5c31faa15askia-flutter-autoroll@skia.org Roll Skia from b91914d51880 to 38f06cbd2f37 (1 revision) (flutter/engine#51481 )
2024-03-17 zanderso@users.noreply.github.com Pass some missing --disable-dart-dev and --suppress-analytics to dart (flutter/engine#51473 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC bdero@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-03-17 19:41:23 +00:00
engine-flutter-autoroll
7c860ddf97
Roll Flutter Engine from cfbf11d757d1 to 4c420dd2dfd9 (2 revisions) ( #145280 )
...
cfbf11d757...4c420dd2dfskia-flutter-autoroll@skia.org Roll Dart SDK from 6eb2bc37b91c to d5cf2d3849ca (1 revision) (flutter/engine#51478 )
2024-03-16 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from nTth7xxzAfENAJjMH... to Ow67Jf4AHxeapVlCa... (flutter/engine#51477 )
Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from nTth7xxzAfEN to Ow67Jf4AHxea
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC bdero@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-03-17 03:14:25 +00:00
Ian Hickson
c7123c96cd
Factor out use of "print" in flutter_goldens ( #144846 )
...
This is part 5 of a broken down version of the #140101 refactor.
This PR removes direct use of `print` and replaces it with a callback.
2024-03-17 01:56:19 +00:00
engine-flutter-autoroll
b24b6b1afe
Roll Flutter Engine from dd4050334ff3 to cfbf11d757d1 (1 revision) ( #145275 )
...
dd4050334f...cfbf11d757skia-flutter-autoroll@skia.org Roll Dart SDK from cf4f757cb51e to 6eb2bc37b91c (1 revision) (flutter/engine#51476 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC bdero@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-03-16 21:36:32 +00:00
engine-flutter-autoroll
ed845c7a7c
Roll Flutter Engine from 618ee6c8ba34 to dd4050334ff3 (1 revision) ( #145270 )
...
618ee6c8ba...dd4050334fskia-flutter-autoroll@skia.org Roll Skia from 70bc8aad2a0a to b91914d51880 (1 revision) (flutter/engine#51472 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC bdero@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-03-16 19:28:06 +00:00
engine-flutter-autoroll
16d0731363
Roll Flutter Engine from e4602aa149d8 to 618ee6c8ba34 (1 revision) ( #145266 )
...
e4602aa149...618ee6c8baskia-flutter-autoroll@skia.org Roll Skia from 28701a2820eb to 70bc8aad2a0a (1 revision) (flutter/engine#51470 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC bdero@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-03-16 17:13:24 +00:00
engine-flutter-autoroll
e7baebdce7
Roll Flutter Engine from 91b9cf24d328 to e4602aa149d8 (1 revision) ( #145259 )
...
91b9cf24d3...e4602aa149skia-flutter-autoroll@skia.org Roll Dart SDK from 934c41c1c18e to cf4f757cb51e (1 revision) (flutter/engine#51469 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC bdero@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-03-16 12:56:23 +00:00
auto-submit[bot]
48c1c2313a
Reverts "Reland #128236 "Improve build output for all platforms" ( #143166 )" ( #145261 )
...
Reverts: flutter/flutter#143166
Initiated by: guidezpl
Reason for reverting: breaks devicelab windows tests
Original PR Author: guidezpl
Reviewed By: {loic-sharma}
This change reverts the following previous change:
Reland #128236 , reverted in https://github.com/flutter/flutter/pull/143125 .
This PR contains [one additional commit](199baea9a9https://github.com/flutter/flutter/assets/6655696/ecc52abe-cd2e-4116-b22a-8385ae3e980d ">
<img width="634" alt="image" src="https://github.com/flutter/flutter/assets/6655696/8af8bd33-c0bd-4215-9a06-9652ee019436 ">
### `macos`, `ios`, `ipa`
Build executables are self-contained and use a newly introduced `OperatingSystemUtils.getDirectorySize`.
<img width="514" alt="image" src="https://github.com/flutter/flutter/assets/6655696/b5918a69-3959-4417-9205-4f501d185257 ">
<img width="581" alt="image" src="https://github.com/flutter/flutter/assets/6655696/d72fd420-18cf-4470-9e4b-b6ac10fbcd50 ">
<img width="616" alt="image" src="https://github.com/flutter/flutter/assets/6655696/5f235ce1-252a-4c13-898f-139f6c7bc698 ">
### `windows`, `linux`, and `web`
Build executables aren't self-contained, and folder size can sometimes overestimate distribution size, therefore their size isn't mentioned (see discussion below).
<img width="647" alt="image" src="https://github.com/flutter/flutter/assets/6655696/7179e771-1eb7-48f6-b770-975bc073437b ">
<img width="658" alt="image" src="https://github.com/flutter/flutter/assets/6655696/a6801cab-7b5a-4975-a406-f4c9fa44d7a2 ">
<img width="608" alt="image" src="https://github.com/flutter/flutter/assets/6655696/ee7c4125-a273-4a65-95d7-ab441edf8ac5 ">
### Size reporting
When applicable, the printed size matches the OS reported size.
- macOS
<img width="391" alt="image" src="https://github.com/flutter/flutter/assets/6655696/881cbfb1-d355-444b-ab44-c1a6343190ce ">
- Windows
<img width="338" alt="image" src="https://github.com/flutter/flutter/assets/6655696/3b806def-3d15-48a9-8a25-df200d6feef7 ">
- Linux
<img width="320" alt="image" src="https://github.com/flutter/flutter/assets/6655696/89a4aa3d-2148-4f3b-b231-f93a057fee2b ">
## Related issues
Part of #120127
Fixes https://github.com/flutter/flutter/issues/121401
2024-03-16 12:40:26 +00:00
Pierre-Louis
2fc76c7896
Reland #128236 "Improve build output for all platforms" ( #143166 )
...
Reland #128236 , reverted in https://github.com/flutter/flutter/pull/143125 .
This PR contains [one additional commit](199baea9a9https://github.com/flutter/flutter/assets/6655696/ecc52abe-cd2e-4116-b22a-8385ae3e980d ">
<img width="634" alt="image" src="https://github.com/flutter/flutter/assets/6655696/8af8bd33-c0bd-4215-9a06-9652ee019436 ">
### `macos`, `ios`, `ipa`
Build executables are self-contained and use a newly introduced `OperatingSystemUtils.getDirectorySize`.
<img width="514" alt="image" src="https://github.com/flutter/flutter/assets/6655696/b5918a69-3959-4417-9205-4f501d185257 ">
<img width="581" alt="image" src="https://github.com/flutter/flutter/assets/6655696/d72fd420-18cf-4470-9e4b-b6ac10fbcd50 ">
<img width="616" alt="image" src="https://github.com/flutter/flutter/assets/6655696/5f235ce1-252a-4c13-898f-139f6c7bc698 ">
### `windows`, `linux`, and `web`
Build executables aren't self-contained, and folder size can sometimes overestimate distribution size, therefore their size isn't mentioned (see discussion below).
<img width="647" alt="image" src="https://github.com/flutter/flutter/assets/6655696/7179e771-1eb7-48f6-b770-975bc073437b ">
<img width="658" alt="image" src="https://github.com/flutter/flutter/assets/6655696/a6801cab-7b5a-4975-a406-f4c9fa44d7a2 ">
<img width="608" alt="image" src="https://github.com/flutter/flutter/assets/6655696/ee7c4125-a273-4a65-95d7-ab441edf8ac5 ">
### Size reporting
When applicable, the printed size matches the OS reported size.
- macOS
<img width="391" alt="image" src="https://github.com/flutter/flutter/assets/6655696/881cbfb1-d355-444b-ab44-c1a6343190ce ">
- Windows
<img width="338" alt="image" src="https://github.com/flutter/flutter/assets/6655696/3b806def-3d15-48a9-8a25-df200d6feef7 ">
- Linux
<img width="320" alt="image" src="https://github.com/flutter/flutter/assets/6655696/89a4aa3d-2148-4f3b-b231-f93a057fee2b ">
## Related issues
Part of #120127
Fixes https://github.com/flutter/flutter/issues/121401
2024-03-16 08:13:56 +00:00
Pierre-Louis
3109b1118e
Introduce Split curve ( #143130 )
...
`Split` is a curve that progresses according to `beginCurve` until
`split`, then according to `endCurve`.
This curve is used with bottom sheets to allow linear finger dragging
and non-linear enter/exit animations. This PR cleans up a previously
private class I introduced and replaces it with the more customisable
`Split`.
Fixes https://github.com/flutter/flutter/issues/51627
Diagram to be added with
https://github.com/flutter/assets-for-api-docs/pull/239
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
2024-03-16 09:08:00 +01:00
engine-flutter-autoroll
988bee803c
Roll Flutter Engine from 120e52b8a1c2 to 91b9cf24d328 (1 revision) ( #145256 )
...
120e52b8a1...91b9cf24d3skia-flutter-autoroll@skia.org Roll Skia from 05e1b6675da4 to 28701a2820eb (1 revision) (flutter/engine#51468 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC bdero@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-03-16 08:06:12 +00:00
engine-flutter-autoroll
360d46fadf
Roll Flutter Engine from 3abc25139959 to 120e52b8a1c2 (1 revision) ( #145254 )
...
3abc251399...120e52b8a1skia-flutter-autoroll@skia.org Roll Skia from 2d46a81facd8 to 05e1b6675da4 (1 revision) (flutter/engine#51467 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC bdero@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-03-16 07:10:29 +00:00
engine-flutter-autoroll
483aa35c9d
Roll Flutter Engine from 6f180615e6ac to 3abc25139959 (1 revision) ( #145253 )
...
6f180615e6...3abc251399skia-flutter-autoroll@skia.org Roll Dart SDK from 2241333f69f3 to 934c41c1c18e (1 revision) (flutter/engine#51465 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC bdero@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-03-16 06:16:25 +00:00
Jenn Magder
a2678be7ad
Platform view devicelab ad banner scroll list real ads ( #145239 )
...
Reland https://github.com/flutter/flutter/pull/144745 , which was reverted due to a the Android app ads not being set up correctly, crashing on launch: https://github.com/flutter/flutter/pull/145228
Add the missing [`com.google.android.gms.ads.APPLICATION_ID` `meta-data` tag](https://developers.google.com/admob/android/quick-start#import_the_mobile_ads_sdk ) to the manifest.
Validated both `platform_views_scroll_perf__timeline_summary` and `platform_views_scroll_perf_impeller__timeline_summary` ran locally on an Android emulator.
Successful presubmit runs:
https://ci.chromium.org/ui/p/flutter/builders/try/Linux_pixel_7pro%20platform_views_scroll_perf__timeline_summary/4/overview
https://ci.chromium.org/ui/p/flutter/builders/try/Linux_pixel_7pro%20platform_views_scroll_perf_impeller__timeline_summary/4/overview
Original commit message:
_________
This benchmark is to measure the platform view performance improvement.
It is similar to https://github.com/lucalooz/flutter_ads_list_perf
There's still a pending issue https://github.com/flutter/flutter/issues/144339
Fixes https://github.com/flutter/flutter/issues/143534
Fixes https://github.com/flutter/flutter/issues/143257
2024-03-16 05:44:21 +00:00
engine-flutter-autoroll
7599666511
Roll Flutter Engine from 6ddaa40bf1a6 to 6f180615e6ac (1 revision) ( #145251 )
...
6ddaa40bf1...6f180615e6flar@google.com Silence gn warning about unused Skia flag (flutter/engine#51464 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC bdero@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-03-16 03:57:06 +00:00
engine-flutter-autoroll
33bf4757f2
Roll Flutter Engine from d46c1fa17dda to 6ddaa40bf1a6 (1 revision) ( #145250 )
...
d46c1fa17d...6ddaa40bf1flar@google.com Reland "Add DisplayList Region and Transform benchmarks to CI" (flutter/engine#51458 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC bdero@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-03-16 03:03:40 +00:00
engine-flutter-autoroll
2ac7b95a94
Roll Flutter Engine from 7f15dc1200bc to d46c1fa17dda (2 revisions) ( #145248 )
...
7f15dc1200...d46c1fa17dskia-flutter-autoroll@skia.org Roll Dart SDK from 03cc4d817056 to 2241333f69f3 (2 revisions) (flutter/engine#51461 )
2024-03-16 chinmaygarde@google.com Re-land "[Impeller] A toolkit for managed handles to Android NDK vended objects." (flutter/engine#51460 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC bdero@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-03-16 02:18:08 +00:00
LongCatIsLooong
cc01701781
Use a separate TextPainter for intrinsics calculation in RenderEditable and RenderParagraph ( #144577 )
...
Use a dedicated `TextPainter` for intrinsic size calculation in `RenderEditable` and `RenderParagraph`.
This is an implementation detail so the change should be covered by existing tests. Performance wise this shouldn't be significantly slower since SkParagraph [caches the result of slower operations across different paragraphs](9c62e7b382/modules/skparagraph/src/ParagraphCache.cpp (L254-L272)
2024-03-16 01:15:19 +00:00
engine-flutter-autoroll
15e90ad224
Roll Flutter Engine from 2db915c64e6e to 7f15dc1200bc (1 revision) ( #145245 )
...
2db915c64e...7f15dc1200skia-flutter-autoroll@skia.org Roll Skia from 11b1a958c2ac to 2d46a81facd8 (11 revisions) (flutter/engine#51459 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC bdero@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-03-16 00:34:48 +00:00
engine-flutter-autoroll
20105db16c
Roll Flutter Engine from ba1115c30381 to 2db915c64e6e (2 revisions) ( #145240 )
...
ba1115c303...2db915c64e737941+loic-sharma@users.noreply.github.com [Windows] Move to new present callback (flutter/engine#51293 )
2024-03-15 matanlurey@users.noreply.github.com Log messages when an image successfully uploads to Skia Gold (flutter/engine#51455 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC bdero@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-03-15 23:48:27 +00:00
engine-flutter-autoroll
55d8b20df1
Roll Flutter Engine from c2fd5333a5d2 to ba1115c30381 (3 revisions) ( #145237 )
...
c2fd5333a5...ba1115c303matanlurey@users.noreply.github.com Add more explicit logging (just to `stderr`) if a try-job detects an untriaged image (flutter/engine#51454 )
2024-03-15 98614782+auto-submit[bot]@users.noreply.github.com Reverts "[Impeller] A toolkit for managed handles to Android NDK vended objects. (#51334 )" (flutter/engine#51457 )
2024-03-15 chinmaygarde@google.com [Impeller] A toolkit for managed handles to Android NDK vended objects. (flutter/engine#51334 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC bdero@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-03-15 23:04:24 +00:00
yusuf-goog
1c153c38d2
Renaming the virtual device Nexus5 name to Nexus5.gce_x86 ( #145225 )
...
This is required to match a rename being made for the devices in firebase lab.
Also removed `version=24` entry, since thats not supported on Nexus5x, per the firebase team.
Bug:b/322830672
*Replace this paragraph with a description of what this PR is changing or adding, and why. Consider including before/after screenshots.*
*List which issues are fixed by this PR. You must list at least one issue. An issue is not required if the PR fixes something trivial like a typo.*
*If you had to change anything in the [flutter/tests] repo, include a link to the migration guide as per the [breaking change policy].*
2024-03-15 22:50:21 +00:00
