Jonah Williams
f7bd03202f
[devicelab] boot up benchmarks. ( #132148 )
...
Enable Impeller benchmarks for drawAtlas/drawVertices on iOS/Metal, Android/GLES, and Android/Vulkan.
Enable impeller tessellation benchmarks on iOS/Metal and Android/Vulkan - not GLES as this is measuring backend agnostic performance.
2023-08-14 18:47:08 +00:00
Victoria Ashworth
fff08248b3
Disable Xcode Debug tests ( #132398 )
...
Temporarily removes Xcode debug tests.
Xcode tests are currently failing in CI for some infra-related issues. I have a fix for it (https://github.com/flutter/flutter/pull/132318 ) that I confirmed worked in presubmit, but I think the logic is better suited to live in recipes. However, it's going to be a bit of a learning curve to update recipes and might take me a couple days so disabling them in the meantime.
Tracking issue to readd when ready: https://github.com/flutter/flutter/issues/132309
2023-08-11 18:24:23 +00:00
Zachary Anderson
bd1bb675b3
Remove bringup from Windows build_tests shards ( #132306 )
...
Context:
aff8ef13d4
2023-08-10 09:25:02 -07:00
Victoria Ashworth
d631b26285
New tooling for iOS 17 physical devices ( #131865 )
...
This PR includes the following changes. These changes only apply to iOS 17 physical devices.
| Command | Change Description | Changes to User Experience |
| ------------- | ------------- | ------------- |
| `flutter run --release` | Uses `devicectl` to install and launch application in release mode. | No change. |
| `flutter run` | Uses Xcode via automation scripting to run application in debug and profile mode. | Xcode will be opened in the background. Errors/crashes may be caught in Xcode and therefore may not show in terminal. |
| `flutter run --use-application-binary=xxxx` | Creates temporary empty Xcode project and use Xcode to run via automation scripting in debug and profile. | Xcode will be opened in the background. Errors/crashes may be caught in Xcode and therefore may not show in terminal. |
| `flutter install` | Uses `devicectl` to check installed apps, install app, uninstall app. | No change. |
| `flutter screenshot` | Will return error. | Will return error. |
Other changes include:
* Using `devicectl` to get information about the device
* Using `idevicesyslog` and Dart VM logging for device logs
Note:
Xcode automation scripting (used in `flutter run` for debug and profile) does not work in a headless (without a UI) interface. No known workaround.
Fixes https://github.com/flutter/flutter/issues/128827 , https://github.com/flutter/flutter/issues/128531 .
2023-08-09 19:25:12 +00:00
gaaclarke
1ff82af540
[Impeller] Adds advanced blend benchmark ( #131893 )
...
issue: https://github.com/flutter/flutter/issues/131784
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
2023-08-09 10:57:35 -07:00
Ricardo Amador
45383deffa
Mark the ci_yaml roller task so that it is not backfilled. ( #131966 )
...
In order to avoid new tasks from not being scheduled we are not going to backfill the autoroller because it can sometimes play transactions out of order causing issues with tasks that are scheduled but not known.
*List which issues are fixed by this PR. You must list at least one issue.*
Part of https://github.com/flutter/flutter/issues/127063
*If you had to change anything in the [flutter/tests] repo, include a link to the migration guide as per the [breaking change policy].*
2023-08-05 01:18:10 +00:00
Christopher Fujino
a2fa60cc4d
mark linux packages_autoroller flaky because of token issue ( #131970 )
...
unblock tree from https://github.com/flutter/flutter/issues/131968
2023-08-04 18:00:14 -07:00
gaaclarke
f0e39349c9
[Impeller] Add animated_blur_backdrop_filter_perf execution on samsung vulkan and opengles ( #131864 )
...
issue: https://github.com/flutter/flutter/issues/131784
2023-08-03 22:31:06 +00:00
gaaclarke
4247e1eff1
Added new gallery benchmark test that forces opengles. ( #131796 )
...
fixes https://github.com/flutter/flutter/issues/131782
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
---------
Co-authored-by: Xilai Zhang <xilaizhang@google.com>
2023-08-03 12:25:29 -07:00
Chris Yang
13ff16cba9
remove Mac_ios ios_app_with_extensions_test ( #131806 )
...
Removing the extension test that unnecessarily running with devices.
The new hostonly tests were added in https://github.com/flutter/flutter/pull/131441
2023-08-03 16:28:58 +00:00
Mahmoud Zayad
22f029e582
Remove target Staging_build_linux framework_tests_misc ( #126959 )
...
I deleted the target mentioned in the issue listed below. This is my first time contributing to open source please explain if I did anything wrong in the process or wrong with the changes.
Best
*List which issues are fixed by this PR. You must list at least one issue.*
Resolves [#126278 ](https://github.com/flutter/flutter/issues/126278 )
2023-08-03 15:50:59 +00:00
Chris Yang
12b8e0cb0e
add gem dependency to the ios_app_with_extensions_test ( #131713 )
...
Adds gem dependency to the tests
Fixes https://github.com/flutter/flutter/issues/131693
2023-08-02 18:37:06 +00:00
Elias Yishak
aff8ef13d4
Update .ci.yaml to add new shard to prevent timeouts ( #131712 )
...
Fixes:
- https://github.com/flutter/flutter/issues/131327
It was observed that the tests would hit their 30 minute timeout so this PR adds another shard to reduce how many tests are run per shard to reduce test run time
2023-08-02 17:26:44 +00:00
Chris Yang
3c8c3004f3
Move ios_app_with_extensions_test to host only ( #131441 )
...
`ios_app_with_extensions_test` only builds the artifact, it does not need a device to run.
This PR adds the copies of these tests to run hostonly. When the new tests pass in post submit, we should remove the old ones.
2023-07-28 15:42:35 +00:00
Jackson Gardner
e81907e07a
Update Chrome to 115, and remove bringup: true
from skwasm benchmarks. ( #131430 )
...
Recent changes to binaryen cause us to need to update to Chrome 115 for our wasm benchmarks.
2023-07-28 15:04:19 +00:00
Loïc Sharma
81b0e9f111
Revert "Run benchmarks with --omit-type-checks
" ( #131353 )
...
Reverts flutter/flutter#131102 as it closed the tree due to `Linux web_benchmarks_skwasm` failures. The test seems to be timing out without completing.
Example failure: https://ci.chromium.org/ui/p/flutter/builders/prod/Linux%20web_benchmarks_skwasm/1/overview
2023-07-26 19:23:37 +00:00
Jackson Gardner
8046e13373
Run benchmarks with --omit-type-checks
( #131102 )
...
We've decided to use the `--omit-type-checks` flag for our dart2wasm benchmarks. Right now, many of the benchmark results are dominated by type checks and most of what we are actually trying to measure get drowned out in the noise.
2023-07-26 17:10:07 +00:00
Dan Field
764095ce1a
[CI/FTL] Oriole to Panther, presubmit false ( #130912 )
...
Alternative to https://github.com/flutter/flutter/pull/130868
Oriole is the Pixel 6, Panther is the Pixel 7. Panther is more available in FTL at this point.
There's less value in running this on presubmit, since those can spawn many jobs multiple times over as people push new commits to branches. Let's just run it post submit to avoid overloading the capacity of FTL.
2023-07-21 18:21:22 +00:00
Zachary Anderson
3b0b670d91
Mark Windows_android channels_integration_test_win flaky ( #130893 )
...
For https://github.com/flutter/flutter/issues/130732
2023-07-19 08:39:43 -07:00
Reid Baker
7a42ed7ef6
Update to valid build tools variant and update lockfiles ( #125825 )
...
https://github.com/flutter/flutter/issues/125331
2023-07-17 15:57:08 +00:00
Ricardo Amador
4d7bffe7f5
Remove use_emulator flag ( #130634 )
...
MInor cleanup to remove the use_emulator flag as adding the virtual device is enough to signal use of an emulator.
Land after https://flutter-review.googlesource.com/c/recipes/+/47341
*List which issues are fixed by this PR. You must list at least one issue.*
Fixes https://github.com/flutter/flutter/issues/130522
*If you had to change anything in the [flutter/tests] repo, include a link to the migration guide as per the [breaking change policy].*
2023-07-14 23:52:49 +00:00
Zachary Anderson
e1d025ae54
Move straggling Android Impeller test to staging. ( #130529 )
2023-07-13 15:31:02 -07:00
Jonah Williams
0e543889ec
mark android impeller tests as bringup ( #130525 )
...
These should not close the tree as this backend is a WIP.
2023-07-13 14:35:30 -07:00
Dan Field
13283f86cb
Revert "Marks Linux firebase_oriol33_abstract_method_smoke_test to be unflaky" ( #130497 )
...
Reverts flutter/flutter#128398
See e.g.
https://ci.chromium.org/ui/p/flutter/builders/try/Linux%20firebase_oriol33_abstract_method_smoke_test/350/overview
2023-07-13 08:55:36 -07:00
Christopher Fujino
b89bfd8e37
re-enable "Linux packages_autoroller" ( #130088 )
...
Fixes https://github.com/flutter/flutter/issues/129744
This change:
1. re-enables the Linux packages_autoroller
2. ensures we redact the token from appearing in any logs (in local testing I realized some failure logs might still expose the token)
What actually fixed authentication however was creating and uploading a new GitHub personal access token, not this change.
It's currently failing post-submit because being marked `bringup` it is running in the try pool, which does not have permissions to access the cloud KMS. However, I ran a LED build in the prod pool that succeeded:
3a8f128c35/+/build.proto
?server=chromium-swarm.appspot.com
2023-07-10 19:32:56 +00:00
Flutter GitHub Bot
c8265f81cf
Marks Linux firebase_oriol33_abstract_method_smoke_test to be unflaky ( #128398 )
...
<!-- meta-tags: To be used by the automation script only, DO NOT MODIFY.
{
"name": "Linux firebase_oriol33_abstract_method_smoke_test"
}
-->
The test has been passing for [50 consecutive runs](https://data.corp.google.com/sites/flutter_infra_metrics_datasite/flutter_check_test_flakiness_status_dashboard/?p=BUILDER_NAME:%22Linux%20firebase_oriol33_abstract_method_smoke_test%22 ).
This test can be marked as unflaky.
2023-07-06 19:42:24 +00:00
Christopher Fujino
97fce9aa19
mark packages-autoroller bringup again ( #129859 )
...
Even after updating the account (and the cloudKMS GitHub token), when
the bot tries to push to
https://github.com/flutter-pub-roller-bot/flutter , it gets a 403, which
probably means authentication failed. I will have to investigate next
week.
```
Exception: GitException: Exception on command "push https://[GitHub TOKEN]@github.com/flutter-pub-roller-bot/flutter.git packages-autoroller-branch-1:packages-autoroller-branch-1": Command "git push https://[GitHub TOKEN]@github.com/flutter-pub-roller-bot/flutter.git packages-autoroller-branch-1:packages-autoroller-branch-1" failed in directory "/b/s/w/ir/x/w/flutter_conductor_checkouts/framework" to update the release branch with the commit. Git exited with error code 128.
stderr from git:
16:33:21.199510 exec-cmd.c:90 trace: resolved executable path from procfs: /b/s/w/ir/cipd_bin_packages/bin/git
16:33:21.199587 exec-cmd.c:237 trace: resolved executable dir: /b/s/w/ir/cipd_bin_packages/bin
16:33:21.200155 git.c:460 trace: built-in: git push https://[GitHub TOKEN]@github.com/flutter-pub-roller-bot/flutter.git packages-autoroller-branch-1:packages-autoroller-branch-1
16:33:21.200542 run-command.c:655 trace: run_command: GIT_DIR=.git git remote-https https://[GitHub TOKEN]@github.com/flutter-pub-roller-bot/flutter.git https://[GitHub TOKEN]@github.com/flutter-pub-roller-bot/flutter.git
16:33:21.201787 exec-cmd.c:90 trace: resolved executable path from procfs: /b/s/w/ir/cipd_bin_packages/libexec/git-core/git
16:33:21.201845 exec-cmd.c:237 trace: resolved executable dir: /b/s/w/ir/cipd_bin_packages/libexec/git-core
16:33:21.202175 git.c:750 trace: exec: git-remote-https https://[GitHub TOKEN]@github.com/flutter-pub-roller-bot/flutter.git https://[GitHub TOKEN]@github.com/flutter-pub-roller-bot/flutter.git
16:33:21.202195 run-command.c:655 trace: run_command: git-remote-https https://[GitHub TOKEN]@github.com/flutter-pub-roller-bot/flutter.git https://[GitHub TOKEN]@github.com/flutter-pub-roller-bot/flutter.git
16:33:21.203510 exec-cmd.c:90 trace: resolved executable path from procfs: /b/s/w/ir/cipd_bin_packages/libexec/git-core/git-remote-http
16:33:21.203567 exec-cmd.c:237 trace: resolved executable dir: /b/s/w/ir/cipd_bin_packages/libexec/git-core
remote: Permission to flutter-pub-roller-bot/flutter.git denied to flutter-pub-roller-bot.
fatal: unable to access 'https://github.com/flutter-pub-roller-bot/flutter.git/ ': The requested URL returned error: 403
```
https://ci.chromium.org/ui/p/flutter/builders/prod/Linux%20packages_autoroller/6031/overview
This is still being tracked in
https://github.com/flutter/flutter/issues/129744
2023-06-30 16:54:55 -07:00
Christopher Fujino
67b7aa22c2
Change pub roller bot to push to flutter-pub-roller-bot/flutter.git ( #129844 )
...
Fixes https://github.com/flutter/flutter/issues/129744
Part of https://github.com/flutter/flutter/issues/129847
Migrate the packages_autoroller script to push to
flutter-pub-roller-bot/flutter.git, rather than
fluttergithubbot/flutter.git.
2023-06-30 16:28:00 -07:00
gmackall
d1eb1f0a57
Upgrade integration tests to use AGP 7.3/Gradle 7.4 ( #129642 )
...
Upgrades tests under `dev/integration_tests` to use the latest values [in the templates](944d6c8fef/dev/tools/bin/generate_gradle_lockfiles.dart (L135)
). Most of this PR was auto-generated, by running `find dev/integration_tests/ -type d -name 'android' | dart dev/tools/bin/generate_gradle_lockfiles.dart` from the root of the flutter directory.
The pieces that were not are:
1. Upgrading the Gradle versions used in integration tests to be >=7.4, in places where it was currently lower.
2. Upgrading the mac, windows, and linux build_tests .ci.yaml configuration to use jdk 17 on all shards. It currently was using a mix of 17 and 11. This isn't desirable, because some of the tests require 17, and the distribution is [random across shards](cef9a8c54b/dev/bots/test.dart (L553)
) (so they were only passing because they were getting randomly placed on shards using jdk 17).
3. Adding a dependency on jdk 11 for the tests based on the `firebaselab/firebaselab` recipe. Previously they had no java dependency, and were therefore defaulting to java 1.8. The newer AGP versions necessitated an upgrade to 11 to run.
Note that it also ended up downgrading the AGP version in two places (in the [hybrid_android_views](https://github.com/flutter/flutter/pull/129642/files#diff-d7cfaa1c96d5c2383e7fc253ac8c9df062b544c24f7d80aa8a02290c01d17205L17 ) and [platform_interaction](https://github.com/flutter/flutter/pull/129642/files#diff-b2fba811efadd1cfb097bebd93be99fe4b6d6f17aefa863267290fc704290766L17 ) tests), because those had been manually edited to a newer version than the template.
Related to: https://github.com/flutter/flutter/issues/123636 , https://github.com/flutter/flutter/pull/123910
2023-06-30 19:34:20 +00:00
Jackson Gardner
1b887c72b5
Skwasm benchmarks. ( #129681 )
...
This enables benchmarks for the Skwasm renderer, compiled with
dart2wasm.
Platform views aren't supported in Skwasm yet, so we are skipping those
benchmarks for now.
2023-06-28 17:16:19 -07:00
Christopher Fujino
c1b764a80f
mark autoroller flaky ( #129745 )
...
Unblock tree while I investigate: https://github.com/flutter/flutter/issues/129744
2023-06-28 23:26:56 +00:00
Victoria Ashworth
9531cd4000
Update Xcode to 14.3.1 ( #129024 )
...
Framework part of https://github.com/flutter/flutter/issues/129019
2023-06-27 18:21:33 +00:00
Brandon DeRosier
b898d1d270
[devicelab] Add platform view scroll benchmarks for Impeller on Android ( #129455 )
...
For tracking perf improvements with changes like
https://github.com/flutter/engine/pull/43152 .
2023-06-23 18:40:17 -07:00
godofredoc
929468e171
Add a devicelab test to recipes cq. ( #129411 )
...
This is to ensure the devicelab_drone recipe is tested on presubmit.
Bug: https://github.com/flutter/flutter/issues/126111
2023-06-23 17:38:38 +00:00
Kate Lovett
309e50173e
Run misc test shard when examples/api/** change ( #129433 )
...
Fixes https://github.com/flutter/flutter/issues/129390
Found in https://github.com/flutter/flutter/pull/129381 , changing sample code in `examples/api` did not trigger the misc test shard that executes the tests for `examples/api`.
2023-06-23 16:46:04 +00:00
godofredoc
f582c0c573
Add comments to .ci.yaml that were removed from recipes. ( #129321 )
...
Firebaselab recipe was cleaned up and comments removed. This is adding the still valid comments to the .ci.yaml file.
2023-06-23 05:10:54 +00:00
gmackall
51f659825e
Unpin path_provider_android ( #129205 )
...
Unpins path_provider_android where it is pinned. Follows the same steps as https://github.com/flutter/flutter/pull/128898 .
Fixes https://github.com/flutter/flutter/issues/116376
2023-06-22 21:22:49 +00:00
godofredoc
dffef2715e
Move all the firebase lab device configs to .ci.yaml. ( #129219 )
...
Bug: https://github.com/flutter/flutter/issues/129211
2023-06-21 01:10:07 +00:00
Jackson Gardner
54e27e3ed5
Update Chrome version for testing ( #128447 )
...
Most of the tests are using Chrome 96.2, which is quite old. Update to Chrome 114.
2023-06-08 15:37:06 +00:00
Reid Baker
b4796915b3
i127682 android api 33 test support ( #127689 )
...
- try to set emulator to version 33 to see what happens
#127682
2023-05-31 16:38:16 +00:00
godofredoc
7d310e3b1b
Add oriol_33 firebaselab configuration. ( #127894 )
...
This allows to run the api 33 as a separate build.
Bug: https://github.com/flutter/flutter/issues/127884
Bug: https://github.com/flutter/flutter/issues/118736
2023-05-31 00:19:58 +00:00
keyonghan
2b4e303b5a
Remove legacy xcode properties/dependencies ( #127724 )
...
Now only $flutter/osx_sdk property is being used, and it's safe to remove deprecated entries from ci.yaml.
Part of https://github.com/flutter/flutter/issues/127534
2023-05-30 23:14:02 +00:00
keyonghan
3eecc217cf
Append $flutter/osx sdk property to existing platforms/targets relying on xcode ( #127537 )
...
Part of https://github.com/flutter/flutter/issues/127534
2023-05-25 22:47:31 +00:00
keyonghan
784ebdf2a3
Run Mac intel only targets on both intel and arm ( #127230 )
...
The slowness issue was resolved with latest xcode: https://github.com/flutter/flutter/issues/119750 , and all these targets should resume on both platforms as before. This will help mitigate high queue time on intel bots.
This PR updates these targets:
- Mac plugin_test_ios: https://github.com/flutter/flutter/issues/119764
- Mac build_tests: https://github.com/flutter/flutter/pull/120620
- Mac plugin_test: https://github.com/flutter/flutter/pull/120714
- Mac plugin_test_macos: https://github.com/flutter/flutter/pull/122212
- Mac framework_tests_misc: https://github.com/flutter/flutter/pull/122618
2023-05-19 23:22:25 +00:00
Zachary Anderson
31a16f342e
Roll goldctl to f808dcff91b221ae313e540c09d79696cd08b8de ( #127218 )
...
goldctl hasn't been updated in about a year, and an update may be needed to reland https://github.com/flutter/flutter/pull/127110 .
2023-05-19 18:52:50 +00:00
Christopher Fujino
344c9c6af2
mark windows build tests non-bringup ( #127059 )
...
This is a follow-up to aa0a1a7ae1
. I was forced to mark these targets bringup in that PR because the targets were technically new (since each name changed 3 -> 4), so this is marking them non-bringup.
2023-05-18 17:08:21 +00:00
Christopher Fujino
aa0a1a7ae1
shard windows build tests 3 -> 4 ( #127057 )
...
Time outs are currently making the tree red.
Fixes https://github.com/flutter/flutter/issues/127004
2023-05-17 15:49:35 -07:00
godofredoc
25a9efe994
Fix drone_dimensions. ( #126953 )
...
Use drone_dimensions instead of dimensions for builds running on dart-internal. This is required for those builders to select the correct drone type.
2023-05-16 22:11:21 +00:00
keyonghan
3f01c7e019
Move Mac_build_test flutter_gallery__transition_perf_e2e_ios
to prod ( #126941 )
...
Target `Mac_build_test flutter_gallery__transition_perf_e2e_ios` was enabled in staging: https://github.com/flutter/flutter/pull/111164 , and it has passed more than 50 runs: https://ci.chromium.org/p/flutter/builders/staging/Mac_build_test%20flutter_gallery__transition_perf_e2e_ios?limit=50 .
Manually enabling it in prod and removing the old `Mac_ios flutter_gallery__transition_perf_e2e_ios`.
The `Mac_build_test` one does the same thing as `Mac_ios` one, but separating build and test steps in separate targets.
Context: https://github.com/flutter/flutter/issues/103542
2023-05-16 21:46:06 +00:00
Jonah Williams
41abe998ee
[devicelab] add drawPoints benchmark ( #126728 )
...
Add a benchmark that measures the improvements from https://github.com/flutter/engine/pull/41803
2023-05-15 19:14:58 +00:00
Zachary Anderson
674b1ad0ae
Remove obsolete iOS benchmark ( #126862 )
...
Fixes https://github.com/flutter/flutter/issues/126861
2023-05-15 19:12:56 +00:00
Reid Baker
159ebf736a
Mark no longer flakey tests as bringup:false ( #126281 )
...
This is a result of auditing the ci.yaml tests marked as bringup true and determining which ones were still flakey.
Each commit markes one tests as non flakey along with a link of proof of the lack of flakes.
- Mark new_gallery_impeller__transition_perf as not flakey, #124699 closed, not recent flakes
- No failures in 500 runs for Staging_build_linux analyze https://ci.chromium.org/p/flutter/builders/staging/Staging_build_linux%20analyze\?cursor\=id%3E8782771663962116337\&limit\=200
- No flakes in 600 builds https://ci.chromium.org/p/flutter/builders/staging/Linux%20flutter_packaging_test\?cursor\=id%3E8787892377160059793\&limit\=200
- No flakes in 600 builds https://ci.chromium.org/p/flutter/builders/staging/Mac%20flutter_packaging_test\?cursor\=id%3E8787870631931126673\&limit\=200
- No flakes in 600 builds https://ci.chromium.org/p/flutter/builders/staging/Mac_arm64%20flutter_packaging_test\?cursor\=id%3E8787809799161254193\&limit\=200
#124699 is the only closed bug that was linked for a test that is no longer flakey. Closed status helps the case that flakes are no longer an issue.
2023-05-15 18:12:52 +00:00
Zachary Anderson
468512e057
Increase test timeout for analyzer_benchmark to 60 minutes ( #126586 )
...
Fixes https://github.com/flutter/flutter/issues/126451
2023-05-12 08:45:14 -07:00
godofredoc
fa117aad28
Add dimensions to release builds. ( #126117 )
...
Release builds running in dart internal require the dimensions to be set explicitly at the target level in ci.yaml.
Bug: https://github.com/flutter/flutter/issues/126116
2023-05-11 17:28:08 +00:00
keyonghan
a7a1ddfb5a
Add cpu: x86
dimension and xcode dependency for Mac_build_test targets ( #126482 )
...
This is a follow up of https://github.com/flutter/flutter/pull/111164 .
My local LED was based on `cpu: x86` dimension and `xcode` dependency. But these are missed in the above PR, which caused test failure: https://ci.chromium.org/ui/p/flutter/builders/staging/Mac_build_test%20flutter_gallery__transition_perf_e2e_ios/19/overview
2023-05-11 16:41:26 +00:00
keyonghan
8ab782d08a
Migrate gallery ios tests to build+test ( #111164 )
...
Part of https://github.com/flutter/flutter/issues/103542
2023-05-10 00:50:11 +00:00
Reid Baker
0fdddd67f9
Test AGP 8.0 using java 17 ( #125323 )
...
- Update Gradle/AGP version and add namespace plus dependencies.
https://github.com/flutter/flutter/issues/125181
2023-05-08 15:02:31 +00:00
Drew Roen
9de9a81b80
Bring back the failing build_test's ( #126014 )
...
https://github.com/flutter/flutter/issues/125897
The issue has been resolved, so bringing the tests out of bringup
2023-05-05 15:54:43 +00:00
Jenn Magder
4f3c989bd3
Remove complex_layout_*__compile
benchmarks ( #126023 )
...
Fixes https://github.com/flutter/flutter/issues/126020 .
2023-05-03 23:49:01 +00:00
Flutter GitHub Bot
15bd29c8e2
Marks Linux_android slider_perf_android to be unflaky ( #125968 )
...
<!-- meta-tags: To be used by the automation script only, DO NOT MODIFY.
{
"name": "Linux_android slider_perf_android"
}
-->
The test has been passing for [50 consecutive
runs](https://data.corp.google.com/sites/flutter_infra_metrics_datasite/flutter_check_test_flakiness_status_dashboard/?p=BUILDER_NAME:%22Linux_android%20slider_perf_android%22 ).
This test can be marked as unflaky.
2023-05-03 09:22:21 -07:00
Chris Yang
9fcb42d0dd
Update xcode to 14e222b ( #125716 )
...
Framework part of https://github.com/flutter/flutter/issues/125814
2023-05-02 19:56:17 +00:00
Jenn Magder
cc9a3d9d95
Mark microbenchmarks_ios unflaky ( #125332 )
...
This hasn't flaked for > 50 commits which is our threshhold. Marking as unflaky.
2023-05-02 19:34:40 +00:00
godofredoc
d0069bec94
Mark build_test builds as bringup. ( #125898 )
...
They require an additional dimension to be passed as part of the
.ci.yaml configuration.
Bug: https://github.com/flutter/flutter/issues/125897
## Pre-launch Checklist
- [X] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [X] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [X] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [X] I signed the [CLA].
- [X] I listed at least one issue that this PR fixes in the description
above.
- [X] I updated/added relevant documentation (doc comments with `///`).
- [X] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [X] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
2023-05-02 12:22:56 -07:00
Zachary Anderson
fef41cfce0
Remove bringup from new_gallery_skia_ios__transition_perf ( #125715 )
...
Final step of https://github.com/flutter/flutter/pull/125663
2023-04-28 15:31:19 -07:00
Zachary Anderson
50f83fc277
Add back one Skia test on iOS ( #125663 )
...
Fixes https://github.com/flutter/flutter/issues/125648
2023-04-28 10:41:33 -07:00
Taha Tesser
746cacc501
Add slider_perf_android
task to ci.yaml
( #125540 )
...
This adds `devicelab` task `slider_perf_android` to `.ci.yaml`, which was added in https://github.com/flutter/flutter/pull/125296
2023-04-27 21:32:39 +00:00
Jenn Magder
28e17177fd
Mark module_test_ios tests unflaky ( #125498 )
...
[Dart workaround](https://dart-review.googlesource.com/c/sdk/+/297821 ) to prevent the flake has rolled into the framework. Mark the tests unflaky so we can detect if it happens again when a fix for the underlying issue lands.
https://github.com/flutter/flutter/issues/125425#issuecomment-1522142360
Reverts https://github.com/flutter/flutter/pull/125426
2023-04-27 18:09:25 +00:00
Zachary Anderson
1d30a1fc5a
Remove flavors_test_macos ( #125581 )
...
This test has been failing for the past >1000 runs, and is wedging a bot
for 30 minutes as the failure mode is a timeout.
Fixes https://github.com/flutter/flutter/issues/119782
2023-04-26 14:02:49 -07:00
Zachary Anderson
66fa4c5d30
Remove web compile benchmarks that specify an attached device ( #125559 )
...
Fixes https://github.com/flutter/flutter/issues/125492
2023-04-26 09:37:56 -07:00
Zachary Anderson
53cba8fd49
Add hostonly web compile size benchmarks ( #125518 )
...
First part of https://github.com/flutter/flutter/issues/125492
2023-04-25 19:11:12 -07:00
keyonghan
624bdd38b0
Mark module_test_ios flaky ( #125426 )
...
https://github.com/flutter/flutter/issues/125425
2023-04-24 18:46:50 +00:00
Jenn Magder
9e2e64c7c0
Do not run windows_home_scroll_perf__timeline_summary
benchmark in presubmit ( #125343 )
...
Introduced in https://github.com/flutter/flutter/pull/99564 . Checked with @jonahwilliams and this should not be running in presubmit.
2023-04-24 18:33:21 +00:00
Jenn Magder
baafa1991d
Combine flutter_tool_startup
devicelab tests ( #125226 )
...
`flutter_tool_startup__windows/linux/macos` were identical. Use the same task for all three.
2023-04-21 22:33:07 +00:00
keyonghan
d186792c00
Update xcode to 14c18 for host only bots ( #125211 )
...
With https://flutter-review.googlesource.com/c/recipes/+/42160 , we are
ready to make all tests consistent with xcode 14c18.
> auto label is removed for flutter/flutter, pr: 125211, due to This PR has not met approval requirements for merging. Changes were requested by {jmagman}, please make the needed changes and resubmit this PR. You have project association MEMBER and need 1 more review(s) in order to merge this PR.
>
> * Merge guidelines: You need at least one approved review if you are already a MEMBER or two member reviews if you are not a MEMBER before re-applying the autosubmit label. **Reviewers**: If you left a comment approving, please use the "approve" review action instead.
Sounds an auto-submit bug. Manually submit.
2023-04-20 20:50:59 -07:00
Casey Hillers
7d2669b8e7
[ci.yaml] Remove unnecessary use of { ( #125058 )
...
In yaml, indented blocks indicate the following fields are children of the parent indent. The use of curly brackets is unnecessary here
2023-04-21 00:32:31 +00:00
Zachary Anderson
c31467f18c
Stop running "_impeller_" benchmark variants ( #125044 )
...
Impeller is now the default on iOS, so these are redundant.
In a subsequent change, I'll clean up the source files for these.
2023-04-18 09:54:02 -07:00
Casey Hillers
b1f8d5df64
[ci.yaml] Disable packaging_test on release candidates ( #124712 )
...
[ci.yaml] Disable packaging_test on release candidates
2023-04-12 18:42:23 +00:00
Flutter GitHub Bot
2a5ecb6c48
Marks Linux firebase_abstract_method_smoke_test to be flaky ( #124692 )
...
Marks Linux firebase_abstract_method_smoke_test to be flaky
2023-04-12 18:29:07 +00:00
Flutter GitHub Bot
d15325407e
Marks Linux_samsung_s10 new_gallery_impeller__transition_perf to be flaky ( #124694 )
...
Marks Linux_samsung_s10 new_gallery_impeller__transition_perf to be flaky
2023-04-12 17:52:26 +00:00
Flutter GitHub Bot
df48b922ca
Marks Mac_ios animated_blur_backdrop_filter_perf_ios__timeline_summary to be unflaky ( #124706 )
...
Marks Mac_ios animated_blur_backdrop_filter_perf_ios__timeline_summary to be unflaky
2023-04-12 16:59:43 +00:00
Flutter GitHub Bot
2dfb03fdac
Marks Linux_android animated_blur_backdrop_filter_perf__timeline_summary to be unflaky ( #124705 )
...
Marks Linux_android animated_blur_backdrop_filter_perf__timeline_summary to be unflaky
2023-04-12 16:58:25 +00:00
Flutter GitHub Bot
e68086e910
Marks Linux_android new_gallery_impeller__transition_perf to be flaky ( #124700 )
...
Marks Linux_android new_gallery_impeller__transition_perf to be flaky
2023-04-12 16:55:44 +00:00
keyonghan
cf1891218d
Mark android_semantics_integration_test as flaky ( #124638 )
...
Mark android_semantics_integration_test as flaky
2023-04-11 23:49:05 +00:00
godofredoc
be2aa1c268
Set multiple tests as non flaky. ( #124604 )
...
Set multiple tests as non flaky.
2023-04-11 20:05:21 +00:00
keyonghan
4c3d7333b1
Mark analyzer_benchmark as unflaky ( #124394 )
...
Mark analyzer_benchmark as unflaky
2023-04-07 17:20:52 +00:00
keyonghan
c7bab2973e
Move analyzer_benchmark_vm to vm ( #124147 )
...
Move analyzer_benchmark_vm to vm
2023-04-04 22:41:34 +00:00
Jenn Magder
f115e280c4
Run web integration tests on x64 or arm Macs ( #123714 )
...
Run web integration tests on x64 or arm Macs
2023-04-04 01:29:06 +00:00
Jonah Williams
54dbbd76b8
[devicelab] add regular old blur benchmark ( #123879 )
...
[devicelab] add regular old blur benchmark
2023-03-31 20:54:51 +00:00
Flutter GitHub Bot
91d751f8cd
Marks Mac platform_channel_sample_test_macos to be unflaky ( #123702 )
2023-03-30 12:37:33 -07:00
Flutter GitHub Bot
a8afbfa22e
Marks Windows flutter_packaging_test to be unflaky ( #123240 )
...
Marks Windows flutter_packaging_test to be unflaky
2023-03-24 04:00:20 +00:00
Flutter GitHub Bot
ec7c45948c
Marks Mac_arm64 flutter_packaging_test to be unflaky ( #123239 )
...
Marks Mac_arm64 flutter_packaging_test to be unflaky
2023-03-23 21:52:20 +00:00
Chris Bracken
674ff1573f
[macOS] Add platform_channel sample/test ( #123141 )
...
Adds a macOS implementation of the platform_channel example,
demonstrating method channels and event channels with a battery power
plugin.
Adds platform_channel_sample_test_macos macOS host test to verify the
sample works.
Issue: https://github.com/flutter/flutter/issues/79204
2023-03-23 11:56:23 -07:00
Flutter GitHub Bot
49dbb74c38
Marks Mac flutter_packaging_test to be unflaky ( #123238 )
...
Co-authored-by: godofredoc <godofredoc@google.com>
2023-03-22 18:20:52 -07:00
Flutter GitHub Bot
2a70f7eb10
Marks Linux flutter_packaging_test to be unflaky ( #123237 )
...
Co-authored-by: godofredoc <godofredoc@google.com>
2023-03-22 16:49:11 -07:00
Flutter GitHub Bot
2cdf078f0f
Marks Linux engine_dependency_proxy_test to be unflaky ( #123236 )
...
Marks Linux engine_dependency_proxy_test to be unflaky
2023-03-22 18:41:47 +00:00
Flutter GitHub Bot
e760624f8a
Marks Linux build_tests_3_3 to be unflaky ( #114528 )
...
Co-authored-by: godofredoc <godofredoc@google.com>
2023-03-21 20:30:45 -07:00
Flutter GitHub Bot
d75f0de604
Marks Linux build_tests_1_3 to be unflaky ( #114526 )
2023-03-21 19:14:51 -07:00
Jonah Williams
67810d672b
delete sksl benchmarks ( #123163 )
...
delete sksl benchmarks
2023-03-21 22:52:18 +00:00
Xilai Zhang
cf18456755
add dimenstion for arm packaging ( #122770 )
...
Add dimenstion for arm packaging
2023-03-18 00:40:14 +00:00
godofredoc
1541dd3f25
Re-enable engine dependency proxy test. ( #115511 )
...
Re-enable engine dependency proxy test.
2023-03-17 03:16:13 +00:00
godofredoc
9f35ed77d7
Use packages/packages recipe. ( #122822 )
...
Use packages/packages recipe.
2023-03-16 20:52:09 +00:00
Flutter GitHub Bot
5b40de684a
Marks Linux web_long_running_tests_2_5 to be unflaky ( #122718 )
...
Marks Linux web_long_running_tests_2_5 to be unflaky
2023-03-15 21:52:05 +00:00
godofredoc
77178396c9
Fix globs in runIf configurations. ( #122630 )
...
Fix globs in runIf configurations.
2023-03-14 22:25:51 +00:00
Jenn Magder
5fd1c2b6a6
Revert "Run Skia gold framework tests on arm64 Mac builders ( #122618 )" ( #122639 )
...
Revert "Run Skia gold framework tests on arm64 Mac builders"
2023-03-14 21:55:05 +00:00
Jenn Magder
dfab19c1fe
Run Skia gold framework tests on arm64 Mac builders ( #122618 )
...
Run Skia gold framework tests on arm64 Mac builders
2023-03-14 20:09:16 +00:00
Yegor
091104f8bc
[web] stop using deprecated jsonwire web-driver protocol ( #122560 )
...
[web] stop using deprecated jsonwire web-driver protocol
2023-03-14 18:25:23 +00:00
stuartmorgan
449a5bc757
Enable plugin_test_linux ( #120912 )
...
Enable plugin_test_linux
2023-03-09 00:41:34 +00:00
Flutter GitHub Bot
ac76dabe67
Marks Windows plugin_test to be flaky ( #122201 )
...
Marks Windows plugin_test to be flaky
2023-03-08 20:57:54 +00:00
keyonghan
c4ca9a4142
Update cmake version to the latest in infra/3pp/tools ( #122147 )
...
Update cmake version to the latest in infra/3pp/tools
2023-03-08 19:55:47 +00:00
Jenn Magder
244372b303
Run plugin_test_macos on Intel machines ( #122212 )
...
Run plugin_test_macos on Intel machines
2023-03-08 19:44:37 +00:00
Flutter GitHub Bot
75ccb43c54
Marks Mac_ios hot_mode_dev_cycle_ios__benchmark to be flaky ( #120809 )
...
Marks Mac_ios hot_mode_dev_cycle_ios__benchmark to be flaky
2023-03-08 00:24:05 +00:00
Michael Goderbauer
b9c2d49989
Mark web_long_running_tests_2_5 flaky ( #121814 )
...
Mark web_long_running_tests_2_5 flaky
2023-03-03 18:35:13 +00:00
stuartmorgan
92bb306bcd
Add curl
dependency to plugin_test_linux ( #121807 )
...
Add `curl` dependency to plugin_test_linux
2023-03-02 19:18:26 +00:00
godofredoc
888b7b9b19
Remove customer testing from recipes cq. ( #121734 )
...
Remove customer testing from recipes cq.
2023-03-01 21:35:55 +00:00
Flutter GitHub Bot
2159604f89
Marks Mac_ios flutter_gallery_ios_sksl_warmup__transition_perf to be flaky ( #121232 )
...
Marks Mac_ios flutter_gallery_ios_sksl_warmup__transition_perf to be flaky
2023-03-01 21:21:10 +00:00
Flutter GitHub Bot
46fed5903f
Marks Windows plugin_test to be unflaky ( #113711 )
...
Marks Windows plugin_test to be unflaky
2023-03-01 01:21:57 +00:00
Flutter GitHub Bot
5dc569f148
Marks Linux run_debug_test_linux to be unflaky ( #121237 )
...
Co-authored-by: Loïc Sharma <737941+loic-sharma@users.noreply.github.com>
2023-02-23 19:11:17 +00:00
gaaclarke
bd5e8db3a3
Turned off bringup
for wide gamut color tests. ( #120918 )
2023-02-21 18:53:11 +00:00
Loïc Sharma
00c0a07fa3
Increase Linux docs_test timeout ( #120899 )
...
The `Linux docs_test` target has timed out repeatedly. This is a short-term mitigation to prevent unnecessary framework tree closures. In the future we should remove docset generation from post-submit `Linux docs_test`. See: https://github.com/flutter/flutter/issues/120901 .
See this similar change: https://github.com/flutter/flutter/pull/120718
2023-02-16 17:35:29 -08:00
stuartmorgan
e00241a060
Enable Windows plugin tests ( #119345 )
...
* Fix binary path
* Enable in presubmit
2023-02-16 21:21:10 +00:00
stuartmorgan
e65dfba8e1
Add Linux unit tests to plugin template ( #120814 )
...
* Add Linux unit tests to plugin template
Adds an example native unit test to the plugin template for Linux,
matching the structure we use for our 1P plugin unit tests. Once these
have been added for all platforms+languages, they will be documented on
a new plugin development page to explain their use.
While ideally we would adjust the engine APIs first to allow for testing
the method call handler directly, it's unclear when we will have time
for that work, and for a complex plugin most of the testing wouldn't be
at that layer anyway, so having the structure in place with the
limitations documented is still a significant improvement over having
nothing in the template.
Part of https://github.com/flutter/flutter/issues/82458
* Add creation test
* Add integration tests
* Missing newlines
* test owner
* Typo
2023-02-15 19:13:11 +00:00
Loïc Sharma
a9f43665ca
Fix the flutter run -d linux
tests ( #120721 )
...
* Fix the Linux run_debug_test_linux test
* ?
* Also do release
* ??
2023-02-15 17:43:12 +00:00
Loïc Sharma
2cfca820a3
Force Mac plugin_test to run on x64 bots ( #120714 )
2023-02-15 00:00:19 +00:00
Loïc Sharma
480c54c370
Increase Linux docs_publish timeout ( #120718 )
...
This target recently caused the tree to close due to a timeout: https://ci.chromium.org/ui/p/flutter/builders/prod/Linux%20docs_publish/8906/overview
This target consistently takes ~55 minutes, which is very close to its current timeout of 60 minutes. This increases the timeout to make timeouts less likely.
2023-02-14 13:18:12 -08:00
Loïc Sharma
865422da20
Force Mac tool_integration_tests
to run on x64 bots ( #120634 )
2023-02-13 23:52:35 +00:00
gaaclarke
ddebe833b0
Added integration test for wide gamut support. ( #119657 )
...
* Added integration test for wide gamut support.
* cleaned up
* deleted files that can be generated
* switched back to standard flutter in the shell script
* added devicelab task
* removed analysis options
* analyzer
* Fixed task
* made local_run.sh not executable
* analyzer
* removed the logo asset
* added task to ci
* updated pubspec
* analysis errors fixed
* updated pubspec
2023-02-13 22:33:19 +00:00
Jenn Magder
95fd821ab8
Force Mac build_tests
to run on x64 bots ( #120620 )
2023-02-13 21:23:11 +00:00
Flutter GitHub Bot
957494d9f0
Marks Linux_android flavors_test to be unflaky ( #120299 )
2023-02-13 17:20:03 +00:00
Xilai Zhang
96823590ec
post submit only ( #120411 )
2023-02-10 17:29:09 +00:00
Camille Simon
3a514175d3
Remove Android spell check integration test ( #120144 )
2023-02-08 18:51:52 +00:00
Jenn Magder
71971f2232
Run verify_binaries_codesigned
task on release branches ( #120141 )
...
* Run verify_binaries_codesigned on release branches
* Revert branches
2023-02-07 02:56:38 +00:00
Jenn Magder
e627e8d841
Force web_tool_tests to run on x64 builders ( #120128 )
2023-02-06 23:52:52 +00:00
godofredoc
c8e75a8dff
Do not run customer testing on release candidate branches. ( #119979 )
...
These tests try to use a commit contemporary to the framework commit in
customer repositories. This won't work because a CP to the framework
release candidate branch may be recent even though the release candidate
branch can be months old.
2023-02-04 03:32:26 +00:00
Jenn Magder
909dc30090
Verify Mac artifact codesigning on x64 and arm64 ( #119971 )
...
* Verify Mac artifact codesigning on x64 and arm64
* mac_arm64
2023-02-04 01:52:05 +00:00
Jenn Magder
c24904ddee
Run macOS benchmarks in prod pool to upload metrics ( #119963 )
2023-02-03 22:38:53 +00:00
Jenn Magder
c52215e935
Run Mac hostonly tests on any available arch ( #119884 )
...
* Run Mac hostonly tests on any available arch
* Exception for framework tests
2023-02-03 22:37:48 +00:00
Jenn Magder
51b05ac7e1
Add mac_benchmark ci.yaml property ( #119871 )
...
* Add mac_benchmark ci.yaml property
* Remove presubmit
* Bringup
* Comma
* gems
* Test animated_complex_opacity_perf_macos__e2e_summary in presubmit
* Try top-level mac_model
* Move dependencies back into tasks
* Add signing dependency
* Revert animated_complex_opacity_perf_macos__e2e_summary test
2023-02-03 21:36:48 +00:00
Jenn Magder
d875899a65
Bump test Chrome version for Mac arm support ( #119773 )
2023-02-03 00:14:42 +00:00
Ricardo Amador
22bbdf03e0
Android defines target update ( #119766 )
...
* Round 2 with dimensions
* Try with stringified keys
* Forgot a comma
* trying a list of maps.
* Try key value pairs
* Try with kvm only
* try with swarming_dimensions
* Updated with fix in swarming.star
* Attempting to remove the bring up property to verify test is running.
* Remove android from target tags to avoid adb command automatically running in test_utils call.
* Remove the duplicated dependencies in the defines target that exist in the platform
2023-02-02 20:56:05 +00:00
Flutter GitHub Bot
e7d934a014
Marks Linux_android android_choreographer_do_frame_test to be flaky ( #119721 )
2023-02-02 18:12:56 +00:00
Jenn Magder
34730c79ca
Revert "Run Mac hostonly tests on any available arch ( #119762 )" ( #119784 )
...
This reverts commit 475fc4ac9d
.
2023-02-02 03:42:17 +00:00
Jenn Magder
475fc4ac9d
Run Mac hostonly tests on any available arch ( #119762 )
...
* Run Mac hostonly presubmit tests on any available arch
* Force all Mac tests to run on arm64 to validate in presubmit
* Go back to web tests on x64
* Run plugin_test_ios on x64
* Try Chrome 110 on arm
* Revert chrome bump, remove forcing arm64
* Update issue number
2023-02-02 02:34:08 +00:00
Flutter GitHub Bot
1573c12963
Marks Mac_android microbenchmarks to be unflaky ( #119727 )
2023-02-01 18:53:20 +00:00
Chris Bracken
d272a3ab80
Reland: [macos] add flavor options to tool commands ( #119564 )
...
* Reland: [macos] add flavor options to tool commands
Adds --flavor option to flutter run and flutter build. Running against
preexisting devicelab flavor tests for feature parity between macOS,
iOS, and Android.
This relands #118421 by alex-wallen which was reverted in #118858 due to
the following test failures:
The bail-out with "Host and target are the same. Nothing to install."
added in `packages/flutter_tools/lib/src/commands/install.dart`
triggered failures in the following tests, which unconditionally attempt
to install the built app, which is unsupported on desktop since the
host and target are the same:
* https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket/8791495589540422465/+/u/run_flutter_view_macos__start_up/test_stdout
* https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket/8791496218824259121/+/u/run_complex_layout_win_desktop__start_up/test_stdout
* https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket/8791496218165602641/+/u/run_flutter_gallery_win_desktop__start_up/test_stdout
Fixes #64088
* Partial revert: eliminate install check on desktop
The original flavour support patch included a check that triggered a
failure when flutter install is run on desktop OSes. This was
intentional, since the host and target devices are the same and
installation is unnecessary to launch the app on currently-supported
desktop OSes.
Note that Windows UWP apps *do* require installation to run, and we used
to have an install command for those apps, though UWP is no longer
supported.
Since that part of the change was orthogonal to flavour support itself,
I'm reverting that component of the change and we can deal with it
separately if so desired.
2023-01-31 17:37:46 +00:00
Flutter GitHub Bot
8898f4f198
Marks Mac_android run_debug_test_android to be unflaky ( #117468 )
2023-01-30 23:26:54 +00:00
Flutter GitHub Bot
b2f2bf31c0
Marks Linux run_release_test_linux to be unflaky ( #119156 )
2023-01-27 19:19:45 +00:00
Flutter GitHub Bot
459c1b78b4
Marks Mac complex_layout_scroll_perf_macos__timeline_summary to be unflaky ( #119157 )
2023-01-26 18:59:40 +00:00
Flutter GitHub Bot
fc02701818
Marks Mac run_debug_test_macos to be unflaky ( #117470 )
...
Co-authored-by: Chris Bracken <chris@bracken.jp>
2023-01-26 05:25:00 +00:00
stuartmorgan
e3c51a2f2a
Add Windows unit tests to plugin template ( #118638 )
...
* Add Windows unit tests to plugin template
Adds an example native unit test to the plugin template for Windows,
matching the format we use for our 1P plugin example app unit tests.
Once these have been added for all platforms+languages, they will be
documented on a new plugin development page to explain their use.
Since we don't appear to be running our current plugin e2e tests for
Windows, this adds a new configuration to run them. I haven't
`led`-tested this, so it may not work, but this will give a starting
point for getting them running.
Part of https://github.com/flutter/flutter/issues/82458
* Minor fix
* Add test owner
* Fix typo
* Fix test feature flag
2023-01-24 18:23:57 +00:00
Jenn Magder
2e8dd9dd69
Run integration_ui_test_test_macos in prod ( #118919 )
2023-01-24 01:37:52 +00:00