Commit graph

37663 commits

Author SHA1 Message Date
Flutter GitHub Bot 6f093b1db8
Marks Windows_arm64 complex_layout_win_desktop__start_up to be unflaky (#137225)
<!-- meta-tags: To be used by the automation script only, DO NOT MODIFY.
{
  "name": "Windows_arm64 complex_layout_win_desktop__start_up"
}
-->
The issue https://github.com/flutter/flutter/issues/134083 has been closed, and the test has been passing for [50 consecutive runs](https://data.corp.google.com/sites/flutter_infra_metrics_datasite/flutter_check_test_flakiness_status_dashboard/?p=BUILDER_NAME:%22Windows_arm64%20complex_layout_win_desktop__start_up%22).
This test can be marked as unflaky.
2023-10-26 22:05:44 +00:00
engine-flutter-autoroll c7249647de
Roll Flutter Engine from 394744d2c4d0 to ce1c1ee54107 (2 revisions) (#137367)
394744d2c4...ce1c1ee541

2023-10-26 jason-simmons@users.noreply.github.com [Impeller] Fix the transform and geometry criteria for an optimization in TiledTextureContents (flutter/engine#47341)
2023-10-26 jason-simmons@users.noreply.github.com Roll HarfBuzz to 8.2.2 (flutter/engine#47284)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC aaclarke@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-10-26 21:44:03 +00:00
Flutter GitHub Bot 6f3c3a3f2a
Marks Windows_arm64 hot_mode_dev_cycle_win_target__benchmark to be unflaky (#137217)
<!-- meta-tags: To be used by the automation script only, DO NOT MODIFY.
{
  "name": "Windows_arm64 hot_mode_dev_cycle_win_target__benchmark"
}
-->
The issue https://github.com/flutter/flutter/issues/134083 has been closed, and the test has been passing for [50 consecutive runs](https://data.corp.google.com/sites/flutter_infra_metrics_datasite/flutter_check_test_flakiness_status_dashboard/?p=BUILDER_NAME:%22Windows_arm64%20hot_mode_dev_cycle_win_target__benchmark%22).
This test can be marked as unflaky.
2023-10-26 21:34:06 +00:00
Flutter GitHub Bot b6cde8f720
Marks Windows_arm64 flutter_view_win_desktop__start_up to be unflaky (#137226)
<!-- meta-tags: To be used by the automation script only, DO NOT MODIFY.
{
  "name": "Windows_arm64 flutter_view_win_desktop__start_up"
}
-->
The issue https://github.com/flutter/flutter/issues/134083 has been closed, and the test has been passing for [50 consecutive runs](https://data.corp.google.com/sites/flutter_infra_metrics_datasite/flutter_check_test_flakiness_status_dashboard/?p=BUILDER_NAME:%22Windows_arm64%20flutter_view_win_desktop__start_up%22).
This test can be marked as unflaky.
2023-10-26 21:34:03 +00:00
Flutter GitHub Bot dfd003abb0
Marks Windows_arm64 platform_view_win_desktop__start_up to be unflaky (#137227)
<!-- meta-tags: To be used by the automation script only, DO NOT MODIFY.
{
  "name": "Windows_arm64 platform_view_win_desktop__start_up"
}
-->
The issue https://github.com/flutter/flutter/issues/134083 has been closed, and the test has been passing for [50 consecutive runs](https://data.corp.google.com/sites/flutter_infra_metrics_datasite/flutter_check_test_flakiness_status_dashboard/?p=BUILDER_NAME:%22Windows_arm64%20platform_view_win_desktop__start_up%22).
This test can be marked as unflaky.
2023-10-26 21:34:00 +00:00
Flutter GitHub Bot 71bc3b02f2
Marks Windows_arm64 flutter_gallery_win_desktop__start_up to be unflaky (#137224)
<!-- meta-tags: To be used by the automation script only, DO NOT MODIFY.
{
  "name": "Windows_arm64 flutter_gallery_win_desktop__start_up"
}
-->
The issue https://github.com/flutter/flutter/issues/134083 has been closed, and the test has been passing for [50 consecutive runs](https://data.corp.google.com/sites/flutter_infra_metrics_datasite/flutter_check_test_flakiness_status_dashboard/?p=BUILDER_NAME:%22Windows_arm64%20flutter_gallery_win_desktop__start_up%22).
This test can be marked as unflaky.
2023-10-26 21:11:52 +00:00
Flutter GitHub Bot dc16104b35
Marks Windows_arm64 hello_world_win_desktop__compile to be unflaky (#137222)
<!-- meta-tags: To be used by the automation script only, DO NOT MODIFY.
{
  "name": "Windows_arm64 hello_world_win_desktop__compile"
}
-->
The issue https://github.com/flutter/flutter/issues/134083 has been closed, and the test has been passing for [50 consecutive runs](https://data.corp.google.com/sites/flutter_infra_metrics_datasite/flutter_check_test_flakiness_status_dashboard/?p=BUILDER_NAME:%22Windows_arm64%20hello_world_win_desktop__compile%22).
This test can be marked as unflaky.
2023-10-26 21:08:01 +00:00
Flutter GitHub Bot 3836988980
Marks Windows_arm64 flutter_gallery_win_desktop__compile to be unflaky (#137223)
<!-- meta-tags: To be used by the automation script only, DO NOT MODIFY.
{
  "name": "Windows_arm64 flutter_gallery_win_desktop__compile"
}
-->
The issue https://github.com/flutter/flutter/issues/134083 has been closed, and the test has been passing for [50 consecutive runs](https://data.corp.google.com/sites/flutter_infra_metrics_datasite/flutter_check_test_flakiness_status_dashboard/?p=BUILDER_NAME:%22Windows_arm64%20flutter_gallery_win_desktop__compile%22).
This test can be marked as unflaky.
2023-10-26 21:07:59 +00:00
Flutter GitHub Bot fdd38d30d7
Marks Windows_arm64 run_release_test_windows to be unflaky (#137220)
<!-- meta-tags: To be used by the automation script only, DO NOT MODIFY.
{
  "name": "Windows_arm64 run_release_test_windows"
}
-->
The issue https://github.com/flutter/flutter/issues/134083 has been closed, and the test has been passing for [50 consecutive runs](https://data.corp.google.com/sites/flutter_infra_metrics_datasite/flutter_check_test_flakiness_status_dashboard/?p=BUILDER_NAME:%22Windows_arm64%20run_release_test_windows%22).
This test can be marked as unflaky.
2023-10-26 21:06:19 +00:00
Greg Price 5b3293c5ae
Fix dislocated doc and comment on ThemeData localize cache (#137315)
This comment on _localizedThemeDataCacheSize was a bit garbled from getting split up, and the doc on _localizedThemeDataCache was missing from having been moved elsewhere.

It looks like the dislocation happened in 8b86d238b (#116088), which was otherwise making unrelated changes, including a couple of lines near these.  Likely it was due to an error in resolving merge or rebase conflicts at some point while revising that PR.
2023-10-26 20:57:52 +00:00
Flutter GitHub Bot d737038f39
Marks Windows_arm64 platform_channel_sample_test_windows to be unflaky (#137218)
<!-- meta-tags: To be used by the automation script only, DO NOT MODIFY.
{
  "name": "Windows_arm64 platform_channel_sample_test_windows"
}
-->
The issue https://github.com/flutter/flutter/issues/134083 has been closed, and the test has been passing for [50 consecutive runs](https://data.corp.google.com/sites/flutter_infra_metrics_datasite/flutter_check_test_flakiness_status_dashboard/?p=BUILDER_NAME:%22Windows_arm64%20platform_channel_sample_test_windows%22).
This test can be marked as unflaky.
2023-10-26 20:55:14 +00:00
engine-flutter-autoroll 1984fbd2ff
Roll Flutter Engine from 7c5c8f587992 to 394744d2c4d0 (1 revision) (#137364)
7c5c8f5879...394744d2c4

2023-10-26 skia-flutter-autoroll@skia.org Roll Skia from 19e9ccf5f820 to fb72136c9325 (2 revisions) (flutter/engine#47346)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC aaclarke@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-10-26 20:48:15 +00:00
engine-flutter-autoroll 5f2e71c483
Roll Flutter Engine from 9363fe6ba503 to 7c5c8f587992 (3 revisions) (#137363)
9363fe6ba5...7c5c8f5879

2023-10-26 jonahwilliams@google.com [Impeller] remove giant closure in EntityPass. (flutter/engine#47343)
2023-10-26 godofredoc@google.com Adds firebase test lab tests. (flutter/engine#47320)
2023-10-26 skia-flutter-autoroll@skia.org Roll Skia from e1cc41ff84ca to 19e9ccf5f820 (1 revision) (flutter/engine#47342)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC aaclarke@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-10-26 20:01:12 +00:00
engine-flutter-autoroll c22ca2a152
Roll Flutter Engine from 542f8bc4c019 to 9363fe6ba503 (2 revisions) (#137354)
542f8bc4c0...9363fe6ba5

2023-10-26 skia-flutter-autoroll@skia.org Roll Skia from 091de96cad96 to e1cc41ff84ca (1 revision) (flutter/engine#47340)
2023-10-26 30870216+gaaclarke@users.noreply.github.com [Impeller] added missing openplayground (flutter/engine#47338)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC aaclarke@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-10-26 19:18:20 +00:00
Elias Yishak 56ae555992
Unified analytics events for doctor validators (#136647)
Related to tracking issue:
- https://github.com/flutter/flutter/issues/128251

This PR sends analytic events for each of the doctor validators.

This PR below will need to land first in `dart-lang/tools` before this merges.
2023-10-26 18:23:24 +00:00
engine-flutter-autoroll 6c81009bcb
Roll Flutter Engine from d8132d5070bf to 542f8bc4c019 (2 revisions) (#137349)
d8132d5070...542f8bc4c0

2023-10-26 skia-flutter-autoroll@skia.org Roll Skia from bc5c938ccff4 to 091de96cad96 (1 revision) (flutter/engine#47339)
2023-10-26 skia-flutter-autoroll@skia.org Roll Skia from ebae76679a04 to bc5c938ccff4 (1 revision) (flutter/engine#47337)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC aaclarke@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-10-26 18:23:21 +00:00
Flutter GitHub Bot 17797ba50b
Marks Windows_arm64 run_debug_test_windows to be unflaky (#137219)
<!-- meta-tags: To be used by the automation script only, DO NOT MODIFY.
{
  "name": "Windows_arm64 run_debug_test_windows"
}
-->
The issue https://github.com/flutter/flutter/issues/134083 has been closed, and the test has been passing for [50 consecutive runs](https://data.corp.google.com/sites/flutter_infra_metrics_datasite/flutter_check_test_flakiness_status_dashboard/?p=BUILDER_NAME:%22Windows_arm64%20run_debug_test_windows%22).
This test can be marked as unflaky.
2023-10-26 18:15:56 +00:00
engine-flutter-autoroll 7e2ecf810d
Roll Flutter Engine from 0a6253dbfafd to d8132d5070bf (1 revision) (#137347)
0a6253dbfa...d8132d5070

2023-10-26 30870216+gaaclarke@users.noreply.github.com [Impeller] Improved documentation of the gaussian blur. (flutter/engine#47283)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC aaclarke@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-10-26 17:37:32 +00:00
engine-flutter-autoroll 888e9490cd
Roll Flutter Engine from 5da115661f01 to 0a6253dbfafd (1 revision) (#137341)
5da115661f...0a6253dbfa

2023-10-26 skia-flutter-autoroll@skia.org Roll Skia from fb63b86f7bb8 to ebae76679a04 (1 revision) (flutter/engine#47336)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC aaclarke@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-10-26 16:50:02 +00:00
engine-flutter-autoroll c1c3910e51
Roll Flutter Engine from 61ae5ef94e9c to 5da115661f01 (1 revision) (#137340)
61ae5ef94e...5da115661f

2023-10-26 skia-flutter-autoroll@skia.org Roll Skia from 3b84335bf181 to fb63b86f7bb8 (2 revisions) (flutter/engine#47335)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC aaclarke@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-10-26 15:56:04 +00:00
engine-flutter-autoroll c555599fbb
Roll Packages from f751ffb7d3cf to fea24c5b93b4 (4 revisions) (#137339)
f751ffb7d3...fea24c5b93

2023-10-25 stuartmorgan@google.com [url_launcher] Fix launch mode types in new APIs (flutter/packages#5232)
2023-10-25 43054281+camsim99@users.noreply.github.com [camerax] Implement `setZoomLevel` (flutter/packages#4950)
2023-10-25 engine-flutter-autoroll@skia.org Roll Flutter from 5e8b5f4ea2 to 5dd2a4e0aa (59 revisions) (flutter/packages#5231)
2023-10-25 43054281+camsim99@users.noreply.github.com [file_selector_android] Run tests on AVDs running Android 34 (flutter/packages#5218)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-10-26 15:39:06 +00:00
engine-flutter-autoroll b38706f034
Roll Flutter Engine from 23649a0529e5 to 61ae5ef94e9c (1 revision) (#137337)
23649a0529...61ae5ef94e

2023-10-26 skia-flutter-autoroll@skia.org Roll Skia from 6aaac934861c to 3b84335bf181 (1 revision) (flutter/engine#47334)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC aaclarke@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-10-26 14:58:24 +00:00
Victoria Ashworth 341af51391
Run test with older version of Xcode (#137293)
Xcode Debug tests require an older version of Xcode to run in CI.

New test is failing due to incompatible Xcode version: https://ci.chromium.org/ui/p/flutter/builders/staging/Mac_arm64_ios%20flavors_test_ios_xcode_debug/1/overview
2023-10-26 14:42:17 +00:00
engine-flutter-autoroll 7135af2f9b
Roll Flutter Engine from f8525b9fdddf to 23649a0529e5 (1 revision) (#137333)
f8525b9fdd...23649a0529

2023-10-26 skia-flutter-autoroll@skia.org Roll Skia from 7f59dc2ba2b0 to 6aaac934861c (1 revision) (flutter/engine#47333)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC aaclarke@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-10-26 11:52:36 +00:00
Bruno Leroux b2ec34fcb4
Add ProcessTextService (#137145)
## Description

This PR adds `ProcessTextService` on the framework side to communicate with the engine to query and run text processing actions (on the engine side, only Android is supported currently, see https://github.com/flutter/engine/pull/44579).

## Related Issue

Non-UI framework side for https://github.com/flutter/flutter/issues/107603

## Tests

Adds 3 tests.
2023-10-26 11:44:07 +00:00
engine-flutter-autoroll 8ba52bc49b
Roll Flutter Engine from b6bea17e39d3 to f8525b9fdddf (1 revision) (#137330)
b6bea17e39...f8525b9fdd

2023-10-26 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from kNdyn03p28H7VeMcd... to YSn00b0Trsu2vdhIq... (flutter/engine#47332)

Also rolling transitive DEPS:
  fuchsia/sdk/core/mac-amd64 from kNdyn03p28H7 to YSn00b0Trsu2

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC aaclarke@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-10-26 10:11:36 +00:00
engine-flutter-autoroll fb30baf37f
Roll Flutter Engine from ec29ea930f58 to b6bea17e39d3 (1 revision) (#137329)
ec29ea930f...b6bea17e39

2023-10-26 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from zTq0jH2Y3Fl0uUUSa... to akT2HxdLNPWSG-gbV... (flutter/engine#47331)

Also rolling transitive DEPS:
  fuchsia/sdk/core/linux-amd64 from zTq0jH2Y3Fl0 to akT2HxdLNPWS

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC aaclarke@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-10-26 09:31:37 +00:00
engine-flutter-autoroll c1c1eb2a96
Roll Flutter Engine from 2a01fae53ded to ec29ea930f58 (1 revision) (#137326)
2a01fae53d...ec29ea930f

2023-10-26 skia-flutter-autoroll@skia.org Roll Skia from 5fd4c58f1e37 to 7f59dc2ba2b0 (1 revision) (flutter/engine#47330)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC aaclarke@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-10-26 08:39:43 +00:00
engine-flutter-autoroll 0ce766dfd6
Roll Flutter Engine from 10a91eb44c5b to 2a01fae53ded (1 revision) (#137320)
10a91eb44c...2a01fae53d

2023-10-26 skia-flutter-autoroll@skia.org Roll Skia from 14c3cf9efb44 to 5fd4c58f1e37 (2 revisions) (flutter/engine#47329)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC aaclarke@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-10-26 07:19:05 +00:00
engine-flutter-autoroll 3c76b8ad41
Roll Flutter Engine from f844ab933364 to 10a91eb44c5b (1 revision) (#137317)
f844ab9333...10a91eb44c

2023-10-26 skia-flutter-autoroll@skia.org Roll Skia from 94e67b76fd2d to 14c3cf9efb44 (1 revision) (flutter/engine#47328)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC aaclarke@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-10-26 06:38:31 +00:00
engine-flutter-autoroll 2f45754aab
Roll Flutter Engine from 6428ed576841 to f844ab933364 (1 revision) (#137314)
6428ed5768...f844ab9333

2023-10-26 skia-flutter-autoroll@skia.org Roll Skia from a5da4435bb5c to 94e67b76fd2d (1 revision) (flutter/engine#47327)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC aaclarke@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-10-26 04:51:43 +00:00
engine-flutter-autoroll 53a5d56805
Roll Flutter Engine from 6e09ee14e244 to 6428ed576841 (38 revisions) (#137310)
Roll Flutter Engine from 6e09ee14e244 to 6428ed576841 (38 revisions)

6e09ee14e2...6428ed5768

2023-10-26 jason-simmons@users.noreply.github.com Revert Dart SDK to 360370ff93b053253343832432f8329a11372ffc (flutter/engine#47326)
2023-10-25 skia-flutter-autoroll@skia.org Roll Skia from fb979d0ce053 to a5da4435bb5c (1 revision) (flutter/engine#47325)
2023-10-25 jonahwilliams@google.com [Impeller] Cache location in metadata. (flutter/engine#46640)
2023-10-25 skia-flutter-autoroll@skia.org Roll Skia from 8492914821fa to fb979d0ce053 (1 revision) (flutter/engine#47324)
2023-10-25 737941+loic-sharma@users.noreply.github.com [Windows] Introduce FlutterWindowsViewController (flutter/engine#47242)
2023-10-25 skia-flutter-autoroll@skia.org Roll Skia from 773abacc1581 to 8492914821fa (2 revisions) (flutter/engine#47322)
2023-10-25 skia-flutter-autoroll@skia.org Roll Dart SDK from 73fa7b3e048a to 7745c140d1fe (1 revision) (flutter/engine#47321)
2023-10-25 zanderso@users.noreply.github.com Cleanup Dart package dependencies a bit (flutter/engine#47306)
2023-10-25 skia-flutter-autoroll@skia.org Roll Skia from d511fa1f1533 to 773abacc1581 (1 revision) (flutter/engine#47312)
2023-10-25 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from SOv1RJmbyDByvud8D... to kNdyn03p28H7VeMcd... (flutter/engine#47313)
2023-10-25 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from vX5n99OIWgLX6bObI... to zTq0jH2Y3Fl0uUUSa... (flutter/engine#47309)
2023-10-25 skia-flutter-autoroll@skia.org Roll Skia from 0748053419cd to d511fa1f1533 (1 revision) (flutter/engine#47308)
2023-10-25 30870216+gaaclarke@users.noreply.github.com Missed linter argument comment violations (flutter/engine#47310)
2023-10-25 chinmaygarde@google.com [Impeller] Remove use of FML_DISALLOW_<FOO> macros in Impeller. (flutter/engine#47307)
2023-10-25 30870216+gaaclarke@users.noreply.github.com Adds lint for checking argument commments (flutter/engine#47305)
2023-10-25 skia-flutter-autoroll@skia.org Roll Dart SDK from 2791495ed583 to 73fa7b3e048a (1 revision) (flutter/engine#47304)
2023-10-25 skia-flutter-autoroll@skia.org Roll Skia from 4848dd9b5dab to 0748053419cd (2 revisions) (flutter/engine#47302)
2023-10-25 skia-flutter-autoroll@skia.org Roll Skia from 788eafdcf70d to 4848dd9b5dab (1 revision) (flutter/engine#47301)
2023-10-25 skia-flutter-autoroll@skia.org Roll Skia from 5c315b761a24 to 788eafdcf70d (1 revision) (flutter/engine#47300)
2023-10-25 skia-flutter-autoroll@skia.org Roll Skia from 18ad006ec7f9 to 5c315b761a24 (1 revision) (flutter/engine#47299)
2023-10-25 skia-flutter-autoroll@skia.org Roll Dart SDK from 57661d5dbc1e to 2791495ed583 (1 revision) (flutter/engine#47298)
2023-10-25 skia-flutter-autoroll@skia.org Roll Skia from 9537c25509ea to 18ad006ec7f9 (1 revision) (flutter/engine#47297)
2023-10-25 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from YqSO1OByhoexFJSCr... to SOv1RJmbyDByvud8D... (flutter/engine#47296)
2023-10-25 skia-flutter-autoroll@skia.org Roll Skia from d51d3bcbcacd to 9537c25509ea (1 revision) (flutter/engine#47295)
2023-10-25 skia-flutter-autoroll@skia.org Roll Skia from f98fc9536c43 to d51d3bcbcacd (1 revision) (flutter/engine#47294)
2023-10-25 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from tqukMrdJ6j-845-57... to vX5n99OIWgLX6bObI... (flutter/engine#47293)
2023-10-25 skia-flutter-autoroll@skia.org Roll Skia from 0d4fcf388a6f to f98fc9536c43 (1 revision) (flutter/engine#47292)
2023-10-24 chinmaygarde@google.com [Impeller] Update shader compilation pipeline documentation to detail multi-arch archives. (flutter/engine#47289)
2023-10-24 skia-flutter-autoroll@skia.org Roll Skia from 076a9dd0094f to 0d4fcf388a6f (2 revisions) (flutter/engine#47290)
2023-10-24 matanlurey@users.noreply.github.com OpenGL <4.x does not support stencil-only formats, so delete the TODO (flutter/engine#47286)
2023-10-24 matanlurey@users.noreply.github.com [Impeller] Unconditionally dither in gradient shader fragments. (flutter/engine#46746)
2023-10-24 skia-flutter-autoroll@skia.org Roll Skia from f491209e969d to 076a9dd0094f (1 revision) (flutter/engine#47285)
2023-10-24 chinmaygarde@google.com [Impeller] Add support for multi-rendering-backend fat shader archives. (flutter/engine#47278)
2023-10-24 skia-flutter-autoroll@skia.org Roll Skia from 502277be15cf to f491209e969d (1 revision) (flutter/engine#47281)
2023-10-24 skia-flutter-autoroll@skia.org Roll Dart SDK from 360370ff93b0 to 57661d5dbc1e (1 revision) (flutter/engine#47280)
2023-10-24 30870216+gaaclarke@users.noreply.github.com Migrated away from UnmodifiableUint8ListView (flutter/engine#47276)
2023-10-24 skia-flutter-autoroll@skia.org Roll Skia from bc90585b0dd4 to 502277be15cf (1 revision) (flutter/engine#47277)
2023-10-24 1961493+harryterkelsen@users.noreply.github.com Reland "Use a single OffscreenCanvas for rendering in CanvasKit (#45744)" (flutter/engine#47241)

Also rolling transitive DEPS:
  fuchsia/sdk/core/linux-amd64 from tqukMrdJ6j-8 to zTq0jH2Y3Fl0
  fuchsia/sdk/core/mac-amd64 from YqSO1OByhoex to kNdyn03p28H7

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
...
2023-10-26 02:55:37 +00:00
Mairramer de4e3d67a0
fix:: trigger onTapOutside only if has focus (#136291)
Adds new feat and fix to https://github.com/flutter/flutter/issues/134341
2023-10-26 00:26:20 +00:00
Michael Goderbauer 1c90ed8b64
Fix structure of pkg:integration_test (#137283)
The private _ libraries should not be advertised as importable. Moving them to the src directory.

I noticed this while browsing our dart docs. This should remove the underscore entries.

![image](https://github.com/flutter/flutter/assets/1227763/41511efe-4eb8-487a-9758-ccde1720e05a)

Replaces https://github.com/flutter/flutter/pull/137197.
2023-10-25 20:24:15 +00:00
Victoria Ashworth 5dd2a4e0aa
Ensure Xcode project is setup to start debugger (#136977)
Some users have their Xcode settings set to not debug (see example here https://github.com/flutter/flutter/issues/136197#issuecomment-1766834195). This will cause the [engine check for a debugger](22ce5c6a45/runtime/ptrace_check.cc (L56-L71)) to fail, which will cause an error and cause the app to crash.

This PR parses the scheme file to ensure the scheme is set to start a debugger and warn the user if it's not.

Fixes https://github.com/flutter/flutter/issues/136197.
2023-10-25 17:08:57 +00:00
Flutter GitHub Bot 9366170e84
Marks Windows build_tests_6_6 to be unflaky (#137216)
<!-- meta-tags: To be used by the automation script only, DO NOT MODIFY.
{
  "name": "Windows build_tests_6_6"
}
-->
The test has been passing for [50 consecutive runs](https://data.corp.google.com/sites/flutter_infra_metrics_datasite/flutter_check_test_flakiness_status_dashboard/?p=BUILDER_NAME:%22Windows%20build_tests_6_6%22).
This test can be marked as unflaky.
2023-10-25 17:07:19 +00:00
godofredoc c391315c17
Remove gem and docker files. (#137200)
Gem files were used to install cocoapods which now is being provisioned as part of the ruby cipd package.

This is also deleting the docker file used for Cirrus testing.

Bug: https://github.com/flutter/flutter/issues/136377
2023-10-25 17:07:17 +00:00
auto-submit[bot] bfc4c502c6
Reverts "[gallery] Reland roll gallery to ecfb9e5352bd12032301b12b30d5853d83d89bda" (#137264)
Reverts flutter/flutter#137199
Initiated by: zanderso
This change reverts the following previous change:
Original Description:
Reverts flutter/flutter#133095

Dependencies have been fixed, hopefully : https://github.com/flutter/flutter/issues/133096#event-10761117209
2023-10-25 16:41:20 +00:00
Jonah Williams aaf7184a42
[gallery] Reland roll gallery to ecfb9e5352bd12032301b12b30d5853d83d89bda (#137199)
Reverts flutter/flutter#133095

Dependencies have been fixed, hopefully : https://github.com/flutter/flutter/issues/133096#event-10761117209
2023-10-25 16:05:22 +00:00
engine-flutter-autoroll de93f0268a
Roll Packages from 2faf992a0589 to f751ffb7d3cf (11 revisions) (#137254)
2faf992a05...f751ffb7d3

2023-10-25 stuartmorgan@google.com [ci] Enable legacy Android emulator tests (flutter/packages#5190)
2023-10-25 49699333+dependabot[bot]@users.noreply.github.com Bump ossf/scorecard-action from 2.3.0 to 2.3.1 (flutter/packages#5209)
2023-10-25 godofredoc@google.com Replace gems dependency with ruby. (flutter/packages#5219)
2023-10-25 godofredoc@google.com Update the ftl hardware version. (flutter/packages#5224)
2023-10-25 737941+loic-sharma@users.noreply.github.com [ci] Disable Windows Arm64 stable CI (flutter/packages#5217)
2023-10-24 10687576+bparrishMines@users.noreply.github.com [webview_flutter_wkwebview] Only set `limitsNavigationsToAppBoundDomains` when it is set to true (flutter/packages#5137)
2023-10-24 stuartmorgan@google.com [url_launcher] Add an `inAppBrowserView` mode (flutter/packages#5155)
2023-10-24 43054281+camsim99@users.noreply.github.com [Android] Introduces API 34 emulators for subset of tests (flutter/packages#5105)
2023-10-24 stuartmorgan@google.com [url_launcher] Add an `inAppBrowserView` mode in implementations (flutter/packages#5211)
2023-10-24 stuartmorgan@google.com [ci] Fix legacy Android task names (flutter/packages#5191)
2023-10-24 reidbaker@google.com Update annotations deps to 1.7 (flutter/packages#4935)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-10-25 15:42:21 +00:00
Flutter GitHub Bot cd2c08ee51
Marks Windows build_tests_3_6 to be unflaky (#137214)
<!-- meta-tags: To be used by the automation script only, DO NOT MODIFY.
{
  "name": "Windows build_tests_3_6"
}
-->
The test has been passing for [50 consecutive runs](https://data.corp.google.com/sites/flutter_infra_metrics_datasite/flutter_check_test_flakiness_status_dashboard/?p=BUILDER_NAME:%22Windows%20build_tests_3_6%22).
This test can be marked as unflaky.
2023-10-25 14:49:32 +00:00
Flutter GitHub Bot 7db948cfdb
Marks Windows build_tests_5_6 to be unflaky (#137215)
<!-- meta-tags: To be used by the automation script only, DO NOT MODIFY.
{
  "name": "Windows build_tests_5_6"
}
-->
The test has been passing for [50 consecutive runs](https://data.corp.google.com/sites/flutter_infra_metrics_datasite/flutter_check_test_flakiness_status_dashboard/?p=BUILDER_NAME:%22Windows%20build_tests_5_6%22).
This test can be marked as unflaky.
2023-10-25 14:40:12 +00:00
Flutter GitHub Bot 1001a0a3d0
Marks Windows build_tests_2_6 to be unflaky (#137213)
<!-- meta-tags: To be used by the automation script only, DO NOT MODIFY.
{
  "name": "Windows build_tests_2_6"
}
-->
The test has been passing for [50 consecutive runs](https://data.corp.google.com/sites/flutter_infra_metrics_datasite/flutter_check_test_flakiness_status_dashboard/?p=BUILDER_NAME:%22Windows%20build_tests_2_6%22).
This test can be marked as unflaky.
2023-10-25 14:37:57 +00:00
Taha Tesser d0fe9f203d
Revert "Update OutlinedButton tests for Material 3 (#136809)" (#137242)
This reverts commit d36a843335
(https://github.com/flutter/flutter/pull/136809)

This fails even tho golden files were approved and `golden test` pending
was cleared and green and `autosubmit` successfully merged the PR.


```console
02:42 +4618 ~5: C:/b/s/w/ir/x/w/flutter/packages/flutter/test/material/outlined_button_test.dart: Material3 - OutlinedButton, OutlinedButton.icon defaults
══╡ EXCEPTION CAUGHT BY FLUTTER TEST FRAMEWORK ╞════════════════════════════════════════════════════
The following SkiaException was thrown while running async test code:
Skia Gold received an unapproved image in post-submit
testing. Golden file images in flutter/flutter are triaged
in pre-submit during code review for the given PR.

Visit https://flutter-gold.skia.org/ to view and approve
the image(s), or revert the associated change. For more
information, visit the wiki:
https://github.com/flutter/flutter/wiki/Writing-a-golden-file-test-for-package:flutter

Debug information for Gold --------------------------------
stdout: Given image with hash 37275e74c51f98d7abd7f301c5c94ac1 for test
material.outlined_button.ink_sparkle.default
Expectation for test: 531f5fa74908d2e6db2b8fd86a6b8662 (positive)
Expectation for test: 683e368ff51d947a3d63c2a5f4568cf6 (positive)
Expectation for test: 749241ff0fa21595b2c6cb551fd40b68 (positive)
Expectation for test: aaf9ac1328614d6c9f4540308bc86f62 (positive)
Expectation for test: b31a50440c7dd31b10cacd9e7b5c6b86 (positive)
Expectation for test: c0a7c8c625b69ddc695a770f28abd403 (positive)
Expectation for test: f1f66ce931c2ef33ebcb699a637025a6 (positive)
Expectation for test: 2d32e34efc1d7ca4cd12965402fb76ff (positive)
Untriaged or negative image:
https://flutter-gold.skia.org/detail?grouping=name%3Dmaterial.outlined_button.ink_sparkle.default%26source_type%3Dflutter&digest=37275e74c51f98d7abd7f301c5c94ac1


stderr: Test: material.outlined_button.ink_sparkle.default FAIL


result-state.json: No result file found.

When the exception was thrown, this was the stack:
#0      SkiaGoldClient.imgtestAdd (package:flutter_goldens_client/skia_client.dart:243:7)
<asynchronous suspension>
#1      MatchesGoldenFile.matchAsync.<anonymous closure> (package:flutter_test/src/_matchers_io.dart:118:32)
<asynchronous suspension>
<asynchronous suspension>
(elided one frame from dart:async)

The exception was caught asynchronously.
════════════════════════════════════════════════════════════════════════════════════════════════════
02:42 +4618 ~5 -1: C:/b/s/w/ir/x/w/flutter/packages/flutter/test/material/menu_anchor_test.dart: Menu functions keyboard directional traversal works
02:42 +4618 ~5 -1: C:/b/s/w/ir/x/w/flutter/packages/flutter/test/material/outlined_button_test.dart: Material3 - OutlinedButton, OutlinedButton.icon defaults [E]
  Test failed. See exception logs above.
  The test description was: Material3 - OutlinedButton, OutlinedButton.icon defaults
  
02:42 +4619 ~5 -1: C:/b/s/w/ir/x/w/flutter/packages/flutter/test/material/menu_anchor_test.dart: Menu functions keyboard directional traversal works
```

## Pre-launch Checklist

- [ ] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [ ] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [ ] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [ ] I signed the [CLA].
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [ ] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [ ] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
2023-10-25 14:48:27 +03:00
Taha Tesser d36a843335
Update OutlinedButton tests for Material 3 (#136809)
Updated unit tests for `CircleOutlinedButton` to have M2 and M3 versions.

More info in #127064

This also gets rid of unnecessary `fromSwatch` usage (part of https://github.com/flutter/flutter/issues/132584 documentation and test cleanup)
2023-10-25 10:06:27 +00:00
fzyzcjy 6df6c897ef
Let OverflowBox be shrink-wrappable (#129095)
Close https://github.com/flutter/flutter/issues/129094

I have demonstrated how this PR fixes the problem using tests in #129094. I will further add tests in this PR if the PR looks roughly acceptable :)
2023-10-25 03:51:24 +00:00
Polina Cherkasova dcbb2de0ad
Add dependency on leak_tracker to flutter_test. (#137069)
Contributes to: https://github.com/flutter/flutter/issues/135856

This PR also adds transitive dependency on  web_socket_channel, crypto, typed_data. `web_socket_channel` is needed to request retaining path for not GCed objects from VM Service. Two others are needed to serve web_socket_channel.

The dependency on leak_tracker is pinned:
aea562114c/packages/flutter_tools/lib/src/commands/update_packages.dart (L40)
2023-10-25 02:45:26 +00:00
yim 25c5bf0640
fix SliverReorderableLists item wrong offset (#136828)
This PR fixes the issue of items being created at the wrong position during dragging.

Fixes #135819
2023-10-25 01:11:18 +00:00
Jackson Gardner 4afdfca264
Remove bringup: true from realm_checker and remove the redundant tool test. (#137186)
Now that the realm checker is no longer in bringup, we can remove the tool test that checks for the empty realm file.
2023-10-25 01:09:18 +00:00
Qun Cheng ebc67643bd
Revert "Fix Gradle lockfiles." (#137198)
Reverts flutter/flutter#137190
2023-10-24 17:47:45 -07:00