Ian Hickson
6bfd9bb996
Fix a race condition in vmservice_test.dart ( #23835 )
...
Fixes https://github.com/flutter/flutter/issues/19273
2018-11-08 20:54:06 -08:00
engine-flutter-autoroll
17fe191a18
Roll engine 22fc02028306..b2479f8d2991 (10 commits) ( #24137 )
...
b2479f8d2 Revert "Roll src/third_party/skia 06a477c3300d..dd650c40d148 (11 commits) (#6801 )" (flutter/engine#6809 )
16f8c67f0 Update paint hinting for upcoming Skia API changes. (flutter/engine#6802 )
e011d544b Roll src/third_party/skia 06a477c3300d..dd650c40d148 (11 commits) (flutter/engine#6801 )
47ef89ee5 Include vector in embedded_views.h (flutter/engine#6800 )
a0efb9419 Make the FlutterPlatformViewFactory create FlutterPlatformViews. (flutter/engine#6782 )
7ed4909fc Fix mDNS publishing for iOS simulator (flutter/engine#6789 )
86d34e02d disable embedder_unittests (flutter/engine#6798 )
01f6ad0fb Roll src/third_party/skia 5d58d09ae77d..06a477c3300d (5 commits) (flutter/engine#6797 )
18ca035cf Discard embedded UIViews on hot restart. (flutter/engine#6772 )
387ca2ef8 Add an internal_nodes_canvas to PaintContext. (flutter/engine#6728 )
2018-11-08 19:27:19 -08:00
TL Lee
94d0b2ffc2
[Material] Add API for an unpainted input border ( #21289 )
...
* Introduce a rounded InputBorder with no paint
* Update documentation for API
* Change name of Widget to NoStrokeInputBorder and updated documentation
* [FilledInputBorder] PR feedback.
* [FilledInputBorder] typo correction.
* [FilledInputBorder] Removing news.
* [FilledInputBorder] PR feedback.
* [FilledInputBorder] Removing use of borderSide.
* [FilledInputBorder] Adding tests for hashcode.
* [FilledInputBorder] Comments.
* [TextFields] Input decoration feature parity.
* [TextFields] Making floating of placeholder optional.
* [TextFields] Cleanup
* [TextFields] Removing unused isAnimated.
* [TextFields] Cleanup.
* [TextFields] Correcting border.
* [TextFields] Correcting comment.
* [TextFields] Comment.
* [TextFields] Corrections for tests.
* [TextFields] Cleanup.
* [TextFields] Cleanup.
* [TextFields] Tests.
* [TextFields] Cleanup.
* [TextFields] Cleanup.
* [TextFields] Formatting.
* [TextFields] PR feedback.
* [TextFields] PR feedback.
* [TextFields] PR feedback.
2018-11-08 22:00:50 -05:00
Amir Hardon
903c5f8d29
Add DartDoc for UiKitViewController#acceptGesture ( #24127 )
2018-11-08 16:16:24 -08:00
jslavitz
75ca39f8c3
Animate user account drawer header arrow ( #24023 )
...
* Adds user account header arrow animation and test
2018-11-08 12:16:09 -08:00
Amir Hardon
dc4bf652cc
Make UiKitViews participate in gesture arenas ( #24027 )
2018-11-08 12:11:57 -08:00
engine-flutter-autoroll
0b953f92b6
Roll engine 70a1106b509e..22fc02028306 (10 commits) ( #24118 )
...
70a1106b50...22fc020283flutter/engine#6796 )
d372d56ae Roll src/third_party/skia 23d1f94faac1..fa8898747551 (1 commits) (flutter/engine#6794 )
8f105d79c Roll src/third_party/skia 2f8889b876d3..23d1f94faac1 (1 commits) (flutter/engine#6793 )
0ce31d660 Roll src/third_party/skia 71bcc7d63f8c..2f8889b876d3 (1 commits) (flutter/engine#6792 )
09ff6dc47 avoid overreleasing FlutterView (flutter/engine#6791 )
bd793c011 Roll src/third_party/skia f49563bf9276..71bcc7d63f8c (3 commits) (flutter/engine#6790 )
c8da28826 Roll Dart version to 9c07fb64c48adb3d6fde50bab6b8b641c5b67683 (flutter/engine#6788 )
94dd7165e Skia Cleanup (flutter/engine#6786 )
547b8585e Roll src/third_party/skia b52c273d3f05..f49563bf9276 (7 commits) (flutter/engine#6785 )
b6f76e07a Delete unused license goldens and add check (flutter/engine#6784 )
The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
2018-11-08 14:27:28 -05:00
Dan Field
9430906e77
clarify widgetsapp docs ( #24090 )
...
* clarify widgetsapp docs
* Rename shadowed param, update doc
* pageContentBuilder
2018-11-08 10:46:11 -08:00
Gary Qian
aab9244791
scriptCode support in gen_localizations and strip scriptCodes for date l10n. ( #23853 )
2018-11-08 10:43:40 -08:00
liyuqian
b21fe0aaad
Revert "Change engine merge method back to squash" ( #24114 )
...
Reverts flutter/flutter#24111 as https://skia-review.googlesource.com/c/buildbot/+/167200 has been deployed.
2018-11-08 09:12:06 -08:00
Todd Volkert
515dbcba82
Update API docs landing page. ( #24073 )
2018-11-08 09:00:47 -08:00
liyuqian
c0fc864a60
Change engine merge method back to squash ( #24111 )
...
We need to wait the fix in
https://skia-review.googlesource.com/c/buildbot/+/169724
to land in order to enable the rebase merge method again.
TBR: goderbauer
We'll land this quickly without waiting for presubmit checks
to unblock our engine roller.
2018-11-08 08:43:15 -08:00
Danny Tuppeny
2d5ed986e1
Update integration tests to use vm_service_lib ( #23937 )
...
* Move integration tests to use vm_service_lib
* Turn off debug logging that was accidentally committed
* Run update-packages --force to fix checksum for new dev dependency
* Trim trailing whitespace
2018-11-08 07:55:54 +00:00
Jonah Williams
d04fa1a670
only pass packages once ( #24074 )
2018-11-07 21:57:00 -08:00
Greg Spencer
a6e901130e
Convert existing '## Sample code' samples to '{@tool sample}...{@end-tool}' form. ( #24077 )
...
This converts existing ## Sample code samples to {@tool sample}...{@end-tool} form.
Also:
1. Fixed a minor bug in analyze-sample-code.dart
2. Made the snippet tool only insert descriptions if the description is non-empty.
3. Moved the Card diagram to before the code sample.
2018-11-07 20:35:10 -08:00
Dan Field
9d53d7f848
Update pubspec template docs for module/plugin ( #24081 )
...
* Document module pubspec
* update doc on plugin template
* clarify language
2018-11-07 17:20:18 -08:00
Ian Hickson
f9374fe071
Update the URL to the recommend bug report ( #23708 )
...
We have templates now.
2018-11-07 17:12:35 -08:00
engine-flutter-autoroll
8b751d8153
Roll engine 2494abdda728..70a1106b509e (3 commits) ( #24082 )
...
2494abdda7...70a1106b50flutter/engine#6757 )
f9095fcc4 Roll src/third_party/skia 62cc5f581747..b52c273d3f05 (13 commits) (flutter/engine#6783 )
4cdddbac4 Fix String comparison as if Java were Dart. (flutter/engine#6781 )
The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
2018-11-07 19:17:19 -05:00
jslavitz
5dac7a2347
Removes check for Homebrew if all necessary packages are present. ( #23844 )
...
* Removes need for homebrew installation if all other packages are installed. Modifies test to work with this new functionality.
2018-11-07 15:21:05 -08:00
Jonah Williams
00c07266c1
add frontend server as a non dart dep of fuchsia_tool ( #24075 )
2018-11-07 15:14:35 -08:00
Ryan Macnak
d92d175bcb
Opt into deterministic snapshots.
...
Also, remove old flags.
2018-11-07 14:44:20 -08:00
Hans Muller
4bb62b4348
Stop TextFields from wobbling within scrollables ( #24015 )
2018-11-07 14:27:25 -08:00
liyuqian
57c2fac14a
Add engine merge method configuration ( #23953 )
...
In order for this to take effect, https://skia-review.googlesource.com/c/buildbot/+/167200
needs to be landed and deployed.
The /bin/internal/engine.merge_method file controls how we merge a pull
request created by the engine auto-roller. If it's squash, there's only one
commit for a pull request no matter how many engine commits there are inside
that pull request. If it's rebase, the number of commits in the framework is
equal to the number of engine commits in the pull request. The latter method is
easier to detect regressions but cost more test resources.
2018-11-07 13:06:38 -08:00
jslavitz
50fb729609
Includes frameworkVersion in JSON version output ( #23891 )
...
* Include framework version in JSON output and adds test
2018-11-07 12:28:22 -08:00
jslavitz
7342816084
Adds fix for double comparison error ( #24026 )
...
* adds fix for rounding error
2018-11-07 12:27:08 -08:00
Dan Field
3d01e89e7a
Unbreak WidgetsApp when only a builder specified ( #23976 )
...
* update assert add test
* update docs
2018-11-07 12:16:35 -08:00
Jonah Williams
6c88b2e9fb
restore compileExpressionService ( #24063 )
2018-11-07 12:04:05 -08:00
engine-flutter-autoroll
fe6798bd25
Roll engine e64af7510e89..2494abdda728 (2 commits) ( #24065 )
...
e64af7510e...2494abdda7flutter/engine#6780 )
daeeedafa Roll src/third_party/skia 67f5c0ceac22..273fa2f3bd0b (1 commits) (flutter/engine#6779 )
The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
2018-11-07 15:03:19 -05:00
Greg Spencer
fbcd664e08
Generate a robots.txt when generating docs for API site. ( #24059 )
2018-11-07 10:19:25 -08:00
Michael Beckler
9abce96e8e
BottomNavigationBar: bug fix for dealing with animations with shifting tabs ( #22264 )
...
Should fix #22226 .
Code introduced in #20890 caused a regression that broke color flooding animations in a BottomNavigationBar that has BottomNavigationBarType.shifting.
The original issue (#19653 ) dealt with background color changes not occurring until another tab was selected. The result is that the background color instantly changes whenever the state changes and when the widget changes, instead of allowing a new widget to animate the background color change.
2018-11-07 09:20:27 -08:00
Greg Spencer
094f93dfcf
Fixes several bugs in samples, quotes HTML properly, and pre-compiles snippet tool. ( #24020 )
...
When converting all of the samples to use the snippet tool, I encountered some bugs/shortcomings:
1. The document production took 90 minutes, since the snippet tool was being invoked from the command line each time. I fixed this by snapshotting the executable before running, so it's down to 7 minutes.
2. The sample code was not being properly escaped by the snippet tool, so generics were causing issues in the HTML output. It is now quoted.
3. Code examples that used languages other than Dart were not supported. Anything that highlight.js was compiled for dartdoc with is now supported.
4. The comment color for highlight.js was light grey on white, which was pretty unreadable. It's now dark green and bold.
2018-11-07 08:29:14 -08:00
engine-flutter-autoroll
1594931605
Roll engine 824daacf6d95..e64af7510e89 (1 commits) ( #24052 )
...
824daacf6d...e64af7510eflutter/engine#6777 )
The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
2018-11-07 07:05:19 -05:00
engine-flutter-autoroll
baf3cf5d3c
Roll engine 4f4c470d2419..824daacf6d95 (1 commits) ( #24045 )
...
4f4c470d24...824daacf6dflutter/engine#6776 )
The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
2018-11-07 03:46:19 -05:00
Dan Field
220cceedb5
Fix heroes transition when initial route is not '/' ( #24039 )
...
* early return for initialRoute + test
2018-11-07 00:06:34 -08:00
Dan Field
028087d0fc
fix identifier for release.xcconfig in module template ( #23978 )
2018-11-06 22:44:01 -08:00
engine-flutter-autoroll
3fbf692af3
Roll engine e61f05256eaa..4f4c470d2419 (3 commits) ( #24038 )
...
e61f05256e...4f4c470d24flutter/engine#6775 )
177e043b5 fix setInitialRoute (flutter/engine#6774 )
6fa5c0a82 Pass scriptCode into Locale on initialization. (flutter/engine#6711 )
The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
2018-11-06 22:15:44 -08:00
engine-flutter-autoroll
ea82e5a650
Roll engine dda667f8f093..e61f05256eaa (2 commits) ( #24032 )
...
dda667f8f0...e61f05256eflutter/engine#6773 )
21eb1caae Update the contributing guide (flutter/engine#6754 )
The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
2018-11-06 21:23:35 -08:00
Jonah Williams
2fc2581be4
unpin mockito ( #24021 )
2018-11-06 17:24:39 -08:00
Gary Qian
08e0fd379e
Roll engine 5006ce574823..dda667f8f (3 commits), harfbuzz upgrade to 2.1.0 ( #24024 )
...
dda667f8f Roll update to harfbuzz to 2.1.0 (#6760 )
e8f0c08c9 Add instructions to download the full license log diff. (#6771 )
5077e95f1 Roll src/third_party/skia f2b35e4fb8cc..2aa9a22fe159 (7 commits) (#6770 )
2018-11-06 15:55:54 -08:00
jslavitz
34fa90b062
Improves SDK Search Error Messages ( #23884 )
...
* Improves error message and adds test.
2018-11-06 15:13:35 -08:00
engine-flutter-autoroll
99374edc6c
Roll engine fb5b097e5c20..5006ce574823 (4 commits) ( #24018 )
...
5006ce574 fix type in embedded views preview flag name (flutter/engine#6767 )
eec27fc8a Roll src/third_party/skia e70c6b13dd55..f2b35e4fb8cc (6 commits) (flutter/engine#6768 )
aea7071e2 Roll src/third_party/skia e6c85755832b..e70c6b13dd55 (1 commits) (flutter/engine#6766 )
1132d6c42 Roll src/third_party/skia 11407e56f277..e6c85755832b (2 commits) (flutter/engine#6765 )
2018-11-06 14:42:40 -08:00
Jonah Williams
81c7af342d
Add fuchsia specific entrypoint ( #23916 )
2018-11-06 14:36:35 -08:00
Ian Hickson
cf2fba7b3b
Reorganize contributor documentation ( #23963 )
2018-11-06 13:41:09 -08:00
Jonah Williams
ab2d0323a7
cleanup accessibility test skips in gallery ( #23977 )
2018-11-06 13:29:23 -08:00
Jonah Williams
48c00dc7d7
fix build for real ( #24016 )
2018-11-06 12:32:35 -08:00
Jonah Williams
e862580518
move file back ( #24014 )
2018-11-06 11:09:57 -08:00
xster
7be8562202
Add cupertino_icons dependency to module pubspec template ( #23961 )
2018-11-06 10:52:00 -08:00
Jonah Williams
a43e3a4a2f
Retry remove package:test from flutter ( #24007 )
2018-11-06 10:48:34 -08:00
Jonah Williams
23a7535a39
Revert "Remove package:test dependency from flutter_test ( #23755 )" ( #24004 )
...
This reverts commit 71e9bd6f25
2018-11-06 09:12:48 -08:00
Jonah Williams
71e9bd6f25
Remove package:test dependency from flutter_test ( #23755 )
2018-11-06 08:39:27 -08:00
