Commit graph

11401 commits

Author SHA1 Message Date
Ryan Macnak 68b0ba9d4b Revert "Make initialSemanticsTreeCreation less sensitive to GC timing. (#19491)"
This reverts commit 3840719987.

Bug: https://github.com/flutter/flutter/issues/19435
2018-07-24 15:32:28 -07:00
Jonah Williams 12aa7ec427
remove trailing whitespace (#19728) 2018-07-24 15:21:40 -07:00
Jonah Williams fba4fdb4e6
Fix off by one error in TextPainter. (#19429) 2018-07-24 14:26:06 -07:00
liyuqian ca93c53cbe
Roll engine to 95e91e31fad816738d3fef341256620e1819b6d9 (#19716)
95e91e31f Update tonic to pull in Android build fixes. (#5834)
29f475c8d Update tonic to pull in fixes to assertions and build failures on Windows. (#5833)
5474415e1 Roll src/third_party/skia e35055f31c7f..b8eeb808d84f (5 commits) (#5832)
380eb84c4 Remove unused function CreateSkiaInterface (#5812)
33a4aef1d Fix build break caused by https://github.com/flutter/engine/pull/5830 (#5831)
244ebd660 Reapply "Fix Dart 2 reload when running from a snapshot instead of platform.dill." (#5830)
0bad812c7 Migrate to a standalone Tonic repository separated from Topaz (#5817)
f949f7d43 Roll src/third_party/skia 206dbe8a21b6..e35055f31c7f (1 commits) (#5829)
768daa4d3 Roll src/third_party/skia 5e6cd2affe41..206dbe8a21b6 (5 commits) (#5828)
b8cd25b4f libtxt: fix a bug that used incorrect buffer size depending on conditions (#5804)
b7b13b5e9 Roll src/third_party/skia df795638b9bd..5e6cd2affe41 (1 commits) (#5824)
5886949c9 Roll src/third_party/skia dfe1fe40796e..df795638b9bd (1 commits) (#5822)
926f546de Roll src/third_party/skia cc22d4d2fb02..dfe1fe40796e (1 commits) (#5821)
04633f326 Generate process global trace identifiers for pipeline flow traces. (#5818)
fb0bc05d7 Roll src/third_party/skia 6f6de6524c73..cc22d4d2fb02 (1 commits) (#5820)
fadfff7fd Mention that running git clone isn't necessary (#5816)
81ec6000d Roll src/third_party/skia d3509a42638a..6f6de6524c73 (5 commits) (#5819)
2a77a4130 Make git diff range more robust in format.sh (#5813)
e555ea573 Remove trailing white spaces (#5734)
4c7618ac7 Roll src/third_party/skia fa0720436319..d3509a42638a (7 commits) (#5814)
2018-07-24 14:15:56 -07:00
Jonah Williams 810a29d663
Semantics framework updates (#18758)
Changes:

- Move the SemanticsConfiguration update from RenderToggleable to each subclass, so that Switch can use toggled.
- Add image, liveRegion, toggled properties to Semantics, SemanticsConfiguration, SemanticsNode
- Added semanticsLabel and excludeFromSemantics to Image (the latter so that we avoid creating a semantics node)
- Added onDismiss semantics action which maps to the modal escape on iOS and dismiss action on Android.
- Added dismiss and liveRegion to snackbar widget
- Updated custom painter semantics to handle image, liveRegion, toggle
- Updated relevant tests to use correct flag/action
2018-07-24 13:10:17 -07:00
matthew-carroll 687f059a89
Fix Flutter.java initialization crash (#19628) 2018-07-24 11:58:59 -07:00
Hans Muller 0863367c6e
Extend InputDecoration borders for disabled/error/focused states (#19694)
Added five InputBorder properties to InputDecoration etc so that apps can control the appearance of an InputDecorator's border:  errorBorder, focusedBorder, focusedErrorBorder, disabledBorder, enabledBorder.
2018-07-24 08:57:27 -07:00
Ian Hickson 56800d8fa1
Improve docs for FutureBuilder (#19687) 2018-07-23 22:56:03 -07:00
Danny Tuppeny 18a6a2aa33
Run "flutter update-packages --force-upgrade" (#19679) 2018-07-24 06:51:40 +01:00
sandrasandeep 834fb7b9a8
Add cursorWidth and cursorRadius to TextField (Material) cursor (#19317)
* fixed segmented control golden test

* fixed segmented control golden test

* made the comments more explanatory

* changed comment, wrapped tests with if statements so they only run on MacOS

* changed formatting

* added width and radius fields to TextField; to do: tests and Material defaults

* weak warnings

* added tests

* added default cursor width; changed default EditableText width

* only run golden file tests on linux

* changed goldens version

* actually changed goldens.version

* style changes

* small fixes

* added default material cursor color

* changed goldens.version

* changed goldens version again

* changed goldens.version again (3)

* added todo

* deleted whitespace
2018-07-23 16:33:39 -07:00
Greg Spencer f44f625c06
Fix whitespace detector to handle deleted files. (#19690)
The trailing whitespace detector wasn't handling file deletes very well (at all, really).

This filters the set of files grepped to only include files that exist.

Also, clarified the failure message to make it more obvious what the failure is when the grep finds results.
2018-07-23 15:41:31 -07:00
Jonah Williams d61b4fae64
Add ignoringSemantics argument to AbsorbPointer (#19651) 2018-07-23 15:28:34 -07:00
Ian Hickson b4d3808a15
Fix the checksum verification to be more sensitive (#19290)
* Fix the checksum verification to be more sensitive

* update packages
2018-07-23 13:01:22 -07:00
Danny Tuppeny 868d8c1458
In microbenchmarks, ensure flutter quits by sending q to stdin (#19400)
* Tell flutter to quit directly

Fixes #19208.

* Tweak comment
2018-07-23 18:53:19 +01:00
Gary Miguel a7b59b51b8 Remove redundant check for platform.isLinux. (#19441)
We don't actually care if we're on linux, we care only if the lcov
tool is available. We check for that explicitly just below.
Additionally there is code below which indicates that lcov is available
for macOS. Before this change that code would never execute.
2018-07-23 08:38:20 -07:00
Alexandre Ardhuin 27018359d2
re-enable lint unnecessary_const (#19592)
* re-enable lint unnecessary_const

* remove trailling whitespaces

* remove unnecessary const (after merge)
2018-07-23 08:31:48 +02:00
Lukas Piliszczuk 1cb2677234 Change material RefreshIndictor.onRefresh signature from Future<Null> to Future<void> (#18775)
* Change material refresh indicator onRefresh signature from Future<Null> to Future<void>.

* Update authors.

* Explicitly name void argument.
2018-07-21 15:30:53 -07:00
Jonah Williams e154298e0b
Roll engine to 96f5f5b96c7220ffc8c4ce22ed895616a15ad3a0 (#19615) 2018-07-21 00:45:16 -07:00
Greg Spencer 3bff2e4666
Shard the Appveyor tests. (#19631) 2018-07-20 22:30:02 -07:00
amirh debd50158e
Introduce an AndroidView widget and a RenderAndroidView render object. (#19565)
RenderAndroidView is responsible for sizing and displaying an embedded
Android view.
AndroidView is responsible for creating and disposing the Android view
and is using RenderAndroidView to display it.
2018-07-20 15:58:55 -07:00
jslavitz 9a4db21129
Changed duration (#19015)
* Changed duration

* Fixed column width for ios build error messages

* fixed a couple things

* fixed a couple things

* accidental changes

* added spaces

* added spaces

* Added test for default snackbar duration

* Fixed link:

* Final commit

* Final commit2

* Actual final commit
2018-07-20 15:17:44 -07:00
Leaf Petersen 32f94443cc
Remove uses of deprecated constants and change int.parse to int.tryParse (#19575)
* Remove uses of deprecated constants
* Change int.parse to int.tryParse where appropriate
2018-07-20 15:07:24 -07:00
Ian Hickson 35346b4966
Increase verbosity on bots during setup and other minor cleanup (#19526)
The verbosity change is to help track down timeouts that currently look like:

```
C:\Windows\Temp\flutter sdk>call bin\flutter.bat config --no-analytics
Checking Dart SDK version...
Downloading Dart SDK from Flutter engine c5a63d28bf3735569c8187753bc490d8351a8363...
Unzipping Dart SDK...
Updating flutter tool...
```
2018-07-20 11:01:45 -07:00
Michael Goderbauer 8a00318e89
Whitespace fixes to make Travis happy (#19611)
Follow-up to https://github.com/flutter/flutter/pull/18562, which passed Travis before the check was added.
2018-07-20 10:51:41 -07:00
Greg Spencer 90a5f4613f
Separate tools tests from other tests and put them in a different shard. (#19593) 2018-07-20 10:21:34 -07:00
Norbert Kozsir a14b4f621e Making the space between keyboard and text-field when the keyboard pops up a variable. (#18562) 2018-07-20 09:46:24 -07:00
Sarah Zakarias f0639bb022
add more uses of FlutterProject to locate files (#19403) 2018-07-20 09:21:41 +02:00
Greg Spencer 9f39039f7b
Add presubmit test for trailing whitespace. (#19412)
Checks only changed source files (C++, Dart, Java, ObjC) for trailing whitespace.
2018-07-19 23:05:37 -07:00
Greg Spencer 1cc036519c
Removes trailing whitespace from source files. (#19329) 2018-07-19 23:03:58 -07:00
Sigurd Meldgaard 2d3a5c744d
Revert "Revert "Use FlutterProject to locate files (#18913)" (#19409)" (#19456)
With a fix of a path being printed relative instead of absolute.
2018-07-20 08:00:30 +02:00
Jonah Williams d2d17abeec
Add support for custom semantics actions to Android and iOS. (#18882) 2018-07-19 20:47:21 -07:00
Alex Allen 924c206cf8 Add optional haptic feedback on LongPressDraggable (#18781) 2018-07-19 20:21:40 -07:00
Jonah Williams a66ea0a628
add textCapitalization property (#19367) 2018-07-19 18:06:44 -07:00
Jonah Williams eb69f59461
Allow material button to grow as wide as its constraints allow (#19416) 2018-07-19 14:20:46 -07:00
Hans Muller 73960e7569
Added 20 new supported locales to Material (#19567) 2018-07-19 14:19:21 -07:00
Ryan Macnak 0c79970df3 Roll engine to 482469bad8094ff05fd66dfc07149fbef4ae00ac.
482469bad Roll Dart to 937ee2e8ca4b76499e24cd463f07bfb736bccd74. (#5800)
bb323c145 Revert "Roll src/third_party/skia 9e0d7e4072e4..297c3c8e85bd (62 commits) (#5802)" (#5803)
0bf69f02d Roll src/third_party/skia 9e0d7e4072e4..297c3c8e85bd (62 commits) (#5802)
2018-07-19 13:30:15 -07:00
Ryan Macnak 0442ab8b8b Roll engine to 5d0e13a45b210b9b05427cccfc5f94928ae701ab.
5d0e13a45 Fix starting isolate directly from CoreJIT snapshot. (#5798)
2018-07-19 13:30:15 -07:00
Ryan Macnak c4328e0053 Roll engine to 09ff9493e08c0c937bcd2c6f780981e2a7c5f2b5.
09ff9493e Re-land removal of vmservice_io from release builds. (#5784)
b523ee847 Revert "Switch to Fuchsia's ICU (#5774)" (#5801)
69695493b Switch to Fuchsia's ICU (#5774)
2018-07-19 13:30:15 -07:00
Ryan Macnak 2a058d3a58 Roll engine to 55b423f07ff747c2303c957fe151487b45585192.
55b423f07 Ensure assistiveTechnologyEnabled is initialized when the android view is set up (#5793)
3054f3183 Add touch events to the platform views method channel API. (#5796)
91c16af0c Revert "Roll Dart to 937ee2e8ca4b76499e24cd463f07bfb736bccd74. (#5745)" (#5799)
1a66f895b Roll Dart to 937ee2e8ca4b76499e24cd463f07bfb736bccd74. (#5745)
8d046a727 Revert "Roll src/third_party/skia 9e0d7e4072e4..8f8bf8880d9d (32 commits) (#5794)" (#5797)
e8d172cf3 Revert "Fix Dart 2 reload when running from a snapshot instead of platform.dill. (#5792)" (#5795)
624cf7e25 Fix Dart 2 reload when running from a snapshot instead of platform.dill. (#5792)
16da4710d Roll src/third_party/skia 9e0d7e4072e4..8f8bf8880d9d (32 commits) (#5794)
3fe63fd5d Add presubmit check for engine to flutter roll (#5790)
2018-07-19 13:30:15 -07:00
matthew-carroll 3ca6445c99
Added textInputAction parameter to TextFormField that forwards to TextField, added onEditingComplete parameter to TextField that forwards to EditableText, added onEditingComplete parameter to TextFormField that forwards to TextField. (#19397) (#19427) 2018-07-19 13:22:45 -07:00
TL Lee 865d809d61
Revert accidental force push: 99457c92d7 (#19573) 2018-07-19 16:04:02 -04:00
Jason Simmons e80c699cc9
Keep the debug repaint rainbow color within a valid range (#19355)
Fixes https://github.com/flutter/flutter/issues/18971
2018-07-19 12:58:52 -07:00
Tian Lun Lee 99457c92d7 Add build test for Flutter codelabs 2018-07-19 15:26:49 -04:00
Danny Tuppeny d9ee971e38
Fix copy/paste error in test (#19564) 2018-07-19 19:52:15 +01:00
amirh c1de12dd44
Skip flaky test (expression_evaluation_test) (#19543) 2018-07-19 10:20:28 -07:00
Chris Bracken bb338ef2c6
Don't bundle Genereted.xcconfig as a resource (#19544)
Generated.xcconfig is only required at build time for iOS apps. In the
flutter create project template and example apps, Generated.xcconfig was
previously marked as a resource to be bundled into the built app.
2018-07-19 07:24:06 -07:00
Hans Muller a960b870cc
Enable extended FAB hero transition resizing (#19534) 2018-07-19 07:15:13 -07:00
Danny Tuppeny 6016882a56
Update devicelab test with new message prefix (#19560)
While working on attach, I changed the message output while waiting for an app to connect but didn't catch this.
2018-07-19 14:59:20 +01:00
Danny Tuppeny ed9afbbc72
Add --machine support for flutter attach (#19077)
* Extract some of startApp into a reusable method

* Get basic attach --machine working

* Attach --machine tweaks

Move validation to validate method and create daemon early so we get the startup event before trying to get a connection.

* Bump daemon version so we know whether it's valid to flutter attach

* Tweak output text

* Swap package imports for relative

* Review tweaks (naming, formatting, typedefs)

* Separate arguments from process spawning

This will make calling attach easier

* Add a basic test for flutter attach --machine

* Fix crash if port unforward modifies the list of forwarded ports

* Add a no-op port forwarder for flutter-tester

* Switch to using BasicProject instead of our own inline code

* Fix expectation in test now we have a portForwarder

* Remove stale TODO (this is done)

* Tweak formatting

* Change some Completers to void to fix Dart 2 issues
2018-07-19 13:38:29 +01:00
Danny Tuppeny 442fc3cf06
Make cleanup of flutter processes in tests more reliable (#19307)
* Make cleanup of flutter processes in tests more reliable

* Fix quit signals

I confused SigInt&SigTerm for SigTerm&SigKill when I first did this. SigTerm can be blocked and doesn't guarantee the process will be terminated.

* Don't use deprecated constants

* Fix typo

* Add some additional info to debug buffer

* Fix return types on Futures
2018-07-19 11:37:40 +01:00