Jago
5c5e64722e
[material] Fix info text ( #147040 )
...
Fixes intro info text for `IconButton.outlined` constructor.
No fixing issue required as this is a text fix.
2024-04-19 22:55:05 +00:00
engine-flutter-autoroll
5931b7b1ce
Roll Flutter Engine from 0902c4117ed9 to a9a6f598f007 (1 revision) ( #147088 )
...
0902c4117e...a9a6f598f0skia-flutter-autoroll@skia.org Roll Skia from 0689969ffaee to f4a214ecf197 (1 revision) (flutter/engine#52265 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-04-19 22:22:11 +00:00
engine-flutter-autoroll
6b2122bfa6
Roll Flutter Engine from 5083af669cee to 0902c4117ed9 (1 revision) ( #147085 )
...
5083af669c...0902c4117eflar@google.com [Impeller] Use the new DisplayList depth info in the experimental canvas prototype (flutter/engine#52214 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-04-19 21:22:26 +00:00
Kostia Sokolovskyi
a4e9026589
Add test for animated_padding.0.dart API example. ( #146718 )
...
This PR contributes to https://github.com/flutter/flutter/issues/130459
### Description
- Adds `examples/api/test/widgets/implicit_animations/animated_padding.0_test.dart` test
2024-04-19 20:16:56 +00:00
Jesse
3b21c27c08
Refactor android preview tool integration tests ( #146518 )
...
Android preview tool integration test refactoring
Part of https://github.com/flutter/flutter/issues/145482
2024-04-19 20:05:33 +00:00
engine-flutter-autoroll
ca170341c3
Roll Flutter Engine from 1363b52813e3 to 5083af669cee (1 revision) ( #147083 )
...
1363b52813...5083af669cskia-flutter-autoroll@skia.org Roll Dart SDK from 1c49f17b5437 to 2ff00e4eb759 (1 revision) (flutter/engine#52264 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-04-19 20:00:20 +00:00
Kostia Sokolovskyi
cb3e689167
Add test for dismissible.0.dart API example. ( #146723 )
...
This PR contributes to https://github.com/flutter/flutter/issues/130459
### Description
- Adds `examples/api/test/widgets/dismissible/dismissible.0_test.dart` test
2024-04-19 19:21:08 +00:00
engine-flutter-autoroll
c1689166c6
Roll Flutter Engine from 908f619d9e1c to 1363b52813e3 (4 revisions) ( #147079 )
...
908f619d9e...1363b52813skia-flutter-autoroll@skia.org Roll Skia from fa31a916cbb8 to 0689969ffaee (1 revision) (flutter/engine#52263 )
2024-04-19 skia-flutter-autoroll@skia.org Roll Skia from d01e53b8beb7 to fa31a916cbb8 (1 revision) (flutter/engine#52261 )
2024-04-19 jonahwilliams@google.com [Impeller] remove absorb opacity limit. (flutter/engine#52160 )
2024-04-19 30870216+gaaclarke@users.noreply.github.com [Impeller] cleaned up semantics for RenderPipelineT and added docstrings (flutter/engine#52237 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-04-19 19:19:11 +00:00
Elias Yishak
be0eb721d5
Update docs around ga3 ga4 mismatch ( #147075 )
...
Fixing nit in code doc
2024-04-19 19:15:09 +00:00
Kostia Sokolovskyi
e09ee6be9b
Add test for preferred_size.0.dart API example. ( #146725 )
...
This PR contributes to https://github.com/flutter/flutter/issues/130459
### Description
- Adds `examples/api/test/widgets/preferred_size/preferred_size.0_test.dart` test
2024-04-19 19:08:07 +00:00
engine-flutter-autoroll
c1c661cb93
Roll Flutter Engine from 9cc1cc3de1a7 to 908f619d9e1c (1 revision) ( #147068 )
...
9cc1cc3de1...908f619d9eskia-flutter-autoroll@skia.org Roll Skia from 0bdd0daaa3fc to d01e53b8beb7 (2 revisions) (flutter/engine#52260 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-04-19 17:36:25 +00:00
engine-flutter-autoroll
b5589e42db
Roll Flutter Engine from 7fafbbf17c02 to 9cc1cc3de1a7 (1 revision) ( #147061 )
...
7fafbbf17c...9cc1cc3de1skia-flutter-autoroll@skia.org Roll Dart SDK from 3e139f5d0720 to 1c49f17b5437 (1 revision) (flutter/engine#52259 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-04-19 16:12:56 +00:00
engine-flutter-autoroll
66cdf117f7
Roll Packages from 0e3809d995b6 to 88a3a561f16c (4 revisions) ( #147059 )
...
0e3809d995...88a3a561f1stuartmorgan@google.com [camera] Convert iOS Obj-C->Dart calls to Pigeon (flutter/packages#6568 )
2024-04-19 highdro0479@gmail.com [flutter_markdown] Ensure customize nested bullet list style. (flutter/packages#6384 )
2024-04-18 stuartmorgan@google.com [ci] Add more dev dependency checks, and fix errors (flutter/packages#6563 )
2024-04-18 engine-flutter-autoroll@skia.org Roll Flutter from 3882afbfa9fb110b98daflutter/packages#6565 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com ,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-04-19 15:58:04 +00:00
Victoria Ashworth
98685a099f
Replace CocoaPods deprecated exists? with exist? ( #147056 )
...
Fixes https://github.com/flutter/flutter/issues/147041 .
2024-04-19 15:21:04 +00:00
engine-flutter-autoroll
4f7b7c93ff
Roll Flutter Engine from 4ed7a2d6aed9 to 7fafbbf17c02 (2 revisions) ( #147046 )
...
4ed7a2d6ae...7fafbbf17cskia-flutter-autoroll@skia.org Roll Skia from 7ad507eca0bd to 0bdd0daaa3fc (1 revision) (flutter/engine#52257 )
2024-04-19 skia-flutter-autoroll@skia.org Roll Dart SDK from 12e49f395fd9 to 3e139f5d0720 (1 revision) (flutter/engine#52256 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-04-19 13:06:28 +00:00
engine-flutter-autoroll
9feccd5f3b
Roll Flutter Engine from 25d773ea90c4 to 4ed7a2d6aed9 (3 revisions) ( #147038 )
...
25d773ea90...4ed7a2d6aeskia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from peYcbx9eguHcbhMP0... to RruZA4WorQDkGpz25... (flutter/engine#52252 )
2024-04-19 skia-flutter-autoroll@skia.org Roll Dart SDK from a46161eec56d to 12e49f395fd9 (1 revision) (flutter/engine#52251 )
2024-04-19 skia-flutter-autoroll@skia.org Roll Skia from ca5481ebd0fb to 7ad507eca0bd (2 revisions) (flutter/engine#52249 )
Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from peYcbx9eguHc to RruZA4WorQDk
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-04-19 09:08:40 +00:00
Pierre-Louis
4deff2dd9c
Update link branches to main (continued) ( #146985 )
...
I generalized the analysis to match all `googlesource.com` repos. I also
added a test and fixed more cases.
Part of https://github.com/flutter/flutter/issues/121564
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
[Data Driven Fixes]:
https://github.com/flutter/flutter/wiki/Data-driven-Fixes
2024-04-19 10:46:24 +02:00
engine-flutter-autoroll
12d54de962
Roll Flutter Engine from b6234dd1984e to 25d773ea90c4 (1 revision) ( #147035 )
...
b6234dd198...25d773ea90skia-flutter-autoroll@skia.org Roll Skia from fef9f270935c to ca5481ebd0fb (1 revision) (flutter/engine#52246 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-04-19 07:10:34 +00:00
engine-flutter-autoroll
d4b42780ba
Roll Flutter Engine from ff471881e90a to b6234dd1984e (2 revisions) ( #147029 )
...
ff471881e9...b6234dd198skia-flutter-autoroll@skia.org Roll Dart SDK from 62b85ea79bce to a46161eec56d (1 revision) (flutter/engine#52243 )
2024-04-19 bquinlan@google.com Add a dependency on `package:web_socket` in pkg_demo_test (flutter/engine#52239 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-04-19 04:21:25 +00:00
engine-flutter-autoroll
20034ce0a2
Roll Flutter Engine from 442d14a7e840 to ff471881e90a (1 revision) ( #147025 )
...
442d14a7e8...ff471881e9skia-flutter-autoroll@skia.org Roll Skia from 8fd4d8eaadc2 to fef9f270935c (7 revisions) (flutter/engine#52240 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-04-19 02:33:19 +00:00
engine-flutter-autoroll
c59e2e3b77
Roll Flutter Engine from 6e4a15d31769 to 442d14a7e840 (2 revisions) ( #147023 )
...
6e4a15d317...442d14a7e8jonahwilliams@google.com [Impeller] dont use half precision constants / Fixes for SPIRV tools roll (flutter/engine#52213 )
2024-04-18 skia-flutter-autoroll@skia.org Roll Skia from edece87ce734 to 8fd4d8eaadc2 (1 revision) (flutter/engine#52238 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-04-19 01:23:06 +00:00
Elias Yishak
1c3372fa38
Opt out users from GA3 if opted out of GA4 ( #146453 )
...
This PR will opt out users from legacy analytics if they have already been opted out from package:unified_analytics.
After successfully merging into main, this will be CP'd into beta and stable channels
2024-04-19 01:03:15 +00:00
engine-flutter-autoroll
8c891ba5ba
Roll Flutter Engine from 61bf47d129bb to 6e4a15d31769 (1 revision) ( #147022 )
...
61bf47d129...6e4a15d317dkwingsmt@users.noreply.github.com [macOS] Rename viewId to viewIdentifier (flutter/engine#52202 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-04-19 00:39:36 +00:00
engine-flutter-autoroll
4464360d86
Roll Flutter Engine from 13a6ce419664 to 61bf47d129bb (4 revisions) ( #147017 )
...
13a6ce4196...61bf47d129skia-flutter-autoroll@skia.org Roll Dart SDK from 8d834bbb2163 to 62b85ea79bce (1 revision) (flutter/engine#52236 )
2024-04-18 skia-flutter-autoroll@skia.org Roll Skia from 1af1e478ef85 to edece87ce734 (5 revisions) (flutter/engine#52233 )
2024-04-18 chinmaygarde@google.com Suppress in-actionable warnings in the iOS profiler. (flutter/engine#52227 )
2024-04-18 30870216+gaaclarke@users.noreply.github.com [Impeller] sorted commonly used default pipelines first (flutter/engine#52231 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-04-18 23:43:48 +00:00
Ian Hickson
3e22598a14
Add a breadcrumb for the pub autoroller ( #146786 )
...
Adds some breadcrumbs to update-packages so that people can easily figure out how to tell what's going on with the pub autoroller.
2024-04-18 23:34:31 +00:00
auto-submit[bot]
bb4c9b381e
Reverts "Add generic type for result in PopScope ( #139164 )" ( #147015 )
...
Reverts: flutter/flutter#139164
Initiated by: chunhtai
Reason for reverting: hard breaking change
Original PR Author: chunhtai
Reviewed By: {justinmc}
This change reverts the following previous change:
Adds a generic type and pop result to popscope and its friend.
The use cases are to be able to capture the result when the pop is called.
migration guide: https://github.com/flutter/website/pull/9872
2024-04-18 22:36:26 +00:00
Zayd Krunz
e8fc89e690
Redundant message fix ( #143978 )
...
Saying that the commands only work on macOS is redundant because the command is only shown on macOS hosts.
2024-04-18 22:33:10 +00:00
Jesse
ece6ac2bb6
Clean up flutterRoot ( #147010 )
...
The flutterroot param is accessible from the util function after the recent refactor of utils https://github.com/flutter/flutter/pull/146592 so this change cleans up the references to the suite runners to make them simpler.
Part of https://github.com/flutter/flutter/issues/145482
2024-04-18 22:33:08 +00:00
dependabot[bot]
7433225a95
Bump actions/upload-artifact from 4.3.1 to 4.3.2 ( #147011 )
...
Bumps [actions/upload-artifact](https://github.com/actions/upload-artifact ) from 4.3.1 to 4.3.2.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/actions/upload-artifact/releases ">actions/upload-artifact's releases</a>.</em></p>
<blockquote>
<h2>v4.3.2</h2>
<h2>What's Changed</h2>
<ul>
<li>Update release-new-action-version.yml by <a href="https://github.com/konradpabjan "><code>@âkonradpabjan</code></a> in <a href="https://redirect.github.com/actions/upload-artifact/pull/516 ">actions/upload-artifact#516</a></li>
<li>Minor fix to the migration readme by <a href="https://github.com/andrewakim "><code>@âandrewakim</code></a> in <a href="https://redirect.github.com/actions/upload-artifact/pull/523 ">actions/upload-artifact#523</a></li>
<li>Update readme with v3/v2/v1 deprecation notice by <a href="https://github.com/robherley "><code>@ârobherley</code></a> in <a href="https://redirect.github.com/actions/upload-artifact/pull/561 ">actions/upload-artifact#561</a></li>
<li>updating <code>@actions/artifact</code> dependency to v2.1.5 and <code>@actions/core</code> to v1.0.1 by <a href="https://github.com/eggyhead "><code>@âeggyhead</code></a> in <a href="https://redirect.github.com/actions/upload-artifact/pull/562 ">actions/upload-artifact#562</a></li>
</ul>
<h2>New Contributors</h2>
<ul>
<li><a href="https://github.com/andrewakim "><code>@âandrewakim</code></a> made their first contribution in <a href="https://redirect.github.com/actions/upload-artifact/pull/523 ">actions/upload-artifact#523</a></li>
</ul>
<p><strong>Full Changelog</strong>: <a href="https://github.com/actions/upload-artifact/compare/v4.3.1...v4.3.2 ">https://github.com/actions/upload-artifact/compare/v4.3.1...v4.3.2 </a></p>
</blockquote>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="1746f4ab6531685d04a018bf333cd2https://redirect.github.com/actions/upload-artifact/issues/562 ">#562</a> from actions/eggyhead/update-artifact-v215</li>
<li><a href="dac413befabb3b4a3cdb3e3da837d2e35774f165https://redirect.github.com/actions/upload-artifact/issues/561 ">#561</a> from actions/robherley/deprecation-notice</li>
<li><a href="e63ea677fbef09cdac3ehttps://redirect.github.com/actions/upload-artifact/issues/523 ">#523</a> from andrewakim/andrewakim/migration-readme-fix</li>
<li><a href="00e36f94d85d5d22a312...1746f4ab65https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=actions/upload-artifact&package-manager=github_actions&previous-version=4.3.1&new-version=4.3.2 )](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores )
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.
---
<details>
<summary>Dependabot commands and options</summary>
<br />
You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency
- `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
</details>
2024-04-18 22:33:05 +00:00
Victoria Ashworth
6d19fa3bfa
Add Swift Package Manager as new opt-in feature for iOS and macOS ( #146256 )
...
This PR adds initial support for Swift Package Manager (SPM). Users must opt in. Only compatible with Xcode 15+.
Fixes https://github.com/flutter/flutter/issues/146369 .
## Included Features
This PR includes the following features:
* Enabling SPM via config
`flutter config --enable-swift-package-manager`
* Disabling SPM via config (will disable for all projects)
`flutter config --no-enable-swift-package-manager`
* Disabling SPM via pubspec.yaml (will disable for the specific project)
```
flutter:
disable-swift-package-manager: true
```
* Migrating existing apps to add SPM integration if using a Flutter plugin with a Package.swift
* Generates a Swift Package (named `FlutterGeneratedPluginSwiftPackage`) that handles Flutter SPM-compatible plugin dependencies. Generated package is added to the Xcode project.
* Error parsing of common errors that may occur due to using CocoaPods and Swift Package Manager together
* Tool will print warnings when using all Swift Package plugins and encourage you to remove CocoaPods
This PR also converts `integration_test` and `integration_test_macos` plugins to be both Swift Packages and CocoaPod Pods.
## How it Works
The Flutter CLI will generate a Swift Package called `FlutterGeneratedPluginSwiftPackage`, which will have local dependencies on all Swift Package compatible Flutter plugins.
The `FlutterGeneratedPluginSwiftPackage` package will be added to the Xcode project via altering of the `project.pbxproj`.
In addition, a "Pre-action" script will be added via altering of the `Runner.xcscheme`. This script will invoke the flutter tool to copy the Flutter/FlutterMacOS framework to the `BUILT_PRODUCTS_DIR` directory before the build starts. This is needed because plugins need to be linked to the Flutter framework and fortunately Swift Package Manager automatically uses `BUILT_PRODUCTS_DIR` as a framework search path.
CocoaPods will continue to run and be used to support non-Swift Package compatible Flutter plugins.
## Not Included Features
It does not include the following (will be added in future PRs):
* Create plugin template
* Create app template
* Add-to-App integration
2024-04-18 21:12:36 +00:00
Jesse
f0fc419a6c
Refactor framework coverage tests ( #146210 )
...
Refactor framework coverage tests in order to reduce testing logic in test.dart and allow for later implementing package:test onto the existing framework coverage tests
Part of https://github.com/flutter/flutter/issues/145482
2024-04-18 21:07:05 +00:00
engine-flutter-autoroll
7610ceca42
Roll Flutter Engine from 46ff024bff10 to 13a6ce419664 (3 revisions) ( #147006 )
...
46ff024bff...13a6ce4196skia-flutter-autoroll@skia.org Roll Skia from dc6df9137614 to 1af1e478ef85 (10 revisions) (flutter/engine#52230 )
2024-04-18 goderbauer@google.com Fix docs for SemanticsAction (flutter/engine#52229 )
2024-04-18 skia-flutter-autoroll@skia.org Roll Dart SDK from a0caf3de902d to 8d834bbb2163 (1 revision) (flutter/engine#52228 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-04-18 21:05:09 +00:00
Jackson Gardner
fd25493f60
Changing the renderer on the web target should change its build key. ( #147003 )
...
Changing the web renderer doesn't directly modify the environment's dart defines, and so doesn't do a full build invalidation. We need to include the web renderer in the build key for the compiler configuration. This information is used directly by the web targets to modify the dart defines that are passed into the compiler, so we need to rebuild if this information changes.
2024-04-18 21:05:06 +00:00
engine-flutter-autoroll
94ef462259
Roll Flutter Engine from 6abfa565a9f9 to 46ff024bff10 (1 revision) ( #147005 )
...
6abfa565a9...46ff024bffjonahwilliams@google.com [Impeller] Reland: remove most temporary allocation during polyline generation. (flutter/engine#52180 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-04-18 20:10:13 +00:00
chunhtai
7ee05a05ff
Add generic type for result in PopScope ( #139164 )
...
Adds a generic type and pop result to popscope and its friend.
The use cases are to be able to capture the result when the pop is called.
migration guide: https://github.com/flutter/website/pull/9872
2024-04-18 19:30:10 +00:00
engine-flutter-autoroll
ffa3b303ee
Roll Flutter Engine from aa6f7411c219 to 6abfa565a9f9 (1 revision) ( #147002 )
...
aa6f7411c2...6abfa565a9skia-flutter-autoroll@skia.org Roll Skia from 1f74f67959f2 to dc6df9137614 (2 revisions) (flutter/engine#52224 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-04-18 19:07:18 +00:00
Chris Bracken
c219bf73fc
[tools] Make SnapshotType.platform non-nullable ( #146958 )
...
When performing artifact lookups for `Artifact.genSnapshot` for macOS desktop builds, a `TargetPlatform` is used to determine the name of the tool, typically `gen_snapshot_$TARGET_ARCH`. Formerly, this tool was always named `gen_snapshot`.
The astute reader may ask "but Chris, didn't we support TWO target architectures on iOS and therefore need TWO `gen_snapshot` binaries?" Yes, we did support both armv7 and arm64 target architectures on iOS. But no, we didn't initially have two `gen_snapshot` binaries. We did *build* two `gen_snapshots`:
* A 32-bit x86 binary that emitted armv7 AOT code
* A 64-bit x64 binary that emitted arm64 AOT code
At the time, the bitness of the `gen_snapshot` tool needed to match the bitness of the target architecture, and to avoid having to do a lot of work plumbing through suffixed `gen_snapshot` names, the author of that work (who, as evidenced by this patch, is still paying for his code crimes) elected to "cleverly" lipo the two together into a single multi-architecture macOS binary still named `gen_snapshot`. See: https://github.com/flutter/engine/pull/4948
This was later remediated over the course of several patches, including:
* https://github.com/flutter/engine/pull/10430
* https://github.com/flutter/engine/pull/22818
* https://github.com/flutter/flutter/pull/37445
However, there were still cases (notably `--local-engine` workflows in the tool) where we weren't computing the target platform and thus referenced the generic `gen_snapshot` tool.
See: https://github.com/flutter/flutter/issues/38933
Fixed in: https://github.com/flutter/engine/pull/28345
The test removed in this PR, which ensured that null `SnapshotType.platform` was supported was introduced in https://github.com/flutter/flutter/pull/11924 as a followup to https://github.com/flutter/flutter/pull/11820 when the snapshotting logic was originally extracted to the `GenSnapshot` class, and most invocations still passed a null target platform.
Since there are no longer any cases where `TargetPlatform` isn't passed when looking up `Artifact.genSnapshot`, we can safely make the platform non-nullable and remove the test.
This is pre-factoring towards the removal of the generic `gen_snapshot` artifact from the macOS host binaries (which are currently unused since we never pass a null `TargetPlatform`), which is pre-factoring towards the goal of building `gen_snapshot` binaries with an arm64 host architecture, and eliminate the need to use Rosetta during iOS and macOS Flutter builds.
Part of: https://github.com/flutter/flutter/issues/101138
Umbrella issue: https://github.com/flutter/flutter/issues/103386
Umbrella issue: https://github.com/flutter/flutter/issues/69157
No new tests since the behaviour is enforced by the compiler.
2024-04-18 16:34:06 +00:00
engine-flutter-autoroll
b25f90995a
Roll Flutter Engine from b8e802515b5a to aa6f7411c219 (1 revision) ( #146996 )
...
b8e802515b...aa6f7411c2skia-flutter-autoroll@skia.org Roll Skia from d7f79d7183cd to 1f74f67959f2 (3 revisions) (flutter/engine#52223 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-04-18 16:34:05 +00:00
engine-flutter-autoroll
5321626655
Roll Flutter Engine from 2c3e9c8bfce6 to b8e802515b5a (2 revisions) ( #146993 )
...
2c3e9c8bfc...b8e802515bskia-flutter-autoroll@skia.org Roll Dart SDK from 415669e2604d to a0caf3de902d (1 revision) (flutter/engine#52222 )
2024-04-18 skia-flutter-autoroll@skia.org Roll Skia from 4fb772942c5c to d7f79d7183cd (1 revision) (flutter/engine#52221 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-04-18 15:53:20 +00:00
engine-flutter-autoroll
af0649317a
Roll Packages from d39830e40c07 to 0e3809d995b6 (9 revisions) ( #146992 )
...
d39830e40c...0e3809d995flutter/packages#6562 )
2024-04-18 stuartmorgan@google.com [ci] Add Linux desktop support to Linux custom_package_tests (flutter/packages#6551 )
2024-04-17 katelovett@google.com [two_dimensional_scrollables] Refactor Spans for common use (flutter/packages#6550 )
2024-04-17 reidbaker@google.com [in_app_purchase] Add api to expose country code (flutter/packages#6540 )
2024-04-17 stuartmorgan@google.com [camera] Initial iOS Pigeon conversion (flutter/packages#6553 )
2024-04-17 reidbaker@google.com [in_app_purchase] Add countryCode implementation to android and storekit (flutter/packages#6556 )
2024-04-17 magder@google.com [google_sign_in_ios] Upgrade GoogleSignIn iOS SDK to 7.1 (flutter/packages#6404 )
2024-04-17 reidbaker@google.com [in_app_purchase_platform_interface] Adds countryCode API (flutter/packages#6548 )
2024-04-17 stuartmorgan@google.com [google_maps_flutter] Update app-facing package iOS requirements (flutter/packages#6552 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com ,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-04-18 15:49:40 +00:00
Valentin Vignal
cbf35b4e85
Fix memory leaks in navigation rail ( #146988 )
2024-04-18 08:03:19 -07:00
Valentin Vignal
fb110b98da
Fix memory leaks in MaterialBanner ( #146963 )
2024-04-18 07:21:18 -07:00
Valentin Vignal
c83d650de4
Fix memory leak in data table ( #146892 )
2024-04-18 07:16:32 -07:00
Valentin Vignal
47a4c69b82
Dispose the curved animation in transition test ( #146961 )
2024-04-18 07:14:15 -07:00
engine-flutter-autoroll
a6c7f90bb5
Roll Flutter Engine from 5687011d5e94 to 2c3e9c8bfce6 (1 revision) ( #146982 )
...
5687011d5e...2c3e9c8bfcskia-flutter-autoroll@skia.org Roll Skia from 54c2053bab03 to 4fb772942c5c (1 revision) (flutter/engine#52220 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-04-18 11:25:23 +00:00
engine-flutter-autoroll
b9e9435b25
Roll Flutter Engine from 132d364ef373 to 5687011d5e94 (2 revisions) ( #146972 )
...
132d364ef3...5687011d5eskia-flutter-autoroll@skia.org Roll Skia from 32a36614f879 to 54c2053bab03 (2 revisions) (flutter/engine#52218 )
2024-04-18 skia-flutter-autoroll@skia.org Roll Skia from d221c1591d59 to 32a36614f879 (1 revision) (flutter/engine#52217 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-04-18 08:31:21 +00:00
engine-flutter-autoroll
22f49b276b
Roll Flutter Engine from 20638b75c8c4 to 132d364ef373 (1 revision) ( #146969 )
...
20638b75c8...132d364ef3skia-flutter-autoroll@skia.org Roll Dart SDK from 45dd87c2329c to 415669e2604d (1 revision) (flutter/engine#52216 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-04-18 06:49:26 +00:00
Loïc Sharma
86135b7774
[macOS] Migrate @NSApplicationMain attribute to @main ( #146848 )
...
This migrates Flutter to use the `@main` attribute introduced in Swift 5.3. The `@NSApplicationMain` attribute is deprecated and will be removed in Swift 6. See: https://github.com/apple/swift-evolution/blob/main/proposals/0383-deprecate-uiapplicationmain-and-nsapplicationmain.md
This change is split into two commits:
1. a508d3e503f43482786ehttps://github.com/flutter/flutter/pull/146707
Fixes https://github.com/flutter/flutter/issues/143044
2024-04-18 03:08:36 +00:00
engine-flutter-autoroll
e57e456652
Roll Flutter Engine from 07f7532ecd29 to 20638b75c8c4 (2 revisions) ( #146962 )
...
07f7532ecd...20638b75c8skia-flutter-autoroll@skia.org Roll Skia from a3a016537a8c to d221c1591d59 (2 revisions) (flutter/engine#52210 )
2024-04-17 flar@google.com DisplayList tracks maximum render op depths (flutter/engine#52070 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-04-18 02:08:26 +00:00
engine-flutter-autoroll
5fae912007
Roll Flutter Engine from 725ebd708246 to 07f7532ecd29 (1 revision) ( #146960 )
...
725ebd7082...07f7532ecdjonahwilliams@google.com [Impeller] Off by default experimental canvas. (flutter/engine#52035 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-04-18 01:24:25 +00:00
