Commit graph

11798 commits

Author SHA1 Message Date
Matteo Crippa 5907a7264d Fix/ios run simulator (#20262) 2018-09-05 09:03:08 -07:00
Danny Tuppeny 6e64cb0ad8
Fix windows crash running flutter run which tries to find Xcode (#21423)
* Add a failing test for #21418

* Filter workflows to only those applicable to the current platform

Fixes #21418.
2018-09-05 16:22:12 +01:00
tonyzhao1 58d98ce31e Create categories for doctor validators (#20758)
* First step in Flutter Doctor refactor. Assigns categories to all validators.

* Revert "Roll engine e54bc4ea1832..a84b210b3d26 (6 commits) (#20453)"

This reverts commit 05c2880a17.

* Split iOS and Android workflows into workflow and validator classes.

* Change ValidatorCategory to handle standalone validators that share a
category (e.g. IntelliJ).

Also make Android Studio and Android toolchain use separate categories.

At this stage, flutter doctor output matches what it was previously.
(The summary() method itself has not yet been changed )

* Change doctor summary code to support validator categories.

Output is still unchanged.

* Handle small formatting issues.

* Flip Flutter category's isGroup field to false until it's actually
needed.

* Revert auto-generated formatting changes to keep those lines from
muddying the pull.

* Small fixes pointed out by analyzer.

* Properly fix analyzer issues around const constructors.

* Small changes to address comments.

* Add tests to verify grouped validator behavior and validationtype
merging.

* Update doctor.dart

* Add comments for clarification.
2018-09-04 19:36:47 -07:00
Ian Hickson 88c94f57c7
Remove unnecessary consts (#21410) 2018-09-04 17:05:30 -07:00
Marcin Szałek 1658fd9412 Added size to stepper icons (#19313)
* Added size to stepper icons

* Added Stepper icons size test
2018-09-04 16:51:39 -07:00
Chris Bracken 2ab4ed748e
Eliminate Dart 1 support from DevFS (#21404)
Dart 1 is no longer supported in Flutter. Hot reload now always occurs
via kernel file updates (plus any asset bundle changes).
2018-09-04 16:47:57 -07:00
Will Larche 2ef7cd649c
[Icons] Updating default icon theme values. (#20840)
Closes #3188
2018-09-04 19:26:52 -04:00
Chris Bracken 70eefd1e9c
Eliminate Dart 1 support from FlutterDevice class (#21402) 2018-09-04 15:42:05 -07:00
Chris Bracken 63fde92adc
Eliminate Dart 1 support from Xcode xcconfig files (#21400) 2018-09-04 14:33:49 -07:00
Jonah Williams 3cd6f40a34
wire bold text flag to text widget (#21325) 2018-09-04 13:49:20 -07:00
Chris Bracken d04a057efd
Eliminate BuildInfo.previewDart2 (now always true) (#21392)
Dart 1 is no longer supported in Flutter.
2018-09-04 13:38:17 -07:00
Jonah Williams 5b5a5b8228
Revert "Enable taking screenshots of arbitrary RenderObjects from a running a… (#20637)" (#21395)
This reverts commit 3306fc1042.
2018-09-04 12:40:40 -07:00
Jacob Richman 3306fc1042
Enable taking screenshots of arbitrary RenderObjects from a running a… (#20637)
Enable taking screenshots of arbitrary RenderObjects from a running application from within the inspector.

Key functionality is in the added _ScreenshotPaintingContext class.
2018-09-04 10:50:04 -07:00
Chris Bracken ac8b906cb4
Eliminate support for Dart 1 in AOT snapshotter (#21388) 2018-09-04 10:17:12 -07:00
Chris Bracken ed0b8be041
Eliminate script snapshot support (#21387)
Script snapshots were only every used in Dart 1 mode, which is no longer
supported.
2018-09-04 10:05:26 -07:00
Hans Muller 343b57036a
InheritedModel - an InheritedWidget for data models (#19739)
Added InheritedModel:  An InheritedWidget that's intended to be used as the base class for models whose dependents may only depend on one part or "aspect" of the overall model.
2018-09-04 09:31:52 -07:00
Danny Tuppeny a74f591d0c
Change asset_bundle_package_font_test to memory file system (#21114)
* Change assert_bundle_package_font_test to memory file system

This is to work towards being able to run the tests without `-j1` (#21113). These tests were using the real filesystem and setting/relying on fs.currentDirectory. There was a comment about this being because the memory provider didnt' support POSIX and Windows, however that seems to have changed since (and many other asset tests already do something similar to this).

* Trim trailing whitespace

* Add a workaround for Windows path slash directions

Strictly this is correct, but the real FS can tolerate either path. The in-memory file system is more strict (see https://github.com/google/file.dart/issues/112).

* Extract a helper for writing schema files in tests

* Missed file when saving!

* Remove redundant comment

* Rename writeBasicSchema -> writeEmptySchema

* Use the file we already have to write contents

* Make comments more descriptive

* Remove another dupe of writeSchema to use the shared one

* Rename schema -> pubspec_schema

* Trim whitespace
2018-09-04 17:12:24 +01:00
Chris Bracken 041ff621a7
Eliminate --preview-dart-2 flag (#21304)
This patch eliminates the --preview-dart-2/--no-preview-dart-2 flag,
hardcoding all uses to true. It also defaults all previewDart2 method
parameters to true, where they hadn't yet been.

A series of subsequent patches will eliminate all previewDart2
parameters and the associated code from within the codebase.
2018-09-04 08:50:05 -07:00
Danny Tuppeny db7aa6a069
Unskip passing tests on Windows + add a new failing test with GH reference (#21351)
* Unskip integration tests on Windows that now pass

The referenced issue is closed and these tests pass for me locally on Windows now.

* Remove import that's no longer used

* Add another issue that is afffecting these tests on Windows

* Add a hot restart test and mark skip on Windows

Skipped due to https://github.com/flutter/flutter/issues/21348.
2018-09-04 16:24:10 +01:00
jensjoha cd65903f56
Initialize from dill on tests (#20414) 2018-09-04 11:17:10 +02:00
engine-flutter-autoroll 2369087668
Roll engine 77fad1a731f2..de4c7a53f21c (1 commits) (#21364)
77fad1a731...de4c7a53f2

git log 77fad1a731f2..de4c7a53f21c --no-merges --oneline
de4c7a53f Roll src/third_party/skia 09a7bb222172..88119de2b849 (1 commits) (flutter/engine#6146)


The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
2018-09-03 11:39:32 -04:00
engine-flutter-autoroll 84ee41686d
Roll engine 2318a5274af4..77fad1a731f2 (1 commits) (#21360)
2318a5274a...77fad1a731

git log 2318a5274af4..77fad1a731f2 --no-merges --oneline
77fad1a73 Roll src/third_party/skia 2f53025e8bf1..09a7bb222172 (1 commits) (flutter/engine#6144)


The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
2018-09-03 08:30:34 -04:00
engine-flutter-autoroll eb5a2857ca
Roll engine d88e0b8229ec..2318a5274af4 (1 commits) (#21345)
d88e0b8229...2318a5274a

git log d88e0b8229ec..2318a5274af4 --no-merges --oneline
2318a5274 Roll src/third_party/skia ca858b68c34b..2f53025e8bf1 (1 commits) (flutter/engine#6143)


The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
2018-09-02 23:18:32 -04:00
engine-flutter-autoroll 409fd05bf0
Roll engine 949fb0fb4cbe..d88e0b8229ec (1 commits) (#21342)
949fb0fb4c...d88e0b8229

git log 949fb0fb4cbe..d88e0b8229ec --no-merges --oneline
d88e0b822 Roll src/third_party/skia 2f8c60e28682..ca858b68c34b (2 commits) (flutter/engine#6142)


The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
2018-09-02 17:55:32 -04:00
engine-flutter-autoroll 6678efecba
Roll engine a4471589f2cd..949fb0fb4cbe (1 commits) (#21339)
a4471589f2...949fb0fb4c

git log a4471589f2cd..949fb0fb4cbe --no-merges --oneline
949fb0fb4 Roll src/third_party/skia 8534723c7be1..2f8c60e28682 (1 commits) (flutter/engine#6141)


The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
2018-09-02 14:30:34 -04:00
Viet Do 26b2909077
Cupertino Countdown Timer Picker doc fix (#21299) 2018-09-02 11:29:10 -07:00
engine-flutter-autoroll 3b21e34e04
Roll engine 017dafd42660..a4471589f2cd (8 commits) (#21337)
017dafd426...a4471589f2

git log 017dafd42660..a4471589f2cd --no-merges --oneline
a4471589f Roll src/third_party/skia e8e12e89c46b..8534723c7be1 (1 commits) (flutter/engine#6140)
db3484f27 Fix crash in text layout when GetMinikinFontCollectionForStyle returns null. (flutter/engine#6139)
0f7bfeaf4 Roll src/third_party/skia 6487e5ca6f10..e8e12e89c46b (1 commits) (flutter/engine#6138)
f25d89a2d Fix windows embedder builds. (flutter/engine#6137)
b3c778fe9 Allow embedders to specify software renderer configs. (flutter/engine#6133)
da419912d Roll src/third_party/skia 7bfe8438a94b..6487e5ca6f10 (6 commits) (flutter/engine#6136)
f44c0008b Roll src/third_party/skia 62db8d577931..7bfe8438a94b (20 commits) (flutter/engine#6134)
fbf672643 Mark deprecated Flutter iOS APIs as unavailable (flutter/engine#6124)


The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
2018-09-02 07:36:32 -04:00
xster 457e7b23df
Fix FixedExtentScrollController.animateToItem (#20618) 2018-09-01 04:06:46 -07:00
Amir Hardon 4aaa5dfe31
Don't reject the gesture after all pointers are up on AndroidView. (#21295)
This was a bug, when e.g a LongPressGestureRecognizer was in the gesture
arena, the android view gesture team may not yet win the arena when the
last pointer was up. This change allows AndroidView to win the gesture
even after all pointers are up.
2018-08-31 16:32:21 -07:00
Amir Hardon abb55cb649
fix wrong hashCode implementation in FakeMotionEvent (#21291) 2018-08-31 16:16:37 -07:00
Chris Bracken 4a0106658f
Migrate hot reload tests to Dart 2 (#21290) 2018-08-31 15:40:00 -07:00
Chris Bracken 4d0f09a2aa
Migrate Flutter Tester tests to Dart 2 (#21292) 2018-08-31 15:39:34 -07:00
liyuqian c1beb15f85
Use Visibility to hide gallery menu (#19121) 2018-08-31 14:46:19 -07:00
Chris Bracken a6af2ca643
Run resident_runner_test in Dart 2 mode (#21288) 2018-08-31 14:31:38 -07:00
engine-flutter-autoroll 1593b98166
Roll engine f612a761c2f0..017dafd42660 (2 commits) (#21287)
f612a761c2...017dafd426

git log f612a761c2f0..017dafd42660 --no-merges --oneline
017dafd42 Roll buildroot to 35959f6255c341eee550884ed69afd6b2891bd53 (unbreaks Windows) (flutter/engine#6132)
842546824 Roll buildroot to pick up new NDK r17b (flutter/engine#6131)


The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
2018-08-31 17:10:32 -04:00
Michael Goderbauer c1c4c41867
Roll engine to 017dafd4266005805167045739fa2ddec9bb7cad (1 commit, new NDK) (#21283) 2018-08-31 13:57:02 -07:00
Chris Bracken 251e82d211
Migrate devfs tests to Dart 2 (#21285)
DevFS.update only runs in Dart 2 mode when the generator parameter is
supplied. In Dart 2 mode, both mainPath and pathToReload are required
parameters; this patch marks them as such.

generator is required for running in Dart 2. All call sites other than tests already explicitly set this value.

Note the statements on line 510 and line 516 for why mainPath and pathToReload are required.
2018-08-31 13:31:56 -07:00
Chris Bracken 9d0084ff57
Restrict compilationQueue to library-visibility (#21280)
Its type uses a generic type which is limited to library-visibility.
Eliminating compilationQueue from ResidentCompiler's public interface
makes it possible to mock in tests.
2018-08-31 12:22:50 -07:00
engine-flutter-autoroll 80a58439ca
Roll engine 90faf8531c00..f612a761c2f0 (1 commits) (#21282)
90faf8531c...f612a761c2

git log 90faf8531c00..f612a761c2f0 --no-merges --oneline
f612a761c Roll src/third_party/skia 8ff2f13f3817..62db8d577931 (21 commits) (flutter/engine#6130)


The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
2018-08-31 15:11:32 -04:00
engine-flutter-autoroll 927a056a0a
Roll engine a114659c4a83..90faf8531c00 (1 commits) (#21274)
a114659c4a...90faf8531c

git log a114659c4a83..90faf8531c00 --no-merges --oneline
90faf8531 Roll src/third_party/skia f8592a69428e..8ff2f13f3817 (1 commits) (flutter/engine#6129)


The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
2018-08-31 09:59:32 -04:00
Mikkel Nygaard Ravn 6cc8008283
Fix extraction of product bundle ID for iOS projects (#21252) 2018-08-31 11:07:15 +02:00
engine-flutter-autoroll f999f1447a
Roll engine dc7b5eb89da3..a114659c4a83 (5 commits) (#21261)
dc7b5eb89d...a114659c4a

git log dc7b5eb89da3..a114659c4a83 --no-merges --oneline
a114659c4 Roll src/third_party/skia 381efe73499e..f8592a69428e (1 commits) (flutter/engine#6127)
21ac961df Roll src/third_party/skia 8e318fda76df..381efe73499e (11 commits) (flutter/engine#6126)
e7767ae9b Add license file patching instructions to README (flutter/engine#6125)
51d4be774 Add a `-[FlutterViewController splashScreenView]` property (flutter/engine#6112)
a047fd20f Roll src/third_party/skia 7ed0eae0cd13..8e318fda76df (17 commits) (flutter/engine#6123)


The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
2018-08-31 02:30:34 -04:00
liyuqian f7b2722d50
Add clipBehavior to Chips and update documents (#21231)
This fixes https://github.com/flutter/flutter/issues/20746
2018-08-30 23:27:37 -07:00
xster cda2c223f5
Turn on unawaited_futures in flutter_tools (#21048) 2018-08-30 20:57:44 -07:00
Jonah Williams f2442b8a13
Fix traversal order issues caused by intersecting or overlapping child rects (#21235) 2018-08-30 19:55:07 -07:00
Todd Volkert 2f32166f4b
Update packges (#21241)
https://github.com/flutter/flutter/issues/19578
2018-08-30 18:16:23 -07:00
Chris Bracken 9f9676c4c6
Eliminate Dart 1 support in devicelab tests (#21240)
Flutter commands all default to --preview-dart-2. Eliminate support for
the use of this option and the previewDart2 parameter in dev/devicelab
tests.
2018-08-30 17:17:37 -07:00
Alexander Aprelev eab5cd9853
Fix analysis shard of dev/bots/test.dart so it works on Windows. (#21203)
Normalize file path to non-Windows so string path comparison works.
2018-08-30 14:47:04 -07:00
Chris Bracken 6d7ecab25c
Minor improvements to analyzer test naming (#21234)
Clarify the intent of these tests.
2018-08-30 14:07:34 -07:00
engine-flutter-autoroll 5a5ebde3d3
Roll engine 252da4808277..dc7b5eb89da3 (5 commits) (#21233)
252da48082...dc7b5eb89d

git log 252da4808277..dc7b5eb89da3 --no-merges --oneline
dc7b5eb89 Use Skia normalize again after Skia precision fix. (flutter/engine#6121)
1c7682418 entering a character with a selection deletes the selection (flutter/engine#6113)
9fc355d2c Roll src/third_party/skia cd7907b57d76..7ed0eae0cd13 (1 commits) (flutter/engine#6120)
6586016da Roll src/third_party/skia f7c723c93d26..cd7907b57d76 (1 commits) (flutter/engine#6119)
1fa5fe6a0 Roll src/third_party/skia eb0bb732f43f..f7c723c93d26 (3 commits) (flutter/engine#6118)


The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
2018-08-30 16:19:32 -04:00