Commit graph

5454 commits

Author SHA1 Message Date
Jonah Williams 302e992ca7
[flutter_tools] throw a tool exit if pub cannot be run (#83293) 2021-05-24 14:34:02 -07:00
Jenn Magder 4bcf8fb40d
Migrate compile to null safety (#83153) 2021-05-24 11:24:02 -07:00
Jenn Magder 19eab105a5
Migrate build_system, exceptions, and source to null safety (#83147) 2021-05-24 10:29:04 -07:00
Michael Goderbauer ee17ebe51f
Use type:int without format in gen_l10n (#83132) 2021-05-24 09:54:02 -07:00
Dan Field a6b9c404f3
Remove dead code from attach.dart (#83187)
* Remove dead code from attach.dart

Remove dead code (see https://github.com/flutter/flutter/pull/30857/files#diff-70164e71957eed4bf8b4119543e779e808e3ddfedeceef98d4a24ab23efc99ecR214)
2021-05-23 10:02:26 -07:00
Jonah Williams 0f929f9f13
[flutter_tools] require cmdline-tools for android licenses (#82560) 2021-05-22 15:54:03 -07:00
Michael Goderbauer 485c409184
import pkg:intl when DateFormat or NumberFormat is used (#83122) 2021-05-21 19:04:04 -07:00
Jenn Magder 0d79013a81
Move globals.artifacts to globals_null_migrated, update imports (#83137) 2021-05-21 18:35:02 -07:00
Emmanuel Garcia 8a7f2dee51
Move AndroidX error handler to the end (#83135) 2021-05-21 18:29:03 -07:00
Michael Goderbauer f7bcfa8e95
Be more helpful when l10n generation fails (#83134) 2021-05-21 17:19:02 -07:00
Emmanuel Garcia fa5883b78e
Add Gradle lockfiles and tool to generate them (#83067) 2021-05-21 13:04:03 -07:00
Jonah Williams b891adb4bd
[flutter_tools] migrate artifacts to null safety (#83073) 2021-05-21 11:54:03 -07:00
nt4f04uNd 80a2b6b015
Fix typos (#82589) 2021-05-20 17:19:09 -07:00
Jonah Williams 24bfc46d89
[flutter_tools] allow passing properties directly to gradle (#82941) 2021-05-20 16:19:03 -07:00
Balvinder Singh Gambhir 4a33813b35
[flutter_tools] added base-href command in web (#80519) 2021-05-19 12:39:02 -07:00
Marian Triebe 2d283504e6
Add cold boot option to emulator launch command (#82647) 2021-05-19 10:54:04 -07:00
Hattomo (TomohiroHattori) 08a70e7ac8
Enable avoid_escaping_inner_quotes lint (#81153) 2021-05-19 09:54:02 -07:00
Jonah Williams 84734ecc54
[flutter_tools] pin shelf (#82869) 2021-05-18 23:09:03 -07:00
Jonah Williams 666675078c
[flutter_tools] adjust some feature settings (#82851) 2021-05-18 20:49:03 -07:00
Jenn Magder 8f536ec17b
Default --no-tree-shake-icons to false for 'flutter build bundle' (#82773) 2021-05-18 20:34:04 -07:00
Lau Ching Jun 2acd0007d6
Refactor CustomDimensions in analytics to be type safe (#82531) 2021-05-18 20:29:03 -07:00
Jay Zhuang f512ebfd06
[fuchsia_asset_builder] Write depfile (#82469) 2021-05-18 20:24:04 -07:00
Jonah Williams 5c09eecd0d
[flutter_tools] remove special casing of web listview requests (#82826) 2021-05-18 13:19:03 -07:00
Jonah Williams a3863b6592
[flutter_tools] support memory profiles from flutter drive (#82739) 2021-05-17 17:39:03 -07:00
Taha Tesser 0f03147138
remove unnecessary comment (#82650) 2021-05-17 11:59:02 -07:00
Chris Bracken e364e30c90
[tool] Prefer installing multi-arch Win32 binaries (#82668)
Depending on the user's build configuration, we may output
multi-architecture or single-architecture binaries. Prefer to install
the multi-architecture binary if built, otherwise fall back to the
single-architecture binary.
2021-05-16 19:40:00 -07:00
Chris Bracken 7c5857d3b0
[tool] Improve Windows install process (#82659)
This eliminates the use of the Install.ps1 script during Windows app
installation and instead uses uwptool install. Install.ps1 was the
slowest part of app install, and had resource contention issues that
frequently caused it to fail.
2021-05-16 17:21:18 -07:00
Chris Bracken 40bb2b293d
Add missed package version bump override (#82593)
In https://github.com/flutter/flutter/pull/82577, I landed a version
bump of package shelf and package flutter_template_images. This local
override should have been part of that patch but was missed in the
checkin.

The version bumps themselves happened in the previous patch; this just
ensures we don't accidentally 'upgrade' back to version 1.0.2.
2021-05-14 18:00:27 -07:00
Chris Bracken 90d978f8fb
Add windowsIdentifier template parameter (#82588)
Windows package identifiers are globally unique strings, typically a
GUID. These are required for templates that require a Windows package
name as described in
https://docs.microsoft.com/en-us/windows/win32/appxpkg/appx-portal

Fixes https://github.com/flutter/flutter/issues/82587
2021-05-14 17:48:30 -07:00
Jenn Magder ea21938ccc
Remove symroot from generated iOS Xcode build settings (#82576) 2021-05-14 17:09:04 -07:00
Jonah Williams 5d7b40190a
[flutter_tools] remove mocks from downgrade and devices test (#82579) 2021-05-14 16:28:39 -07:00
Taha Tesser 99472cf072
fix pkg typos (#82544) 2021-05-14 13:09:03 -07:00
Abhishek Ghaskata b554f893bd
Enable unnecessary_null_checks lint (#82084) 2021-05-14 10:44:03 -07:00
Gary Roumanis e3fd8dbfd5
Update loader style (#82485) 2021-05-13 22:59:03 -07:00
Taha Tesser 3c72ef374d
Fix Android Studio 4.2 detection on Windows (#82484) 2021-05-13 22:54:04 -07:00
Jonah Williams ed85dd49c7
[flutter_tools] use try to delete in web cache (#82478) 2021-05-13 21:44:02 -07:00
Jonah Williams 0f8a6ab4dd
[flutter_tools] make failures to unforward android port non-fatal (#82477) 2021-05-13 21:39:03 -07:00
Jenn Magder 8334fb0a1e
Tool exit on xcodebuild -list when Xcode project is corrupted (#82476) 2021-05-13 21:34:04 -07:00
Emmanuel Garcia 93c87e92b3
[flutter_tool] Suggest fix for transform input (#82309) 2021-05-13 21:24:04 -07:00
Chris Bracken 14546bfad1
Support uninstall, install status query for UWP (#82481)
Adds UwpTool.install and UwpTool.uninstall methods. Refactors the
PowerShell-based install code to move the powershell-related bits out of
the Device class and into UwpTool so that when we swap out the
PowerShell-based install for the uwptool-based install, it's transparent
to the WindowsUWPDevice class.

Adds implementations for:
* WindowsUWPDevice.isAppInstalled
* WindowsUWPDevice.uninstallApp

Refactors:
* WindowsUWPDevice.installApp
2021-05-13 16:15:09 -07:00
Jonah Williams 344f3ab7d9
[flutter_tools] swap web debugging protocol to ws (#82456) 2021-05-13 16:04:03 -07:00
Emmanuel Garcia 60633b609c
[flutter_tool] Suggest how to increase the Android minSdkVersion (#82372) 2021-05-13 11:59:04 -07:00
Kenzie Schmoll 766b4509c6
Add 'v' hotkey to open DevTools in the browser (#82227)
* Add 'v' hotkey to open DevTools in the browser
2021-05-13 09:54:10 -07:00
Chris Bracken 53c2f7086b
[flutter_tools] support flutter run -d winuwp (#82373)
Allow flutter run to work end-to-end with a UWP device.

Uses win32/ffi for the actual launch of the application, injected via
the native API class. This is structured to avoid a g3 dependency.

Install and amuid require powershell scripts for now.

Actually connecting to the observatory requires running a command in an
elevated prompt. Instructions are presented to the user if a terminal is
attached.

This is a rebased version of https://github.com/flutter/flutter/pull/79684
by @jonahwilliams, updated to remove `NativeApi` and replace is with calls
to `uwptool`.

Part of https://github.com/flutter/flutter/issues/82085
2021-05-12 20:45:30 -07:00
Alexandre Ardhuin c03e7488b4
remove noop primitive operations (#82297) 2021-05-12 00:04:02 -07:00
Shi-Hao Hong 633edb649f
[gen-l10n] Cleans up formatting of the generated file (#79517) 2021-05-11 17:19:05 -07:00
Renan 293756455c
Re-land: Allow users to pass in Xcode build settings as env variables to flutter build macos FLUTTER_XCODE_ (#82298) 2021-05-11 17:09:09 -07:00
Taha Tesser 0d50604a56
[reland] Adding vscode path installed via snap (#81989) 2021-05-11 17:04:03 -07:00
Jenn Magder c1c12aa365
Add posix permission chown suggestion to io error handling (#81942) 2021-05-11 14:54:02 -07:00
Dan Field 111c6ab136
Fix reuseApplication when ws URI does not end with / (#82066) 2021-05-10 16:29:03 -07:00
Michael Goderbauer b8a2456737
Enable library_private_types_in_public_api lint (#81578) 2021-05-10 16:26:16 -07:00
Anurag Roy 6e08ea0a2c
[flutter_tools] Show linux distribution and kernel release in flutter doctor (#81368) 2021-05-10 10:04:02 -07:00
Dan Field f82794c968
Fix missing logger (#82064) 2021-05-08 23:29:03 -07:00
Jenn Magder 783e1dd22c
Standardize build system environment defines derived from build info (#81879) 2021-05-07 17:04:02 -07:00
Emmanuel Garcia 094179e82d
Enable Dart plugin registrant on Desktop only (#81586) 2021-05-07 15:36:32 -07:00
Alexandre Ardhuin 9bca38c5e5
remove unnecessary String.toString() (#81859) 2021-05-07 14:54:02 -07:00
Zachary Anderson 04bb954a7d
Revert "Allow users to pass in Xcode build settings as env variables to flutter build macos FLUTTER_XCODE_ (#81384)" (#82004)
This reverts commit 0bba935b76.
2021-05-06 19:04:23 -07:00
Jenn Magder 3e6fe491f3
Remove extended attributes from entire Flutter project (#81435) 2021-05-06 16:34:04 -07:00
Renan 0bba935b76
Allow users to pass in Xcode build settings as env variables to flutter build macos FLUTTER_XCODE_ (#81384) 2021-05-06 16:29:04 -07:00
Dan Field 3ce6c1f4ba
[flutter drive] Do not start dds if --no-dds (#81784) 2021-05-03 15:15:10 -07:00
Ian Hickson 33b183e6c9
Fix extra blank lines in logger output (#81607) 2021-05-03 09:19:02 -07:00
Gary Roumanis 0cb0767bd7
Flutter Web Loading Indicator (#81581) 2021-04-30 21:04:02 -07:00
Michael Goderbauer 1edaec6c2c
Add additional logging when devtools cannot launch (#81554) 2021-04-30 17:54:02 -07:00
Jonah Williams 50ace38c32
[flutter_tools] make bundle-sksl-path a define (#81576) 2021-04-30 17:39:07 -07:00
Jonah Williams d4e48a1537
[flutter_tools] remove mocks from android emulator tests (#81548) 2021-04-30 17:39:03 -07:00
Jonah Williams 001323a275
[flutter_tools] remove timeout from iOS device startup (#81229) 2021-04-29 22:49:02 -07:00
Jonah Williams e3625706a8
[flutter_tools] remove mocks, globals from golden comparator and test runner tests | Reland
This reverts commit 027d4ecaba.
2021-04-29 22:40:59 -07:00
Hannes Winkler 82830fa1a0
[custom-devices] add screenshotting support (#80675) 2021-04-29 22:39:03 -07:00
Michael Goderbauer 027d4ecaba
Revert "[flutter_tools] remove mocks, globals from golden comparator and test runner tests (#81423)" (#81487)
This reverts commit 8fe4cc7964.
2021-04-29 10:56:57 -07:00
Jonah Williams 8fe4cc7964
[flutter_tools] remove mocks, globals from golden comparator and test runner tests (#81423) 2021-04-29 07:56:34 -07:00
Jason Simmons 93242d7548
Ignore the sort order of imports in generated_plugin_registrant.dart (#81437) 2021-04-28 19:19:05 -07:00
Jenn Magder ba4177f6da
Find Android Studio installations with Spotlight query on macOS (#80475) 2021-04-28 19:09:03 -07:00
Ian Hickson 0021a08c4d
Always activate DevTools if it's not installed (#81242) 2021-04-28 17:14:02 -07:00
Matej Knopp f6726b425d
Add support for DarwinArchs when assembling macOS App.framework (#81243) 2021-04-28 11:33:36 -07:00
Jonah Williams 2b0d09dd81
[versions] roll versions and add ffi dep (#81403) 2021-04-28 11:19:03 -07:00
Jenn Magder d2b0687558
Remove Finder extended attributes before code signing iOS frameworks (#81342) 2021-04-28 11:05:09 -07:00
Erick aecd5e0302
[flutter_tools] always build test assets (#81341) 2021-04-27 20:53:57 -07:00
Jenn Magder db3f49b1b4
Use cached Xcode build settings during iOS build (#80904) 2021-04-27 17:20:11 -07:00
Christopher Fujino ea1b5e3f68
allow flutterManifest to handle empty lists, add unit tests (#81324) 2021-04-27 16:04:03 -07:00
Ian Hickson 6beafa7b16
Apply style guide regarding createTempSync pattern (#81090) 2021-04-27 14:59:03 -07:00
Ian Hickson a7eb2c8a1a
Use "aliases" in args to fix some technical debt (#81073) 2021-04-27 14:54:03 -07:00
Jonah Williams 064eae8c38
[flutter_tools] remove mocks and fix fake imports (#81309) 2021-04-27 11:51:41 -07:00
Emmanuel Garcia 91d6c972cb
Fix bug when resolving entrypoint against package config (#81248) 2021-04-27 10:44:03 -07:00
xster ff2dde2c7f
Reland double gzip wrapping NOTICES to reduce on-disk installed space (#80897) 2021-04-26 22:35:45 -07:00
Jenn Magder 8d3bc1846f
Migrate analyze_size to null safety (#81002) 2021-04-26 16:46:14 -07:00
Jonah Williams 52661bc713
[flutter_tools] skip copying 1GB of data from chrome cache dirs (#81170)
* [flutter_tools] skip copying 1GB of data from chrome cache dirs

* Update chrome.dart
2021-04-26 13:02:42 -07:00
Sam Rawlins cd956c17d2
Remove "unnecessary" imports in flutter_tools (#81008) 2021-04-26 10:49:03 -07:00
Ian Hickson e5414695d4
Change --disable-dds to --no-dds to avoid double negatives (#80900)
Also, refactor internal code to do the same.

See https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo#avoid-double-negatives-in-apis
2021-04-23 16:29:38 -07:00
Emmanuel Garcia b0a63c4ffe
Reland the Dart plugin registry (#79669) 2021-04-23 15:34:04 -07:00
Jonah Williams 84bc2382f7
[flutter_tools] do not check for pubspec.yaml in packages forward command (#81059) 2021-04-23 13:39:20 -07:00
Ian Hickson 598737adf2
Clean up the command line tool interactive help output. (#80903) 2021-04-22 19:34:02 -07:00
Jonah Williams b30d97a64c
[flutter_tools] split host artifacts out of Artifacts (#80876) 2021-04-22 19:29:02 -07:00
Jonah Williams 82cfa25a64
[flutter_tools] fix asset directory paths for UWP (#80984) 2021-04-22 13:35:45 -07:00
Jonah Williams d8d8534362
[flutter_tools] remove usage of getIsolate in extension waiter (#80960) 2021-04-22 10:47:57 -07:00
Jonah Williams 8663aea5e4
[flutter_tools] run UWP builds ahead of cmake (#80879) 2021-04-22 10:14:37 -07:00
Jonah Williams e67f14e511
[flutter_tools] handle missing method on exit, debugDumpX (#80890) 2021-04-22 09:59:04 -07:00
Jonah Williams 14759dc5a4
Revert "[flutter_tools] pin transitive deps during --transitive-closure (#80911)" (#80959)
This reverts commit c2aa193c5f.
2021-04-22 09:39:39 -07:00
Jonah Williams c2aa193c5f
[flutter_tools] pin transitive deps during --transitive-closure (#80911) 2021-04-21 21:40:48 -07:00
Jenn Magder 18a118b952
Log full app bundle location after "flutter build ios" (#80838) 2021-04-21 21:39:03 -07:00
Jonah Williams 44c284baa2
[flutter_tools] output release artifacts to build/winuwp (#80137) 2021-04-21 18:39:04 -07:00