mirror of
https://github.com/flutter/flutter
synced 2024-08-27 20:10:11 +00:00
[flutter_tools] throw a tool exit if pub cannot be run (#83293)
This commit is contained in:
parent
5c3f5a7af3
commit
302e992ca7
|
@ -148,7 +148,8 @@ class _DefaultPub implements Pub {
|
|||
_processUtils = ProcessUtils(
|
||||
logger: logger,
|
||||
processManager: processManager,
|
||||
);
|
||||
),
|
||||
_processManager = processManager;
|
||||
|
||||
final FileSystem _fileSystem;
|
||||
final Logger _logger;
|
||||
|
@ -156,6 +157,7 @@ class _DefaultPub implements Pub {
|
|||
final Platform _platform;
|
||||
final BotDetector _botDetector;
|
||||
final Usage _usage;
|
||||
final ProcessManager _processManager;
|
||||
|
||||
@override
|
||||
Future<void> get({
|
||||
|
@ -391,11 +393,15 @@ class _DefaultPub implements Pub {
|
|||
'cache',
|
||||
'dart-sdk',
|
||||
'bin',
|
||||
if (_platform.isWindows)
|
||||
'pub.bat'
|
||||
else
|
||||
'pub'
|
||||
'pub',
|
||||
]);
|
||||
if (!_processManager.canRun(sdkPath)) {
|
||||
throwToolExit(
|
||||
'Your Flutter SDK download may be corrupt or missing permissions to run. '
|
||||
'Try re-downloading the Flutter SDK into a directory that has read/write '
|
||||
'permissions for the current user.'
|
||||
);
|
||||
}
|
||||
return <String>[sdkPath, ...arguments];
|
||||
}
|
||||
|
||||
|
|
|
@ -22,6 +22,31 @@ void main() {
|
|||
Cache.flutterRoot = '';
|
||||
});
|
||||
|
||||
testWithoutContext('Throws a tool exit if pub cannot be run', () async {
|
||||
final FakeProcessManager processManager = FakeProcessManager.empty();
|
||||
final BufferLogger logger = BufferLogger.test();
|
||||
final MemoryFileSystem fileSystem = MemoryFileSystem.test();
|
||||
processManager.excludedExecutables.add('bin/cache/dart-sdk/bin/pub');
|
||||
|
||||
fileSystem.file('pubspec.yaml').createSync();
|
||||
|
||||
final Pub pub = Pub(
|
||||
fileSystem: fileSystem,
|
||||
logger: logger,
|
||||
processManager: processManager,
|
||||
usage: TestUsage(),
|
||||
platform: FakePlatform(
|
||||
environment: const <String, String>{},
|
||||
),
|
||||
botDetector: const BotDetectorAlwaysNo(),
|
||||
);
|
||||
|
||||
await expectLater(() => pub.get(
|
||||
context: PubContext.pubGet,
|
||||
checkUpToDate: true,
|
||||
), throwsToolExit(message: 'Your Flutter SDK download may be corrupt or missing permissions to run'));
|
||||
});
|
||||
|
||||
testWithoutContext('checkUpToDate skips pub get if the package config is newer than the pubspec '
|
||||
'and the current framework version is the same as the last version', () async {
|
||||
final FakeProcessManager processManager = FakeProcessManager.empty();
|
||||
|
|
Loading…
Reference in a new issue