Greg Spencer
54236427dc
Fix flake in logger_test ( #22095 )
...
This fixes a flaky test where it included 0ms as part of an output check. Kind of a classic flaky test.
2018-09-20 14:45:24 -07:00
Kathy Walrath
72d86f904f
Fix a link ( #21888 )
...
Fix a link that works in GitHub but not in dartdoc.
2018-09-20 13:15:51 -07:00
Stanislav Baranov
c799c2fd80
Use "product" mode VM snapshot when running dynamic "release" mode flutter with cached engine. ( #22043 )
...
Dynamic "release" mode requires "product" (not "release") mode VM, so we must point it to the correct cached snapshot.
Generation and caching of this snapshot happens the following corresponding change: https://chromium-review.googlesource.com/c/chromium/tools/build/+/1232134
2018-09-20 13:12:38 -07:00
Alexander Aprelev
76468dd56a
Dart roll
2018-09-20 12:42:41 -07:00
Alexander Aprelev
6eea84cc34
Pre-dart roll
2018-09-20 12:42:41 -07:00
Alexander Aprelev
2fec45b17d
Amend the test following console output changes. ( #22093 )
...
This is the follow-up to https://github.com/flutter/flutter/pull/20958 .
2018-09-20 12:12:53 -07:00
tonyzhao1
8b5af14f24
Use grouped validator instead of categories ( #21577 )
...
This is a cleanup PR.
2018-09-19 15:42:51 -07:00
Michael Klimushyn
36b735eeb2
Fix WidgetApp.title documentation ( #22011 )
...
Closes #16031
2018-09-19 15:39:02 -07:00
Greg Spencer
7caa65943f
Added more extensive ANSI color printing support on terminals. ( #20958 )
...
This adds support to AnsiTerminal for colored output, and makes all tool output written to stderr (with the printError function) colored red.
No color codes are sent if the terminal doesn't support color (or isn't a terminal).
Also makes "progress" output print the elapsed time when not connected to a terminal, so that redirected output and terminal output match (redirected output doesn't print the spinner, however).
Addresses #17307
2018-09-19 15:22:43 -07:00
Jonah Williams
85b4670b2a
Revert "Implement Double Tap Handling in TextField and Editable" ( #22051 )
...
* Revert "Revert "Add RichText support to find.text" (#22046 )"
This reverts commit 8e70421913
.
* Revert "Implement Double Tap Handling in TextField and Editable (#21264 )"
This reverts commit 02e87334dd
.
2018-09-19 14:59:23 -07:00
Jonah Williams
8e70421913
Revert "Add RichText support to find.text" ( #22046 )
2018-09-19 13:51:35 -07:00
Niko Yuwono
02e87334dd
Implement Double Tap Handling in TextField and Editable ( #21264 )
...
Thanks @NikoYuwono for getting this working! We appreciate your help!
* Implement Double Tap Handling in TextField and Editable
* Fix test broken by the change and add test for double tap
* Fix affected tests
* Remove unnecessary new
* Fix test
2018-09-19 13:35:33 -07:00
Greg Spencer
9f0183eaaf
Turn on compute credits for all contributor builds ( #22000 )
2018-09-19 12:22:40 -07:00
Renan
74e93e4c5c
Make ScaleGestureRecognizer detect pointer rotation ( #17345 )
2018-09-19 11:48:41 -07:00
Jonah Williams
ff1f8dd143
Add RichText support to find.text ( #21964 )
2018-09-19 10:01:34 -07:00
Danny Tuppeny
7dd82813f2
Remove -j1 to run tools tests concurrently ( #22038 )
...
Fixes #21113 .
2018-09-19 17:47:06 +01:00
Danny Tuppeny
4108240a7c
Update devicelab test for rename of materialize -> make-host-app-editable ( #22034 )
...
This fixes the devicelab failure after #22006 renamed this command.
2018-09-19 16:12:01 +01:00
matthew-carroll
18d5b9dc45
Renamed 'flutter materialize' to 'flutter make-host-app-editable'. The iOS version is still incomplete and will therefore require additional renaming. ( #21771 ) ( #22006 )
2018-09-18 17:58:20 -07:00
sir-boformer
3c22d7b025
clarify how to display an image with a specific density ( #21152 )
...
Closes #18679
2018-09-18 16:29:52 -07:00
engine-flutter-autoroll
cc9b256f9f
Roll engine 9e315e64659e..2e8e96fad1ad (2 commits) ( #22005 )
...
9e315e6465...2e8e96fad1
git log 9e315e64659e..2e8e96fad1ad --no-merges --oneline
2e8e96fad Roll Dart to 4eb879133a06c86869dc54cecf904f4b1d46c47b (flutter/engine#6276 )
765b0cc23 Roll src/third_party/skia 060e992ef5b8..1d6281d4bb47 (34 commits) (flutter/engine#6274 )
The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
2018-09-18 18:25:32 -04:00
Jonah Williams
bf7c27095c
Make helper and error text separate widgets, make error and counter live region ( #21752 )
2018-09-18 13:39:21 -07:00
Chris Bracken
f8c50ea15f
Use Xcode legacy build system for iOS builds ( #21901 ) ( #21994 )
...
Xcode 10 introduces a new build system which includes stricter checks on
duplicate build outputs.
When plugins are in use, there are two competing build actions that copy
Flutter.framework into the build application Frameworks directory:
1. The Embed Frameworks build phase for the Runner project
2. The [CP] Embed Pods Frameworks build phase that pod install creates
in the project.
Item (1) is there to ensure the framework is copied into the built app
in the case where there are no plugins (and therefore no CocoaPods
integration in the Xcode project). Item (2) is there because Flutter's
podspec declares Flutter.framework as a vended_framework, and CocoaPods
automatically adds a copy step for each such vended_framework in the
transitive closure of CocoaPods dependencies.
As an immediate fix, we opt back into the build system used by Xcode 9
and earlier. Longer term, we need to update our templates and
flutter_tools to correctly handle this situation.
See: https://github.com/flutter/flutter/issues/20685
2018-09-18 10:05:46 -07:00
Danny Tuppeny
ff9dc22e44
Run logcat through shell ( #21977 )
...
This should fix #18889 which may be related to `adb logcat` not working correctly in non-terminals on some LG devices. See https://github.com/flutter/flutter/issues/18889#issuecomment-422217761 .
2018-09-18 17:57:31 +01:00
Jacob Richman
ccd070a5b4
Add back screenshot extension that was temporarily disabled. ( #21828 )
...
Add back screenshot extension that was temporarily disabled.
Add matchesReferenceImage matcher to test that the screenshot extension
generates equivalent images to InspectorService.instance.screenshot.
2018-09-18 09:32:39 -04:00
engine-flutter-autoroll
b01d3a2abc
Roll engine dcbc8a820733..9e315e64659e (3 commits) ( #21979 )
...
dcbc8a8207...9e315e6465
git log dcbc8a820733..9e315e64659e --no-merges --oneline
9e315e646 Remove entries from dart_vm_entry_points.txt and use annotations (flutter/engine#6226 )
cdbe21466 Update test .gitignore (flutter/engine#6272 )
dbfa8276d [fuchsia] Fixes for the Fuchsia build (flutter/engine#6273 )
The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
2018-09-18 06:12:32 -04:00
Alexandre Ardhuin
e2d0b062d9
remove unnecessary ignore prefer_const_constructors ( #21934 )
2018-09-18 05:54:03 +02:00
Alexander Markov
cffa67da68
Roll engine to dcbc8a820733f1e613ffdaad3cf1ab57d6337632
2018-09-17 19:12:00 -07:00
Alexander Markov
6ced74da9b
Roll engine to ba7752917f3081fd6b4e10d8ef6cecbdfe59a985
2018-09-17 19:12:00 -07:00
Chris Bracken
4c045e79fb
Revert "Use Xcode legacy build system for iOS builds ( #21901 )" ( #21966 )
...
This caused issues for projects without an Xcode workspace. Almost all
Flutter projects in the wild will have a workspace, but this patch needs
to add a check to catch any that lack one.
This reverts commit 021f472efc
.
2018-09-17 18:22:54 -07:00
Chris Bracken
021f472efc
Use Xcode legacy build system for iOS builds ( #21901 )
...
Xcode 10 introduces a new build system which includes stricter checks on
duplicate build outputs.
When plugins are in use, there are two competing build actions that copy
Flutter.framework into the build application Frameworks directory:
1. The Embed Frameworks build phase for the Runner project
2. The [CP] Embed Pods Frameworks build phase that pod install creates
in the project.
Item (1) is there to ensure the framework is copied into the built app
in the case where there are no plugins (and therefore no CocoaPods
integration in the Xcode project). Item (2) is there because Flutter's
podspec declares Flutter.framework as a vended_framework, and CocoaPods
automatically adds a copy step for each such vended_framework in the
transitive closure of CocoaPods dependencies.
As an immediate fix, we opt back into the build system used by Xcode 9
and earlier. Longer term, we need to update our templates and
flutter_tools to correctly handle this situation.
See: https://github.com/flutter/flutter/issues/20685
2018-09-17 17:54:57 -07:00
Ian Hickson
9f359aeee2
Remove all "flaky" annotations from devicelab ( #21895 )
...
These tests don't seem particularly more flaky than ony others any more.
2018-09-17 13:02:34 -07:00
engine-flutter-autoroll
c9d4593daa
Roll engine 1b2a2075a936..b0b19d6ce1d2 (1 commits) ( #21948 )
...
1b2a2075a9...b0b19d6ce1
git log 1b2a2075a936..b0b19d6ce1d2 --no-merges --oneline
b0b19d6ce Fix the frontend_server test (flutter/engine#6261 )
The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
2018-09-17 14:37:33 -04:00
engine-flutter-autoroll
6f15e7a62e
Roll engine 72665c6827a5..1b2a2075a936 (2 commits) ( #21946 )
...
72665c6827...1b2a2075a9
git log 72665c6827a5..1b2a2075a936 --no-merges --oneline
1b2a2075a Update engine tests for Dart 2 compilation and language changes (flutter/engine#6262 )
83b0e299a Roll src/third_party/skia 098c1355bf70..060e992ef5b8 (1 commits) (flutter/engine#6269 )
The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
2018-09-17 13:46:33 -04:00
Jason Simmons
6f435b286e
Stop the animation controller if a CircularProgressIndicator is determinate ( #21832 )
...
Fixes https://github.com/flutter/flutter/issues/21445
2018-09-17 10:08:27 -07:00
engine-flutter-autoroll
2bca8007bd
Roll engine b43b3e87022b..72665c6827a5 (4 commits) ( #21916 )
...
b43b3e8702...72665c6827
git log b43b3e87022b..72665c6827a5 --no-merges --oneline
72665c682 Roll src/third_party/skia 840debe9c748..098c1355bf70 (1 commits) (flutter/engine#6268 )
d212e84b7 Roll src/third_party/skia 8e73f4b6bbef..840debe9c748 (1 commits) (flutter/engine#6267 )
aaef8ebdf Roll src/third_party/skia afebe1614e5e..8e73f4b6bbef (1 commits) (flutter/engine#6265 )
45696e72f Roll src/third_party/skia 7b617a7fc85d..afebe1614e5e (8 commits) (flutter/engine#6258 )
The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
2018-09-16 12:30:34 -04:00
engine-flutter-autoroll
3e95d0c1c6
Roll engine 24d94601b906..b43b3e87022b (3 commits) ( #21894 )
...
24d94601b9...b43b3e8702
git log 24d94601b906..b43b3e87022b --no-merges --oneline
b43b3e870 Remove LayerBuilder and DefaultLayerBuilder (flutter/engine#6256 )
e817f2d98 Roll src/third_party/skia 7724d3f4949b..7b617a7fc85d (6 commits) (flutter/engine#6255 )
a0dff815e Update test and license scripts for Dart SDK 2.1.0 (flutter/engine#6254 )
The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
2018-09-16 08:35:54 -07:00
liyuqian
1ad538e454
Fix the @macro link in doc ( #21890 )
...
Is it possible to add a unit test to make sure that all links in our
Dart doc are valid?
2018-09-14 16:47:28 -07:00
liyuqian
872eba2d4c
Track 90th, 99th percentile instead of missed_frame_build_budget_count ( #21754 )
...
See https://github.com/flutter/flutter/pull/19121#issuecomment-419520765
2018-09-14 13:24:13 -07:00
Régis Crelier
8b8aeeff34
24d9460 Roll Dart to bb56d4592f7cde38cdf0a04ad7f40d105af99d11 ( #21883 )
2018-09-14 13:10:05 -07:00
Alexandre Ardhuin
a07d3719a1
enable lint prefer_generic_function_type_aliases ( #21680 )
2018-09-14 21:06:19 +02:00
engine-flutter-autoroll
6c3adcf60f
Roll engine 7a9b430d740b..60bb5da33c72 (2 commits) ( #21880 )
...
7a9b430d74...60bb5da33c
git log 7a9b430d740b..60bb5da33c72 --no-merges --oneline
60bb5da33 Reapply "Some cleanups enabled by removing support for Dart 1" (flutter/engine#6250 )
272be27f7 update live region to trigger on label change, remove manual trigger (flutter/engine#6248 )
The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
2018-09-14 14:06:32 -04:00
engine-flutter-autoroll
7f7a731da0
Roll engine ade2d1d04cca..7a9b430d740b (1 commits) ( #21878 )
...
ade2d1d04c...7a9b430d74
git log ade2d1d04cca..7a9b430d740b --no-merges --oneline
7a9b430d7 Roll src/third_party/skia 66261f1ac2b7..7724d3f4949b (3 commits) (flutter/engine#6252 )
The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
2018-09-14 13:11:32 -04:00
engine-flutter-autoroll
b5afdca20e
Roll engine f3ef31aa8c2c..ade2d1d04cca (1 commits) ( #21877 )
...
f3ef31aa8c...ade2d1d04c
git log f3ef31aa8c2c..ade2d1d04cca --no-merges --oneline
ade2d1d04 Roll src/third_party/skia 637c06aec7b1..66261f1ac2b7 (29 commits) (flutter/engine#6251 )
The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
2018-09-14 10:04:32 -04:00
engine-flutter-autoroll
b9eb4ecbd1
Roll engine 931d3cbbc250..f3ef31aa8c2c (1 commits) ( #21875 )
...
931d3cbbc2...f3ef31aa8c
git log 931d3cbbc250..f3ef31aa8c2c --no-merges --oneline
f3ef31aa8 Roll src/third_party/skia 46a5f6c28a34..637c06aec7b1 (1 commits) (flutter/engine#6246 )
The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
2018-09-14 09:18:32 -04:00
Michael Goderbauer
dda7382e49
Fix the the ( #21732 )
2018-09-14 12:42:20 +02:00
asiva
8b81449d4b
Roll engine version to 931d3cbbc250dbeec1c485f6bee869a15080ac0e
...
931d3cbbc Roll Dart to version c28db2d6e17f046f95db5987394df43c95d58468
2018-09-13 20:43:30 -07:00
asiva
6b87adb059
Roll engine to version abd918eb618bfcc9a1a07513f88dfc066ea4aa3c
...
abd918eb6 (upstream/master) Add scrollIndex and scrollChildren to semantics, add Android implementation (#6239 )
23fcc2771 Prepare for stripping and dsyming Flutter.framework (#6247 )
2018-09-13 20:43:30 -07:00
Mehmet Fidanboylu
2895d71b79
Make Flutter repo Dart SDK 2.1-dev3.1 compatible ( #21853 )
...
This is a blocker for Google roll since we are not at dev4.0:
- Future is not yet part of dart:core.
- Future.sync().then<dynamic>... causes failure without the new keyword.
2018-09-13 18:50:21 -07:00
liyuqian
069cddaa67
Missing default hardEdge clip for ClipRectLayer ( #21826 )
...
In my local tests, this should finally fix https://github.com/flutter/flutter/issues/21617
2018-09-13 11:42:49 -07:00
Jonah Williams
9bf8502fef
Add debug check for localization parent ( #20787 )
2018-09-13 10:47:31 -07:00