Jonah Williams
4d3b51e284
Allow flutter web to be compiled with flutter ( #32360 )
2019-05-09 08:57:26 -07:00
stuartmorgan
e8c5c98132
Fix assignment in macos_build_flutter_assets.sh ( #32406 )
...
Bash assignment doesn't have spaces around '='.
Fixes #32341
2019-05-09 10:16:30 -04:00
Phil Quitslund
d96c1c88b7
make immutables const ( #32340 )
...
* make immutables const
2019-05-09 05:47:01 -07:00
Michael Goderbauer
1621baafc7
Introduce separate HitTestResults for Box and Sliver ( #31894 )
2019-05-09 10:00:01 +02:00
Michael Goderbauer
ff1dbcdeb6
Add geometry getters to Flutter Driver ( #32302 )
2019-05-09 09:50:02 +02:00
engine-flutter-autoroll
8b114482a4
Roll engine 026df8e46cde..3ef5007d90cf (2 commits) ( #32355 )
...
026df8e46c...3ef5007d90flutter/engine#8889 )
e7e6689b7 Expose API to decode images to specified dimensions (flutter/engine#8596 )
The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff (chinmaygarde@google.com ), and stop
the roller if necessary.
2019-05-08 21:05:39 -04:00
Greg Spencer
aeccd6a8bc
Fix nested listeners so that ancestor listeners can also receive enter/exit/move events. ( #32350 )
...
This changes Listener to trigger enter/move/exit in all Listeners below the pointer, not just the leaf region (the first region hit). This is because we need to allow listeners to be nested so that, say, a widget that handles changing color on hover, but also is wrapped in a Tooltip (that handles hover) can trigger both actions, not just one.
To that end, I added a findAll to Layer, similar to the existing find method that was previously used. It returns an iterator over annotated layers which match the given data type.
Since the findAll is implemented as returning an Iterable (and is sync*), I re-implemented the find routines as just returning the first result from findAll, since that should be just as efficient, and would then prevent duplication in the implementation.
2019-05-08 17:57:42 -07:00
engine-flutter-autoroll
e0943c4268
026df8e46 Roll src/third_party/dart f80f0bfcfd..f7bf890ff7 (2 commits) ( #32343 )
...
0a2d18da95...026df8e46chttps://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff (chinmaygarde@google.com ), and stop
the roller if necessary.
2019-05-08 20:13:39 -04:00
Greg Spencer
23baae0e45
Fix RenderPointerListener so that callbacks aren't called at the wrong time. ( #32142 )
...
I recently added some code to keep hover events from being propagated when a mouse wasn't attached. While that works, there are times when it can fire callbacks during the building of other components, since they can now be called from detach/attach. This is not ideal, since it will assert then. This changes the code so that it won't update the annotations during attach/detach, but also won't push the annotation layer unless a mouse is connected, achieving the same result as before, but with better semantics.
The basic problem is that in the detach for RenderPointerListener, it would detach the annotation, which could cause onExit to be called on the annotation, since the widget was disappearing under the mouse, and thus needs to receive an onExit, but that onExit might be (and probably will be) calling setState, which marks the owning widget as needing to be built, sometimes when it already has been.
The fix creates a new _ListenerElement that overrides activate and deactivate in order to tell the render object ahead of the detach that it might be detached, and so the onExit gets called before the detach instead of during it.
In addition, I now avoid scheduling more than one check for mouse positions per frame.
2019-05-08 12:20:31 -07:00
engine-flutter-autoroll
41d26b96e3
0a2d18da9 Roll src/third_party/dart 0e2e186262..f80f0bfcfd (4 commits) ( #32331 )
...
892b505d0a...0a2d18da95https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff (chinmaygarde@google.com ), and stop
the roller if necessary.
2019-05-08 14:08:39 -04:00
engine-flutter-autoroll
b1835cf0b7
892b505d0 Provide a resource context in the GLFW shell (flutter/engine#8895) ( #32322 )
...
edff0aa18a...892b505d0aflutter/engine#8895 )
The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff (chinmaygarde@google.com ), and stop
the roller if necessary.
2019-05-08 12:26:40 -04:00
engine-flutter-autoroll
ce4bdd217f
edff0aa18 Roll src/third_party/dart 8143450941..0e2e186262 (3 commits) ( #32318 )
...
1604a413ad...edff0aa18ahttps://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff (chinmaygarde@google.com ), and stop
the roller if necessary.
2019-05-08 11:09:39 -04:00
engine-flutter-autoroll
d6c4e36693
Roll engine ac4f3c9945ee..1604a413add7 (3 commits) ( #32316 )
...
ac4f3c9945...1604a413adflutter/engine#8900 )
3fccf83ec Roll src/third_party/skia 4497ac179949..f90bfd72174b (2 commits) (flutter/engine#8897 )
5d1c1a027 Remove more asserts and fix a11y check (flutter/engine#8896 )
The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff (chinmaygarde@google.com ), and stop
the roller if necessary.
2019-05-08 10:12:40 -04:00
engine-flutter-autoroll
45d2b15d97
ac4f3c994 Prevent iOS from autofilling password into wrong text box (flutter/engine#8894) ( #32297 )
...
436a3c70a9...ac4f3c9945flutter/engine#8894 )
The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff (chinmaygarde@google.com ), and stop
the roller if necessary.
2019-05-08 05:29:39 -04:00
engine-flutter-autoroll
91aa36b7bd
436a3c70a Roll src/third_party/skia 51e15a69ce5b..4497ac179949 (1 commits) (flutter/engine#8893) ( #32287 )
...
0fc6efb0d5...436a3c70a9flutter/engine#8893 )
The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff (chinmaygarde@google.com ), and stop
the roller if necessary.
2019-05-08 03:03:39 -04:00
Matthew Lloyd
969c6ef1dc
Add reference to Runner-Bridging-Header.h to iOS template's profile configuration ( #32266 )
2019-05-07 23:59:01 -07:00
engine-flutter-autoroll
13985db2d2
Roll engine 149b7b8981bf..0fc6efb0d5de (7 commits) ( #32284 )
...
149b7b8981...0fc6efb0d5flutter/engine#8888 )
0b406c3de Copy the Flutter Runner from //topaz into the engine. (flutter/engine#8886 )
2b1f9925e new lints (flutter/engine#8849 )
0c7a3f25f Copy //dart-pkg/zircon|fuchsia from Topaz into the engine. (flutter/engine#8884 )
ba82ea2af Roll src/third_party/skia 056944747072..51e15a69ce5b (8 commits) (flutter/engine#8885 )
d71704488 Copy //runtime/dart/utils from Topaz into the engine. (flutter/engine#8871 )
The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff (chinmaygarde@google.com ), and stop
the roller if necessary.
2019-05-08 02:13:39 -04:00
engine-flutter-autoroll
fbe11671a4
149b7b898 Roll src/third_party/dart 3173e594ba..a8b6e18b62 (16 commits) (flutter/engine#8883) ( #32260 )
...
df79d63a73...149b7b8981flutter/engine#8883 )
The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff (chinmaygarde@google.com ), and stop
the roller if necessary.
2019-05-07 18:13:39 -04:00
chunhtai
21efdff8a5
fix issue 32212 Text field keyboard selection crashes ( #32256 )
2019-05-07 15:07:11 -07:00
engine-flutter-autoroll
c27d10bf46
Roll engine 0e500daac83b..df79d63a7387 (20 commits) ( #32253 )
...
0e500daac8...df79d63a73#8869
444925f13 Roll src/third_party/dart cdabea8fe2..36c315eacc (17 commits)
3f9de1abb Roll src/third_party/skia 77af4ecd3546..5f2807b71e71 (3 commits) (flutter/engine#8866 )
10cbdd49d Add resize functions to GLFW shell (flutter/engine#8864 )
62ab9c7b8 Provide access to GLFW window in plugins (flutter/engine#8806 )
4d830d2c9 Roll src/third_party/skia 7d2ad0fdef01..77af4ecd3546 (9 commits) (flutter/engine#8862 )
3671182a9 Get prebuilt Dart via CIPD (flutter/engine#8859 )
07bb4f9cd Roll src/third_party/dart 125c5cbf4a..cdabea8fe2 (4 commits)
7bcb665e7 Roll src/third_party/dart 67df3ff878..125c5cbf4a (6 commits) (flutter/engine#8856 )
94b40540b Roll src/third_party/skia 2f3637bf2ed4..7d2ad0fdef01 (1 commits) (flutter/engine#8857 )
2c2f060b7 Roll src/third_party/skia 719a69ca5a6d..2f3637bf2ed4 (2 commits) (flutter/engine#8855 )
The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff (chinmaygarde@google.com ), and stop
the roller if necessary.
2019-05-07 17:21:39 -04:00
engine-flutter-autoroll
186b619110
Roll engine ee6412a74d36..0e500daac83b (3 commits) ( #32133 )
...
* e40cc1a03 Roll src/third_party/dart dbe80f3397..e0e5c85f48 (8 commits)
* 4101fa8bd Roll src/third_party/dart e0e5c85f48..e5575ba64a (5 commits)
* 0e500daac Roll src/third_party/dart e5575ba64a..67df3ff878 (3 commits)
2019-05-07 11:54:46 -07:00
xster
aa450d5660
Cupertino localization step 9: add tests ( #29954 )
2019-05-07 11:47:59 -07:00
Jonah Williams
eb996afaa8
make hotfix use a plus instead of minus ( #32060 )
2019-05-07 10:11:00 -07:00
Shi-Hao Hong
2f1e7cf662
Added state management docs/sample to SwitchListTile ( #32147 )
...
* Added documentation to SwitchListTile
2019-05-07 08:33:22 -07:00
Ian Hickson
f5674d7098
Performance issue template ( #31944 )
2019-05-06 18:32:28 -07:00
Ian Hickson
f61a2c3907
Clean up flutter_test/test/controller_test.dart ( #31333 )
...
Instead of using a custom WidgetController, which is very brittle, we just use the usual infrastructure.
Also, use structured data instead of an array.
This adds offsetMoreOrLessEquals to handle small floating point errors in offsets.
2019-05-06 14:36:30 -07:00
Ian Hickson
b770cdf267
Revert "Add shape property to SliverAppBar ( #31662 )" ( #32155 )
...
This reverts commit 28b58db1f2
2019-05-06 12:02:02 -07:00
Michael Klimushyn
fecba55888
Remove deprecated decodedCacheRatioCap ( #32041 )
2019-05-06 11:19:35 -07:00
yaheng
57d6666462
Fix text selection toolbar appearing under obstructions ( #29809 )
2019-05-06 11:18:09 -07:00
Emmanuel Garcia
cc7ec6d624
Bump multicast_dns version
2019-05-06 11:14:41 -07:00
Tiziano Munegato
28b58db1f2
Add shape property to SliverAppBar ( #31662 )
2019-05-06 10:34:37 -07:00
Darren Austin
017997b9c1
Increase size of touch regions in the Time Picker header ( #32053 )
...
- Increased the AM/PM, minute and hour buttons to at least 48x48
- Added InkWells to all of them
- Adjusted the landscape layout for the AM/PM buttons to be horizontal
- Added a test to ensure the regions are at least 48x48
2019-05-06 10:27:16 -07:00
Darren Austin
2d2edbf70b
Date picker layout exceptions ( #31514 )
...
Fixed several layout issues with the material date picker. Mostly just removed hard coded sizes to allow the grid view to scroll instead of overflowing.
2019-05-06 10:26:26 -07:00
Zachary Anderson
61236c873e
[flutter_tool] In 'attach' use platform dill and patched sdk dir from the Fuchsia SDK ( #32071 )
2019-05-06 09:26:58 -07:00
Jonah Williams
dd5d0d6c36
rename foreground and background to light and dark ( #32070 )
2019-05-06 08:02:08 -07:00
Jonah Williams
99e7b0a0ff
dont NPE with empty pubspec ( #32072 )
2019-05-06 08:01:45 -07:00
Antti Ahti
526113db32
Fix tab indentation ( #31798 )
...
Code indentation was done with tabs in some places. Replaced with spaces.
2019-05-06 14:09:54 +02:00
Michael Goderbauer
cc239580d3
Make Hover Listener respect transforms ( #32025 )
2019-05-06 13:36:13 +02:00
Michael Goderbauer
ea03ac2b84
Revert "Sliver animated list ( #28834 )" ( #32135 )
...
This reverts commit d2de911d50
2019-05-06 11:53:32 +02:00
Simon Binder
d2de911d50
Sliver animated list ( #28834 )
2019-05-06 11:26:38 +02:00
engine-flutter-autoroll
538a1c6618
Roll engine 1d062db4db11..ee6412a74d36 (4 commits) ( #32129 )
...
1d062db4db...ee6412a74dflutter/engine#8853 )
9fc786c9a Roll src/third_party/skia ac55784e3363..3fd1841161d1 (1 commits) (flutter/engine#8852 )
09fae0827 fix assert (flutter/engine#8851 )
bf89afdf6 Add asserts to semantics.dart (flutter/engine#8846 )
The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff (amirha@google.com ), and stop
the roller if necessary.
2019-05-06 02:38:39 -04:00
LongCatIsLooong
8800153468
Fix CupertinoSliverRefreshControl onRefresh callback ( #32086 )
...
Replace CupertinoSliverRefreshControl.onRefresh's then callback with whenCompleted callback, so when onRefresh completes with error the sliver refresh control retracts like when it completes with value.
2019-05-04 15:54:44 -07:00
Shi-Hao Hong
2f75005a16
Fix Exception on Nested TabBarView disposal ( #31581 )
...
* Add Flag to determine if pixels is set by viewport during disposal
* Add TODO to remove nested TabBarView workaround once unnecessary build/dispose issues are resolved
2019-05-04 09:14:49 -07:00
done
d53115ab2e
fix FlutterDriver timeout ( #31824 )
2019-05-04 06:13:25 -07:00
engine-flutter-autoroll
c731e3e670
1d062db4d remove unecessary usage of runtimeType in dart:ui (flutter/engine#8844) ( #32084 )
...
72bafad41d...1d062db4dbflutter/engine#8844 )
The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff (amirha@google.com ), and stop
the roller if necessary.
2019-05-04 04:59:39 -04:00
engine-flutter-autoroll
6a3f6cc178
72bafad41 Roll src/third_party/skia feae867f8425..ac55784e3363 (1 commits) (flutter/engine#8847) ( #32081 )
...
e518dd2aad...72bafad41dflutter/engine#8847 )
The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff (amirha@google.com ), and stop
the roller if necessary.
2019-05-04 03:16:41 -04:00
engine-flutter-autoroll
fcab9de545
e518dd2aa Roll src/third_party/skia 8ac78aa6df3f..feae867f8425 (1 commits) (flutter/engine#8845) ( #32078 )
...
f82ea26494...e518dd2aadflutter/engine#8845 )
The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff (amirha@google.com ), and stop
the roller if necessary.
2019-05-03 23:29:38 -04:00
engine-flutter-autoroll
bdcd084c7d
f82ea2649 Update buildroot, libjpeg-turbo and googletest to pull in Fuchsia SDK patches. (flutter/engine#8841) ( #32077 )
...
88e82d371a...f82ea26494flutter/engine#8841 )
The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff (amirha@google.com ), and stop
the roller if necessary.
2019-05-03 22:26:38 -04:00
engine-flutter-autoroll
54e424f714
88e82d371 Remove static leaks (flutter/engine#8825) ( #32076 )
...
33cf682f18...88e82d371aflutter/engine#8825 )
The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff (amirha@google.com ), and stop
the roller if necessary.
2019-05-03 21:31:41 -04:00
engine-flutter-autoroll
bd0c1dc370
33cf682f1 Roll src/third_party/skia 70aab823547a..8ac78aa6df3f (5 commits) (flutter/engine#8838) ( #32075 )
...
2c9e37c34e...33cf682f18flutter/engine#8838 )
The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff (amirha@google.com ), and stop
the roller if necessary.
2019-05-03 20:36:38 -04:00
