Commit graph

8781 commits

Author SHA1 Message Date
Danny Tuppeny 3ea4b44374
Increase timeout waiting for app to start (#22504)
https://github.com/flutter/flutter/issues/22338#issuecomment-425794734 shows almost 1 minute being spent on the `Resolving Dependencies` step alone. Possibly this needs to go higher still, but this should be a good start.
2018-10-05 17:02:08 +01:00
tonyzhao1 b04447d51c Split Android license checks into their own subvalidator (#22446) 2018-10-05 08:45:16 -07:00
Alexandre Ardhuin 2d3ff10d62
apply lint prefer_void_to_null in packages/flutter_tools (#22686) 2018-10-05 07:54:56 +02:00
Alexandre Ardhuin c26b56cba3
apply lint prefer_void_to_null in packages/fuchsia_remote_debug_protocol (#22690) 2018-10-05 06:48:20 +02:00
Greg Spencer 40a7a9cfc3
Fixes a common crash in getAdbDevices when adb executable isn't found. (#22676)
Apparently, this accounts for 13% of our crashes in Beta.
2018-10-04 15:57:15 -07:00
Greg Spencer 9f23866a0a
Rename module --> application in flutter create command. (#22565)
This renames the "module" template to the "application" template, and makes "application" the default. The existing "app" template is now deprecated.

flutter create also now recognizes the type of project in an existing directory, and is able to recreate it without having the template type explicitly specified (although you can still do that). It does this now by first looking in the .metadata file for the new project_type field, and if it doesn't find that, then it looks at the directory structure. Also, the .metadata file is now overwritten even on an existing directory so that 1) the project_type can be added to legacy projects, and 2) the version of Flutter that updated the project last is updated.

I also cleaned up a bunch of things in create_test.dart, added many more tests, and added an example test to the test/ directory in the generated output of the application template.

Fixes #22530
Fixes #22344
2018-10-04 13:03:20 -07:00
Gary Qian 00bcffd108
Roll engine and update tests (#22643)
git log 7e3b41dc7ba6..74e68ff8b108 --no-merges --oneline
74e68ff8b Roll src/third_party/skia 7b7805581733..66a973493468 (4 commits) (#6436)
58fbd1fd1 Roll src/third_party/skia 4442e3138927..7b7805581733 (1 commits) (#6435)
83151d9fc Roll src/third_party/skia 4dd17156c6e4..4442e3138927 (1 commits) (#6434)
5fe7e377d Roll src/third_party/skia 8841085abeb9..4dd17156c6e4 (1 commits) (#6432)
5340f4224 Revert "Use single_root_scheme when compiling platform (#6402)" (#6431)
37fd43d43 Add deadline_now_delta argument to Engine::NotifyIdle's trace (#6419)
4af077b29 Roll src/third_party/skia 4504a652c071..8841085abeb9 (1 commits) (#6429)
165f3dd1c Update //third_party/benchmark dependency to 21f1eb (ToT). (#6427)
34bd0ef87 Don’t build benchmarking binaries on Windows. (#6428)
ae4db4469 Ensure setViewIdResourceName has the correct version guard (#6404)
2c5d0c407 [rapidjson] Fix import statements (#6418)
c2128fc80 Create a benchmarking target for the shell. (#6420)
30f78af91 Raise errors on non-zero exits while creating artifacts on the bots. (#6424)
191168cec Disable line_height tests on Windows (#6423)
061cc6643 Fix ideographic baseline to match spec. (#6422)
74eac1f56 Roll src/third_party/skia bfa76f20bfcf..4504a652c071 (14 commits) (#6421)
10b45405b Implement ParagraphStyle.line_height and add tests for line_height and baselines. (#6417)
2018-10-04 10:57:30 -07:00
jslavitz 64029ba6ea
Vertical divider (#22641)
* Vertical divider bug fix and additional cleaning.
2018-10-04 10:29:32 -07:00
Philip 4a13be4151 Added sample code for scaffold widget [#21136] (#21613)
* added sample code for scaffold widget [#21136]

* Fixed indent and spacing for scaffold sample code

* Update scaffold.dart

Fix one more formatting issue
2018-10-04 10:21:05 -07:00
Jason Simmons e031613a2a
Use "gradle tasks --all" to query build variants (#21761)
Previously flutter_tools had used "gradle properties" to find the build types
and flavors supported by the Gradle project.  Tasks should work more reliably
across different versions of the Android Gradle plugin.

Fixes https://github.com/flutter/flutter/issues/20781
2018-10-04 10:06:31 -07:00
Alexandre Ardhuin 2ea1d81cdc
sort_constructors_first (#22575) 2018-10-04 07:28:07 +02:00
Jonah Williams 3e0cefb80e
Fix build by removing new (#22634) 2018-10-03 14:34:50 -07:00
Philip d0c9560856 Make RotationTransition widget alignment configurable (#22535) 2018-10-03 14:20:05 -07:00
Michael Goderbauer 07fc9f6442
Fix mkdir call to not fail if dir exists (#22622) 2018-10-03 14:12:54 -07:00
jslavitz f44b277fa6
Custom offset functionality for Popup Menu Button (#22534)
* Adds offset functionality to popup menu
* Adds a test
2018-10-03 11:19:19 -07:00
Hans Muller aa6a27e8a2
Updated the ColorScheme dartdoc: a11y (#22618) 2018-10-03 11:15:28 -07:00
Hans Muller 3a87b93fce
Added support for the Khmer (km) language (#22617) 2018-10-03 11:14:56 -07:00
Gary Qian 37c10acb97
Use 'Future<void>' insted of 'Future<Null>' in SystemChrome (#22583) 2018-10-03 11:14:09 -07:00
jslavitz 8d76d37f33
Choice Chip Fix (#22589)
* choice chip fix

* added test
2018-10-03 11:08:01 -07:00
Danny Tuppeny 2f6155bf18
Throw if trying to set fs.currentDirectory in tests (#22037)
* Block setting of fs.currentDirectory in tests

This isn't perfect, it only covers tests using testUsingContext, but that is the huge majority of tests.

* Tweak error message.
2018-10-03 19:07:04 +01:00
xster 188c25fbd3
Clarify that only one nav bar should be in each route (#22584) 2018-10-02 20:09:23 -07:00
xster dd3af0e287
Cupertino picker fidelity fixes (#22537) 2018-10-02 18:35:02 -07:00
Michael Goderbauer bfa9822134
Hide App.framework.dSYM from Spotlight (#22540) 2018-10-02 18:28:22 -07:00
Hans Muller 99a2293893
Added ColorScheme dartdoc (#22592) 2018-10-02 17:35:36 -07:00
Hans Muller eea3465ae7
Added ColorScheme, updated ThemeData, ButtonTheme, material buttons (#22013)
Introduce an overall material "color scheme" and to make it possible to redefine how a component's visual properties bind to the color scheme and to the existing material Theme.
2018-10-02 14:50:43 -07:00
Gary Qian 46bc911b72
Add 'restoreSystemUIOverlays' to SystemChrome to allow simple UI restore after System force changes. (#22221)
* Add 'restoreSystemUIOverlays' to SystemChrome to allow simple UI restore after System force changes.
2018-10-02 14:44:39 -07:00
Danny Tuppeny d89604d85c
Change file paths to URIs to fix "Could not run configuration in engine" on Windows (#22507)
* Change file paths to URIs to fix "Could not run configuration in engine" on Windows

Plus unskip test that was failing due to this.

Fixes #21348.

* Remove unused import
2018-10-02 18:31:55 +01:00
Alexandre Ardhuin 5de96bb734
unnecessary this in field initializers (#22522) 2018-10-02 17:14:59 +02:00
jensjoha 4bd6ad7395
Use unsafePackageSerialization when running tests (#22407) 2018-10-02 08:36:21 +02:00
Yegor d91f1608c5
upgrade packages (#22524) 2018-10-01 14:42:53 -07:00
Jason Simmons 3581b3ae85
Make font manifest descriptors consistent with the paths used for font assets (#22375)
The asset subsystem uses URIs to represent asset locations.  The font manifest
should also use URI-encoded paths instead of unencoded paths taken directly
from the manifest YAML.

Fixes https://github.com/flutter/flutter/issues/19452
2018-10-01 14:14:48 -07:00
Jonah Williams f19674853c
move doc comment back (#22525) 2018-10-01 13:29:21 -07:00
Alexandre Ardhuin f62afdcf57
add missing type parameter on methods (#22096) 2018-10-01 21:29:08 +02:00
Alexandre Ardhuin 48fb726b01
compare to null with == (#21944)
* compare to null with ==

* address review comments
2018-10-01 21:22:51 +02:00
Jonah Williams 224f91e386
Revert "Eliminate snapshot, depfile opts from bundle cmd (#22495)" (#22519)
This reverts commit b07d986f66.
2018-10-01 10:49:39 -07:00
Chris Bracken b07d986f66
Eliminate snapshot, depfile opts from bundle cmd (#22495)
Eliminates the --snapshot and --depfile parameters from the flutter
bundle command. The snapshot parameter is unused in Dart 2 -- code is
built to kernel .dill files and for profile/release builds, then AOT
compiled.

While depfiles are still used in Dart 2 (e.g. by the kernel compiler),
there are enough assumptions in the code that they lie in the default
location (e.g. in the Gradle build) and no reasons to support
user-cusomisation that it makes sense to eliminate the --depfile option
as well, and always use the default location.

This commit also renames 'depFilePath' to 'depfilePath' for consistency
across the codebase.
2018-10-01 10:19:37 -07:00
jslavitz a7303e040d
Selection controls internationalization (#22443)
* Fix internationalization issues with cupertinoTextSelectionControls
2018-10-01 10:04:08 -07:00
Tran Huy Phuc 481cb77a4c Fix flutter emaultors crash when ini file is not parsed (#22503)
Fixes #22247.
2018-10-01 18:02:43 +01:00
xster ac9dc5745e
Add support for material agnostic driver navigation (#22461) 2018-10-01 09:18:20 -07:00
Viet Do 2a8e35cc9c Cupertino Date Picker (#21251) 2018-09-28 18:29:28 -07:00
jslavitz efc5123d29
Chip press elevation (#22383)
* Make Chip press elevation customizable.
2018-09-28 16:12:55 -07:00
shrike69 c496751ae8
Change flutter tool to not require Fuchsia build args (#22382)
* Change flutter tool to not require Fuchsia build args

* Restore code that was commented out.

* Fix style nits.
2018-09-28 15:13:47 -07:00
Stanislav Baranov 54c10f44b2
Implement build flow for hot updates on Android (#22391)
This also involves switching from Core JIT to App JIT snapshot, and replacing per-isolate VM snapshot with the shared VM snapshot.

For now there is no separate update bundle file, as the generated update gets packaged directly into the APK for testing purposes.
2018-09-28 13:58:37 -07:00
liyuqian 783c028f2c
Don't push offset to leaf layers (#21619)
For retained rendering, we don't want to push the offset down to each leaf layer. Otherwise, changing an offset layer on the very high level could cascade the change to too many leaves, which means that we can't retain them.

To not push the offset downwards, we simply push a TransformLayer when there's an offset. Skia has a fast path for concatenating scale/translation-only matrix so this operation should be fast (no performance regression is measured on Moto G4).

This is our first step towards https://github.com/flutter/flutter/issues/21756
2018-09-28 12:21:43 -07:00
Andrew Davies 1c2f478e9e
[frdp][connection] Exception checks in _getDartVm (#22386)
Through some integration testing checks, it looks like it's possible
that connecting to a new instance of the Dart VM may fail even after the
Dart VM instance has been discovered.

This means that _getDartVm should be checked in more than just one
place.  This changes the function to return a null value in the event of
a 'well-known' exception (`HttpException` or `TimeoutException`
specifically).

As a result, code now calling _getDartVm checks for null and handles it
as appropriate, and the DartVm RPC calls are all updated with
consistent timeout params.
2018-09-28 11:40:36 -07:00
shrike69 fd8a9603ac
Remove waitForViews() during hot reload (#22371) 2018-09-28 11:35:38 -07:00
liyuqian 598ef49051
Put opacity image source inside "Sample code" (#22385)
See https://github.com/flutter/flutter/pull/22278#pullrequestreview-159230244
2018-09-28 11:10:11 -07:00
jslavitz 657a41ed8c
Vertical divider (#22377)
* Add vertical divider option.

* added vertical divider

* restored hello world

* final changes

* a few changes

* comment fixes

* added VerticalDivider

* few changes

* comment changes:

* ultra nits
2018-09-27 16:37:33 -07:00
asiva 556568ffe6 Fix quotes. 2018-09-27 15:17:03 -07:00
asiva 5024871a05 Fix error message. 2018-09-27 15:17:03 -07:00