Darren Austin
3d93f24c05
Tapping a modal bottom sheet should not dismiss it by default ( #32528 )
...
Removed the GestureDetector from the modal bottom sheet that dismissed it on tap and updated several tests to accommodate this change.
2019-05-15 15:50:39 -07:00
Tong Mu
20299a2c17
Add buttons customization to WidgetController and related testing classes ( #31095 )
...
* Add buttons to WidgetController and TestPointer
* Add more buttons
* Let TestPointer handle default device
* Use getter only buttons
2019-05-15 15:42:03 -07:00
Amir Hardon
f545f47d8f
Add a FocusNode for AndroidView widgets. ( #32773 )
...
The PlatformViewsService listens for `viewFocused` calls on the
platform_views system channel and fires a callback that focuses the
focus node for the relevant AndroidView widget.
2019-05-15 15:25:50 -07:00
engine-flutter-autoroll
d3b16ecfa0
62b51ae39 Roll src/third_party/skia c8d66d35538c..32c32b9a6caa (15 commits) (flutter/engine#8976) ( #32775 )
...
3cdfa807fa...62b51ae398flutter/engine#8976 )
The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff (jsimmons@google.com ), and stop
the roller if necessary.
2019-05-15 18:13:40 -04:00
engine-flutter-autoroll
301a97796a
3cdfa807f Replace ararysize macro with fml::size function (flutter/engine#8975) ( #32771 )
...
ce22829cd9...3cdfa807faflutter/engine#8975 )
The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff (jsimmons@google.com ), and stop
the roller if necessary.
2019-05-15 17:20:38 -04:00
engine-flutter-autoroll
a68f2963cd
Roll engine 208011758ffe..ce22829cd99a (2 commits) ( #32767 )
...
208011758f...ce22829cd9flutter/engine#8973 )
81b6f7bec Roll src/third_party/dart a0290f823c..ea9b0cd0f5 (86 commits)
The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff (jsimmons@google.com ), and stop
the roller if necessary.
2019-05-15 15:25:39 -04:00
MH Johnson
da0a3a275a
[Material] Remove inherit: false on default TextStyle in bottom navigation bar ( #32727 )
2019-05-15 10:30:41 -04:00
Hans Muller
30fed3a05d
Material should not prevent ScrollNotifications from bubbling upwards ( #32726 )
2019-05-15 07:15:34 -07:00
engine-flutter-autoroll
7d667decd5
Roll engine 849fa42a06a5..208011758ffe (3 commits) ( #32745 )
...
849fa42a06...208011758fflutter/engine#8971 )
45599515d Roll src/third_party/skia c8a84d2b7ff9..3f79f07a14eb (1 commits) (flutter/engine#8968 )
f5fa03b5e Use Android text selection shifting API to handle keyboard backspace (flutter/engine#8956 )
The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff (jsimmons@google.com ), and stop
the roller if necessary.
2019-05-15 04:35:39 -04:00
engine-flutter-autoroll
89f38fd3db
Roll engine 832cdacc6f95..849fa42a06a5 (4 commits) ( #32735 )
...
832cdacc6f...849fa42a06flutter/engine#8969 )
10742e77a Roll src/third_party/dart a0290f823c..6d5f763952 (70 commits)
55ff8d60b Revert "Roll src/third_party/dart a0290f823c..6d5f763952 (70 commits)" (flutter/engine#8966 )
704b6eead Roll src/third_party/dart a0290f823c..6d5f763952 (70 commits)
The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff (jsimmons@google.com ), and stop
the roller if necessary.
2019-05-15 00:30:39 -04:00
Chris Bracken
0d8959448c
Correct platform reference in UiKitViewController ( #32724 )
...
Correct docs and error message for UiKitViewController to refer to iOS
view rather than Android views. Minor cleanup to the docs for
PlatformViewsService, which previously mentioned Android only.
2019-05-14 21:27:34 -07:00
Greg Spencer
bb3c660522
Implements focus handling and hover for Material buttons. ( #31438 )
...
This implements focus and hover handling for Material buttons. It inserts Focus widgets into the tree in order to allow buttons to be focusable via keyboard traversal (a.k.a. TAB traversal), and Listener widgets into the InkWell to allow the detection of hover states for widgets.
Addresses #11344 , #1608 , and #13264 .
2019-05-14 20:48:29 -07:00
Greg Spencer
ed90d05596
Fix needsCompositing propagation from child widgets. ( #32717 )
...
This fixes propagation of needsCompositing from child widgets.
When needsCompositing is turned on by a child widget, it necessarily sets the needsCompositing bit of its parent widget, but RenderPointerListener was ignoring that piece of information and only turning on compositing if it thought it needed it for itself.
This corrects that, and adds a test for the condition, and updates a test that was affected by the change.
Fixes #32525 (again)
2019-05-14 17:09:29 -07:00
engine-flutter-autoroll
a967bc35f3
832cdacc6 Roll src/third_party/skia 4167215daf0e..c8a84d2b7ff9 (9 commits) (flutter/engine#8964) ( #32722 )
...
d0dc9b94d4...832cdacc6fflutter/engine#8964 )
The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff (jsimmons@google.com ), and stop
the roller if necessary.
2019-05-14 19:55:39 -04:00
stuartmorgan
6722fb448c
Teach flutter msbuild for Windows ( #32335 )
...
Eliminates the need for a build.bat in the Windows build workflow, adding
preliminary support for building using msbuild. The handling of
vcvars64.bat may be refined in the future, but this serves as a starting point.
2019-05-14 19:24:40 -04:00
Dan Field
6d4b0abfa8
Ignore some JSON RPC errors ( #32710 )
2019-05-14 16:04:04 -07:00
engine-flutter-autoroll
5f9826040c
d0dc9b94d Rename frame_time and engine_time (flutter/engine#8952) ( #32721 )
...
66087301cd...d0dc9b94d4flutter/engine#8952 )
The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff (jsimmons@google.com ), and stop
the roller if necessary.
2019-05-14 18:59:39 -04:00
Darren Austin
752147e2b1
Added 'enabled' property to the PopupMenuButton ( #32527 )
...
Added 'enabled' property to the PopupMenuButton to allow the button to be disabled in the case where the menu would be empty.
2019-05-14 15:48:13 -07:00
Alexandre Ardhuin
41b9abdc32
enable lint prefer_null_aware_operators ( #32686 )
2019-05-14 22:34:49 +02:00
engine-flutter-autoroll
242e2f5cf7
Roll engine a89cf80d4de5..66087301cd9a (2 commits) ( #32709 )
...
a89cf80d4d...66087301cdflutter/engine#8950 )
a89531561 Roll src/third_party/skia c2aea5938d0d..4167215daf0e (5 commits) (flutter/engine#8961 )
The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff (jsimmons@google.com ), and stop
the roller if necessary.
2019-05-14 16:26:39 -04:00
Efthymis Sarmpanis
7498ad00b5
Add a more meaningful message to the assertion on children property of MultiChildRenderObjectWidget and SliverChildListDelegate. ( #32487 )
2019-05-14 12:41:07 -07:00
Hans Muller
d9f6cada1c
Tabs code/doc cleanup ( #32654 )
2019-05-14 12:00:03 -07:00
Mouad Debbar
bcae3563d4
Redo: Show/hide toolbar and handles based on device kind ( #32704 )
2019-05-14 11:04:16 -07:00
Zachary Anderson
8841afeb1f
[flutter_tool] Build a Fuchsia package ( #32519 )
2019-05-14 10:59:23 -07:00
Kate Lovett
054d9bb2f1
Updating dart.dev related links ( #32641 )
...
* Updating dart.dev related links
* Update packages/flutter_tools/lib/src/base/context.dart
2019-05-14 10:35:00 -07:00
Mouad Debbar
ef5abcc6bf
Revert "Show/hide toolbar and handles based on device kind ( #29683 )" ( #32702 )
...
This reverts commit 18ca37542d
2019-05-14 09:33:04 -07:00
engine-flutter-autoroll
7ab111ea61
a89cf80d4 Roll src/third_party/skia 136ad09848f5..c2aea5938d0d (1 commits) (flutter/engine#8958) ( #32700 )
...
4238163010...a89cf80d4dflutter/engine#8958 )
The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff (jsimmons@google.com ), and stop
the roller if necessary.
2019-05-14 11:52:40 -04:00
Mouad Debbar
18ca37542d
Show/hide toolbar and handles based on device kind ( #29683 )
2019-05-14 08:50:23 -07:00
engine-flutter-autoroll
fe8cddbb8d
423816301 Roll src/third_party/skia 4e66df54e7da..136ad09848f5 (2 commits) (flutter/engine#8957) ( #32685 )
...
49bc9c86c9...4238163010flutter/engine#8957 )
The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff (jsimmons@google.com ), and stop
the roller if necessary.
2019-05-14 11:04:39 -04:00
Greg Spencer
96ebfec1a3
Add diagnostics around needsCompositing ( #32656 )
...
Added diagnostic output for needsCompositing to RenderObject diagnostics output.
2019-05-14 08:02:25 -07:00
engine-flutter-autoroll
894dca77b6
49bc9c86c Roll src/third_party/skia 0221e8b22687..4e66df54e7da (5 commits) (flutter/engine#8955) ( #32671 )
...
5ac2d02645...49bc9c86c9flutter/engine#8955 )
The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff (chinmaygarde@google.com ), and stop
the roller if necessary.
2019-05-14 02:35:39 -04:00
engine-flutter-autoroll
b3b4d60408
Roll engine c83ec26f351f..5ac2d02645a2 (4 commits) ( #32665 )
...
c83ec26f35...5ac2d02645flutter/engine#8954 )
51486a549 New Plugin API PR2: Introduces ActivityAware, ActivityControlSurface, and ActivityPluginBinding. (flutter/engine#8943 )
b3b817a9b Add a minimal set of symbols to the dynamic symbol table for Linux executables (flutter/engine#8937 )
96ffc893e Copy the Dart Runner from //topaz into the engine. (flutter/engine#8949 )
The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff (chinmaygarde@google.com ), and stop
the roller if necessary.
2019-05-13 23:06:39 -04:00
engine-flutter-autoroll
5bd307caf2
c83ec26f3 Roll Tonic (flutter/engine#8940) ( #32653 )
...
904cfc4fe3...c83ec26f35flutter/engine#8940 )
The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff (chinmaygarde@google.com ), and stop
the roller if necessary.
2019-05-13 19:39:39 -04:00
Greg Spencer
a5053bfb29
Fix transforms for things with RenderPointerListeners ( #32535 )
...
This fixes #32525 , because it now marks the compositing bits as needing to be recalculated if the mouse tracker changes its idea of whether or not a mouse is attached.
This bug occurred because the test framework was leaking state from one test to the next (the state about whether a mouse pointer was active), and so even though there was a "passing" test when run in order with the other tests in the file, when the test was run individually (or first), it would have failed and caught the bug.
This adds an assert to make sure that after each test there are no simulated mouse pointers connected, and now calls removePointer in all of the tests where this was a problem.
2019-05-13 15:48:12 -07:00
Jason Simmons
f5cf209a66
Remove appbundle build steps that are required for APKs but not AABs ( #32515 )
...
Some parts of the appbundle build process were based on the logic for building
APK packages. However, these steps (copying to a directory shared by all
build variants, and calculating a SHA) are not necessary for an appbundle.
2019-05-13 15:36:47 -07:00
Shi-Hao Hong
41ff8408ca
Add Actions to AppBar Sample Doc ( #32530 )
...
* Add actions to AppBar sample doc
2019-05-13 15:19:14 -07:00
engine-flutter-autoroll
74d3fe6555
Roll engine f4d23ef694a9..904cfc4fe363 (5 commits) ( #32648 )
...
f4d23ef694...904cfc4fe3#32642 ). (flutter/engine#8947 )
c9406d45c Roll src/third_party/skia d696f8e6bca3..0221e8b22687 (5 commits) (flutter/engine#8948 )
1b649a57d update docs (flutter/engine#8928 )
47fd66c89 Terminate debug background task on expiry (flutter/engine#8930 )
14c82d996 Only cache required frames (flutter/engine#8837 )
The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff (chinmaygarde@google.com ), and stop
the roller if necessary.
2019-05-13 17:54:40 -04:00
liyuqian
06f86c8b2f
Reland matrix check ( #32521 )
...
This relands flutter/flutter#31701 with missing const added
This reverts commit 549b412656
2019-05-13 14:36:09 -07:00
xster
1cd88c3501
Let CupertinoNavigationBarBackButton take a custom onPressed ( #32469 )
2019-05-13 12:41:24 -07:00
engine-flutter-autoroll
f82c83b31c
f4d23ef69 Replace Skia font macros with enums. (flutter/engine#8920) ( #32640 )
...
839628b1e8...f4d23ef694flutter/engine#8920 )
The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff (chinmaygarde@google.com ), and stop
the roller if necessary.
2019-05-13 15:39:39 -04:00
engine-flutter-autoroll
11fe9fc91c
839628b1e Roll src/third_party/skia 617d801ff762..d696f8e6bca3 (6 commits) (flutter/engine#8946) ( #32635 )
...
c454d2ef7f...839628b1e8flutter/engine#8946 )
The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff (chinmaygarde@google.com ), and stop
the roller if necessary.
2019-05-13 14:26:40 -04:00
Shi-Hao Hong
9545c5d166
Tab Animation Sample Video ( #32177 )
...
* Improve tabs documentation regarding matching lengths
* Add Tabs animation to docs
2019-05-13 09:06:43 -07:00
engine-flutter-autoroll
c4d527123e
Roll engine 816d3fc58611..c454d2ef7fc5 (2 commits) ( #32625 )
...
816d3fc586...c454d2ef7fflutter/engine#8945 )
8d126ce9f Roll src/third_party/skia 806621b2e0b5..695206d7149a (1 commits) (flutter/engine#8942 )
The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff (chinmaygarde@google.com ), and stop
the roller if necessary.
2019-05-13 11:00:41 -04:00
Danny Tuppeny
b76a1e8312
Comment out .vscode/ in gitignore for templates ( #32404 )
2019-05-13 09:06:30 +01:00
engine-flutter-autoroll
9b2a1853ac
816d3fc58 New Plugin API PR1: Introduces PluginRegistry and FlutterPlugin, adds support for plugin registration to FlutterEngine. (flutter/engine#8826) ( #32598 )
...
21ad7f051c...816d3fc586flutter/engine#8826 )
The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff (chinmaygarde@google.com ), and stop
the roller if necessary.
2019-05-12 21:28:38 -04:00
engine-flutter-autoroll
ebacca34e5
21ad7f051 Move the Fuchsia Flutter Runner to //flutter/shell/platform/fuchsia/flutter (flutter/engine#8939) ( #32593 )
...
7553de25db...21ad7f051cflutter/engine#8939 )
The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff (chinmaygarde@google.com ), and stop
the roller if necessary.
2019-05-12 19:09:39 -04:00
engine-flutter-autoroll
3d42e3fadf
7553de25d Roll src/third_party/skia 5c7b54112bca..806621b2e0b5 (1 commits) (flutter/engine#8941) ( #32579 )
...
5526884e78...7553de25dbflutter/engine#8941 )
The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff (chinmaygarde@google.com ), and stop
the roller if necessary.
2019-05-12 11:05:39 -04:00
stuartmorgan
710a0cb9a5
Adjust macOS build flow ( #32538 )
...
- Removes SYMROOT from the Generated.xcconfig. Having it causes current
versions of Xcode to switch the project's build output to "Legacy",
which causes anything not overridden to use a project-relative build
directory instead of a shared directory in DerivedData, breaking
anything with subprojects that it depends on.
This means that `flutter run` and builds from Xcode will use
completely different build directories, but that each should be
internally consistent.
- Moves the FlutterMacOS.framework to $SRCROOT/Flutter. This is
consistent with the approach we're moving to for all desktop
platforms, and avoids issues finding it now that SYMROOT doesn't match
for the two different build modes.
Fixes #32494
2019-05-11 21:12:42 -04:00
engine-flutter-autoroll
145f9f7ea6
Roll engine 6e3c0431410c..5526884e7878 (3 commits) ( #32568 )
...
6e3c043141...5526884e78flutter/engine#8936 )
5ad986424 Roll src/third_party/skia 303bacbc0fcb..5c7b54112bca (2 commits) (flutter/engine#8938 )
64481bd5d Roll src/third_party/skia 6e407986cd3b..303bacbc0fcb (2 commits) (flutter/engine#8935 )
The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff (chinmaygarde@google.com ), and stop
the roller if necessary.
2019-05-11 19:47:39 -04:00
Jonah Williams
8b0243f413
Teach Linux to use local engine ( #31631 )
2019-05-11 00:08:29 -07:00
