Kate Lovett
3a3939a7fa
Revert "Skia Gold Support for Local & PreSubmit Testing in package:flutter ( #40710 )" ( #43227 )
...
This reverts commit 8df0d6556d
.
2019-10-21 17:31:54 -07:00
Jonah Williams
22f0bf87e4
Silence presubmit codecov checks ( #43183 )
2019-10-21 16:54:02 -07:00
Emmanuel Garcia
e82ddc4c7a
Ensure android.enableR8
is appended to a new line ( #43187 )
2019-10-21 16:52:30 -07:00
Jonah Williams
27105cba2f
switch dart2js build to depfile, remove Source.function ( #42977 )
2019-10-21 16:46:44 -07:00
Jonah Williams
6c91a13731
Adding missing break in plugin validation check ( #43180 )
2019-10-21 16:46:07 -07:00
Kate Lovett
8df0d6556d
Skia Gold Support for Local & PreSubmit Testing in package:flutter ( #40710 )
2019-10-21 16:45:56 -07:00
Jonah Williams
31a4ff80c7
add samsungexynos7570 to list of known physical devices ( #43042 )
2019-10-21 16:45:48 -07:00
Kate Lovett
83878683c0
Re-landing SliverAnimatedList ( #42485 )
2019-10-21 16:44:55 -07:00
Jonah Williams
6db4c44da8
remove period from URL so that it opens correctly in vscode ( #43200 )
2019-10-21 16:43:11 -07:00
engine-flutter-autoroll
ce2d8ace2f
8882bf3c7 Avoid dereferencing IO manager weak pointers on the UI thread (flutter/engine#13232) ( #43045 )
...
git@github.com:flutter/engine.git/compare/8aefcd857508...8882bf3c73f5
git log 8aefcd857508..8882bf3c73f5 --no-merges --oneline
2019-10-18 jason-simmons@users.noreply.github.com Avoid dereferencing IO manager weak pointers on the UI thread (flutter/engine#13232 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC franciscojma@google.com on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
2019-10-21 19:43:06 -04:00
Emmanuel Garcia
30493a35b6
Test Gradle on Windows ( #42709 )
2019-10-21 16:42:46 -07:00
Christopher Fujino
898e6fe3c6
comment out fastlane test archiving ( #43207 )
2019-10-21 15:25:55 -07:00
Ian Hickson
584ee10c68
Disable CI tests that LUCI is failing ( #43149 )
2019-10-21 07:49:28 -07:00
Ian Hickson
d09ed19ee9
Disable CI tests that LUCI is failing (2) ( #43150 )
2019-10-21 07:49:21 -07:00
Tong Mu
1c535de7e0
Soften layer breakage ( #42953 )
...
* Replace hard break of Layer.find/All with findAllAnnotations
* Deprecate findAll
2019-10-18 16:40:42 -07:00
Ian Hickson
124dc6617f
Clean up test infrastructure ( #43030 )
...
See #41880 for history.
2019-10-18 16:35:39 -07:00
engine-flutter-autoroll
40b1335a87
8aefcd857 Roll src/third_party/skia f4b3d6b9f3d1..7605c89c00f7 (10 commits) (flutter/engine#13234) ( #43039 )
...
git@github.com:flutter/engine.git/compare/ee91881ccc8f...8aefcd857508
git log ee91881ccc8f..8aefcd857508 --no-merges --oneline
2019-10-18 skia-flutter-autoroll@skia.org Roll src/third_party/skia f4b3d6b9f3d1..7605c89c00f7 (10 commits) (flutter/engine#13234 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC franciscojma@google.com on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
2019-10-18 18:48:06 -04:00
Edman P. Anjos
faa514fc24
Quick fix on material dialog docs ( #42968 )
2019-10-18 15:43:04 -07:00
Aditya Sharma
b6c865ff9c
Fix typo ( #42922 )
2019-10-18 15:42:28 -07:00
Jonah Williams
39e4d9d152
Expand scope of rethrown gradle errors ( #42966 )
2019-10-18 14:56:39 -07:00
engine-flutter-autoroll
f7018c2a47
ee91881cc Adds Dark Mode support to new Android embedding (this was accidentally missed previously). (flutter/engine#13215) ( #43032 )
...
git@github.com:flutter/engine.git/compare/98e6d15663b0...ee91881ccc8f
git log 98e6d15663b0..ee91881ccc8f --no-merges --oneline
2019-10-18 matthew-carroll@users.noreply.github.com Adds Dark Mode support to new Android embedding (this was accidentally missed previously). (flutter/engine#13215 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC franciscojma@google.com on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
2019-10-18 17:37:06 -04:00
engine-flutter-autoroll
ac012c5f1b
Roll engine dea7150f33fd..98e6d15663b0 (3 commits) ( #43027 )
...
git@github.com:flutter/engine.git/compare/dea7150f33fd...98e6d15663b0
git log dea7150f33fd..98e6d15663b0 --no-merges --oneline
2019-10-18 mouad.debbar@gmail.com Preserve stdout colors of subprocesses run by felt (flutter/engine#13209 )
2019-10-18 ferhat@gmail.com [web] Fix canvas reuse metrics. Refactor drawVertices code. (flutter/engine#13190 )
2019-10-18 jfedor@jfedor.org Add repeatCount to FlutterKeyEvent (flutter/engine#13176 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC franciscojma@google.com on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
2019-10-18 16:51:06 -04:00
Emmanuel Garcia
29afbe0d8c
Remove GeneratedPluginRegistrant.java ( #42981 )
2019-10-18 13:11:33 -07:00
Jonah Williams
6fc99e98ad
rename headless server to web server ( #42970 )
2019-10-18 12:41:47 -07:00
Jonah Williams
21be8372c9
implement debugTogglePlatform for the web ( #42951 )
2019-10-18 12:41:15 -07:00
Jonah Williams
e67f9a3f6c
ensure we can disable --track-widget-creation in debug mode ( #43016 )
2019-10-18 12:40:50 -07:00
engine-flutter-autoroll
5db53aee5e
Roll engine 7a621a7f7e4f..dea7150f33fd (4 commits) ( #43023 )
...
git@github.com:flutter/engine.git/compare/7a621a7f7e4f...dea7150f33fd
git log 7a621a7f7e4f..dea7150f33fd --no-merges --oneline
2019-10-18 50856934+nturgut@users.noreply.github.com Adding firefox_installer.dart (flutter/engine#13185 )
2019-10-18 skia-flutter-autoroll@skia.org Roll fuchsia/sdk/core/linux-amd64 from _G94w... to bdTv5... (flutter/engine#13228 )
2019-10-18 skia-flutter-autoroll@skia.org Roll src/third_party/skia b80d31f8cbe2..f4b3d6b9f3d1 (1 commits) (flutter/engine#13229 )
2019-10-18 skia-flutter-autoroll@skia.org Roll fuchsia/sdk/core/mac-amd64 from KNygX... to SevlL... (flutter/engine#13227 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC franciscojma@google.com on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
2019-10-18 15:34:06 -04:00
Erick (CptBlackPixel)
12b7b08da5
Reading deviceId for RawKeyEventDataAndroid event ( #42235 )
...
This PR adds a new property on RawKeyEventDataAndroid to hold the deviceId from which that event was generated. The deviceId is been sent from the engine on the changes from this PR: flutter/engine#12958
With this, we will be able to identify from where the event came from, adding the ability to support local multiplayer games, with multiple gamepads.
2019-10-18 12:32:21 -07:00
Greg Spencer
560873af92
Wire up canRequestFocus and skipTraversal in FocusScopeNode ( #43013 )
...
This adds a canRequestFocus and skipTraversal argument to FocusScope and FocusScopeNode, so that a scope can prevent being traversed.
This allows a fix for a problem in the gallery where the focus while traversing the list of items would sometimes appear to disappear, since it would be focusing things that were in the backdrop that were part of the tree, but were not visible.
Related Issues
Fixes #42955
2019-10-18 12:31:15 -07:00
Greg Spencer
df76354488
Add a Focus node to the DropdownButton, and adds an activation action for it. ( #42811 )
...
This adds a Focus node to the DropdownButton widget, allowing it to receive keyboard focus, and to show a focus highlight. In addition, I added the ability to activate the dropdown using the "enter" key binding (which is bound to ActivateAction in the WidgetsApp).
Related Issues
Fixes #42646
Fixes #43008
Fixes #42511
2019-10-18 12:30:40 -07:00
Christopher Fujino
18ff9a24db
temporarily disable system_debug_ios devicelab test ( #43026 )
2019-10-18 12:28:46 -07:00
engine-flutter-autoroll
7da9561cdb
Roll engine 508146f0defb..7a621a7f7e4f (26 commits) ( #43017 )
...
git@github.com:flutter/engine.git/compare/508146f0defb...7a621a7f7e4f
git log 508146f0defb..7a621a7f7e4f --no-merges --oneline
2019-10-18 skia-flutter-autoroll@skia.org Roll src/third_party/skia 20eafffd2d2f..b80d31f8cbe2 (4 commits) (flutter/engine#13226 )
2019-10-18 skia-flutter-autoroll@skia.org Roll src/third_party/skia da29d70f1a59..20eafffd2d2f (1 commits) (flutter/engine#13223 )
2019-10-18 skia-flutter-autoroll@skia.org Roll src/third_party/skia 63a387395751..da29d70f1a59 (11 commits) (flutter/engine#13221 )
2019-10-18 skia-flutter-autoroll@skia.org Roll fuchsia/sdk/core/linux-amd64 from WpvU_... to _G94w... (flutter/engine#13220 )
2019-10-18 chinmaygarde@google.com Specify a human readable reason for an error from the embedder API. (flutter/engine#13218 )
2019-10-18 skia-flutter-autoroll@skia.org Roll fuchsia/sdk/core/mac-amd64 from _9Uy_... to KNygX... (flutter/engine#13219 )
2019-10-17 iska.kaushik@gmail.com Reland ICU update to 64.2 (flutter/engine#13216 )
2019-10-17 hterkelsen@users.noreply.github.com Use `window.devicePixelRatio` in the CanvasKit backend (flutter/engine#13192 )
2019-10-17 gw280@google.com Re-enable WeakPtr ThreadChecker and fix associated failures (flutter/engine#12257 )
2019-10-17 chinmaygarde@gmail.com Re-land "Custom compositor layers must take into account the device pixel ratio."
2019-10-17 chinmaygarde@gmail.com Add trace events around custom compositor callbacks. (flutter/engine#13212 )
2019-10-17 skia-flutter-autoroll@skia.org Roll src/third_party/skia 93e853bf2b83..63a387395751 (9 commits) (flutter/engine#13208 )
2019-10-17 bkonyi@google.com Roll src/third_party/dart 9b3c7f64d8..a61c775db8 (5 commits)
2019-10-17 chinmaygarde@gmail.com Document //flutter/runtime/dart_snapshot.h (flutter/engine#13196 )
2019-10-17 chinmaygarde@gmail.com Revert "Custom compositor layers must take into account the device pixel ratio. (#13193 )" (flutter/engine#13211 )
2019-10-17 50856934+nturgut@users.noreply.github.com wrap the text in text editing. This was causing a missalingment issue in textarea. (flutter/engine#13207 )
2019-10-17 chinmaygarde@google.com Custom compositor layers must take into account the device pixel ratio. (flutter/engine#13193 )
2019-10-17 mouad.debbar@gmail.com [web] Environment variable to disable felt snapshot (flutter/engine#13187 )
2019-10-17 bkonyi@google.com Roll src/third_party/dart 9e636b5ab4..9b3c7f64d8 (5 commits)
2019-10-17 skia-flutter-autoroll@skia.org Roll src/third_party/skia 0df7697235b4..93e853bf2b83 (1 commits) (flutter/engine#13205 )
2019-10-17 skia-flutter-autoroll@skia.org Roll fuchsia/sdk/core/linux-amd64 from ek5iQ... to WpvU_... (flutter/engine#13203 )
2019-10-17 skia-flutter-autoroll@skia.org Roll fuchsia/sdk/core/mac-amd64 from 6j3Gw... to _9Uy_... (flutter/engine#13202 )
2019-10-17 skia-flutter-autoroll@skia.org Roll src/third_party/skia 6a19e03047cc..0df7697235b4 (1 commits) (flutter/engine#13200 )
2019-10-17 bkonyi@google.com Roll src/third_party/dart 1e3e9ee04c..9e636b5ab4 (9 commits)
2019-10-17 skia-flutter-autoroll@skia.org Roll src/third_party/skia f29cb70281d5..6a19e03047cc (5 commits) (flutter/engine#13198 )
2019-10-17 bkonyi@google.com Roll src/third_party/dart f020ce5d23..1e3e9ee04c (12 commits)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC franciscojma@google.com on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
2019-10-18 14:11:18 -04:00
Jonah Williams
1982a5c3ec
Revert "Clean up test infrastructure ( #41880 )" ( #42982 )
...
This reverts commit 1781d5c9bb
.
2019-10-17 19:47:16 -07:00
Ian Hickson
be7937965c
Reenable the dartdocs benchmark tracking ( #42882 )
2019-10-17 19:32:31 -07:00
Ian Hickson
1781d5c9bb
Clean up test infrastructure ( #41880 )
2019-10-17 19:22:47 -07:00
Jonah Williams
863fb2f2cc
Remove linux-x64 unpack logic ( #42962 )
2019-10-17 19:22:03 -07:00
Jonah Williams
b80e6bba6a
re-enable some linux devicelab tests ( #42971 )
2019-10-17 19:21:52 -07:00
Jonah Williams
f53b32eb23
refactor depfile usage and update linux rule ( #42487 )
2019-10-17 17:42:40 -07:00
Ryan Macnak
315471bfb0
Do not produce an error when encountering a new type in a service response. ( #42972 )
...
Flutter tool's service client library tries to "upgrade" sub-components of service responses with higher level model objects. It does this for all members of the response, rather than only those documented in the version it targets, and it errors out when encountering a new type. This causes it to fail when a new field is introduced with a new typed. Clients are required to ignore this.
2019-10-17 16:56:57 -07:00
Michael Goderbauer
ddca78b4b7
Fix memory leak in TransitionRoute ( #42777 )
2019-10-17 15:51:45 -07:00
Jaumard
1faf6a9a89
create gesture recognizers on attach and dispose on detach to avoid leaks ( #42076 )
2019-10-17 15:48:20 -07:00
Jenn Magder
b194f93541
Remove use_modular_headers from Podfiles using libraries ( #42872 )
...
* Remove use_modular_headers from Podfiles using libraries
* Remove @imports
2019-10-17 15:26:10 -07:00
Jonah Williams
bc396d1b5c
Add onVisible callback to snackbar. ( #42344 )
2019-10-17 15:12:25 -07:00
Greg Spencer
a7aa66164e
Re-implement hardware keyboard text selection. ( #42879 )
...
This re-implements keyboard text selection so that it will work on platforms other than Android (e.g. macOS, Linux, etc.).
Also, fixed a number of bugs in editing selection via a hardware keyboard (unable to select backwards, incorrect conversion to ASCII when cutting to clipboard, lack of support for CTRL-SHIFT-ARROW word selection, etc.).
Did not address the keyboard locale issues that remain, or add platform specific switches for the bindings. All that will need some more design work before implementing them.
Related Issues
Fixes #31951
2019-10-17 15:11:44 -07:00
Ferhat
f7ce5ae3fc
[web] Update web runner message with flutter.dev/web ( #42676 )
...
* Update web runner message with flutter.dev/web
* Update spoopy test to use Warning instead
2019-10-17 15:08:15 -07:00
Shi-Hao Hong
3dc8898e10
Revert "Default colorScheme data in ButtonThemeData (Fix for #38655 ) ( #39627 )" ( #42854 )
...
This reverts commit 19899db223
.
2019-10-17 15:07:42 -07:00
Hans Muller
0a7e605632
Support AppBars with jumbo titles ( #42936 )
2019-10-17 15:01:41 -07:00
Greg Spencer
3afdd08af4
This disables the up/down arrow focus navigation in text fields in a different way. ( #42790 )
...
In #42533 , I disabled the up/down arrows for focus navigation in text fields, but we thought of a better way to do it, so this is that better way.
This change reverts the other change, and instead it tests the context of the node in the action to see if it's an EditableText node. If so, then it doesn't do the navigation action.
2019-10-17 15:01:22 -07:00
engine-flutter-autoroll
e007720a16
508146f0d Add a task runner for the Win32 embedding (flutter/engine#13043) ( #42898 )
...
git@github.com:flutter/engine.git/compare/3a357afc0372...508146f0defb
git log 3a357afc0372..508146f0defb --no-merges --oneline
2019-10-17 stuartmorgan@google.com Add a task runner for the Win32 embedding (flutter/engine#13043 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC franciscojma@google.com on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
2019-10-17 13:31:06 -04:00
engine-flutter-autoroll
a4d5266b76
Roll engine 9660eddaa588..3a357afc0372 (6 commits) ( #42895 )
...
git@github.com:flutter/engine.git/compare/9660eddaa588...3a357afc0372
git log 9660eddaa588..3a357afc0372 --no-merges --oneline
2019-10-17 skia-flutter-autoroll@skia.org Roll src/third_party/skia 1dfc77cc08ee..f29cb70281d5 (1 commits) (flutter/engine#13195 )
2019-10-17 bkonyi@google.com Roll src/third_party/dart b28b9ae8fc..f020ce5d23 (14 commits)
2019-10-17 chinmaygarde@google.com Remove incomplete static thread safety annotations. (flutter/engine#13151 )
2019-10-16 garyq@google.com Add utils to disable on mac/windows, disable invalid LibLxt tests on mac (flutter/engine#13189 )
2019-10-16 liyuqian@google.com Update timeout_microseconds to timeout in docs (flutter/engine#13179 )
2019-10-16 chinmaygarde@google.com Use the fixtures mechanism for txt unit-tests and benchmarks. (flutter/engine#13180 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC franciscojma@google.com on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
2019-10-17 01:13:06 -04:00