Commit graph

12592 commits

Author SHA1 Message Date
Jonah Williams 377879825e
[flutter_tools] prevent StateError when log reader is disposed (#52173)
Previously the AdbLogReader did async setup in the StreamController.onListen callback, specifically it would query the api version and start the adb process. If the log subscription was cancelled before this setup completed, then the log output could (haven't confirmed) get added to a closed controller, causing the above state error.
2020-03-10 11:34:40 -07:00
Jenn Magder fdd023fa59
Migrate older Xcode projects off the legacy build system (#52288) 2020-03-10 10:11:16 -07:00
Jonah Williams 60d0fef17a
[flutter_tools] move stack_trace_mapper and require.js into memory file system (#52276) 2020-03-09 22:07:34 -07:00
Jonah Williams 3191af1332
[flutter_tools] add more information to obfuscate option documentation (#52282) 2020-03-09 20:09:47 -07:00
Jonah Williams 88b39402ac
[flutter_tools] configure dwds to not serve devtools (#52284) 2020-03-09 19:20:11 -07:00
Francisco Magdaleno e9905b6ad8
[Keyboard] Collects windows key data (#52265) 2020-03-09 17:21:02 -07:00
Jonah Williams bc43b41d99
[flutter_tools] ensure --track-widget-creation is not enabled for build aot (#52261)
This option was defaulting to on, which was tickling some benchmarks
2020-03-09 17:19:14 -07:00
George Wright 084a7077ce
Revert "Put fuchsia tools into their own directory, and set source_dir to point at them. (#52266)" (#52277)
This reverts commit ffcc776513.
2020-03-09 16:55:58 -07:00
renyou 847280f72f
Revert "Improve text formatter repeat filter logic (#52055)" (#52274)
This reverts commit 91b0bcf1a8.
2020-03-09 16:26:48 -07:00
George Wright ffcc776513
Put fuchsia tools into their own directory, and set source_dir to point at them. (#52266)
This worksaround an issue with the latest version of package_config which doesn't handle
multiple dart packages sharing the same source directory. In this case, the fuchsia dart_tool
targets were sharing a directory with their dependency, :flutter_tools
2020-03-09 15:08:57 -07:00
Gary Qian 91b0bcf1a8
Improve text formatter repeat filter logic (#52055) 2020-03-09 13:05:07 -07:00
Angjie Li 665d380f81
Add Android Chrome support to Flutter Web Driver. (#51677)
* Support Android Chrome for Flutter Web Driver.
2020-03-09 13:01:07 -07:00
Per Classon 1546f41ec1
Add width constraints for FlexibleSpaceBar.title in its expanded state, so that overflow of long titles can be handled (#51335) 2020-03-09 12:06:01 -07:00
Chad Nehemiah 31df1d459e
made builder required (#51993) 2020-03-09 12:01:01 -07:00
Mike Rogers 57d84adc2d
Fix 2 typos within comments (#52181)
* occure > occur
* occured > occurred
* uptodate > up-to-date
2020-03-08 08:48:26 +00:00
Dan Field e13e17009d
Reland fix --version (#52141) 2020-03-06 21:38:35 -08:00
Dan Field db1f33fd70
Revert "Local engine build mode (#52043)" (#52152)
This reverts commit 4d05ed5deb.
2020-03-06 16:57:18 -08:00
Jonah Williams c1112d3f7e
[flutter_tools] Reland: Allow providing dart-defines to Android, iOS, macOS builds (#52044) 2020-03-06 14:53:36 -08:00
Darren Austin 1c3ebad904
Fix for negative padding from a curve in AnimatedPadding. (#52072)
* Fix for negative padding from a curve in AnimatedPadding.

* Added a EdgeInsets.clamp function that would return an EdgeInsets instance instead of a _MixedEdgeInsets used by the base class. This was causing some tests to fail that didn't have a text direction.
2020-03-06 14:14:03 -08:00
Christopher Fujino 2e18cd347e
Fix simctl process exceptions not being caught (#51916) 2020-03-06 13:16:01 -08:00
Dan Field a42d38a2f8
Fix flaky test (#52088) 2020-03-06 13:01:42 -08:00
Jonah Williams e7d70fbf75
Revert "Fix version command for certain git workflows (#52062)" (#52128)
This reverts commit 20bf43b9eb.
2020-03-06 12:58:00 -08:00
Jenn Magder a14ac4e3c8
Bump recommended CocoaPods version to 1.8 (#52071) 2020-03-06 12:14:42 -08:00
Jenn Magder f6a55125d2
Add usage event for failed iOS project migration (#51879) 2020-03-06 12:14:29 -08:00
Zachary Anderson 6c408a0567
Reland: [flutter_tool] Where possible, catch only subtypes of Exception (#52021)
* Reland: [flutter_tool] Where possible, catch only subtypes of Exception

* Add armv7f to getIOSArchForName
2020-03-06 10:22:12 -08:00
Masayuki Ono 2294d75bfa
Fix englishLike2018 bodyText (#49756) 2020-03-06 07:28:38 -08:00
Per Classon 88852731a5
Validate text selection before updating it inside of EditableText (#51410) 2020-03-06 01:26:01 -08:00
Dan Field 20bf43b9eb
Fix version command for certain git workflows (#52062) 2020-03-05 23:51:02 -08:00
Dan Field 4d05ed5deb
Local engine build mode (#52043) 2020-03-05 23:46:02 -08:00
Dan Field 24883e1cf2
Add overrides for FileSystemUtils (#52080) 2020-03-05 22:51:15 -08:00
Jonah Williams d2f889b4f0
[flutter_tools] Reduce context usage in analyze command and tests (#49589) 2020-03-05 17:20:54 -08:00
Jonah Williams bafa03e5b5
[flutter_tools] Remove mocking and simplify Dart target tests (#50688) 2020-03-05 17:19:15 -08:00
Jonah Williams 8872d1d8c4
[flutter_tools] Reland: supports tree-shake-icons for web builds (#52054) 2020-03-05 17:18:44 -08:00
Dan Field 6ad807e3a0
More fixes for randomizing test order (#52060) 2020-03-05 17:14:27 -08:00
Hans Muller a68f96ae3f
Fixed a typo in a FAB build debugPrint message (#52034) 2020-03-05 16:08:44 -08:00
Jenn Magder b8472f25ab
Update Maven URL to https (#52042) 2020-03-05 16:00:34 -08:00
Jonah Williams 35bf5ab5d0
[flutter-tools] add awaits to debug a potential timing issue (#52047) 2020-03-05 15:24:28 -08:00
Jonah Williams b127868db4
[flutter_tools] update web template to remove some absolute paths (#52040) 2020-03-05 13:59:57 -08:00
Jonah Williams ad16823e4c
[flutter_tools] support new SDK structure for sdkmanager (#51980) 2020-03-05 13:59:20 -08:00
Jonah Williams c411f588c6
Revert "[flutter_tools] supports tree-shake-icons for web builds (#51808)" (#52045)
This reverts commit aed961993d.
2020-03-05 13:02:22 -08:00
Jonah Williams ee476a7bd1
Revert "[flutter_tools] Allow providing dart-defines to Android, iOS, macOS builds (#51714)" (#52041)
This reverts commit ee60eeea3e.
2020-03-05 12:51:42 -08:00
Jonah Williams ee60eeea3e
[flutter_tools] Allow providing dart-defines to Android, iOS, macOS builds (#51714) 2020-03-05 12:38:40 -08:00
Jonah Williams aed961993d
[flutter_tools] supports tree-shake-icons for web builds (#51808)
* [flutter_tools] supports tree-shake-icons for web builds

* Update compile.dart

* fix icon_tree_shaker
2020-03-05 12:35:04 -08:00
Jonah Williams 1bf6f0232e
[flutter_tools] support coverage and machine together (#51988) 2020-03-05 12:34:37 -08:00
Jonah Williams bbf913bc4c
[flutter_tools] resolve requests to web directory in debug mode (#51995) 2020-03-05 12:34:03 -08:00
Jonah Williams 374f85c976
[flutter_tools] pin exact build_runner version (#52033) 2020-03-05 11:09:41 -08:00
Alexandre Ardhuin c2ae654ddf
enable avoid_single_cascade_in_expression_statements (#51944) 2020-03-05 08:03:26 +01:00
Flutter GitHub Bot 9c5009b251
[gen_l10n] Escape quote characters in ARB files (#51952) 2020-03-04 20:41:03 -08:00
Flutter GitHub Bot cccbf1f200
Custom onPressed behavior for CloseButton widget (#51925) 2020-03-04 20:36:02 -08:00
Jonah Williams cc52a903a8
[flutter_tools] add status logs to determine where test is getting stuck (#51984) 2020-03-04 18:59:18 -08:00