Commit graph

37393 commits

Author SHA1 Message Date
engine-flutter-autoroll 33db5d7a87
Manual roll Flutter Engine from 6605151b4d0a to a4e62581525c (9 revisions) (#136564)
Manual roll requested by jacksongardner@google.com

Cannot build log URL because revision "a4e62581525c" is invalid: Luci builds of "Mac mac_ios_engine" for a4e62581525c1864a3cd23a67539a3615717eb98 was STARTED

2023-10-13 skia-flutter-autoroll@skia.org Manual roll Dart SDK from c8143a7c026f to 5844b34768ce (1 revision) (flutter/engine#46909)
2023-10-13 skia-flutter-autoroll@skia.org Roll Skia from c9601553b0f3 to 4bc4b4d22866 (1 revision) (flutter/engine#46908)
2023-10-13 skia-flutter-autoroll@skia.org Roll Skia from 8dc8e21a4dec to c9601553b0f3 (3 revisions) (flutter/engine#46907)
2023-10-13 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from SDPa6SfaKvRRSUCij... to 4DwpR2CMJECZJ8EKz... (flutter/engine#46903)
2023-10-13 skia-flutter-autoroll@skia.org Roll Skia from b50d7f9aa743 to 8dc8e21a4dec (4 revisions) (flutter/engine#46902)
2023-10-13 jonahwilliams@google.com [Impeller] fix clear color optimization for large subpasses. (flutter/engine#46887)
2023-10-13 matanlurey@users.noreply.github.com Oops, allow files in opted-in third_party directories. (flutter/engine#46897)
2023-10-13 skia-flutter-autoroll@skia.org Roll Skia from e10e6765480a to b50d7f9aa743 (1 revision) (flutter/engine#46899)
2023-10-13 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from pI1BVH08V0eG0M7sw... to wBb32R567S1alWbfn... (flutter/engine#46898)

Also rolling transitive DEPS:
  fuchsia/sdk/core/linux-amd64 from pI1BVH08V0eG to wBb32R567S1a
  fuchsia/sdk/core/mac-amd64 from SDPa6SfaKvRR to 4DwpR2CMJECZ

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jacksongardner@google.com,jsimmons@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-10-13 23:04:25 +00:00
dependabot[bot] 5f9965cf6f
Bump github/codeql-action from 2.22.0 to 2.22.3 (#136563)
Bumps [github/codeql-action](https://github.com/github/codeql-action) from 2.22.0 to 2.22.3.
<details>
<summary>Changelog</summary>
<p><em>Sourced from <a href="https://github.com/github/codeql-action/blob/main/CHANGELOG.md">github/codeql-action's changelog</a>.</em></p>
<blockquote>
<h1>CodeQL Action Changelog</h1>
<p>See the <a href="https://github.com/github/codeql-action/releases">releases page</a> for the relevant changes to the CodeQL CLI and language packs.</p>
<h2>[UNRELEASED]</h2>
<p>No user facing changes.</p>
<h2>2.22.3 - 13 Oct 2023</h2>
<ul>
<li>Provide an authentication token when downloading the CodeQL Bundle from the API of a GitHub Enterprise Server instance. <a href="https://redirect.github.com/github/codeql-action/pull/1945">#1945</a></li>
</ul>
<h2>2.22.2 - 12 Oct 2023</h2>
<ul>
<li>Update default CodeQL bundle version to 2.15.0. <a href="https://redirect.github.com/github/codeql-action/pull/1938">#1938</a></li>
<li>Improve the log output when an error occurs in an invocation of the CodeQL CLI. <a href="https://redirect.github.com/github/codeql-action/pull/1927">#1927</a></li>
</ul>
<h2>2.22.1 - 09 Oct 2023</h2>
<ul>
<li>Add a workaround for Python 3.12, which is not supported in CodeQL CLI version 2.14.6 or earlier. If you are running an analysis on Windows and using Python 3.12 or later, the CodeQL Action will switch to running Python 3.11. In this case, if Python 3.11 is not found, then the workflow will fail. <a href="https://redirect.github.com/github/codeql-action/pull/1928">#1928</a></li>
</ul>
<h2>2.22.0 - 06 Oct 2023</h2>
<ul>
<li>The CodeQL Action now requires CodeQL version 2.10.5 or later. For more information, see the corresponding changelog entry for CodeQL Action version 2.21.8. <a href="https://redirect.github.com/github/codeql-action/pull/1907">#1907</a></li>
<li>The CodeQL Action no longer runs ML-powered queries. For more information, including details on our investment in AI-powered security technology, see <a href="https://github.blog/changelog/2023-09-29-codeql-code-scanning-deprecates-ml-powered-alerts/">&quot;CodeQL code scanning deprecates ML-powered alerts.&quot;</a> <a href="https://redirect.github.com/github/codeql-action/pull/1910">#1910</a></li>
<li>Fix a bug which prevented tracing of projects using Go 1.21 and above on Linux. <a href="https://redirect.github.com/github/codeql-action/pull/1909">#1909</a></li>
</ul>
<h2>2.21.9 - 27 Sep 2023</h2>
<ul>
<li>Update default CodeQL bundle version to 2.14.6. <a href="https://redirect.github.com/github/codeql-action/pull/1897">#1897</a></li>
<li>We are rolling out a feature in October 2023 that will improve the success rate of C/C++ autobuild. <a href="https://redirect.github.com/github/codeql-action/pull/1889">#1889</a></li>
<li>We are rolling out a feature in October 2023 that will provide specific file coverage information for C and C++, Java and Kotlin, and JavaScript and TypeScript. Currently file coverage information for each of these pairs of languages is grouped together. <a href="https://redirect.github.com/github/codeql-action/pull/1903">#1903</a></li>
<li>Add a warning to help customers avoid inadvertently analyzing the same CodeQL language in multiple matrix jobs. <a href="https://redirect.github.com/github/codeql-action/pull/1901">#1901</a></li>
</ul>
<h2>2.21.8 - 19 Sep 2023</h2>
<ul>
<li>Add a deprecation warning for customers using CodeQL version 2.10.4 and earlier. These versions of CodeQL were discontinued on 12 September 2023 alongside GitHub Enterprise Server 3.6, and will be unsupported by the next minor release of the CodeQL Action. <a href="https://redirect.github.com/github/codeql-action/pull/1884">#1884</a>
<ul>
<li>If you are using one of these versions, please update to CodeQL CLI version 2.10.5 or later. For instance, if you have specified a custom version of the CLI using the 'tools' input to the 'init' Action, you can remove this input to use the default version.</li>
<li>Alternatively, if you want to continue using a version of the CodeQL CLI between 2.9.5 and 2.10.4, you can replace <code>github/codeql-action/*@v2</code> by <code>github/codeql-action/*@v2.21.7</code> in your code scanning workflow to ensure you continue using this version of the CodeQL Action.</li>
</ul>
</li>
<li>Enable the following language aliases when using CodeQL 2.14.4 and later: <code>c-cpp</code> for C/C++ analysis, <code>java-kotlin</code> for Java/Kotlin analysis, and <code>javascript-typescript</code> for JavaScript/TypeScript analysis. <a href="https://redirect.github.com/github/codeql-action/pull/1883">#1883</a></li>
</ul>
<h2>2.21.7 - 14 Sep 2023</h2>
<ul>
<li>Update default CodeQL bundle version to 2.14.5. <a href="https://redirect.github.com/github/codeql-action/pull/1882">#1882</a></li>
</ul>
<h2>2.21.6 - 13 Sep 2023</h2>
<ul>
<li>Better error message when there is a failure to determine the merge base of the code to analysis. <a href="https://redirect.github.com/github/codeql-action/pull/1860">#1860</a></li>
<li>Improve the calculation of default amount of RAM used for query execution on GitHub Enterprise Server. This now reduces in proportion to the runner's total memory to better account for system memory usage, helping to avoid out-of-memory failures on larger runners. This feature is already available to GitHub.com users. <a href="https://redirect.github.com/github/codeql-action/pull/1866">#1866</a></li>
<li>Enable improved file coverage information for GitHub Enterprise Server users. This feature is already available to GitHub.com users. <a href="https://redirect.github.com/github/codeql-action/pull/1867">#1867</a></li>
</ul>
</blockquote>
<p>... (truncated)</p>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="0116bc2df5"><code>0116bc2</code></a> Merge pull request <a href="https://redirect.github.com/github/codeql-action/issues/1947">#1947</a> from github/update-v2.22.3-82ba90b1d</li>
<li><a href="f5a984b113"><code>f5a984b</code></a> Update changelog for v2.22.3</li>
<li><a href="82ba90b1d9"><code>82ba90b</code></a> Merge pull request <a href="https://redirect.github.com/github/codeql-action/issues/1945">#1945</a> from github/henrymercer/authenticate-api-url</li>
<li><a href="34f97d7a16"><code>34f97d7</code></a> Merge pull request <a href="https://redirect.github.com/github/codeql-action/issues/1944">#1944</a> from github/henrymercer/sublanguage-file-coverage-fixes</li>
<li><a href="74442e0a95"><code>74442e0</code></a> Add changelog note</li>
<li><a href="bd32fab74f"><code>bd32fab</code></a> Provide token when downloading from GHES API</li>
<li><a href="b584cf8321"><code>b584cf8</code></a> Merge pull request <a href="https://redirect.github.com/github/codeql-action/issues/1922">#1922</a> from github/nora/add-commit-sha-to-database-upload</li>
<li><a href="761255a4a3"><code>761255a</code></a> Merge pull request <a href="https://redirect.github.com/github/codeql-action/issues/1943">#1943</a> from github/mergeback/v2.22.2-to-main-d90b8d79</li>
<li><a href="346d5c4b07"><code>346d5c4</code></a> Test sub-language file coverage in file baseline information check</li>
<li><a href="5950d13564"><code>5950d13</code></a> Enable sub-language file coverage in <code>interpret-results</code> too</li>
<li>Additional commits viewable in <a href="2cb752a87e...0116bc2df5">compare view</a></li>
</ul>
</details>
<br />

[![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=github/codeql-action&package-manager=github_actions&previous-version=2.22.0&new-version=2.22.3)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.

---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency
- `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

</details>
2023-10-13 22:35:18 +00:00
Jonah Williams ec12ba2875
[Impeller] GPU frame timings summarization. (#136408)
Allow processing GPU start and end events to get processed by flutter driver. To figure out whether or not this works we'll ship in on CI :)
2023-10-13 22:18:37 +00:00
Daniel Chevalier ac095ed393
Changes WidgetInspector to use valuenotifier instead of a force rebuild for (#131634)
![](https://media.giphy.com/media/qriH9W51oLsL6/giphy.gif)
Fixes https://github.com/flutter/devtools/issues/6014

Change the forceRebuild behaviour of the WidgetInspector to use
ValueListenableBuilders instead. This should help resolve heavy rebuilds
when the widgetInspectorOverride value changes.
2023-10-13 17:07:57 -04:00
engine-flutter-autoroll be45c4ca41
Roll Flutter Engine from 799e8de11c12 to 6605151b4d0a (3 revisions) (#136558)
799e8de11c...6605151b4d

2023-10-13 dnfield@google.com [Impeller] Only allow Impeller in flutter_tester if vulkan is enabled. (flutter/engine#46895)
2023-10-13 skia-flutter-autoroll@skia.org Roll Skia from 4783e1146146 to e10e6765480a (1 revision) (flutter/engine#46893)
2023-10-13 233583+mossmana@users.noreply.github.com Replace deprecated [UIScreen mainScreen] in FlutterView.mm (flutter/engine#46802)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-10-13 20:58:43 +00:00
engine-flutter-autoroll cff36c9922
Roll Flutter Engine from 93f02f7237db to 799e8de11c12 (6 revisions) (#136553)
93f02f7237...799e8de11c

2023-10-13 skia-flutter-autoroll@skia.org Roll Skia from 643d74cf4e0b to 4783e1146146 (2 revisions) (flutter/engine#46890)
2023-10-13 skia-flutter-autoroll@skia.org Roll Dart SDK from 95e2ecee106a to c8143a7c026f (1 revision) (flutter/engine#46889)
2023-10-13 skia-flutter-autoroll@skia.org Roll Skia from 77e73bb2744b to 643d74cf4e0b (2 revisions) (flutter/engine#46888)
2023-10-13 derekx@google.com Use --timeline_recorder=systrace instead of --systrace_timeline (flutter/engine#46884)
2023-10-13 erikgerman917@gmail.com fixed AutofillHints.middleName tanslation for web. (flutter/engine#46429)
2023-10-13 skia-flutter-autoroll@skia.org Roll Skia from 3acf82dcc479 to 77e73bb2744b (2 revisions) (flutter/engine#46886)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-10-13 19:24:26 +00:00
Polina Cherkasova 9f512d7037
Mark leak in NativeCodec.getNextFrame. (#136514) 2023-10-13 11:57:57 -07:00
Polina Cherkasova 2ea541aca9
Stop skipping leaks in the test. (#136512) 2023-10-13 11:55:58 -07:00
Christopher Fujino c353e641ad
run tests under dev/tools as part of framework-misc and get them passing (#136501)
part of https://github.com/flutter/flutter/issues/136500

this should not affect any production code, it merely runs the tests on CI and makes the changes needed to get them passing.
2023-10-13 18:48:43 +00:00
engine-flutter-autoroll 7d3b7d147e
Roll Flutter Engine from 60968c892649 to 93f02f7237db (5 revisions) (#136546)
60968c8926...93f02f7237

2023-10-13 30870216+gaaclarke@users.noreply.github.com [Impeller] Started throwing errors if dart:ui/Image.toByteData fails (flutter/engine#46738)
2023-10-13 skia-flutter-autoroll@skia.org Roll Skia from e566db061ce8 to 3acf82dcc479 (2 revisions) (flutter/engine#46883)
2023-10-13 kjlubick@users.noreply.github.com Fix forward declare and some deprecated enums (flutter/engine#46882)
2023-10-13 skia-flutter-autoroll@skia.org Roll Skia from c640eeed2695 to e566db061ce8 (1 revision) (flutter/engine#46881)
2023-10-13 kjlubick@users.noreply.github.com Update to use GrDirectContexts::MakeVulkan (flutter/engine#46878)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-10-13 18:43:37 +00:00
Victoria Ashworth 9c791f465e
Remove bringup from tests and move some back to presubmit. Reorganize TESTOWNERS. (#136498)
We renamed a few tests and therefore had to run them in bringup first
(https://github.com/flutter/flutter/pull/136463). This removes bringup
and moves some of them back to presubmit. Also, reorganize TESTOWNERS
since they're running on hostonly now.

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
2023-10-13 10:12:02 -07:00
droidbg 86c9b8ea8c
[leak-tracking] Add leak tracking in test/rendering -2 (#136310) 2023-10-13 10:08:11 -07:00
droidbg 8f14104c7d
[leak-tracking] Add leak tracking in test/rendering -3 (#136308) 2023-10-13 10:06:55 -07:00
engine-flutter-autoroll b808e5c247
Roll Packages from 93c3f69fa6c6 to fd84e6545a45 (3 revisions) (#136538)
93c3f69fa6...fd84e6545a

2023-10-12 48316647+yamhoresh@users.noreply.github.com [go_router] Fix missing build parameter in type-safe routes topic documentation (flutter/packages#5040)
2023-10-12 engine-flutter-autoroll@skia.org Roll Flutter (stable) from ead455963c to 2f708eb839 (1 revision) (flutter/packages#5134)
2023-10-12 goderbauer@google.com [web_benchmarks] Bump process version constraints (flutter/packages#5122)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-10-13 15:42:16 +00:00
engine-flutter-autoroll e88bbfbc15
Roll Flutter Engine from f9aed0267352 to 60968c892649 (1 revision) (#136539)
f9aed02673...60968c8926

2023-10-13 zanderso@users.noreply.github.com Don't use objcopy to embed Android icudtl (flutter/engine#46862)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-10-13 15:42:13 +00:00
engine-flutter-autoroll 3865e49a68
Roll Flutter Engine from e94f191d0ba4 to f9aed0267352 (2 revisions) (#136537)
e94f191d0b...f9aed02673

2023-10-13 skia-flutter-autoroll@skia.org Roll Dart SDK from 54ef02480719 to 95e2ecee106a (1 revision) (flutter/engine#46877)
2023-10-13 skia-flutter-autoroll@skia.org Roll Skia from f27c0f222320 to c640eeed2695 (1 revision) (flutter/engine#46874)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-10-13 14:44:24 +00:00
engine-flutter-autoroll b4a67ce690
Roll Flutter Engine from 40ddc30b9d6c to e94f191d0ba4 (1 revision) (#136532)
40ddc30b9d...e94f191d0b

2023-10-13 skia-flutter-autoroll@skia.org Roll ICU from 995db880cff2 to a622de35ac31 (1 revision) (flutter/engine#46873)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-10-13 13:06:07 +00:00
engine-flutter-autoroll 0b15c3e00a
Roll Flutter Engine from 5acdac549034 to 40ddc30b9d6c (1 revision) (#136526)
5acdac5490...40ddc30b9d

2023-10-13 skia-flutter-autoroll@skia.org Roll Dart SDK from 849253fd69b6 to 54ef02480719 (2 revisions) (flutter/engine#46871)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-10-13 10:32:23 +00:00
engine-flutter-autoroll 4603314cd2
Roll Flutter Engine from b59d779d4f7f to 5acdac549034 (2 revisions) (#136523)
b59d779d4f...5acdac5490

2023-10-13 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from XnH2CtqEH7byTHna7... to SDPa6SfaKvRRSUCij... (flutter/engine#46868)
2023-10-13 skia-flutter-autoroll@skia.org Roll Skia from faad330e7120 to f27c0f222320 (1 revision) (flutter/engine#46869)

Also rolling transitive DEPS:
  fuchsia/sdk/core/mac-amd64 from XnH2CtqEH7by to SDPa6SfaKvRR

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-10-13 09:02:27 +00:00
engine-flutter-autoroll d479b5e2c6
Roll Flutter Engine from dc30b4cd0239 to b59d779d4f7f (2 revisions) (#136521)
dc30b4cd02...b59d779d4f

2023-10-13 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from QLiomHC9D-GWh_gyK... to pI1BVH08V0eG0M7sw... (flutter/engine#46867)
2023-10-13 skia-flutter-autoroll@skia.org Roll Skia from aee708412bec to faad330e7120 (1 revision) (flutter/engine#46866)

Also rolling transitive DEPS:
  fuchsia/sdk/core/linux-amd64 from QLiomHC9D-GW to pI1BVH08V0eG

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-10-13 07:35:07 +00:00
engine-flutter-autoroll 962fcd6243
Roll Flutter Engine from 31ec5e31a914 to dc30b4cd0239 (1 revision) (#136518)
31ec5e31a9...dc30b4cd02

2023-10-13 skia-flutter-autoroll@skia.org Roll Skia from bf557aeaaef8 to aee708412bec (1 revision) (flutter/engine#46865)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-10-13 06:50:14 +00:00
engine-flutter-autoroll bae67d96f0
Roll Flutter Engine from 7a6172e9d34c to 31ec5e31a914 (1 revision) (#136516)
7a6172e9d3...31ec5e31a9

2023-10-13 skia-flutter-autoroll@skia.org Roll Dart SDK from b0d65ad14354 to 849253fd69b6 (1 revision) (flutter/engine#46864)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-10-13 06:05:16 +00:00
engine-flutter-autoroll 43d8a133ac
Roll Flutter Engine from ffb3b5b67f61 to 7a6172e9d34c (1 revision) (#136515)
ffb3b5b67f...7a6172e9d3

2023-10-13 zanderso@users.noreply.github.com Revert "Remove the frontend server wrapper" (flutter/engine#46863)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-10-13 05:25:21 +00:00
Kostia Sokolovskyi 7d79472531
SearchAnchor should dispose created FocusNode and SearchController. (#136120) 2023-10-12 19:35:46 -07:00
engine-flutter-autoroll e0b8ec0782
Roll Flutter Engine from dee90f16aacd to ffb3b5b67f61 (2 revisions) (#136506)
dee90f16aa...ffb3b5b67f

2023-10-13 skia-flutter-autoroll@skia.org Roll Dart SDK from 34c06f0bcb29 to b0d65ad14354 (3 revisions) (flutter/engine#46859)
2023-10-12 jason-simmons@users.noreply.github.com Temporarily remove the runs of the engine Dart tests with Impeller enabled (flutter/engine#46854)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-10-13 02:00:26 +00:00
Todd Volkert bc688cf0df
Make constraints a covariant argument in RenderBox.computeDryLayout() (#136432)
Some render box subclasses have a specific layout contract that is tightly coupled with other render box subclasses (e.g. two private classes in a local project file). In these cases, it is also possible that they use a constraints object that is a subclass of `BoxConstraints`. To allow for this, this change makes the `constraints` argument to `RenderBox.computeDryLayout()` a covariant argument.

For completeness' sake, this updates the other render objects in the rendering package to also use the covariant keyword for this argument.
2023-10-13 01:10:29 +00:00
Yegor 0f082889a8
[web] remove loading indicator in -d web-server builds (#136482)
Fixes https://github.com/flutter/flutter/issues/135226
2023-10-12 23:45:06 +00:00
engine-flutter-autoroll 5f796b2950
Roll Flutter Engine from cb37ebc81939 to dee90f16aacd (3 revisions) (#136502)
cb37ebc819...dee90f16aa

2023-10-12 skia-flutter-autoroll@skia.org Roll Skia from 8b110fd65de9 to bf557aeaaef8 (1 revision) (flutter/engine#46853)
2023-10-12 uysalere@gmail.com [fuchsia] Add fatal error for Vulkan failure (flutter/engine#46831)
2023-10-12 mdebbar@google.com [web] Stop using `flutterViewEmbedder` for platform views (flutter/engine#46046)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-10-12 23:45:03 +00:00
engine-flutter-autoroll 856475c0e4
Roll Flutter Engine from 7eb20a09073e to cb37ebc81939 (2 revisions) (#136492)
7eb20a0907...cb37ebc819

2023-10-12 skia-flutter-autoroll@skia.org Roll Skia from 222fe6b9b0eb to 8b110fd65de9 (1 revision) (flutter/engine#46852)
2023-10-12 skia-flutter-autoroll@skia.org Roll Skia from fdcbbc4d5c25 to 222fe6b9b0eb (2 revisions) (flutter/engine#46849)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-10-12 22:59:09 +00:00
xubaolin 3f722c1442
[SingleChildScrollView] Correct the offset pixels if it is out of range during layout (#136239)
Fixes https://github.com/flutter/flutter/issues/105733
FIxes https://github.com/flutter/flutter/issues/135865

The above two issues will not occur on the `ListView` widget, so after analyzing their differences, it was found that the `SingleChildScrollView` pixels were not corrected according to the content dimensions during layout.

### ListView correct the pixels codes
5dfd78c2e3/packages/flutter/lib/src/rendering/viewport.dart (L1462-L1465)

We should correct the pixels to prevent the physics ballistic simulations.

This change makes them have the same behavior.
2023-10-12 21:25:09 +00:00
Greg Spencer 22b0a62a0c
Allow TapRegion to consume tap events (#136305)
## Description

In order for `MenuAnchor` menus to be able to not pass on the taps that close their menus, `TapRegion` needed a way to consume them.  This change adds a flag to the `TapRegion`, `consumeOutsideTap` that will consume taps that occur outside of the region if the flag is set (it is false by default). The same flag is added to `MenuAnchor` to allow selecting the behavior for menus.

`TapRegion` consumes the tap event by registering with the gesture arena and immediately resolving the tap as accepted if any regions in a group have `consumeOutsideTap` set to true.

This PR also deprecates `MenuAnchor.anchorTapClosesMenu`, since it is a much more limited version of the same feature that only applied to the anchor itself, and even then only applied to closing the menu, not passing along the tap.  The same functionality can now be implemented by handling a tap on the anchor widget and checking to see if the menu is open before closing it.

## Related Issues
 - https://github.com/flutter/flutter/issues/135327

## Tests
 - Added tests for `TapRegion` to make sure taps are consumed properly.
2023-10-12 21:04:41 +00:00
Michael Goderbauer 7ea5536f12
Fix doc TODO (#136485)
Underlying bug (https://github.com/dart-lang/dartdoc/issues/2276) has been fixed a while ago.
2023-10-12 20:52:51 +00:00
engine-flutter-autoroll 1b797baf0d
Roll Flutter Engine from f02006736390 to 7eb20a09073e (4 revisions) (#136478)
f020067363...7eb20a0907

2023-10-12 skia-flutter-autoroll@skia.org Roll Skia from 1d134a8f3ae2 to fdcbbc4d5c25 (7 revisions) (flutter/engine#46844)
2023-10-12 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from 8AXhoo-MMME8NMKt0... to XnH2CtqEH7byTHna7... (flutter/engine#46843)
2023-10-12 chinmaygarde@google.com [Impeller] Specify default border color for texture wrap mode that clamps. (flutter/engine#46806)
2023-10-12 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from giQtXxdSj6NdIViCw... to QLiomHC9D-GWh_gyK... (flutter/engine#46838)

Also rolling transitive DEPS:
  fuchsia/sdk/core/linux-amd64 from giQtXxdSj6Nd to QLiomHC9D-GW
  fuchsia/sdk/core/mac-amd64 from 8AXhoo-MMME8 to XnH2CtqEH7by

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-10-12 20:16:25 +00:00
Michael Goderbauer 437361321a
Bump file,process,process_runner (#136418) 2023-10-12 13:05:24 -07:00
engine-flutter-autoroll 90b24fb5b1
Roll Flutter Engine from 664657d32992 to f02006736390 (3 revisions) (#136467)
664657d329...f020067363

2023-10-12 zanderso@users.noreply.github.com Remove the frontend server wrapper (flutter/engine#46440)
2023-10-12 jason-simmons@users.noreply.github.com Roll SwiftShader to include a fix required by the latest Clang toolchain (flutter/engine#46803)
2023-10-12 skia-flutter-autoroll@skia.org Roll Skia from 2dd1579c6921 to 1d134a8f3ae2 (5 revisions) (flutter/engine#46824)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-10-12 17:54:12 +00:00
huycozy e8a0cf3ae8
Fix PageView API doc sample fails on Desktop and Web (#135910)
### Description

This PR aims to improve/fix the PageView API doc sample for Web and Desktop platforms. On these platforms, mouse dragging gestures do not provide natural behavior similar to other desktop applications. This PR will add navigation buttons (indicators) so users can interact with the demo.

### Related issue

Fixes https://github.com/flutter/flutter/issues/135188

### Demo video

https://github.com/flutter/flutter/assets/104349824/0f9c60bd-8b18-404e-b5b6-1d594604de31
2023-10-12 17:28:13 +00:00
Derek Xu 406c4dbf77
Add --trace-to-file option to flutter run (#135713) 2023-10-12 13:23:52 -04:00
Christopher Fujino 9751fe6449
[flutter_tools] handle ERROR_INVALID_FUNCTION when trying to symlink across drives (#136424)
~~Fixes https://github.com/flutter/flutter/issues/136321~~

edit by @andrewkolos: Fixes https://github.com/flutter/flutter/issues/66224
2023-10-12 17:15:45 +00:00
pdblasi-google fa827eb2aa
Updates references to finders.dart in controller.dart to use a namespace. (#136423)
Updates references to `finders.dart` in `controller.dart` to use a namespace. This enables us to make use of `finders.dart#find` in `SemanticsController` without anything being shadowed.

Fixes #136421
2023-10-12 17:02:32 +00:00
Victoria Ashworth d6ec0cf564
Change some tests to run on macs without iOS devices attached (#136463)
Some tests have been running on devicelab bots with iOS devices attached, however, they don't require an iOS device. So moving them to run on bots without iOS devices.

Fixes https://github.com/flutter/flutter/issues/136415.
2023-10-12 16:52:16 +00:00
engine-flutter-autoroll ee7e41fec0
Roll Packages from 4b483f242936 to 93c3f69fa6c6 (9 revisions) (#136461)
4b483f2429...93c3f69fa6

2023-10-12 goderbauer@google.com [shared_preferences] update file version constraints (flutter/packages#5121)
2023-10-12 supercionci@hotmail.it [cross_file] Improved documentation about ignored parameters in IO module. (flutter/packages#4416)
2023-10-11 41873024+droidbg@users.noreply.github.com [in_app_purchase] [#135759] Fix. doc reference finishPurchase to completePurchase. (flutter/packages#5081)
2023-10-10 zeucxb@gmail.com Update repo README issues link (flutter/packages#5106)
2023-10-10 43643339+nohli@users.noreply.github.com [flutter_markdown] Fix typo in readme (flutter/packages#5096)
2023-10-10 43054281+camsim99@users.noreply.github.com [camerax] Implements torch mode (flutter/packages#4903)
2023-10-10 25266387+Leptopoda@users.noreply.github.com [shared_preferences] fix documentation wording (flutter/packages#4986)
2023-10-10 katelovett@google.com [two_dimensional_scrollables] Fix paint bug when rows/columns are pinned and axes are reversed (flutter/packages#5038)
2023-10-10 engine-flutter-autoroll@skia.org Roll Flutter from f52fe4f7e5 to 83134ac7e4 (25 revisions) (flutter/packages#5104)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-10-12 16:13:06 +00:00
Victoria Ashworth ddc9b40a98
Fix typo in function name (#136273)
Rename `removeIOSimulator` to `removeIOSSimulator`.
2023-10-12 15:53:00 +00:00
Taha Tesser f65dd3bac0
Fix chip widgets don't the apply provided iconTheme (#135751)
fixes [`Chip.iconTheme` does not apply the icon theme](https://github.com/flutter/flutter/issues/111828)

### Description
- Fix chip widgets that don't utilize the provided `iconTheme`.
- Prevent `iconTheme` with just color from overriding the default icon size.
- Add some missing M3 tests for the chip and chip theme properties.

### Code sample

<details>
<summary>expand to view the code sample</summary> 

```dart
import 'package:flutter/material.dart';

void main() => runApp(const MyApp());

class MyApp extends StatelessWidget {
  const MyApp({super.key});

  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      debugShowCheckedModeBanner: false,
      theme: ThemeData(useMaterial3: true),
      home: const Example(),
    );
  }
}

class Example extends StatefulWidget {
  const Example({super.key});

  @override
  State<Example> createState() => _ExampleState();
}

class _ExampleState extends State<Example> {
  final bool _isEnable = true;

  @override
  Widget build(BuildContext context) {
    return Scaffold(
      body: Center(
        child: Column(
          mainAxisAlignment: MainAxisAlignment.spaceEvenly,
          children: <Widget>[
            RawChip(
              iconTheme: const IconThemeData(color: Colors.amber),
              avatar: const Icon(Icons.favorite_rounded),
              label: const Text('RawChip'),
              onPressed: () {},
              isEnabled: _isEnable,
            ),
            const Chip(
              iconTheme: IconThemeData(color: Colors.amber),
              avatar: Icon(Icons.favorite_rounded),
              label: Text('Chip'),
              // onDeleted: () {},
            ),
            FilterChip(
              iconTheme: const IconThemeData(color: Colors.amber),
              avatar: const Icon(Icons.favorite_rounded),
              label: const Text('FilterChip'),
              selected: false,
              onSelected: _isEnable ? (bool value) {} : null,
            ),
            InputChip(
              iconTheme: const IconThemeData(color: Colors.amber),
              avatar: const Icon(Icons.favorite_rounded),
              label: const Text('InputChip'),
              isEnabled: _isEnable,
              onPressed: () {},
            ),
            ActionChip(
              iconTheme: const IconThemeData(color: Colors.amber),
              avatar: const Icon(Icons.favorite_rounded),
              label: const Text('ActionChip'),
              onPressed: _isEnable ? () {} : null,
            ),
            ChoiceChip(
              iconTheme: const IconThemeData(color: Colors.amber),
              avatar: const Icon(Icons.favorite_rounded),
              label: const Text('ChoiceChip'),
              selected: false,
              onSelected: _isEnable ? (bool value) {} : null,
            ),
          ],
        ),
      ),
      floatingActionButton: FloatingActionButton(
        onPressed: () {},
        child: const Icon(Icons.add),
      ),
    );
  }
}

```

</details>

### Before
![Screenshot 2023-09-29 at 16 59 39](https://github.com/flutter/flutter/assets/48603081/4bc32032-cff3-4237-812f-86f17ed95337)

### After

![Screenshot 2023-09-29 at 16 55 24](https://github.com/flutter/flutter/assets/48603081/05a1fc52-fb31-4790-a840-18f2e9718241)
2023-10-12 14:17:56 +00:00
engine-flutter-autoroll fad8bda64a
Roll Flutter Engine from 33a6d21b3364 to 664657d32992 (2 revisions) (#136450)
33a6d21b33...664657d329

2023-10-12 skia-flutter-autoroll@skia.org Roll Dart SDK from 9afac395dfb1 to 34c06f0bcb29 (1 revision) (flutter/engine#46820)
2023-10-12 skia-flutter-autoroll@skia.org Roll ICU from 985b9a6f70e1 to 995db880cff2 (1 revision) (flutter/engine#46818)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-10-12 11:40:22 +00:00
engine-flutter-autoroll b89e1df7ac
Roll Flutter Engine from d00fabf0b919 to 33a6d21b3364 (5 revisions) (#136442)
d00fabf0b9...33a6d21b33

2023-10-12 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from Qjz4zE4Oe0AO_7T3f... to 8AXhoo-MMME8NMKt0... (flutter/engine#46814)
2023-10-12 skia-flutter-autoroll@skia.org Roll Skia from 9f5080c58aac to 2dd1579c6921 (1 revision) (flutter/engine#46813)
2023-10-12 skia-flutter-autoroll@skia.org Roll Dart SDK from db2465f106ad to 9afac395dfb1 (1 revision) (flutter/engine#46812)
2023-10-12 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from hMA99PoacaRZVXHgr... to giQtXxdSj6NdIViCw... (flutter/engine#46811)
2023-10-12 skia-flutter-autoroll@skia.org Roll Skia from ff3c2e3d45bd to 9f5080c58aac (1 revision) (flutter/engine#46809)

Also rolling transitive DEPS:
  fuchsia/sdk/core/linux-amd64 from hMA99PoacaRZ to giQtXxdSj6Nd
  fuchsia/sdk/core/mac-amd64 from Qjz4zE4Oe0AO to 8AXhoo-MMME8

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-10-12 08:07:21 +00:00
engine-flutter-autoroll c0d19ca561
Roll Flutter Engine from 05e26c1b2c79 to d00fabf0b919 (5 revisions) (#136431)
05e26c1b2c...d00fabf0b9

2023-10-12 skia-flutter-autoroll@skia.org Roll Skia from 924df8d87766 to ff3c2e3d45bd (1 revision) (flutter/engine#46807)
2023-10-11 skia-flutter-autoroll@skia.org Roll Dart SDK from 0732be6b823a to db2465f106ad (8 revisions) (flutter/engine#46797)
2023-10-11 bdero@google.com [Impeller] Use triangle strips to dedupe rectangle vertices. (flutter/engine#46610)
2023-10-11 bdero@google.com [Impeller] Bump impeller-cmake (flutter/engine#46764)
2023-10-11 skia-flutter-autoroll@skia.org Roll Skia from 2459d71707e0 to 924df8d87766 (7 revisions) (flutter/engine#46798)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-10-12 03:33:07 +00:00
Qun Cheng 6388e3d727
Floating SnackBar should always float above the bottom widgets (#136411)
Fixes #136162

This PR is to fix the floating `SnackBar` issue so that when the top of the bottom bar is higher than the top of the FAB, the snack bar will still float and not be clipped.

| Before fix | After fix |
|--------|--------|
| ![Screenshot 2023-10-11 at 1 54 30 PM](https://github.com/flutter/flutter/assets/36861262/dbe02312-1a80-4532-9bad-a8f162a6a942) | ![Screenshot 2023-10-11 at 1 54 52 PM](https://github.com/flutter/flutter/assets/36861262/68211de0-f04f-4b1a-b554-baf6a8e2f947)
 |
2023-10-12 01:17:07 +00:00
Bryan Olivares d9c0d3ae51
SearchBar should listen to changes to the SearchController and update suggestions on change (#134337)
This PR is adding a listener to the `SearchController`, so that the `suggestionBuilder` can be updated when the `SearchController` changes. 

Another method we can possibly do is  have an update method on `SearchController`, so that the user can manually update the suggestions instead of us doing it automatically.

Fixes #132161
2023-10-12 00:55:38 +00:00
Kevin Moore 3e60999b11
Allow latest pkg:material_color_utilities (#132445)
* Allow latest pkg:material_color_utilities
* Bump other dependencies to their latest - including pkg:web
2023-10-11 23:57:16 +00:00
engine-flutter-autoroll 695825419d
Roll Flutter Engine from 8bf1460892c6 to 05e26c1b2c79 (3 revisions) (#136422)
8bf1460892...05e26c1b2c

2023-10-11 jason-simmons@users.noreply.github.com Run the binary size treemap script from the buildroot directory (flutter/engine#46740)
2023-10-11 dnfield@google.com [Impeller] flutter_tester --enable-impeller (flutter/engine#46389)
2023-10-11 jacksongardner@google.com Switch to Chrome For Testing instead of Chromium (flutter/engine#46683)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-10-11 23:52:06 +00:00