Commit graph

14295 commits

Author SHA1 Message Date
Todd Volkert 323373d333
Add blank newline after Dartdoc bulleted list. (#33403)
This also fixes up some indentation in some
bulleted lists.

https://github.com/dart-lang/dartdoc/issues/1969
2019-05-27 12:27:28 -07:00
Todd Volkert ddef473e07
Add clarification in Animation's listener API docs (#33363) 2019-05-27 10:17:09 -07:00
Jonah Williams 75d75bfaec
fix relative paths and snapshot logic in tool (#33283) 2019-05-25 19:47:17 -07:00
Jonah Williams 582c5587cd
make sure we build test targets too (#33284) 2019-05-25 19:46:44 -07:00
stuartmorgan 81c38b22cb
Implement macOS support in flutter doctor (#33277)
Splits Xcode validation out of the iOS validator and into a stand-alone
validator, and groups the CocoaPods validator with that top-level
validator instead of the iOS validator. iOS now validates only the
iOS-specific tools (e.g., ideviceinstaller).

Reorganizes many of the associated clases so that those that are used by
both macOS and iOS live in macos/ rather than ios/. Moves some
validators to their own files as part of the restructuring.

This is the macOS portion of #31368
2019-05-24 22:51:02 -04:00
Chris Bracken 156b4220b4
Americanise spellings (#33323)
Updates documentation and non-public API to use American spellings for
consistency with the rest of the codebase.

No changes to behaviour... other than how it's spelt.
2019-05-24 19:13:02 -07:00
Chris Bracken 4d9923201b
Correct typos (#33322)
Corects a bnuch of typeos throuhgout teh Fluter codebsae.

Made use of the `misspell` tool:
https://github.com/client9/misspell
2019-05-24 19:12:45 -07:00
stuartmorgan 0f6e4e6190
Add macosPrefix to the pubspec schema for plugins (#33287)
Adds a new macosPrefix, which serves the same purpose as iosPrefix but
for macOS plugins.

It is not yet used by the tooling, but this allows for plugins to start
to be written using it in preparation for tooling support for plugins.

Part of #32718
2019-05-24 15:39:48 -04:00
Todd Volkert daa7060882
Add stateful_widget_animation snippet template (#33295) 2019-05-24 09:24:16 -07:00
Shi-Hao Hong 9d52085344
ExpandIcon Custom Colors (#33148)
* Implement ExpandIcon custom color, expandedColor, and disabledColor

* Update to use pumpAndSettle instead of hard-coded duration

* Update colors to unfocused state, added dark mode test to active state

* Fix Colors.white30 doc opacity value

* Add links to Material Design specifications to color, expandedColor and disabledColor

* Update API docs to reference dark theme material page
2019-05-24 09:06:23 -07:00
Shi-Hao Hong 73798a1592
Explain hairline rendering in BorderSide.width docs (#33226) 2019-05-24 09:04:21 -07:00
Greg Spencer c99ed8fed9
Add unpublish_package script. (#33267)
This adds a maintenance script that will allow us to "unpublish" a release: basically remove it from the cloud storage so that we're no longer serving it from the website.

Obviously, gsutil access to the cloud storage server is required for this to function.
2019-05-24 08:56:52 -07:00
Zachary Anderson f5827f0f07
[flutter_tool] Improve Fuchsia 'run' tests (#33263) 2019-05-24 07:48:41 -07:00
Jonah Williams 7ec9a6fa72
no longer necessary with ddc fix (#33271) 2019-05-23 23:49:41 -07:00
Emmanuel Garcia 12a0e475e2
Make paths absolute in settings.gradle (#33228) 2019-05-23 23:32:11 -07:00
Jonah Williams 1bd85dd6c2
disable flaky devfs test (#33285) 2019-05-23 17:05:29 -07:00
liyuqian 552e74770d
Mark non-flaky test as such (#33269) 2019-05-23 12:39:55 -07:00
Todd Volkert c6129b4e85
Add cast to prepare for package:file update (#33268) 2019-05-23 12:33:24 -07:00
Todd Volkert bc7bc94083
Slight clarification in the ImageCache docs (#33195)
It was easy to miss the reference to the top-level `imageCache`
property before.  This calls out the property a little more
explicitly.
2019-05-23 10:29:07 -07:00
Paul Berry 9a16900ed1
Pass an async callback to testWidgets. (#33260)
The dart analyzer fails to warn about missing returns in function expressions due to a bug that has been
fixed but not yet rolled into Flutter (see
https://dart-review.googlesource.com/c/sdk/+/100301).  So it failed to catch that https://github.com/flutter/flutter/pull/33217 accidentally introduced a call to `testWidgets` that passed it a synchronous callback.
2019-05-23 10:17:22 -07:00
Fedor Korotkov 4bc8e9c00e [ci] use Windows Container 2019 (#33248)
They are newer and faster to start
2019-05-23 09:35:58 -07:00
Justin McCandless 6031c56d4c
Material Long Press Text Handle Flash (#32911)
Fix a bug where holding down on text selection caused the handles to flash. The fix was to only update selection when it actually changed.
2019-05-23 08:15:59 -07:00
Devon Carew 0e8720e926
use the --disable-server-feature-completion cli arg to the analysis server (#33232) 2019-05-23 07:48:23 -07:00
Todd Volkert be2918ff30
Fix ImageStreamListener's hashCode & operator== (#33217)
I forgot to add `onChunk` to them in #33092
2019-05-22 18:14:01 -07:00
stuartmorgan ef9866bf27
Build macOS via workspace, rather than project (#33198)
This is necesasry to integrate CocoaPods, since CocoaPods operates
primarily on the workspace rather than the project.
2019-05-22 19:58:29 -04:00
engine-flutter-autoroll 2f6a986675
Roll engine 64f18f2cb686..8dc3a4cde207 (5 commits) (#33219)
64f18f2cb6...8dc3a4cde2

git log 64f18f2cb686649e7ba330e8254053f13d1526cd..8dc3a4cde2075a4f5458fd0eb199627f5124508d --no-merges --oneline
8dc3a4cde Add missing top level to stub_ui (flutter/engine#9060)
6299af30a remove over-optimistic assert (flutter/engine#9045)
0308a1c4a Roll src/third_party/dart fde6a5917e..e3edfd36b2 (14 commits)
1bce77992 Roll src/third_party/skia e63b01b364a0..f77dbd04b926 (19 commits) (flutter/engine#9057)
4dbb9ba38 Expose pointer type and buttons in embedder.h (flutter/engine#9034)

The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff (garyq@google.com), and stop
the roller if necessary.
2019-05-22 19:58:17 -04:00
Jonah Williams 018df5ecdd
manual engine roll (#33224) 2019-05-22 16:12:02 -07:00
Jonah Williams a30ffb60ad
Revert "Clean up some flutter_tools tests and roll dependencies (#33163)" (#33206) 2019-05-22 12:20:02 -07:00
Jason Simmons a6f1c095dc
Engine roll 75963dbb0ba6..64f18f2cb686 (#33157) 2019-05-22 10:19:08 -07:00
Emmanuel Garcia dc28ba8919
Remove colon from Gradle task name since it's deprecated (#33191) 2019-05-22 09:58:08 -07:00
Ian Hickson e5f81e1048
Clean up some flutter_tools tests and roll dependencies (#33163)
* Clean up some flutter_tools tests

* Remove arbitrary retry that happens even for fundamental errors, and generally clean up _DevFSHttpWriter.

* Update dependencies (requires fixes; see next commit)

* Fixes for new dependencies.
2019-05-22 09:31:37 -07:00
engine-flutter-autoroll cb576181e9
303a3910d fix dartdevc build (flutter/engine#9036) (#33155)
75963dbb0b...303a3910d3

git log 75963dbb0ba62a9dbd7024e568fbe5d499d00d7d..303a3910d398ee48a3411108688ebd5ccc101e8a --no-merges --oneline
303a3910d fix dartdevc build (flutter/engine#9036)

The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff (garyq@google.com), and stop
the roller if necessary.
2019-05-21 20:12:18 -04:00
Zachary Anderson 2eee3f3283
[flutter_tool] Don't look for Fuchsia artifacts on Windows (#33146) 2019-05-21 16:12:27 -07:00
engine-flutter-autoroll ecc7793c30
75963dbb0 Roll src/third_party/skia 12710911dcc2..e63b01b364a0 (11 commits) (flutter/engine#9035) (#33151)
ee5915fbb0...75963dbb0b

git log ee5915fbb0862ec42754ec35fe9ada03871ae60b..75963dbb0ba62a9dbd7024e568fbe5d499d00d7d --no-merges --oneline
75963dbb0 Roll src/third_party/skia 12710911dcc2..e63b01b364a0 (11 commits) (flutter/engine#9035)

The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff (garyq@google.com), and stop
the roller if necessary.
2019-05-21 19:09:17 -04:00
Mattia Crovero 73dbca4142 Added ScrollController to TextField (#32620)
scrollController param on TextField and CupertinoTextField
2019-05-21 16:07:55 -07:00
Todd Volkert 27d3c2fcc8
Add support for ImageStreamListener.onChunk() (#33092)
This is another step towards supporting image loading
progress notification at the widgets layer.

This adds an `ImageChunkEvent` class along with associated
`ImageChunkListener` callback signature and an `onChunk`
property to `ImageStreamListener`. The events serve to
notify registered listeners when byte chunks are received
while loading an image.

https://github.com/flutter/flutter/issues/32374
2019-05-21 14:55:29 -07:00
Lorenz Nickel ca4ad6dc5a Updated some links (#32444) 2019-05-21 14:48:42 -07:00
engine-flutter-autoroll 9aa3990f77
ee5915fbb Avoid unnecessary copying of vectors in AccessibilityBridge (flutter/engine#9033) (#33147)
74aaf735a4...ee5915fbb0

git log 74aaf735a4744ea2274ccec8aee2263071e52e29..ee5915fbb0862ec42754ec35fe9ada03871ae60b --no-merges --oneline
ee5915fbb Avoid unnecessary copying of vectors in AccessibilityBridge (flutter/engine#9033)

The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff (garyq@google.com), and stop
the roller if necessary.
2019-05-21 17:15:21 -04:00
engine-flutter-autoroll 6b8e6d24ca
74aaf735a Roll src/third_party/skia 54fbe0f813c1..12710911dcc2 (5 commits) (flutter/engine#9032) (#33141)
6dd38f3b85...74aaf735a4

git log 6dd38f3b85753f5830ac490de15547ec3a588ac0..74aaf735a4744ea2274ccec8aee2263071e52e29 --no-merges --oneline
74aaf735a Roll src/third_party/skia 54fbe0f813c1..12710911dcc2 (5 commits) (flutter/engine#9032)

The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff (garyq@google.com), and stop
the roller if necessary.
2019-05-21 15:49:18 -04:00
Greg Spencer a389d17766
A minor bug fix and comment cleanups for focus (#33135)
This just fixes up some comments for DefaultFocusTraversal, and fixes a minor bug when setting the onKey on a FocusNode on creation before attaching to it.
2019-05-21 12:42:26 -07:00
Christopher Fujino 041755faad
don't send crash reports if on a user branch (#33078)
* don't send crash reports if on a user branch.
* add test to test/crash_reporting_test.dart
2019-05-21 11:58:41 -07:00
Todd Volkert ceec48785a
Re-apply "Add assert that the root widget has been attached" (#33084)
This re-applies #32437 with a fix to the broken device lab test.
2019-05-21 11:21:57 -07:00
Efthymis Sarmpanis c6be1b9619 Fix apidocs in _WidgetsAppState.basicLocaleListResolution (#32638)
(all tests passed, github not displaying it)
2019-05-22 01:15:57 +08:00
Zachary Anderson 94ce956f0a
[flutter_tool] Adds support for 'run' for Fuchsia devices (#32849) 2019-05-21 08:49:43 -07:00
Shi-Hao Hong 3265e15925
SliverAppBar shape property (#33073) 2019-05-21 08:30:58 -07:00
engine-flutter-autoroll 277d5fe5f6
6dd38f3b8 Roll src/third_party/skia 1903c94f44fd..54fbe0f813c1 (6 commits) (flutter/engine#9030) (#33128)
301f560bd8...6dd38f3b85

git log 301f560bd835e462134b491f1d5a74d21d03f3a8..6dd38f3b85753f5830ac490de15547ec3a588ac0 --no-merges --oneline
6dd38f3b8 Roll src/third_party/skia 1903c94f44fd..54fbe0f813c1 (6 commits) (flutter/engine#9030)

The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff (garyq@google.com), and stop
the roller if necessary.
2019-05-21 10:50:24 -04:00
Michael Thomsen 7ae3caf309
Rename flutter packages to flutter pub (#33041) 2019-05-21 16:38:58 +02:00
engine-flutter-autoroll d5aae54a28
301f560bd Roll src/third_party/skia dbc3caaf6c3d..1903c94f44fd (1 commits) (flutter/engine#9028) (#33096)
e40768c63a...301f560bd8

git log e40768c63a00252062ea1061a6db9e756ccb65e8..301f560bd835e462134b491f1d5a74d21d03f3a8 --no-merges --oneline
301f560bd Roll src/third_party/skia dbc3caaf6c3d..1903c94f44fd (1 commits) (flutter/engine#9028)

The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff (jsimmons@google.com), and stop
the roller if necessary.
2019-05-20 23:19:18 -04:00
engine-flutter-autoroll 9e7923dba0
e40768c63 Initialize next_pointer_flow_id_ to 0 (flutter/engine#9026) (#33093)
3d2e9b24aa...e40768c63a

git log 3d2e9b24aa712ba60206e7ac392a709df0939635..e40768c63a00252062ea1061a6db9e756ccb65e8 --no-merges --oneline
e40768c63 Initialize next_pointer_flow_id_ to 0 (flutter/engine#9026)

The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff (jsimmons@google.com), and stop
the roller if necessary.
2019-05-20 22:15:17 -04:00
engine-flutter-autoroll 0b107c285f
3d2e9b24a Correct the return type of addRetained (flutter/engine#9025) (#33089)
e3772232c2...3d2e9b24aa

git log e3772232c2d24c174beac7ef03dff63907cdda46..3d2e9b24aa712ba60206e7ac392a709df0939635 --no-merges --oneline
3d2e9b24a Correct the return type of addRetained (flutter/engine#9025)

The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff (jsimmons@google.com), and stop
the roller if necessary.
2019-05-20 21:13:17 -04:00