development/flutter
development/flutter
1
0
Fork 0
mirror of https://github.com/flutter/flutter synced 2024-07-17 02:48:33 +00:00
Code Issues Actions 3 Packages Projects Releases Wiki Activity
35501 commits 766 branches 962 tags 1.3 GiB
Commit graph

35501 commits

This branch
This branch
All branches
Author SHA1 Message Date
pdblasi-google 321abcbe4f
Adds dart_fix support to integration_test (#129579) 
* Adds fix for `IntegrationTestWidgetsFlutterBinding.runTest(timeout)` to support first round of deprecations for `flutter_test`

Resolves #124346
 2023-06-27 18:01:06 +00:00
Casey Hillers b359e9072f
Update labeler.yml to v5.0.0-beta.1 (#129617) 
https://github.com/flutter/flutter/issues/128440
 2023-06-27 17:52:04 +00:00
Luccas Clezar a90c33fd61
iOS TextSelectionToolbar fidelity (#127757) 
CupertinoTextSelectionToolbar is different from the native one, with some UI and UX issues. More details on the linked issue.

https://github.com/flutter/flutter/issues/127756

Currently the only problem that I listed on the linked issue that I couldn't fix was the horizontal scrolling, but to workaround this I added a GestureDetector to change pages when swiping the toolbar. It's not exactly the same as native as there is no scroll animation, but it works.

I'm creating this PR a little early to have some feedback as these changes were more complex than the ones in my last PR. Probably best if @justinmc is involved 😅

|Version|Video|
|-|-|
|Flutter Old|<video src="https://github.com/flutter/flutter/assets/12024080/7cf81075-46ec-4970-b118-cc27b60ddac0"></video>|
|Flutter New|<video src="https://github.com/flutter/flutter/assets/12024080/c9e27a53-f94c-4cb0-9b76-e47b73841dcb"></video>|
|Native|<video src="https://github.com/flutter/flutter/assets/12024080/468c7d5b-ba93-4bd4-8f6e-8ec2644b9866"></video>|
 2023-06-27 17:50:07 +00:00
Jason Simmons 3e66c86ae4
Make a paragraph test involving Chinese characters work with inconsistent host system fonts (#129628) 
Text tests are run using the Ahem font, and test host environments such
as LUCI may not provide a fallback font for Chinese glyphs.
 2023-06-27 09:56:13 -07:00
engine-flutter-autoroll 4b238d5458
Roll Packages from 6b70804799a9 to f89ce028d764 (7 revisions) (#129630) 
6b70804799...f89ce028d7

2023-06-27 hansmuller@google.com Updated
rfw/test/material_widgets_test.dart for M3 (flutter/packages#4316)
2023-06-27 tarrinneal@gmail.com [shared_preferences] Adds new
`clearWithParameters` and `getAllWithParameters` methods to platform
interface. (flutter/packages#4261)
2023-06-26 engine-flutter-autoroll@skia.org Roll Flutter from
042c0366c9 to 96a2c05358 (60 revisions) (flutter/packages#4313)
2023-06-26 10687576+bparrishMines@users.noreply.github.com
[file_selector_android] Create initial Android implementation of the
file_selector package (flutter/packages#3814)
2023-06-26 49699333+dependabot[bot]@users.noreply.github.com
[in_app_pur]: Bump org.json:json from 20230227 to 20230618 in
/packages/in_app_purchase/in_app_purchase/example/android/app
(flutter/packages#4244)
2023-06-26 me@ghyeok.io [webview_flutter_wkwebview] Adds the
`isInspectable` to `WebKitWebViewController`. (flutter/packages#3984)
2023-06-26 stuartmorgan@google.com [ci] Remove jcenter from legacy
project (flutter/packages#4306)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert
to ensure that a human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-06-27 11:55:05 -04:00
engine-flutter-autoroll 7dbdacff46
Roll Flutter Engine from 715eff211a42 to f320b8c36fee (6 revisions) (#129599) 
715eff211a...f320b8c36f

2023-06-27 ditman@gmail.com [web] Removes patchCanvasKitModule. (flutter/engine#42941)
2023-06-26 skia-flutter-autoroll@skia.org Roll ANGLE from cafbf6e2660f to cba77bceb26c (1 revision) (flutter/engine#43222)
2023-06-26 bdero@google.com [Impeller] Fix CPU Porter-Duff blends (flutter/engine#43217)
2023-06-26 skia-flutter-autoroll@skia.org Roll Skia from c1effc01211e to 370132bcadb1 (2 revisions) (flutter/engine#43221)
2023-06-26 skia-flutter-autoroll@skia.org Roll ANGLE from 4a4b13cc6931 to cafbf6e2660f (2 revisions) (flutter/engine#43219)
2023-06-26 skia-flutter-autoroll@skia.org Roll Skia from 4ae209493390 to c1effc01211e (4 revisions) (flutter/engine#43218)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-06-27 02:05:23 +00:00
hangyu 9459f1c517
Fix chinese text is not selected by long press (#129320) 
issue:#126652

 in Chinese text, word length is 1 and (position.offset == word.end) happens a lot.

Update if (position.offset >= word.end) to if (position.offset > word.end) to resolve the issue that Chinese characters are not selected.
 2023-06-27 01:15:38 +00:00
engine-flutter-autoroll 2e5a255b87
Roll Flutter Engine from 0da06de991a9 to 715eff211a42 (4 revisions) (#129593) 
0da06de991...715eff211a

2023-06-26 58529443+srujzs@users.noreply.github.com Refactor JSNumber.toDart and Object.toJS (flutter/engine#43149)
2023-06-26 jonahwilliams@google.com [Impeller] Treat SubOptimalKHR as rotated. (flutter/engine#43214)
2023-06-26 skia-flutter-autoroll@skia.org Roll ANGLE from f6c7dc891859 to 4a4b13cc6931 (12 revisions) (flutter/engine#43213)
2023-06-26 skia-flutter-autoroll@skia.org Roll Skia from 632fa401098d to 4ae209493390 (3 revisions) (flutter/engine#43212)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-06-26 23:55:25 +00:00
godofredoc 9f1809b578
Fix syntax error in no-response (#129588) 
The comma needs to be enclosed in the quotes.


## Pre-launch Checklist

- [X] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [X] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [X] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [X] I signed the [CLA].
- [X] I listed at least one issue that this PR fixes in the description
above.
- [X] I updated/added relevant documentation (doc comments with `///`).
- [X] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [X] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
 2023-06-26 16:22:55 -07:00
engine-flutter-autoroll c56362c615
Roll Flutter Engine from f2d70cc809cd to 0da06de991a9 (3 revisions) (#129582) 
f2d70cc809...0da06de991

2023-06-26 tamird@google.com Avoid channel clone (flutter/engine#43181)
2023-06-26 5236035+fzyzcjy@users.noreply.github.com ParagraphStyle uses the wrong bit mask (flutter/engine#43070)
2023-06-26 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from 3Y8TbEFhQUKOJBLQ4... to bj_X2Se1zObk_l_CC... (flutter/engine#43205)

Also rolling transitive DEPS:
  fuchsia/sdk/core/linux-amd64 from 3Y8TbEFhQUKO to bj_X2Se1zObk

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-06-26 21:53:24 +00:00
Hans Muller b703f75f0f
Updated chip_test.dart tests for M3 (#129570) 
Updated the chip tests per the changes from https://github.com/flutter/flutter/pull/128584 so that Chip tests that depend on Material2 will continue to pass when Material3 becomes the default. 

Part of: https://github.com/flutter/flutter/issues/127064
 2023-06-26 21:02:58 +00:00
engine-flutter-autoroll 02c0abbbd6
Roll Flutter Engine from 4032a9bc964e to f2d70cc809cd (4 revisions) (#129574) 
4032a9bc96...f2d70cc809

2023-06-26 skia-flutter-autoroll@skia.org Roll Skia from 46dcf29e5dfe to 632fa401098d (5 revisions) (flutter/engine#43204)
2023-06-26 godofredoc@google.com Revert "Remove master mirroring workflow." (flutter/engine#43206)
2023-06-26 jonahwilliams@google.com [Impeller] opt srgb to linear into f16 (flutter/engine#43182)
2023-06-26 skia-flutter-autoroll@skia.org Roll ANGLE from 764f31be3228 to f6c7dc891859 (1 revision) (flutter/engine#43203)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-06-26 19:45:25 +00:00
dependabot[bot] 96a2c05358
Bump ossf/scorecard-action from 2.1.3 to 2.2.0 (#129453) 
Bumps [ossf/scorecard-action](https://github.com/ossf/scorecard-action) from 2.1.3 to 2.2.0.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/ossf/scorecard-action/releases">ossf/scorecard-action's releases</a>.</em></p>
<blockquote>
<h2>v2.2.0</h2>
<h2>What's Changed</h2>
<ul>
<li>🌱 Bump github.com/ossf/scorecard/v4 from v4.10.5 to v4.11.0 by <a href="https://github.com/spencerschrock"><code>@​spencerschrock</code></a> in <a href="https://redirect.github.com/ossf/scorecard-action/pull/1192">ossf/scorecard-action#1192</a></li>
</ul>
<h2>Scorecard Result Viewer</h2>
<p>Thanks to contributions from <a href="https://github.com/cynthia-sg"><code>@​cynthia-sg</code></a> and <a href="https://github.com/tegioz"><code>@​tegioz</code></a> at <a href="https://github.com/cncf/clomonitor">CLOMonitor</a>, there is a new Scorecard Result visualization page at <code>https://securityscorecards.dev/viewer/?uri=&lt;project-url&gt;</code>.</p>
<ul>
<li><a href="https://redirect.github.com/ossf/scorecard-webapp/pull/406">ossf/scorecard-webapp#406</a></li>
<li><a href="https://redirect.github.com/ossf/scorecard-webapp/pull/422">ossf/scorecard-webapp#422</a></li>
</ul>
<p>As an example, you can see our own score visualized <a href="https://securityscorecards.dev/viewer/?uri=github.com/ossf/scorecard">here</a>
Checkout our <a href="08b4669551/README.md (scorecard-badge)">README</a> to learn how to link your README badge to the new visualization page.</p>
<h2>Publishing Results</h2>
<p>This release contains two fixes which will improve the user experience when <code>publish_results</code> is <code>true</code></p>
<ul>
<li>Runs that fail our <a href="08b4669551/README.md (workflow-restrictions)">workflow restrictions</a> will fail with a 400 response indicating the problem, instead of a vague 500 status. (<a href="https://redirect.github.com/ossf/scorecard-action/pull/1156">ossf/scorecard-action#1156</a>, resolved <a href="https://redirect.github.com/ossf/scorecard-action/issues/1150">ossf/scorecard-action#1150</a>)</li>
<li>Scorecard action will retry when signing results and submitting them to our web API. This should help with flakiness from connection failures. (<a href="https://redirect.github.com/ossf/scorecard-action/pull/1191">ossf/scorecard-action#1191</a>)</li>
</ul>
<h2>Docs</h2>
<ul>
<li>📖 Update README to accept fine-grained tokens by <a href="https://github.com/pnacht"><code>@​pnacht</code></a> in <a href="https://redirect.github.com/ossf/scorecard-action/pull/1175">ossf/scorecard-action#1175</a></li>
<li>📖 Update installation instructions to match current GitHub UI  by <a href="https://github.com/joycebrum"><code>@​joycebrum</code></a> in <a href="https://redirect.github.com/ossf/scorecard-action/pull/1153">ossf/scorecard-action#1153</a></li>
<li>📖 Document the GitHub action workflow restrictions when publishing results. by <a href="https://github.com/spencerschrock"><code>@​spencerschrock</code></a> in</li>
</ul>
<h2>New Contributors</h2>
<ul>
<li><a href="https://github.com/bobcallaway"><code>@​bobcallaway</code></a> made their first contribution in <a href="https://redirect.github.com/ossf/scorecard-action/pull/1140">ossf/scorecard-action#1140</a></li>
<li><a href="https://github.com/pnacht"><code>@​pnacht</code></a> made their first contribution in <a href="https://redirect.github.com/ossf/scorecard-action/pull/1175">ossf/scorecard-action#1175</a></li>
</ul>
<p><strong>Full Changelog</strong>: <a href="https://github.com/ossf/scorecard-action/compare/v2.1.3...v2.2.0">https://github.com/ossf/scorecard-action/compare/v2.1.3...v2.2.0</a></p>
</blockquote>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="08b4669551"><code>08b4669</code></a> 🌱 Bump docker tag to for v2.2.0 release. (<a href="https://redirect.github.com/ossf/scorecard-action/issues/1194">#1194</a>)</li>
<li><a href="3c7470f58c"><code>3c7470f</code></a> 📖 Update README badge link to use new uri param. (<a href="https://redirect.github.com/ossf/scorecard-action/issues/1185">#1185</a>)</li>
<li><a href="a164dbc12a"><code>a164dbc</code></a> 🌱 Bump github.com/ossf/scorecard/v4 from v4.10.5 to v4.11.0 (<a href="https://redirect.github.com/ossf/scorecard-action/issues/1192">#1192</a>)</li>
<li><a href="597960e1d9"><code>597960e</code></a> 📖 Update README to accept fine-grained tokens (<a href="https://redirect.github.com/ossf/scorecard-action/issues/1175">#1175</a>)</li>
<li><a href="8808ed28c3"><code>8808ed2</code></a> 🌱 Retry external network calls when publishing results (<a href="https://redirect.github.com/ossf/scorecard-action/issues/1191">#1191</a>)</li>
<li><a href="0eed6cb5da"><code>0eed6cb</code></a> 🌱 Bump golang.org/x/net from 0.10.0 to 0.11.0</li>
<li><a href="6c6335c126"><code>6c6335c</code></a> 🌱 Bump github/codeql-action from 2.3.6 to 2.20.0</li>
<li><a href="7f1baf380a"><code>7f1baf3</code></a> 📖 Switch recommended badge link to the new viewer. (<a href="https://redirect.github.com/ossf/scorecard-action/issues/1176">#1176</a>)</li>
<li><a href="df98bbc13d"><code>df98bbc</code></a> 🌱 Bump actions/checkout from 3.5.2 to 3.5.3</li>
<li><a href="75886d414a"><code>75886d4</code></a> 🌱 Bump golangci/golangci-lint-action from 3.5.0 to 3.6.0 (<a href="https://redirect.github.com/ossf/scorecard-action/issues/1172">#1172</a>)</li>
<li>Additional commits viewable in <a href="80e868c13c...08b4669551">compare view</a></li>
</ul>
</details>
<br />

[![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=ossf/scorecard-action&package-manager=github_actions&previous-version=2.1.3&new-version=2.2.0)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.

---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

</details>
 2023-06-26 18:42:13 +00:00
engine-flutter-autoroll 7dd5c76df4
Roll Flutter Engine from 63582320d20e to 4032a9bc964e (2 revisions) (#129569) 
63582320d2...4032a9bc96

2023-06-26 jonahwilliams@google.com [Impeller] use default precision specifiers. (flutter/engine#43183)
2023-06-26 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from GkEyRw1Q2qLZWxitD... to ytzCCSvHY1lHWEDM9... (flutter/engine#43200)

Also rolling transitive DEPS:
  fuchsia/sdk/core/mac-amd64 from GkEyRw1Q2qLZ to ytzCCSvHY1lH

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-06-26 18:06:03 +00:00
Hans Muller 548fe14730
Updated TextMagnifierExampleApp to M3 (#129381) 2023-06-26 10:44:11 -07:00
engine-flutter-autoroll cef9a8c54b
Roll Flutter Engine from debee7cece49 to 63582320d20e (3 revisions) (#129563) 
debee7cece...63582320d2

2023-06-26 skia-flutter-autoroll@skia.org Roll ANGLE from 7169dc5fe003 to 764f31be3228 (1 revision) (flutter/engine#43199)
2023-06-26 skia-flutter-autoroll@skia.org Roll Skia from 6d89bc1acb7e to 46dcf29e5dfe (2 revisions) (flutter/engine#43197)
2023-06-26 matej.knopp@gmail.com Implement union and intersection for DlRegion (flutter/engine#42620)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-06-26 17:20:48 +00:00
Taha Tesser c8e42b47f5
Fix AnimatedList & AnimatedGrid doesn't apply MediaQuery padding (#129556) 
fixes [AnimatedList does not take SafeArea into account when building the list ](https://github.com/flutter/flutter/issues/129539)

### Description
This PR fixes an issue for `AnimatedList` & `AnimatedGrid` where `MediaQuery` padding isn't applied. See the [source](a20db068dd/packages/flutter/lib/src/widgets/scroll_view.dart (L803-L833)).

While the  `ListView` or `GridView` applies `MediaQuery` padding to its inner `SliverPadding`.  This is missing from `AnimatedList` & `AnimatedGrid`.

![Digram of ListView applying MediaQuery padding](https://github.com/flutter/flutter/assets/48603081/01917900-cd26-4ca1-8e51-b7dcd1241471)

The fix applies  `MediaQuery` padding to the inner `SliverPadding` in `AnimatedList` & `AnimatedGrid`.

![Digram of AnimatedList & AnimatedGrid applying MediaQuery padding](https://github.com/flutter/flutter/assets/48603081/75d0a0ad-539c-485e-b3c1-770ee187086b)

### Code sample
<details> 
<summary>expand to view the code sample</summary> 

```dart
import 'package:flutter/material.dart';

void main() => runApp(const MyApp());

class MyApp extends StatelessWidget {
  const MyApp({super.key});

  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      debugShowCheckedModeBanner: false,
      theme: ThemeData(useMaterial3: true),
      home: const Example(),
    );
  }
}

class Example extends StatelessWidget {
  const Example({super.key});

  @override
  Widget build(BuildContext context) {
    return Scaffold(
      appBar: AppBar(
        title: const Text('Sample'),
      ),
      body: Row(
        children: <Widget>[
          Expanded(
            child: Column(
              children: <Widget>[
                const Text('ListView'),
                Expanded(
                  child: ListView.builder(
                    itemCount: 50,
                    itemBuilder: (_, int index) {
                      return ColoredBox(
                        color: Theme.of(context).colorScheme.primaryContainer,
                        child: Center(
                          child: Text('$index', textAlign: TextAlign.center),
                        ),
                      );
                    },
                  ),
                ),
              ],
            ),
          ),
          const VerticalDivider(width: 4),
          Expanded(
            child: Column(
              children: <Widget>[
                const Text('AnimatedList'),
                Expanded(
                  child: AnimatedList(
                    initialItemCount: 50,
                    itemBuilder: (_, int index, __) {
                      return ColoredBox(
                        color: Theme.of(context).colorScheme.primaryContainer,
                        child: Center(
                          child: Text('$index', textAlign: TextAlign.center),
                        ),
                      );
                    },
                  ),
                ),
              ],
            ),
          ),
          const VerticalDivider(width: 4),
          Expanded(
              child: Column(
            children: <Widget>[
              const Text('AnimatedGrid'),
              Expanded(
                child: AnimatedGrid(
                  initialItemCount: 50,
                  gridDelegate: const SliverGridDelegateWithFixedCrossAxisCount(
                    crossAxisCount: 2,
                  ),
                  itemBuilder: (_, int index, __) {
                    return ColoredBox(
                      color: Theme.of(context).colorScheme.primaryContainer,
                      child: Center(
                        child: Text('$index', textAlign: TextAlign.center),
                      ),
                    );
                  },
                ),
              ),
            ],
          ))
        ],
      ),
    );
  }
}

``` 
	
</details>

### Before
![Before preview image](https://github.com/flutter/flutter/assets/48603081/73954a8a-9d1d-4b9e-b6a3-cae8071f3462)

### After
![After preview image](https://github.com/flutter/flutter/assets/48603081/9f1dc48a-622f-4402-8d5e-8e6e3e150165)
 2023-06-26 16:19:02 +00:00
godofredoc bac0589539
Process only specific labels. (#129475) 
To avoid trying to process all the open bugs in flutter/flutter.
 2023-06-26 16:02:07 +00:00
engine-flutter-autoroll 4871391dda
Roll Packages from d041934b296d to 6b70804799a9 (7 revisions) (#129559) 
d041934b29...6b70804799

2023-06-23 47866232+chunhtai@users.noreply.github.com [go_router] Reduces excessive rebuilds due to inherited look up. (flutter/packages#4227)
2023-06-23 stuartmorgan@google.com [image_picker] Update to 1.0 (flutter/packages#4285)
2023-06-23 stuartmorgan@google.com [tool] Consider comment-only changes to be dev-only (flutter/packages#4279)
2023-06-23 stuartmorgan@google.com [ci] Switch to LUCI for Android build-all (flutter/packages#4274)
2023-06-23 stuartmorgan@google.com [file_selector] Add file group to save return value (flutter/packages#4222)
2023-06-23 47866232+chunhtai@users.noreply.github.com [go_router] Adds onException to GoRouter constructor. (flutter/packages#4216)
2023-06-23 stuartmorgan@google.com [file_selector] Add file group to save return value - implementations (flutter/packages#4273)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-06-26 15:48:02 +00:00
Ian Hickson a20db068dd
Make bug templates more consistent (#129460) 
* remove trailing periods in template titles
* tweak the design doc template a little based on testing it out
 2023-06-26 12:27:27 +00:00
engine-flutter-autoroll da2b8723fd
Roll Flutter Engine from be46101e952d to debee7cece49 (1 revision) (#129544) 
be46101e95...debee7cece

2023-06-26 skia-flutter-autoroll@skia.org Roll Skia from 5ea08db08587 to 6d89bc1acb7e (2 revisions) (flutter/engine#43194)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-06-26 09:20:56 +00:00
engine-flutter-autoroll fde3906307
Roll Flutter Engine from 88ff46e1efc1 to be46101e952d (2 revisions) (#129540) 
88ff46e1ef...be46101e95

2023-06-26 skia-flutter-autoroll@skia.org Roll Skia from a20d58872fbe to 5ea08db08587 (1 revision) (flutter/engine#43193)
2023-06-26 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from XnZWRj5iNXgOHlVNi... to 3Y8TbEFhQUKOJBLQ4... (flutter/engine#43192)

Also rolling transitive DEPS:
  fuchsia/sdk/core/linux-amd64 from XnZWRj5iNXgO to 3Y8TbEFhQUKO

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-06-26 07:58:35 +00:00
engine-flutter-autoroll c7f82a1ca2
Roll Flutter Engine from 317673b3278a to 88ff46e1efc1 (1 revision) (#129534) 
317673b327...88ff46e1ef

2023-06-26 robert.ancell@canonical.com Allow event channels to reuse names (flutter/engine#41837)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-06-26 03:44:09 +00:00
engine-flutter-autoroll 8b6e1fdeac
Roll Flutter Engine from 593e1d9a9cf5 to 317673b3278a (3 revisions) (#129531) 
593e1d9a9c...317673b327

2023-06-25 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from uh5om9qyypCToIllT... to GkEyRw1Q2qLZWxitD... (flutter/engine#43190)
2023-06-25 skia-flutter-autoroll@skia.org Roll Skia from 7866f2c6ba52 to a20d58872fbe (1 revision) (flutter/engine#43191)
2023-06-25 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from w-DJY4dBZWS7lxsxE... to XnZWRj5iNXgOHlVNi... (flutter/engine#43188)

Also rolling transitive DEPS:
  fuchsia/sdk/core/linux-amd64 from w-DJY4dBZWS7 to XnZWRj5iNXgO
  fuchsia/sdk/core/mac-amd64 from uh5om9qyypCT to GkEyRw1Q2qLZ

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-06-26 01:38:21 +00:00
engine-flutter-autoroll b2e9501317
Roll Flutter Engine from 5178e8ab7764 to 593e1d9a9cf5 (1 revision) (#129514) 
5178e8ab77...593e1d9a9c

2023-06-25 skia-flutter-autoroll@skia.org Roll Skia from 18a947ed2253 to 7866f2c6ba52 (1 revision) (flutter/engine#43187)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-06-25 15:39:29 +00:00
engine-flutter-autoroll 42d2c2d592
Roll Flutter Engine from 100f6fc854b4 to 5178e8ab7764 (1 revision) (#129508) 
100f6fc854...5178e8ab77

2023-06-25 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from N0MQ5J5y_hQoiOYs9... to uh5om9qyypCToIllT... (flutter/engine#43185)

Also rolling transitive DEPS:
  fuchsia/sdk/core/mac-amd64 from N0MQ5J5y_hQo to uh5om9qyypCT

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-06-25 10:40:12 +00:00
engine-flutter-autoroll 176f7e6382
Roll Flutter Engine from a9f446e25f0c to 100f6fc854b4 (1 revision) (#129498) 
a9f446e25f...100f6fc854

2023-06-25 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from bjQLnDu32Oj0KUbrW... to w-DJY4dBZWS7lxsxE... (flutter/engine#43184)

Also rolling transitive DEPS:
  fuchsia/sdk/core/linux-amd64 from bjQLnDu32Oj0 to w-DJY4dBZWS7

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-06-25 04:00:25 +00:00
engine-flutter-autoroll c0f76fc94a
Roll Flutter Engine from 5b1b98305768 to a9f446e25f0c (1 revision) (#129495) 
5b1b983057...a9f446e25f

2023-06-24 bdero@google.com [Impeller] Supply surface cull rect for Vulkan & GLES dispatchers (flutter/engine#43152)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-06-25 00:37:07 +00:00
engine-flutter-autoroll c442c6d464
Roll Flutter Engine from 72c902ce3b81 to 5b1b98305768 (2 revisions) (#129493) 
72c902ce3b...5b1b983057

2023-06-24 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from JF0sJRpJH8KiyyqrR... to N0MQ5J5y_hQoiOYs9... (flutter/engine#43180)
2023-06-24 bdero@google.com [Impeller] Disable blending for Source blend mode (flutter/engine#43162)

Also rolling transitive DEPS:
  fuchsia/sdk/core/mac-amd64 from JF0sJRpJH8Ki to N0MQ5J5y_hQo

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-06-24 21:23:11 +00:00
engine-flutter-autoroll 96a9773d1b
Roll Flutter Engine from f2976add9414 to 72c902ce3b81 (1 revision) (#129489) 
f2976add94...72c902ce3b

2023-06-24 skia-flutter-autoroll@skia.org Roll Skia from 1826cbacd4da to 18a947ed2253 (1 revision) (flutter/engine#43178)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-06-24 19:08:12 +00:00
engine-flutter-autoroll 6855b52779
Roll Flutter Engine from 76a5e971dc09 to f2976add9414 (1 revision) (#129487) 
76a5e971dc...f2976add94

2023-06-24 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from b5PDBUm8Hfx-y9Hsp... to bjQLnDu32Oj0KUbrW... (flutter/engine#43177)

Also rolling transitive DEPS:
  fuchsia/sdk/core/linux-amd64 from b5PDBUm8Hfx- to bjQLnDu32Oj0

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-06-24 17:33:07 +00:00
engine-flutter-autoroll fd9d13c28a
Roll Flutter Engine from 79fd6beea087 to 76a5e971dc09 (1 revision) (#129483) 
79fd6beea0...76a5e971dc

2023-06-24 skia-flutter-autoroll@skia.org Roll Skia from 050d2ad6dda3 to 1826cbacd4da (2 revisions) (flutter/engine#43175)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-06-24 09:47:25 +00:00
engine-flutter-autoroll afa4cf7e0e
Roll Flutter Engine from 30ac9107f2f9 to 79fd6beea087 (1 revision) (#129479) 
30ac9107f2...79fd6beea0

2023-06-24 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from w-tUP3Ia2kfAaFNW1... to JF0sJRpJH8KiyyqrR... (flutter/engine#43174)

Also rolling transitive DEPS:
  fuchsia/sdk/core/mac-amd64 from w-tUP3Ia2kfA to JF0sJRpJH8Ki

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-06-24 08:19:14 +00:00
engine-flutter-autoroll cc76ed95f2
Roll Flutter Engine from ee65380bf3fd to 30ac9107f2f9 (1 revision) (#129476) 
ee65380bf3...30ac9107f2

2023-06-24 skia-flutter-autoroll@skia.org Roll Skia from ef64a8c132c4 to 050d2ad6dda3 (2 revisions) (flutter/engine#43171)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-06-24 05:47:24 +00:00
engine-flutter-autoroll a8c6842533
Roll Flutter Engine from 240a86f40781 to ee65380bf3fd (2 revisions) (#129474) 
240a86f407...ee65380bf3

2023-06-24 skia-flutter-autoroll@skia.org Roll ANGLE from f834ba7fdab9 to 7169dc5fe003 (1 revision) (flutter/engine#43169)
2023-06-24 skia-flutter-autoroll@skia.org Roll Skia from 3d9732b86456 to ef64a8c132c4 (6 revisions) (flutter/engine#43170)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-06-24 04:54:10 +00:00
godofredoc 0f006ea0dd
Fix issues with no response bot. (#129470) 
This is also increasing the number of items to be evaluated on each iteration.
 2023-06-24 04:03:59 +00:00
engine-flutter-autoroll e058ceb616
Roll Flutter Engine from 5e6dcf959ea0 to 240a86f40781 (1 revision) (#129473) 
5e6dcf959e...240a86f407

2023-06-24 godofredoc@google.com Add docs for magic variables. (flutter/engine#43121)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-06-24 04:00:07 +00:00
engine-flutter-autoroll 1d5aeea47f
Roll Flutter Engine from 550bfedc8760 to 5e6dcf959ea0 (1 revision) (#129468) 
550bfedc87...5e6dcf959e

2023-06-24 skia-flutter-autoroll@skia.org Roll Skia from 8818761fbc84 to 3d9732b86456 (4 revisions) (flutter/engine#43167)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-06-24 02:40:55 +00:00
engine-flutter-autoroll c39bc1d940
Roll Flutter Engine from c1abd1f17ab1 to 550bfedc8760 (3 revisions) (#129466) 
c1abd1f17a...550bfedc87

2023-06-23 bdero@google.com [Impeller] Label present waiter command buffer in SurfaceMTL (flutter/engine#43165)
2023-06-23 tamird@google.com Add tmp storage capability to flutter runner (flutter/engine#43157)
2023-06-23 skia-flutter-autoroll@skia.org Roll Skia from c53a952a2dab to 8818761fbc84 (5 revisions) (flutter/engine#43164)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-06-24 01:56:05 +00:00
Brandon DeRosier b898d1d270
[devicelab] Add platform view scroll benchmarks for Impeller on Android (#129455) 
For tracking perf improvements with changes like
https://github.com/flutter/engine/pull/43152.
 2023-06-23 18:40:17 -07:00
engine-flutter-autoroll 813fc3bbcd
Roll Flutter Engine from eca910dd5e3f to c1abd1f17ab1 (3 revisions) (#129456) 
eca910dd5e...c1abd1f17a

2023-06-23 skia-flutter-autoroll@skia.org Roll ANGLE from 566f1ee4657c to f834ba7fdab9 (1 revision) (flutter/engine#43158)
2023-06-23 skia-flutter-autoroll@skia.org Roll Skia from d53ea1557b35 to c53a952a2dab (1 revision) (flutter/engine#43156)
2023-06-23 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from VSKvLPB4DCIDvXzOA... to b5PDBUm8Hfx-y9Hsp... (flutter/engine#43155)

Also rolling transitive DEPS:
  fuchsia/sdk/core/linux-amd64 from VSKvLPB4DCID to b5PDBUm8Hfx-

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-06-23 23:50:59 +00:00
engine-flutter-autoroll be803a7df7
Roll Flutter Engine from f8a39cb4dc56 to eca910dd5e3f (3 revisions) (#129451) 
f8a39cb4dc...eca910dd5e

2023-06-23 110993981+htoor3@users.noreply.github.com [web] - Fix for Safari partially autofilling form  (flutter/engine#43058)
2023-06-23 skia-flutter-autoroll@skia.org Roll ANGLE from bc2d5ed01f27 to 566f1ee4657c (1 revision) (flutter/engine#43154)
2023-06-23 skia-flutter-autoroll@skia.org Roll Skia from 7b6aae68a11f to d53ea1557b35 (1 revision) (flutter/engine#43153)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-06-23 22:37:18 +00:00
engine-flutter-autoroll 80f8bf1191
Roll Flutter Engine from 74ef61859bdc to f8a39cb4dc56 (2 revisions) (#129445) 
74ef61859b...f8a39cb4dc

2023-06-23 skia-flutter-autoroll@skia.org Roll ANGLE from 2e285bb591f7 to bc2d5ed01f27 (1 revision) (flutter/engine#43151)
2023-06-23 chinmaygarde@google.com [Impeller] FenceWaiterVK: Move potentially slow calls out of wait set mutex critical section. (flutter/engine#43131)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-06-23 21:07:56 +00:00
Loïc Sharma e1e2ebd176
Add CallbackShortcuts widget of the week video (#129296) 2023-06-23 20:16:28 +00:00
engine-flutter-autoroll b136f5f951
Roll Flutter Engine from 060cd9c17df3 to 74ef61859bdc (3 revisions) (#129444) 
060cd9c17d...74ef61859b

2023-06-23 godofredoc@google.com Remove master mirroring workflow. (flutter/engine#42681)
2023-06-23 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from 07vKo_Vaiy_Vw2xxb... to w-tUP3Ia2kfAaFNW1... (flutter/engine#43148)
2023-06-23 skia-flutter-autoroll@skia.org Roll Skia from 9635d54210dc to 7b6aae68a11f (5 revisions) (flutter/engine#43147)

Also rolling transitive DEPS:
  fuchsia/sdk/core/mac-amd64 from 07vKo_Vaiy_V to w-tUP3Ia2kfA

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-06-23 20:15:50 +00:00
engine-flutter-autoroll fb90a49efe
Roll Flutter Engine from cd30a48ef889 to 060cd9c17df3 (3 revisions) (#129440) 
cd30a48ef8...060cd9c17d

2023-06-23 chillers@google.com [impeller] Explicitly cast enum class to int before passing it to a formatted string (flutter/engine#43139)
2023-06-23 54558023+keyonghan@users.noreply.github.com Add osx_sdk context to mac_clang_tidy (flutter/engine#43115)
2023-06-23 jonahwilliams@google.com [Impeller] re-enable buffer to texture blit Vulkan. (flutter/engine#43129)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-06-23 18:44:10 +00:00
engine-flutter-autoroll 935652c34f
Roll Flutter Engine from 27f3498286ff to cd30a48ef889 (4 revisions) (#129437) 
27f3498286...cd30a48ef8

2023-06-23 skia-flutter-autoroll@skia.org Roll Skia from 04fa1c1ef69c to 9635d54210dc (2 revisions) (flutter/engine#43145)
2023-06-23 skia-flutter-autoroll@skia.org Roll ANGLE from 9211ebf1f2ac to 2e285bb591f7 (1 revision) (flutter/engine#43144)
2023-06-23 34871572+gmackall@users.noreply.github.com Add a note in ImeSyncDeferringInsetsCallback explaining the reason behind capturing the latest final inset state (flutter/engine#43109)
2023-06-23 skia-flutter-autoroll@skia.org Roll Skia from 6ab865ee1f65 to 04fa1c1ef69c (1 revision) (flutter/engine#43141)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-06-23 17:58:10 +00:00
godofredoc 929468e171
Add a devicelab test to recipes cq. (#129411) 
This is to ensure the devicelab_drone recipe is tested on presubmit.

Bug: https://github.com/flutter/flutter/issues/126111
 2023-06-23 17:38:38 +00:00
Paurakh Sharma Humagain a9164a4d76
fix: Inconsistency of SelectionArea when scrolling (#128765) 
This PR fixes inconsistency of SelectionArea when scrolling by removing the `_clearSelection` on `longPressUpdate` gesture. This in turn makes the selection UX much better.

*List which issues are fixed by this PR. You must list at least one issue.*
Fixes: https://github.com/flutter/flutter/issues/120892

*If you had to change anything in the [flutter/tests] repo, include a link to the migration guide as per the [breaking change policy].*
 2023-06-23 16:47:47 +00:00
Kate Lovett 309e50173e
Run misc test shard when examples/api/** change (#129433) 
Fixes https://github.com/flutter/flutter/issues/129390

Found in https://github.com/flutter/flutter/pull/129381, changing sample code in `examples/api` did not trigger the misc test shard that executes the tests for `examples/api`.
 2023-06-23 16:46:04 +00:00