Commit graph

37864 commits

Author SHA1 Message Date
Zachary Anderson 2e50a54128
Move Skia new_gallery_transition_perf on a02 from staging to prod (#138013)
cc @yusuf-goog
2023-11-07 19:07:00 +00:00
Qun Cheng ed70f4e248
Adaptive Switch (#130425)
Currently, `Switch.factory` delegates to `CupertinoSwitch` when platform
is iOS or macOS. This PR is to:
* have the factory configure the Material `Switch` for the expected look
and feel.
* introduce `Adaptation` class to customize themes for the adaptive
components.
2023-11-07 10:26:23 -08:00
engine-flutter-autoroll a76720e9f6
Roll Flutter Engine from e2810f07abb5 to a9e0f9514f78 (1 revision) (#138005)
e2810f07ab...a9e0f9514f

2023-11-07 skia-flutter-autoroll@skia.org Roll Skia from 44dc086b6623 to 058145c1e5b5 (1 revision) (flutter/engine#47749)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC bdero@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-11-07 17:34:25 +00:00
engine-flutter-autoroll d5ac6c46ed
Roll Flutter Engine from b91400976b4a to e2810f07abb5 (1 revision) (#138002)
b91400976b...e2810f07ab

2023-11-07 skia-flutter-autoroll@skia.org Roll Skia from 71d865c5211e to 44dc086b6623 (1 revision) (flutter/engine#47748)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC bdero@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-11-07 16:47:09 +00:00
Daco Harkes da23eae33f
[native assets] Tool exit on build failure (#137995)
If the native assets feature is enabled, and the `build.dart` invocation fails, the `flutter build` and `flutter run` should abort.

Closes: https://github.com/flutter/flutter/issues/137910
2023-11-07 16:41:19 +00:00
engine-flutter-autoroll 5a6a3224fe
Roll Packages from 49eac1fec6c7 to be18d282c5e7 (3 revisions) (#137999)
49eac1fec6...be18d282c5

2023-11-06 engine-flutter-autoroll@skia.org Roll Flutter from 29b25165ca to f5a9835351 (101 revisions) (flutter/packages#5341)
2023-11-06 49699333+dependabot[bot]@users.noreply.github.com [pigeon]: Bump org.jetbrains.kotlin:kotlin-gradle-plugin from 1.9.10 to 1.9.20 in /packages/pigeon/platform_tests/test_plugin/android (flutter/packages#5334)
2023-11-06 krozett@gmail.com [flutter_markdown] Strip leading whitespace from list items (flutter/packages#5294)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-11-07 15:58:15 +00:00
engine-flutter-autoroll 68e95b9e7e
Roll Flutter Engine from b1f2581f05e3 to b91400976b4a (2 revisions) (#138000)
b1f2581f05...b91400976b

2023-11-07 skia-flutter-autoroll@skia.org Roll Skia from 3ac7216f1f6d to 71d865c5211e (1 revision) (flutter/engine#47746)
2023-11-07 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from NaQb_BU6PSbKXSAoU... to VcFEJiUUTYwkhEAlJ... (flutter/engine#47745)

Also rolling transitive DEPS:
  fuchsia/sdk/core/linux-amd64 from NaQb_BU6PSbK to VcFEJiUUTYwk

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC bdero@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-11-07 15:53:21 +00:00
engine-flutter-autoroll c1d11b1d5b
Roll Flutter Engine from 633065f75b1c to b1f2581f05e3 (1 revision) (#137997)
633065f75b...b1f2581f05

2023-11-07 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from wmM4lS2lYcphFSHPV... to CssR5Ci8l8Wn47xEJ... (flutter/engine#47744)

Also rolling transitive DEPS:
  fuchsia/sdk/core/mac-amd64 from wmM4lS2lYcph to CssR5Ci8l8Wn

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC bdero@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-11-07 15:04:52 +00:00
engine-flutter-autoroll 1b63c29946
Roll Flutter Engine from 99149d59cb3d to 633065f75b1c (1 revision) (#137996)
99149d59cb...633065f75b

2023-11-07 skia-flutter-autoroll@skia.org Roll Skia from 9fd258076b4d to 3ac7216f1f6d (2 revisions) (flutter/engine#47743)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC bdero@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-11-07 14:02:19 +00:00
engine-flutter-autoroll 5ff09c27f8
Roll Flutter Engine from 7f4d56a7f4f7 to 99149d59cb3d (1 revision) (#137987)
7f4d56a7f4...99149d59cb

2023-11-07 jiahaog@users.noreply.github.com Fix ImmutableEnum lint (flutter/engine#47739)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-11-07 08:35:26 +00:00
engine-flutter-autoroll 6007b91a37
Roll Flutter Engine from f9f822359f2b to 7f4d56a7f4f7 (1 revision) (#137983)
f9f822359f...7f4d56a7f4

2023-11-07 skia-flutter-autoroll@skia.org Roll Dart SDK from aded6314af29 to 15c286ed91ea (1 revision) (flutter/engine#47738)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-11-07 07:43:32 +00:00
engine-flutter-autoroll 1402d99476
Roll Flutter Engine from b1a5d772792f to f9f822359f2b (1 revision) (#137980)
b1a5d77279...f9f822359f

2023-11-07 skia-flutter-autoroll@skia.org Roll Skia from 9106e374e08d to 9fd258076b4d (1 revision) (flutter/engine#47735)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-11-07 04:21:33 +00:00
engine-flutter-autoroll be81cccd3b
Roll Flutter Engine from 461d815b48a0 to b1a5d772792f (13 revisions) (#137979)
461d815b48...b1a5d77279

2023-11-07 skia-flutter-autoroll@skia.org Roll Skia from 7e3119240ae4 to 9106e374e08d (1 revision) (flutter/engine#47732)
2023-11-07 skia-flutter-autoroll@skia.org Roll Dart SDK from 82731b940e7f to aded6314af29 (1 revision) (flutter/engine#47731)
2023-11-07 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from HQfFSkurc6-jKM2jh... to wmM4lS2lYcphFSHPV... (flutter/engine#47730)
2023-11-07 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from _vGlgDiKOrtlKrZAP... to NaQb_BU6PSbKXSAoU... (flutter/engine#47728)
2023-11-07 skia-flutter-autoroll@skia.org Roll Skia from bd5f57c9bd1a to 7e3119240ae4 (10 revisions) (flutter/engine#47726)
2023-11-06 gspencergoog@users.noreply.github.com Add `KeyEventDeviceType` to `KeyData` (flutter/engine#47315)
2023-11-06 skia-flutter-autoroll@skia.org Roll Skia from 2b218381e226 to bd5f57c9bd1a (2 revisions) (flutter/engine#47719)
2023-11-06 skia-flutter-autoroll@skia.org Roll Dart SDK from 07d4c9d85a5a to 82731b940e7f (1 revision) (flutter/engine#47717)
2023-11-06 skia-flutter-autoroll@skia.org Roll Skia from 77aeee3b81a5 to 2b218381e226 (1 revision) (flutter/engine#47715)
2023-11-06 30870216+gaaclarke@users.noreply.github.com [Impeller] scales blur coverage to match rendered output (flutter/engine#47621)
2023-11-06 jonahwilliams@google.com [Impeller] Fix EntityPassTarget::Flip with implict MSAA. (flutter/engine#47701)
2023-11-06 skia-flutter-autoroll@skia.org Roll Dart SDK from 9211fc6406bb to 07d4c9d85a5a (1 revision) (flutter/engine#47709)
2023-11-06 jonahwilliams@google.com [Impeller] fix drawVertices dest fast path to apply alpha. (flutter/engine#47695)

Also rolling transitive DEPS:
  fuchsia/sdk/core/linux-amd64 from _vGlgDiKOrtl to NaQb_BU6PSbK
  fuchsia/sdk/core/mac-amd64 from HQfFSkurc6-j to wmM4lS2lYcph

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-11-07 03:41:17 +00:00
engine-flutter-autoroll 156ba0f717
Roll Flutter Engine from bdfa8aa8f81f to 461d815b48a0 (1 revision) (#137944)
bdfa8aa8f8...461d815b48

2023-11-06 zanderso@users.noreply.github.com Move some Dart packages to
//flutter/third_party/pkg (flutter/engine#47654)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com,zra@google.com on the revert to ensure that
a human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-11-06 18:58:39 -08:00
Kostia Sokolovskyi c0b21b16ef
SemanticsHandle should dispatch creation and disposal events. (#137960) 2023-11-06 14:14:42 -08:00
Kostia Sokolovskyi 4880aab113
ScrollActivity should dispatch creation and disposal events. (#137961) 2023-11-06 14:14:08 -08:00
Kostia Sokolovskyi 2d9a075dfc
Cover text_selection tests with leak tracking. (#137009) 2023-11-06 14:10:50 -08:00
flutter-pub-roller-bot db57d286e4
Roll pub packages (#137862)
This PR was generated by `flutter update-packages --force-upgrade`.
2023-11-06 21:57:06 +00:00
Elias Yishak 17e0fe1a93
Migration for HotEvent for Flutter hot runner (#137717)
Related to tracker issue:
- https://github.com/flutter/flutter/issues/128251

For this migration, the `HotEvent` was being referenced in 2 additional files outside of `lib/src/reporting/events.dart`, shown below in the screenshot

<img width="257" alt="image" src="https://github.com/flutter/flutter/assets/42216813/97986f89-2253-4db1-9deb-bbced6321a16">
2023-11-06 21:33:11 +00:00
Jonah Williams 925f3eee66
[benchmarks] disable partial repaint for multiple backdrop blur iOS macrobenchmarks. (#137902)
Partial repaint is too effective, and we'd like to be able to measure performance without carefully structuring the benchmarks. For example, right now partial repaint is culling any blurs in the multibackdrop case, which we should be using to track  https://github.com/flutter/flutter/issues/132735
2023-11-06 19:49:15 +00:00
Greg Spencer f5a9835351
Check sample links for malformed links (#137807)
## Description

This checks API doc strings for malformed links to examples. It prevents errors in capitalization, spacing, number of asterisks, etc.  It won't catch all errors, because it needs to have a minimally indicative string to know that it even is trying to be a link to an example.  At a minimum, the line needs to look like (literally, not as a regexp) `///*seecode.*` in order to be seen as a link to an example.

Separately, I'm going to add a check to the snippets tool that checks to make sure that an `{@tool}` block includes either a link to a sample file or a dart code block.

## Tests
 - Added a test to make sure it catches some malformed links.
2023-11-06 18:46:18 +00:00
Ivan Inozemtsev defa4bce0a
Change cast in json parsing (#137708)
`jsonDecode` decodes lists as `List<Object?>`, so the cast to `List<Object>` fails at runtime in sound null safety mode.
2023-11-06 17:29:07 +00:00
auto-submit[bot] 3649deb3f6
Reverts "Update BottomNavigationBar tests for M3" (#137948)
Reverts flutter/flutter#136624
Initiated by: HansMuller
This change reverts the following previous change:
Original Description:
This PR updates `BottomNavigationBar` unit tests for M3 migration.

More info in https://github.com/flutter/flutter/issues/127064

It was somewhat complex because existing tests relied on a lot of magic numbers.
2023-11-06 16:43:19 +00:00
engine-flutter-autoroll 1d66b364d1
Roll Packages from cccf5d24d703 to 49eac1fec6c7 (2 revisions) (#137943)
cccf5d24d7...49eac1fec6

2023-11-03 katelovett@google.com [two_dimensional_scrollables] Add borderRadius support to TableSpanDecoration (flutter/packages#5184)
2023-11-03 47866232+chunhtai@users.noreply.github.com [go_router] Adds an ability to add a custom codec for serializing/des… (flutter/packages#5288)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-11-06 15:44:10 +00:00
Bruno Leroux 59d4d76705
Update BottomNavigationBar tests for M3 (#136624)
This PR updates `BottomNavigationBar` unit tests for M3 migration.

More info in https://github.com/flutter/flutter/issues/127064

It was somewhat complex because existing tests relied on a lot of magic numbers.
2023-11-06 15:15:07 +00:00
engine-flutter-autoroll 2e016b90f8
Roll Flutter Engine from 4f6ed31bd8bd to bdfa8aa8f81f (1 revision) (#137941)
4f6ed31bd8...bdfa8aa8f8

2023-11-06 skia-flutter-autoroll@skia.org Roll Dart SDK from 96664852accc to 9211fc6406bb (1 revision) (flutter/engine#47706)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-11-06 14:53:38 +00:00
engine-flutter-autoroll 377e40e8e0
Roll Flutter Engine from b9b3269b0b2c to 4f6ed31bd8bd (2 revisions) (#137935)
b9b3269b0b...4f6ed31bd8

2023-11-06 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from V3diHxFGlypUQKNH_... to HQfFSkurc6-jKM2jh... (flutter/engine#47705)
2023-11-06 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from kCyxKT7e5lMvkD3Yt... to _vGlgDiKOrtlKrZAP... (flutter/engine#47704)

Also rolling transitive DEPS:
  fuchsia/sdk/core/linux-amd64 from kCyxKT7e5lMv to _vGlgDiKOrtl
  fuchsia/sdk/core/mac-amd64 from V3diHxFGlypU to HQfFSkurc6-j

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-11-06 13:35:51 +00:00
Taha Tesser 826bb0a809
Provide a helpful error message when ColorScheme.brightness doesn't match ThemeData.brightness (#137611)
fixes [Unexpected behaviour with ColorScheme.fromSeed and Brightness.dark](https://github.com/flutter/flutter/issues/127523)
2023-11-06 13:34:10 +00:00
engine-flutter-autoroll aa3436db7a
Roll Flutter Engine from 555ffa17b55c to b9b3269b0b2c (1 revision) (#137933)
555ffa17b5...b9b3269b0b

2023-11-06 kustermann@google.com Fix FFI-based tonic layer to use proper C++ static_cast<>()s (flutter/engine#47644)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-11-06 11:25:18 +00:00
Andrew Kolos 12de94d152
Fix tool exit message shown when user provides a non-list to "assets" for a deferred component (#137837)
Fixes #136163
2023-11-06 04:01:25 +00:00
engine-flutter-autoroll aa82e222d3
Roll Flutter Engine from 0d8c7ceacc01 to 555ffa17b55c (1 revision) (#137921)
0d8c7ceacc...555ffa17b5

2023-11-05 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from IH6mGM_PvyJB5x7SM... to V3diHxFGlypUQKNH_... (flutter/engine#47696)

Also rolling transitive DEPS:
  fuchsia/sdk/core/mac-amd64 from IH6mGM_PvyJB to V3diHxFGlypU

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-11-06 00:59:32 +00:00
engine-flutter-autoroll 819b309a5b
Roll Flutter Engine from 11d66db97d3f to 0d8c7ceacc01 (1 revision) (#137920)
11d66db97d...0d8c7ceacc

2023-11-05 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from qGNZvKP4q2a4jm2Ce... to kCyxKT7e5lMvkD3Yt... (flutter/engine#47697)

Also rolling transitive DEPS:
  fuchsia/sdk/core/linux-amd64 from qGNZvKP4q2a4 to kCyxKT7e5lMv

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-11-06 00:21:23 +00:00
engine-flutter-autoroll 7eb01cde86
Roll Flutter Engine from a7592e42464c to 11d66db97d3f (1 revision) (#137914)
a7592e4246...11d66db97d

2023-11-05 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from 3dRrKiwZsFq8U8vSM... to qGNZvKP4q2a4jm2Ce... (flutter/engine#47694)

Also rolling transitive DEPS:
  fuchsia/sdk/core/linux-amd64 from 3dRrKiwZsFq8 to qGNZvKP4q2a4

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-11-05 12:33:30 +00:00
engine-flutter-autoroll 9a6be0b998
Roll Flutter Engine from 1c6bd97e2288 to a7592e42464c (1 revision) (#137912)
1c6bd97e22...a7592e4246

2023-11-05 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from sZ51VV1mNynI39WtT... to IH6mGM_PvyJB5x7SM... (flutter/engine#47693)

Also rolling transitive DEPS:
  fuchsia/sdk/core/mac-amd64 from sZ51VV1mNynI to IH6mGM_PvyJB

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-11-05 11:52:35 +00:00
engine-flutter-autoroll 55868ed2a9
Roll Flutter Engine from daf18fe46b72 to 1c6bd97e2288 (1 revision) (#137908)
daf18fe46b...1c6bd97e22

2023-11-05 skia-flutter-autoroll@skia.org Roll Dart SDK from b9ae53ac4663 to 96664852accc (1 revision) (flutter/engine#47692)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-11-05 06:28:23 +00:00
engine-flutter-autoroll 234024e506
Roll Flutter Engine from a45e679828e6 to daf18fe46b72 (1 revision) (#137904)
a45e679828...daf18fe46b

2023-11-04 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from SmJ_8HFjjm55T4ijL... to 3dRrKiwZsFq8U8vSM... (flutter/engine#47690)

Also rolling transitive DEPS:
  fuchsia/sdk/core/linux-amd64 from SmJ_8HFjjm55 to 3dRrKiwZsFq8

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-11-04 23:34:18 +00:00
engine-flutter-autoroll e074df0b04
Roll Flutter Engine from fb2a9c20141e to a45e679828e6 (1 revision) (#137903)
fb2a9c2014...a45e679828

2023-11-04 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from ftLug7WGUYrtgHyy6... to sZ51VV1mNynI39WtT... (flutter/engine#47689)

Also rolling transitive DEPS:
  fuchsia/sdk/core/mac-amd64 from ftLug7WGUYrt to sZ51VV1mNynI

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-11-04 22:59:28 +00:00
engine-flutter-autoroll dedbb399b2
Roll Flutter Engine from 576833873c15 to fb2a9c20141e (1 revision) (#137900)
576833873c...fb2a9c2014

2023-11-04 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Roll Dart SDK from b9ae53ac4663 to 96664852accc (1 revision)" (flutter/engine#47687)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-11-04 18:41:32 +00:00
engine-flutter-autoroll 5e3b3e2570
Roll Flutter Engine from 25f5e285f874 to 576833873c15 (1 revision) (#137898)
25f5e285f8...576833873c

2023-11-04 godofredoc@google.com Fix symbols upload (flutter/engine#47669)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-11-04 17:43:13 +00:00
engine-flutter-autoroll 9085183d4c
Roll Flutter Engine from 7282a5d94ab6 to 25f5e285f874 (2 revisions) (#137892)
7282a5d94a...25f5e285f8

2023-11-04 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from 8tJt8KJzTzbwwQlUE... to SmJ_8HFjjm55T4ijL... (flutter/engine#47682)
2023-11-04 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from 5GLArzquQ4eL56vdy... to ftLug7WGUYrtgHyy6... (flutter/engine#47681)

Also rolling transitive DEPS:
  fuchsia/sdk/core/linux-amd64 from 8tJt8KJzTzbw to SmJ_8HFjjm55
  fuchsia/sdk/core/mac-amd64 from 5GLArzquQ4eL to ftLug7WGUYrt

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-11-04 11:19:25 +00:00
engine-flutter-autoroll 46d4b11f46
Roll Flutter Engine from b66a87626300 to 7282a5d94ab6 (2 revisions) (#137887)
b66a876263...7282a5d94a

2023-11-04 skia-flutter-autoroll@skia.org Roll Dart SDK from b9ae53ac4663 to 96664852accc (1 revision) (flutter/engine#47679)
2023-11-04 skia-flutter-autoroll@skia.org Roll Dart SDK from c52fb4fe2d86 to b9ae53ac4663 (1 revision) (flutter/engine#47674)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-11-04 07:55:06 +00:00
Kostia Sokolovskyi e8d9d9bfd5
HeroController should dispatch creation and disposal events. (#137835) 2023-11-03 20:42:47 -07:00
engine-flutter-autoroll 0e7ed92988
Roll Flutter Engine from ec20731de6ff to b66a87626300 (1 revision) (#137877)
ec20731de6...b66a876263

2023-11-03 kustermann@google.com Fix incorrect C++ return value of PictureRecorder::endRecording() (flutter/engine#47645)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-11-04 00:04:15 +00:00
Alex Isaienko b5fb6652d6
InheritedElement.removeDependent() (#129210)
Call the `dependency.removeDependent(this)` instead of `dependency._dependents.remove(this)` inside the `Element.deactivate()`. This allows `InheritedElements` to know when they can release resources associated with a given dependent `Element`.

Fixes #129207
2023-11-03 23:27:21 +00:00
Michael Goderbauer 8a0f9118ea
Remove unused generic type from BottomSheet (#137791)
Fixes https://github.com/flutter/flutter/issues/137424.

The generic type argument was unused.
2023-11-03 22:25:37 +00:00
engine-flutter-autoroll 6f5ca8542c
Roll Flutter Engine from 035740c1f90e to ec20731de6ff (2 revisions) (#137872)
035740c1f9...ec20731de6

2023-11-03 skia-flutter-autoroll@skia.org Roll Dart SDK from 529fcd5bdffc to c52fb4fe2d86 (1 revision) (flutter/engine#47668)
2023-11-03 jacksongardner@google.com Bundle flutter.js via esbuild (flutter/engine#47573)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-11-03 22:24:02 +00:00
Daco Harkes 7634609062
Pin dart-lang/native dependencies (#137601)
Pin the dependencies from dart-lang/native to a specific version during testing (rather than having them auto-upgrade during pub resolution). This will prevent tests using the template to start failing if a bad version is published to pub.

Closes: https://github.com/flutter/flutter/issues/137418

Also bumps dep in flutter_tools.
2023-11-03 22:16:04 +00:00
Chris Bracken 4455e86d90
Send caret rect to embedder on selection update (#137863)
Background: In the framework, the position of the caret rect is updated on each cursor position change such that if the user initiates composing input, the current cursor position can be used for the first character until the composing rect can be sent.

Previously, no update was sent on selection changes, on the assumption that the most recent cursor position will remain the correct position for the duration of the selection. While this is the case for forward selections, it is an incorrect assumption for reversed selections, where selection.base > selection.extent.

We now update the cursor position during selection changes such that the cursor position sent to the embedder is always the position at which next text input would occur. This is the start position of the selection or min(selection.baseOffset, selection.extentOffset).

Issue: https://github.com/flutter/flutter/issues/137677
2023-11-03 22:09:09 +00:00
engine-flutter-autoroll 71db445c37
Roll Flutter Engine from 677040f10f65 to 035740c1f90e (4 revisions) (#137871)
677040f10f...035740c1f9

2023-11-03 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from ho9FqsUD0hxh0b8to... to 8tJt8KJzTzbwwQlUE... (flutter/engine#47666)
2023-11-03 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from y-hqwYkPPVT6RwmAS... to 5GLArzquQ4eL56vdy... (flutter/engine#47667)
2023-11-03 skia-flutter-autoroll@skia.org Roll Skia from c0ca9f2fd828 to 77aeee3b81a5 (1 revision) (flutter/engine#47663)
2023-11-03 flar@google.com [Impeller] Remove Rect field accesses from aiks subdirectory (flutter/engine#47628)

Also rolling transitive DEPS:
  fuchsia/sdk/core/linux-amd64 from ho9FqsUD0hxh to 8tJt8KJzTzbw
  fuchsia/sdk/core/mac-amd64 from y-hqwYkPPVT6 to 5GLArzquQ4eL

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-11-03 21:37:58 +00:00
Chris Bobbe e7f99821cc
Tooltip docs: Recommend setting preferBelow to false in theme (#135879)
As discussed at https://github.com/flutter/flutter/pull/133007#issuecomment-1743916183, this is a docs change meant to help people in the absence of a fix for #133006, which is being closed as WONTFIX.
2023-11-03 20:18:36 +00:00